From patchwork Wed Oct 16 15:01:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuicheng Lin X-Patchwork-Id: 13838603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D0B5D2A529 for ; Wed, 16 Oct 2024 15:37:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0521E10E73A; Wed, 16 Oct 2024 15:37:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="NcQmecyT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDF7610E73A; Wed, 16 Oct 2024 15:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729093047; x=1760629047; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=lL4//Oqzwbvxk/txT4MlT2rCJlZ9T5IyzMsGW/YAPLw=; b=NcQmecyTjMzcFg1ghX0ofz2hTWVHqlEOASN1Gtk4IwXXFPGgyXvABm55 Zm18dHMGDuN9Tf9IPMPC4ixuhk/8NjyBF3HNrY1aILEzT7q0jnw9RoCIv ud9UETljVvxfhDsIPq9nv/f+bDwfnOz2lPkQkbX8KY01DuYjSYy2f0omk sia4XTz7E8nTCGWIN4sFn2FJ04vlxax1qm9cyrxXesIDXaW8EzPwYwMQ4 flvAJmoCfeVecxvOb34+8PZn9yLsDXtzv/R2pi/veKhJ5qB8zUDcRSuja JEyzSwH7utZwlT06ygXnxAswph9zJzVaG1F3KIqBJA8DQkRq4iP8RPUt2 g==; X-CSE-ConnectionGUID: wL0QQ8uPQyCK53G2GNTTJw== X-CSE-MsgGUID: KVVv5ZXVTR2hMtvtobPDDw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="28435151" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="28435151" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2024 08:37:27 -0700 X-CSE-ConnectionGUID: CdBb9hdqTv6CFM16Tz2/vw== X-CSE-MsgGUID: vWKv6rOqRKK7USSQQP/L7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,208,1725346800"; d="scan'208";a="78710501" Received: from osgc-linux-buildserver.sh.intel.com ([10.112.232.61]) by orviesa007.jf.intel.com with ESMTP; 16 Oct 2024 08:37:27 -0700 From: Shuicheng Lin To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Shuicheng Lin , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi Subject: [PATCH v2] drm/i915/dp: Fix memory leak in parse_lfp_panel_dtd() Date: Wed, 16 Oct 2024 15:01:54 +0000 Message-Id: <20241016150154.1466131-1-shuicheng.lin@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The function parse_lfp_panel_dtd() is called when the driver attempts to initialize the eDP connector, and it allocates memory, which is recorded in panel->vbt.lfp_vbt_mode. However, since no eDP panel is connected, the driver fails at intel_edp_init_dpcd() and follows the failure path. Unfortunately, the allocated memory is not freed in this case. To fix this issue, free the memory in the failure path. leak info from kmemleak: " unreferenced object 0xffff8881252f8800 (size 128): comm "systemd-udevd", pid 192, jiffies 4294896880 hex dump (first 32 bytes): e8 fd 00 00 00 04 18 04 a0 04 40 05 00 00 00 03 ..........@..... 03 03 09 03 26 03 00 00 0a 00 00 00 00 00 00 00 ....&........... backtrace (crc 7448f6b4): [] kmemleak_alloc+0x4b/0x80 [] __kmalloc_cache_noprof+0x2be/0x390 [] intel_bios_init_panel+0x1c4c/0x2720 [xe] [] intel_bios_init_panel_early+0x13/0x20 [xe] [] intel_dp_init_connector+0x2f9/0x1080 [xe] [] intel_ddi_init+0xbba/0xf50 [xe] [] intel_bios_for_each_encoder+0x36/0x60 [xe] [] intel_setup_outputs+0x206/0x450 [xe] [] intel_display_driver_probe_nogem+0x163/0x1f0 [xe] [] xe_display_init_noaccel+0x27/0x70 [xe] [] xe_device_probe+0x806/0x9a0 [xe] [] xe_pci_probe+0x31f/0x590 [xe] [] local_pci_probe+0x48/0xb0 [] pci_device_probe+0xc8/0x280 [] really_probe+0xf8/0x390 [] __driver_probe_device+0x8a/0x170 " v2 (Jani): -use intel_bios_fini_panel() to pair with intel_bios_init_panel_early() Signed-off-by: Shuicheng Lin Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/display/intel_dp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 90fa73575feb..7141e3ca0d83 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -6801,6 +6801,7 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, out_vdd_off: intel_pps_vdd_off_sync(intel_dp); + intel_bios_fini_panel(&intel_connector->panel); return false; }