From patchwork Thu Oct 17 08:55:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wadim Egorov X-Patchwork-Id: 13839636 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6E80D21260 for ; Thu, 17 Oct 2024 08:56:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D7B010E303; Thu, 17 Oct 2024 08:56:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=phytec.de header.i=@phytec.de header.b="Foxwse/q"; dkim-atps=neutral Received: from mickerik.phytec.de (mickerik.phytec.de [91.26.50.163]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2148110E300 for ; Thu, 17 Oct 2024 08:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; d=phytec.de; s=a4; c=relaxed/simple; q=dns/txt; i=@phytec.de; t=1729155405; x=1731747405; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7FTIXUBTbKyS5duZobcY1RpkOFb9rEz3FlKeAXNHRxY=; b=Foxwse/qk5NDWw7eoxIPZhU6F8SJd353ef2SOtmD+vAZKuwHDZmmf1ZF52V3MfcG GLj0pUCy3YxfxH+vQ8PBVH0/g3jTRwM5MSIbyrUl6zfkrRGMB2R8k0+0MfydTJEq T4R1RYNFNK9bjosWldgStweGNUmy4q8E+A4ApJ1UzZY=; X-AuditID: ac14000a-ecaea24000004e2a-87-6710d14d63d7 Received: from berlix.phytec.de (Unknown_Domain [172.25.0.12]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mickerik.phytec.de (PHYTEC Mail Gateway) with SMTP id 31.81.20010.D41D0176; Thu, 17 Oct 2024 10:56:45 +0200 (CEST) Received: from augenblix2.phytec.de (172.25.0.11) by Berlix.phytec.de (172.25.0.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Thu, 17 Oct 2024 10:56:44 +0200 From: Wadim Egorov To: , , CC: , , , , , , , , , , , , , , , Subject: [PATCH v3 1/2] dt-bindings: display: bridge: sil, sii9022: Add bus-width Date: Thu, 17 Oct 2024 10:55:55 +0200 Message-ID: <20241017085556.3045686-2-w.egorov@phytec.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241017085556.3045686-1-w.egorov@phytec.de> References: <20241017085556.3045686-1-w.egorov@phytec.de> MIME-Version: 1.0 X-Originating-IP: [172.25.0.11] X-ClientProxiedBy: Florix.phytec.de (172.25.0.13) To Berlix.phytec.de (172.25.0.12) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsWyRpKBR9f3okC6QctyVosT1xcxWdxf/JnF YnXLdEaLNXvPMVnMP3KO1eLK1/dsFs/nr2O0OPnmKovFy1n32Cw6Jy5ht7i8aw6bxcKPW1ks 2jqXsVq833mL0WLSvJusFv/37GC3mP1uP7vFljcTWS2636k7CHvs/baAxWPnrLvsHrM7ZrJ6 LN7zkslj06pONo8TEy4xedy5tofNY97JQI/73ceZPPq7W1g9Np+u9vi8SS6AJ4rLJiU1J7Ms tUjfLoEr49Gvg4wFm3kqDq/ZzdrAuJGzi5GTQ0LAROLrxd/MXYxcHEICS5gk5v18wArhPGaU eHGtiRGkik1AXeLOhm+sILaIgJ/ErS/72EGKmAU2MUt8fr0bLCEsECBx7tVboFEcHCwCqhL7 vkeBmLwClhLTLwRBLJOXmHnpOzuIzSlgJfHp31VmEFsIqGTDj+NsIDavgKDEyZlPWEBsZqD6 5q2zmSFsCYmDL15A1ctLvLi0nAVm5rRzr5kh7FCJI5tWM01gFJqFZNQsJKNmIRm1gJF5FaNQ bmZydmpRZrZeQUZlSWqyXkrqJkZQHIswcO1g7JvjcYiRiYPxEKMEB7OSCO+kLt50Id6UxMqq 1KL8+KLSnNTiQ4zSHCxK4ryrO4JThQTSE0tSs1NTC1KLYLJMHJxSDYxNfMr75U8vOhy49LK/ tku70D6/7/mOfKdsNu0KUTwrqNaQ+F275/jbPu43SsZN9V9+LXhX3WX8Ycm0qFONin53vh64 fyGz7JRwg+ap5Y13Lmet8RGzCfj1IkdYmNPA4kHAOv0/p3d+DAlkVV5T63PKr+hC80r9/WGT H2vqzpqxQjrxUPLuNwuUWIozEg21mIuKEwFC3R1V0QIAAA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The SI9022 HDMI transmitter can be configured with a bus-width of 16, 18, or 24 bits. Introduce a bus-width property to the input endpoint, specifying the number of parallel RGB input bits connected to the transmitter. Signed-off-by: Wadim Egorov Reviewed-by: Krzysztof Kozlowski --- v3: Add Reviewed-by tag from Krzysztof --- .../bindings/display/bridge/sil,sii9022.yaml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml index 5a69547ad3d7..1509c4535e53 100644 --- a/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml @@ -81,9 +81,22 @@ properties: properties: port@0: - $ref: /schemas/graph.yaml#/properties/port + unevaluatedProperties: false + $ref: /schemas/graph.yaml#/$defs/port-base description: Parallel RGB input port + properties: + endpoint: + $ref: /schemas/graph.yaml#/$defs/endpoint-base + unevaluatedProperties: false + + properties: + bus-width: + description: + Endpoint bus width. + enum: [ 16, 18, 24 ] + default: 24 + port@1: $ref: /schemas/graph.yaml#/properties/port description: HDMI output port From patchwork Thu Oct 17 08:55:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wadim Egorov X-Patchwork-Id: 13839638 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86D1ED21260 for ; Thu, 17 Oct 2024 08:56:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2B9D10E309; Thu, 17 Oct 2024 08:56:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=phytec.de header.i=@phytec.de header.b="PB0BbswE"; dkim-atps=neutral Received: from mickerik.phytec.de (mickerik.phytec.de [91.26.50.163]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1714210E300 for ; Thu, 17 Oct 2024 08:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; d=phytec.de; s=a4; c=relaxed/simple; q=dns/txt; i=@phytec.de; t=1729155405; x=1731747405; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QEnmiH9jI1YFjLImlKAlfNH1g1OGXrwhTMgTXW6e2aE=; b=PB0BbswEzE50qq2Ip5IBt7zzOswNSiFq7UeePUFRd7j5rBccYn0Ssv4sk179ai+S BZf5cG06vUK6qK3WP8nDF7lePEq/PhYuaNu7xlvmhCfVNeG0epmTCbvy/Du77g/H x0oEDaRxJ5eePt9HepcYO5Rr7sU3Bmogj7jakcu7ais=; X-AuditID: ac14000a-4637f70000004e2a-88-6710d14d6797 Received: from berlix.phytec.de (Unknown_Domain [172.25.0.12]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mickerik.phytec.de (PHYTEC Mail Gateway) with SMTP id A3.81.20010.D41D0176; Thu, 17 Oct 2024 10:56:45 +0200 (CEST) Received: from augenblix2.phytec.de (172.25.0.11) by Berlix.phytec.de (172.25.0.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Thu, 17 Oct 2024 10:56:45 +0200 From: Wadim Egorov To: , , CC: , , , , , , , , , , , , , , , Subject: [PATCH v3 2/2] drm/bridge: sii902x: Set input bus format based on bus-width Date: Thu, 17 Oct 2024 10:55:56 +0200 Message-ID: <20241017085556.3045686-3-w.egorov@phytec.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241017085556.3045686-1-w.egorov@phytec.de> References: <20241017085556.3045686-1-w.egorov@phytec.de> MIME-Version: 1.0 X-Originating-IP: [172.25.0.11] X-ClientProxiedBy: Florix.phytec.de (172.25.0.13) To Berlix.phytec.de (172.25.0.12) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsWyRpKBR9f3okC6QdNZPosT1xcxWdxf/JnF YnXLdEaLNXvPMVnMP3KO1eLK1/dsFs/nr2O0OPnmKovFy1n32Cw6Jy5ht7i8aw6bxcKPW1ks 2jqXsVq833mL0WLSvJusFv/37GC3mP1uP7vFljcTWS2636k7CHvs/baAxWPnrLvsHrM7ZrJ6 LN7zkslj06pONo8TEy4xedy5tofNY97JQI/73ceZPPq7W1g9Np+u9vi8SS6AJ4rLJiU1J7Ms tUjfLoEro79/N1PBScGK45+/sDYwbuXrYuTkkBAwkXjz/zdrFyMXh5DAEiaJvkM/GCGcx4wS uy48ZwGpYhNQl7iz4RsriC0i4Cdx68s+dpAiZoFNzBKfX+8GSwgLhEj8bd/BBmKzCKhKbLkz EyjOwcErYCnx6FgdxDZ5iZmXvrOD2JwCVhKf/l1lBrGFgEo2/DgO1sorIChxcuYTsL3MQPXN W2czQ9gSEgdfvICql5d4cWk5C8zMaedeM0PYoRJHNq1mmsAoNAvJqFlIRs1CMmoBI/MqRqHc zOTs1KLMbL2CjMqS1GS9lNRNjKBIFmHg2sHYN8fjECMTB+MhRgkOZiUR3kldvOlCvCmJlVWp RfnxRaU5qcWHGKU5WJTEeVd3BKcKCaQnlqRmp6YWpBbBZJk4OKUaGFNDp7E43XFM8jqXyb5h 2+L0YI7jOovWeh4MeXu8tFfW/q8IS2X1vunRxmIHGVRUlJ6tn+WzOjbHspTvjfoU5RUZZpwm av08B2fyVqxaeyno57tivTuqKXduvzCYmlTLGaH9Z86xP2mHFTi3nFQOf2O87rmjHOOSAw8f ct0u4D8h5LL3qlBNmRJLcUaioRZzUXEiAG4BDDzSAgAA X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Introduce a bus-width property to define the number of parallel RGB input pins connected to the transmitter. The input bus formats are updated accordingly. If the property is not specified, default to 24-bit bus-width. Signed-off-by: Wadim Egorov --- v3: Ensure bus_width is set/defaults to 24 even if an endpoint is not defined --- drivers/gpu/drm/bridge/sii902x.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 7f91b0db161e..9be9cc5b9025 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bridge/sii902x.c @@ -180,6 +180,8 @@ struct sii902x { struct gpio_desc *reset_gpio; struct i2c_mux_core *i2cmux; bool sink_is_hdmi; + u32 bus_width; + /* * Mutex protects audio and video functions from interfering * each other, by keeping their i2c command sequences atomic. @@ -477,6 +479,8 @@ static u32 *sii902x_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, u32 output_fmt, unsigned int *num_input_fmts) { + + struct sii902x *sii902x = bridge_to_sii902x(bridge); u32 *input_fmts; *num_input_fmts = 0; @@ -485,7 +489,20 @@ static u32 *sii902x_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, if (!input_fmts) return NULL; - input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24; + switch (sii902x->bus_width) { + case 16: + input_fmts[0] = MEDIA_BUS_FMT_RGB565_1X16; + break; + case 18: + input_fmts[0] = MEDIA_BUS_FMT_RGB666_1X18; + break; + case 24: + input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24; + break; + default: + return NULL; + } + *num_input_fmts = 1; return input_fmts; @@ -1167,6 +1184,11 @@ static int sii902x_probe(struct i2c_client *client) return PTR_ERR(sii902x->reset_gpio); } + sii902x->bus_width = 24; + endpoint = of_graph_get_endpoint_by_regs(dev->of_node, 0, -1); + if (endpoint) + of_property_read_u32(endpoint, "bus-width", &sii902x->bus_width); + endpoint = of_graph_get_endpoint_by_regs(dev->of_node, 1, -1); if (endpoint) { struct device_node *remote = of_graph_get_remote_port_parent(endpoint);