From patchwork Fri Oct 18 10:00:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13841488 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43D6F20100A; Fri, 18 Oct 2024 09:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245158; cv=fail; b=fJIqEKHwbtPpgHGS077KO9AU6HDe6WQ5Gl/bD9cNTA6+WYD9Yh/PFrseqMbOB42/2zxuhmqf1zKtwhanAF8gP97hrXWs3jmqsGLTdON24NxVDxgeHms/t6In7m4hKy6a7elmrXDT+pmPy4SuyqWs40+TrNvKecs5pGRYmRn4Shw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245158; c=relaxed/simple; bh=WYkMqcmzSQqssu3iTqvUC9FUZ6QanVNIu6veJiyDpHk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=sBp2CBsQ3Mb2Gp3bJZLXwdyQj6XoCQKQsiexNhq9xandUV/19xAiheBF5RGP3jr53AnKn0o2gQjjEIDSmbErnCWUQAdEI7/a4B/spj4CCHkFUn8Npv4xoan/Fgv3/mTVNUFo5iPiiZap01OaFEBuGWduHtElGZ1YE7Yoc0fimNs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=thqzPscw; arc=fail smtp.client-ip=40.107.21.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="thqzPscw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=io5TKuDedAetOXwvKm0oAH/oLTSa5acKAqGG4RRyGRJDnL0d0SIa78IVN+mtB+T1DWWm9ZTVJHltWaYfGX0jBK2v7Yp3oVoXcBFnSvewUsg9+3KcaGy0nPVNjb873bWk4iiThw5V6gyxVfgTggLV52uwUtFwFkmrlUH3Hsxu/KpFNE8aVtIazfpwNDHM67GEW8V2YeTZJhKETZe41413WphexNANor6PNzwQIe2Ij3PlehlchPyiHWkRSsY6jCUih6UMchQqkrjBvFgn+5PHMzrzGsAT7QbGZnjPS1tLWWg+53TNBRo439+TGZoAWdpg3S0z62S1u8HbVtaecy57XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n45sX0jlW0hUXc+CXKLrG3U7xIQumx5jCDpKYVho75s=; b=reZI6rubg7cBePb7xzp7TEn7/qjDhZKlDHKnW6e3Bjp2DM5GRnB6LWjCFLDlELLN8fJjO2jpJNzqsqRB0uk/JzC+gzeQsNk1z7hlb6IjAiWKyjTh5J6aWf8vg8I6AswTc0NZmJCNyQaRz0zpylPHMGubkILUakddYNjrN0XCR1u06BTaVi4cL/7WKRh5MLTPjPUre6MEVRa5Kdm0GEwgKDPzHVwQagW9Nej7ibVmn7Kt0cSm/d3urDzmvW2PRkmHqPv+PBooHY1EVI9VQTawv4PF3OGOrymOQd3xqNWHAhYlIpqjHFAArF3pigfr9sm1EVW42tkkN7i5wFTqV+BIXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n45sX0jlW0hUXc+CXKLrG3U7xIQumx5jCDpKYVho75s=; b=thqzPscwV1B4Fh3hW7IfSIlgO+Z4WF2uOJxX+kK5B2AcFQTnWP1QKMk0IM6RZXGP+eU6vNaNaz6csJmYBjvuorHRwVrKnOPGWPCc/LM1x7M844R+hQ30GMyCq+/yXq6RNUBxt+jNY4OuvtMZ0tzXCsSkTEw7F43yF5TtKl9sdyjS6lD/QcZ8EDQCWMb/McISQKc9fhiYFYphDrsAaqEHTZHT5zXrew+MQ2AzwBkn9uy+4ItzVvnj0lO5X9zfIb8P2AHjSdonkEMQeY+wV82CJKhkgymV/Nuf7O51F8F00kR80C1On0xBrauj05ajS5QWjH5a9A/W1CSXbWCSPXTPMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.20; Fri, 18 Oct 2024 09:52:32 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%6]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 09:52:32 +0000 From: "Peng Fan (OSS)" Date: Fri, 18 Oct 2024 18:00:55 +0800 Subject: [PATCH v2 1/4] clk: imx: lpcg-scu: SW workaround for errata (e10858) Message-Id: <20241018-imx-clk-v1-v2-1-92c0b66ca970@nxp.com> References: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> In-Reply-To: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Aisheng Dong Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1729245675; l=3168; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=5lV6Fnymwi08mNJOqfNiqBqacUaEGvCOefJyeSXwdDg=; b=zldSwAASvzZPp+4QoKIdmyOjLYUE2CgIaCB5H/e+itCHrvZX2WNvv45/rbzX3una65nJkJhP7 SxJMK9swp/RDf3AB1+IxJRCpmiDz0ARmD8gDN1bRNKXlEpkflEubfU7 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0028.apcprd01.prod.exchangelabs.com (2603:1096:4:192::21) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DBAPR04MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: d05c2861-10d0-4168-dd45-08dcef5a961c X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?s6tBmlZAmZ/gjZd3rXEGdZkm/3qPh53?= =?utf-8?q?66M3Qboh346j/1dNlcA8tOQfj0HrUrs6PxMBXjpaddkB6T+3a5Y7gZefIyrVW34bV?= =?utf-8?q?q9oQ77qL17IzmZoc88kvSZi03i8lyOgjoAm67lRIksMZD2wDTgnq9y2t4+zERz3RN?= =?utf-8?q?M9oVhfyud3lU0V/qUQjY5MznGCzzIIFVkH05tDTm75ehleohLWroUpboXaExQ/QZJ?= =?utf-8?q?TG+KOfwmpm80cQ6MgBZ7PrdFke811PmSdXGkbXT9Q1CQY6E+9ruy1D/32O7r7RiRg?= =?utf-8?q?4JnGw/FEXiOUZGUcAkCB0OIqC/5m5X8G3oOky87dIUAPl36K8rvD6zpWIvCCuyf6B?= =?utf-8?q?UBBzJzoCX/ClFQiGOBV7EMqe/OnFqU0P6x/ZRDvaJAe2JoVqvqgj0ENvC9Tin8ooE?= =?utf-8?q?paIgRxj7M6pMPf2yyDoF0aOHADqmN1resb9xbjWRfUnRc4MgOQ6uB3IiBdE1RxewS?= =?utf-8?q?FfTZwM7LGRsZhJ9k0GFkFDyzr0qM0I6nr5jJ4RIY1gWicb7YZ9Q5fSMvGxA+ol8MC?= =?utf-8?q?wdNOqE+jI7b0TEUmX+W7rvq9IRjTkiZlIkC3G7Dyk/FkDmcaq4tzyEKPGfLl3QqwX?= =?utf-8?q?Rs94+eNqK3Eb3ECBrD6+woRlFKcqIWuEOpIAD6MOrW20CygiaYyx1gD6HNeCNMOEF?= =?utf-8?q?8gbKP0Z92MXm23hQgTVqpw3zmJ8+1tmtj6z1emn5e18RxawFT9+LJTPsinKSuAgZr?= =?utf-8?q?o9LS20benw4ySBH9irvhCcJDE1DdVgklyip9rJ9tG8h/C2DyF8Kx0/DdKzj7Dcfb5?= =?utf-8?q?yL+rTc5/3vY2BsMutlFb+m2fS9aNTTiSdfKrGAO2F+JYpIvUFXaR9QJjCLcNB32iK?= =?utf-8?q?ZoAImEQAAw9eWjhwGshI6X/cd+6Oab6wDPVfGPfRsgw5BKkj2JW/1Sz6EM6uRbpwz?= =?utf-8?q?bV5l9sEeNTGC3btllf8IXgQ0z1t9Hh0rrKKY67drKNtAIIFtHWQSUaW0obGX2Dykf?= =?utf-8?q?stW3UffFu4wWJJWRLFAPdkpzMajqWjRLngt1Lv3LlZFS+qmWasfIFRUTk50QMx5S5?= =?utf-8?q?4z4SJQys7fsCUYnaSXqr89AtOCM5StZws/RUmeX+cQ48gWsRPi1CsfYXtRJn2+gl0?= =?utf-8?q?wv0AWKGaJlr4q5XPanvIzfX4bYu1ffFw2TKKcC38qP2LF8PwaI6r7K7f5ZsxwS+SE?= =?utf-8?q?FxoRrFRcfYEUDjy5X7fzjTS3uxrWFgSWwKgffQwDwtMbPSgq4SGBkB59nrieQJ/74?= =?utf-8?q?26sdTThL2im7AtyNO9CRe1kLBaH4BpUFp0N5tsAfnisJ4hX7suCcg4+nuGHfi4jv/?= =?utf-8?q?eoGkZxt7v2rN7?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Ttbf1zsYoOOlcz0+FhG0HIiD5dCT?= =?utf-8?q?vmLwX2AaY84KvMn3PjP0GY6LHwixLmScsi6VwwXKAqn8/fhH54e4eT0VSujytk/mi?= =?utf-8?q?z/pscJMGjQOduF3X9dI7HGlSSeZmoL+830pLJ2EAT6/OJ05UnxfrMpftZB3PREHHP?= =?utf-8?q?mB6SkkM6kZKZLgYGTcqmZGYCsTyUn74G7JCAceiJY/V4t0/PlkxznhE8pjSZcePoF?= =?utf-8?q?dXyncWJRb4QjWkmvIB+x11TdQ9u5FxGfXTUDHs7lxjxkE/YihTPGRgbi07ZR5hp02?= =?utf-8?q?jCKRrBd+z/phwZShW91qT23w5dNJYnOP02yhpwY6dLwr/QOhGFeHwjSTD4gNgtXO5?= =?utf-8?q?OcccJcMDAz00aDTFqPmPKx+kTCRgHTVLgNuNMMEB8QEsY1aNNxleHjj20CwVYTdlS?= =?utf-8?q?95y89c8JG0BHAppv4yg1Y96FtM84HM0He+ceokDOvQzX3vAp3YuwBW9bfRQUGfAQ1?= =?utf-8?q?vupc/MFCgr5+NOsTjh1hTsQdM3Akvg82zySiCw0SQwscFIv/l4dR4ZVH0XF/hfz1Z?= =?utf-8?q?nW620P7NyTuNPVb4PmJiNux75bmhZiCJzhCt2FyKLS/KoKh03sggH79hrQ1hU5YBl?= =?utf-8?q?A6UQ+qgmMExuJ0BjxRhcK6ZbIAMjqtRSnFtRIiMVTC3YPGZCJ1wVOUlQrO/ZvqbwZ?= =?utf-8?q?bSUvs9CIZkrIY8CGQlo5qnCP8EiY4XUZb+9XSgL5orn9G85OQYrpAl9jjnrY+Q16l?= =?utf-8?q?OIZtQaFg7OjqHLnOA0aVzKru+LgWAXc2DHUUvavZnwNEypOS4wHe1aCvSQpbvjEPT?= =?utf-8?q?ltAIhyNbSQlGi4zhOsyX/7uacSHrsi+DUxKdWtXmkUOLhbW7nYw18QfWdA/5tnHK9?= =?utf-8?q?5lbBQBffMUWr8EETBy5LQAT7uJ1KSbLtHDZ6WCFEiYM84y8I5xUgQabg+I5EjNrdh?= =?utf-8?q?sZQksV8R0XXRYtnFR8kZKKfdMZXKZKXHWrjXY2XQZm44a9hSGnKOSwjes7DQqGeZC?= =?utf-8?q?ew+v9fiY88UeNbVUf4kD4tQPhUUd+PFSAx9gBx4h0VJBe4RBJRSiqyQOBmk2XAeuh?= =?utf-8?q?yq8I/KCgyKRpjEjCHgK3pyYWZlYHbzSAWzggfFDjKglbh5erO9y6ta0iozOZpwQos?= =?utf-8?q?SZxKUF0a1TDskvNziyplxGorcuZoN3vbw7nbSQcnpCp+QohHiS5QsGT7KHOnOhdvO?= =?utf-8?q?Rfgs0Bf5k1yaIqFLR7yZVwmGgcd6vkTQaSOIUghoaci3BTiiPnNX2Qu3C22eQOEHG?= =?utf-8?q?nQ1g9XHbXphriqfYyqqayVBLcCqRR0Q/os5vTBmeCr+r/gVX4+2H8d9RSgnjfNg2c?= =?utf-8?q?r1SypEVLM0pvHaW8Vs8RTc+UUzh6muQbB0a0vKz37DuutfQdLRXUrjzQb8VLl5Gbu?= =?utf-8?q?TfYP5AHXEVfVgq1PFUTouRw6WEaCednrQeyBQ85oP9GHkMhb4MwGkF911oFNlzH4M?= =?utf-8?q?04IxMM2YGvjYyia7HjdN5bA3FiZ+tuxxWygLvm+YZ6EsJNo0b7BgNcYiYero2ez8z?= =?utf-8?q?D5M6fQaPvcXHsvsJtkM9kcOaH1v/uIA1ZY8q4Gqtnwkr+zzWeqJ/blAlM3yadEztJ?= =?utf-8?q?Qcz9TfCIh7ak?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d05c2861-10d0-4168-dd45-08dcef5a961c X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 09:52:32.5843 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BlJNxB6c06PDt+XxCWxMk4Bni+t3v45/nI+hxnTJdrus3UNqvfrwDcz4hEAloQ0a5UfY8IEx0MSc0Sb+sWYVcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285 From: Peng Fan Back-to-back LPCG writes can be ignored by the LPCG register due to a HW bug. The writes need to be separated by at least 4 cycles of the gated clock. See https://www.nxp.com.cn/docs/en/errata/IMX8_1N94W.pdf The workaround is implemented as follows: 1. For clocks running greater than or equal to 24MHz, a read followed by the write will provide sufficient delay. 2. For clocks running below 24MHz, add a delay of 4 clock cylces after the write to the LPCG register. Fixes: 2f77296d3df9 ("clk: imx: add lpcg clock support") Signed-off-by: Peng Fan --- drivers/clk/imx/clk-lpcg-scu.c | 35 +++++++++++++++++++++++++++++++---- 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-lpcg-scu.c b/drivers/clk/imx/clk-lpcg-scu.c index dd5abd09f3e206a5073767561b517d5b3320b28c..cd42190233662c66f2c354f0a2eee3a2531eeb3a 100644 --- a/drivers/clk/imx/clk-lpcg-scu.c +++ b/drivers/clk/imx/clk-lpcg-scu.c @@ -6,10 +6,12 @@ #include #include +#include #include #include #include #include +#include #include "clk-scu.h" @@ -41,6 +43,31 @@ struct clk_lpcg_scu { #define to_clk_lpcg_scu(_hw) container_of(_hw, struct clk_lpcg_scu, hw) +/* e10858 -LPCG clock gating register synchronization errata */ +static void lpcg_e10858_writel(unsigned long rate, void __iomem *reg, u32 val) +{ + u32 reg1; + + writel(val, reg); + + if (rate >= 24 * HZ_PER_MHZ || rate == 0) { + /* + * The time taken to access the LPCG registers from the AP core + * through the interconnect is longer than the minimum delay + * of 4 clock cycles required by the errata. + * Adding a readl will provide sufficient delay to prevent + * back-to-back writes. + */ + reg1 = readl(reg); + } else { + /* + * For clocks running below 24MHz, wait a minimum of + * 4 clock cycles. + */ + ndelay(4 * (DIV_ROUND_UP(1000 * HZ_PER_MHZ, rate))); + } +} + static int clk_lpcg_scu_enable(struct clk_hw *hw) { struct clk_lpcg_scu *clk = to_clk_lpcg_scu(hw); @@ -57,7 +84,8 @@ static int clk_lpcg_scu_enable(struct clk_hw *hw) val |= CLK_GATE_SCU_LPCG_HW_SEL; reg |= val << clk->bit_idx; - writel(reg, clk->reg); + + lpcg_e10858_writel(clk_hw_get_rate(hw), clk->reg, reg); spin_unlock_irqrestore(&imx_lpcg_scu_lock, flags); @@ -74,7 +102,7 @@ static void clk_lpcg_scu_disable(struct clk_hw *hw) reg = readl_relaxed(clk->reg); reg &= ~(CLK_GATE_SCU_LPCG_MASK << clk->bit_idx); - writel(reg, clk->reg); + lpcg_e10858_writel(clk_hw_get_rate(hw), clk->reg, reg); spin_unlock_irqrestore(&imx_lpcg_scu_lock, flags); } @@ -149,9 +177,8 @@ static int __maybe_unused imx_clk_lpcg_scu_resume(struct device *dev) * FIXME: Sometimes writes don't work unless the CPU issues * them twice */ - - writel(clk->state, clk->reg); writel(clk->state, clk->reg); + lpcg_e10858_writel(0, clk->reg, clk->state); dev_dbg(dev, "restore lpcg state 0x%x\n", clk->state); return 0; From patchwork Fri Oct 18 10:00:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13841489 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2066.outbound.protection.outlook.com [40.107.247.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34394201032; Fri, 18 Oct 2024 09:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245162; cv=fail; b=J28sT5O1FcU5pTC41uqgXz7VHtb5qAuyUDQxtypOLKWhnqAusEeb8JS52iLJuNEU+sTX02J5tW+QEx+I8qzDYXgMGchvTDwTX3yX6MCCOZZJvVcCWrAMXGjI8El1L3T5jL6kEaM98LGAzmoZbTG0T9GCs4oa6dZR9sQ29Kfx0pk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245162; c=relaxed/simple; bh=N/iy+g4d4ZrluabxI3N13/2R+2wZz+/hS82POc1WCr0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=T1qVJJ7NW82vlrwJ7RZGQ+gMBJf91dTg2KVGiRX9mgctPACpSJ8mCzq2FCeAxHrMkMwHugJ5OBzZo/jEXdABcgRmqt/knxMEROzAbZscGNUTHETPoK3GLBTptZNW2T4xQrHkYppCEcG41/LW5LSiAxkcoWwhiSULAlifCBBzjWo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=I5zGDf0S; arc=fail smtp.client-ip=40.107.247.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="I5zGDf0S" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aji57qC18OPKTDm/i+gGteyLpB0eoYNqi0YPKeM/7kl3rVzheCW5SLbX8FnhfpLhfwukYfZ2AABTRyL5OJcpqmitwzI0+8n7VPUL9cBW+qh1K+XxnOY9oApXfaTEurQBJ4hG523aShclXKdBLU/VNU7s28BtilcGMaPU7iUgeQaTQDg1nIyRPnzdD719Zt0Shp3yyrQ9kCTHHAFkYOxUvdfVWmqEE5EsGCgHM6uEh54E424b4BycXly3pAUOS3c8RaZyj4Lfg6qE7TzU3GQ1uBfXXvklYogDUBFiCDMKa509Ro4plA0ZF53DXPgjv0aPrJ0K+umfUQxmi8WZA3V0rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cm/mFQG2wVSjBXkYDMorim2bPCGjUUwGsFt9Oh0GLds=; b=CWqvGoLuqCXRK7wpS7HXGPDk3uiIUg1X6M0TkxpQP5VkNjgbnTjLO4eeMWQduk3xE5LToRqIZohGpzC0GnjXSxgbjRdtX3V9QAZkOgjQmCtMPE4UQd2PU45SqDTnlvfA7NuvAQ40nLq9MRNSOR8hm2YXI8z2jWUQeu0Thm6PCe36hFyKKfsYDX1To9Du4MHLOxkGAGsLSK0DpMac95EjU3pIMQLuLRjQXXNvOqESDjMquGw//GCpqbK2RgnVZQw7tq27NNppnt6Q6GRvSKsqRxIW6Ji8GU7gC28BKHpXK9kHGQ28aJkjkeeZuT8TxqbTw69FV9d+Yvi0UbhBPKhcLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cm/mFQG2wVSjBXkYDMorim2bPCGjUUwGsFt9Oh0GLds=; b=I5zGDf0SoGmGTikOJxuBzyPkBQdITmR857k6IhFiRcWWZaqs1LAya1CIPDg/EQbjJVy7JLsuakuZp7HaaTwH6nXg06HIbKwz3OcgFRkk1UBM58qbXNUVGx/FwACo5ZzhfSnWt+Y13NOVZDzruQfz84DRMvAZ+lZKtrVlbZ+mDI1AH/xla6Nrc3k9pWUy5q8qyH4nCbLuVt9AhxvGbhXRKKJYa0yH6KwvVRz5Z3r1mwkWLL95rHu7Y0hLrstUJjBOgrMKssqsyM8uIZwWvYw7JsbwGs2SCW5n5PtxQPGzi8YEE1DkEiRfC6IvBvH1o9CpFhGrYKZzacXRq9qzt2fNVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.20; Fri, 18 Oct 2024 09:52:36 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%6]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 09:52:36 +0000 From: "Peng Fan (OSS)" Date: Fri, 18 Oct 2024 18:00:56 +0800 Subject: [PATCH v2 2/4] clk: imx: lpcg-scu: Skip HDMI LPCG clock save/restore Message-Id: <20241018-imx-clk-v1-v2-2-92c0b66ca970@nxp.com> References: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> In-Reply-To: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Aisheng Dong Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1729245675; l=1501; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Bc91I2eEi8/lINfvZA+03pByFBF/wxNxtYOf5hDZEIg=; b=Y+dGz3t9xvJH8MXD9XRzQd4Hx7F8NpX8IvWvzxTdUJyMc6JHXo8QTNMMvkbMDsDPJgmBcw3Hh 4k4MKmfRuY+CqepJ4Gw+F+q4pGBmA5xbw4ZUuH7XEO7+9otjY7tVNGG X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0028.apcprd01.prod.exchangelabs.com (2603:1096:4:192::21) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DBAPR04MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: 3913e856-4958-4af3-61db-08dcef5a9866 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?jiUWc58c7YAytpTKNxw5YX69gpyPXUl?= =?utf-8?q?+6cx7m7qggOMMaryd3DpYJIfZzNy11ktCJr9HntArKtlq69laGE2bJugkCeYOsGvh?= =?utf-8?q?bXeFONDkkNELWPiqtleKPd2kussCQw7/igKJhodzDOSNheQwk3pz1nHWq5/9ZZGST?= =?utf-8?q?y+NwH/yXSjFSqBZ26fBpwrCmqm4sKtkJ2nwkzuRbEQUua7UO8jWRh8RAYkBkqppaH?= =?utf-8?q?YWFFEpelT+adeU0Cg96xqhvJq2TB/0z2EFhizLzNziLXOOlGVe5i1bKNChR6xGpkZ?= =?utf-8?q?FHkGGlxFJifR1YxBqv10jscBRF4kt1Ns2HEUhSHu3uUKmhCfEONuDb3nOTdw5Lr/S?= =?utf-8?q?CHVXlDVaaRy9arYd8LJLcKSc1ouaZPNg6mzGODXhiXn772uLKqEasfbvR5AafAG64?= =?utf-8?q?/K3Ms5p6No7P7us/JrJsMA5xmI7hf/ebeeLQqJNq6WnH2Qz2wqC3uM7HVxiGnd+dU?= =?utf-8?q?SawNdAPNXMfUJ4vUukbdJhOe+qke0tz9wbqp1JxpoFyYtwbnpowz8dq8+S0/8XadZ?= =?utf-8?q?IWDGLpu4YKJ4eAweHNZDUt1H56ifiNCac3/cOhdqBg7/T8mwnr6EwUUSH9FllHHe6?= =?utf-8?q?NZs+5NKxGkOyPHY7WWh2kdi4xTB0Dxu5cispubMpVpv4l7VYHlBCWU1s4pBsQ1bpz?= =?utf-8?q?PWJ20DqwjulBvi3ClAmZeIFxYhMvlA/yOuA1e2iIKFeahx0okEa1YBouIdtJZddQe?= =?utf-8?q?jXubSPpgRi6XD26kJpVGxx2kCsurHZfuqU/FCejICCDD6Th4mNi0+DUcmVVvPd/XV?= =?utf-8?q?S+TwZpUGu+hPYt27sxCaJZo36g4u6d0GWdQLf2XxDcDgWThn1T/V4YD7lM8ESgZ8A?= =?utf-8?q?9+0IzMIdkdmWyWSP8XpH353kcduJBILJV04lRBrgxvT8jTVwiv29w00EYhRf69IE7?= =?utf-8?q?G+cx0lrj0eZtaio0VjySmbBNOlEyN9sm6Z25sSGsakN+YB1Jzm3su7ul5tfNhKdbV?= =?utf-8?q?aWBlQUCtZFNNCe1g/Uiq35ssdFK02km80+jdQrVtxIDqiLmdesk0yC/oybiKNXQ1S?= =?utf-8?q?UM53cjr2WRMWAB2j1vkGUlCCDdIXUQNUCfszX7AdXeujDBx0jVaU37twkV7TRNqWW?= =?utf-8?q?XoOFWZfEoW59163qStZIEtvIsppgIu9gWaaHWBPt42GzVVEQDqpR83pDOsN261ihh?= =?utf-8?q?lRz4AbEBZWfyJAwQmHlyYQhEg5xI9MccBkZ8JUNML8A5igVjd6tgBIYYqZwd5NGRd?= =?utf-8?q?JJmYzV6YWfDKN0+FbriMaUE1V9iTCOKWhVOWDbeLA+xato9OMssZSrL0tMv2TdAeJ?= =?utf-8?q?y9bYqzCMYNdu2z5eWqlQMuXoZQjZvY1qkOigMEQ55IDNVxYm/r4YrUts=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?nbjVksECNjEpxbH3ZGlLB58HcSuh?= =?utf-8?q?lS33QuIm75lGcV6uh7qRuy0AeTdoWZ9YXWCGPgQ2l/aLCCWUvbhUAY+rqUM4hR7Sc?= =?utf-8?q?MzcsA3GeWgr/u4Mcf/U16D44Rw6MmMvhF1/eSG8Ontn9wbcT+Gl7E04OXRPiaGWCf?= =?utf-8?q?2DUUHrRfsIgnzPXmggXjzeH4x8ukwUBjLLaUG/qmAAMFe+ocYjJHCiiDh2RihzKIQ?= =?utf-8?q?MEW8o9f20jjV+fSvBhwgsVfvUB+OcTFeSdaJC9c7kicl/QM1jVJw/v+gB6hkrAYvD?= =?utf-8?q?rwfMZVFRGZuk99F848nUtaAB3CYA/SILxHdz+RfTFCHmT9TLdLpPWTw6X+MB/sswi?= =?utf-8?q?8JU8Huu0xaixDAhokUxSLoKT0yh8yjUt9753cPviBSynqfZeFPOVLm9njsPuu3LIX?= =?utf-8?q?iRJH06xjZQnSjFb1cJsl23tdwaUmzBJOznJe5DhL2Q8Do0gO8B4wqMuZFe9VfYNWR?= =?utf-8?q?K0tmX1gEkLehHB2487MMz5UKb72+gfSg5zkMzxGd80BiJJrcFTqXcEq+fBPjSXOXX?= =?utf-8?q?XVClwzwPlTWNB1kltVIHpT6GxZ/bRJy7LSZEXTrWOV/lQ4lpTlCaSqoP1MhOlr3mH?= =?utf-8?q?MjG7YjWvdA+VB7Wtfx+so9qyXFP+ymrH60IT9+m+oPMC3+ZNC9xZqaqR8tCWE8rBN?= =?utf-8?q?O2o//hwLrvqEm1CmKGLlgADyab5SP1i76KwFg4fLW9q7zdCKHGnXvvSsdGOB8ww2P?= =?utf-8?q?ej4GVoih4ylGc1sfb7hK2nI7et02rqBFUWdA+AE2KCyThPpITJIlYf3HIojFp3jGt?= =?utf-8?q?4vE2kC/cGuREFLZLFpbYCa9WcsE4DXBgQ4G+t2qRe58rPMJ2eg9wgrqZEIJz7Zr7J?= =?utf-8?q?vKdXgpG9KEbRZHYiDRDcBcr8engq41g266DUYRZL/qrMCGJX92WFflvcCMuqbAhuO?= =?utf-8?q?Uxcloi6HzbnfrRRKgVUJnBLYvXTXk06xFLCtNQy8KQAwpEO04ZXRdh3bc9zovQHQY?= =?utf-8?q?zPtx7mCXr12/Cah79FjsYo9pPDT3k+XwcFIsrS0t/dXAStQ/AO1aWr0iQ7vT5xY8Q?= =?utf-8?q?tOT8bv/JZUvUecHWk2IFG9lBk7j/WHyLxy4ntveW+4ZM4V/3SDgot83YqL/uFsoyl?= =?utf-8?q?7riVRtZiEOEexzM2ortjov2an1GOWCnWALlMo2J9eIdFOrOuEJi55V+hkmQUIMpz4?= =?utf-8?q?aoxMWO4nYtSpBfucNjELLga8A8mx1K820PSso4N98ObbhbZfjYmeK0V+ajyvdV2zH?= =?utf-8?q?My7+lxPBTZhD2XSrVCXs7PJ4BqFioAO+Adzu1R9DCHEYbFAu/ib15BeLrsMVkgyYM?= =?utf-8?q?sNDY4awmQ9HWtnHryBaDLQLHF4GcT6gMy5t4wutM9z6ySKtn1s/DqwwK606+sAe86?= =?utf-8?q?ebR7IKrulrMJRczFGOOwRLkvh84+x4Ahg2ViW3hyTlf3tp8c7dqu4SSLnc5ekHILo?= =?utf-8?q?nE4LNx/ukZOlSjg/4ksv1BkHubxWyI0xQhrGoxsL9+5jWcveVhY9/B4iuZtH2OFiY?= =?utf-8?q?j51OnJhSRKYTHMJxymuomKSfvDaz5D14yKspNH4Nhp0mKvYdxPsu6PSjv35VrMBCd?= =?utf-8?q?tjwMZu6saspn?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3913e856-4958-4af3-61db-08dcef5a9866 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 09:52:36.4009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: phywFUaCWgFJsgy6we+Rk2u5oIZm5nkU6C68bbHUV7N4xykKF/PUujgn10rUtAB+Di+2FMuAc6CQoX2tyux3eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285 From: Peng Fan On i.MX8QM, HDMI LPCG clocks operation needs SCU clock "hdmi_ipg_clk" to be ON. While during noirq suspend phase, "hdmi_ipg_clk" is disabled by HDMI IRQ STEER driver, so SError will be triggered when accessing the HDMI LPCG registers. Skip all HDMI LPCG clocks save/restore to avoid SError during system suspend/resume, it will NOT introduce additional power consumption as their parent clock is disabled when suspend. Signed-off-by: Peng Fan --- drivers/clk/imx/clk-lpcg-scu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/imx/clk-lpcg-scu.c b/drivers/clk/imx/clk-lpcg-scu.c index cd42190233662c66f2c354f0a2eee3a2531eeb3a..07deadcf73e929841fe113c7febfb6c9b6c5e719 100644 --- a/drivers/clk/imx/clk-lpcg-scu.c +++ b/drivers/clk/imx/clk-lpcg-scu.c @@ -163,6 +163,9 @@ static int __maybe_unused imx_clk_lpcg_scu_suspend(struct device *dev) { struct clk_lpcg_scu *clk = dev_get_drvdata(dev); + if (!strncmp("hdmi_lpcg", clk_hw_get_name(&clk->hw), strlen("hdmi_lpcg"))) + return 0; + clk->state = readl_relaxed(clk->reg); dev_dbg(dev, "save lpcg state 0x%x\n", clk->state); @@ -173,6 +176,9 @@ static int __maybe_unused imx_clk_lpcg_scu_resume(struct device *dev) { struct clk_lpcg_scu *clk = dev_get_drvdata(dev); + if (!strncmp("hdmi_lpcg", clk_hw_get_name(&clk->hw), strlen("hdmi_lpcg"))) + return 0; + /* * FIXME: Sometimes writes don't work unless the CPU issues * them twice From patchwork Fri Oct 18 10:00:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13841490 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2088.outbound.protection.outlook.com [40.107.247.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55FC8201009; Fri, 18 Oct 2024 09:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245174; cv=fail; b=eXBPgW5gruigQc/A7dpHBk97NmWwBvLeViIntQvPPQ6SagDO4irnYdF+xeGs1ZaiBWhvdpV2JLV6anDXcOydl7xaHYT/+9VARJmfSwEXd2MC6oWUaZiITxxL+ryqk2qtkbcvzAYZpGmciUzZZLnBwL5b4OTTfBUll5lshGDueVs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245174; c=relaxed/simple; bh=v8ksMBxvbeVAy80xC/9SxZUA+6+FZGxZgqOBK4nC2MI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=gc2Ep89sVR9Tium1Sv/a37AEZoweT/ZK1uNvHWm+qBtRIm0AUrqRPgkUnART0i2hQiw7erludZ71bjzompPrdomEGyO32jlU3GG+5HPUM3+nWZFqXEGK7bqYqdvUcbLft3CgZq2I0Yf55jGAH4ZT4m6RRuqdCJebXuet0qhClJo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jbZYfts+; arc=fail smtp.client-ip=40.107.247.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jbZYfts+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z/0LLIBBNeGZ6ZjSZgjtCXpatGAzlWQWssBxR27Zy7ZnsMSJLBF/Hr2I/bkOC0ta6ZB/7xtptXydSZOZNs6P8WKJ3ujoJlqEZZxww51AaPx+Z2ifzRWI/bPjQB78X1K2dJNHA1ncYNv7bpds4m5Q/Coxy/88M/otA7eDUfDQtAYzt08vuAFw7qTWiGAx/uHp44RouYRnqWWWTf+S4yihWFtDqR8DK5o4vXOYoD6WPCA9Zu3J1BuXMnkEeuKKMe0jnt/4LCgrF+Atc1zVwmWBSO5CCSH7cJNEI44lTwPk7Bsu7GcaKHs/Wvc5+NFvzyN8Dq42DsJiLdtU4k4HrHZa/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tll9CQpoI2JYPFCpRJcMtd6vZ7urFG2dHGkXxAOPskU=; b=ghCvP5JJaAb7nG4Eg0OEkwxwFdDlZh5ZvmuIAUSHtZFbqICDF59EFDcvOUPnxjmj2gDzjamBP+D4iOZT18AtotegP5NIQ0UV0Mk4cA044NbuzcdAr0/bRr2tzDvJ6sER3qCRDKVGa09HCaj8GhQQj5yI8JMIq/AP05z8wiNP5Q7C74hZ0Xku6UGDrHUP+Vstn8ceen+KWceEmmRugLppFAam/g0l/2a+dfdE2AExFyrn0ckpkw5FQ/4N8xpkllpGzuy8UvcdI/oQLJbH7Dy9waxwu9yNvKQH/rAUNi4t5X1ZvhjFiGDSDOilpPEPlJuvwb+xcsvNQU+SGKX2ZxUlag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tll9CQpoI2JYPFCpRJcMtd6vZ7urFG2dHGkXxAOPskU=; b=jbZYfts+LEQj2uhI+cLMeaaSot0zK0/WIvdfsZB8SQRZjtzJfo+qZJuEdml2krbp+WxSrESP9GZReuxPFeHEXqQNcuoE0nrFxG2uWqXLG2uP18l4WAVEGX5Tm/S9OzyoFVV+DtE27gAo71MW+0YihTaeDGlOZywMmCPdx9Km5eommc5SOoqSHxZ/Foq04Dsd+xojGYVulm2IYS9ZNa158qHCNqm/+BveXSEh09t1r7kWmjGsJW+R9MX49c4IOsjcRR2UockvxF1iQYsPwQ3lmNQ/ti2nZDJHiyr/uZj1VPdd/fMBvMBp6AYGDmkJ0yNIcuXgM/KU09Xcu1/lUQa1GQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.20; Fri, 18 Oct 2024 09:52:45 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%6]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 09:52:40 +0000 From: "Peng Fan (OSS)" Date: Fri, 18 Oct 2024 18:00:57 +0800 Subject: [PATCH v2 3/4] clk: imx: fracn-gppll: correct PLL initialization flow Message-Id: <20241018-imx-clk-v1-v2-3-92c0b66ca970@nxp.com> References: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> In-Reply-To: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Aisheng Dong Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1729245675; l=1523; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Sv4CHyV16UexiFdZ+yIX03Ey/S7U3vzUPoU0hMATx6E=; b=DSOgn3MmfKf9qUurppWcHeibwzQ634wERjidpXq8wcEo6dML0JSZjn0YQQTXq6G9GACruCnpH FvZvsurJmT9CixVl+oBbQjkYWhWSNlD3FgaWeHqxwNGe4nt7VhB/xqI X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0028.apcprd01.prod.exchangelabs.com (2603:1096:4:192::21) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DBAPR04MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: 64c9acf6-5414-42bd-b798-08dcef5a9aff X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?dnhGO+0mRPAuAhQtgsl/dwWH94/ViK9?= =?utf-8?q?We//0dWXk3cNCSNLSA8AgDKMCwPq0nN54BHfIj7/AYjzBHN3JaClbh3i/vjGiAO15?= =?utf-8?q?Oe6t1cbC6rhMgKQlWz3i2kKF8uTg6/pGX/u0uA/df7tdp9nenmDCv9Eg+CvqFrzS5?= =?utf-8?q?QUSiMO5oKKJE/Hljan+yt7K0fBn5wAL4AlY6L3KtBWHzYmVhhNLbWugPkEWN9bGVo?= =?utf-8?q?GipPNrSOLnMCallgliCJ3v5AfC1l8Sq1C71oD8Gc5QAqmGhHgAHOQH+24LWvVQrMx?= =?utf-8?q?PCiaMwmujctMVSny/ZtIVn4uk/u3652sg7HSjpMZoUIDXgz++jC9J3SroqtxvfL6w?= =?utf-8?q?jCku5CuvKQ347c/8htl4fqJqKewNSlbHE0hKxxMLefyAP4lAAMmS7at1ia36iq8rh?= =?utf-8?q?WgKe85UBJQfMFpn0/SwVZZm7CGzYcPhAkqDH74j/WA8miQngbNydfSu1p5ZFNN1Ts?= =?utf-8?q?Bv8SA9RiJBgZr5uXmnJ0w/R5YTn0rJ/ijQzAz/CAWGtTM68+hbnvFJ8IuS1NpafzJ?= =?utf-8?q?HyrboCGuNd5hF0rwzUCdyR1ztmdQq9n679VKb2DjgCGxXqWcEbckWjmsXKOJgNXi0?= =?utf-8?q?Q2sFkDCStc49r8cG1JuySZXgBYNru/s4Qksse7klIscT39ztYJiCZNp6Eeb+g0AUp?= =?utf-8?q?5jLgJOF2jxLo3bphvq4GtjSdrLbDQ4CR3KRYAYuQjfcZyiexENS6VsHZonpubtXZK?= =?utf-8?q?b2kHXkurgsknVv3lKd32UWFlRtFfR5NyQrhCIb9TganQzHn+X8o3128UfRYhnoCKF?= =?utf-8?q?/Qi0Zc6drezULC4xSzfEu/ZGsUWWSJNhDiGO4XzD72ab3S81xi6L3p8dXmHAsFhQE?= =?utf-8?q?46weQJxk+HX5ql1DSTfOSD+Sj8TWMDQowvEPObSo8ofyE+TCzoNWBdT+jLScLkH55?= =?utf-8?q?4aoB/zIKfhCouYYzZRQFbkLLgdmp7d7mqz5gsEEhnI/bko3HkmDljAAx0xEslAWLR?= =?utf-8?q?4Cp1j+gsKhw4QU8//YRJVdFa3LvSk75LVHmVB7cjszns19ir34ivvJ1DYaNyyMLMu?= =?utf-8?q?3u1skLlyF3BhMQUBzvlrUg/eQdtEHREZHVbBAn3L9mpXmd+STOaxi9rtOeFFgfQJY?= =?utf-8?q?kFtos2LaQnUEbqDWqzEgzGyXnVAMVh7WbJnVvFJ+tyajSJ3pdUu7eZ7cTY4kT/4BV?= =?utf-8?q?StXvMF6bSUdLJn3eTDHQJL+BfUM0wqUXCyByu62LVHvYnU5tKY/8GVtTqq2HC9xVy?= =?utf-8?q?GZHeHAUCGrlvnvjSthTq6STowZi/Ar1gp5d/xAv3RklvnSL6RGxII0z5nOX3wtWms?= =?utf-8?q?GLs4CeDmi/J5qpvgJsL6bahvL5r07wHzMB5l7rLc75hUrykp8jo6+LMc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?I3wbnTM76E/TaDrEUXaiLzkjpw8s?= =?utf-8?q?LEeVYGaqlscnf/yOqjHUrbgCpGnygK05d/iHoKdCw030czkU98k/ymqtwyUSxMp+v?= =?utf-8?q?wzesaZkuyV4Z8xXHnz7Bw6/9Txe1fTKBMqgeegSEr/XAY5sC/LHFssEIT+RmKzIdB?= =?utf-8?q?fT6+Gb1LPkwp/VooPYz7m2BU0KJJGHrpaBq+nCqZqgj7oD44wm2S4OLEyrYgMsoep?= =?utf-8?q?YrKHiVnAMryTqvppv84yirtMurFuJB9KYPFYqKlGET65V1qXjGAHDdXWORq3y0gSG?= =?utf-8?q?zfNcjQBHyw/TF0X9ssrc4hx5OXCsWygXDMBDYYKc1DwXHm/8LV1gWu3SYip3PGFNs?= =?utf-8?q?SFdvRPW244Oei8jrEf65F2NzW6+A4D2dpCl8ggBdZqYgNuXLQAiYEwf4ZwbWIR5Ya?= =?utf-8?q?IijyvzjM3CnU8FJdDBFrZbV22Aja1SKwwJdZq4GpS6iHF/KE8Y/sTdlX5XieuNacW?= =?utf-8?q?r+22gZ2TYZt/YO8dtJfCvqgsTLv9auOvAQYEn+PRw43y4gu95KVQXHCSkeJzMyjat?= =?utf-8?q?D2qJcScHJLknRiv7suUSZGuQ8ydHcaZDb86NRsVdJD/BQrAnkN2XD6bUmJfYlYt0X?= =?utf-8?q?WxiuDfzpWReeEVXTZQ0rER589lEkUcVx2x0AoPR067wZM700lVLsp9Lp1Z4vIKEuZ?= =?utf-8?q?Z7orTlXCUUmCP/yddP/rgk7+wtim0dpmkBSOjrYbGxyIEUkOwfrVtyGQZBimwEpDR?= =?utf-8?q?7hylKBsivO/zu3/QnumD5zgL395v1QuYTmfMP1ko6bQPOSkj+Re8n0Nwi4booGNcn?= =?utf-8?q?C/y1Vu+mdgt/t8g4b6ULmJ+kadrdMnDF1UohqNvEObPCB4LDTwDK5RrTR6UOaSjgd?= =?utf-8?q?t+icxEC0cl66mrnWhP4yux8cs8VHJjsRUTwc65P7WkMgvhvFz8yBnAFaERSYWt5mg?= =?utf-8?q?NcmTJ6ynFcZRrQ704lx0W3cbYyEtekvzP5MoctHyPXjhNTp8zKkCa0e9sqtpPA/mk?= =?utf-8?q?7LNgxzJWkhW1n+Kwxv1A/EdtELxwoU6Zo/oHbcfoCI4/qmGgQev9MHsgJ7lJBi+tg?= =?utf-8?q?9T+M1DpMfLraTc6oUdaLRitV+SreVh7j04kOlPdvi+EyyGjcsCnvv+XTPZawYh+yF?= =?utf-8?q?PGdlRmwBDR6Vczk0cnOHYxNnkXsak0nn0+Iz1XLXcm4MEb16XFolmvY39uTBCpjgo?= =?utf-8?q?vHK3LNxhgMmSN2idwvUUcAsLhXU81YeMk/cTcjYXC8r7kdBkZDE4qqwm4EMZE7m3d?= =?utf-8?q?g5bJYWqiPQGFOkii2dRBNhUCSVgGe8qsJmy5rnuCgEF++AR5jksBpt9iZvmEVz3us?= =?utf-8?q?H8b1vAcpYM4uAy3tikTVFgsqCkjNo3S2XASJRNtuwFKOlUf7ikPe5gFVV+Eexkdn1?= =?utf-8?q?2OqNc5udadT9vllR+CpQmbDB8u4zexKbdEWdy4QY21pUvIo2lpFp1+Vftp7D3S5vl?= =?utf-8?q?1deEw1iXJCja0sZGCz5Fi++MRXa26VY6bX0gUrfxSStgkj3kFp0wirYb8bw3KeoP1?= =?utf-8?q?8SLP5ES3jdNOQEu0dO4uNT1bYxC7z/4eloC31zOtuha203QRtHvpqYZMo+bF4GGYn?= =?utf-8?q?YhMAVPKWDitW?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64c9acf6-5414-42bd-b798-08dcef5a9aff X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 09:52:40.7530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jV0Dfm9exJm7db9bb3L6Q+HDouyhCmMEL3V8r6I9aX3k5CotXdMT6/1Pu3wcR91rgre1+sq8iV2DMqDE06TqfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285 From: Peng Fan Per i.MX93 Reference Mannual 22.4 Initialization information 1. Program appropriate value of DIV[ODIV], DIV[RDIV] and DIV[MFI] as per Integer mode. 2. Wait for 5 μs. 3. Program the following field in CTRL register. Set CTRL[POWERUP] to 1'b1 to enable PLL block. 4. Poll PLL_STATUS[PLL_LOCK] register, and wait till PLL_STATUS[PLL_LOCK] is 1'b1 and pll_lock output signal is 1'b1. 5. Set CTRL[CLKMUX_EN] to 1'b1 to enable PLL output clock. So move the CLKMUX_EN operation after PLL locked. Fixes: 1b26cb8a77a4 ("clk: imx: support fracn gppll") Co-developed-by: Jacky Bai Signed-off-by: Jacky Bai Signed-off-by: Peng Fan --- drivers/clk/imx/clk-fracn-gppll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-gppll.c index 591e0364ee5c113859a7b6271c8c11e98a0e0ffc..4749c3e0b7051cf53876664808aa28742f6861f7 100644 --- a/drivers/clk/imx/clk-fracn-gppll.c +++ b/drivers/clk/imx/clk-fracn-gppll.c @@ -303,13 +303,13 @@ static int clk_fracn_gppll_prepare(struct clk_hw *hw) val |= POWERUP_MASK; writel_relaxed(val, pll->base + PLL_CTRL); - val |= CLKMUX_EN; - writel_relaxed(val, pll->base + PLL_CTRL); - ret = clk_fracn_gppll_wait_lock(pll); if (ret) return ret; + val |= CLKMUX_EN; + writel_relaxed(val, pll->base + PLL_CTRL); + val &= ~CLKMUX_BYPASS; writel_relaxed(val, pll->base + PLL_CTRL); From patchwork Fri Oct 18 10:00:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13841491 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2088.outbound.protection.outlook.com [40.107.247.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E4D8201022; Fri, 18 Oct 2024 09:52:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245176; cv=fail; b=A/W/n57AxxD4lJFOC2PRirb6iA8YDggtYJvy1on8v2x6SKE+pSY0i9rsQyNe/GGTGS8uhFaI2u3HLEDmt0IJIE+klPbMB1TS6ZVBuEduE6dpcU/SNQGJLpmXN8dUSsZeYsRhJvLKgBC8ERLeqj0nX4hCpfgnAcNmMKRv0YjvDLk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245176; c=relaxed/simple; bh=YZFP2ut1ozz6BeuzTp96FlzaXbQr4fqELBEGph/16b0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=uTNFrpOyc8CJo+mGwcdHGwRam6HnFlDVoBS2F/vAMGwrZpLkUsE8l5qmFI7tQJoavfNsR6PBQyA4ywVyVUkVNE90Dv7lQJsBUadLe0O2Wk+4g9HXnRmUB5OFZ7UM2OZ58CThCYSmO1A1hh2hLzTnoulKir4TlULxghNLNufsEVg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=HiinE3L8; arc=fail smtp.client-ip=40.107.247.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="HiinE3L8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O+DcYc3Y7wPAHJnCmyaIrNUA65vtUSQS7QhDdR8mZYZmhv+1gMgp71QJD+Z/LLf8SM/WswNhrlTtXHIARST+P/2YRuh3Z1OZv1WHJa9xFiMWXjrrsyrs1wsFXrDhbDqD/AXWfanPDxwMycMxGdOMyd5NrhVJhUVdUXntWxMcVwi7XMEHa1qudrAFxT3VwdeWAYv0Ba7s9lm0wUN++G0J5n2qEh5utkl/aaSbYbHKEQePmakf4DmnJ+rz8EBi0Hr+y89mDxO63nOzYL3Jj4dumPpY/lRLdRcZwVAe3+NBcoYhDgi1zK1U5qlIEcsa7ma77zo8quRf9ZRrpY+Ncfkn/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+kcPrphzLGA7BGzbN1UZPB/S9IXEYPjoakvnz0Egv0=; b=XL9KuMBL8IQsy8nNkOYBiZ49tp2ytk0jY1ghIqqy0u5v0Wk5i0GHgAa9gwjrEFxIDH39Akx8QZX6YoyqHEUK0yw4Lpueknv1CtiNVVlklLym++af8CWAhVpxSX1ABtHOITco38r/b1LYniiI0uM5N1g8aXGmKlyQJsl5nQrFWBS/IyBtJjxZpl9FBFjrQ9wgeNti/NKXfL6y5Vb8N+R751/WillIGo/lvL3U/PmEty77uLbH6PB29HfCeIcaAQ8Bvs6XzYtkQzmPO72GbmUmRsiSq/w8MA0Ts6rxPBGdrYkC9s0UTksYLFmTllYRZmpdGzh/YW0KznJCm1uwwO8yNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+kcPrphzLGA7BGzbN1UZPB/S9IXEYPjoakvnz0Egv0=; b=HiinE3L8YSDl59ZzScWCpuGOlFuUIg3gQcXFirtcjR5tY1AjPKkPVUUdQFE7qUjtUcuwnVFLFvIMEcy0Rh2jVGptn5n9SHIYrp4Jzi9bd+9G1l7gPNf3epKLmwOGNM/EyAI/OCSTI5BXcPdkVojy0HOxysIqar6mvCDGJVmltP8TIrNiUCB21SedSr4Qat+S0/hqFKYQtJMdCqoyO1K8GNpeYiNpgo3Bg7HD1S95+kWCgjhgWeOyxWBWWd5GVAzIu16UoHVvF/jac0eY3h+BaK8DmUfubLk6GtXjMdISgdE4h/ewVJHffqav/VIAwyXPJu8GuVDgLaQqxpGrAVLAuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.20; Fri, 18 Oct 2024 09:52:49 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%6]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 09:52:49 +0000 From: "Peng Fan (OSS)" Date: Fri, 18 Oct 2024 18:00:58 +0800 Subject: [PATCH v2 4/4] clk: imx: fracn-gppll: fix pll power up Message-Id: <20241018-imx-clk-v1-v2-4-92c0b66ca970@nxp.com> References: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> In-Reply-To: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Aisheng Dong Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1729245675; l=3036; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=84M7E9SFxBK3SAqAyey+G62IZbKKHtL8RhiilZogEI0=; b=xlHiWobNppTS/0cbCmCuEwUr+/L3eCAQYme3vG5dICODTaDLGrODTHTveR3ajfiDB6IK1yx+4 dMR5jtNcE0bA31D2oR+01venJIBsdiN0oypLD9J9f0rXeZtqzSrHOwR X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0028.apcprd01.prod.exchangelabs.com (2603:1096:4:192::21) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DBAPR04MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: e60789e4-a748-4db4-228c-08dcef5a9d62 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?/Rbe2xiG9HUfM2f0zP4oGeFE+6v8+dq?= =?utf-8?q?NdtsSsmzhjvVfLn5bskHS1+HvTiH7w0pHCplH2WXQiqaLLwG2mray7CZk8rFOZVWw?= =?utf-8?q?V7ATgDK01OVhvvKs/UY/3RNKSy/msJ6fWyPaGS0NAEdIMukmWf566B0tTbF5VpweM?= =?utf-8?q?7x7edwQ68RUq6Kb1wkrKHOzcAijsBYojzNWCWUJ8zOGcluWqDiGpm8jDPczw6vHyg?= =?utf-8?q?tzs3UQBMv7oF/FY04PB94M+MiTNwPrjoMeO9Hjcr8d6LVtVtVDBffCmSi7DPMzW7t?= =?utf-8?q?csrWv+lBmKtzTMT4QkUcc/mUWWdkxzMrbcLNxGbhuvP1DM1fezhxNd8zSAlIiIfco?= =?utf-8?q?j/iR9+V6K6aY91PSEC0oxrs2guYl8g9SOL977lzqgVKxX79a+sytI5KKsYWcenEOw?= =?utf-8?q?HQDld1wK3ASWCuFVovIZsmKzlGkozNETT4w4aZknjN+EiMfIAbSomfPgqrNxvn8Wo?= =?utf-8?q?Nxyeq/nNLtubHLtFP87VW/WS0gQ/qIYbPFWnUbCSKj4cyxIGpMYSAQcqHXXjaetrG?= =?utf-8?q?bVo+j/3FxEBM4aUkh6cRLPPu08Sko79hlbPC/P8uxeGzno87w5Ig7gKGClmpmeccx?= =?utf-8?q?ZJMqauESk9CHqqnBcHJyCwNRGYP8PzfiiT0BLboUFelP+QvplLAytGnu/TlWkzqpA?= =?utf-8?q?xPWe3oUZiSx2TO7WR/3bkfvcRumTgpjgyDQGEOnMk/91NgcAA/D9TyXs5ATxtWgjY?= =?utf-8?q?UdGx+tgcz6MArnzNOhwDknmKkou71tWP0d7TAn0UCttGGQiwDkGrg9xsuvI3j7P2s?= =?utf-8?q?36WwEBIC1hLJNnRg5ruhYf6VKRnJcQynHjHKmfznJ2ZHHflwTSq5nPhiq98nO1OJq?= =?utf-8?q?jMWqVPHGAWSV+O0jp3/Iv82ey8LV7g8WgFfTtCHaTdmOl96YibRLoEIVnBGpcE46t?= =?utf-8?q?FEQqQgRN6mKarcY6aRMjLfNeYXlWroGMp5dARnhSIlJSHLfEat4G4uhvkl7F3ISl/?= =?utf-8?q?nWC2+8Wey6UDbhgO89aKiyFHEGVIuCYvG4RU0GLhENt2QoP2HuhXjCAH9hCHEu0Z5?= =?utf-8?q?C6wzg+27tAauVnNPjWXt25KKfDhGAQTROqLO+6b0UKMO/6TLr9eW5r9nVME6Sgm4S?= =?utf-8?q?dUlrNJ7RWb7W+XAq+aeQ1nZPbsgkCvf2EQ+Z2xUrkfohexWZ7QjHOtU5j2FGY1y/t?= =?utf-8?q?TOaBZO46dYNWeEvFP3cYvEpCu5lxYZ6lQN2fX542GRs5R323amPhc0gW4y7HI8vTB?= =?utf-8?q?Rwx8RpLf68vAY3UY20u/ZcTMiL+FYzBl4pqGzBuOAC9S/FoV2mf2bmtCg6u7ncrY7?= =?utf-8?q?P/TsNKSZBGilJOb1sVOsYG0a2PcN9vyUW8lSlDBZVBlVdRimFqr+7vGs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?VRMoO0dEAJ8ocomXppixvJzvfhCo?= =?utf-8?q?lYIgM3vfLCLfRogvxk4w8r4224bBQiEvEYgMwNJP9wN0u0KXyUdlKllVhUKRnGTFF?= =?utf-8?q?mRo+mzBodXnQLeVKLQ1+f0072ug/KKWSvSzIjyDVG+XI8euTDmyO4nZnFQ+rmQgxm?= =?utf-8?q?5Kwi9FP/BC/jNk0xZDK4+hCur+HzRbE0OpOPMTyIsJBn9yt6uSTyv7xkOsjHh6IhM?= =?utf-8?q?7L39dY4IaDKHcvVWPlIF1FMBCUc1XOmgf9b8wXfLo5ht1kqMAh29+nI+VNju/58Dm?= =?utf-8?q?6nCEiWgsJfgqGmlyQWEaBvrJt78LEUP7yoohOD6WFE/ZnNuBfWvgi/eYxpbvpo94e?= =?utf-8?q?nql3gRjyd/a7GZ3PM5dkL7CxWHJS1S+MSy+MpCZDerBSS9xuWyo8hD7fYmUNuqKAg?= =?utf-8?q?zchePxjpikRnuekxf1tj9NF6qmrHsI41X4UUFfzNuvyKIIn5W63xP/ekicYk93fqV?= =?utf-8?q?pp6XpIjZrT7xIWKP/Uj66FjNAuQ9L2Pm+14g1EskOK0wR1DCQCmeAAX2A2PZ8Ifw4?= =?utf-8?q?uD2RJymoVh0rUylxfKfYPProyQwSElmRg8eW0OhrGMldG07uahJTskqy85LJVYEIc?= =?utf-8?q?cMq57eq1FtQ1aIynautUzPAlZaXwXPuQAC1qB7b2eMfiikI+NWdEo9g4i+7Om7bJM?= =?utf-8?q?VOucUox5pnxX268G2rKE+lPSdCU2S4vrJztjHWCbxCZ7sIIzelUbJHKcuDCT2J1er?= =?utf-8?q?zAeKHdYf9FK3iFIdWqjZuCKzU4doqsgXaLFk6g7CkkUPCG/tv1xg6FO4nFaysMXai?= =?utf-8?q?UvJrh8rHX/qfkC85cpwrQwnVEgCKJzGsCOyWvDeAjNeLd6YiZe9gu9bjilLUsyfKG?= =?utf-8?q?nTMQzPXFNQ3t9qDJGsp4mNO52GB+OqySRfB7Zl9q+v7d4eUqeWtdJUwuLmOR79BAl?= =?utf-8?q?gz8eCngXEsOmeaaPJIVzWyLTAKs5+hMDPPR1krZmmNgVz09eVNbGGjF0nFayIxu6h?= =?utf-8?q?qBZ5/C4sNgWdOsDxKXxWsiWBk5T69clHjKuWEflbVgQJXLHUVTw8aZ75UNrlhbOlA?= =?utf-8?q?D8Bm2mNKqlcZwPDSMvjDrzeAL5zGuvE6NuoX8bObBdUyEi8Ungmmq4dW9PPNY7Ixa?= =?utf-8?q?fSf2zC+MRhY4nIseiK/5hK2IJ166FLDZCYTzwuR+NkPNP46BjmniewhQFHbdwoliT?= =?utf-8?q?PwF5c3HQZ8UHsOjchs5LE8t2C1Qx6GF5hDWxlctOT9BYT/zDK7UCtEJehKJCT/Byw?= =?utf-8?q?09TSgKtIsK/QZ+wbv9S3bxxPt2UnX8s1yHfxzj1XfW24meBaLuM5qU6cA2Qk+sNR7?= =?utf-8?q?2GERIekjcF23bMt3Q+Y6NjyJxO5h4jl6KOpb8m1SVoOxRTpquEAKWg4obupC1ozoy?= =?utf-8?q?nM8vEqo4ovIpWNitCjZIuofY0DztAm9kpFqAY6gTGmAWWMeshomeLA2NEDedCbcd6?= =?utf-8?q?PfA3zD1YRPasdZ6XyoZHSC/d9TAssKsp2bpMzKrzgjtjYs17cquXUWQE4OIgZI3AY?= =?utf-8?q?ZR+4A7wJaGvR5wvJ8JfQl2Ny3EEM7xyo3U0DO/0rv23sGHWudqhO2KlvNhG7YTKLe?= =?utf-8?q?+p8icH01jgsW?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e60789e4-a748-4db4-228c-08dcef5a9d62 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 09:52:44.7693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IhCTU/4TpMvf0fbmMxCfRwK0VtbIZCNb0aBNZTNPvxy3ZW8OYMv4CdUbKuAMzGUuznCLTLjdKuRk5SUfOwAwAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285 From: Peng Fan To i.MX93 which features dual Cortex-A55 cores and DSU, when using writel_relaxed to write value to PLL registers, the value might be buffered. To make sure the value has been written into the hardware, using readl to read back the register could achieve the goal. current PLL power up flow can be simplified as below: 1. writel_relaxed to set the PLL POWERUP bit; 2. readl_poll_timeout to check the PLL lock bit: a). timeout = ktime_add_us(ktime_get(), timeout_us); b). readl the pll the lock reg; c). check if the pll lock bit ready d). check if timeout But in some corner cases, both the write in step 1 and read in step 2 will be blocked by other bus transaction in the SoC for a long time, saying the value into real hardware is just before step b). That means the timeout counting has begins for quite sometime since step a), but value still not written into real hardware until bus released just at a point before step b). Then there maybe chances that the pll lock bit is not ready when readl done but the timeout happens. readl_poll_timeout will err return due to timeout. To avoid such unexpected failure, read back the reg to make sure the write has been done in HW reg. So use readl after writel_relaxed to fix the issue. Since we are here, to avoid udelay to run before writel_relaxed, use readl before udelay. Fixes: 1b26cb8a77a4 ("clk: imx: support fracn gppll") Co-developed-by: Jacky Bai Signed-off-by: Jacky Bai Signed-off-by: Peng Fan --- drivers/clk/imx/clk-fracn-gppll.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-gppll.c index 4749c3e0b7051cf53876664808aa28742f6861f7..85771afd4698ae6a0d8a7e82193301e187049255 100644 --- a/drivers/clk/imx/clk-fracn-gppll.c +++ b/drivers/clk/imx/clk-fracn-gppll.c @@ -254,9 +254,11 @@ static int clk_fracn_gppll_set_rate(struct clk_hw *hw, unsigned long drate, pll_div = FIELD_PREP(PLL_RDIV_MASK, rate->rdiv) | rate->odiv | FIELD_PREP(PLL_MFI_MASK, rate->mfi); writel_relaxed(pll_div, pll->base + PLL_DIV); + readl(pll->base + PLL_DIV); if (pll->flags & CLK_FRACN_GPPLL_FRACN) { writel_relaxed(rate->mfd, pll->base + PLL_DENOMINATOR); writel_relaxed(FIELD_PREP(PLL_MFN_MASK, rate->mfn), pll->base + PLL_NUMERATOR); + readl(pll->base + PLL_NUMERATOR); } /* Wait for 5us according to fracn mode pll doc */ @@ -265,6 +267,7 @@ static int clk_fracn_gppll_set_rate(struct clk_hw *hw, unsigned long drate, /* Enable Powerup */ tmp |= POWERUP_MASK; writel_relaxed(tmp, pll->base + PLL_CTRL); + readl(pll->base + PLL_CTRL); /* Wait Lock */ ret = clk_fracn_gppll_wait_lock(pll); @@ -302,6 +305,7 @@ static int clk_fracn_gppll_prepare(struct clk_hw *hw) val |= POWERUP_MASK; writel_relaxed(val, pll->base + PLL_CTRL); + readl(pll->base + PLL_CTRL); ret = clk_fracn_gppll_wait_lock(pll); if (ret)