From patchwork Mon Oct 21 20:21:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13844645 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEBAB1FCF57; Mon, 21 Oct 2024 20:22:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542151; cv=none; b=eV1Yq/31ZqQpR1n/WQk3Ao3FfzjAhE4t1DQFaMvOlFIV7s3dH3Ypma1rnRfow2kX3ylBCmYMk1S3ohPWGWxU1v1zmudadJHZxkQlRf1iBefIkwrNjMl52/wJyL0+JwanuS1iJ0bI+eG0dbZJun+YFn9AIio8glMc+8m+Auh4EhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542151; c=relaxed/simple; bh=nW22kA3OZ8EJw/l5LRYWZwP/cEEwRZBk/AkUyI7nGVM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZrMxgFOQrcdNIjqg+Q05pzXpzO5RBO3WO90eFccCmLg1xhymaYK/cBqkQPNcu6ekxSQAeYEOv6GfX7qQsrSXxV82Gj7bLLamH9wHwhKGnW5qbt8Uyt4/laDbmJ6NRgWpTvvabyCh/WEk1GFoN95G0nVf/XMkqsxus25jCMenXh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GpVN5mDA; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GpVN5mDA" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2f75c56f16aso47632041fa.0; Mon, 21 Oct 2024 13:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729542148; x=1730146948; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Le88MClF/oogWi94ucU/sxxSZSDZmIFKIazI7EAYOAc=; b=GpVN5mDA1ZkeEOPuMIVjoCihT8NINUXm6+uiL4xzG+iVyz5A552ARAoKtA1sLSw+JS I3SjgUNAxu9mDr6XbUHaVcfLfOtJ+orkMOTIw96KYPuKARA1z/vov8EzFF8BsDWLRcKO +PnwgQy3z89eWp0OXIp1bRvGCfTNAzZsydNLhpUFxJh7bTxtlsVK7mj6Ncfl8LdhBLEC i+ZzHYLn8yAzAhWFiGuZGmy+kYuZ2uyd/uoiVg+WESMa3ntGs3sGk0t0QFqsaBZcF1zz pjGoWaaxYRhx9C7Zt8VKJs6Sigm5PZoS/x+ObijO3oiY1lY9IMThU7aSXoUXggQcOED2 z0mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729542148; x=1730146948; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Le88MClF/oogWi94ucU/sxxSZSDZmIFKIazI7EAYOAc=; b=oMzFasKsgOJ6n5TVGmuRQnvoc9HzjuB/4VYaVYNcv21Dcwdh7cIfzhV44y+LgWcvL6 fT1K4BNNoJEhMWZa85u0I2rw2D9j9FM4i+NlHq+1Z/pqKIoRZPT8b5ubdKoyZQ+Fq4nd hbi/9GesmuQFmMW64Q81GIeyyXKwd+PC56i1dEBYzSnWLIG7KDn+9ZbaZkK5bruSLQid WnTTHmEMT2JQ2hqxGe7afAhAH00ZnFuoEM469EaKq4Z6xYRJW7Y5wAGtsADuXI8mghbV GJ8SnZlEbW3jUb9jule0fPnaTailJqq1GpNEMU/hk7ZtPAHFXJLjCc9b9iaJWaa4zNgI iuSw== X-Forwarded-Encrypted: i=1; AJvYcCU0QAf/IPmOvl1XlU8G8dqMr6uymbmiBejI+QJrRhvAq/6q5S00Wym+1l/U//O8noRRRyNGjAdDNSnS07dw@vger.kernel.org, AJvYcCUfF4IKg7ou5tsU8l2a5+gQ6C8kmcqBeahcN8OVIsb+6hgzFvRucp/kxz5QDRK3NaMchogMnaAWRbI=@vger.kernel.org X-Gm-Message-State: AOJu0YxnenPo5E1XSnJvpXpv8zpH1NkMkNfj81u1UwJ/7aPuIMaD8uLa oU0KzwRuCDmp1dY7jwRrxekmzZ0iryrldq+Chh8XIf4FRTjpVPEH X-Google-Smtp-Source: AGHT+IG/h6nTU2w6uC55uu0G1qJPZMDvmMsoWuZlhSScKnAICacSEqRQHJkkjr+1usLpye1ZlnJBaQ== X-Received: by 2002:a2e:bc28:0:b0:2fa:beb5:11cc with SMTP id 38308e7fff4ca-2fc9335a475mr1049951fa.40.1729542147404; Mon, 21 Oct 2024 13:22:27 -0700 (PDT) Received: from redchief.lan (5D59A6C7.catv.pool.telekom.hu. [93.89.166.199]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a654b9sm2366497a12.34.2024.10.21.13.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 13:22:27 -0700 (PDT) From: Gabor Juhos Date: Mon, 21 Oct 2024 22:21:57 +0200 Subject: [PATCH 1/5] clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241021-alpha-mode-cleanup-v1-1-55df8ed73645@gmail.com> References: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> In-Reply-To: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since neither 'alpha' nor 'alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the superfluous initialization of the 'alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate. No functional changes, the initial rate of the PLL is the same both before and after the patch. Tested on TP-Link Archer AX55 v1 (IPQ5018). Signed-off-by: Gabor Juhos --- drivers/clk/qcom/apss-ipq-pll.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index e8632db2c542806e9527a22b54fe169e3e398a7a..dec2a5019cc77bf60142a86453883e336afc860f 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -73,7 +73,6 @@ static const struct alpha_pll_config ipq5018_pll_config = { .main_output_mask = BIT(0), .aux_output_mask = BIT(1), .early_output_mask = BIT(3), - .alpha_en_mask = BIT(24), .status_val = 0x3, .status_mask = GENMASK(10, 8), .lock_det = BIT(2), From patchwork Mon Oct 21 20:21:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13844646 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69D791FCF78; Mon, 21 Oct 2024 20:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542152; cv=none; b=PeplsseIclNXoV8HH7RhgZNC+yXVeN7U+vPmgD1ucInr6PKV+y73GtYgMQDwVjida0bTg8m0aoBgE5v/OWMY/l61wQzlNPZISwP1JQQYtxekd+gbkLyrMDA4YRXUJZl1psjGAPji3gDUOIsyPpcOtGjKtifvVysWCTmP6K4afoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542152; c=relaxed/simple; bh=AL6RLYuLt4zWQRHLjhbYdG3IFFX5ivF6IjLsk67Ud10=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SFBdKrr6+BAeKIXTN6docpiBUgJ2fHRijrj29vKDt8y3XCGIu+dxcFwUEyZTS4dupBjhnhR/04fcom2YfY5pDorEvZxj/9zFJwEjzDlm8+F/mhK+McIgcY6XO5xmppDbJsDFdzlGIWtIIW6+WLdfUYiOkvV79fnvtKXVxYDoLSg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fwDcaMvA; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fwDcaMvA" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5c94b0b466cso5563329a12.0; Mon, 21 Oct 2024 13:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729542149; x=1730146949; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aNEH/622O/5zc0yJC5K87eSPeiZM18UZH0FAszllMAw=; b=fwDcaMvAbFASQMG9sh5rJz8tsOtKop45eSyDyr4GEJP+0hSEFsB0rUoDPZAJrQ8PcI V/S6HdQbmJqbBYKZnNXoZ5YCKlsX76Ah++lsCdi7ld/7EE65rUIteBFL6RCuqn0Fr2v2 V+VVD8ABYfVzkM9wqJyj1m2Mn2EIahhK0zTo0DuGYLAdu75brU7S0hzaKoBrkazYd2U2 m/c4tAQPRY5J2L2kEjJR5S2VbVwtyQXnBJ0s4ovMOPKFXw65EKn6+INBVv8c60hXjPN1 3gGIXpW2mnF97L4qYdVOyXu6EgId32kLPI9XlLRXg7nZptqJIl64k6BiOLD6tODOlU1H TQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729542149; x=1730146949; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aNEH/622O/5zc0yJC5K87eSPeiZM18UZH0FAszllMAw=; b=tz2B4JcRFuXAsr0OgdowuR0QnGcv3PDJYeXnBGkkRlmPbGpltUTgzo8JbN7riG2QU6 d8NhC83mA6kSVrc5IOlLd2yddersH1i1JApur6KFg/iBnTtv+K1+/pN2D4gYCO5xUrzD JWjjcPG7iFxTw2eMsKdG3/e9z7vSVvDFG9l3go1ki6C/vX9HU4+wE1QGbGJnBDl6IhfN H1TUQnx3YuUZl2bRMUtJIF49YackVWTAywh/fRb9k/hS2UzkU7H9E4KOoJp4hqvlBHjb OTA/k0lP6shY68xpKzhDkm27EsSzdfPj4qfzvWyjAcsklbT3iy1FiCRBQG6H4Rxh2Ecr WGGA== X-Forwarded-Encrypted: i=1; AJvYcCVvc+csiSFiz8fxvsNDAU35SG+k0lFAqqIJ9BKIoM+U7Q67f8iAh7H9BDhBQmyb90woJKXFaEGCBfc=@vger.kernel.org, AJvYcCXJZzwuiH7MADs9l82eHCxLAro8NXCgeiBMsBZlDdUK9oNk6rxxFhM3idjgu0ibgbH5OUvmkN9doITOyW0s@vger.kernel.org X-Gm-Message-State: AOJu0YwMX791Bei/9QxF8YHYZk70gtNyhWZR2zZfJ6cN5M+qcE+v4+YN QaUIg+2QkOwOyjsB3ukq3ANU6NmWboSWV6ZpnO6elCdNGWjRQTTU X-Google-Smtp-Source: AGHT+IGT9HelIXWhpB25KQ/wXCYeHl+HhjrhCjQsSKEeNbwtm5u5vvLGOLAkHKfza7xnwr/fICnYtA== X-Received: by 2002:a05:6402:5107:b0:5ca:151a:b84c with SMTP id 4fb4d7f45d1cf-5ca151ab9cfmr6731971a12.18.1729542148604; Mon, 21 Oct 2024 13:22:28 -0700 (PDT) Received: from redchief.lan (5D59A6C7.catv.pool.telekom.hu. [93.89.166.199]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a654b9sm2366497a12.34.2024.10.21.13.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 13:22:28 -0700 (PDT) From: Gabor Juhos Date: Mon, 21 Oct 2024 22:21:58 +0200 Subject: [PATCH 2/5] clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 PLL config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241021-alpha-mode-cleanup-v1-2-55df8ed73645@gmail.com> References: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> In-Reply-To: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since neither 'alpha' nor 'alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the superfluous initialization of the 'alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate. While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration. No functional changes, the initial rate of the PLL is the same both before and after the patch. Tested on Xiaomi Router BE3600 2.5G (IPQ5312, out-of-tree board). Signed-off-by: Gabor Juhos Reviewed-by: Dmitry Baryshkov --- drivers/clk/qcom/apss-ipq-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index dec2a5019cc77bf60142a86453883e336afc860f..d6c1aea7e9e1e50a8d7561ce352feac4e76fb1e3 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -79,13 +79,13 @@ static const struct alpha_pll_config ipq5018_pll_config = { .test_ctl_hi_val = 0x00400003, }; +/* 1.080 GHz configuration */ static const struct alpha_pll_config ipq5332_pll_config = { .l = 0x2d, .config_ctl_val = 0x4001075b, .main_output_mask = BIT(0), .aux_output_mask = BIT(1), .early_output_mask = BIT(3), - .alpha_en_mask = BIT(24), .status_val = 0x3, .status_mask = GENMASK(10, 8), .lock_det = BIT(2), From patchwork Mon Oct 21 20:21:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13844647 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EDFC1FDF91; Mon, 21 Oct 2024 20:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542153; cv=none; b=gi7we6RCiP9Q9CwlgAy0qJI/3DmSvEq6BgxwraM4rSPb82QAS8Mw9OxeXIKwsgXWYjD1CfklKtxZguj4hVgRsznauab6fRokJcpcL0R0/TRktZQRheJDkrxUdZIOFhgPv5e5AwJRFRJ8MmQz0pOD5EWeVNdVFiqNUBw0om5sbkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542153; c=relaxed/simple; bh=+eqpVxj18IKkNxPlnSqzMVQV3IXyCAd7GNvYT+LQcPA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZM+Rt40iclRGOdiuRZqpJjHr0KaLN6ZAjRRhgINUsm61YC1jJTX3YxDRHzytrPlm4nBjsRCdIDcTHxk/UUNo/gmhU8gyul6asp2ir49Vhty+UwDfVUlApfJXOMQTJcG4QhabQjO+RK7XX3WZBhTNY3Igh4cF1IOmxh4RnSAQet8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OsFuyW31; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OsFuyW31" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-37d4c482844so3330096f8f.0; Mon, 21 Oct 2024 13:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729542150; x=1730146950; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vZLYS1OEzQ8U66l/dkY11+Zsi+x+7OGdOhDex1oCwpY=; b=OsFuyW31wzzs9eWeV78M4KAqGmW9QrVlABnHDR8c/2ynO61LakGJZ1wXTcTuEm026W 0ACXoXEC6SKQb/+d4tujjErH3dDTSRzQmfaXo+Itp2kBqZpAcsl4qsCsHYXLi3e9mI4Q krMq65DbTQWRpJpgxkitX8bD2j77jnH0MsRdWroQkNdbbp1/LZ4q0Kp7lzx4Pne71jYo SOlPbJk+JR2AZy583ZQswIPi+Zyoi1SC67pULp4FxKFQYBmJ+KXPapHWsz/1YK3Y1zHX HofP6s1+UsLjfsWHWEZA+P3yGkSo0muJh3F7YnKXWyIxx+RDgSkHRz2Ytu1r+eJQqTU8 ccDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729542150; x=1730146950; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vZLYS1OEzQ8U66l/dkY11+Zsi+x+7OGdOhDex1oCwpY=; b=S6Ou1jqU63leKEwbD+4pUsvz2UwYZmHaDv1oIW0kMTE4sEtZihoIF5JYu99CokIVBL SsQRKuPqTL2rHygkAjR6LBVttzXWmoPKF2lakARbPEFJYacN7CkSpDa0sL3MWgDDEy3U Nrme3+ZnJrvO7iXDdwbk9g69Dvs58L4DWLpDvr2IpfJPppK4A7UCYwbzReUzUMRGgfPR Fu3RhiI4aBII9IPI+Kh6Bl1CvZNXGhYJJVf2Eof7goeaRaWQONXinNmwCExe4JsWBsOf mpZcliwfkkwz9uu++lP3ICzCVJNpFaMN0Hr+RAv0Z4te+rir+II9N+zY/aMhgzrLQwsy bYFw== X-Forwarded-Encrypted: i=1; AJvYcCUWOajruEzUshN7b9GNMtLDcBg3E/sj6/Vdxycg8zg5gRgW9BWxR6rewJp8cdJUg/EhWiOJp4OeyscviUUp@vger.kernel.org, AJvYcCX1IifhI3bmevNEnSwJxPQ4SoqX3M3N1za3nZ/qTMd5Z92SiDw2yOMEFChPRgZoV9iZE26xUbTw+8I=@vger.kernel.org X-Gm-Message-State: AOJu0YzmKa2gIq55tlLuL6W58+VfMt9NsgiXkk6KHHLvg7bGmp8mfEzU Im3+FhtQ9rB8RQsKuDQVBjlaRqv0yvcIPUps/CyHHzX1J9GBQ/6R X-Google-Smtp-Source: AGHT+IHs7j7KVkJsSgtcwCaEv6jrSWKQnSLJGRFh80uOiAHFAkXZPB5AGk8IGnjhPgx41r5gKQelXg== X-Received: by 2002:a5d:4452:0:b0:37d:393a:97c5 with SMTP id ffacd0b85a97d-37eb488cb8emr8912512f8f.28.1729542149684; Mon, 21 Oct 2024 13:22:29 -0700 (PDT) Received: from redchief.lan (5D59A6C7.catv.pool.telekom.hu. [93.89.166.199]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a654b9sm2366497a12.34.2024.10.21.13.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 13:22:29 -0700 (PDT) From: Gabor Juhos Date: Mon, 21 Oct 2024 22:21:59 +0200 Subject: [PATCH 3/5] clk: qcom: gcc-ipq6018: remove alpha values from NSS Crypto PLL's config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241021-alpha-mode-cleanup-v1-3-55df8ed73645@gmail.com> References: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> In-Reply-To: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since both the 'alpha' and 'alpha_hi' members of the configuration is initialized with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the initialization of the alpha* members to make it clear that alpha mode is not required to get the desired output rate. While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration. No functional changes, the PLL runs at 1.2 GHz both before and after the change. Tested on Xiaomi Mi Router AX1800 (IPQ6018, out-of-tree board). Signed-off-by: Gabor Juhos Reviewed-by: Dmitry Baryshkov --- drivers/clk/qcom/gcc-ipq6018.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c index ab0f7fc665a9790dd8edba0cf4b86c5c672a337d..d861191b0c85ccc105ac0e62d7a68210c621fc13 100644 --- a/drivers/clk/qcom/gcc-ipq6018.c +++ b/drivers/clk/qcom/gcc-ipq6018.c @@ -4194,10 +4194,9 @@ static const struct alpha_pll_config ubi32_pll_config = { .test_ctl_hi_val = 0x4000, }; +/* 1200 MHz configuration */ static const struct alpha_pll_config nss_crypto_pll_config = { .l = 0x32, - .alpha = 0x0, - .alpha_hi = 0x0, .config_ctl_val = 0x4001055b, .main_output_mask = BIT(0), .pre_div_val = 0x0, @@ -4206,7 +4205,6 @@ static const struct alpha_pll_config nss_crypto_pll_config = { .post_div_mask = GENMASK(11, 8), .vco_mask = GENMASK(21, 20), .vco_val = 0x0, - .alpha_en_mask = BIT(24), }; static struct clk_hw *gcc_ipq6018_hws[] = { From patchwork Mon Oct 21 20:22:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13844648 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 505E01FEFAB; Mon, 21 Oct 2024 20:22:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542155; cv=none; b=fUgsvQP/FbW9frm6RWiEUYZRRfN1oV/ZYBF05A+DiskHALc+p9KE8xVdh//nJX373f4QPUGrnX66lFEvPMgeWbXdjnYIgXqSytvvd+jrHC4OUDhm0WkvQxJfzVhSPSyM1k3ZXKvefTGxsyhkplSclotVz/asO+cRj32/A5VtDCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542155; c=relaxed/simple; bh=wO7xITuJG5GXJ1lJj5YlfqQ0jtSxwBCqgwT4iHS5WJc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t0orS6162KJj8hEkESmK7JSYsTuVCOPiA+nFhJra/zxTPAwIzFoXUK1bZS07GSJBgeXtlcagwvfhRV+R42LxKvHV5UYdPwqTr2LeQK+sP0hDtDAloP6OxsvFuTJ08VWLCZtp96fnBg0clv+spiNlF5FrZX6nXQAPpmgkmJejYGo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N8sfM/6e; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N8sfM/6e" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c9428152c0so6596191a12.1; Mon, 21 Oct 2024 13:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729542153; x=1730146953; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=r2XXuDDlU++mbkCnQ0NL8s5PWg5702ny9VH8GeOe8rw=; b=N8sfM/6e+0fCDA2FKOU1jvM8xyNWKxkbtk+lqWzGVsRDYc5fxFHIVyrRC2GTSawY2D 6VBbZKlUfpJxaRc33so1uBcVD1fnWJ+cEKEEjD+6uZzyaZXjGm5TRaCjWRsXJHGfkvMX JA0dmya0Sn/0mwS8w6nKlaQelieIrA0Ehk/bMW6o9R6TIZftxO/y6Mda/lqOkycDKVxr ESHFWw0cu31fxmr03OtU8jujqaJVqOwNoqFD3AiDKb4itrtrgYsvZ3mRHA4TsNb56QYQ wdUVwHkIHtb9tr+udGmi6d5lZ9y8KXUaa5WGcQCa6RTK+dY2Sj4KzTF0YNlUfb5BZdjX k6Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729542153; x=1730146953; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r2XXuDDlU++mbkCnQ0NL8s5PWg5702ny9VH8GeOe8rw=; b=cB3ZyecaQfPsEK8g+IDCWJ9XZqITRE7UwmSb9cGQn419BvTwZJZUHo6X0zGtIT34ee KVCrv0zq4tS1Lxo2gFUR+iIIWRP9RYbnKERAg1eYWroyq0DjLlpto2c3FBulI5uasiHO 04D9963eSnWLVJ3Tf4C0korPOX0+D/AtOJDPpQgLe6pqWvI0jVnLja+vHEzGSMckN6P8 LA3iPwmhxE1B4rtUc49BVldqeVUCSA2x3IRkKWtQODPkPL3bIuA1D20F/CoLwWzsOlc6 j0RRzzJp3A/9Xl19B6S4XJyxYPaLvBYHpx2dSeyJj3r/pHvsUGEo4D8vpdo0AVA5rQ7+ /XUw== X-Forwarded-Encrypted: i=1; AJvYcCUk1gtZ8zMIjZ1j6xm/7gVp9MMrdYwlWSM0HRgtFcnxjUi1wkyE/lr2/h2Ego0fH5qqJoixnNXVv9o=@vger.kernel.org, AJvYcCW1rFB3EPcDqwxXRWpoQmwegeZqHUKR05YqQpJmPuja/ggd4OjF3M7MUZ0cjHybaZmksAxBHh83lAD7ms2U@vger.kernel.org X-Gm-Message-State: AOJu0YxoENR0NbP9F4NCsTq1cqMnD7pGjiXKUmYtdTHJtiJkNFDi+B1o Vp+WDOb1wBI5+oZiGd0SjxYjeoxstXsiLMgMFps03sfP44b0IlJ5JlP8Kg4C X-Google-Smtp-Source: AGHT+IGGholbNXi8gC7ySdmu4kronu+UcOm7cbOy2xMZoBdWIYhJZgg6hcsFOpGzCuqc2XqPs+Fhiw== X-Received: by 2002:a05:6402:348a:b0:5c8:acf3:12c6 with SMTP id 4fb4d7f45d1cf-5ca0ac443c4mr10200596a12.6.1729542152658; Mon, 21 Oct 2024 13:22:32 -0700 (PDT) Received: from redchief.lan (5D59A6C7.catv.pool.telekom.hu. [93.89.166.199]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a654b9sm2366497a12.34.2024.10.21.13.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 13:22:31 -0700 (PDT) From: Gabor Juhos Date: Mon, 21 Oct 2024 22:22:00 +0200 Subject: [PATCH 4/5] clk: qcom: dispcc-qcm2290: remove alpha values from disp_cc_pll0_config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241021-alpha-mode-cleanup-v1-4-55df8ed73645@gmail.com> References: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> In-Reply-To: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since both the 'alpha' and 'alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate. No functional changes intended, compile tested only. Signed-off-by: Gabor Juhos --- drivers/clk/qcom/dispcc-qcm2290.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/qcom/dispcc-qcm2290.c b/drivers/clk/qcom/dispcc-qcm2290.c index 449ffea2295d3760f40abe8b1195e9022f46a9b0..d7bb1399e1022afc68e45ee335d615d4a5be5add 100644 --- a/drivers/clk/qcom/dispcc-qcm2290.c +++ b/drivers/clk/qcom/dispcc-qcm2290.c @@ -40,8 +40,6 @@ static const struct pll_vco spark_vco[] = { /* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l = 0x28, - .alpha = 0x0, - .alpha_en_mask = BIT(24), .vco_val = 0x2 << 20, .vco_mask = GENMASK(21, 20), .main_output_mask = BIT(0), From patchwork Mon Oct 21 20:22:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13844649 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53E6E1FEFCA; Mon, 21 Oct 2024 20:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542158; cv=none; b=QYBqaaj/spJD4pL6F7EQADMEf0eTiPcf+i8ucxrNg2o2CYZ98nOoFz9FrgbZY2d6m39jMk0R0TLTtkdwopkh1XiU0CKUHwLJAN7ACZK46bO7OL8YMgi0DgAlr3bTL7mF8EU28vp5R1KTlaCebHgza+6+g6lelLq8BGTcWYJ8JGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729542158; c=relaxed/simple; bh=HyV1HYjLScohBPh/00tXVNyLUDdbtA9AN5TFXZThMhg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KVHKtk4yGyKwyP6XCqRJC2azq9dEymQXdbPaFDUFQ9RsLClwh/rlhxTNfpK41Ce2DwRNAQlaV/k4nZ0WL39Kwd2i6gpgID/KY+SICh/ldRb+FYIugfrEsjX3SjMImTzWs+3TYBenZ9Df+TlP9W8GWguEolhxbDgYEYolqg/hooc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YeYFDrli; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YeYFDrli" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c94c4ad9d8so6336892a12.2; Mon, 21 Oct 2024 13:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729542155; x=1730146955; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zOH2Pc3KFq6bBPSNxl1UY5bFlP+4ex8kBkOOMJO1alA=; b=YeYFDrliZbN03suyA6hFIZfuKvKwMefZxGYT4XOcYEYMUTSMh124/MGcrwOC72vpXb nEVybIzGFk9BrL86smcxCRpB5W7OqJAtE/mebDjNg+HvuhiXn98lePkwsRDEnZULsacd Af6Ce6+tahDHgfoKwpzT+1EkNk1RZPGzyUk3ZpbdOhJ/L5p+385EayAM72C+Q8x0i094 wUoDJviF/8NVDe4azftBzv+VBW8g/AdouQuqKYQgqvKtv1eAWAuYL//Tjofal4zK5UQG Bef9c0Y2AZYrW+tl0BuCgebwUnmFHaoTXB9h0ae4uh6Zemi0oSRTV3AsAGlSeH+DedL8 mpaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729542155; x=1730146955; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zOH2Pc3KFq6bBPSNxl1UY5bFlP+4ex8kBkOOMJO1alA=; b=NtFkunYgskQC/51YofGsj41mHTo19zqv4g5h1r5AnasEu0C5d/OX0snSceUpy25Zap mCeKhOqnBok4f939v2CzIFv0kDCoTs/6VtE5auJLZTnnUda2/nbslN5DSNhyKUwaaNdu D0YrrFFEWZfnt3q7zlyqmCPvgEofL2Adjro4aYIDtDu+SZYSURgg3IJDOase8Twsb02q xOYXPtwdJBKHP0WD9VF7G4OpMODJZ8Jx3AD0xq5BO62skw4P5hLFml6MroopLVZGXDfl zpwk/ygvZFtp1+tw+jk3m94kWXcCGjbIffaQpKBhm/4HKZDYGw8h1SqI4ROsbaUqL+gf KYMA== X-Forwarded-Encrypted: i=1; AJvYcCVd1+ZcI1XsFQDC32WpBf6Z6Fy5/sfii4h1hW8SOMuRIBFpNBpR9g5ACr3fpz1+4VEjquPTZ268Onc=@vger.kernel.org, AJvYcCXxD1Zbe4m+HYQf9WIeJuQjOjK+YAm5A7EnTbxhG3Oaom0vGCgI8WgCOqFbXcGW6E4ch/go3RFAbzqorXFe@vger.kernel.org X-Gm-Message-State: AOJu0YxB8zBgkgeXP+VsuNEBeGsSPVUe+o7SQP9K+IFIC8AFGRZOX6P9 XBGia19c8WX8HxdChv+gVUm0yEuw2OTOMZadoWINzrE/PcGfFNNQ X-Google-Smtp-Source: AGHT+IF5kt879pJePv1sjlS0MWuWVkzkaD51mNxZdPgCprUZvqL6g2itNlj14yh5sSwjvn4NlY8lmA== X-Received: by 2002:a05:6402:4310:b0:5c9:3389:bdc3 with SMTP id 4fb4d7f45d1cf-5cb7fc696e8mr167311a12.0.1729542154501; Mon, 21 Oct 2024 13:22:34 -0700 (PDT) Received: from redchief.lan (5D59A6C7.catv.pool.telekom.hu. [93.89.166.199]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a654b9sm2366497a12.34.2024.10.21.13.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 13:22:34 -0700 (PDT) From: Gabor Juhos Date: Mon, 21 Oct 2024 22:22:01 +0200 Subject: [PATCH 5/5] clk: qcom: dispcc-sm6115: remove alpha values from disp_cc_pll0_config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241021-alpha-mode-cleanup-v1-5-55df8ed73645@gmail.com> References: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> In-Reply-To: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since both the 'alpha' and 'alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate. No functional changes intended, compile tested only. Signed-off-by: Gabor Juhos Reviewed-by: Dmitry Baryshkov --- drivers/clk/qcom/dispcc-sm6115.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm6115.c b/drivers/clk/qcom/dispcc-sm6115.c index 939887f82ecc3da21a5f26168c3161aa8cfeb3cb..2b236d52b29fe72b8979da85c8bd4bfd1db54c0b 100644 --- a/drivers/clk/qcom/dispcc-sm6115.c +++ b/drivers/clk/qcom/dispcc-sm6115.c @@ -48,8 +48,6 @@ static const struct pll_vco spark_vco[] = { /* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l = 0x28, - .alpha = 0x0, - .alpha_en_mask = BIT(24), .vco_val = 0x2 << 20, .vco_mask = GENMASK(21, 20), .main_output_mask = BIT(0),