From patchwork Wed Oct 23 15:26:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghavendra Rao Ananta X-Patchwork-Id: 13847284 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E988B1C232D for ; Wed, 23 Oct 2024 15:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729697205; cv=none; b=myX3dxKIYG6eNWWbRnOknL2hica7ATw4/ayFrzMIktIoEjGSse5YNjKKNht3T24IJ1TbRdSoi1j/qKkkK1Pdhn85VTegMxxbwg+coo66EryH8Tz9bytIINBTYmKJ8MJIfL9MrK719/Cnh8HSlQZFMyZVIlxSIXbkISSamwJNoKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729697205; c=relaxed/simple; bh=esQoNZuXsR24jwPl1DfQPAsmfQfBH1AfjOxCgQQxj50=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=I7Xk6w+pSxxoEQOZOJ7wJr3ccpXk2ZQ+yJt0VxHrIJI+3yfDH213WDas4H/bWH7ggRrIwIRSB+xREGwqAwaGl9HRM2ItVNMfa2209sGGmSkTLibat1xpn8LvhNb0/U9g4skW7cE8rqT4Sv48Z6UyXf/ARWEToNzBs8SFk6dBTxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--rananta.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UnptddTT; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--rananta.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UnptddTT" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e3529d80e5so120963547b3.0 for ; Wed, 23 Oct 2024 08:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729697203; x=1730302003; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=eTpDcLprhbUi5YHe62ZQ4u0o+/QxbhbJTnRiVU+yROI=; b=UnptddTTjSWKqFJpFHyGYMDGmM0jP/sK2gHpXfLQk7V82ed287fPn46FIkFrKgU7KY MMnroaaEM9/iQOZjHXpxquCaux9bLcCGyhEiThtZGCwT3JLkf7B7rmBEzzD1Q1cLYRvi DnkOsJrDo0oTzeVq/dB9btZxFejWLXrhHMDLVtgOCbw6OZD6yVnvHfe7PPUWBGdgCPVh EBstI9G9vgJ83GR5vklGiCH4o/gY+yKao/pgtxyMzw6u+S8lQwaBY2B69aXdlJ+PXZjP kWcFj8OGAb6zsbkBhLqupwZsOCwzcMtlopkkVRUr9Py0o8EfpIIISFPtBopxxHt0YzS1 jcIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729697203; x=1730302003; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eTpDcLprhbUi5YHe62ZQ4u0o+/QxbhbJTnRiVU+yROI=; b=rW32sshwo1652rPIrWes7mVdAe6zDe0orCL39g+NVSANj1vY21QzS5818XFqV05fFz 2So0e/HqWAEGQQrtfFp5lczhG1iwa8dCN2+iS3Th1xvn5Qz6DWztvDYlzaig7k0AjBy1 cJzXRKYOzOYS/o8qLZNlTjCGyCxzElEgqaIY/AfCCyiBNEgITKdxOqsCe0SJE2WSjfWV EZhC41m0nXxkGPQl47ybqZQ0Mfgv2e/8h0Xd97zyCW7TvFUHscOp93efRCkAi+c5Ar2b +zZDXHcyjAiB/NkrCmUtbmwwt0gknydeJ410giM/kRcZZZzssPBNn9hT/CTYaCu/u70U 6o+g== X-Forwarded-Encrypted: i=1; AJvYcCU5uggxgw0oBqf20p2YSA2vbetJmGMhLFvSkgSL+JmzsQpwUxhZjDpUFVVUyWLmaq4L1Bc=@vger.kernel.org X-Gm-Message-State: AOJu0YyvQE6YJfTqfKVfkxBRfwZ4kC25CZlxDI73cMTiKa1Jd13Lh2v/ dmpGU3KmZFsCdbZK2RPwYX5iItBLXSD6sMuPXjPVenljkUR5EG2TKdcg9TorYAGvre6GqLlqBAs DgEwkJw== X-Google-Smtp-Source: AGHT+IGyKD6tDsN1UOGbK0zHzy2EM8WTJ3RRqhXskaDYZzY4RpWhowWcPc5+5VKKdGJS9/5Go7f2MraDRssJ X-Received: from rananta-linux.c.googlers.com ([fda3:e722:ac3:cc00:11b:3898:ac11:fac1]) (user=rananta job=sendgmr) by 2002:a25:8e87:0:b0:e1d:912e:9350 with SMTP id 3f1490d57ef6-e2e3a6bc055mr2784276.6.1729697202285; Wed, 23 Oct 2024 08:26:42 -0700 (PDT) Date: Wed, 23 Oct 2024 15:26:35 +0000 In-Reply-To: <20241023152638.3317648-1-rananta@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241023152638.3317648-1-rananta@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Message-ID: <20241023152638.3317648-2-rananta@google.com> Subject: [kvm-unit-tests PATCH v2 1/4] arm: Fix clang error in sve_vl() From: Raghavendra Rao Ananta To: Subhasish Ghosh , Joey Gouly , Andrew Jones Cc: Oliver Upton , Marc Zyngier , Raghavendra Rao Anata , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Fix the following clang error in sve_vl(): In file included from arm/selftest.c:16: kvm-unit-tests/lib/asm/processor.h:163:16: error: value size does not match register size specified by the constraint and modifier [-Werror,-Wasm-operand-widths] : "=r" (vl)); ^ kvm-unit-tests/lib/asm/processor.h:162:14: note: use constraint modifier "w" "rdvl %0, #8" ^~ %w0 1 error generated. Fixes: d47d370c8f ("arm: Add test for FPU/SIMD context save/restore") Signed-off-by: Raghavendra Rao Ananta --- lib/arm64/asm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/arm64/asm/processor.h b/lib/arm64/asm/processor.h index b28d41fd..e261e74d 100644 --- a/lib/arm64/asm/processor.h +++ b/lib/arm64/asm/processor.h @@ -159,7 +159,7 @@ static inline int sve_vl(void) int vl; asm volatile(".arch_extension sve\n" - "rdvl %0, #8" + "rdvl %w0, #8" : "=r" (vl)); return vl; From patchwork Wed Oct 23 15:26:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghavendra Rao Ananta X-Patchwork-Id: 13847285 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C401E51D for ; Wed, 23 Oct 2024 15:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729697207; cv=none; b=dW/6I23KuPXBIkOjUGaAkyxOBzku1zUGS4+/WeYZ9+Xr3CJyRNBgGP+VxerDC0I2q8peBbxz5Md9Vf9IryKWTk+ZtDZvdHw23mvNn1LrfYMBfp5AreLQmVM4hmQRWnSAFCwe0WyIJN3T/FiRBWZJG65qCdrFZqlfQpLAeDjpIXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729697207; c=relaxed/simple; bh=3W9iajvimea6YrR9U732pMuKRx3PZLGRnnVS589DTvs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=LOIUQBF+f7p4ibqPBg8KIyM+HkQQLuO1gyHUgd3eMmp1LNrOuIfpbGHJsWSRIlDgwNmX/0nC5+PK6KMRCb5j/7OMaZKXeM++MJeeIC6DNdJc9bp5Z/S25bj1ULIsj5bCcoy89Nas5BCz7UDKb2AxU0oKBfjXQr3RZdW0kYfh9h4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--rananta.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=c5iJRAnV; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--rananta.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="c5iJRAnV" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e2bd09d2505so7277405276.2 for ; Wed, 23 Oct 2024 08:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729697204; x=1730302004; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fFBeTk/ypl/mbwDh0gs/JhAq5wRwgc/prGa+mqCvt5o=; b=c5iJRAnV3Fi4lYXeoXbKQPKWwovOzhYCc7sZo9bpxAhvPLbExgqWjK/KFIIiKQAuBU cls+xavghVNYuH1042htv/kbU2HgDQT07ozuJ6M3fFAdqT8s6OE7z+iLVixM5oGa8ADJ pIoRkf5fIbv1l7Ot/HWh36gR8vPw0b1kpmYi78aa+/ONsNBRXWe2gqwjWzX3Ov6ER02J WamC9Fuc/rTkgOqRjcLJIpbzoiBPXocjThvzeRKc8PeneZyreuX22clYk8US5MYuSxkB 97tKfUIQv1xo1BIWOm38vuPNnSzeWnsfa8y3wlrdt0jBfsu2NxeXsl+xKTGgbBRJlUlc OgxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729697204; x=1730302004; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fFBeTk/ypl/mbwDh0gs/JhAq5wRwgc/prGa+mqCvt5o=; b=en13Uu3du32cTX95RijS/fAXGMVqF0mOc4SHGef/TiEcYZHRNaQ6u13//ngW/tD5Oc KQnjBeLFULPnEdqRJkwobvt+9mPKIHZU6djoQzf3lV9eEEQBZMSzXMvXVbPxII//Pru7 O221i2PgFQoQiIkttcjj4l6Ie6ODm20QugKwIBVioyzc5cg3th84yMAcMQtTQ2YTmRAU JpBiEEERTsrm4ykIimZqdYo+9hviOZV9Nr3TU/UwQ1PsYDn2UMgGYxCO30zEtUK+KUOT salFnPrPnItsKvKRwpCSksWlROvUIcKa7Pwcn2YkI9klsenj/ehg9hxzwYcNZ2wgQ8zf E3cA== X-Forwarded-Encrypted: i=1; AJvYcCWmQ9i5h5t3yjqo5T7eHOTxS9jhLpgwk+CY1JlscNKJmT1+wGPpDTlirr3Egs8BF5rxWro=@vger.kernel.org X-Gm-Message-State: AOJu0YyQaxCLq3xtviM54rbSWSxW39UPRqha+FUkyOoitmqD45Tj05CE Eyb12lMXFuGRpcRuUm2PRkd8xz+yPfJboEBLQZGqHcNmJVnBZ41eziFMG48pf1WW1g+ZKbEN/ru oBVZxAw== X-Google-Smtp-Source: AGHT+IFh0UYQGtbCtvsET0xrrd1Y/kAJ4FbXvNEzhh8lcJJcZvj2pTt+HaP9rNqWRxjhbRVfontBWLjAHjHZ X-Received: from rananta-linux.c.googlers.com ([fda3:e722:ac3:cc00:11b:3898:ac11:fac1]) (user=rananta job=sendgmr) by 2002:a25:acce:0:b0:e28:8f62:e735 with SMTP id 3f1490d57ef6-e2e3a5f5d18mr1688276.1.1729697204137; Wed, 23 Oct 2024 08:26:44 -0700 (PDT) Date: Wed, 23 Oct 2024 15:26:36 +0000 In-Reply-To: <20241023152638.3317648-1-rananta@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241023152638.3317648-1-rananta@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Message-ID: <20241023152638.3317648-3-rananta@google.com> Subject: [kvm-unit-tests PATCH v2 2/4] arm: fpu: Convert 'q' registers to 'v' to satisfy clang From: Raghavendra Rao Ananta To: Subhasish Ghosh , Joey Gouly , Andrew Jones Cc: Oliver Upton , Marc Zyngier , Raghavendra Rao Anata , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Clang doesn't seem to support 'q' register notation in the clobbered list, and hence throws the following error: arm/fpu.c:235:3: error: unknown register name 'q0' in asm fpu_reg_read(outdata); ^ arm/fpu.c:59:10: note: expanded from macro 'fpu_reg_read' : "q0", "q1", "q2", "q3", \ ^ arm/fpu.c:281:3: error: unknown register name 'q0' in asm fpu_reg_write(*indata); ^ arm/fpu.c:92:10: note: expanded from macro 'fpu_reg_write' : "q0", "q1", "q2", "q3", \ ^ 2 errors generated. Hence, replace 'q' with 'v' registers for the clobbered list. Fixes: d47d370c8f ("arm: Add test for FPU/SIMD context save/restore") Signed-off-by: Raghavendra Rao Ananta --- arm/fpu.c | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/arm/fpu.c b/arm/fpu.c index edbd9a94..587b6ea3 100644 --- a/arm/fpu.c +++ b/arm/fpu.c @@ -56,16 +56,16 @@ static inline bool arch_collect_entropy(uint64_t *random) "stp q30, q31, [%0], #32\n\t" \ : "=r" (__val) \ : \ - : "q0", "q1", "q2", "q3", \ - "q4", "q5", "q6", "q7", \ - "q8", "q9", "q10", "q11", \ - "q12", "q13", "q14", \ - "q15", "q16", "q17", \ - "q18", "q19", "q20", \ - "q21", "q22", "q23", \ - "q24", "q25", "q26", \ - "q27", "q28", "q29", \ - "q30", "q31", "memory"); \ + : "v0", "v1", "v2", "v3", \ + "v4", "v5", "v6", "v7", \ + "v8", "v9", "v10", "v11", \ + "v12", "v13", "v14", \ + "v15", "v16", "v17", \ + "v18", "v19", "v20", \ + "v21", "v22", "v23", \ + "v24", "v25", "v26", \ + "v27", "v28", "v29", \ + "v30", "v31", "memory"); \ }) #define fpu_reg_write(val) \ @@ -89,16 +89,16 @@ do { \ "ldp q30, q31, [%0], #32\n\t" \ : \ : "r" (__val) \ - : "q0", "q1", "q2", "q3", \ - "q4", "q5", "q6", "q7", \ - "q8", "q9", "q10", "q11", \ - "q12", "q13", "q14", \ - "q15", "q16", "q17", \ - "q18", "q19", "q20", \ - "q21", "q22", "q23", \ - "q24", "q25", "q26", \ - "q27", "q28", "q29", \ - "q30", "q31", "memory"); \ + : "v0", "v1", "v2", "v3", \ + "v4", "v5", "v6", "v7", \ + "v8", "v9", "v10", "v11", \ + "v12", "v13", "v14", \ + "v15", "v16", "v17", \ + "v18", "v19", "v20", \ + "v21", "v22", "v23", \ + "v24", "v25", "v26", \ + "v27", "v28", "v29", \ + "v30", "v31", "memory"); \ } while (0) #ifdef CC_HAS_SVE From patchwork Wed Oct 23 15:26:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghavendra Rao Ananta X-Patchwork-Id: 13847286 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C3E91C8FB5 for ; Wed, 23 Oct 2024 15:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729697208; cv=none; b=W9l3AvEi2ZIYMExdnXvmDCBINPEP48N/g7jqDOrgKnOU3OZtw/iQF+1KTBsI2CYIFQqA480hEh/ywWl1fpTMfkexfYjunS4u0hHVjF+R+OlstGd9vf+EGm11j2ZVTfNbe6QOPeXX4JZVJpcmV6AtDf6+BQUBwrqTr6XZipIrt2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729697208; c=relaxed/simple; bh=sTMEe8hKVyhG4n3/J0S0bVeWZJkoFNBIjGAvrfLzml8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=OL9uMRDiGag1wyRPNBp9eAMlx26qJJxRuZIBWUCu2E4Dl8A7jK/8grnMzAVW2goAEOlqmwj25X8+jzCkPs+cuKjP82+3JuUmMjdTV1gVbXL5q0zRA5tmH2/g2IDk4uw6N8WM54vG20XXbpuhLQEYHBbKgaYWD6qYjVyH42uUcL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--rananta.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tEQDW2TP; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--rananta.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tEQDW2TP" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e35199eb2bso129953787b3.3 for ; Wed, 23 Oct 2024 08:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729697205; x=1730302005; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7NioyoNb1tbeyUGY4RlitjUeF9A4E3KRPhc6ahZCNVQ=; b=tEQDW2TP4aSlWq5iJGF0obfpW9K++suPbFYXR9gRcqeoXCNrINNmWcQAwiUErUHrhe EIQ4Q6L7hkC1Lpi1ZDYUr2jcNgeIENl8cX60FUD6uwSxaGGh6Q3sDyqoW5Ntl2LHT0ro 0FBr4Tkgmv4riw3M7uh54fA7Rwz/I3JdXpDkzmriMSnjFBEGYfC9z+NzykFXC5qRDh7s NvVt3bXraKyVCzUFpXelc73Q7EliBIJ+mzXCN5isJ1DqSdCzOntiawjk9NlN0LGoBGUs yCbqSTvwxPnKkpVWkNgJgnfpSsXkb1+5mxKivDQlPkLvXqorouaqK1yjThx5wdVBxZSR 3P/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729697205; x=1730302005; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7NioyoNb1tbeyUGY4RlitjUeF9A4E3KRPhc6ahZCNVQ=; b=B8zjfedPHcdVbPB3zLhF0YnGKrr4JeOriyQRAA1nNvjWhjKJHuKQsJY4Kcq9524Wv8 2nmbwK3yQCdI1wpmDKpo54jBEAx9eHcmbUmWEWokfAhDIAsCVAzCINyA1M9l00D53C9i KNZi6LLzMsJ1wN9dJhmGuUX2LsvN50D2sPdcepRdPT2/LYkblKleWx0fccmXz7U0/294 EL6WuOSvnNIwpV0gmgpCv8jYYLImZTWxv0eu4/j2S4LjRD6bWL6zjEtOR8h0/WWAQzKD gZAie0OVF2c2kDvStb2oynxAXn6gIiSvmhzNyr3n5wQ2HYCt0u2m/Jf56QiQoQovXZAl H4eQ== X-Forwarded-Encrypted: i=1; AJvYcCVTC7EmGs6/oJXZQW9/o3usniFlhU4Mat2S9qLmdgNFIQ5xuzcZHhQ52C/kQQT2AbrJ7gM=@vger.kernel.org X-Gm-Message-State: AOJu0YxDonuTO8c7MtaWf0i167ERqbG9PHLs4t19miHYcDmdPkVz8Th5 9/ghOrY/F7rGHkU3xmYkLnOlW1GcwPNU5eyjrgDV8BafnmIUdG9pNmObmXpaVAKqoalKN5EEQ6f zHXGrfw== X-Google-Smtp-Source: AGHT+IE9OyKSIQFj5g+9JOMt/US00gq7iSxNgRTSGWr8GfQo9rufdELdBzRinCot5ZkBU1YALlbhI9gWX/bZ X-Received: from rananta-linux.c.googlers.com ([fda3:e722:ac3:cc00:11b:3898:ac11:fac1]) (user=rananta job=sendgmr) by 2002:a5b:947:0:b0:e28:f454:7de5 with SMTP id 3f1490d57ef6-e2e3a6b78d6mr6103276.6.1729697205144; Wed, 23 Oct 2024 08:26:45 -0700 (PDT) Date: Wed, 23 Oct 2024 15:26:37 +0000 In-Reply-To: <20241023152638.3317648-1-rananta@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241023152638.3317648-1-rananta@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Message-ID: <20241023152638.3317648-4-rananta@google.com> Subject: [kvm-unit-tests PATCH v2 3/4] arm: fpu: Add '.arch_extension fp' to fpu macros From: Raghavendra Rao Ananta To: Subhasish Ghosh , Joey Gouly , Andrew Jones Cc: Oliver Upton , Marc Zyngier , Raghavendra Rao Anata , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Since the tests are built with '-mgeneral-regs-only', clang-18 tends to push 'q' registers out of the scope and hence, the following error is observed: arm/fpu.c:281:3: error: instruction requires: fp-armv8 281 | fpu_reg_write(*indata); | ^ arm/fpu.c:74:15: note: expanded from macro 'fpu_reg_write' 74 | asm volatile("ldp q0, q1, [%0], #32\n\t" \ | ^ :1:2: note: instantiated into assembly here 1 | ldp q0, q1, [x8], #32 | ^ Hence, explicitly add fp support where these registers are used. Reported-by: Andrew Jones Signed-off-by: Raghavendra Rao Ananta --- arm/fpu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arm/fpu.c b/arm/fpu.c index 587b6ea3..f327a349 100644 --- a/arm/fpu.c +++ b/arm/fpu.c @@ -38,7 +38,8 @@ static inline bool arch_collect_entropy(uint64_t *random) #define fpu_reg_read(val) \ ({ \ uint64_t *__val = (val); \ - asm volatile("stp q0, q1, [%0], #32\n\t" \ + asm volatile(".arch_extension fp\n" \ + "stp q0, q1, [%0], #32\n\t" \ "stp q2, q3, [%0], #32\n\t" \ "stp q4, q5, [%0], #32\n\t" \ "stp q6, q7, [%0], #32\n\t" \ @@ -71,7 +72,8 @@ static inline bool arch_collect_entropy(uint64_t *random) #define fpu_reg_write(val) \ do { \ uint64_t *__val = (val); \ - asm volatile("ldp q0, q1, [%0], #32\n\t" \ + asm volatile(".arch_extension fp\n" \ + "ldp q0, q1, [%0], #32\n\t" \ "ldp q2, q3, [%0], #32\n\t" \ "ldp q4, q5, [%0], #32\n\t" \ "ldp q6, q7, [%0], #32\n\t" \ From patchwork Wed Oct 23 15:26:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghavendra Rao Ananta X-Patchwork-Id: 13847287 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C838D1CACE8 for ; Wed, 23 Oct 2024 15:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729697209; cv=none; b=KvM/P7VkJb0OQpZEr/VXMf1s9PwXuoBlcM47MUuSpwAZ+/gwQuGlZGM7rvTWR5UbIP7bvnIW7lP0sVs8ns94EPYyqRUEMBZOqLZW7COmIAsxQ5mt3OLnGmyEdoGeVT40Jk5Nm1L4FCMuV3Jndi4DpZI90YN4DIeozvdu6uT0f5s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729697209; c=relaxed/simple; bh=B5fYkslRkwaBuwyV1YpAJJzIGleZ/3nKyW4XhZgaP44=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=mKlDnEmVVsY3eUZK+w2tmtFmRXhqETp1SpXtMybFkTQ0xNAuHd0JjISrTuUNwhAvemGuaRqYsc7q9TQkGKu5e5iiVhepwyWa1JcQtsA7bISCZtjrWNzmYbCphpdFu5G50Gbrb+Z5znHU+AIsRNCtYnsiO9QGsdd4YZAAS3Px0zU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--rananta.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u2ea6r3d; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--rananta.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u2ea6r3d" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e24a31ad88aso10082349276.1 for ; Wed, 23 Oct 2024 08:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729697207; x=1730302007; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=A2EE3sVxYqIJ1dH+QTH0uydlcXtt1ReqMB1Nu0t+juU=; b=u2ea6r3d2DUU5+bl/sZVLf2mxi4D/rLDtSW5oIpRnXZb/HE/6PCPVq9h2iNazmbHQt oXU8vIRfe5neBGFo32fAMSkNM0Mb17GrEAwcENC0Hl3j7pO6z012RFw+WuuJ3P4uS4+b WUEpkKYcOUd7u6KBgAfofZdt8skvAeLRlspJAmGEtZwXjh6WV6G6TwfupgDMdKTlw3ZJ +DljepbT8XN3emQglF5nQSPxF801+XKvQ/jXBNxwOBO9HVfrLTlbZmwfNtacsxTaPEwm 2JEpDGCi9PZGt0W/RfH/Ssk2Iv8TnZ4GEHAYxDKNTR8BH6O7LFVcO1qjzdPRkaD9cSOU F9Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729697207; x=1730302007; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A2EE3sVxYqIJ1dH+QTH0uydlcXtt1ReqMB1Nu0t+juU=; b=Gv1y7VWm5IAwQ2ZF1H3cu39anrd2toIm3OYhrIRRanl+HNm/xilmqQRrdL21v5iV0C kJ8OheoIkq70S2jZJdbGY3RNNDD6xIfUfbybZVbhLgLsoLH/t5N3Uw6ZGrG8wX275P8u 0IvGG9GsNUIzYFowdXTfT+WDp7bTYCk/EopXmT/RyF4r6ivtytppmYfrvSVG3SnXb5Zm +lot8nyuYeJLJSi8Pkzwnt6f+Q/X3RDahkCfFSyrkfPv48hF2oACawXc67xSH8IZhXMN fhMcR9A59kmGqSA6ke6pryu+/jjE6r0Jys7FYCWk5mphBaEtAZ3txS/vJ5cZSnLNYmF4 k3dg== X-Forwarded-Encrypted: i=1; AJvYcCW0xtP4AR+Osal/FEYZpATzwAgBcn3TQBiI9aCp5Yztv1N7GulzSOD1v3M5qNGed3IPgQs=@vger.kernel.org X-Gm-Message-State: AOJu0YypHQaD+Aqk/82DAFA+vxBPn/aS9YSMIeM/g/BcQcSFiCOnfiWn WF+Sk5bMpw7onD6M0IFPT0OzzoiP3CmwYWfwqUOer9SyYRYuYMvLgYvdi0g8yJ8ihYsfeMDc0gv 4AtJ3bw== X-Google-Smtp-Source: AGHT+IFIvoDWzY92c7Ql5MqDK4/LO8cFIPrnyxqxIgb86cVrW0eQyRyYu3QqngJF51cWPwSpHNgspMn0AOrE X-Received: from rananta-linux.c.googlers.com ([fda3:e722:ac3:cc00:11b:3898:ac11:fac1]) (user=rananta job=sendgmr) by 2002:a25:df45:0:b0:e28:e510:6ab1 with SMTP id 3f1490d57ef6-e2e3a6c91cemr1496276.8.1729697206388; Wed, 23 Oct 2024 08:26:46 -0700 (PDT) Date: Wed, 23 Oct 2024 15:26:38 +0000 In-Reply-To: <20241023152638.3317648-1-rananta@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241023152638.3317648-1-rananta@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Message-ID: <20241023152638.3317648-5-rananta@google.com> Subject: [kvm-unit-tests PATCH v2 4/4] arm: fpu: Fix the input/output args for inline asm in fpu.c From: Raghavendra Rao Ananta To: Subhasish Ghosh , Joey Gouly , Andrew Jones Cc: Oliver Upton , Marc Zyngier , Raghavendra Rao Anata , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org The macros fpu_reg_{read,write} post-increment the '__val' pointer register as a part of 'stp' and 'ldp' instructions. As a result, mark it with "+r" for the compiler to treat it as read-write operand. On the contrary, sve_reg_read() never updates the value of the pointer/register. Hence, mark this as "r" for the compiler to treat it as read-only operand. Without these adjustments, the compiler can potentially perform optimizations over the registers holding the pointers that could lead to data aborts. Fixes: d47d370c8f ("arm: Add test for FPU/SIMD context save/restore") Signed-off-by: Raghavendra Rao Ananta --- arm/fpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arm/fpu.c b/arm/fpu.c index f327a349..f44ed82a 100644 --- a/arm/fpu.c +++ b/arm/fpu.c @@ -55,7 +55,7 @@ static inline bool arch_collect_entropy(uint64_t *random) "stp q26, q27, [%0], #32\n\t" \ "stp q28, q29, [%0], #32\n\t" \ "stp q30, q31, [%0], #32\n\t" \ - : "=r" (__val) \ + : "+r" (__val) \ : \ : "v0", "v1", "v2", "v3", \ "v4", "v5", "v6", "v7", \ @@ -89,8 +89,8 @@ do { \ "ldp q26, q27, [%0], #32\n\t" \ "ldp q28, q29, [%0], #32\n\t" \ "ldp q30, q31, [%0], #32\n\t" \ + : "+r" (__val) \ : \ - : "r" (__val) \ : "v0", "v1", "v2", "v3", \ "v4", "v5", "v6", "v7", \ "v8", "v9", "v10", "v11", \ @@ -140,8 +140,8 @@ do { \ "str z29, [%0, #29, MUL VL]\n" \ "str z30, [%0, #30, MUL VL]\n" \ "str z31, [%0, #31, MUL VL]\n" \ - : "=r" (__val) \ : \ + : "r" (__val) \ : "z0", "z1", "z2", "z3", \ "z4", "z5", "z6", "z7", \ "z8", "z9", "z10", "z11", \ From patchwork Thu Oct 24 08:31:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 13848508 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A9418A6D9 for ; Thu, 24 Oct 2024 08:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729758679; cv=none; b=cpjEC2Y1CqOuAApCHUWuuN+QpgegSMwGkqfLziIH6e17a7xUXGlCCuYcfAnjcOtAJhqUVtYSccUKp1p+KaU+XmGxhgYaE3kTMUBOrH9nNXXIGIQGNSLcLRvvz0eC+isoiF/ww9Df/AJkkRYkiOeyF3hoS4IRVQec3+2M/P9/RvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729758679; c=relaxed/simple; bh=SLxGWY68OHG0AINM51aVgPJt6dLPEQxTn05PoCqvbZA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jDo6Y/16dQf9GWXM98YStrnrUZ3l99XyQWoLtf+YaWZ17K64iSC7zobUAh688RHur2zJqvBqZpnbPNg8cmOYa2ucmE8htKbB4OrWUPxCdm2oIxJCRBhNkbwHAGM+0efxQkbGTvzD+Nja8q3wxWBwdCY/xfLLTy+dShXd+Pk7j6c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wrG+2ELj; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wrG+2ELj" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729758670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjte7RtBn7FVljJYgwwoEgon3WN/ThmaGIVx5uuDnBE=; b=wrG+2ELjwwKYlj5fGMNSv9CBTqaOi9XQzss1ya4zurKvYKLDA2w9eohtYAl3zdcuVWEf5T WKQ/3Se94bzzj1HQfYBSR9fzytsJI+Q0Z9FQqiEWJ9SIObLRTWvzn7c5mJG6e9ePIfN16q Jtx1Vi46vDooxQYyCO3mReKR8Ws5UoU= From: Andrew Jones To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: rananta@google.com, pbonzini@redhat.com, thuth@redhat.com, subhasish.ghosh@arm.com, joey.gouly@arm.com, oliver.upton@linux.dev, maz@kernel.org Subject: [kvm-unit-tests PATCH 5/4] arm64: gitlab-ci: Add clang build tests Date: Thu, 24 Oct 2024 10:31:05 +0200 Message-ID: <20241024083104.44236-2-andrew.jones@linux.dev> In-Reply-To: <20241023152638.3317648-1-rananta@google.com> References: <20241023152638.3317648-1-rananta@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT Test building aarch64 with clang both with and without --enable-efi. Use in-tree building for one and out-of-tree building for the other to get more coverage there too. Signed-off-by: Andrew Jones --- .gitlab-ci.yml | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b7ad99870e5a..aa69ca594ba3 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -80,6 +80,52 @@ build-aarch64-efi-acpi: | tee results.txt - grep -q PASS results.txt && ! grep -q FAIL results.txt +build-aarch64-clang: + extends: .outoftree_template + script: + - dnf install -y qemu-system-aarch64 gcc-aarch64-linux-gnu clang + - mkdir build + - cd build + - ../configure --arch=arm64 --cc=clang --cflags='--target=aarch64' --cross-prefix=aarch64-linux-gnu- + - make -j2 + - ACCEL=tcg MAX_SMP=8 ./run_tests.sh + cache + debug-bp + debug-sstep + debug-wp + gicv2-active + gicv2-ipi + gicv2-mmio + gicv3-active + gicv3-ipi + its-introspection + its-trigger + pci-test + pmu-cycle-counter + pmu-event-counter-config + pmu-sw-incr + selftest-setup + selftest-smp + selftest-vectors-kernel + selftest-vectors-user + timer + | tee results.txt + - grep -q PASS results.txt && ! grep -q FAIL results.txt + +build-aarch64-clang-efi: + extends: .intree_template + script: + - dnf install -y edk2-aarch64 qemu-system-aarch64 gcc-aarch64-linux-gnu clang + - ./configure --arch=arm64 --cc=clang --cflags='--target=aarch64' --cross-prefix=aarch64-linux-gnu- --enable-efi --enable-efi-direct + - make -j2 + - ACCEL=tcg MAX_SMP=8 ./run_tests.sh + selftest-setup + selftest-smp + selftest-vectors-kernel + selftest-vectors-user + | tee results.txt + - grep -q PASS results.txt && ! grep -q FAIL results.txt + build-arm: extends: .outoftree_template script: