From patchwork Wed Oct 23 17:12:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13847658 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67558CFA452 for ; Wed, 23 Oct 2024 17:13:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F01A36B0099; Wed, 23 Oct 2024 13:13:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E63FE6B00A0; Wed, 23 Oct 2024 13:13:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDCF36B00A2; Wed, 23 Oct 2024 13:13:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A839F6B0099 for ; Wed, 23 Oct 2024 13:13:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0FB48AB308 for ; Wed, 23 Oct 2024 17:12:28 +0000 (UTC) X-FDA: 82705511070.17.EBFCD97 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2068.outbound.protection.outlook.com [40.107.95.68]) by imf08.hostedemail.com (Postfix) with ESMTP id 56BD4160029 for ; Wed, 23 Oct 2024 17:12:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=RQeu1mOv; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf08.hostedemail.com: domain of ziy@nvidia.com designates 40.107.95.68 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729703427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=zzcAyqu/MVxyI5pW9uS4cxtAvGQBBEfvUnoTPh/5le8=; b=nv+N4t00wPIVs7Vk+4J2LRVV+OfJzCV2jqiK1fAceboYr2zs1YZRB8bWJrwf8uNFkF5kNj 40WKO/0sELyfozhHIiCzGc9FxYUdK0duahUdCARV4J606UIffkgGhIttW4A/AeCX3Q7PDC QCEg1YRhSKsvB9RwvQjnwEEB77qHG6U= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729703427; a=rsa-sha256; cv=pass; b=f96FUwKVX5YFdB+dq5VhJBxUm33BsSwRHCF5h4JJpFWPj/2ZIaiQMmh+29UQ6D9JwtnizQ ZyThJJuJf21b8QKyQ8+ADE3xSsJWqD/nPhtc5qrVhIBDstLBI0pjkUik2fu8L/rR62bF6D ibgc8rqwS6Fe6mEVeu6EkX59mPVFYbA= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=RQeu1mOv; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf08.hostedemail.com: domain of ziy@nvidia.com designates 40.107.95.68 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DUyUjT3QRuqkbcRpkqia+pIEUmaCZVICMPMamqF1+8672lB0iUiI3FBJ2BoWAWC8Hh8hoSUrRxl9F+47AvTdawwdh9OLh/WVMUUe+B9JAqgtqmC932oX0v6+7GiN8LuswSPwVkMIK15Oph4QCMS4BQ7RQ2o5XQe1DCSpYQMlGZPqXkdokR9rARHQTCeT7iBDm49r/SQkK1DPToN/axg6oJV3B3Hx+os+XdwLc54pScMcQSsF6gE87bsQwcdwWsW1VCYFZGZW6SgwwTTlKZm6xNIojQYxqX/8FIfA+Ow81mBIK62wGajSx1dkQMCZ201QAIJcdDyn+hw7M9TKx0RAHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zzcAyqu/MVxyI5pW9uS4cxtAvGQBBEfvUnoTPh/5le8=; b=kskR23HULm1JtGAchubjFjIi266GZ9evIw8kICox6ScNon6wD3nPQ9OZdyIviVrBmykX5AIW2psOd0KMXDDgXEC3gVtTvrPK9VHuAQjUgUrw6urBXduseo/cnc2DKnYbTnM29QzD7au8A3o1AHihQGg3veSSrQFVeUtyxrh31Q4bNg9inbsmelBNgEk6RgaeySAldNHSQ/uANgcm2taDst2BR2W2ZUX/SXgGhGo/PhSr537xS9Ksey3QYlxUwKaQ2jTEk5NsJkB1E7G8syQ2Xbpg0tDEM2vGWK5vWi58I1EhW4Ziu9zRuIEgvwYGZSBYcwc4wnF+fFx+PG6p9DG2Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zzcAyqu/MVxyI5pW9uS4cxtAvGQBBEfvUnoTPh/5le8=; b=RQeu1mOvx94NdlWU/lPD3Xs/9lFypOQE9pgrDoZmmHYBG+10CKHq8KoqQO/V+IkGk/CoVWTPNpcipj855tx6PEDvBOFWjc8ya01YHag9mLyR6sv311nmXVAB9phdx9qGrZA7kmy1FSDvuJDr5mZTAyB6AoJLRjF2tAxghmoDylE0hYiFlH1QloR8HHwuWsoAIEqIlxczYMxPsJUCp279fNVamuBL+aat5Sx3pwIRQGIU6R7xGZOYJfokkMoeV/57lYlYRu/CaYkumeyPXFgNPUJH6yu23s18ZCeaiFmo5U6d9SjRS66VzcUeNingRYs5zMoi4pRrvVzzCAGPLAGjRw== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CY8PR12MB7171.namprd12.prod.outlook.com (2603:10b6:930:5c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.29; Wed, 23 Oct 2024 17:12:56 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%7]) with mapi id 15.20.8093.018; Wed, 23 Oct 2024 17:12:56 +0000 From: Zi Yan To: linux-mm@kvack.org, Andrew Morton Cc: usamaarif642@gmail.com, baohua@kernel.org, cerasuolodomenico@gmail.com, corbet@lwn.net, david@redhat.com, hannes@cmpxchg.org, kernel-team@meta.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, npache@redhat.com, riel@surriel.com, roman.gushchin@linux.dev, rppt@kernel.org, ryan.roberts@arm.com, ryncsn@gmail.com, shakeel.butt@linux.dev, willy@infradead.org, yuzhao@google.com, Zi Yan Subject: [PATCH] mm: avoid VM_BUG_ON when try to map an anon large folio to zero page. Date: Wed, 23 Oct 2024 13:12:36 -0400 Message-ID: <20241023171236.1122535-1-ziy@nvidia.com> X-Mailer: git-send-email 2.45.2 X-ClientProxiedBy: MN2PR15CA0025.namprd15.prod.outlook.com (2603:10b6:208:1b4::38) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CY8PR12MB7171:EE_ X-MS-Office365-Filtering-Correlation-Id: 09557070-1230-40db-0c31-08dcf385f04a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|7416014|1800799024; X-Microsoft-Antispam-Message-Info: wG9m4RyiH4FS+YoApwSCuUPk4G3D5fvn2u6ow1gULrqYYf4roy7XYLNgS7hAvLBULVbzN31KYnjOQU0QaIu0OHPf6PXXYDkkvjvuNx7cgEKrn8SjaQ2inVu3y3uJ7hH9AURaLYJRf5kzYPCBetS8gOmiM1M6BBDpF3QqD1MFsK2JJjcE19BAYLp5kZ3wxJj+1j7jQf3WDooxb10OKynpyWJFFLXNm0kwbb8YnBSMK+ZYWFR0VxwwWuDu/KMx4dde3Q4dEoIzM6nkUCzVuhtoStsHlcUoJQMVwaoF24QPqyYiJ81q/Epe5F2YyuCTFjeicqTwtvE0rB2PpRn1GLerBO1VtK9jOcGGkXqnJkJcJRwU/G1lQ1gBto46ocQn3eBF4Mu6t3r1i1oZulJhUO18sI73C3lavcr1kkhX/JntYPPpMp6xM/x5r2C0ADqoCFR0QPALLMTA8sSGK/5duktDMW8chG+g1PnqKLAWh8dxF3H8Gmii3hiv8HQ5iBPhI774jDRHW5dBEJScnLuTa4VahzOGxXyEBOjH88Znsl/jkua87T3wRTTrrdjptOnDb8adFWdB1pYfxvBrxltINJNJmnWycMyrm0MJvsvq2O0H71IjXFrX8Nyp+rRMSov+tiACbFQ39W2/f/PCASKGB35NcFEKx2JSHo+Zu/kJiW+SBLeUe7JNTvqTeG+6uiY0g3CwwHHJMWfiNzJFuaPO2REvNzvuH/MPWZVHsqmSyHJlWyqYQLD+5ySv8BmhlLMEzjKP5IbM8rbpuzyxd1jIsaxFsy9ARwo9iNbH5DfJZaar+RD1v3SZjXNSj2oJxtrsHNpha+89TS6RaN0tcZkf/j4NXbqSdrX5WuNje/pMlJzCSiNqDxyH9fmI/ik1yvLos4b076DTHE+8OIMOLkd+4SPkoIj1cwkagHygZD0ZEJbvCVXy5XoRR63nVbz6y659xa/tG3tPe7j7ce/jiE9xl6DsyaO4reXWPouAdoTKGWA5d8wYw5IuWA9m6zqJC7TZA+afKTPrR9q4bcU3HX8owYoTTDV2JOuXBo4098/wK44wOG2rphZiNnbg07pXoyLJKS+Ox8ovaiNLNJf93o8Gkq5wWQ+/0oAxuCFiIkpkARlSObLyiSZGip7b82UpXJfYBHpQKBAUEmcpUV3KAJzi2LjcwYgqNXweb5eRYcgK6Ldr9HC5+kEyK2RPoDxXm2mxwVRqFCl7Yj3yXXqKOyFP4rmieDspr8v6kevY1tmcPlfHiaGPUT4hgWmZyzKL9akdMfnlkQSIWExd8RaElFtMgPrRMbH8zYETF9s5YVL8ZNPngnfyH+xYkjJf6rbHfJfQ54e/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Yxuk/8TjGbelmvLPrYG2F2N5eFduVx9a5CMwkmZftB1QbipxE+OTPYST0RksBXNG1Qz1Vrg+iAE9sHw8i+4XyzEoHCYT62YH81j72lw8r/UmXKJK74V1kOVnDXiAId5egKcj74oYSl52DPq4cpE/0sImjMiK+c+QU2pqqDcXuQ5+Gf+OPaxweFa3cImGFYbPiSjK73Gakjda2cgpdERDzP51kWV412KzjWDgyH7el9DZuw471+wperPE/LFK8CzXzNh1oFqs4v3bsZFF7gD0TH50S8VwiEtfRsimTLajQaoHoUyj8yBC0KAPRnysv2iDE2BXiSQIKfiSi5xWc0eT8FfMuGdgGzqVoTg3gxMsfHoYyKUVcw6RaxetlqaLOCxYwUPAtO0BHe2Qun30U+8NdFDjElpPT6DXRBS5/pBhHvPs2XtTGe8KqwmSqgohOyWjY7oB58uQQOkEdm209q8sNUTPMfq+MeC6fTirJ7pxbFOZ3RV2WY6OvzqZlMrf3tvG33KDJY6Z6yhBQaVwOii/LhLXaG33bS1vPzCsh4RGjuOEUnfPfVT5NU6l7qp9dsat8u/Id2LC5YhAzEOPMoRjIycPixVo4CuGgyUZfwPe/f3ieFKLHhn6UIluW4xbh8ypJZWmRUAGv1CWB2iJ65z+t8owhF9I5vmpTWZZlPOCIbtFfimDckCBtG51MUpWCHqzdiow5vrA8+q45baQklN6nEndJbALko0xDlDuPVLT5P7u2y1MwlowhRWoGLxM4fswNJlYoYp9oA4onLteZa89QBnL6/cXG65L5eyxyp2pUd/sJ20eSNGpqG05AXc68EKZxTn6OnI66KiqPcnjc/mvwkpOHKmcYdtYNqM+K5V9r0peW77Cwu6JuRDxqNsTI4KE/hjF7aR5pEsQl7RhCq47Nngh0mj2081tqW43Ij2M0isoAei+jEDxnd1o1GJEQ7OUDusS9B0x/gTBYZvxYgfEWYySeg9zgmN9HwxKXPSmiioB06XdFjoRelArM9jk9vz0JuMFuO1FsAI+vMnJRp+IjJlgpFyRTdD8hNGbwcIn1YWZ70SFp2d9Qrhx/FoyHZ9+4SdTRdssiI77NJFUZlvItrx1621ssMEGQDctJnQfzwGnsBXT9Epv/i2OcCQCWlou2cjSOeB04iueXGMUsv1BwxrICzZh019TfVw8Jv5ikP3tW0vr1asDGsjA6m6iY90KZgedPawTjNKxswh00m2xDuKaWlM4Nm+AwMGofBujcfR2aA7Kj0jr5kLHsMUoelIo76nMaHIcXOW8lVqJJtYD27x/HAzM5aiBJYH5jVCkM8/M5cLXS/LED7VKqyE6NTYD/8iPuK2+a5+D29XtMRcWe8WncnCKSpGU3gM7y8f+HxAYLTBqzsIAvZEvWzoqSkCxe2n7gI6TNL3EECVJ4Uk4Lkwp9WYuG2Jb6NPE4kAO90tMpOrFTmhF2uMiHYwi4gMTcmsTMzNMMau2/ScU24h9lhm4tUjG0ToSJ0uZ8v16p/+q1pCtdAd1+9qnE+tJc85G0sogHTBiWs/EXvPTE9NkaqprLOb9OtuV7a+viyR+AoJvOnd/wrAFenXkbw3MJ86k X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09557070-1230-40db-0c31-08dcf385f04a X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2024 17:12:56.8566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VKVrlc/pZ+eqKH48fxfTAZO2zINNEAp7SjIhXDK2b5ft0maJ/GSjyZLmarR0IfLt X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7171 X-Stat-Signature: mums9ur5yisaqfdbycano79i5167bbbk X-Rspamd-Queue-Id: 56BD4160029 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729703568-824044 X-HE-Meta: U2FsdGVkX1/5gg/rmL+v4R4b0vZxAdn6/XI6CAOIQibVadMsVX/k3AT8iq7Wqe+zKI+PGWgpXcKv7nkyyy383iwBn6Tmgc1Ykp2O4NLe5AbcQUoX9ZExahXtWZ6L1wCjDkAoKy7Ddu868gWMMMjOQd8ciTDnemfDxaIZ/ZPWlwABsPdaI42mRntVvO+aS67mVkSq8csU5ykgtpLBzC/Xw53MMw6m6ybg/COyplqNxKOxiepgD6RywHX2Gyl/UpulmXvJIRq5VbVjXtRzleqKdgabXcL9mVfZqdoTOoVqYPiQYNZ0CiNohHpz1qXtx8yPCBnKFMMdjHj/LKflH8wNGIL4Zs7QtXnvoPsNCnTClyMYwC/UFVH7SI2in2iZCleMN6FgDlKU7ZeMqB6ID84PJ4CVfKXC+0+T3coC4WSpWtOjXycnWSRzRW5wb29hwt0+8VqRQ4BRhsS1t8xoIrIKeO2I8NXdqak3PwnB5XsPG7jYD8f3Zb8hTIvW2/aLQ0vRr9aRpjG04xz4vyd2tDxjiE2MhAc6h4px4I+kfGwIzOGchx1RwDeYvSd+QGDntXABdGEcHc20zmf2Vov5jW1rtVq8bBCFqR7H19CkYH2ho1OZYPV3+8oP3Kcg6Saq6PTsmEPkIQ155gEi4C/89NM6GApVlNh4UDUgQNz2ka0biU/4M9AOknOTakrqa09FMyCHtTHhEfWBKhiaAKVDjR+Otwjug06V73w7Zn3UVq5Zk1jJiedwm4X2O7j0Cjxy9tJ+efuYXlZ1GU1XsSKgmG57vIMQHMqEhDcjuGRPWBEOcXHskHy7pPoapcMCsY7esDBZIJeg98LJ24eW58owvY9gUXHJsv0R6TfsQG+30a2qN+AV/n5Iro94VmkPFkkIhjLczWNFkW4WjadKPH9KUVfiXRbAWua+/Sf5iHmiMG3F8FRy/FmkcdgkDPsreIRZpClRkwvXpPmH1DQba2HP4d5 2V4AF9e7 cdFzNIhDfnNqRu0UTTUJQOQNz85K+AAvD73eY3k/kjThvSX/c5DT4akS361tc9bi+eBBRgP2HHSWVxuyfNUke0T2vEa9CUYXDuH++V+p9OwQzMAlcEISryAxmA8OVHNBOgSA/8Z07OFm/uo0E2Klb8nXqEazScfqYyqP2w7siB/UOxyh+ucgUe4W4kZ8t6fl15nPMTaDXFgNOy7tM94ZcCa/meF8N3y+dJcSRvFEjOe3fkdyqL4AcQ0GaIwgWSlXA1DGnG/aytrHxzjYhR5sedtoOyhRKci0PpeLapzUKMbkI2PrcdRmLLjIrKD3bZ6FoiRxlbS6mIZ5utusSNyRkMoWyXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: An anonymous large folio can be split into non order-0 folios, try_to_map_unused_to_zeropage() should not VM_BUG_ON compound pages but just return false. This fixes the crash when splitting anonymous large folios to non order-0 folios. Fixes: b1f202060afe ("mm: remap unused subpages to shared zeropage when splitting isolated thp") Signed-off-by: Zi Yan Acked-by: David Hildenbrand Acked-by: Usama Arif --- mm/migrate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index e950fd62607f..7ffdbe078aa7 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -206,7 +206,8 @@ static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw, pte_t newpte; void *addr; - VM_BUG_ON_PAGE(PageCompound(page), page); + if (PageCompound(page)) + return false; VM_BUG_ON_PAGE(!PageAnon(page), page); VM_BUG_ON_PAGE(!PageLocked(page), page); VM_BUG_ON_PAGE(pte_present(*pvmw->pte), page);