From patchwork Thu Oct 24 06:13:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 188F9D0BB61 for ; Thu, 24 Oct 2024 06:13:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DB9210E1F1; Thu, 24 Oct 2024 06:13:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="nAmPt8U9"; dkim-atps=neutral Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB18110E1F1 for ; Thu, 24 Oct 2024 06:13:56 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6e3705b2883so11402417b3.3 for ; Wed, 23 Oct 2024 23:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750436; x=1730355236; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=nAmPt8U9d8sCyHWUN3yxfD4Sy94ki7EFFsrEzrB4+WmNTlJuPWYgIkuPB2vzyN8PUJ fBgmeKSQX8MCSTmwUt9FqB6NkQONjQShm8giskDzjW8Ww8vq5zyddSct0MrRFvj0z8iY +Q82VHcoVkDavhhlB87g6KyFR5ooOppJlG/PguxbUvCV/oJ85a04XyM115rv7h80QUwh 9bB68uWnAcPzm/wacRCSBWQTqGGfR0g9oRlBbQhz5qIN1JeGS9ORaksAEVrYKd1rdWlA Tj0oABXT2qJbyDSoAOPo/5or8XAikoMm431kNsKpPzrGnQL8siIaSN7bcUN1L1ftkjnB /w+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750436; x=1730355236; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=vNPuI+QeCMaGAHw8OU5zEHGL5yRjz7p7p7YocIAhS2wY3UsPjhpchDjN8onUuvQQoI ZH2AB+zN/+xE2VUvTOSnhLNr8fQG9OIgEt6u7kYLtt2adM1ifW0rMIY7JZC5LFXP8HXI qNS9z2gHB1BA5Pqyfy5AB9Hzpev01AjjlhwTXV2kkWYa98zmivbikkPXA5tdPdfB7jkU RDfG3+GcBE3S/JDitq0UMJRXKZr42CX7B1PAZGLW0Qec19XCgrhX1fBNmwnwbNlrvl8P c0BUQ/PmiQBs18DWDtMkyEayS0GJIM5hWmyHxR2WgFeisWRNliLNgjmsO79btXwJhVOx IoVg== X-Forwarded-Encrypted: i=1; AJvYcCVV9eePuAimKz3t7+iQnjQqwoSpk/BZ1auF5wFVxifvXS3Rqtj71u99hSFVmYuL0sTaQeRa2t78b1A=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yzna8IuY+GYCViTxnZGs7p0MohXC84HmtwHik4hKA+onTs3Rqnj 3T5z5lUXeqVQ/8ji1Rw8FFDIQzQs+6SDTgYsQ9b3Hy8tQqBsEPIO5ITMws8jayyBqMEr8nrQpgT Seg2aj/E+VLeCoQ== X-Google-Smtp-Source: AGHT+IHCEMkQ2RfyYdNtjaLmn7Q1IV6vv3d2IoDuURVXiH0KtdFNDJTv0BNk9TxANKxuJUTxCoodn7NIA1qQz7g= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:6811:b0:6e3:19d7:382a with SMTP id 00721157ae682-6e85813d7f5mr589267b3.1.1729750435897; Wed, 23 Oct 2024 23:13:55 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:42 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-2-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 1/3] drm: display: Set fwnode for aux bus devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0 Reported-by: "Nícolas F. R. A. Prado" Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ Tested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan Reviewed-by: Thierry Reding Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_aux_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_aux_bus.c b/drivers/gpu/drm/display/drm_dp_aux_bus.c index d810529ebfb6..ec7eac6b595f 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_bus.c +++ b/drivers/gpu/drm/display/drm_dp_aux_bus.c @@ -292,7 +292,7 @@ int of_dp_aux_populate_bus(struct drm_dp_aux *aux, aux_ep->dev.parent = aux->dev; aux_ep->dev.bus = &dp_aux_bus_type; aux_ep->dev.type = &dp_aux_device_type_type; - aux_ep->dev.of_node = of_node_get(np); + device_set_node(&aux_ep->dev, of_fwnode_handle(of_node_get(np))); dev_set_name(&aux_ep->dev, "aux-%s", dev_name(aux->dev)); ret = device_register(&aux_ep->dev); From patchwork Thu Oct 24 06:13:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848340 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83A05D0BB61 for ; Thu, 24 Oct 2024 06:14:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D037310E8AD; Thu, 24 Oct 2024 06:14:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="Bq2PjO9c"; dkim-atps=neutral Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F20610E8AD for ; Thu, 24 Oct 2024 06:14:01 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e59dc7df64so7436197b3.1 for ; Wed, 23 Oct 2024 23:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750441; x=1730355241; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=Bq2PjO9cjUx5A6dfWyYLUf3VZN+iMJ59VMcwegEKR7LGUwAfRGNRxC+gx5kQf9o90n PLXJUAWNAdO966A9j1IN2E19FYQchoLXTKKHtnTn9zI9kqKBl6/Y864wB+JLQISYZ9hS RK9YYohq/f0e7Vs0nSUKR927n7mDR6cueRG7aXkzZotBg2VAplpi0zIf15WQI8o4mV/L 9YaJPXW7tSJcNR3VnMyEHS/x17NB3ZGb96FZJd4ZpXGhL5e72X2J5hVEvBc/U4oig7T0 dp7812a8Xp73ovJna7JxcX8+06+gojstwCXNy/E3wv7YEGYH06Jp9BlZO8aymtjXKWSx aI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750441; x=1730355241; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=e2oinT+v4qwtliUbPxXP6fed9rG4yZx0q4O+2E+oDsUpHR5PeHsY3rJyFm6lCXFCVl jxRnvK7XWLERSSWLXYHADU003vABiPm/bf0tf9OZ5InlB1fcyzpiYjaTbTPKz3EWy80m 6FDyC1j2SlYgVJFb9ZARwdiCVOjpNeu0AptVd9rZETMNIoIe2HMc7G4fdOxyBbQRpPDn zvBXGc4sM6BGrlG4/KH2xGyoO7fgHW8NeP4+ZaTE6/c+er49KQWtLlMf9z60hZUawpeD /Wj7iY4DQO5G0a5DU11GakpPVy1tubays8haF5jmuLIrzJtDHSTIio8OYGVQG4q0Yq2z RETA== X-Forwarded-Encrypted: i=1; AJvYcCWfvB+Ri5cJoirurMbiRMWMddCd5m2C1J6O6SMoG7z2Jqc0Jf7VDHVJwzWMU24dvhQeDVp6tSYcDDs=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxLhI80XvRQvjpWaJ1v0JcL/FpMrQ+XxW6Sp6irbofduXrnGR4A y9xGpdXaeBj2g5kkhFVHKOr9DTYIob3UHiapI+wWuWcwlOT7+z3guWWWKjRPjO4rpsAI/WQ495X 76pfrQ4VJZlOiaw== X-Google-Smtp-Source: AGHT+IEvWKI797qzaVIyJQytUKUTuDrxqDTilc69F1bH77+J3k5wYMBvLRY6cYuzVgsPwwCo2eftygSjpmQuXoI= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:9c06:b0:6e3:c4cb:689b with SMTP id 00721157ae682-6e866350bbfmr483267b3.4.1729750440665; Wed, 23 Oct 2024 23:14:00 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:43 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-3-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 2/3] phy: tegra: xusb: Set fwnode for xusb port devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Tested-by: Jon Hunter Suggested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan Acked-by: Thierry Reding --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index cfdb54b6070a..0a2096085971 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -543,7 +543,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, device_initialize(&port->dev); port->dev.type = &tegra_xusb_port_type; - port->dev.of_node = of_node_get(np); + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); port->dev.parent = padctl->dev; err = dev_set_name(&port->dev, "%s-%u", name, index); From patchwork Thu Oct 24 06:13:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 821FAD0BB61 for ; Thu, 24 Oct 2024 06:14:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D2BD10E8B0; Thu, 24 Oct 2024 06:14:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="4K73Q4Kx"; dkim-atps=neutral Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by gabe.freedesktop.org (Postfix) with ESMTPS id DECF410E8B0 for ; Thu, 24 Oct 2024 06:14:06 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e376aa4586so10678887b3.1 for ; Wed, 23 Oct 2024 23:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750446; x=1730355246; darn=lists.freedesktop.org; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=4K73Q4KxiNenV+nB4z4ga/3/8hUvtDbe7p94/AiSrBWpfKwKw0V2FEMXDISc5vLXBP pelvMsZUvDtMjWQRiTMEvE5RUgYJZhvd+UegcvDtZRSmwmcHfcuRduH9wKtjzmeP6PQI wGFS57i0V4bh9B6heo/8UbaI33NJCLntHfMSYTz6/r+KigtScVxNqlW/9ZTjMuTNLB0O 1080eBiZGxxx++P54fhyUpSldUl0I/4lJE5MCbR5z+9tqePZXuCakAahLNtmLcU9U4Oq CR+Z0NJkPc5ygJOEe54W5E7jXHZSWHZ7wZQk2U8mlbH/ApZcVP2X/xwfHTZKnFVDX909 1Mqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750446; x=1730355246; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=shPFOLGr0zsFSujFv/0c7xAAVtLh5+LgN6aNagU05ebT4dZ5k/favuV72XxasN5J4e Hwvyaw6AqzYVlv1MyEF5LGJce6Q+AMdbGFPJ68e4RW/ZT+zvlHNjLmkVdwjlvkQTALyx LY9kkXlswSzISOAHKITQwJphc84N/lrCll/uqLq4ZrQppXKW6EK1RFPsxXlb55iygJlN mnppPxBA5kIsjOpL4/9Pl2riCYsgfK5ZG1ka3/94P9DJ4QB6ichHluwzKv/c7voYPFUV lelAIqT77jFhGSm1UMQLK9Q3eg8ReIR8m8m+0bN0nxomfdv/CQPmWiKUs3OtKWTsRUS9 bACg== X-Forwarded-Encrypted: i=1; AJvYcCX9ZXfdM3ywqxkwGt+hJ8Un0VeWWZO7DtXLXiq73s4Yqz8z6cHzbdsE+l2iUXEVMr6MwnGRKIB0tkg=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxFTxspKpjjafqReC++iLCU/3P59cYcVYsJh7cADZXSKwncWGE1 QfjuNnxfHS4WTiYBru6fGTdsClJGDE93jqcnsksJG6thg5PMztsCmqJkxjCatEZFZh0C4HTLEJE 8aCdkeKQMawRsVg== X-Google-Smtp-Source: AGHT+IEJXaAAeZpuDAkTsefFXLL2kex4B2AlfwjdclQcvPn636A6m5nX8BurNhgR4ykV7U+QaaWd5sb2nHuey3k= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:3749:b0:6e2:4b3:ee22 with SMTP id 00721157ae682-6e866359b6fmr171667b3.6.1729750445961; Wed, 23 Oct 2024 23:14:05 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:44 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-4-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 3/3] drivers: core: fw_devlink: Make the error message a bit more useful From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It would make it easier to debugs issues similar to the ones reported[1][2] recently where some devices didn't have the fwnode set. [1] - https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ [2] - https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Signed-off-by: Saravana Kannan --- drivers/base/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index a4c853411a6b..3b13fed1c3e3 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2181,8 +2181,8 @@ static int fw_devlink_create_devlink(struct device *con, } if (con != sup_dev && !device_link_add(con, sup_dev, flags)) { - dev_err(con, "Failed to create device link (0x%x) with %s\n", - flags, dev_name(sup_dev)); + dev_err(con, "Failed to create device link (0x%x) with supplier %s for %pfwf\n", + flags, dev_name(sup_dev), link->consumer); ret = -EINVAL; }