From patchwork Fri Nov 1 21:04:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13859766 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2051.outbound.protection.outlook.com [40.107.21.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 600E11E2606 for ; Fri, 1 Nov 2024 21:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730495107; cv=fail; b=tzl6Et5GXzWQhnPY0XRlut3NphXzmBE8NZxH3tXA3nHZ9WLBxSymgKggGg89ErJ37u3YrBxxoAKPoX9Dq12NK9D0Ct3CSHVF+r4OYDiQiDliF52mVMd4SfVjuZ++NHYrUoDrpczKFgcJEN/MALzOnRod6hgfar0zJLt3/11aGLU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730495107; c=relaxed/simple; bh=rJIqxvluRC/yMOR5R9EHOlh7W/U5VF9REJtvm0zbl1o=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=XUg3HhfwOT89gjwOcfjjRszFzyy2J92H5X1cWjyRfdDjDUcbyeUqOtHCNZ0tZCRBwydneSZ5jVQ8MrPUyjlgdRu5E0AV1CD2gS7Jquv/T9J/pCk3Hv1PWJOz/FoGHojpS8zrYJlGRhxVpwwzVeqoBpYRbOuu6AR2VnvpJOWqVag= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=AzWYrHVP; arc=fail smtp.client-ip=40.107.21.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="AzWYrHVP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RpsN5UwMQVpd2auImlR5HpYcdkS89MdoEuFLjK8E/2RF24ozhf4deZM5uYRPsvWdFIVgUD0493qokCcEW8Q4Mv2mgi4yFENp9HHsXFhgHOr2T/aBunJLPSqZ2We6+afXYsno7oxbLbmmkdQ6M0NVnOXxPL+0hzaq9S4O5q6chk6ALmI3+UtjIJhJNfVM5Nmx2s05tjpe3CtMm9IZyAZWEr8voXOOQ5qhE4efTEUrRp+yhUY1hy/gF87McxRFbGPmcQa1El9Wd1sC5NNW+kq0oIEOktT1dqSLOlfur9yj0dLUGgPQYRktUGghS1AUkXGoeCKfYW6u4nGSj2ugm/SISg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rgZfvPdpXTDMFhwi/+fS6tJCSsYlh0cHbpKlPxzHmSU=; b=Z/PRm1Zt7f4VwjbH62PcQJuoOXOFKvvT/guMOJkgAZaP9LNXzebiVqPxvWh2T1aC+OdTwX8sheOqrdMiCehiExm+xv5vSffykhQ0EaamdxQYa4yXDA5Fh4rxV01vGm9XoLN5o5lnXlXz0Gytwk2xes35w3mP1D2T9v9yLUnT3rlSIWYceSN+VyruaTqensOq17DDF+xQvCIAF4pJSnSOWe1sNBsY5+eaH8/x8GgfcO3MtayzKVDS1eUhkPxXaBoI54OyTRq6gdf5C/l7qExAllmNez/zKgt8fNMp4nOx58fdC0DMlpeDj/kSMk8ygCGnFJh8htOF4KSEgNjOGObHlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rgZfvPdpXTDMFhwi/+fS6tJCSsYlh0cHbpKlPxzHmSU=; b=AzWYrHVPO9jwo+DEMwHsJT6JGOgtWgoGtM5Wx+T/12Ccpp9Pxvqty3Gtyd1IVlFRpVUPTbdjMwT2FQkgWI9SbmqMKfDJIFPWX5K7/4oIWkvUl9nT8iRVn09JQ7ibs2KjHLSr8zd5nj1pT57C37j4LfCib/dcdGkiWoMavHn4Egy+i5lUdSIPy8NP2Xfqz7H860kcXayxrzXCSj8stkASKZkecegNtxzWGLBHyzRnCwMhWwcnI1w5e4X8PLaWZTNe8ClfS02COEiz2DhkxJVJ1mxndZB8CvU9/t1jemnDOW54bzTPYOn686e2ZoAAjcAWA2LOrkqD6FGjb4swHPivtQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PA1PR04MB10502.eurprd04.prod.outlook.com (2603:10a6:102:44f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.24; Fri, 1 Nov 2024 21:05:02 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8093.027; Fri, 1 Nov 2024 21:05:02 +0000 From: Frank Li Date: Fri, 01 Nov 2024 17:04:39 -0400 Subject: [PATCH v4 1/2] PCI: Add enable_device() and disable_device() callbacks for bridges Message-Id: <20241101-imx95_lut-v4-1-0fdf9a2fe754@nxp.com> References: <20241101-imx95_lut-v4-0-0fdf9a2fe754@nxp.com> In-Reply-To: <20241101-imx95_lut-v4-0-0fdf9a2fe754@nxp.com> To: Bjorn Helgaas , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Frank.li@nxp.com, alyssa@rosenzweig.io, bpf@vger.kernel.org, broonie@kernel.org, jgg@ziepe.ca, joro@8bytes.org, l.stach@pengutronix.de, lgirdwood@gmail.com, maz@kernel.org, p.zabel@pengutronix.de, robin.murphy@arm.com, will@kernel.org, Robin Murphy , Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1730495090; l=3777; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=rJIqxvluRC/yMOR5R9EHOlh7W/U5VF9REJtvm0zbl1o=; b=pmY+M7aJ3wCP5C5dh8LDONwupDZUwfyckIugCkGGv6I/UrbabCgqsTxrlxV//qW3N7sqPIpOa pSbqeXRj7cfCm0AKXcyRewJeUFbp1iHuhqZTB52oA1r4CaoezDIBVP7 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0092.namprd13.prod.outlook.com (2603:10b6:a03:2c5::7) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PA1PR04MB10502:EE_ X-MS-Office365-Filtering-Correlation-Id: b2ca22a4-4fa8-41bb-c1de-08dcfab8da5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|376014|1800799024|7416014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?28jfwpibjBnoqWjyFpRbY5ID4TkFgj6?= =?utf-8?q?IVIaPXUN5LOvtMr9bz9vUr2efb3/sfyIlXMBzpBbdHkrcIYPb70zFWjXzOThoDagb?= =?utf-8?q?fERvbvj9xkxBiWgIQJMcyjdysk3SbpxMirlGj1BB2aopGrtjQ5ACaUjOkdZv+xCtw?= =?utf-8?q?7R5eXLKzYz1yp2ddDxZJM6eEk/URn7qvXfevLfL4ZlhBumS6MRcIBiw34SrIaJgPL?= =?utf-8?q?Zbc6c2688qvpUqP5oKNxKdob2S8AeuQt319xBt3iIurN+9LAl76KdUMKEDONe0e2m?= =?utf-8?q?cRB0KPWm7Io4aH3zZLolyNRXoOHtbei8H2bkWk0MniETL03OcDy5soG3Ki3aMsHPd?= =?utf-8?q?2WLGSo1vAuh4XwDOe27G9kZdndsFgF88DgiKd9lr7e3u2M01V56i61ozdWxsHHKAh?= =?utf-8?q?vVtpqRJiO0VejZ0mb87dnpuPsyOdgFGhpn4GxhohWHnsI0rLYwdKG3TK7gPmYCpMK?= =?utf-8?q?j9v9KXD3uAnYlXijobui8V0uHld/L4XrbbUWU4pFwDwGjbdf+ZlfvF/AwZ1fyZeyS?= =?utf-8?q?e+PBIcFSS4civjSCWxO/X9S3+GW6XVfXWUOVK0km2PlASBPB179I7cQJ+jqepc9dB?= =?utf-8?q?Bn4x1C5FgGrbWVZdM4jzvSps/cyu37aM2DfgtuD6AmTj3naQAbJVVEDBA0FhJeCxQ?= =?utf-8?q?E7eGnF+sRouEZU1T9NZ6XMuTinOJjfXiWnsozkphaDiBFMPPUVxkHP0a+/Px+KrFG?= =?utf-8?q?RcQpJjv9+/lDh5AFiisooPdnC3uiOo29O7EGWUyQhlCxpOOgfMi4K3azaKwXRc82V?= =?utf-8?q?ttFMciApLiRIrByTpHAOTV0a1XhOQB6fm69ZanWg3aqGahHhpNxDwn0kzK4/qh3lS?= =?utf-8?q?7r5iwXWiIcDkTxgFRwy0rI2VVbYqeKM6arCowWx8bCwDQ7MDxascDSpeHmL4aGFV+?= =?utf-8?q?J4ArMLWEBd2I3a/zvJP2sm536D6BIl76JMLhxz21OmQymfJvDPfy+iGKhRUV2Es77?= =?utf-8?q?dwTKMcyv48vq4dLgvy+nCd2k1kicsm8RXdmeqiM0CQLKL/dtjoFLRCsuECOFK5fjv?= =?utf-8?q?C3+1NknKf/AmCyNsxpBLx2VQ0pSn4S0cUXzjNoUlP4XNu1QemNrdfwAnwfUD8YqNw?= =?utf-8?q?R+Kckq1lUEGcdHX70PMtIuenTqkCooNUHLXYBCg8II5Yob5ovC5kgpY3x2aBK+EL7?= =?utf-8?q?67CCsLEM2SUmtGbuTqsk1zs198/ueiL0sF3jSi/72CFYueptz/RVPgWRc03IHZab1?= =?utf-8?q?hsdjgznhO7FYTbM2d/lkZPuzDwUBYyB9JPG9iDBbQSAUgAcsuw5kF3TWNfFW0STC5?= =?utf-8?q?j4vjL9BZC0T/9we+Y+ks++DoPay6BIq3KSkdcOfQ0DqB8MiTRbeMezlb5OQZgWLt1?= =?utf-8?q?edIWIsijt3bn?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(376014)(1800799024)(7416014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Cb7owNJYtP4wpTVCUhbvBBidkkh2?= =?utf-8?q?9kbn6/eQR9UzBPuJTQppsAWs2K6XkmDJXJCsZWfNHTm34TU73oE5bLtA5DPEA8r4D?= =?utf-8?q?rZor5ZLDERg/o3pWptD5R/DkwUaKg1p6P7GBdmXhfhM1Ei6lzp0tVfEHrK26JOoV3?= =?utf-8?q?kzlatbCmS0HHQc73iiyPmhkX4SHtzss2SZXocFaiB9VdnbBXJZNWjU4hqWN7lZYFN?= =?utf-8?q?iCEwhbXp0enr8WX1UK2xOWOuPCP83fHv2MAqDU/8CjaYzagMvR5kURnM0sARmMgS+?= =?utf-8?q?MVcxDAUgJLAzdp4cpQoB4+obtFx9aW+55KvNjl60pay/nzO/PCC2jCkdrQrcLTSLg?= =?utf-8?q?ZFdrDHLqHa+90tbNlwU7nWRAjYdHh1x13oaEaMX4eDEFaRqvuLo/YzcVMvGWpt0UA?= =?utf-8?q?HHSjRNUmFlwoFxpLSW6Y9ZsLZXdlNvmYeU4ufmPEAv+GP9qPMKWCpthMyHIznYfi/?= =?utf-8?q?pXzl5oI6APJI6qJ7oT2cMsjJ4SiVPuRvmLBfXas6FBR6cH1O+gvL8heEowF+FuenA?= =?utf-8?q?QTwc/328qK7ynp3ZU0FgjzMi3haZwl15I0uNGsPUZxvZOYyVy0a/mH5GO4Cm+HWGx?= =?utf-8?q?yog2S6c4JGNej0EaglfF4NJ5TtyDs47M09w6u6dJEcHQ5xtX1cSl4ySDHAHW1aEtf?= =?utf-8?q?jE4pUiR8P6PB+lvzsGMCjEWcgNxOSxpB0ZIo3i7NRKpFLkAyn1higH6+ZxSLXeYh6?= =?utf-8?q?fRllwu9j1GDjZzJ5INeFdILloj2N2SXZ1LuAYhZYq/GX4iYs77Wj9eL7Cfh3YkpfD?= =?utf-8?q?HY3AMnhRFKNe5YpGImt57EudobYYOK7FlBOCsaWmOcV22Jepv0UOxqoYP9EqILANQ?= =?utf-8?q?/WFVa1uSssL51Rteyc2bdfdNHyn17m8+US7p0Q/JVW1XpKz30keHbftgeVtizvptr?= =?utf-8?q?D7QFhStC/aiatsRyTwcxzSII7v76s76IUKvDScnAZcxbCwcSPzspJFO4kKyTj2Ht3?= =?utf-8?q?QoHnbL6qq3d9M7cIzJnRddnTfv17ckLzToKjRfPPSBigi23WpoTZax7uaMSc7lnZs?= =?utf-8?q?ta814Pii7LoCpO+parYmYBavZxqg67m5QdQwTOX9MGxqJgIWVt0xaLznHNYgUV2YN?= =?utf-8?q?8Om1AKnu92USw6/NuAq30L3sdC24piSxrmUHwMNf0L30iH0o2uyjVDVeG9xPK0kyQ?= =?utf-8?q?O7GFp4l0ZIxqPkWgbVFPoYN07GkC+/PNiJ05iih70MToDthI3dim2Zu8UEri/yFbq?= =?utf-8?q?RebLFWD2yEpU64R3wn2DivLs/jsRISJtQm5XQ4xl/nBGxZEYcBrQITeQKR2cNnDVI?= =?utf-8?q?pgMusMYtsAeajneE5p4ft1+aFgPYzuehJH2jQxastaS0T4lMOnDwKzKXGA7Hcy7oE?= =?utf-8?q?I2N78OeD/8ehX6v3FjytHp9PQ967oPmvMNdyzw3tvSKEXWGiepZHzh1dOPpBYAX8p?= =?utf-8?q?Js1vYRcNnzKooQqN9FHXukjReut6X86BEHWQuLiKV/BGCxTqzgFd+SXPh+CJQPFZD?= =?utf-8?q?XxHvYdU+KTyrUD68uVnWwBCEvbWgI1G7Nn4LWIpDliw+vHeKrlgOrzK8iUwiz9B0L?= =?utf-8?q?5AcgZGYfaZgH?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2ca22a4-4fa8-41bb-c1de-08dcfab8da5e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2024 21:05:02.5177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kufqtSdoXTfMtXgghIeQW/SO/Gv5XUUXn1hzxveBWU7C8n4XuuSIoX5vsEAK+tej9rdXGoQr1TZqe9RaAXckdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10502 Some PCIe host bridges require special handling when enabling or disabling PCIe Endpoints. For example, the i.MX95 platform has a lookup table to map Requester IDs to StreamIDs, which are used by the SMMU and MSI controller to identify the source of DMA accesses. Without this mapping, DMA accesses may target unintended memory, which would corrupt memory or read the wrong data. Add a host bridge .enable_device() hook the imx6 driver can use to configure the Requester ID to StreamID mapping. The hardware table isn't big enough to map all possible Requester IDs, so this hook may fail if no table space is available. In that case, return failure from pci_enable_device(). It might make more sense to make pci_set_master() decline to enable bus mastering and return failure, but it currently doesn't have a way to return failure. Acked-by: Bjorn Helgaas Signed-off-by: Frank Li Reviewed-by: Marc Zyngier Tested-by: Marc Zyngier --- Change from v3 to v4 - Add Bjorn's ack tag Change from v2 to v3 - use Bjorn suggest's commit message. - call disable_device() when error happen. Change from v1 to v2 - move enable(disable)device ops to pci_host_bridge --- drivers/pci/pci.c | 23 ++++++++++++++++++++++- include/linux/pci.h | 2 ++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 7d85c04fbba2a..4699b1208d621 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -2056,6 +2056,7 @@ int __weak pcibios_enable_device(struct pci_dev *dev, int bars) static int do_pci_enable_device(struct pci_dev *dev, int bars) { int err; + struct pci_host_bridge *host_bridge; struct pci_dev *bridge; u16 cmd; u8 pin; @@ -2068,9 +2069,16 @@ static int do_pci_enable_device(struct pci_dev *dev, int bars) if (bridge) pcie_aspm_powersave_config_link(bridge); + host_bridge = pci_find_host_bridge(dev->bus); + if (host_bridge && host_bridge->enable_device) { + err = host_bridge->enable_device(host_bridge, dev); + if (err) + return err; + } + err = pcibios_enable_device(dev, bars); if (err < 0) - return err; + goto err_enable; pci_fixup_device(pci_fixup_enable, dev); if (dev->msi_enabled || dev->msix_enabled) @@ -2085,6 +2093,13 @@ static int do_pci_enable_device(struct pci_dev *dev, int bars) } return 0; + +err_enable: + if (host_bridge && host_bridge->disable_device) + host_bridge->disable_device(host_bridge, dev); + + return err; + } /** @@ -2262,12 +2277,18 @@ void pci_disable_enabled_device(struct pci_dev *dev) */ void pci_disable_device(struct pci_dev *dev) { + struct pci_host_bridge *host_bridge; + dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0, "disabling already-disabled device"); if (atomic_dec_return(&dev->enable_cnt) != 0) return; + host_bridge = pci_find_host_bridge(dev->bus); + if (host_bridge && host_bridge->disable_device) + host_bridge->disable_device(host_bridge, dev); + do_pci_disable_device(dev); dev->is_busmaster = 0; diff --git a/include/linux/pci.h b/include/linux/pci.h index 573b4c4c2be61..ac15b02e14ddd 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -578,6 +578,8 @@ struct pci_host_bridge { u8 (*swizzle_irq)(struct pci_dev *, u8 *); /* Platform IRQ swizzler */ int (*map_irq)(const struct pci_dev *, u8, u8); void (*release_fn)(struct pci_host_bridge *); + int (*enable_device)(struct pci_host_bridge *bridge, struct pci_dev *dev); + void (*disable_device)(struct pci_host_bridge *bridge, struct pci_dev *dev); void *release_data; unsigned int ignore_reset_delay:1; /* For entire hierarchy */ unsigned int no_ext_tags:1; /* No Extended Tags */ From patchwork Fri Nov 1 21:04:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13859767 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2081.outbound.protection.outlook.com [40.107.22.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDDE71E766A for ; Fri, 1 Nov 2024 21:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730495115; cv=fail; b=P+5nTCDhwutx7ogh8cn/i5gdZjKX2qw4NMzoAt2QBtAigsri1UsXDoHn6gSo4bmYs/sa3wDxp+Zl7hgVlchrLM2JnXQO8zzTK6sLRCDMo8v+ORwwc6Fw66qF0Bf0KygQy7VqF8XVvLASkeEg9ZkxQjECg3xx3N/6nOgGMzubUoE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730495115; c=relaxed/simple; bh=H923IcuEQyzA+uPEcS1JQpTm0nIuQQUxCktmluZQinU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=pGreuzLHC0SppAYUMDPvxXEsUT4K+qSm5rCp9+hTh3UUBlje23OtkYH/yE/WrmbWRj/Hp7YqgP8n3UAaGy9P7Kd1rtNRJSzMW5e5JPWEnHApAbCRcIfGznkSinJZLWD3bbmvynD94Qzc8o/hVIZXXK6zpIHHQXfoP6n8O5OfuRs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=azwOSOB1; arc=fail smtp.client-ip=40.107.22.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="azwOSOB1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rFV1iEgUtWoA935gI3ADJ67yimkDu/mDwA3BmVy1zETw3e7LD1j4mIxszHXI28hij3UCnrdPSleR6MhetRmGyo6wj2XC7J05Rnf/TMXf4P6kpnkb7c6lnpWXUcq/2Nrmsvi1RarEmTArDT5XZ7I27Z866qnXRWcdxwVWIXDIzfQap03YgimsSMkXtIMD8hvw+e/cFCERri6JnJGJr7tZzKhRLxhinqabvmT+ifGpyy1lJJFQ55pKy2jqQRWNDlHRG4MmVHbqI6ACyWdZGm9EDWfJfS2ZNkfRhCPgAHYjsqfT3IqCRNMAOPt34Cm+iHelZ4Cax/XNcOW34ZsOaZf3SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2EWh9k/P12ZthR32RK14tFtWh5Qe4e/lMVaslXghNsg=; b=atbD1ytmVJKQuNb41KyYmi9SI/nV2Vt5zTaZizmDurcM1Jr9LlAeJgwmCns7ROS5EW+dGXaWpUZ7JYbGKhxKoar2+Z6TkGU57Ldhogy0ub7du+Hw5NaAOInTCu3UkECY7aB80r9v3fkcQNWoDG0HnprNsKWHBVvY+TEib3AoPWvGNtyeooF49ZvpMjPe4hnHBU0w+QXZ+9TaYHvdFdFXiHYRYYx3ojVriDA5Qi4GcOzt6XkSY9UTjbldAAqBZvzHV92tHF5CVDXdTOisGLL/YhB8ld7neZHDH+lyKsMD2XPjLdNTszAIoH5AUAUYknvpp4I328VLA56FlMpIySvtHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2EWh9k/P12ZthR32RK14tFtWh5Qe4e/lMVaslXghNsg=; b=azwOSOB1I3n/Uc4RoGJZFON9NUw/hL8RFCgTAUa7W4vylp2sR4tgL8hRx1Bcn2InmTy8kXNpv31+LCk3Iwr00JzFAVbW/bxY546lY0kXTPVKCY0Q9PT0R9gs/qpNUOZA2n1BE4kBRzefvU9BxIJ4CtpT9U0k3D5ubvhqlXmi+ic54iZhap4Kt7E4/eHTnwnG1THgdTiOtQvup4gSoldihXvirOVvOH2W1lRdktphn9HCZl31i6mQJYNFsbUmKwUTi28ifx7UOKhWrTyASociMLgm96W9DI0jrrJwmoN6gsVtRM+AxPyqLOfpS56hN3vWlP8Xg5S0Ns+cL3Rm8ZJ9PA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PA1PR04MB10502.eurprd04.prod.outlook.com (2603:10a6:102:44f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.24; Fri, 1 Nov 2024 21:05:08 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8093.027; Fri, 1 Nov 2024 21:05:08 +0000 From: Frank Li Date: Fri, 01 Nov 2024 17:04:40 -0400 Subject: [PATCH v4 2/2] PCI: imx6: Add IOMMU and ITS MSI support for i.MX95 Message-Id: <20241101-imx95_lut-v4-2-0fdf9a2fe754@nxp.com> References: <20241101-imx95_lut-v4-0-0fdf9a2fe754@nxp.com> In-Reply-To: <20241101-imx95_lut-v4-0-0fdf9a2fe754@nxp.com> To: Bjorn Helgaas , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Frank.li@nxp.com, alyssa@rosenzweig.io, bpf@vger.kernel.org, broonie@kernel.org, jgg@ziepe.ca, joro@8bytes.org, l.stach@pengutronix.de, lgirdwood@gmail.com, maz@kernel.org, p.zabel@pengutronix.de, robin.murphy@arm.com, will@kernel.org, Robin Murphy , Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1730495090; l=8217; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=H923IcuEQyzA+uPEcS1JQpTm0nIuQQUxCktmluZQinU=; b=VhHg1V9aDJY4/4HeIhOY1LLz+9EdLyfXH/tZZSFcvLks1BXQ5R22huumGE2Vm0ysDJFQClBfO hmGNUsOrh1IC2LCoJqkb2DRGrocVtrqFQfiV1ejjmYikiPlaNLecVNl X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0092.namprd13.prod.outlook.com (2603:10b6:a03:2c5::7) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PA1PR04MB10502:EE_ X-MS-Office365-Filtering-Correlation-Id: 046d74c5-dff2-4cef-a043-08dcfab8de10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|376014|1800799024|7416014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?fcKTxZdHfwd69S6niJRSzh+E6glLKNG?= =?utf-8?q?lB/JQrzOEi/1eeIvmCMsdgdZa/kZ2WCWx3x08cFXB1PF1096icV18TKOMlBiCg8bL?= =?utf-8?q?OtthP0aNgdwLd8ZrDdNSE+eMmZ98ufFxjgb8A2fPrWNop1HC+DuwY69JgvQnKj2gB?= =?utf-8?q?uq0X4HYlX+Xg+M7EtqWYId/au1cROJTyRIs04UlKuJz2DMOGVWoTk3H13hPniggPT?= =?utf-8?q?+sBeN0adt1dqyAvP05XCMiKoK1Rk85RigIBpgh3NZbw+ZsucjdJ8yHoUc/SAV+X1p?= =?utf-8?q?8hw5LMhhVIp6HztGgaP44mjOB/imLTp4csqUkohgy6r7KbZZpFcwu0mUStpGqo6V+?= =?utf-8?q?5LDL7ZEnfCEBkwGIkPq7tNA73MqkDuKZQj+PDxtHhwNNBq9kFEcR0GR8FZxbEwoVf?= =?utf-8?q?cgNDLwhyTTgYAR2/ulT5U5k8KPoB9cZxyjW5W1fw9mOB+KNKUBQthOsrI5CgB71Ho?= =?utf-8?q?C+U7eZ/tvpDK3f6PzDiV5Ivytb/+qEi7FTs6JdTVUPkDZ4bga38kcTo0TWiMhPqFF?= =?utf-8?q?LuHiMt9S6Cm3i3CMd3UWL8o/jN/KVn9hiTR+n1cDchrRNr68J6ztRgZFUUwf/63AA?= =?utf-8?q?i8Wh7kes2mG4gjOtLFPFFk6kiGaAArG5nAxYB3xOkunvP3f2zH8CSclTjlk28Ma5B?= =?utf-8?q?M+ktEFcZpROfZ1NTvvUA5t0STRUaRU+c4wba0H6E2uSnF7goOckvBfzmKsy7uHXHU?= =?utf-8?q?n/uDKwPgG1a8lBfVE7Wb5otLF983bZ77faltHH9Ugp3hNz7QBgldhO5oVIoj8Y/U1?= =?utf-8?q?yftQ+lx01tdcmByRZSHGwgUOkoBz500QxOmbitVtPtnhU8+qs0OBKy5wunFts1m1/?= =?utf-8?q?DNB38cYFhjppqdfZ4rd4XCoXCHA5+RlGetKzHWdfF0HhDLZWOouIKE2y4N7cJokcn?= =?utf-8?q?EEC3ZHhYga3Z66TS3lTgV2DuyoiF/ZhHK4/eyIdIl9s8Ooy4DFt1aKZf3S1ox/riD?= =?utf-8?q?BL3X1NxnwRUCiBAnf6zaRq4NAKKXOCMNipsS47ibsKOjJQmQ4illOAwaNqik9oUEM?= =?utf-8?q?5F4vAzJvLPnBLF12EL6TjI4SstRXT+BH6YfqlYNR9ms/gDmFMnm81goyVvFECrgua?= =?utf-8?q?emr6YIZ8nwTGIONRICKNx9OLHipHOnNwWdV7O4/D4tXR+F0/8i1EEnWvg2v4JWLKk?= =?utf-8?q?SMQ0PVxdXixPygGzQydtjR6SFxinpBtYe86p4P15CfUz7i43qXymoPEFerZEk1NS6?= =?utf-8?q?vNTGd5hqOx+94nfpRfGaUt8oo06X8nRRKKN63M0PIwU7QJaTAWzzm3OujL2U4Ffrk?= =?utf-8?q?CptOEjb4MurvxR4UHiNMAESPbOCqnQDczaep+bpkzY1LIb6WaU34xdOpjQ5hQ86vx?= =?utf-8?q?VdQ9NjLhM1rZ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(376014)(1800799024)(7416014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?x+q5TMiSUm57Rwb+6LD/LTnaT5qZ?= =?utf-8?q?nj1Zus4/nuCEVsbhwEffNjfrJS0BTnUqtH4jYj/ucSOg/qj4R8vikF+5BzVsAQvLC?= =?utf-8?q?zbNyCpIa9NdJot/L9faZAjUCCAvGClPbB4GkjdNzFqLduRGev/u4yGmXiOYd7aYAr?= =?utf-8?q?XVDONVcnN/OyDO9pbPvOUrPIGrU8dIwBr3wxysRrkzaDuvyF+Ym3MtTHTVC+rriXq?= =?utf-8?q?m6Rb2kSeTVuR/S+Et3H/68PNoaA9tOqP4HVSUtTWFrYjZRPLXqsS+Liu1A19yblYH?= =?utf-8?q?FfwzjHmtvFxs8G73RsuXnjWh+Mpp/EoHhmlrJe5vKl0IzX3KW6noFc6zUsLE2gzgc?= =?utf-8?q?dqpgX2ryhzcXzkoM43Z8XN/l+sqANt4fX9Oty9swHtHmvcKoYv5vxlUvWTJaJwzHH?= =?utf-8?q?6wwyGI53S9ze+/nv9zT8sospRqgX+bffVOb9mdlP2FyuuFXS/+NnLGwsvIrZcwHHc?= =?utf-8?q?zhuIdDOrc4sX+4zSmOMRMk7ux3zgrxhPAnA4mIG+KtzD4mH0CFCTtTzYd/TrvovWo?= =?utf-8?q?UwgqVOatPOqfPXhN7GK/mFv7Y7XScD352affa9ao7ZfYPo5oST+5QpmAReb92XxDJ?= =?utf-8?q?a83VvKLE+z2pm7ELeh8VAEMo55zdxZxUwLdUPnx3mGErdmuPpirt8ieoQRszJyAAC?= =?utf-8?q?H6srrqhaeR7MA0NV0WV+Jmff/R+dPxYzCJIfGqHdop0zEBgZdmyKVDq4ZXa5bqQW9?= =?utf-8?q?LAa4xA29y3E1qjogZoiSCyHt8xZBwjl5ZgPAGS0k7QzhzvMaUS7xi5l/2aekSAm96?= =?utf-8?q?lxMoqxBiOuXv8VEGXLpg4xpspeXfOcl+SOptzJZVxG19hkvor6qiLBGVCrvSTvgco?= =?utf-8?q?vU3fc0U4QG74cEVmdCV7XPrO5uW5PdDNnpNYKYWf4pmeW2yB8WA7S3aARdK1VRgsU?= =?utf-8?q?+dWSsVnJWjoniVlB6DJkgYB4w7+8Mkm+EI4Fu6M6aWMkEv/qEpCx5nQbMlz2G7axp?= =?utf-8?q?5i74GWlfk6tfav5bpwq9YDIIbG1ZzhgL3dMQIA/OmfiSlUPZo6awEeHTFJDn6U+bG?= =?utf-8?q?WqSAr3pci5mheFpujhwphtuKGj1MGpVFhrLrP1WWO8psBEajod2KzQ3VrpMxn1ZRn?= =?utf-8?q?JZvFtPKVaeugx5s7FKFWubF8eQW57L4km3nNi725Gxz/Y+la09mAv9dzrSt6cych3?= =?utf-8?q?/0LTcGJlcHZ47+pNT3ZgWRVmPucLtAj9BeTyUsnnmKEWYEQh40E3ErZ4TQGxBrBAU?= =?utf-8?q?3Zodqb2JGtMozqRduX8sR8l2+QOnH1Vvx2/lXAMSDCyrux0cXBQt1P71YvigDgf2A?= =?utf-8?q?i3wUjPc/B8HPcPDmLUBZxz0r9lHmc9OXNkyxhyGg1KUrPaPk1my1MxiqNkWiisKfc?= =?utf-8?q?C2TWaQ1yBIkbLh/54nakzyRhhYCuL9YwLHLGwrxw99haPK73HCsCrlz65/9B8O1ub?= =?utf-8?q?e7PoLOI/2oThmhNC4A6nTwMZJvG1UK8fbdpHuaAzh+aQGlluy+yat03d4/0nW+UE9?= =?utf-8?q?i0sbG3m6xiWy4G+l5IaAjNK6F8BqkxnFu4Ms+FuD0lmel154zW5okW74=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 046d74c5-dff2-4cef-a043-08dcfab8de10 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2024 21:05:08.7214 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mlT5jYTeV9wNh7HYtxZ/nlVedKSn8gVaW9HWKNkgex/IjGqC2QMmKBli8wuPbxZurbbaqznYbNl/lM5+gc0AdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10502 For the i.MX95, configuration of a LUT is necessary to convert Bus Device Function (BDF) to stream IDs, which are utilized by both IOMMU and ITS. This involves examining the msi-map and smmu-map to ensure consistent mapping of PCI BDF to the same stream IDs. Subsequently, LUT-related registers are configured. In the absence of an msi-map, the built-in MSI controller is utilized as a fallback. Additionally, register a PCI bus callback function enable_device() and disable_device() to config LUT when enable a new PCI device. Signed-off-by: Frank Li Acked-by: Richard Zhu --- Change from v3 to v4 - Check target value at of_map_id(). - of_node_put() for target. - add case for msi-map exist, but rid entry is not exist. Change from v2 to v3 - Use the "target" argument of of_map_id() - Check if rid already in lut table when enable device change from v1 to v2 - set callback to pci_host_bridge instead pci->ops. --- drivers/pci/controller/dwc/pci-imx6.c | 177 +++++++++++++++++++++++++++++++++- 1 file changed, 176 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 94f3411352bf0..1be17bc39ce54 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -55,6 +55,22 @@ #define IMX95_PE0_GEN_CTRL_3 0x1058 #define IMX95_PCIE_LTSSM_EN BIT(0) +#define IMX95_PE0_LUT_ACSCTRL 0x1008 +#define IMX95_PEO_LUT_RWA BIT(16) +#define IMX95_PE0_LUT_ENLOC GENMASK(4, 0) + +#define IMX95_PE0_LUT_DATA1 0x100c +#define IMX95_PE0_LUT_VLD BIT(31) +#define IMX95_PE0_LUT_DAC_ID GENMASK(10, 8) +#define IMX95_PE0_LUT_STREAM_ID GENMASK(5, 0) + +#define IMX95_PE0_LUT_DATA2 0x1010 +#define IMX95_PE0_LUT_REQID GENMASK(31, 16) +#define IMX95_PE0_LUT_MASK GENMASK(15, 0) + +#define IMX95_SID_MASK GENMASK(5, 0) +#define IMX95_MAX_LUT 32 + #define to_imx_pcie(x) dev_get_drvdata((x)->dev) enum imx_pcie_variants { @@ -82,6 +98,7 @@ enum imx_pcie_variants { #define IMX_PCIE_FLAG_HAS_PHY_RESET BIT(5) #define IMX_PCIE_FLAG_HAS_SERDES BIT(6) #define IMX_PCIE_FLAG_SUPPORT_64BIT BIT(7) +#define IMX_PCIE_FLAG_HAS_LUT BIT(8) #define imx_check_flag(pci, val) (pci->drvdata->flags & val) @@ -134,6 +151,7 @@ struct imx_pcie { struct device *pd_pcie_phy; struct phy *phy; const struct imx_pcie_drvdata *drvdata; + struct mutex lock; }; /* Parameters for the waiting for PCIe PHY PLL to lock on i.MX7 */ @@ -925,6 +943,155 @@ static void imx_pcie_stop_link(struct dw_pcie *pci) imx_pcie_ltssm_disable(dev); } +static int imx_pcie_add_lut(struct imx_pcie *imx_pcie, u16 reqid, u8 sid) +{ + struct dw_pcie *pci = imx_pcie->pci; + struct device *dev = pci->dev; + u32 data1, data2; + int i; + + if (sid >= 64) { + dev_err(dev, "Invalid SID for index %d\n", sid); + return -EINVAL; + } + + guard(mutex)(&imx_pcie->lock); + + for (i = 0; i < IMX95_MAX_LUT; i++) { + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, IMX95_PEO_LUT_RWA | i); + regmap_read(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA1, &data1); + + if (!(data1 & IMX95_PE0_LUT_VLD)) + continue; + + regmap_read(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, &data2); + + /* Needn't add duplicated Request ID */ + if (reqid == FIELD_GET(IMX95_PE0_LUT_REQID, data2)) + return 0; + } + + for (i = 0; i < IMX95_MAX_LUT; i++) { + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, IMX95_PEO_LUT_RWA | i); + + regmap_read(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA1, &data1); + if (data1 & IMX95_PE0_LUT_VLD) + continue; + + data1 = FIELD_PREP(IMX95_PE0_LUT_DAC_ID, 0); + data1 |= FIELD_PREP(IMX95_PE0_LUT_STREAM_ID, sid); + data1 |= IMX95_PE0_LUT_VLD; + + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA1, data1); + + data2 = 0xffff; + data2 |= FIELD_PREP(IMX95_PE0_LUT_REQID, reqid); + + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, data2); + + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, i); + + return 0; + } + + dev_err(dev, "All lut already used\n"); + return -EINVAL; +} + +static void imx_pcie_remove_lut(struct imx_pcie *imx_pcie, u16 reqid) +{ + u32 data2 = 0; + int i; + + guard(mutex)(&imx_pcie->lock); + + for (i = 0; i < IMX95_MAX_LUT; i++) { + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, IMX95_PEO_LUT_RWA | i); + + regmap_read(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, &data2); + if (FIELD_GET(IMX95_PE0_LUT_REQID, data2) == reqid) { + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA1, 0); + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, 0); + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, i); + + break; + } + } +} + +static int imx_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_dev *pdev) +{ + u32 sid_i = 0, sid_m = 0, rid = pci_dev_id(pdev); + struct device_node *target; + struct imx_pcie *imx_pcie; + struct device *dev; + int err_i, err_m; + + imx_pcie = to_imx_pcie(to_dw_pcie_from_pp(bridge->sysdata)); + dev = imx_pcie->pci->dev; + + target = NULL; + err_i = of_map_id(dev->of_node, rid, "iommu-map", "iommu-map-mask", &target, &sid_i); + if (target) + of_node_put(target); + else + err_i = -EINVAL; + + target = NULL; + err_m = of_map_id(dev->of_node, rid, "msi-map", "msi-map-mask", &target, &sid_m); + + /* + * Return failure if msi-map exist and no entry for rid because dwc common + * driver will skip setting up built-in MSI controller if msi-map existed. + * + * err_m target + * 0 NULL Return failure, function not work. + * !0 NULL msi-map not exist, use built-in MSI. + * 0 !NULL Find one entry. + * !0 !NULL Invalidate case. + */ + if (!err_m && !target) + return -EINVAL; + else if (target) + of_node_put(target); /* Find entry for rid in msi-map */ + + /* + * msi-map iommu-map + * Y Y ITS + SMMU, require the same sid + * Y N ITS + * N Y DWC MSI Ctrl + SMMU + * N N DWC MSI Ctrl + */ + if (!err_i && !err_m) + if ((sid_i & IMX95_SID_MASK) != (sid_m & IMX95_SID_MASK)) { + dev_err(dev, "its and iommu stream id miss match, please check dts file\n"); + return -EINVAL; + } + + /* + * Both iommu-map and msi-map not exist, use dwc built-in MSI + * controller, do nothing here. + */ + if (err_i && err_m) + return 0; + + if (!err_i) + return imx_pcie_add_lut(imx_pcie, rid, sid_i); + else if (!err_m) + /* Hardware auto add 2 bit controller id ahead of stream ID */ + return imx_pcie_add_lut(imx_pcie, rid, sid_m & IMX95_SID_MASK); + + return 0; +} + +static void imx_pcie_disable_device(struct pci_host_bridge *bridge, struct pci_dev *pdev) +{ + struct imx_pcie *imx_pcie; + + imx_pcie = to_imx_pcie(to_dw_pcie_from_pp(bridge->sysdata)); + imx_pcie_remove_lut(imx_pcie, pci_dev_id(pdev)); +} + static int imx_pcie_host_init(struct dw_pcie_rp *pp) { struct dw_pcie *pci = to_dw_pcie_from_pp(pp); @@ -941,6 +1108,11 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) } } + if (pp->bridge && imx_check_flag(imx_pcie, IMX_PCIE_FLAG_HAS_LUT)) { + pp->bridge->enable_device = imx_pcie_enable_device; + pp->bridge->disable_device = imx_pcie_disable_device; + } + imx_pcie_assert_core_reset(imx_pcie); if (imx_pcie->drvdata->init_phy) @@ -1292,6 +1464,8 @@ static int imx_pcie_probe(struct platform_device *pdev) imx_pcie->pci = pci; imx_pcie->drvdata = of_device_get_match_data(dev); + mutex_init(&imx_pcie->lock); + /* Find the PHY if one is defined, only imx7d uses it */ np = of_parse_phandle(node, "fsl,imx7d-pcie-phy", 0); if (np) { @@ -1587,7 +1761,8 @@ static const struct imx_pcie_drvdata drvdata[] = { }, [IMX95] = { .variant = IMX95, - .flags = IMX_PCIE_FLAG_HAS_SERDES, + .flags = IMX_PCIE_FLAG_HAS_SERDES | + IMX_PCIE_FLAG_HAS_LUT, .clk_names = imx8mq_clks, .clks_cnt = ARRAY_SIZE(imx8mq_clks), .ltssm_off = IMX95_PE0_GEN_CTRL_3,