From patchwork Thu Nov 7 06:36:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ley Foon Tan X-Patchwork-Id: 13865892 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8012ED5AE6B for ; Thu, 7 Nov 2024 06:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cH2vjZ2thek7RGOfUwjm1+5ZY5YuD6+EHAhHxSadIk0=; b=MSzYlnwsL+2Ezpg1QcuzqLHWpV MukUEgPQ+MJ+J6ACZqnfgVgqS63LLyYm4tI0OY4GOHt0ZiU5C/4sDV/2to1Z+SiJJvwGhwdLFoz5z q6L/mLaRPkp9m82tCGI7DBMnWXy96lK57pOLnkLBvX/OzpWdWPKYrK1wSbzugpgrpocG7kv2LCKe5 4XdNVG9svZU7sNJVFnP9Aim4OfLulYe4aB5Lo3uUYsUpAXUvx4/qr6ig+ykERBBEJZyJPkvcZOmTK QvxScCXetMCBeOOyWarOTdM6b1SKqIQJVC84bAaA8TGDbh/kpbHqH+4caJsaBbm3Uv++2bbGVlBVG MKOahS5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t8wC1-00000005rwn-3hZY; Thu, 07 Nov 2024 06:40:33 +0000 Received: from mail-bjschn02on2070f.outbound.protection.partner.outlook.cn ([2406:e500:4440:2::70f] helo=CHN02-BJS-obe.outbound.protection.partner.outlook.cn) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t8w8b-00000005rIa-1fog for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2024 06:37:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OfS71PvoBQnm7TdULqCk7TuaqRT2/NcJtx/0KPk/VPQokdEgsOx/9X6v3quUYfdmGyzriJPRrF/QObPucbklz+jv796BIytIbO1jB7UvQ0+u0QZqJb67uwNMrvdt2BhLE9C2q3gyJpr2JUPZX2BKoJLhxI/tohY9rwIuM7IFLjCynV7+W23eGQRpdpxu4u3qaCTrVI0jR0NkrjO4iWbYKw0QTjwXAvPykqV0ZImCAH8FQOOUwVjFuowWWmvrjtS/1qVjW+5h8nyzahVo6dwKaZvbdB5/W6FfA9auZ26/7pHibJEIa8DzB7cvobXSUK+JNP9OwxqC6l1/WS99Vys5oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cH2vjZ2thek7RGOfUwjm1+5ZY5YuD6+EHAhHxSadIk0=; b=MVDp1KZySV+uGepbyDxchv9wAZmmgeKNRveEC++Ra5aArqh4Nnwfyu0k6j/S1QYU+xJUPLwI/BqwYxuKtjBldS99VEyMFp6fKTZtvoNa/ZFb+Y+lOVsh/McvwNOqxvT1kth7psuZ1WfT0Z0rNzYsODbPZtUqPkv97C16nffvILxDZxznKRm3AtKOeqQAaaHjkfQSga6HdbVaIXoPGgDyp9MCJwSj4gBlr56rgvIn8wfrFD4S6SvK+CHttl5+Qr1j1IYo5Ml/5mCD7Ci4Kmb+R5UBdG67Gap5Ow2K5SGFm8wZ/8wqyuo34lzU2rQEOqC2dmydD/c+smK9fs7jkmZT9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=starfivetech.com; dmarc=pass action=none header.from=starfivetech.com; dkim=pass header.d=starfivetech.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=starfivetech.com; Received: from ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::12) by ZQZPR01MB0963.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.26; Thu, 7 Nov 2024 06:37:05 +0000 Received: from ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn ([fe80::617c:34a2:c5bf:8095]) by ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn ([fe80::617c:34a2:c5bf:8095%5]) with mapi id 15.20.8114.023; Thu, 7 Nov 2024 06:37:05 +0000 From: Ley Foon Tan To: Alexandre Torgue , Jose Abreu , Andrew Lunn Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lftan.linux@gmail.com, leyfoon.tan@starfivetech.com Subject: [PATCH net-next v3 1/3] net: stmmac: dwmac4: Fix MTL_OP_MODE_RTC mask and shift macros Date: Thu, 7 Nov 2024 14:36:34 +0800 Message-ID: <20241107063637.2122726-2-leyfoon.tan@starfivetech.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241107063637.2122726-1-leyfoon.tan@starfivetech.com> References: <20241107063637.2122726-1-leyfoon.tan@starfivetech.com> X-ClientProxiedBy: NT0PR01CA0034.CHNPR01.prod.partner.outlook.cn (2406:e500:c510:c::11) To ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZQZPR01MB0979:EE_|ZQZPR01MB0963:EE_ X-MS-Office365-Filtering-Correlation-Id: e779b874-5d27-4fce-e928-08dcfef69850 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|41320700013|38350700014; X-Microsoft-Antispam-Message-Info: E6aS3eSaZfMyJjqJWNCqISacKnX9Mh1bjTApX42f7LZqUdINn9u01xGuJb2jMBVHuyOrOuTdh2rpToKdQrxHd6oMAG5ZSGisAhnlnT2CkMIolDU2gYKNpYmvKiGwkgMB47OIL+OwkBsm9BTTwya8ewUmk0YzJOxmogkD6+oyuZ7j0qABiMX7OcTmjf1nn7yMzsqSa5Sj8bTuHvUgnC9lRt8Q3KtR1i3EjaV2kOIUYufyfLcBXTDsRcxxIo78X+5CJmLY5jtE6WorNbjXbPTGee140XLIGhwX1oNLP7WBuyZzMqSUMafkbZwsZRLK5t5G3vWhSS5HDFRS58uq76Nb595HNX588xSl9pboEQOF0jpsJ5ysGVkMHFv5KMHO/qzwenC+9DuyOaFQSOVzu0h5JEay+8EDXHMafLsjZ/1bHhfj9nxvDUmbroWC7y9LadKMNcIyMbVd9IfC6/artUXw3Rln3E9i5Jt/1J8/yt6oUsBZJm+0i0vJz0aoAmUNW99y4k+My2iM3l/TnI/CdPYoLVQBs9+C9T03zR/zJ4t0Sk0S/gs1xFruN3cRiYb4yfdbfx4R+pjSWvggk87+Xll34f0O2cqYqyMkg0LdimnitkMFcD4sALmxC6/7oLDIh46e X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(41320700013)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /GZMCGKsbZTgjJe3G4/TM80jWYPo8yC9w3XKmBEVZrLX+ytXl8cwrpJV/nmil/CUioSzhYGcGnrmpsTZtKz9rfCwh5xOz/di3Lw0oexOq1cwyQJeg6yakqHiExKQNuq+LkhdaFi2ywNx8ytcPtyxCf+6A2PMfV/kcgDuAslTHv/JqGSm8SUSF3+JoDY4xlpE9pkKrGX0Nl5Ly+zLgZsAD/6xoPVIdViPZ/DnpFhb5qEwnuiqEOl+tiWju9YGJlkjCa+dxXsF+vcqfBDIkUJjXtsTwTHWteXiXcIStLzDgUeU/UzwpKRv3fi2FCcKTKD+o95LXsV2GTrY2vYkMx/uwSgauueeTRvpsUK0h803WjFdYS25rlCpyW4+DGFGgxRbZx65xauNxsFbvmDvztOZ0ORGaoKNA+X9f3KeQ1rOcBIbhK//XPIWHqpynkaKKxmqdkKQw//tp9pDXRJ43emHUbYknSY22axDZ1yxf+nCZZFj5EWz88vI4ZzvmTth9cKH3B5XeZ5MW9FaOFJi0rPRE1OHT9np9ejAQFq4EfYFY0IRg2furlYKHvscitAZ2bz/kvzejMaqmNLlFGdrzQNM6k4rOza5pZ69E9tdhsypxLEDUwyeRgstlLQ8tqSaegtlLlpmcHHmS0cPEOTTWB5UVvq8D/spCTSqexOsPFrMLSvKgRwrwg1oB4HnOGbnR5x0CmWGM5dzHinctfWB+nFtkqX9jJt0HhHDcW3NzrEnZLv9Rg1sUumuxmvtkf9ZjziCT9+J8ANssQM4BB3SomNh10VbLDnjEtPUbIZOpFUdT6i6foeGRtdadlo3e3GoEtw3DcDWNk1HMt7Wjl8I6WCn5LHqJNLBiWR8jydOJ5PrW46Q0yTVyYpRpVA6wkPbG7XKXYPFL8apz63FBz6XpyWVeEydELDVFdlmzvB6sqTmdTWiLpHVSb/4f1QanEvq2zDJPxuUOiq7HnWl2ewlMeYwFIHJzut/nWz+/ffoeo1xbd3ySiBU+I3AGzX3srICZuBn56hVVUWexdWbMaqB9k3ks+2Hs1Z3DvCRaKuVRjVoDU2l5Aw8TNtWAgaPd32LjvQO1tUNGFCH0JjjnhtgsPu6eD8qRYm/6PxefMzWuIo3gl4+Xt1cojxsd5GBj9RbXvJ8hZH2Z4S67DbgsGowCPXdIl2Z37wfwMqV51s4qGLlMo5y9VDBEEmzvpRnUwkG5K5vvAU9M12Ptgorzb9Hv3IAFRvO1cvVKSCR7AGXMSO1eoQQ0dLneGDuJ0brC4hWjElSB89irlgoS4vlpqo5qlmkEyKT8q5jPGvLogj6nFaZtZEWziIt4bNiYsdIGsSza96V8w3UW0Y3A34Kt414raOAKvK1GyHeXwY7u503QqV5njg+LTRMEVRgrvVO+ApIPMej0seOCN1cEby3M5EAkJoxxlpYFrKir2Pj5orbIVMG6+Faq716I5+m83Gyk4vgugB0lxMtKUZfzp6LI4//4GvlSHOTC1HcneYLiWeWGJvO2S7GwJkNkEioa78uK5ojFc9WjPO1RcOfdOAYmjXYyJ3Hr4DlPNXVza+Q02yEs1eaiQ6uLqSWTzbGOkK6ikJ5bWnHTuxqfoJb077LIkVjBUcW2A== X-OriginatorOrg: starfivetech.com X-MS-Exchange-CrossTenant-Network-Message-Id: e779b874-5d27-4fce-e928-08dcfef69850 X-MS-Exchange-CrossTenant-AuthSource: ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2024 06:37:05.2234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6NZ1o0phO+j7kXAAY8L4d4nub1S838IuEiJ9DdMPYS1LXTiTl158Ve4AFEChzpPq7Wh1j//KdykhBpRFjg8VIAhzh86nN8qPkS8nCiOdOsI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZQZPR01MB0963 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241106_223701_460228_50AF9285 X-CRM114-Status: UNSURE ( 8.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RTC fields are located in bits [1:0]. Correct the _MASK and _SHIFT macros to use the appropriate mask and shift. Signed-off-by: Ley Foon Tan --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4.h index 0c050324997a..184d41a306af 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4.h +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4.h @@ -393,8 +393,8 @@ static inline u32 mtl_chanx_base_addr(const struct dwmac4_addrs *addrs, #define MTL_OP_MODE_EHFC BIT(7) -#define MTL_OP_MODE_RTC_MASK 0x18 -#define MTL_OP_MODE_RTC_SHIFT 3 +#define MTL_OP_MODE_RTC_MASK GENMASK(1, 0) +#define MTL_OP_MODE_RTC_SHIFT 0 #define MTL_OP_MODE_RTC_32 (1 << MTL_OP_MODE_RTC_SHIFT) #define MTL_OP_MODE_RTC_64 0 From patchwork Thu Nov 7 06:36:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ley Foon Tan X-Patchwork-Id: 13865893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B74B7D5AE6B for ; Thu, 7 Nov 2024 06:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7q650lvcqo1SL87Anl6PkbcWcCrWtX06HNbpAIc0c4I=; b=HEYKU20Z4/tWcADQ7Jf50IN+1w wVj0XqKWWr5WPvxi9CPVzyRrrnhERTrwlQ7hKM+okbe2P2o9HmHZU2txtkjku2Q46Kv0PzFo7c3QA nvu1Iky/0A8twVbtaiIuOSck7S7lnb26ZDCvxj7Ed5Ucc86+ibYOOU9BwhpstrJTKLQvYuaEDjYa5 SfLP5azDAF3S7wA3YaJmw0xgRPgSnfAwmFWo9hp2yqyMQ7hwOB9Wg6n269g6wbr0vUiLc/u/1431V 14NZs1cJfBoq6mjLe4LNyPxsK07ctfVqFnoTsbw5PV8AH9Yow/AmISBAzPGg11bHqV/dYBrk++3Ps ApIm7kcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t8wDi-00000005s8C-2hXq; Thu, 07 Nov 2024 06:42:18 +0000 Received: from mail-bjschn02on2070f.outbound.protection.partner.outlook.cn ([2406:e500:4440:2::70f] helo=CHN02-BJS-obe.outbound.protection.partner.outlook.cn) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t8w8c-00000005rIa-43ZT for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2024 06:37:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eUFdKuYu2Lxa8Seu94K3B3chbnKh0reIKC6p2rtJe6Rnvtuu+jcuJH3WvWB1mn5xWnOchRDvkzyK+QCe+r4kzUGgDqf6mgfMI401Ip49YdSG9lac2eOlxgr899yuXozb5tLk8a0Pq/c50uSqrbtLHC5kk48m0JANm3Q7wP1KoRyOKB8Y4oGVZWKHxe4oKyvNyVLKafO7BEmFBxDDbi/AA1/nzmwGfbruhcsCp+dp8DJcAmNbaSqzYhuso7+kOYNrA4dAZL0PgDzeZFybjdkfqeldJdNS86/5xNYikJJNbsrEX2XjT2HicQS4CuZE9FlxuIoGg/clKueuBgAID5aRZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7q650lvcqo1SL87Anl6PkbcWcCrWtX06HNbpAIc0c4I=; b=c1RFuZuD4iRXfINB88ATm+uEYflGhqIGQhuufaouN4b8g9OLi8P7M4uJ1r2/+XOEp25GIxkz++ADD+FwXH1YxBIwGkcvczKHG1epO3Hqda+1cAVGVpUm5Df8iy0O4hW0rMHQmKDAnxzOqaUaPRzTt0fkfFmLzRTXoPkHAoOrWzVMF/XZEcHjs1gPY6NL5wQS4ZjphdG18zBKNRd4ye2qN4+DPqL5AeSRiUTBGiOUOnPxkcrJ+NlfpPR1PzbJ6hN4Jp6FOS99oOddkk6dr6kPDsliD31JNdsIgu6+rV4lKdr2cEp4hZQS3OZyo50sVMyx0Hh+HvJyVxZ0l5ymPvtHng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=starfivetech.com; dmarc=pass action=none header.from=starfivetech.com; dkim=pass header.d=starfivetech.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=starfivetech.com; Received: from ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::12) by ZQZPR01MB0963.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.26; Thu, 7 Nov 2024 06:37:07 +0000 Received: from ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn ([fe80::617c:34a2:c5bf:8095]) by ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn ([fe80::617c:34a2:c5bf:8095%5]) with mapi id 15.20.8114.023; Thu, 7 Nov 2024 06:37:07 +0000 From: Ley Foon Tan To: Alexandre Torgue , Jose Abreu , Andrew Lunn Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lftan.linux@gmail.com, leyfoon.tan@starfivetech.com Subject: [PATCH net-next v3 2/3] net: stmmac: dwmac4: Fix the MTL_OP_MODE_*_MASK operation Date: Thu, 7 Nov 2024 14:36:35 +0800 Message-ID: <20241107063637.2122726-3-leyfoon.tan@starfivetech.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241107063637.2122726-1-leyfoon.tan@starfivetech.com> References: <20241107063637.2122726-1-leyfoon.tan@starfivetech.com> X-ClientProxiedBy: NT0PR01CA0034.CHNPR01.prod.partner.outlook.cn (2406:e500:c510:c::11) To ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZQZPR01MB0979:EE_|ZQZPR01MB0963:EE_ X-MS-Office365-Filtering-Correlation-Id: cab00481-3834-4e65-9e54-08dcfef699a6 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|41320700013|38350700014; X-Microsoft-Antispam-Message-Info: sgWTqHD+t4TlvqQ94iRZlO7NILTUGTyABjWEPsLCBgKdhDUPqpgc99rNu1uGJ5ooNZEDuOKKPZXbY2JG2L7fFQLw5H1nxDq/cnWJktFK6tHU8M8hqMa9WdEvBkyC+ndHGfE/UWkyuUJkgjkC7NvwXKiIIbTIoj0Dy7C5UL/WynzvtjF19Nj6DXZlch5iQ7vlipa1jVWtEtwJR8EJw/fqssyD1PHczWO5Ls235SwALmdS4WTSwOYX5JDjuYLgiSM2RsxObs0ttL7GDRbGkF08jsl1hzGI3hbeB8hTqdYGh4PN6MH5CAh+9nFnHxfCmyJE5vJoSGQ5KmaLgEDCtLjxi5aKa7MLOmqrewzVj15/LiriNLYY8gRlz6MeUYgwEJ/lVmcC/Pyik8lny0SNmwA9aQAtl7LYT6Up5WLYDBvcmUo+e7NFsrvSF8zmPvgmC9ZQWp+vaLr3TupgpWJJB0q67eNGQIhjEpipViFrKQeO1GPwF1+GViSBkkAqk6ZTuU1g+c9Gd+RhRBNHFlVvNtFZxOcNY+p5q9x4ya/6YPwVypQWJYEutVmSvo27/rJ1SiBwGR+OwNkxKsK3ujY0ojoECicGkezjdFLnv0/3/IVXGqHgwIBTYSn6qu1w4yfGmRZy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(41320700013)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QiS/QCRbOAA1gbwtcY8gKZkuqeEB0Z/8xzyQA48DDgj5NcOKGqgifkTzoC62uFuYKBWG6/mubo+fRHMgWSMgAR6TiWYthTcwIRX1VWpvPHTS9FoQZ5Wp7OO8GL/O7FGZCpJAqE9WXQbl5ZY0Q95Isv94QQimxbvfvwALuKvsX5ibont513Quv5voVRuTnS2WT9+CqVwZz6urmCSN4Itg9Rh2VFrWZ27jHPMJbluCVI11jqxcY03x7IOLH0doiQLVB8QU49PbfgE3/D5Eh5uShg+RY3C6gNvqXt3Erug411V+rdzJ7o0YJt3X5MnTRj/LfS47BuggsaubdQMVWYmR9QtgOzTZqGmb8ZGzhj7/wdr4G5z8xqv43PA6C0CMtKN19PD/qNRhiIHdJ77Kgd7PNm7hvPgYXi0YUxuXiTlrNmuXRiOZZSevsy0K/IeGGhI6cmDch1diQELQwBdI2aWpNpkfakKiGiw50Ou1IuY5kvso8N+xESsOSVy8pzdLMOyK4YegDPh7plxrJL449ljlH9+gC3GGOVy5FYm7AIlXlKlLX+dneQrumkhUwsR11xetnLhCH++WKvyD7EIzAB22u4WMofAXWuAWmn9zcBclD3QrFGKn384Eakx3VaAZtN7cYBe9TDfMtnw+Wn/BfkNFYRdz7+bSCUeQfIOngRhIlbE8XPC5YTgVcUSCP9Uecka8808dF4PlElmDB63Hf/KukDzlRH9OAdYJC+++61bHp2YlA1lNHnHkE2GqVgcNUDpT5lpAyY/YAj2mvKt9xNFmRC6GXCWSkfZqJRTQy1AldmFkObOKG2+HiJZdjRHmGjJr65lCNC6rKONA/LUWCJyVjBiIsiTj+PnzqgIYTlKXZoNw/1RbXmIGoLkB68dGjm5o3qNlt3M+noto0IOZHkG2Doza5FETVH2NFqzH1gpHumgMbTL5n85DVFZz1TpR5xTZ88KaD6WHYnqv3yQkQc1KflfkTXTLMm0NcWbGByNZheC2DB23voZ4jyQf09Xnsb/UeJX3E0H/Jn1CireQcZD8CZcfnIOjIz5qHdoj/w26HYzSKkHhbV0+LayHvNSlfHJkSn5LjLhjXvaLRXOvukwywbpMRzsnut83CX2xZ8OGfTcO2EjKHyH04O9gOYPtbF2Ro5FHQQ1Ow5CKcIkV1FdTqx6ZOfTWujX4qXZS8Jj0IRJcjwIJIXQZvJIdzcAE2XUNpixBUNiGk0OUGk/9x2Y5crb8WPK/R/dKpicRq5hU2KouXIr+A3fr2Hi90Mq8iXb4zUjCO7UrV056R2zBHsLtHuyc7wIDmmudol0eVWrvkwDR26kPSdXUhQuqN2shwbbfWK1/w9T4xGsbPNvaHyBwejX24a4roQVRfeeuA9gFuWd+V778xPE47sMUD0lfmwPJuvCcMESw6AMpFmjcc7zlXfILk1fqnryS4kDoWBabgbx5KghqxYqQmyGKz9ug4GCm8ThQWay+vQ+c7Day9E66Z+lmCn4zlibQDMDNDu0gybuCcsTk30LuXtj6UefTxLir96wTXaJyYoqoXnP2HuaN8tcapCpO0OhHhjqvmy/Wk12lP90DtRx0t4O98EvNSPR5xPvF1NDCyjkalgM5g/QK8A== X-OriginatorOrg: starfivetech.com X-MS-Exchange-CrossTenant-Network-Message-Id: cab00481-3834-4e65-9e54-08dcfef699a6 X-MS-Exchange-CrossTenant-AuthSource: ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2024 06:37:07.4658 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KcOr+uxw/chWEsMVJ+iONrXTjz/U8k1TmEXv1SzbtFRaGC35p37FN0mdGaQxPXyokpOrdovHWsGlepwrCP7DcoI4CLQG1Wk8oJqwZnkEYHs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZQZPR01MB0963 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241106_223703_028581_72124646 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In order to mask off the bits, we need to use the '~' operator to invert all the bits of _MASK and clear them. Signed-off-by: Ley Foon Tan --- drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c index 22a044d93e17..0cb84a0041a4 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c @@ -274,7 +274,7 @@ static void dwmac4_dma_rx_chan_op_mode(struct stmmac_priv *priv, } else { pr_debug("GMAC: disable RX SF mode (threshold %d)\n", mode); mtl_rx_op &= ~MTL_OP_MODE_RSF; - mtl_rx_op &= MTL_OP_MODE_RTC_MASK; + mtl_rx_op &= ~MTL_OP_MODE_RTC_MASK; if (mode <= 32) mtl_rx_op |= MTL_OP_MODE_RTC_32; else if (mode <= 64) @@ -343,7 +343,7 @@ static void dwmac4_dma_tx_chan_op_mode(struct stmmac_priv *priv, } else { pr_debug("GMAC: disabling TX SF (threshold %d)\n", mode); mtl_tx_op &= ~MTL_OP_MODE_TSF; - mtl_tx_op &= MTL_OP_MODE_TTC_MASK; + mtl_tx_op &= ~MTL_OP_MODE_TTC_MASK; /* Set the transmit threshold */ if (mode <= 32) mtl_tx_op |= MTL_OP_MODE_TTC_32; From patchwork Thu Nov 7 06:36:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ley Foon Tan X-Patchwork-Id: 13865907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A252D5AE6A for ; Thu, 7 Nov 2024 06:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J39ztJJPp5Nd4R5VpwzQyK2Ms6KeAXzG+PM4hDlqzSM=; b=liPl0gh9/gO/MP8E4LIVSaeKpu /L6edWrW8RHygztZroezc+x8Nvnf5iX5sWFwPoSCb4Xt1pBMfhq//dcIyByq3gsZHkqBCtNW7584g uYIPr1VDMppD1izctkQgONXuA6fxm/k/auG1iFblb2irntvYgcwyiqdvDymc9EFu8PKKSeJ+HbJnM AVCBUAzTiO4su7EtHDZy076dLkP0msHI+dWS/t9L8iG9ziym81v1440BkW8dycZ23nYc2ueoamng5 8QTENNWJaiCGU+TvzRG1eadVrO2U9HBJ/qrmkTwSsPU7B+U2wTTYLeejE4/fAgBb9xeqTYPUDD3+o fUbheEkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t8wFR-00000005sMP-0E77; Thu, 07 Nov 2024 06:44:05 +0000 Received: from mail-bjschn02on2070f.outbound.protection.partner.outlook.cn ([2406:e500:4440:2::70f] helo=CHN02-BJS-obe.outbound.protection.partner.outlook.cn) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t8w8e-00000005rIa-1zuq for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2024 06:37:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O4i8+7Y/fw0F1TjUJK0HFdXjjzfCeiufGirA2nI5Vi7LLvwMDfXVY3sBO1oa2RJcgAtIEUBhASfXVULBbbtFD5ofXUv2mLQRh4psjONCeXpdY9s1k3pHvTtGE2vYx+09estYs7CTSPWhDBRX9u1LeAaLXkptgmPQD0ODf1QSzncgVz4aEYhEWLmd53A6x1N7CyaxkX9Ddwexo9BN9y1S91sFz/sqy3/TKADl2q89ylP1w9nwTH+GNg6G1QKFAygKaKXy6HehpDBPU/F2j/JTxDkdgBYo0t6G4p5Rn23VIl5PojYuVuatxd6xPm0DUkD4YRVxPDHUn3yKBe9/4NFFNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J39ztJJPp5Nd4R5VpwzQyK2Ms6KeAXzG+PM4hDlqzSM=; b=hPzqSSfX4gFt49/iHNq8O9rpKuaHoq05My7NrQZ903+bPD4k5mR+zZ/t75zmnd6Iu1JV8MEzkgtjSqfKson9LgZR8GVxwzQZSNITstTgZI4NAe4eEZERvwF8hFBc8x/11UHtGEF8Pd3BrNpvLKUALLkLU1bWoCSC+hTvFqzCHWwQPpjI9fKP8jCZFmzS4jw/anOh/IpmW6fRKq0AXtBtyV7BHz7U8S/H3D4WNo0ckJNgBYHj8d5IA3GXkPwkl6A7o5u+jMj9PP/Zht2hhkQhl48RQlJhvRZp9wBMbQzRH9X6ByKGPtgIBZ0KRcqZCbi+sr+ABu0r/75hG/Hmr/xGcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=starfivetech.com; dmarc=pass action=none header.from=starfivetech.com; dkim=pass header.d=starfivetech.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=starfivetech.com; Received: from ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::12) by ZQZPR01MB0963.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.26; Thu, 7 Nov 2024 06:37:10 +0000 Received: from ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn ([fe80::617c:34a2:c5bf:8095]) by ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn ([fe80::617c:34a2:c5bf:8095%5]) with mapi id 15.20.8114.023; Thu, 7 Nov 2024 06:37:09 +0000 From: Ley Foon Tan To: Alexandre Torgue , Jose Abreu , Andrew Lunn Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lftan.linux@gmail.com, leyfoon.tan@starfivetech.com Subject: [PATCH net-next v3 3/3] net: stmmac: dwmac4: Receive Watchdog Timeout is not in abnormal interrupt summary Date: Thu, 7 Nov 2024 14:36:36 +0800 Message-ID: <20241107063637.2122726-4-leyfoon.tan@starfivetech.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241107063637.2122726-1-leyfoon.tan@starfivetech.com> References: <20241107063637.2122726-1-leyfoon.tan@starfivetech.com> X-ClientProxiedBy: NT0PR01CA0034.CHNPR01.prod.partner.outlook.cn (2406:e500:c510:c::11) To ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn (2406:e500:c550:f::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZQZPR01MB0979:EE_|ZQZPR01MB0963:EE_ X-MS-Office365-Filtering-Correlation-Id: 4472be9e-78d2-47d4-dc54-08dcfef69afd X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|41320700013|38350700014; X-Microsoft-Antispam-Message-Info: ABEevHAuwl3TNStqcZmoJOJrTwnCKTvJYbM9sh8NnA8ZZWquheGxWlPrYPbdWdn/pJV4j1LM7CXChbikobN5DKWSmQOSck6WLiXjxD2Iaa+YW5SFzFDKpCSNhFPcIsyD4ck2lxW6KprNc3lkCX3ECGhBVruNzQxsUfMM7CvBIo98rEgmvoTe2RcBzhkMNZWMq1bOLkXrkvwcNLhft8F084dUYuIIh57GrtrKj1lvnela6zg+HLffodwcpWsEqBbSRC3ngdV9aDWoteybN6aQQLZ+Tqz8ONLAYmelQiCEN/y/s5gz8swaAtXZDS+3/iKdnOkAzTBPEcU07vyhAIDym26lzrlmW3Hvdw51tr10Yf9uwdy2fJGJTtPU9OJkXWLuuip1c0G6Tn4Vn7WzwgC27SNvPOSvfqQhO3oJNl4yZiCM8pUmkisDg5ZwFRW7SJM9EtwiXxJzjigUuOe8oKm8sD0WQ4JGabTyenLTYdTgOt/QfYEF4z8Xa9nVxWUVV3BXJqAkK5WX07iGTrlTcJ/UT7DtoMEwp2G0SV2cYBILP6WIfMvRsGqHBMGvSC8M8E783h7+rDFySLfMpHpOA617+4RX/9W5CE+jLCqPQ0ai3syPQ3QvEqVbDTMdgM9NEY1x X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(41320700013)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MVNOjN4p7Lhw5D5ADRVY06mJyPRsEONHxoc1Z8KR38WMLMhVkYZdb99uvcT02DU4ur8092nSJZkVZii5LGcxVFppdZDN+BHu4hE86whJEMhUguwWqik+bFh+0BPNSrQqGWErtZCTr022F1C5twamo9x0uerqBhXy8MLn+25VjjDiZjc75sPx7vww/lNndh/b8XFwDbbJUAOngKRGMU2MzFo4On0n6LKfq7LVqtFmbdY+9iGXrgNwkthYPfM/Hm70Z318UVHIB78hb31U1g9MkI6ql+XrfNOD9wRinmEBoN1kdaSuWDg3G9HIqipgOuxYTVbtgGht1oo0xyIg3aXkFPl2/F3hrkWEQzHN2FEpxNIBQbDpImXpoikMDqxXCkvCOUknu16/aGBkmCwQ9fGFXyypKJ9uMI8Qoc2Rj6zn4COMjEwZhYXQ/iUeOnRAfq9hTOe7AfsXklqle0F+PLGDi23593o9MxiJQ364aoRgHFY9je88WtbfoyqReqq+w+FGQd2nbygBXwOk+mNhpMkWdxoe74uGieEkKynlXHEy73YQeIfEL+MY6puoN8fRhM7d5KpogeVCXw8XYQY55C/YQpX1VWNA0X4aHaRBqbAtiuOFw4DYFuHehIuN5nm2ZYVSxM4www1wl/WOPlTRE1/bPixILUw1tmvk5ksV4ixd0OHCp2ytUJO3K7Mvr7SuvrkJQyC2cxtsgfvMH401KSp2DzfiHXfUqAgsuPDlY8NobV2dVkC6434T33p1ZBDQLLmIMUiM+KSgBV4v0IdKdQDoXJ4X4jkz29Tm2QC+SnvTY8Yu6qd8CB0IsfsE8UmjivtrjKp3/Vl7upYIVHZEnSYDB6vbMXZYKk2PNVILxp9xahP/+7Y2ot9k2lTDCDRvsu6MqRuSPIgdY56bQt4n0qKYfWWpIxFJ+BLbTZemYVf0DSv3ZiQXYPgTeow3xZPWBDl/y/SlsoEOJ8G5e9Rywb3Z5cge+GHteVq8HKfK5ElyNfIOdLzWnA6fwMRD9Q6lf+GyNqbsdd0LwxVSFYbMgVn/vNE3lDJtLz70VEqV+ox7BSF/1gjLWaKAIOB4KJeG6A7598K+bozTnPY66nBPXenALN/WIP/M9YD+ciJdBrwPWHa73LopQtRsYkhYzwAFRzVCjFzb3oJSfRW3x3T0Dm5WcVX0gp11l/ilrEdj9q2w9dvmZJm8zYYxWVe8zSkmiv+HS16hx8/vwJTPIjJ1Ff7ZAL6FXM+sS74PIU/pu/9cpyPZf6JrDtuz9DLBWdrcXVJQaczAGmlQtvgEUns8W2EtnPxkqCgFrGtsxhdQbLX+w+h4xALugxSFPRhG80zmCIRaGHG92u5dTxphrqOGGn56ZsTgn0QCMF/iqSGzp6fx2rd/ahzCE66YN9JPaFIKYYGythJh7ZINBsj9VJ4ITcdTqXb+d4Gh0mgT67pbCVcA52HU4ioldcNf85GpKkBgP3bkt1uEcV+FpkEGBLbIldV/ueEERboLhQaXkGucl8Rg++eROgoCsXYhe7gkzEDPN54hpqVfr7CPLBJjPw7Ja/Av5wnaPXl25V2JENKCsStr93YqOxACNMQPNsIKZ78EcbzMmTLrhLUBerpoRBe3r8tYwQ== X-OriginatorOrg: starfivetech.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4472be9e-78d2-47d4-dc54-08dcfef69afd X-MS-Exchange-CrossTenant-AuthSource: ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2024 06:37:09.7260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SadKhuLxLG6To0GP9RptRsz2TrGhdJ50YRxxUfZFnq2Lq7wxPnaKjELEL1VtnI/cHz3ATnGP7MYguHyFTTkonkm9DkOb+5OyYNH6U5pJTQg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZQZPR01MB0963 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241106_223704_537327_F3A109A7 X-CRM114-Status: UNSURE ( 8.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Receive Watchdog Timeout (RWT, bit[9]) is not part of Abnormal Interrupt Summary (AIS). Move the RWT handling out of the AIS condition statement. From databook, the AIS is the logical OR of the following interrupt bits: - Bit 1: Transmit Process Stopped - Bit 7: Receive Buffer Unavailable - Bit 8: Receive Process Stopped - Bit 10: Early Transmit Interrupt - Bit 12: Fatal Bus Error - Bit 13: Context Descriptor Error Signed-off-by: Ley Foon Tan --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c index 0d185e54eb7e..57c03d491774 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c @@ -185,8 +185,6 @@ int dwmac4_dma_interrupt(struct stmmac_priv *priv, void __iomem *ioaddr, x->rx_buf_unav_irq++; if (unlikely(intr_status & DMA_CHAN_STATUS_RPS)) x->rx_process_stopped_irq++; - if (unlikely(intr_status & DMA_CHAN_STATUS_RWT)) - x->rx_watchdog_irq++; if (unlikely(intr_status & DMA_CHAN_STATUS_ETI)) x->tx_early_irq++; if (unlikely(intr_status & DMA_CHAN_STATUS_TPS)) { @@ -198,6 +196,10 @@ int dwmac4_dma_interrupt(struct stmmac_priv *priv, void __iomem *ioaddr, ret = tx_hard_error; } } + + if (unlikely(intr_status & DMA_CHAN_STATUS_RWT)) + x->rx_watchdog_irq++; + /* TX/RX NORMAL interrupts */ if (likely(intr_status & DMA_CHAN_STATUS_RI)) { u64_stats_update_begin(&stats->syncp);