From patchwork Thu Nov 7 19:48:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13867058 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20193D5D687 for ; Thu, 7 Nov 2024 20:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dlF2ppYzrwkxKRIqxdACUVXIBjx0a0SOBqbSU1Wcp2U=; b=Qzz9xvD8a5oP1yaXdYUSPM7Iac fcnbUDvZv1yPP7wQj+MyaVF6INsTGmfhIg7RGjNyZFnX8N6313aHGOmORSURu8iVLNVcIdsOyf+Fu uthaKCev9bu7Y8/1nSfEZ2NC6x1q9tlvi4+ktjAyADA6NiRCSeNRke7RMBtHmuy+C+KxFHkYc8VuH 4LpNH8NJpGoywyzzdglEco/ceDsD/JwEmZ96aDBXhf/3ST+u+lWS7huEu2SkU1dsasrsyHyZ4tckp dvlpsaFve6UkXtIFh55WK0whvaaiXQdbcd6oaMYExed0Z/SwqaontR75rqJIHZ29oJ9RCEGZgm+WV Xu7AMdRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t98iF-00000008CFu-2XK7; Thu, 07 Nov 2024 20:02:39 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t98UO-000000088ep-1uSK; Thu, 07 Nov 2024 19:48:22 +0000 Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:c173:4b:4a04:3a21]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B2E0792; Thu, 7 Nov 2024 20:48:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731008888; bh=RO0c7EoopaN1SQrMONOFRGPZT4eehsDieDHwLK5y4+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fLGm/iU9sPvAnn5tjy3RYomLWN8cyiFhWWvRWnnRM9g4mdkwHcPj8VlW+G5pyUI1T zx6AHenunLiXvdYbdB2obf1uUVTpwHVXABPVcs98qoNCyAkZUf7+NyV2l1SUnB7c6b VVmUp/zSpJ74TS9VCvXHjwAeXePD98oyNdsS8t1Q= From: Umang Jain To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Kieran Bingham , Stefan Wahren , Umang Jain Subject: [PATCH 1/3] staging: vc04_services: Cleanup TODO entry Date: Fri, 8 Nov 2024 01:18:04 +0530 Message-ID: <20241107194806.90408-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241107194806.90408-1-umang.jain@ideasonboard.com> References: <20241107194806.90408-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241107_114820_667422_10BD2357 X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The TODO entry "Fix behvaiour of message handling" no longer applies due to killable completions [1]. Drop the entry from TODO list. [1] https://lore.kernel.org/all/20240918163100.870596-1-umang.jain@ideasonboard.com/ Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/TODO | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 2ae75362421b..f6f24600aa86 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -26,12 +26,3 @@ kthreads, userspace, limitations) could be very helpful for reviewers. The code follows the 80 characters limitation yet tends to go 3 or 4 levels of indentation deep making it very unpleasant to read. This is specially relevant in the character driver ioctl code and in the core thread functions. - -* Fix behavior of message handling - -The polling behavior of vchiq_bulk_transmit(), vchiq_bulk_receive() and -vchiq_queue_kernel_message() looks broken. A possible signal should be -propagated back to user space to let the calling task handle it before -retrying. Hopefully these msleep(1) shouldn't be necessary anymore. - -https://lore.kernel.org/linux-staging/CAK8P3a3HGm1cPo4sW9fOY4E8AN8yAq3tevXxU5m8bmtmsU8WKw@mail.gmail.com/ From patchwork Thu Nov 7 19:48:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13867057 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6279D5D687 for ; Thu, 7 Nov 2024 20:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PmJXawpBcFqg6fhvb715pUfMafSqsiwvL4tmSZFqy2A=; b=UTc01ZWMXITprwQzOb8uFDHFsA cLwulNDWsfVUEIrADJzYbFUp4vbGc/OJnoBR4HK37wOCELkSQg40AGzTpLQ9e0dFxt3Ln2pGpHh5L Ct6FQQSzHoUqXfjLNUpAQzEqfW+aVzViPX13tN/UMjbpiVo53NUAdy+D2JDlFbn1ZT8wsuRalAG0C MyN5qxNd50efZuO7GL4CoNmjiCDWn+hNdy9YYT2iUFVfYNwRsr+Hv7FW0wP4pBfsyTMRlAa1EVerT DoAeoRg5KvhFEMAppZGIbtrHsoYIuVjSODNhA2ayI0qc0wd6hJamggGrE4IpMChtYXV3zigzy4VPO XaZgYeRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t98gV-00000008C2N-2coV; Thu, 07 Nov 2024 20:00:51 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t98UO-000000088ez-1OQB; Thu, 07 Nov 2024 19:48:21 +0000 Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:c173:4b:4a04:3a21]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 87AF899F; Thu, 7 Nov 2024 20:48:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731008890; bh=u3Nlc3VrK6eIFZ/S5a9xrWzVB09MmxR0BHD8rNbHZ9w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Plgr2cOEIf3tTqxCgt5dXMIK+DMiSd+f4ueONz75ODGLhPZbcybzbHcYDu9+zAGYW DFFYlu5piJdtUoaivonivYdwdodXVR1U+0YcIM3izORQcl9n7eEO+digqYgj52AoUx QVPSyDDH8JSjT9hnTlgQRGmSKMB0pxCeAWlpfeU0= From: Umang Jain To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Kieran Bingham , Stefan Wahren , Umang Jain Subject: [PATCH 2/3] staging: vchiq_core: Rectify header include for vchiq_dump_state() Date: Fri, 8 Nov 2024 01:18:05 +0530 Message-ID: <20241107194806.90408-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241107194806.90408-1-umang.jain@ideasonboard.com> References: <20241107194806.90408-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241107_114820_529586_235B209E X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The header vchiq_core.h does not need . It needs the for vchiq_dump_state() to dump the vchiq state through vchiq_debugfs.[ch]. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h index fadca7b1b196..9b4e766990a4 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h @@ -7,11 +7,11 @@ #include #include #include -#include #include #include #include #include +#include #include #include From patchwork Thu Nov 7 19:48:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13867059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06BFDD5D687 for ; Thu, 7 Nov 2024 20:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z3W4q7g9ut2Q8rLD2mKG7lk4sy0uJn/7tWya/6N2/E8=; b=fcS2lQZqHBtZQeQLBhD0x5mfoI NgW2LqXSE5STfQ/xshnJqJB3aHzF1Z75btMG48tLlMDfBJnKfT7AKKk+GFONcK0dZy3A/ln0+46bF zouSS1AhiGO/k/wM4CCTDBXZAJNY9VMrAdUoLmQdBuo0Lxk5VqflLjChqO6kFB4gIa/aOVVEnWJe9 NJbdK88hZE2YiHbbopoocDQMEwMjYFQY6+vD5kCYyJz59UW11X12VjtGAWidmRcfvXCHNvztlyjOp 22UTnv0t3TU4UUVKZo1I8yKLvVGFEB2p8r/h8YTtgpPLEOAF9DI32SBSezus3xxC/gdD6Q1NAP4hd oK91YRYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t98jw-00000008CRH-496X; Thu, 07 Nov 2024 20:04:24 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t98UQ-000000088fs-105T; Thu, 07 Nov 2024 19:48:23 +0000 Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:c173:4b:4a04:3a21]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B4DFA44; Thu, 7 Nov 2024 20:48:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731008892; bh=f0YywPWanEM24s0q52GKso9Nv195uicG46KTsPUxLW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZyAD5dPwUsqoCX0oK08eQBVUxzuucLvpE56CEQAcS1Bg2BQ5gySzMC4cKZgAS41Px 0VteNgF5hMwh7EEv6c37NDD6FUPMz8ha9H6yXOXyWJxiO9r9N9TDBOv4EbXHM1ob54 vurRy453/TxYeVJO2wOYSU6LAEe/j+XR/1GEGuOo= From: Umang Jain To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Kieran Bingham , Stefan Wahren , Umang Jain Subject: [PATCH 3/3] staging: vchiq_debugfs: Use forward declarations Date: Fri, 8 Nov 2024 01:18:06 +0530 Message-ID: <20241107194806.90408-4-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241107194806.90408-1-umang.jain@ideasonboard.com> References: <20241107194806.90408-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241107_114822_436280_05B07AA1 X-CRM114-Status: UNSURE ( 9.25 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use forward declarations for struct vchiq_state and vchiq_instance. We can then drop the vchiq_core.h header from vchiq_debugfs.h. Signed-off-by: Umang Jain --- .../staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h index fabffd81b1ec..b29e6693c949 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h @@ -4,7 +4,8 @@ #ifndef VCHIQ_DEBUGFS_H #define VCHIQ_DEBUGFS_H -#include "vchiq_core.h" +struct vchiq_state; +struct vchiq_instance; struct vchiq_debugfs_node { struct dentry *dentry;