From patchwork Tue Nov 12 10:05:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 13872034 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E71ACD32D83 for ; Tue, 12 Nov 2024 10:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3KtOlUGMPti2KXux/yOWTORdOt+SidR8q0ovrN+aSmw=; b=u5JUs6Hvt8hfkSGV13blMl94ku W6zydqizHK0zd3B8TzcNQP0Fowi+O04DdPCQl7ELt4cSo2ER9YTXl/H1Wj+o9gyLuY3aRycTI1Hcx y/FfNTAQm1WFLugFtAVMDef3LKyVtw3/hj+9PCHfCNfOBDh7psc6lvYsClzBx6u8PJq/yGU73CDG+ DxPhjUEP6AgVlhbQulTPnDtk3oxSWW6EcFpVjpotN3kbYxZSrWXA2pqdwOs2LVFgLbueBhp0Xb31J /pcKRrKjPRostkqkITdUImY9Qkpi0qxYhDdDR5QFYmnjQFC3iCF+e8WGjd1aNUv3xgm8TdaUVgn7K teWQM5aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAnq0-00000002yqE-1HWF; Tue, 12 Nov 2024 10:09:32 +0000 Received: from mail-vi1eur03on20615.outbound.protection.outlook.com ([2a01:111:f403:260c::615] helo=EUR03-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAnmX-00000002y6P-3rui for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2024 10:05:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=POMjIveUCSH2q51lrwnvpTw3KjcvDALzd6WZeymFmohL3jhnqWDqKNG726vfJ18b3wx/WrW/dsOkX4URMCWlVTg0ScsmyARTaM7KREhfPAlckcHVp6hFZbYTcM0N5eosFMplchAwAZgDXUne3sBBTPiPsNl2XeM3plZ38AxLx9yoLjrQ9IZi6CYjvlPFZFufyy9ymc01p3LoocStID+m+/il37jQHG0byymtTWdJ78N91F8NVKzxTNxGg80LBC5xVdUHZYGS/fDScrX9oQsSXqyiQX16oiFEahTDilE95PXK3GqU3KYkQ7tzxMwyU4rixbdyN7Rqqhz9tm0lEV/TMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3KtOlUGMPti2KXux/yOWTORdOt+SidR8q0ovrN+aSmw=; b=UIxu3QZdChdEUQJM/lrBljn4hyZCYOIUyKsS7bRFiY5KSnNhxO7dTF4vog5MRZxZ7JRYq7MuCM27SkJxz8uTrWM+mJsBBwElVmPOVPzrSmgRdZWLU+cQaWYq2s5xJZj1ZkDpTS6oglOaqnGbQmCAXsjgGk/TAoa9ZwdSYy/yO+RITNxWD4N2cqVyQC2at3B/ibAxgETNmFy/M4nTCKqrIsg4kzXETuUrwfOycv2YjlV5JkwUSw4qUQxcx7Uq+1UK4R4n32fsa/GI5nBqCXY/P2IQYXpAcRgSgOWmNXTPZF5J4+mJ+Bea0UYdNUYQxlTdchfoQyp3JXtpmI0H+XuZwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3KtOlUGMPti2KXux/yOWTORdOt+SidR8q0ovrN+aSmw=; b=MKy3iYuscugUYAZkuGsTlodicNP3kzJdnWK6ABSFMhOPIGeuSx97E14aZYXvypkX760tLGX/watMJ4qDhYH04XQxbXJl4pFIvj0TUoQYEXdjb8EmHYFMBLCwmqfkHfGpFKHN0S0MAvEb9TWBk2mBKydZoZrGej7AcPVp+e9NDR5ZF1yuPJ2cAczO4NJKUzpAieL/Aw7qMUY+DX+rH5GsFfaM6LaIL6qqptcQkMcXcg3TU+VXU+iPdV2GqO77GeK7fYIQoHkYj+OfhOKQVSg9eaQGcUdAMm9A06y7byxiQQI1TZMNcw8sva63QQX/2NSfyHqq3dUuJYYNLfXwAnwzjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by PAXPR04MB8256.eurprd04.prod.outlook.com (2603:10a6:102:1c6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Tue, 12 Nov 2024 10:05:54 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Tue, 12 Nov 2024 10:05:54 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v6 1/7] arm64: dts: imx8mp-skov-revb-mi1010ait-1cp1: Set "media_disp2_pix" clock rate to 70MHz Date: Tue, 12 Nov 2024 18:05:41 +0800 Message-Id: <20241112100547.2908497-2-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241112100547.2908497-1-victor.liu@nxp.com> References: <20241112100547.2908497-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:3:18::13) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|PAXPR04MB8256:EE_ X-MS-Office365-Filtering-Correlation-Id: f477ad38-a8ef-4793-3225-08dd03019807 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: wyXcZKUGJ5Dy5PsmDokaYAb4A5lob0cArqfIMepRRiVTLUcYIJZdhfyzmko13u28WwXZssFLXr7bsCjXR7vjnN6Q0FnrsarC1sD+YoncQKybqcfe2phM32rMIo4tbXUjwcgstNqmfKG0OjKiqwuka2B80wKxorwg+G0VC+1GKBBcEHDy6iXZlybqZGVWiDSg9bLYPNvUi5zR+IW5CHn/HhTCCQoYAHfPX8kO5xLLzmtdijz483Q5DTPxSgSCbMvi5o8ARkJIzf572gZgsi8AplZAcfO7FZdKHKyLDpAwsyhOrevdO/42KO6Z5BWbFqVjos0Oilm1dkM56f3lh6uAqQcJU8qv5TF6SEQoVvnh1K9Ec6zBjmdGICEM5b2W3kNN/FdAqV9JIYU9PUMH/MY/kODJXHgCFice2JzW5H4vRVUimjdS4qTG5J6EJ83A/PAegdynObgUPCQorit2+cJyuYRrGbnCH0+7YMoQx6Xj0b4AV+FeDmiRmdjUD3L3jzFyeIpP8Z29TiF1d1sMD1U3n0ddv+dsDME8fVO4ab68Q4ioVM5D51piFmeD+rOya61JuofPbn7585s6Vng5Gqa0j1xfphIgg4J7rcyvtqRKc4g48T98NFltg/bLDdwzaQzGkj0ZYx2s194a5lEzQTQbbRD1T1sl95s2bGzSQcBR6ayc599WlFROY6dTAReP+80JLIh0isjcBjkPRHVGo/Novtm2vvSXpTTvxPJs3xMbj4mkdq+kOYVvfYyofzqN4r0r7mrBL0aiTugd+gVm1t/8vIVy96i6bXc7bDznH7oLXva86KZY9FuOaCGAtb3XOYlW9i50xzQWeAh0Kt557V/pCnk9mGZAOTIbvQ+8dwWKjT6XemUiaBXcm99gj98E93VpuOQI3sybBKExN+sexKPjsB3+K+9DiCO0wC0h8R0568sRiCDBXk5htcxHiSyw2XulzYmkWKf6MdYGZSmRN4fg2wOC2EQcUdQG6UOEMVi/Io6dl1wzPse10j9/4Z3YevDiesBbWF6cYb9XYsorTGhgC1lHIr9kKZMCEhNoB0K33bbYqF14b9A3OnCY1G4Rxe7BCWpt5aqW1FCfDiUPOjFQdF/HKKjyynph5lQWriUwEatxj1DoRvnnMs3mn0888q2bAE+me8wh7djfFQ2yj+hWVth+BXWwBTPL1xwuXf+MBLV+9tRVH5AASKiacDO5I4Xzi3NT9A4OKqNimhzZsSYXFY4QxgLKZjn7PZhAUSB5rv0usfulJLs1Y3FGQbn4x/75v633tWkWqFnPJRyIuVwl5GA0YhVoemvUFYVOGnc/m8mCx1eyJcXagjDcBetHjkmtzQm1/wuPyPR/LDJpVUcyboVn3o5MQyK/4M18TR/v3Rs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9sBdl5aKLfYUEgMEqgFdrWLhrI7OtgDRzztii0QR4O87MozXaRskmJUJDpriZhdymJYRlIon0QP059fWAoegjroW7JFGnK1q36kV/wyiC1akSgu5K1GNBXxWmt8VI19WKNecyUlvxnYLfaZhxQyvtmgzeERjK8i2vMkn5/C+1aTj7bDISlEGrHQPw//ysag7RdtsZ/NsHZfmkPbVbyVJhhhahMbDYo5GXNPk869iLGLyo9P9+1qwlgpF9oOLUdhMPTo3FYQpPdSCmfbj7NS8oL0SEDtCes0nOpHXFek2gP7rOQkblLVb49cKUvmx7copir4yqE+bcCLSpVECB7PppD/T/gzOns8RSnchHS3UtBGoL6P26/rpp6P/M4EJoqaXXv4QdAisBGq0Xsm2a1tAuY2SesOe0Y2bllsqDdBk04VTtZmQDmC/OdpiTLpwRcSKLlUVPfQq1mHm+1IvrMaOKcD98oftkPr5kYOuCKohKuKNu9LeY1rMBM8eGnOJMIVUgxBA9wvQGo6w48s8dqxtmqz5HN2E5Qt+Vfpqiw1n6s9V19AN3WIo5VIR/E3Cy2pQqFMCsKABHq2ZmZ4zHj4pUANBHQqysbkwLsArDYANiQDxUO0PWOHBdjt7wxOPN3OBmDvOVV9GjMxqS9+Kol/J04mF4cPf1DZSVXIzJ9J4X4WkCFzOUWOk0vHB6c49nNj6J/6eefgmucIscr4pDCTnWMIIpaUbzVIv8F5XnCgpPhrRRVEo30VtoVgQDIQ1T45MNqIhyhHaFKIrueDwji0clO4oE8FGvPDSZUojLllu3ICNgx61MuYTkoWrDguCn+fky3y7gsY/12PCzp64sDqlQmjV7LvSxqV6S5MAfWSoCvwYptItLT4LEI+6D05Ob2VG19BRTELGkjAOqTBJtn4tKZGdA8YuMR7h4GWEbdmEZ28YK8ZvXhz3Hytjx3DePX9AkmNjbCCXkYLgOwj8/2MQnkE49ALuXfENTCe3alqzSfOeR/gBy/9kr4Dwv5rPaM46/wuvjoZxnCLcpdwx+pXuSCCZsXuiXRfWUw6dQ5AXuRL3eVNbN1wH/LhK9xDYjgTqTWkCQd60pDJKYUbjAmqSxeYYXe1oGfVEj/JN1BZrIGxz8rcpcMSPD95V7+zZXcuDpynCb1j4PN+aBNPyJymfJFs3+AqCMzJTDM0UPJeASRwNukpyFisL2fzd+8DDTG073U69jyFpelAUYpZ2XcUb8iuH0iicQxb7jry2ODNkRXrj0OWb2h3tAQkLbXM+S2fl7b38KJOiXghGpuHTU6QRRc1AD/AA2QhsduFvSk+Cf9CHe5Pvx/jNbdxNcVoVPVaYH69RpnipWCAG8Qr51uv1Uds9XihcgqTy1ONKCVLyc9ef2NwrBnixcpfi5Pb0FU+4b+/vLRyrwbze+/OSbT0GsWDWdIH5o4wPVfHUecqZ/5DGCfBSb8boQl3P8fLiSV5UD7WnlHyy7bYVw3Woa7dHU43q3gK9G9SQItFLNF9bqFnwdH4gOBbdbpLlkTezaaNHjDbIcdGbfHISAqxjU3na4OgCpSW1+ma+VPxFBzjYF3lbJdP6aq5EWR9pjHtvLMSy X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f477ad38-a8ef-4793-3225-08dd03019807 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 10:05:53.9985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rlZGL78HDRb7ON8TOJhrCsBq3hfUOLNqNgijZus3TniQj+O+IJCJxdlNTb686nj9MZ0Ya+z9wCNPVfiR5WwHVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8256 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_020558_015001_853A0EB9 X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The LVDS panel "multi-inno,mi1010ait-1cp" used on this platform has a typical pixel clock rate of 70MHz. Set "media_disp2_pix" clock rate to that rate, instead of the original 68.9MHz. The LVDS serial clock is controlled by "media_ldb" clock. It should run at 490MHz(7-fold the pixel clock rate due to single LVDS link). Set "video_pll1" clock rate and "media_ldb" to 490MHz to achieve that. This should be able to suppress this LDB driver warning: [ 17.206644] fsl-ldb 32ec0000.blk-ctrl:bridge@5c: Configured LDB clock (70000000 Hz) does not match requested LVDS clock: 490000000 Hz This also makes the display mode used by the panel pass mode validation against pixel clock rate and "media_ldb" clock rate in a certain display driver. Signed-off-by: Liu Ying --- v6: * No change. v5: * No change. v4: * No change. v3: * New patch. .../dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts index 30962922b361..2c75da5f064f 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts @@ -52,7 +52,7 @@ &lcdif2 { &lvds_bridge { /* IMX8MP_CLK_MEDIA_LDB = IMX8MP_CLK_MEDIA_DISP2_PIX * 7 */ - assigned-clock-rates = <482300000>; + assigned-clock-rates = <490000000>; status = "okay"; ports { @@ -70,10 +70,10 @@ &media_blk_ctrl { */ assigned-clock-rates = <500000000>, <200000000>, <0>, /* IMX8MP_CLK_MEDIA_DISP2_PIX = pixelclk of lvds panel */ - <68900000>, + <70000000>, <500000000>, - /* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_LDB * 2 */ - <964600000>; + /* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_LDB */ + <490000000>; }; &pwm4 { From patchwork Tue Nov 12 10:05:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 13872035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37107D32D84 for ; Tue, 12 Nov 2024 10:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BarySs8rmnTz0Lcyjjyr1odVS71UDLLW4AffmsOMvfk=; b=qBRWB0vfjnHub+FbSEirmZks6S Uy78aj1hvmX6nEQisbobu7cLEgu3lyLL3ZsIVErP2f+H3rszrmeslvBTf9GAFjTdzkS+V3TVqwjYW SgZ52WbUnwmPDrjt9QqIEn5DxsuXARTXXqr0WmEH4iS/8fkdByLhmHXD9YUA7FlSPLyBjqgFVuHwx mmxScY35C3102HmVZe2VdYHzl3Vq70dmsK6+G9P2qre/FcTl0ZuXQWUowwRrscYaFJw7243DL76wg oucZSe2KIVU5lMZ1yxv9B/hnTTGN0R7NfxlP/EtAE8AWTX32KWXAdLro3+f/Dp3SXvUAjrvVYgwoO LkfeY2YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAnrn-00000002zEO-1bDd; Tue, 12 Nov 2024 10:11:23 +0000 Received: from mail-am6eur05on20621.outbound.protection.outlook.com ([2a01:111:f403:2612::621] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAnmg-00000002y8N-3gml for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2024 10:06:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xDF7k0Thxz3ae+Y4m5E33vr5d2tJHkiDLqPxuLsPdyaBlEa4eEs4ADS6wDjPW+hcWTR5Jl9F+uxKeZJ9t9kGSaOzK35O6U5dEn9Wme6JGtWHfzPjVea+M9/QSCXp4J0qFZ48oySjbwi9UgzjlKYLQ0Sr0yYcfJTww7YdP+jgqOyZFamCYGoRneGcR6KFsdUdWBtg0FjeUlEi1ea2+E2tCgO/1keQsDDQYGE6Txhm35HL+UO1H2Kxs53Sp6zluzPFc+zgGSov7a2N4MLeN1PfVgpOfanR7gLW21o3n48/fZ3Un5RgjkGJ7sVm6EMQeXgjchggTH8Dm2QAYF9IIrTz/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BarySs8rmnTz0Lcyjjyr1odVS71UDLLW4AffmsOMvfk=; b=orG3Snpep7DyXH/S0MezrPsxhlLSl+2lHsJzYecubAfNONDe2jYrbf38W0SrnfcYjhXavX2Z/vr94iBYnxV9J465/Br6YaKSKWrfNugukvNDpxy/VtGjqpw5W7NRO2UvULF2w6LBFoXP7jtqdw/YbQQphq9GxmZP0+PprN+z2yMTMmFV6RUro3Hg4iS1Vsbckx5QCyWgNUY5QVnSeLKnmcRu2Jq8KxoxDHK7+e0AjuUklSFDzjaemK+H1ZRHrJ0BJ/KLMVnG/O5O4VzqcFyd+RVPOgpsibS/mnEdP/Ykxh7XXcP3hQP4sYEcmu4ViCbqnFIjaR4o2+iqTVu520GICA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BarySs8rmnTz0Lcyjjyr1odVS71UDLLW4AffmsOMvfk=; b=khvReEnazznVlsawlJvx2VY3p0Z5RLSVmXNeR7Z2QdEcNViZRn+j7wEQfTmKqMaXc+UlsFs/6S2W2V+sf6KVXzH382Tp1mQ5bzT9nwz5ziTmsYU96Y0MINx1Q4jwBbChq+cT0vhfezEWDlnZ2YsgzZ7RkrZ98ThoJ2E90qQ2GzuMzeJplNJFWjq1eSlaSqBg3v8EOUg7eeWMjtusYnUFK6J6MdKvl3aA2nrs/WEbJhrD3y+w7GtPi2aDZ+DgL/PKysLDNxGunNC97mW0+KhoiysdhgFjwOD+P4D8aOxkGDm/qZ5SRIFcjwqKAnycwIS15Y5KzRaiGfVBxxSMvPbWBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by PAXPR04MB8256.eurprd04.prod.outlook.com (2603:10a6:102:1c6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Tue, 12 Nov 2024 10:06:03 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Tue, 12 Nov 2024 10:06:03 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v6 2/7] Revert "clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate" Date: Tue, 12 Nov 2024 18:05:42 +0800 Message-Id: <20241112100547.2908497-3-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241112100547.2908497-1-victor.liu@nxp.com> References: <20241112100547.2908497-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:3:18::13) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|PAXPR04MB8256:EE_ X-MS-Office365-Filtering-Correlation-Id: 85a70d83-b547-4374-406c-08dd03019db8 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: iq32CdUNWRx3IeSDAGFdJjPT6eehjigcuZMH2gf3Oe1rqkne7CYC1ub4kz2H1wYrpxCKA/ttb1sFigCxbV6noCInOU8R5nXJMzQ/LPimIeybYNoX/OKVQNQNoxwzutY+0FGqruweXMK6q62q54fiBDeIPCUS7Ncli7B2IYI3PX5jALHfHlmlY1Z1rU8B1+5Va62nmjgWUAFWqirf1jIwyjr2HsIpazN0eFCGdKiyPDr3uofW6k0DkYUbQ5H90TN8PSs8WcMxpFj+kyePb+02Bfe7KQKQOsuUQ8nYxOfp27Ghm5U07PegYmaRGLNd5mD/sCy0rOJg2QMEWwSB6S5CwxJtAjGB9QbzOFKPEl6n3Wx2J+mvV+sqzWScAAj8pv22gYb7MqxYiEuAL+5OB/Y3aiaSzwnmwL6DHZtexrjc4x2j53CC3qFQCch2dJEQDpmxnCcsVmc3jEuOD6RlJGs26bYfaqSaC2TSNgPCddxIGl/BAWmZg6j7OTdpuhjmgA5LMxeVms0pF/HQy0bzTRnijXP9JZ5uEV7h8F8+jKM6CEKDyma/kCYrcFE47/20tz83hEmV32jRXu/565lfab8p5B/Sfa1SW9OyJh8A5+Qvr3K2I89Gco8RTKduPmR16NXwgga6lYvTiNvDPQuRTES1qHFhgBc9IxyW1H/z0DdYjLhJtipFIWlRma3Qct8xH5IQbK1y4quO8xIRovtl/f9POF6BFYbLBY5ecxwJMiOJG2+qc6EFf/gPmo1v2EVwskN/zWKV047Rmz5Ex5Lzh2ChkuAO+nIRZ8w/C2YcZpSnhRoHS+B+I7LQSTbYJhI33z6zkAuT1hW4kZXkDyGg6hcHc08/1uyx+q+EcC2OuYxUgYeD2NrIxXA4cW/CFZhrvUTuTI8xPIPV9EiexXXS9tHWhHaMFS+IF7/Rikpqx7BkbNAmx+VRo42H4j3UCz69C9ePGVVr8uQw5W5DSAWxM+ua4F9JHHt7yDKLB1rLeGrDU/Kx+OHz9OyhFdu+Xxz9hAqY07t2ac7cgtVLjjMhMbh/1J+Yk5bjXVXy6Tqar/AQzEON4mNlPAb8oSSSRUw+jpghENqsv4dOioCBkUjnjn2s2i5qTX+16ux01fczerPziyT2Jbs/fgYuT2z+IkeY9eD+WQp/qFB3TJjIE1cf21wA4op7HddA/5LrvTvpiNB4m7UqMIVcO9M1nW0ast3JkIdULthzDybhqNxPLXcdrBh6+Ng3dotelubuTAP9aVUeN7wS47LCeGDjlIh/xf8B9inuzfUNjhJ7aXLCwV6ZASJnWEgOObk/9hH14LbjS9+76Klh47q9fETPfKOeHJMae2FruvIQMVrk2z8xyRHRRwwuk2Y4kqAwfGXZ+D2p5yZBjZI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sM0+HA+EwUm2mI+uwPMneawY78ctU9zTwuiHsCELOwsC4QaOzbiUrjYtW/zfqrWVopzvJ0w5n/+uzvjLuKh95w6VNw1bLPLeNSwPPoa069MNo+wK9VDYH6j9h5xs14moYa3HURA2Vou1E+TCHCfUiPsfmb2reTV0yf36gLZ0WQbA59REy8dJ8Y/ejDaEiog5QnJzUbEmCbuwf4kDMYzkpYqTftKB62JCLwOfLr/fVxQlvWobcPgIdc5ElF5uf9rxT94Oryv4rkn4K7WUBz5WZjdn9iSIR+EAErGOsrErH8LKlwwPQM+a0ebP7DdmtF3xtL2+OvsNzdmf4BJk1ZB/zmGPPVtfwK8zMdAFet9R464NFwiumv8Ws5frcMzYW5SMnrqeqYWvYbUUPUfWNq8yh8kENEmztQFKg8eQhvqwbLSApFB4RCjmXnev7cU/6sMb0Xnwpc4O2do8wq6ObpsCOiMYkJRMJz5H9n9Q9DqEa08kElh+hZ8Zik7ejJif5WsRsCer+62ymjWc/eaWqYvw9DX9cXgU0nqgS5V5mAq66+Qx5W8g5TT0DQdB3+6oRgMQwbreOPijA4i5W7gElGZyhtC9hAzhKd1MM4uGH+jmk+g7aNeptmNx38zPlg71N+LtEtdW92UMDa5X7Xtn6wzIecqSUzn9tQtqFaUaUudtvb43M7aaPaAu443KnkPHWfKvByNq+4jkINIO7/vVpC3cYSYhsmI0VWnHspf3T5Mo17xEX4BMi6NW9t1//MDbu77aO8M9woXqQC2TW0qcxc7J6Pjj4sTaEzyg2XB/7oj2P9/Xp6tynnVO5FGJyVrfsXOj/gip+AIrBVXaLep4NcDwprqTSJ/yAXvZ6XpGx0GY4epqdoC7WeYNCWbIecmmP+Wvw2v+jBqwdzHwzpFidLY6E6jDUPI8W2ccM2pMoBmlfxeQSVx9/6fmITMD7OJVUJU6A8Pyk0Slm2I6qheAG2mD1D18mpi2C3R8qthns1sE/XoyNqT6T3PFPiATunQWWUJdqd9ImFAx6sk2J/bEnT/it8S0CsniFSNkI/nNaR5WW59Kelc9FcrqF/paxTKcuUBQGc4CAk+ut0eg6FRAOBJpvmkLG4Uc6FtAD1WPGrX0B/eqLJB6fCHnRWgwU5SAifomrZpCky4gpa0aewDIqYsIMhWAmCbeLr8jPE3NOk1C12ohicofZBfZZAQy69TNez9jcd9kDjIZwhNtbnYaz0SIZRamlen9OqAe8aaX81yv3Gi88puoZoweCzP5o4jjrMRiAWbBbVbtMY6vTXP+eGOaCO1+u8F1oBrTsr792eAWPwkmXU4Z2FJXBZ64MLl3pAM7NuhlyoKfXzYeJLEhHpBO+R1qrb2O9BhqIeA5Gh0R1tQ7rjY8LLCgnkeU4tYwb+/jCUVfWEMDpleKaTVK8GQKXERurwQKNfwvZtQz1jwQr+aSX6pmMauVbDzjLov1NK6vSfZe3l+Sbc8wH8ysUBxDj2WEfLdc6Zq7YfDkhx8Yni2c6HRiewWHYBnxMSHS9RnIhmUlnkdxyIdx8K80FSEXxfHelvCajgmgPd8b3ds09OEs1z3vCzEZideZzXMlfhJF X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85a70d83-b547-4374-406c-08dd03019db8 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 10:06:03.4314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qjCXUk6XL1fHmE7aH3zDivWd9UXMzELfTpJ1kGgVNRflFVcFD4dHgSWyFsCQ8m2dBcJRLEJxqU1EvSZxzY+10g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8256 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_020606_952975_7D8A3881 X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This reverts commit ff06ea04e4cf3ba2f025024776e83bfbdfa05155. media_disp1_pix clock is the pixel clock of the first i.MX8MP LCDIFv3 display controller, while media_disp2_pix clock is the pixel clock of the second i.MX8MP LCDIFv3 display controller. The two display controllers connect with Samsung MIPI DSI controller and LVDS Display Bridge(LDB) respectively. Since the two display controllers are driven by separate DRM driver instances and the two pixel clocks may be derived from the same video_pll1_out clock(sys_pll3_out clock could be already used to derive audio_axi clock), there is no way to negotiate a dynamically changeable video_pll1_out clock rate to satisfy both of the two display controllers. In this case, the only solution to drive them with the single video_pll1_out clock is to assign a sensible/unchangeable clock rate for video_pll1_out clock. Thus, there is no need to set the CLK_SET_RATE_PARENT flag for media_disp{1,2}_pix clocks, drop it then. Fixes: ff06ea04e4cf ("clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate") Signed-off-by: Liu Ying --- v6: * New patch. drivers/clk/imx/clk-imx8mp.c | 4 ++-- drivers/clk/imx/clk.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index 516dbd170c8a..e561ff7b135f 100644 --- a/drivers/clk/imx/clk-imx8mp.c +++ b/drivers/clk/imx/clk-imx8mp.c @@ -547,7 +547,7 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) hws[IMX8MP_CLK_AHB] = imx8m_clk_hw_composite_bus_critical("ahb_root", imx8mp_ahb_sels, ccm_base + 0x9000); hws[IMX8MP_CLK_AUDIO_AHB] = imx8m_clk_hw_composite_bus("audio_ahb", imx8mp_audio_ahb_sels, ccm_base + 0x9100); hws[IMX8MP_CLK_MIPI_DSI_ESC_RX] = imx8m_clk_hw_composite_bus("mipi_dsi_esc_rx", imx8mp_mipi_dsi_esc_rx_sels, ccm_base + 0x9200); - hws[IMX8MP_CLK_MEDIA_DISP2_PIX] = imx8m_clk_hw_composite_bus_flags("media_disp2_pix", imx8mp_media_disp_pix_sels, ccm_base + 0x9300, CLK_SET_RATE_PARENT); + hws[IMX8MP_CLK_MEDIA_DISP2_PIX] = imx8m_clk_hw_composite_bus("media_disp2_pix", imx8mp_media_disp_pix_sels, ccm_base + 0x9300); hws[IMX8MP_CLK_IPG_ROOT] = imx_clk_hw_divider2("ipg_root", "ahb_root", ccm_base + 0x9080, 0, 1); @@ -609,7 +609,7 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) hws[IMX8MP_CLK_USDHC3] = imx8m_clk_hw_composite("usdhc3", imx8mp_usdhc3_sels, ccm_base + 0xbc80); hws[IMX8MP_CLK_MEDIA_CAM1_PIX] = imx8m_clk_hw_composite("media_cam1_pix", imx8mp_media_cam1_pix_sels, ccm_base + 0xbd00); hws[IMX8MP_CLK_MEDIA_MIPI_PHY1_REF] = imx8m_clk_hw_composite("media_mipi_phy1_ref", imx8mp_media_mipi_phy1_ref_sels, ccm_base + 0xbd80); - hws[IMX8MP_CLK_MEDIA_DISP1_PIX] = imx8m_clk_hw_composite_bus_flags("media_disp1_pix", imx8mp_media_disp_pix_sels, ccm_base + 0xbe00, CLK_SET_RATE_PARENT); + hws[IMX8MP_CLK_MEDIA_DISP1_PIX] = imx8m_clk_hw_composite("media_disp1_pix", imx8mp_media_disp_pix_sels, ccm_base + 0xbe00); hws[IMX8MP_CLK_MEDIA_CAM2_PIX] = imx8m_clk_hw_composite("media_cam2_pix", imx8mp_media_cam2_pix_sels, ccm_base + 0xbe80); hws[IMX8MP_CLK_MEDIA_LDB] = imx8m_clk_hw_composite("media_ldb", imx8mp_media_ldb_sels, ccm_base + 0xbf00); hws[IMX8MP_CLK_MEMREPAIR] = imx8m_clk_hw_composite_critical("mem_repair", imx8mp_memrepair_sels, ccm_base + 0xbf80); diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h index aa5202f284f3..adb7ad649a0d 100644 --- a/drivers/clk/imx/clk.h +++ b/drivers/clk/imx/clk.h @@ -442,10 +442,6 @@ struct clk_hw *__imx8m_clk_hw_composite(const char *name, _imx8m_clk_hw_composite(name, parent_names, reg, \ IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_DEFAULT) -#define imx8m_clk_hw_composite_bus_flags(name, parent_names, reg, flags) \ - _imx8m_clk_hw_composite(name, parent_names, reg, \ - IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_DEFAULT | flags) - #define imx8m_clk_hw_composite_bus_critical(name, parent_names, reg) \ _imx8m_clk_hw_composite(name, parent_names, reg, \ IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_CRITICAL) From patchwork Tue Nov 12 10:05:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 13872036 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C19E1D32D83 for ; Tue, 12 Nov 2024 10:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cp8Cblo+6YwXQz3tVzJgq0Ki6AfMLZd/vEcpZZbQNLM=; b=ns3YcO3XdO24UFLOoOniPSjNE0 ochRcOUqFWPBYX3GYt4ih4s8TdWEV6Z4FIXl8RmfQ0PRR4yiyS+bJ5E++PjN+278xHq1Uf67JPo0a 0T5oyKPkJ90WBfTVofG4NgmkLqoU+Qg3pFxbOKXYCe6XYDFbudgfWMSmms3L68/kjM+w7Wi+PluxN LGS6OVVa896ODBN2CBEJgM97oUAjtZUyfzDOcYaTU2xEIZwiaFZZtZreb5YcjBPVE4FXHTvaN5Pm5 M+60Ljr5zN3Uz/2mIVvwMxHWT9vm7kwNDAB5GinDRyFRQ5X363RRe+fqbDsrxauFT2CvBxCas0Ro0 kkbrJrvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAntX-00000002zW4-3oCh; Tue, 12 Nov 2024 10:13:11 +0000 Received: from mail-vi1eur03on20607.outbound.protection.outlook.com ([2a01:111:f403:260c::607] helo=EUR03-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAnmr-00000002yAn-2gdH for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2024 10:06:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rqoMg0ExOMF9zewLGu2DycLfOI0yvARjx48raaZnQ+CBbr18RCDMKge25ptGjTZBHdkNnZtN8ZRJjIE1Eu60mavk+g+UYX0WYKvzqQOO/b4tEX0of6swzVr7m9Iw/tXqNhvpYdZZwhlvacNgyYDUUTReIuU+ggNXuhWPSMsDmHd2yUE7tVYk9N267qmqk19O2xbdxTpwj8+IeMuvWsIzIu4ZE9zZ5Um7aNoL6pLApbl2WXi+dmFEEj7I4hkjNT9Gknljrw2WLsYwW03wFsKJDYQ6zFdUpNu3gONl4bLAZ1TKPicaCN/imnnnpCHQk16MwJjjgXT0MJpsJq6rt0rfPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cp8Cblo+6YwXQz3tVzJgq0Ki6AfMLZd/vEcpZZbQNLM=; b=c1E2iFX8ROr6WaACBZ2LvKt5j/A20haWROGoTFA7n+XQS3N45NFBDexKWq8yEthjKAXaRW0WYiDPaBuz7Gj2Pd0JbHcLqJLEVbV44b/eL+WVm4TwQrskWLyxOyd2/76gDArCjr0l0Lhzad321/3CGP3TToVoyGvILURo11l1/PLHMpDNDVeoi565bruqG/0gNvpwTnEMJboyOmr5BoAbIu3W1tJE06Wf3OGMehds74aM5uNc6vjHutf8rEbtxEUJGHmjd1/FFFJNwIq+kj2Kea0s8eDBFjt8C878KYfyiQM1h38bw+n2xdh8HiKCAkRUnijEcj4QupotltiBSVNP0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cp8Cblo+6YwXQz3tVzJgq0Ki6AfMLZd/vEcpZZbQNLM=; b=MYPZtOrozI/PYl83raowS994RANvJwTsu8ot6dExDGQbEK1bXPXGrrOpB4L7EY/vqu0bA+ITConx0pMTsXgPiW41Nm78uj7A9ZBOBkPXUsCs1jMvOzcCiw0AzDgDwiwf+1JLPt9A3NbL05+0SXPpEYG1fgvnGrGwRpKRJ3h/NCkvxMRldlueEwevX58v8PK0FTkn9PIej12NAXY16hxbeOKdwA1WjZv05AKYe66OYgBBqwHkvEnmYS9aW/sp9WiunAEw8JLOrYY/c/PpX7pCeLyLVgLY+pMX227ITQgJoM1TTjJfe9lHZQ608tkPxxLHQ50Wtmvup6uy9pspVAMNbg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by PAXPR04MB8256.eurprd04.prod.outlook.com (2603:10a6:102:1c6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Tue, 12 Nov 2024 10:06:12 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Tue, 12 Nov 2024 10:06:12 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v6 3/7] drm/bridge: fsl-ldb: Get the next non-panel bridge Date: Tue, 12 Nov 2024 18:05:43 +0800 Message-Id: <20241112100547.2908497-4-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241112100547.2908497-1-victor.liu@nxp.com> References: <20241112100547.2908497-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:3:18::13) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|PAXPR04MB8256:EE_ X-MS-Office365-Filtering-Correlation-Id: dc766a2b-227a-4861-154f-08dd0301a338 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: l4ryqmJ1oe0PL+EzqxntOYStiX/LNm9hja6R0k4QTKP9wWqyajWPz94LApP2lAiq0tmjiGlf+t7T4bFyQ3IW04xeKGGhB5XuzvJ0nzvFZM1YNO43OrU22dSsyjRrcNiwalZkvt2wcGQAkmeQzeVcTZVhKiip4eLh6vhkBPQYJQJ9rTQVJ45YluIgVMWNXRyNoe993Gm8/O/XzKU+su0j2mX0bb7KV/uvtdzikMMfUdxl4JIm0+AfA4+ohCJmOoMO2MI43np/rZ2jganBxgMDKMQ3EIsDL9tx7VXL4w/etFT5XhUxQdvxe386f/BkD4GsxHqUZ8DTVNrulLotMhGYreZgIloO9oGiVZg8jubZ62q5kaUFVtXwim8EqgN9GDd62t7o7vQ0AY3SnWGbvstDY24gcjcW0RGrrehVs+KziwbF5yy4fJVTGHjj3xXK2Ztm8jPMomL5YQ0ymL4zOgocfDRXHbsjyYUUW6qDeU2gc4Qcgwmmqzcxrnh2lNZ5SxIj6cjH1b0HOhX+6hbg8WVYURtehkmccqP5dKySksMVNK7MlDV3+Mj+pc/JrR8Jq+rGsGWqqzKjT+KPU9ahbJQTI4Kt8NWSBVZnElNI2niXbOgNaMcZKaKdKrnTUQFEuTxPTBsQMfQJvkcycdvYCdqiQGOZx/eBw1WrUfqHIAl+UA08w2KUw9CjnUsKtRiPkV8tXOkfg3abbRui6oYYoxGmftOxxgs/8OwCEUZFr+iKOQu5GqVM/tiFiujxXHzrOHEoyPCUMgi+WkIhh4Z9x2C8Og9bBnlbEJWuIADzZ648LJF3ZRo9plvtI7G6Ia21xj4Ts8PDp8t1so5kTMeHekd9HQMU9HImq9MpHRfODZ17pSljcu1PcNazLxTM7t7L5p3p8BT8AwZ1Ste2H+1UP9uF7rrcP5gEYAFcwofiUyrbbyX5Shajpyu9xV4w/FDnRd+lwyT+eUjQRX5QnBt3OmFwTI+UWMwUwVwfv3q8jYpTVK/xEDL+GlzVupA+f3/mnyN2/Mb4GwRGp5w3xfa+gkw+14HMVQefaAVGiFCtjO9NaabLQfzof5zQRDyqoV8ZlmzFpho+jVRm3wQGxmc+d+6OOPayZFo85nkeoINePXZ96WVokiSvUSbUiavdnfEL+oZMT0wKzjan9LL5NFO+yn786YN5SBrZcSithhKSRObgVxHQwzeUS1vMcsQpHNxG+cDQ3Y4jspYygPoNoMJFLtsKJVAN7lufgb2L0hGXHy93KvHT8QrJqnkk+wTt6/zFcFuILIvuT99fLEup5y3tCOKXfYBSpaYKRwmYomhM0JoxpmfghbpbDg0sLean+I39gHg8BbiDygu03jPSN/8ZW0Kt39RIJHc6WFEXQZxyionqmd4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hF95+CphTpx192y0/HhrIa8mEOIbUX3fCGnKJ73QNA5lFWKaf/UNqINIwwAOl6+YsV1j3b0GnikawGVBr7EKKCi4SZGXaeASovIV94cEOBLuWQUjxcU+PGQr/GZgqfqpY/tqdFRopwLTVilJ3O/lctEKVLTWFUvZ+4vwW8RQtVZbeZEhZWUxFW44ioJx8mHqZpf/WbWKRp2Q/Aoz7nwsvGoQU8WaxzvRGm7cZQwozm9lBuTdCBSXLlFfAw/ssAaAk1/J7NB3XwBATarlAtf5dPzgBVLz2qkreVrR00nlo0sTHPi+A3nRB/NK0e5s8929bjrUPPxUNGGXtGsd8CXgUeph3CNDgybwJjb15c0imH6ji9kKZBTWN9TIxVbc9ERiW/oKXVa6RI/zhICn68SLoQ2loRtV4QSk92O43mLZWvkLLTDmxhkALTRx06GAm0SwPkxeiVVF/yko/o3kj+fvUxjiHy9yuP4iPiIwVqMWJ9UeQXNgg4qbCg62b1jdmUCh27fKUBJz2qWK9rL3DmQ6pTnOcretpVE1sM2NwJeXUgAfpI8kBj+NEYmOschBolnzvtjQWhXCP1dFSvmyUgbJm+afiEudkgG/ZT+DUp8LsydKfjgqaZ2oVpqlgUu8vGKumJr6VPC/Z6Wmubdt/wInG3gnNPLdWbOBfRPTVY6dG4BnN40AUa90iX87xgBWeY1udmCcO3xDxIxq/xPVtD2e213pk/sbs4GtS5RGqi2vpFDflDW6Y6r2A/4XHMN7vHzkMakJLhOaRKMxvDDnJtICMWB/EcRTC/yZRTuWU4sW/NVXfBWCv5dQ/YCBFTIx6WuK2o6crIQIKYCv3WQLg5yLpjpl0Bht0rlw9Zb7VBhzqnB2kmt7cDf3FTiOyveYs8IWD7Q60zSYO7ARh+irVe/97ebd/u9IPkx6TYPU3bcf7S5C9IOCMtBwMfHNUvBvqR5ERXE5cZh2qkuo1nruiviP9MXHesP7LAbu5/1FT2OL7njbG/Na7ZRQmvKhiGUfxPN6tOlf3WBqrFWr6J8SsqrSU4y9sJM5F+JSs1RUYImcvOWgZSy6PBiWheDizDdjyuCv7lpOvxP314GfeY/Pylf5ll0w+hTdyrrM+32FU5hDMSlstBo68GX6jkKX9Dms8HyDhl+2nVOHN9EAq0HX1t3bYUpcTe9p7CGBHKmY/QzK4UB580QnyRndiAV62FLf1PleOLLCBUK+LmSCVgIH7kDpFKDvBVXi2Va3L/BY1dHMxqZ88E/LTf66SpXVHVYegeN2W/mCFm358d9n9etbk/hXdU5mxFALDGfx24XaG3IwMl8EmLoDIxK7znTIwu9mANPI+YVmZNAR3ca92InlLYLuMyNLbOWocNHk8fJCGDHbMG/1y8PcI1u/mKzk/pOAfg1ZLogWRzAAhQObyD51wnahQ6CFMiVQ6qOw95pJ+w7xfKmw3oRqKGvW5Xh6VEj+Cx5/93vpg/0As8SI+LxofKYK2kjLI/nXjxtxTOn81Zx/QWLUEvc8Ay9ZrbrAGR0U5ckLmHvQpzNIz16kurhDS6z4ZsfIOUa2F5WzBO7C3w5BKeUCw6SMq471b1H9QXKECpRq X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc766a2b-227a-4861-154f-08dd0301a338 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 10:06:12.6804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hBDzhMjPuThNpM+MEh7gsJfSdFISZ7BbvWSQ1noADui5xBIehY2FnmCCx6hdETXyKS71pOq0SwBdMrfgP/0T/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8256 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_020617_715033_9194B5B8 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The next bridge in bridge chain could be a panel bridge or a non-panel bridge. Use devm_drm_of_get_bridge() to replace the combination function calls of of_drm_find_panel() and devm_drm_panel_bridge_add() to get either a panel bridge or a non-panel bridge, instead of getting a panel bridge only. Signed-off-by: Liu Ying Reviewed-by: Dmitry Baryshkov --- v6: * No change. v5: * No change. v4: * No change. v3: * Collect Dmitry' R-b tag. v2: * No change. drivers/gpu/drm/bridge/fsl-ldb.c | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 0e4bac7dd04f..b559f3e0bef6 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -15,7 +15,6 @@ #include #include #include -#include #define LDB_CTRL_CH0_ENABLE BIT(0) #define LDB_CTRL_CH0_DI_SELECT BIT(1) @@ -86,7 +85,7 @@ static const struct fsl_ldb_devdata fsl_ldb_devdata[] = { struct fsl_ldb { struct device *dev; struct drm_bridge bridge; - struct drm_bridge *panel_bridge; + struct drm_bridge *next_bridge; struct clk *clk; struct regmap *regmap; const struct fsl_ldb_devdata *devdata; @@ -117,7 +116,7 @@ static int fsl_ldb_attach(struct drm_bridge *bridge, { struct fsl_ldb *fsl_ldb = to_fsl_ldb(bridge); - return drm_bridge_attach(bridge->encoder, fsl_ldb->panel_bridge, + return drm_bridge_attach(bridge->encoder, fsl_ldb->next_bridge, bridge, flags); } @@ -292,9 +291,7 @@ static const struct drm_bridge_funcs funcs = { static int fsl_ldb_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *panel_node; struct device_node *remote1, *remote2; - struct drm_panel *panel; struct fsl_ldb *fsl_ldb; int dual_link; @@ -318,33 +315,27 @@ static int fsl_ldb_probe(struct platform_device *pdev) if (IS_ERR(fsl_ldb->regmap)) return PTR_ERR(fsl_ldb->regmap); - /* Locate the remote ports and the panel node */ + /* Locate the remote ports. */ remote1 = of_graph_get_remote_node(dev->of_node, 1, 0); remote2 = of_graph_get_remote_node(dev->of_node, 2, 0); fsl_ldb->ch0_enabled = (remote1 != NULL); fsl_ldb->ch1_enabled = (remote2 != NULL); - panel_node = of_node_get(remote1 ? remote1 : remote2); of_node_put(remote1); of_node_put(remote2); - if (!fsl_ldb->ch0_enabled && !fsl_ldb->ch1_enabled) { - of_node_put(panel_node); - return dev_err_probe(dev, -ENXIO, "No panel node found"); - } + if (!fsl_ldb->ch0_enabled && !fsl_ldb->ch1_enabled) + return dev_err_probe(dev, -ENXIO, "No next bridge node found"); dev_dbg(dev, "Using %s\n", fsl_ldb_is_dual(fsl_ldb) ? "dual-link mode" : fsl_ldb->ch0_enabled ? "channel 0" : "channel 1"); - panel = of_drm_find_panel(panel_node); - of_node_put(panel_node); - if (IS_ERR(panel)) - return PTR_ERR(panel); - - fsl_ldb->panel_bridge = devm_drm_panel_bridge_add(dev, panel); - if (IS_ERR(fsl_ldb->panel_bridge)) - return PTR_ERR(fsl_ldb->panel_bridge); - + fsl_ldb->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, + fsl_ldb->ch0_enabled ? 1 : 2, + 0); + if (IS_ERR(fsl_ldb->next_bridge)) + return dev_err_probe(dev, PTR_ERR(fsl_ldb->next_bridge), + "failed to get next bridge\n"); if (fsl_ldb_is_dual(fsl_ldb)) { struct device_node *port1, *port2; From patchwork Tue Nov 12 10:05:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 13872051 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FAA7D32D8B for ; Tue, 12 Nov 2024 10:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XGfk6W2JCj4wpC6o+Qwd+LjQx3NGxQw6YEQqOKv1cTs=; b=WVOE1faukAsFZiPAgtL9No5kMZ vVrLxGMAO+R3OIQhavKPU6aiWOmSMti9cFYAb9raC72kmibo4IpwyC1JmymPmQuk3XqxAKqcVyP1M hAILnP9tJRokegRecgStX/ijplvHmB8EOBP+d9Si6PkGcRZ6qCw0sHGur2kmSwVaVBjgdX56oOIHE OLlSflvq1NoUwfvTrldGjnNm7hgqUf7k0cE1isrwm2UfkVbfme4OzDsnBThqz7WDBNJkfGdtViryf NtTRAy4RionRdp6T8p6+xXpwnLSYJ4fcGyhJ4uJifc0dSQTzKJZ91ixsr5Fv+vDDaI2ajZ6PbplBO jfNauL5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAnx6-000000030H1-0RLL; Tue, 12 Nov 2024 10:16:52 +0000 Received: from mail-db8eur05on20613.outbound.protection.outlook.com ([2a01:111:f403:2614::613] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAnn1-00000002yDx-1yFI for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2024 10:06:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N8k+ymnDbeffNSmHu/6me1G1rTLN1ca5zpGMKBo6Kv/8vYz53UpAUbiG1erjTF4tTnuTYnZE9IhrINaZ5R73E69PUX/wXyy6Ek63yFX5uoQv1zpLc0L0ZdqS3s/CVKtbdJ9sI9nLwvCRioLjdyzPR38owjF7JdCtWI6fE/lmnjK/POGVkmMWHOWipXX04FGVhtJgkRLSfVIHo48PpLFWyOHKwUrcfh2dOcnNMn6z/0fx8wf3At0hjqD3hAtz+du+zpPC/U/rQcRbeXrDgr2Ym1Xi+/aeJHcUNeKAEXl0tLKrTet6NzazCZA8Oxjl6rk5A4On4fIuD7DLjNhdo45ZKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XGfk6W2JCj4wpC6o+Qwd+LjQx3NGxQw6YEQqOKv1cTs=; b=KfYtEsaaGPCIBulLzTcqBbP6ispyPib+ywM7oM9Ye5pdCqRPKAND6pkjV9qykeVb1NyNizDK9p7iGOTLqlP56vYKFCN0KLgAHxP/okSG569D4odswdbejed2Q0sgrUhQnGccLEjByPEpNxhA9oJ6ARJ3kpXhAN5fnsCH+nfX09mqtDj1ZR/X4QaKLQwkN/QZlbKCd/G68vvWuGGE8i2P6Aw7Cly6gLrv9PStU1k643ltiixXwl/f4r2K9sTSzkbBVJbDgDaHLz3mfOOZNKfUmPC4hvVgQK0L3GYcCFELzIQhKmQnIWSGW2589bWKQW0vju3eXYeQ0UZKjAVxhCNxvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XGfk6W2JCj4wpC6o+Qwd+LjQx3NGxQw6YEQqOKv1cTs=; b=hRYRVW0Cbnqxt2HqAxhYlu7tr+LK+tE2qeGM7LsRWt0fVPUOa7P8PvX7Or1JteqXBZwyxtIUTCP0soxv5vNORbjeieVq9VFa928y4axvE1K8Wa/Qko/jhAr/wvdm7vf0Jgx87/jJyoZyyiemlfvhnw6pmAcxSyIvsc/lC+bXVbzwfgw2vSTRtjbuDz2RyL9d4Nzn60nBbGrUZ3FutT9HQHxVpjhuXac62Jk1jzaWXBvSlomOBWR6rJHPVMKqGaceCGnDJ6LekD/UonXpYSPMUeOpTBWKGIjUnWkM9K0b9Yu5c/YjYY7q65Sk3WCE90qrff6upAzIMVM74jZkhwMwsg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS8PR04MB7879.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Tue, 12 Nov 2024 10:06:22 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Tue, 12 Nov 2024 10:06:22 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v6 4/7] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "ldb" clock rate Date: Tue, 12 Nov 2024 18:05:44 +0800 Message-Id: <20241112100547.2908497-5-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241112100547.2908497-1-victor.liu@nxp.com> References: <20241112100547.2908497-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:3:18::13) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS8PR04MB7879:EE_ X-MS-Office365-Filtering-Correlation-Id: a27ea734-9a13-4754-cc32-08dd0301a8bd X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: MkNLkFBMlWRWcJa6ix3+a7zUIaWdhQjPTPAz/3U2aCV1RAkNvbg62eo90h4HPRnmIQjNTAxB6onVV7TMgMvR7/IIluzaTISBv+B7EoczHvTIl6Q6Blr1abh9l6N79lFE83Mkm6y6KzY2vVpL/Ucpai/vDxw3PCdrc5zsfv2mSDUjwu6vleelEN8nZodcg0QNj34Wy8wQK6wPGP5ZBtHkwC5Tm4X8ARNFtw6+s2giOC1S6UE2EzS+XUczSgfmZjwXvsF5J/NMcttIsAIlWi1iRkTNXtOFnRjfxeBxGlbvtqYrkWEumoSh7nAu/fopfot8HkW36csMypPFyZJCzo1KBUrAlZQu4cyJ+jymgoulvTMP6dNR49+l6JVemnBy3sZDkijbDUUjcgAHc9jCnt75PFKJso4kegmXD8g/WxJev3p9iGUOCBFD8ygAHmILOeXX/wY1jHAnfkQSiz1FTZtWcXi7M0R15Hzxx795DD/lzPsQfFlkcRwhRyqNkXp4yXS0bdB2UU5yB5jZ8GKScQcUV0P4vF30fF5FKO7VgcdrmFAT2Ud0PDFE5badsXHnh7MnQuud75jAP+uOi4KHtgqHNcpmiW0yWyH2h3xwbe7CTqtH5MAthi5509OZE8WnmTKLztTtUw8HL9MFdI6WYVmQfmeYhbw2IS4P5hJbbBirlCuerSgjrmrBu2nv47xUYfGhgMlVAUB2mXOF3ooIaU0XM2kMHZ54f3oTEj8BU4xeJG4kaGkTGAo0Y9ia/J31u95KXaqMmCHjG8mZFFyphrV4/BA/sOnDp/mtvBYKXALI2ry2Y4FHm2fuQcBrgZOZJfq0qfdf7xyTGsF2hGESJ+0MsxYzlR8cNz8qG8MGdoyfmAUZmmLWkUodTyUiWm9dLNPz09cionvF/jO7vYH4qAykK5+crJ8qBgU0AdELCX6YIHoE3kRqrQ5TMXHlGCQA84jzDCrWTFPADwKiHcAbIxOhECl604msdb3pt2sxSic27NsIQIU81LJ+e0o3kAAZWNgpyryyjcs8wM7ugyD/8xFt8WmP/C+pfcssB1urtVnfSr9nSy128rOHlFpmfOjAoHBQFLFTMUltf4tZCQqgnB32u6C1BjTyrlbKofONjndxPBPVhH13OaxoPPeCkoiuOm29YsoFzX7053TXO6D78iZwLMG792LGdcGWq8WEI6SduJJwig9FWl/sWYYDDsj9wbJ2r05jjkiURe2kX+Z3HIYUS65c57S3X8gCTtySJWCqkUHrdggwt2BvjCWwNKIndJU3c6iWdmQC1gNwSLeY0l8bzNdxdsnR6Mk5+Z4nMgKSE1GLdXCgdNKpRiYCdLhY9Jb50WKmoSiccTLmD5oqRXLAi9cbVWCM+Pk9+0MdV+tP3P22yOd1qOnPcHhGVjmG1mOG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: e0S/fUUCrL8FOH2q4e4hfdNI4PfKj3ra+iRha9RhkeWMAUBPdB4xzOzSKaBXMOOngQ1JJKewvQ6hZwGLxUkLhjgn8Qeg6OUARccm9knViboOWBSGLhl0pikZUki281XvwY+2Hu+R4jnUzSBqibO3eAK4n9f2nscq4+9/NrKmzy7BSSOFpaamMqtYjkVsbW0jStGj++wS7dt4pra03yBTj7GxjEUwAYwUxeCbEqiELl7rJyfudCYasMreJvMapzwEr8sp52hrmgkA7RPwmMBpsvSP1FKQeApvPaJYNdG6Nr0G5q2GTdED4cKjwZMNAKFiv7NsGmDXNkuuQ1Rh30XsjzFzV9BUiWFzCA1jhfZrn5FXcFdMIvM+OoioBdqCpPxqDdNpOoa+Kaq2mH6uUFzUlLLuuMpB0YRyGDcqb/7B0Y6DD56aKnCFtLIclhlCVPT03BSLVYCHl3exkW3x67cgP1z3oUiam9z/84WYQMYNs+OTpChIG0f4ryClcKBmmYhvgN1BAP3yM4qJ+FIDCvgeppotiVjthRTnZLPUzKtd3ZECn31u6mVgzFHbWpNaXWwyaaT6lCHGYXHdii+AN7dOxlZraknpOPhrc9PFjuIJsU55NswENXY9s0euZ5osXOv4L6fwlknuoqERzzd0uEN/pT7ecQDSMGqOb8swENKatCQlu7gBIB8g0vSuG5Qyc75GKMDs7CA52biEbgm2mBwmNK1Ilj0zs4DBJlMFLFgUdsQVAqcWoGYsMcRgWpRKRPh1yAvXljknU63g05QzzVy1Pe5wyxCOZIXaFmIwR+j3cN82TBV9wZtzQVl9F/mrfiqgwi9ECP8SY134rco10cd1KMIwy2ysWDAGKgtFHE+SMj6uGEPBt7t7SgakdDWBAmngkisZydfxjvpRMOFXfq0SIyC560kEMHbqHzbrggyVs7WEVFFtHVxLPKJt1YO3myS0SpnBKiy5jmbSuaB1Z1AAgjs8vfoUo0siCe0PnWYk5ZQp56kKAMOba5dcXom+w7JzzYSgDTt6Kya/l+AiPVV+Sd/pq/cetZApFlU6dwfbeg1R6bhfCc3oGqHF5kbIWFiHgbAsvXrFUwQ44Mj0FsVD5+0JQpSQo69Xp//s3SjIlTeNZsHcBxrVhDNxf7csk1eoQ7wGkEO8/+MHnBo9IJjY2jERhw6qLM7cCZZXDsNdrcEpqPibJwhyIwgQ6sBPO3NakQKtoJm5Cttv9g9mS1mVgeXX6jd+8zGMelwHq9wh4GV9RTVX6yz/f/CJsj5I/4cQzP6ZN3dUCqPM6rbRrLpp4wfF1QCNVGM3flbnM/cEZDJqRq4kTCb/3kK89Zhkj53y6UHahcEwzM71dyK/+5vbws1jXM2pOdeSzrzETa8V0bE7/S4dsyhMRTu0KcxWPkwWK2r7UAZUw17Ah/q7T4QbwBm3CGIH93kY9QmgtO8csfhxu1bn7ZQjsEZ3paeGZMUuti1ajR+GUijg+ALSlHFsYobrKqrg/j0Lre/MbKcD3hWMCq3EvfqWbS1F6+S2f7Wb1a/RqYAQ+Mjsirg7BIJmJLK9edqk2zch5l0+tvRvCzvuRbh8xpUTcrG1/7E+vEK4 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a27ea734-9a13-4754-cc32-08dd0301a8bd X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 10:06:21.9383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GEjV3ou7ljY2gkzMRaTPBzu8MiLqXA6cybk0HlSHNHNETq0nq67nFTCvXmahoDehRtU7XvYh5IRapVpI2U7ghw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7879 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_020627_539037_440AE0F1 X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Multiple display modes could be read from a display device's EDID. Use clk_round_rate() to validate the "ldb" clock rate for each mode in drm_bridge_funcs::mode_valid() to filter unsupported modes out. Signed-off-by: Liu Ying --- Note that this patch depends on a patch in shawnguo/imx/fixes: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20241017031146.157996-1-marex@denx.de/ v6: * Drop pixel clock rate validation. v5: * No change. v4: * No change. v3: * No change. v2: * Add more comments in fsl-ldb.c and commit message about pixel clock rate validation. (Maxime) drivers/gpu/drm/bridge/fsl-ldb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index b559f3e0bef6..d9436ff9ccc3 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -270,10 +270,16 @@ fsl_ldb_mode_valid(struct drm_bridge *bridge, const struct drm_display_mode *mode) { struct fsl_ldb *fsl_ldb = to_fsl_ldb(bridge); + unsigned long link_freq; if (mode->clock > (fsl_ldb_is_dual(fsl_ldb) ? 160000 : 80000)) return MODE_CLOCK_HIGH; + /* Validate "ldb" clock rate. */ + link_freq = fsl_ldb_link_frequency(fsl_ldb, mode->clock); + if (link_freq != clk_round_rate(fsl_ldb->clk, link_freq)) + return MODE_NOCLOCK; + return MODE_OK; } From patchwork Tue Nov 12 10:05:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 13872052 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAC7BD32D8B for ; Tue, 12 Nov 2024 10:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FVq4WTIZEOvtLEM4VG8GmR/3IxEaIULs8rknSzC85r8=; b=dDzEBW9iDop0KnzgbobXuULL/0 UhOy1SDPisXJjWz3Wn5jKB1OHRKyLCoBFe4EdXutwMmkD7bvQRnvPsfWL5vBbozoPGK5/NfrXw+FA VvK0e4vQ0knupgZ3r/ocCN++1qmMbzA0MbpKCo9PgF6Ib80XtB6EPm/eYE4v+SOJgiy5xPFIOxJE/ ni49E44DB1CxsaQ21Liec1ytJVufN8WaMtRjAHvA6H9h+9AXGY2lD/ykLZWypdJoRg+udII/IKpg9 +xSdluwj9xUVGbFWuRzw0S/+u5CL9+4GA8fSwi19oIBXjpooBw6ui5mmMk1jKdGX8gADDwc/nchag TUIGPylw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAnys-000000030qc-2XVP; Tue, 12 Nov 2024 10:18:42 +0000 Received: from mail-am6eur05on20620.outbound.protection.outlook.com ([2a01:111:f403:2612::620] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAnn9-00000002yG2-1gkB for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2024 10:06:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m2LkA78cP7IFtJdtsavQsWSJv3GbCIzInSEHYhu4bJrUBG/ixVNsrAOGVStv5jWHgz9H9iUMjVNfdXs9c5ADcPpooOwgRS+0EtQw3urwlHjo5lRa43YtKku+qbmuqGsYgKUq+ynAxnncsGwbJ7haf//bEvOrt/YwlxnGSFfyV7f4so6bab60Ye+saLGsOiB1WemPmjUF0+WHgyCuQUPT2hGWi2JVi1wTFNI5OYh0PBbIz+YKPNku0MSwFpWbNiyeQzqT7NRw4lo4KexoqERWIvfxmSTwGqrz/7tQjH8e5p39fqk4GYthuDK2m0X74k3izyyLnxioRzakCCjnxFiWTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FVq4WTIZEOvtLEM4VG8GmR/3IxEaIULs8rknSzC85r8=; b=EJ7DjTnKJTl9FqdrmF/XaBokvcYKETihXf0Nck8RRmZAXijiW+yPNNv+2HZCUnzNCOgBsfEeUTHtFpTrghHd0nEYGGq64QTeKq5iHQ0YppUWoNmYZaGoOpQfrnupiWcj0vfJII5TiD9HyQDDKQL6PxqJQt9C80O2P9+/rwYTh/l2cUFqGD19IcaQAixjE7p6NUpBRrK2gzVBuzaxIaxk/Ib2Mwylkoxm8NyQgS7UZxHJPX97LPD6CEzg6zPoCGK43et+aA4AR3H8eSL+wMUyJZsv1A2KJ3wnq2sbQ+2tjYA6X+tgRHfOIfPw6PlRBNDpxVYhyC6suONDR2CTvdgkOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FVq4WTIZEOvtLEM4VG8GmR/3IxEaIULs8rknSzC85r8=; b=P6F8pc26tjlUULbUn5a7PH5++tP1BxlmBq6e1xiIWlkFRKa38vEYKolIwsxPfJKqq8g+j93yaS1EwDz/rG787iMO0lzZhhrkNM51PjH3Tw+Oli6TPGxTra3WZN0cL0veIeS6VVkkoQCxLPtdWCgIGU8x6Qx3paAUeCwezb1LyW3q7R63jhnQCcE5KBvjOlKTtSOwZvIhioAJGOj7yQ30wFp2qIxe2fHl4csfDVhfbQbPNjYV25VmbT7A5d3Bv5OENu/4aaaFfibEgiWuz0SdM+G/E549kK3P0l4mkNrNhFfxoiLlXIK/sS6siY+WvCPi5KmN7URIGRKNXKpUPQTZLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS8PR04MB7879.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Tue, 12 Nov 2024 10:06:31 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Tue, 12 Nov 2024 10:06:31 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v6 5/7] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "pix" clock rate Date: Tue, 12 Nov 2024 18:05:45 +0800 Message-Id: <20241112100547.2908497-6-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241112100547.2908497-1-victor.liu@nxp.com> References: <20241112100547.2908497-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:3:18::13) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS8PR04MB7879:EE_ X-MS-Office365-Filtering-Correlation-Id: f8d9f606-ab08-4baa-e834-08dd0301ae42 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: Vo4aYelIc+pmkTPKoYDKNgr+KtD51hDFP8cr2COg0KOfxwhsaQceBXEoxsloC4xRmpp6vBiJcjtYgkZFvqUu/LNJx7v5fD/8dJ9Z23nSkyru/oPtAX8dap/hy8h+IM/s20/uSNvbVGNR1AihvLdwoFea4jALp9kwXN8Jo2RBFMHTXaWx7wjmXRKk4NSSNKoeajNj62CHWIV1lnl8sthpux+Xe2RcTZ2j7w/cxKHjt0RiEOoSRj++zJrK3Dp3O9JBsGjEoBhc0h6t5/Je3KHSXiPxo80ku3khdQ+OCq2rYQHVshN8aGfkkhBWPoSqGMDPA50mJ54KWxWI3BGaBo0CZJcvKssP4dhlS+I5bI38miQIk3Mtrs3eCTmyrK/Ha0H8UOOHxFPOu1RmtKjH/z5iqcw07SDSDJy9LIRGvTCrS+xYkrc2kEQ3s7VVI83zsQgYmuHN+v8TkA0H6Wqjx4NRGUtogR6bfmVusSZYOGFQgqvbb4NX15qM4LMVym6BW/5VgmPY7SoOdEy/m2vIKS/mnEBn88NIIuvboOJn5+8y6oKAJRXIxvwXaHHSGmmxhpiyO9qUdLFywfviBWc1edV/7PEeuKGzAZvky+Yn3C5dxlNxKfPv4gFQ6v7yxgjD/RpjIgy0ibauj3cIuqWY48nJ6m5YE14CA057sUEheVGWjhvyan/Fg+5ojhu/kyW1Rpdw7zg3x4pllgz27SqE/Sleq4wIM31K9zA1nVrsFSD6UfFtO78n9bX4fTvcyBd5elTrDiRzzBjXBhpI38AYZLLZmWIY3CdbjISGXdyRptrUDtEadjG4B42o7e4dAs24kppNc84Ly64OOXqGyMi2mU4gPnqomrjUxDmfrrWwjQEhmWiDFGV+FLsDGqFm3ujZlUemfkwVwAcADZXjuglOnxolg3YOULZG26sQIn23JwE9Ge68IkLVnQFNeUw12Y9gAqItvTm3GHnsYQHJs3tNqoI9RgTIUCOisB35UIVCYlOf14aMWwKl8NX0icT/H7M51GK/rPszX201fFK6ZT7EZ2UaLcJEy+2egDpxTgpX7M+MjZ/Ri7FEoP6pgssQ49j5wMa6AhJbMbeuMUIRq8LYNLKpC7dKrHDy4b7Iz/T6mtH5D9qESy/DqTDwEbYG9mJRF8cy4hQpYIdLEahkrd2QWriE35mVbP8tmZ+X421/G4HRoO7XPhuIYscB9Ricj+S9DZ0Gg2dSGQF1e55IchkUm9MLBBXLW61PvJYfYNltfI6QkyxG7OUenD8B9yaTB2pYN1spmsCuUDHcLG4Wful/6b4c3pXd0jHJmN8C5DUp1R9jiFNlSbcPN37s8S2G4uO3GmNoPwJZSTHjy4J9+VReMHUR8FSb9jEiX2m1j9N3SAwqSzo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5G7NEnP2aQabAny+atjNYXOHwQk+ngWlznSW3WOZAQeMKf7BqerxbPNVWV4ptkDW6P9iiBrlgq1dTFuF0yQOYpyOhDTOdCWDobPzZr9xD3ad2MF6mKuEjejqN88Yc+KscAXc19tSrPoboU97K2Mm+9MTQdr9Ud+G87lUPkZo6Oe25t/J63ANXJfUdZHyigAXbZy+X92l8wK6ZZmZqjFDDKcGEWVBOFbBzMTvDvWYLyzAofO+LTEmadIaoz78TlVSsCPuHPhf5S44Ma6OcP922C9byk4c/Ygt9ziZVhbp9rQN3nrsFQl7W6RAk1xtrxjE1yVUMQt4+DSXxjj9Ta450oyXbv8aQA/wroFBzqjCtEUhRfdH6uHIYRkRtioX3X6+8//lKX+d8uewjmZBrYKayAvf+DbpZfW6k4gFFmm2SEhq0zD0QZiGg20+Jqmrn3/p+DLEQx9rwdO1Rk5lAK67P7nEXdddq99RmDlAVb+7snb3qxnIPrjiFikQnC84HPh/u4Ce66wKPFvJ7jfFoVKvzRMgacoTGjYj6HD48haoG0cx5A82qAAK2NqbROlM7GL6VYRv6EsxQg0yKUbS3EOjC4wsBGSDECifuuRwAtAEAcQ6v1Fike1epkjWyrsPiPs4TfEPlYWNaGDyvZowNZg/sN/qoMkPKKt2UX2N+p5zxxyh8vYcadPvi4/6hPiBsOgJ89Wpc/eU6yycmc88b9U0V9RsTN/UNvv+VdV4kptdKRHHIxxWZ2btaRpI3pzrzXhnKUpcDvbj95nr5TcAdJeggAnB614a4c/BuqS9LXifPTes1YBQnX4hUS+bJVMhaA9icCe5WpLsEWnEs00kmHv+/RvdvJvvTgxkQIBLTeHFYVR1xn3TndXmswquzC03G+QXYaXOD1+Yyru1QzIQModIGqMcU6zYTqDM4I6Jip+dd6zOwXMTjICcBx4y5/42zg7diTf2oFH24DHI6PrV7sPfo/GmYtKF2T7PNh/B4bdOgOpyvap/wbSQ/zhymTtUPL5f9+IxUYGitweBCwfl5pN/TievXatvwjWj6DZEdjBgKpNuB5SUXBDNgJTgifEIZXFZKc7FHoV+WQE2LxgXHHVz1kaQwDBccXDr1JgT0e+crJOV1x/p70IV29cOnGktG1+/YZUO7/oY2bwskFec3RvKNo1FfSUL/wEwGgEayFXkd7IT21Qx8+tnZPrBb3Ns8j+4NBAzogQg7U8JiMuoOHZQJ3NktOOBTdrsqN0SLdvrujoCt6bBV/CHfTWLdWM5qPdDM5Hg70rgFw3GKFUYkDHz8PEHuUUfj+KrDfDTD5ZVp9lPFdNZRLVaTeLKOxcL8UMn6xbupe7uVLmo+yNYKLoHUT1bI8vom0JAS8dS4ht1/tEEhpYrt+lCk6jWsZZbOT3YO8XbCJfupsl7fAYdjRXd8x1x1AaADHSHmar1S+5ajB1X+wqYi5aGJMbP3IA3hQQ96Ofttv+oBjkN7+LIdz6W//neR6sZksI+b1XMvg2qq2yhmra4DnBCpsnUZ+Pn46C4A2tzx6D/gE0e3B5hTbXkVgvBbHq+jUnUEk4HT71IqN+sBwvCPsWMi+doVzk3sEGM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8d9f606-ab08-4baa-e834-08dd0301ae42 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 10:06:31.3887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZHnYoxrG4c6uYNEKEMVayIlwx2xN3WsFgmCb5vOEJI3d7I+4e1UrFZIGZBvmdb+V045gl+7GJxpDLxwCR5vBWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7879 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_020635_616041_6C92AAF3 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Same to "ldb" clock rate validation, call clk_round_rate() to validate "pix"(pixel clock) rate too. This may filter modes out whose pixel clock rates cannot be supported by the pixel clock tree. For example, when the pixel clock is derived from the i.MX8MP video_pll1_out clock and video_pll1_out clock rate is 1.0395GHz, mode 720x576p@50Hz with 27MHz pixel clock rate will be filtered out in LDB split mode because the PLL clock rate does satisfy the "ldb" clock rate(27MHz * 3.5 = 94.5MHz) with 11 division ratio while it cannot satisfy the "pix" clock rate with 38.5 division ratio(only integer division ratio is supported). Signed-off-by: Liu Ying --- v6: * New patch. drivers/gpu/drm/bridge/fsl-ldb.c | 38 +++++++++++++++++++++++--------- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index d9436ff9ccc3..035a3ffb4b3b 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -86,7 +87,8 @@ struct fsl_ldb { struct device *dev; struct drm_bridge bridge; struct drm_bridge *next_bridge; - struct clk *clk; + struct clk *clk_ldb; + struct clk *clk_pixel; struct regmap *regmap; const struct fsl_ldb_devdata *devdata; bool ch0_enabled; @@ -176,15 +178,15 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge, mode = &crtc_state->adjusted_mode; requested_link_freq = fsl_ldb_link_frequency(fsl_ldb, mode->clock); - clk_set_rate(fsl_ldb->clk, requested_link_freq); + clk_set_rate(fsl_ldb->clk_ldb, requested_link_freq); - configured_link_freq = clk_get_rate(fsl_ldb->clk); + configured_link_freq = clk_get_rate(fsl_ldb->clk_ldb); if (configured_link_freq != requested_link_freq) dev_warn(fsl_ldb->dev, "Configured LDB clock (%lu Hz) does not match requested LVDS clock: %lu Hz\n", configured_link_freq, requested_link_freq); - clk_prepare_enable(fsl_ldb->clk); + clk_prepare_enable(fsl_ldb->clk_ldb); /* Program LDB_CTRL */ reg = (fsl_ldb->ch0_enabled ? LDB_CTRL_CH0_ENABLE : 0) | @@ -237,7 +239,7 @@ static void fsl_ldb_atomic_disable(struct drm_bridge *bridge, regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->lvds_ctrl, 0); regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->ldb_ctrl, 0); - clk_disable_unprepare(fsl_ldb->clk); + clk_disable_unprepare(fsl_ldb->clk_ldb); } #define MAX_INPUT_SEL_FORMATS 1 @@ -269,15 +271,21 @@ fsl_ldb_mode_valid(struct drm_bridge *bridge, const struct drm_display_info *info, const struct drm_display_mode *mode) { + unsigned long link_freq, pclk_rate, rounded_pclk_rate; struct fsl_ldb *fsl_ldb = to_fsl_ldb(bridge); - unsigned long link_freq; if (mode->clock > (fsl_ldb_is_dual(fsl_ldb) ? 160000 : 80000)) return MODE_CLOCK_HIGH; /* Validate "ldb" clock rate. */ link_freq = fsl_ldb_link_frequency(fsl_ldb, mode->clock); - if (link_freq != clk_round_rate(fsl_ldb->clk, link_freq)) + if (link_freq != clk_round_rate(fsl_ldb->clk_ldb, link_freq)) + return MODE_NOCLOCK; + + /* Validate pixel clock rate. */ + pclk_rate = mode->clock * HZ_PER_KHZ; + rounded_pclk_rate = clk_round_rate(fsl_ldb->clk_pixel, pclk_rate); + if (rounded_pclk_rate != pclk_rate) return MODE_NOCLOCK; return MODE_OK; @@ -297,7 +305,7 @@ static const struct drm_bridge_funcs funcs = { static int fsl_ldb_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *remote1, *remote2; + struct device_node *remote0, *remote1, *remote2; struct fsl_ldb *fsl_ldb; int dual_link; @@ -313,9 +321,16 @@ static int fsl_ldb_probe(struct platform_device *pdev) fsl_ldb->bridge.funcs = &funcs; fsl_ldb->bridge.of_node = dev->of_node; - fsl_ldb->clk = devm_clk_get(dev, "ldb"); - if (IS_ERR(fsl_ldb->clk)) - return PTR_ERR(fsl_ldb->clk); + fsl_ldb->clk_ldb = devm_clk_get(dev, "ldb"); + if (IS_ERR(fsl_ldb->clk_ldb)) + return PTR_ERR(fsl_ldb->clk_ldb); + + /* Get pixel clock from display controller's OF node. */ + remote0 = of_graph_get_remote_node(dev->of_node, 0, 0); + fsl_ldb->clk_pixel = of_clk_get_by_name(remote0, "pix"); + of_node_put(remote0); + if (IS_ERR(fsl_ldb->clk_pixel)) + return PTR_ERR(fsl_ldb->clk_pixel); fsl_ldb->regmap = syscon_node_to_regmap(dev->of_node->parent); if (IS_ERR(fsl_ldb->regmap)) @@ -375,6 +390,7 @@ static void fsl_ldb_remove(struct platform_device *pdev) struct fsl_ldb *fsl_ldb = platform_get_drvdata(pdev); drm_bridge_remove(&fsl_ldb->bridge); + clk_put(fsl_ldb->clk_pixel); } static const struct of_device_id fsl_ldb_match[] = { From patchwork Tue Nov 12 10:05:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 13872064 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59FF0D32D8B for ; Tue, 12 Nov 2024 10:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wz76/czXOIyAUXsPpq8BGSSQVqXZUrTtitXNwj+2qq0=; b=TM1uyHxuAaQ9Bb9MEgS/x9/9pB pNpp+tuOsq6cOsXUylL7WYGH3B4aCtPMXm3x8i1ubHRpvN5i84tDBW0KO90muNK2omac4d8wCiEDk 3ZuxWFZoN2eCqs/FVNcRJVhIiA2kZrh7mxPyySjalLVti1LfWjzPFK6g3m9ikA5Swej96w+513/Lr aXFMOdI7+zewhpTchZ6sswf/4Wpes2eH5wwgsyaLHGR6X9HuW3106nqhdY9sG2XL1U3RKF0gknxIR jlshEKA85nUX5ZmdlZ/JdB/+m6oDn1N16WChaSZT/sHzqDPAxWaHiLNuXsqPtwrX9nxiDXrYDO30e kxARdJpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAo0g-000000031JI-1D2N; Tue, 12 Nov 2024 10:20:34 +0000 Received: from mail-vi1eur05on20629.outbound.protection.outlook.com ([2a01:111:f403:2613::629] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAnnJ-00000002yI3-3i9R for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2024 10:06:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=glynZ8WSDM3JbpSdG+2QaU0tnfhw9owzMdOfehxPWh93unk9iJzWdnU166FlXzt7QS3XmhmkvuNDNt67eb3R0Dwd7qW8zvbM5gw6CbzWSecRuidKT35j4JGlvwBSO1iAwIOCjZ2d26IQCFZsXtKKOs60WzywOWtzc3PSOOquDn0sPOcw456TlivopoMcR36k6d2JrvB8njIQyeu5R9jWZ3H46LoHg8+XQ0+kETTwQpyTTLZhxcVB/hctQY+zA7TBk/rxcDJbhg7NaABOpfVTL5Hw48AR0M2NOS1QP8miFwSZyit7moG+oIqo/jJsZjIVcHuf3fmxo2trDY8wFVRhxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wz76/czXOIyAUXsPpq8BGSSQVqXZUrTtitXNwj+2qq0=; b=UPiuHXCp2ssEmcJQtXfvbg6Lps1LqbjJJnWVdTQwP8D+tPHfvrh8EIarotg7ntHKPerowfvXqFeCfC0T142KT26/mLbdXWL1cuTDme8l38KUTXR+Dt+ROpoYFEdEFm7mdzkpfZU09+gQir/mMeQcglAKdDQip26PIagCrpmaLXNmIONnjF9NrYOEl1Ek0vXvhVzbPZic9KJ5D2k19lig/eBdRd8EZEMzKhfM6sdRSRwWSGG8omw1LqDGYt5BQggeTeWnnL6duGKhC9DftdoD7ppwW2OV6EOxYUTtWs3OhhgLMVk/ECxoX+oWF8XGpyp3LChwlxoibnW5Fbgz9yTpsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wz76/czXOIyAUXsPpq8BGSSQVqXZUrTtitXNwj+2qq0=; b=ZdTfqyBJp668sD+Nac1yCTDvotiTumkWxmAJne+0UEyxdE6W2y/mu/dPBMpz8A25VjDAKJgGEdaet3c+G7t/3L/r9aNdEX5hiuAp5/CFv80OwhU6EFsX6wyg56IdlbutyH2/y1Vl5xQrMyOmhYS4phqZHb3d1g8I9ABYHCo7upA4x0UDxF1oGn0jhEnFmdXPynAQB4MaLy3+z5je3T9d5iVJOoDSOhOkF551K7MPBcVe99zl85vDhdWK3K7sXXAYK6fdgEHdq5GKNPbXE2vBOOayoltm7g6xfK66LZQ3TxbXkK9dD6uRlRJ+1TijqYynJUFj8YRA8FaNs8Wz8sjKjw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS8PR04MB7879.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Tue, 12 Nov 2024 10:06:40 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Tue, 12 Nov 2024 10:06:40 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v6 6/7] arm64: dts: imx8mp-evk: Add NXP LVDS to HDMI adapter cards Date: Tue, 12 Nov 2024 18:05:46 +0800 Message-Id: <20241112100547.2908497-7-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241112100547.2908497-1-victor.liu@nxp.com> References: <20241112100547.2908497-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:3:18::13) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS8PR04MB7879:EE_ X-MS-Office365-Filtering-Correlation-Id: 89a6e98b-9895-4b90-9ae1-08dd0301b3ee X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: k/Q6DPlNLfcfh0LSancEgO5zDncCxFWNyGdhpiZ2/zQiPGQMJARW0l0d21oi6NC6lvtsVNHoMk/mbSEPN3nQ1fXgM19eu7BPdl0XgkshaPP48Mg9zHV+Nsu/Va7TcTP0KASQmGmmr9bz+8TJyZaSx2T3b/57pIWSgtORghoRazuaIVFC/glTG5+ws4bgmQatVAQwSpX1u/c7KraTweum6syqqNwFbj5mgVFGBm5RuiTl8Z0pYKIxR2E5O3x8lbSUtcgHtD095uUzO1Q5r7amky/1uEUgFxoK4aK3IXzJW68NpRHi3EulpTnlplEFUCSq1go8Py2AX2WSpLqWMKqPpSI90hdUm+J+63Q+FvjYVAXEFijQF41huQ4Sa7bjTvjzMTQ/2sIKilKxGTVv7yXL//hfC9C6z4upVUftcI7TqfEwBbRiqtoUu3yL5KZLT84uxd0hQrveSFzRbgYk0+T7jKBYyJW8ER2Xf+FNwoa4zPt7Cwl2mL5eFW3OQkbmMPN9OGB3yQ3354AhZfZSDKpHTX8PbLQfTRgVmOy5tP88tJhLimqndHYSR/l3EbViFq9gPGuLNJ52uMjH2tPvTUPN5AUCEJXIXFzQ07YEtJuwXVhtTixtoNbbJBk3dxWD39DJmx0wgJue9LwqPin+IevOJDrbPxXhMAx8YBaiu8C/xMf3CrGQLruJrEtf8qDj51RTepwTOYl3DV2ve9HPLUMURcEyOvxtcESjHnIbkm4SK1H4DIXgDlhpeVJHFISwccE8VK6wxR3e3WKVDwP9vhr6FVr8Sl4o/ON3hBWZPOT4vEWB8IqPAdLXKXWLI6rtd/A8dfFUA/TXTqIsf4xucf7P/NOivPp+gn1k41jNUwBukWNSUy0ByrQBLs+Sy3qvHDfPtReQ2Tb7oQo/vfxXu62ukZFXMj/1XnQZAvPhumOSCZG4DWYyUjz41GNP6pNyjGt2HPtU74wF1VRTnCiIdUDb292L8XOTxQAXjaKoccjJNroUAZEiPE8FzPUXdEmfmPjbJXkAb0rlMvmka1rU4MSQ25h9Qrvkc0St6s28BJofL6sW/XyuQZitQgqjvOhJ9Gy1COurAo2ali3KOaBSTChuiqsPQrTN8yzOLnNt4IchHScvE3XX4Z8zqrDL7NCbVWJfkFA++1IcwwgTIvxMYXs4NzJGhkPumlqNIGWhjQEkDkw8azFh6/i3Xf0MRr5JeFO0IWjLGcOn/5U5BWvMkBhXTQiEgSKDmMImCCjItV0GJjeM/qWrK4YYXfv2sF1Il1T7MFWgadUxDQ84/WFyAIXeBCFd0xXqF2k5dt4vKK8QndywsxwqWtfBHZ/nizfLyDnB3E7PnZt+KPWlw57RbY0UX5eXpuRpU2P2uB8F9EH+q2scZy5/3qaj+5z6QQHrUhXX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: L4vdBXWNNOzs2t3TPhOI3imrIYTVYrDJDKrFLf9W0k3/9w7Aq8Q51GxOjQKpEXHGkp9uZZHt+YEVMx9i04I2iyJJ66BWxOcmuNnKYytAQd6V7LzcRAI85Jb9rlysOKH6DquUtXYi3vGQHxoFogf3uSujltUl5VGmUl5fZLGzSaHj7LvuzkqyCgUYuZjlwEOz0CfA1KHH5x9r7g2wWKNCNoj1AES2VMyQ/7qYA7TRdTekSfk97wCFdPw3BH3mb57Tkxqlb0P8cGMmKOHbuJjWYpdWiPB7PV6NMj8ieJt4xC2ioRLiER7s7+FCLrrVTUDmWdyz4tHynCkHbZOYsCeSiJF/l6j8m11QRGnc15n601fI9NRXo1Fr+qQVAg9HXM4gYOUBTEkqj8SJY24b+7x6Jl2cHGEufshk5fB25rnGA86ppmRTMutPaQvBALq+F65oPcqWd63bhF9fOXoQWMEkqxkvvGoNJpCGBTfn4ipyqfG4rX5BhiMbI9AOiaXC9qDpkyT3lJS3hIklEAiNWW8/fFLieijdgV5a3KArRPq1xajWMx6n+MLzUZ0OPnJuIdvkUPzVesy3ApkTl3L2qi2VFvPzMiw0KWhXc0nP6YtkeBfPTb8+8vBQCNgLGfKbRaQBhbfz6Zn1HuKsfBbH3rQcLrYGbzLfv/cfxp3Eg5GmoKuBNt5sQJSoEZW/IPbNjAc9+YJOByOWn1dKgXNQJYXd9zLBkW01biQJGqdqfOKucqosEDbCBfOyWE/OhMJ9FEG1mcIppenhjyCjOuOPO743yppCdGtnLpwC33eYLtzqmqqrzDkwqBPwJ1UZVwpVKiN7vTw6T6MNuq8p30ER/kXk4gcFe3nAPsbyQ6tHksAy32/ioUybCW9AKYyl99MTEzevUuqyKfCErAdIFqsTbTLhvK2XsNW2Afe47ksqgPdFc+c3HoRWSSkGimfrF3c1lv6oRiv5yElktXenYMtQ/Z20pitTUt19GPDroqGr+kMJ2E1IZThuWCUMZaRzwuyuKra/n9uEiYKtd96BxAEgJ8x/M8x3L2MnWAwlERS6bCiowJ25yoFwn5xMss9jq0JBXezaK0X8Pucu6c5EviSB0CMzybx2Hj2Cp0I5WOGg7w9yilWBPxJWbvIztOSJkR18Hu7r+qjX4PT38CbYrxZyNsysGhYL8DDzfk0OXEeGbrtENkY1FRmKMPPvQnie8zjPu9sdaAUWWYOuSk2aAoLpP7RSMsqza8JV25cVnd2CKlI+TtGL83K39qJUg2q3kZBnT/DkaIOE1tVzXcfkzvvrJ04URs8+/jOFGzpDCv9N2/GGcgfCKTyB4lFg0J2/VP0tYqQeAH1Y53bpGyPjhNindqKVRYAE5Ja3HXTzIr74+8pRc0iqi8qYlUAjMZ7lEYo9nKeS+1JanDRPPwFoBBBdDeTR4dsYvHalWhrUXbe30VLC/sDja5ejpfxzbPRCzEX59hdS+Hk74hHp6CWGDISxtzxmdxM4Mh2NrZFi/EGxl+IbfaCdemCxVJgWl5iEbWg3yb14J386IPALE1oTQ4C9weSdLA66AAjiYj06i/0u0sYV/JL6y4+mZ5ARFOVYkZ5j7TKf X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89a6e98b-9895-4b90-9ae1-08dd0301b3ee X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 10:06:40.7493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fmchHrMDVGUfepJ3hziRa35MbUgPYbMmuaL75hFWOn19aHnbDeg+Lo1YSqPMHdOc0f1U8VKS9yeIxfffx0P+sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7879 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_020646_132785_130E5853 X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org One ITE IT6263 LVDS to HDMI converter is populated on NXP IMX-LVDS-HDMI and IMX-DLVDS-HDMI adapter cards. Card IMX-LVDS-HDMI supports single LVDS link(IT6263 link1). Card IMX-DLVDS-HDMI supports dual LVDS links(IT6263 link1 and link2). Only one card can be enabled with one i.MX8MP EVK. Add dedicated overlays to support the below four connections: 1) imx8mp-evk-lvds0-imx-lvds-hdmi.dtso: i.MX8MP EVK LVDS0 connector <=> LVDS adapter card J6(IT6263 link1) 2) imx8mp-evk-lvds1-imx-lvds-hdmi.dtso: i.MX8MP EVK LVDS1 connector <=> LVDS adapter card J6(IT6263 link1) 3) imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso: i.MX8MP EVK LVDS0 connector <=> DLVDS adapter card channel0(IT6263 link1) i.MX8MP EVK LVDS1 connector <=> DLVDS adapter card channel1(IT6263 link2) 4) imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso: i.MX8MP EVK LVDS1 connector <=> DLVDS adapter card channel0(IT6263 link1) i.MX8MP EVK LVDS0 connector <=> DLVDS adapter card channel1(IT6263 link2) Part links: https://www.nxp.com/part/IMX-LVDS-HDMI https://www.nxp.com/part/IMX-DLVDS-HDMI Signed-off-by: Liu Ying --- v6: * No change. v5: * No change. v4: * Rebase this patch upon next-20241025 to resolve conflicts when apply. v3: * Use data-mapping DT property instead of ite,lvds-link-num-data-lanes. (Dmitry, Biju) v2: * Add ite,lvds-link-num-data-lanes properties. arch/arm64/boot/dts/freescale/Makefile | 8 ++++ .../imx8mp-evk-imx-lvds-hdmi-common.dtsi | 29 ++++++++++++ ...8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso | 44 +++++++++++++++++++ ...imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi | 43 ++++++++++++++++++ .../imx8mp-evk-lvds0-imx-lvds-hdmi.dtso | 28 ++++++++++++ ...8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso | 44 +++++++++++++++++++ ...imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi | 43 ++++++++++++++++++ .../imx8mp-evk-lvds1-imx-lvds-hdmi.dtso | 28 ++++++++++++ arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 6 +++ 9 files changed, 273 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-imx-lvds-hdmi-common.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi.dtso diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 42e6482a31cb..e2e828b352e7 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -211,8 +211,16 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-wifi-ivy.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-wifi-mallow.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-wifi-yavia.dtb +imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0-dtbs += imx8mp-evk.dtb imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtbo +imx8mp-evk-lvds0-imx-lvds-hdmi-dtbs += imx8mp-evk.dtb imx8mp-evk-lvds0-imx-lvds-hdmi.dtbo +imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0-dtbs += imx8mp-evk.dtb imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtbo +imx8mp-evk-lvds1-imx-lvds-hdmi-dtbs += imx8mp-evk.dtb imx8mp-evk-lvds1-imx-lvds-hdmi.dtbo imx8mp-evk-mx8-dlvds-lcd1-dtbs += imx8mp-evk.dtb imx8mp-evk-mx8-dlvds-lcd1.dtbo imx8mp-evk-pcie-ep-dtbs += imx8mp-evk.dtb imx8mp-evk-pcie-ep.dtbo +dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-lvds0-imx-lvds-hdmi.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-lvds1-imx-lvds-hdmi.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-mx8-dlvds-lcd1.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-pcie-ep.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-imx-lvds-hdmi-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-evk-imx-lvds-hdmi-common.dtsi new file mode 100644 index 000000000000..44b30e9b3fde --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-imx-lvds-hdmi-common.dtsi @@ -0,0 +1,29 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +/dts-v1/; +/plugin/; + +&{/} { + lvds-hdmi-connector { + compatible = "hdmi-connector"; + label = "J2"; + type = "a"; + + port { + lvds2hdmi_connector_in: endpoint { + remote-endpoint = <&it6263_out>; + }; + }; + }; +}; + +&lcdif2 { + status = "okay"; +}; + +&lvds_bridge { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso new file mode 100644 index 000000000000..4008d2fd36d6 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso @@ -0,0 +1,44 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include "imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi" + +&it6263 { + ports { + port@0 { + reg = <0>; + dual-lvds-odd-pixels; + + it6263_lvds_link1: endpoint { + remote-endpoint = <&ldb_lvds_ch0>; + }; + }; + + port@1 { + reg = <1>; + dual-lvds-even-pixels; + + it6263_lvds_link2: endpoint { + remote-endpoint = <&ldb_lvds_ch1>; + }; + }; + }; +}; + +&lvds_bridge { + ports { + port@1 { + ldb_lvds_ch0: endpoint { + remote-endpoint = <&it6263_lvds_link1>; + }; + }; + + port@2 { + ldb_lvds_ch1: endpoint { + remote-endpoint = <&it6263_lvds_link2>; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi new file mode 100644 index 000000000000..6eae7477abf8 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi @@ -0,0 +1,43 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include +#include "imx8mp-evk-imx-lvds-hdmi-common.dtsi" + +&i2c2 { + #address-cells = <1>; + #size-cells = <0>; + + it6263: hdmi@4c { + compatible = "ite,it6263"; + reg = <0x4c>; + data-mapping = "jeida-24"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lvds_en>; + reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>; + ivdd-supply = <®_buck5>; + ovdd-supply = <®_vext_3v3>; + txavcc18-supply = <®_buck5>; + txavcc33-supply = <®_vext_3v3>; + pvcc1-supply = <®_buck5>; + pvcc2-supply = <®_buck5>; + avcc-supply = <®_vext_3v3>; + anvdd-supply = <®_buck5>; + apvdd-supply = <®_buck5>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@2 { + reg = <2>; + + it6263_out: endpoint { + remote-endpoint = <&lvds2hdmi_connector_in>; + }; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi.dtso b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi.dtso new file mode 100644 index 000000000000..9e11f261ad13 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi.dtso @@ -0,0 +1,28 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include "imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi" + +&it6263 { + ports { + port@0 { + reg = <0>; + + it6263_lvds_link1: endpoint { + remote-endpoint = <&ldb_lvds_ch0>; + }; + }; + }; +}; + +&lvds_bridge { + ports { + port@1 { + ldb_lvds_ch0: endpoint { + remote-endpoint = <&it6263_lvds_link1>; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso new file mode 100644 index 000000000000..af2e73e36a1b --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso @@ -0,0 +1,44 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include "imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi" + +&it6263 { + ports { + port@0 { + reg = <0>; + dual-lvds-even-pixels; + + it6263_lvds_link1: endpoint { + remote-endpoint = <&ldb_lvds_ch1>; + }; + }; + + port@1 { + reg = <1>; + dual-lvds-odd-pixels; + + it6263_lvds_link2: endpoint { + remote-endpoint = <&ldb_lvds_ch0>; + }; + }; + }; +}; + +&lvds_bridge { + ports { + port@1 { + ldb_lvds_ch0: endpoint { + remote-endpoint = <&it6263_lvds_link2>; + }; + }; + + port@2 { + ldb_lvds_ch1: endpoint { + remote-endpoint = <&it6263_lvds_link1>; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi new file mode 100644 index 000000000000..8cc9d361c2a4 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi @@ -0,0 +1,43 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include +#include "imx8mp-evk-imx-lvds-hdmi-common.dtsi" + +&i2c3 { + #address-cells = <1>; + #size-cells = <0>; + + it6263: hdmi@4c { + compatible = "ite,it6263"; + reg = <0x4c>; + data-mapping = "jeida-24"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lvds_en>; + reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>; + ivdd-supply = <®_buck5>; + ovdd-supply = <®_vext_3v3>; + txavcc18-supply = <®_buck5>; + txavcc33-supply = <®_vext_3v3>; + pvcc1-supply = <®_buck5>; + pvcc2-supply = <®_buck5>; + avcc-supply = <®_vext_3v3>; + anvdd-supply = <®_buck5>; + apvdd-supply = <®_buck5>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@2 { + reg = <2>; + + it6263_out: endpoint { + remote-endpoint = <&lvds2hdmi_connector_in>; + }; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi.dtso b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi.dtso new file mode 100644 index 000000000000..527a893a71b2 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi.dtso @@ -0,0 +1,28 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include "imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi" + +&it6263 { + ports { + port@0 { + reg = <0>; + + it6263_lvds_link1: endpoint { + remote-endpoint = <&ldb_lvds_ch1>; + }; + }; + }; +}; + +&lvds_bridge { + ports { + port@2 { + ldb_lvds_ch1: endpoint { + remote-endpoint = <&it6263_lvds_link1>; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts index d26930f1a9e9..68e12a752edd 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts @@ -938,6 +938,12 @@ MX8MP_IOMUXC_SPDIF_TX__I2C5_SCL 0x400001c2 >; }; + pinctrl_lvds_en: lvdsengrp { + fsl,pins = < + MX8MP_IOMUXC_GPIO1_IO10__GPIO1_IO10 0x1c0 + >; + }; + pinctrl_pcie0: pcie0grp { fsl,pins = < MX8MP_IOMUXC_I2C4_SCL__PCIE_CLKREQ_B 0x60 /* open drain, pull up */ From patchwork Tue Nov 12 10:05:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 13872065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EF7ED32D8B for ; Tue, 12 Nov 2024 10:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S0ooql6tJx9QvI6HzImFAbKMebLcspbeKsCrIWpXV3Q=; b=TNlmPa+XxFW2V9F8jVxCLjvvlY nJSjm1/kh6EfG7Dxzgy9R+/4x/4LxuQAqbAdwBzgbksigtr32bqeD/TlGrRmxE62ad1210UTCn7XY VwUEA6YR5XjcEG+RgwhJaXE6P9jNaxkiM9xPwjghmphreKH6VaQimG9MqusrNty7IOCx9OFFj3IYb X4w+9BC31vK1w3yGjnNA5tF07lbFMnV7gGZZsH0LsoqaOrxXM21uFwXnIU0OaSWSRcFqhN5RO8Yol n8mYMiT0YJ4kkDrR9M+pR2Tn7kJMmjKWNFsHSNi1+ZhYnEwbLlSx+tBh8m1K6hYAsD2MeDS1fkNaZ CUJwB72A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAo4E-000000031zT-1Bkf; Tue, 12 Nov 2024 10:24:14 +0000 Received: from mail-am6eur05on20629.outbound.protection.outlook.com ([2a01:111:f403:2612::629] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAnnR-00000002yKZ-2nqK for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2024 10:06:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DCrZF6tuJ2RCMteS7iGcDLv9QYBsr5yLa7LlACnYs6dAWHWjyJeb2w+nm8Pwocbi5KsFvd6fG2UGrfoejeEtSMa32Pp4jIlCWAbX+/N9MINTvQLgFBaAoRCvTKriMmBVbBjlGydCrvG2PTcks79EYPVpoPO8peKNmk4NSLDWwbmHpq+R4nQVkd6T5pYbnD96kew4oEsotoB+suHVO5RqwevVQyYAvd/+BXafeWiayKjblGSV/HEImYAXtpm8OKVibDYS2CVOwgGl/+YxLAxJ9nNM8r/Bis+rpzVlNWzQA8K0LcS4IaIx+simKUt1V85yGuQKUga/0Ka5WUqVipBK3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S0ooql6tJx9QvI6HzImFAbKMebLcspbeKsCrIWpXV3Q=; b=c1hQ+MrxgHqePlSVBRTLS6c0oSXXf19wMGklh6B+E1yy+r7qFCyQG1WJ8fe/KsjR458r+Ct3oWV+Wns5UVKXjMGOq/TEZzR9Yl3X3T/ZcymlblJJD5a6OB4SwKirsAzB8pXUz5LrUNhOOT/X6opPDt3aIJ8o8Wdd47SUZTxmgYQLLJUkwT9yIPQjVj8c3sxYHUn7ZxCn/iF54ADbkxXTtBhopTnrn5FLRw3aLLpBV5NH0qpmurtzh1T/aTVyxImJARZ8CauZjV2EBZGjDOtbaYNpqVITVnzKvx+oTDa0RJZXpikGKMSVgoaNJvSlt0072NDV8yQ4cKm8CE/PB3dK2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0ooql6tJx9QvI6HzImFAbKMebLcspbeKsCrIWpXV3Q=; b=QwMF1O4rVot27CWfjhgLcGPSps2jQ6tjpiuQW1k60oqYsnPhbCJ7h+ND5KJm59K+jSd8LACo+aAojq2KrVNrntQw8+Kswfmr16tCLVjmjJ6Ylo5/uikk8LS1zVuRxwDz68yQUJCSaTTRaknMNgIYtrUQ5Kotpvu2PA0TUcyw1PUBNQ4tB/0tWBOaY1yPUS4glY3JqQnJ1LMsDfTHAID6l9lux3Rb0v3KADRvMdf9BlGtSCJoMewATqQ8o1VG6oPSaXnRq2G5pS4yN5+xPgWJtsTfv+NB/AjzGzyhDsM4E5z5OVJe7pcE/vyopZMwcd7RGuc4aIsb6tO9xmIekwTaxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS8PR04MB7879.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Tue, 12 Nov 2024 10:06:50 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Tue, 12 Nov 2024 10:06:50 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v6 7/7] arm64: defconfig: Enable ITE IT6263 driver Date: Tue, 12 Nov 2024 18:05:47 +0800 Message-Id: <20241112100547.2908497-8-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241112100547.2908497-1-victor.liu@nxp.com> References: <20241112100547.2908497-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:3:18::13) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS8PR04MB7879:EE_ X-MS-Office365-Filtering-Correlation-Id: cc538929-e9de-4940-dfe7-08dd0301b977 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: z7tFFzDALkKSSMLqXkbVuHRpwTIBDtrFg9AnU1tpXznhl0zI+SpBbRZSFlSze4Blrul6Ji2+KOgTWiJSOJNB/BBbDvmQI/3I67p1f+x6cds8iC+dTa7mYhVC6ufGu0aIuruPU61r78lLtFBSLyft1w3PGrgMcRZI4zW/eiQZex8YWXVRm5sa3Dzj6nPqmUbRVLuYtECdpZWgS642JJYHDKZBzYUAiFR+gDZ1td/KjkU2/MuB0D9GDj1J3SVI/UStWfEaSvc7I60ZqER0M8Rvsc92tI9vNwY5Vu+BTtZFKNcU1pYQ/G8/lhYDkG1MImcd1QhqT2mVQ+l/PcJO6HMxQsIZ+nsNvcC2N+DzXbzz1vB/Uu3a1r4lgflEwONt/rfFaU0xPWE4Eh/u8ZGNakGYsFS9n9gU+AcxRkNcFDwxLobDW4uCn1LR99a+1xguWMw9DYWIDH7O9sgjaQxMwkogZz8qWDcn4T5oKLCtD2c3FLxJGcFFsYzMAJ9y24+TEZ3oBnbEpcIhx2B0CNNquCQ5d7DEtX7QwxtryvnQqnSrJY1ElVdeUIvUJsmwLOA3MyDS5bw2aj9rQZftLQhdsAzpykeNK9QAW8rrkRVCwMmaO1NimZtUDsSZwDtL1S//PwSsvqzJ8Lhy27DDkNF0ppa8ZCAOEVHFX6YbuyAUTzvYvAWU63+o2JXxJFKVgtXJwL3NEfJilWAaeDr1FLCRM7NBnbVnEBbUk0OSzmYpTYULzN4hQI53GiUEbuHA0DECiB9AOIv3wOGCxbDeBLn7mvKCuz5i05zQl4y5M0VK9jZifxTJUqPGXG9g0XMowbEhgA/EkLxtd6UyCY4rqGwSN5RhTq+yu9hgsySpwFTfWZgoSFuwH3O0Y6XW0fFB9SdPKneWn/uIunutb6zFTwERcsEKJCLw7H9ZES6j53ELGKpBwdKrX/QyUkBTL44qWSlqsOdgw/QFWdswbVeldC+b5g0WpuLI1SWf3gTnN9HCNSn0ktMt0zK+YV2Ls8SDiZgop++1pMAPYYKbN/b9XcBME+7rE/DA9w3JGSAAk/wtSSMSQ8PHpSfsWt+34Ne/vFB3v0HF6g6IUv9Aptwo583nnhizj2jkbmw+Tmy/UuPe1zxeGe3NlxUvLrJmR4WYevwLtGTXRYvylbPyoUfp2sAcQcrilU0/gq6bw6MumvHA28FRPphBdDMQGGBGMZkmJAvge2S/to1AVRx3IIz/hQcgRS5YTVUbePa/BsoRcBVymscN8CvnnOlnEWY2Q3MeH8AP8ZcitKz011E/cnlWlMX1nvHSLgIzxt68wdZ59H2xpipyDe7HUEfxL9WvHWfJMs695Aa/nYWwrscXn20AYLNqfGYbSotVfEXk9MxMEliPyt5V9OU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CWgn6G3XPj9RGYp11WWp63P7J4ABdj/ycsummiNJG+pi9TNK3w/IC08xOQAgaVQItK9VdaiiDGM78dlCoebUdluhTvJZzo0eIu1EauZ+0lA1fn0OEkH9lPNa5qnxbnlK91Yn2kKNaQF8jO2ziUnyXDtCuKmii5uluE9SqxY/Kj7v0AaDCIJVZ9PvJsTJLwQWWVe9uO9HrwC4uRFrz8RTZOTit0SMi3NvSieFL8dONqCq2+GS9ydmudHmzDVcAmDiCpLcFej9vrV01dniab9SM6ipjcvz+GX1OKOukdrmJ5tbGxkjneUKfJx1Q4l1vQY2PPENV2W9YB5asWuWwnM3HEQrkpGGFhzFNBtCjmck8Rw64pzo/EC3kqcvHyLY6CYgfgrgMv/cSfDga1tkTvJc+uuicOu5RxHXNnpDyY4rAzaolwS7d3XDhMp1Oc30rwLgBUsoFwsL9ruyALy8bxHGgF6Bflr5ZyW2NXfj65TNMQci7IQxjiMKb/0gJf8qIq2SYI7xwP/L46z9eqEFdOqH/Vinv67gb9eDdRAsvAco6CyWgyqV7svxdbZblMCfTSAor2g+9yh4JseMJPbzsdxt5G2yFp+mPCwCS8Zu721oCuPhY9UkCTnY/72qGilVc8yNtiBRtOVyQzone36y6ZFLwt8woSbM9UZGkNUyBkdIF3r0nveNxjJLvKC/mkaLNi80wo5B58YkbFiB55Fg0zV74zUHbCOgHBjDSTGssqcayHDQ/pB3uQT+fmVkqF1iuHng3urBkaKAkBXjKOE8O0V+j9m4DWI9X9/A8ig+UpWI9eKHwLjbEV3ZWEFgAK9G8+h4AKmYesNZ1Ab7eFqRhfFj8fPlos0dfuLL5+5/+1XFjG/6c6pWjw300MF71xTp6X6iX7A/SMKu10DqVw/rw9/4oCXU0r/MPikAb5lvdEqxDl6E0WoE3pogfAcmFBty7xTywtUFgdSVWuW6IqoK3AvNOMWS9eRpzETBVEcLdgZw1bE7IcV272AaG2Iy+YXVzf5W1Ah9hl4Lw7UdJLjpqdylD7+TwQ5XFEPYMVviyyNKOTEg47sfDK1PEMLVOT2dxWUbnOyc7I6im8n5wFiiDIBFfW1zsfQqNL69hPKg/CiIyvI9ZzxUSfNXF38KaLQ+PrZmNQYmM5rgKkXNlH9/zvTj6XF2hK2nCtnkpMusWyW9FI81pko72bhjUdS40eKyVPK7sF2RCwL+k4qqIOMjuzTbbduLPUaWXue/U9+jKlcKOGP92XLFCibYWBMNlFaHe7bMBweFKzLK7e4hhLlJ0ywRTv/rbOmVmmei3l6A6NhZ8DO5ZPa5l9c4favpC/mMZ8kieIe7w1nxP7xpXZoMH8Qn8xSElAnGP74tbdc3/UW/8H2JMvhNa1o3M7Xg1JyM76cGoHAkvz8Ys5VvEtOQM5Mntd+ikvE3uBs12fk+SBh3fhgXk5qR5j13SbCdyNXJgr5QhlPM4Dve6JqL20V9TJUpX4AIQ+a7V8MMim86jmK4rGZEgYpYKIvVhqfftRrIriIsz2F5FNJGahcQDkO1WFO/gYKKEopdBfxssoFn9A6ohCfV3zyrevlHIiFd1uycLwOO X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc538929-e9de-4940-dfe7-08dd0301b977 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 10:06:50.1679 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sv5X1GG2QYaSRVMXUmTGPnboqgg37DC7T7gUfIjTQhsfqfeIewQC/+/mUmrQCpUSE+hBwC1fp0bqdVczT5dswg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7879 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_020653_732584_365F98E3 X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ITE IT6263 LVDS to HDMI converter is populated on NXP IMX-LVDS-HDMI and IMX-DLVDS-HDMI adapter cards. The adapter cards can connect to i.MX8MP EVK base board to support video output through HDMI connectors. Build the ITE IT6263 driver as a module. Signed-off-by: Liu Ying Reviewed-by: Biju Das --- v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * No change. arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index d13218d0c30f..9b20b75f82e2 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -901,6 +901,7 @@ CONFIG_DRM_PANEL_SITRONIX_ST7703=m CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=m CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m CONFIG_DRM_FSL_LDB=m +CONFIG_DRM_ITE_IT6263=m CONFIG_DRM_LONTIUM_LT8912B=m CONFIG_DRM_LONTIUM_LT9611=m CONFIG_DRM_LONTIUM_LT9611UXC=m