From patchwork Tue Nov 12 14:37:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 13872319 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B4E81FEFCB; Tue, 12 Nov 2024 14:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731422241; cv=none; b=peH8vl2aKaAtwFBTkylgo38hNziJGr3RHER09Wlp1zNmdCd7QeQwLvCJtQQPx0EyTaVuG59DzKrLPwII3TheHAJANXrfLCLerHMUL0Q2lrn4CKl/MNglZ/1QpAe5BeUFVy5H3pVT+6YXIJpRIRCeyqZSWDZLomrgjf20llbP2PM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731422241; c=relaxed/simple; bh=OLM1LmvcGmfjwEoOH9THmUpT4WbBiVuJoTYmOw4ORrg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iYF93vdw9ZUCcFDMgWpAQ9oB2tZFdQhpANOop2MaJeL2UHXplpeyQnycd4/A0R7sdtlIvHu6iYP3ngf6qMWiqXAtMTI61ulZb8Cn89YNF5FTUfz61fZSwPy90ZhSgyQJpEC2hX8zYyk2NP8mUleTNOSKJ5DPumXPuhr+wqGArFg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HXKHjTKy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HXKHjTKy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56E4FC4CED5; Tue, 12 Nov 2024 14:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731422241; bh=OLM1LmvcGmfjwEoOH9THmUpT4WbBiVuJoTYmOw4ORrg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HXKHjTKyUbZPR6iHL4Gv3k6lw7qIdLYGsYEhL/GTflN6Y9HfituAM/nJ71CLJh9Fm X5cSOnT7xgjcgv1J42+WEixgU9pf+nIvtCPOvvujyDvsNgtfzGHPVLze7e+Wk86eyB anNFzRhsAE32QQWGzcQno7Jz5YcT0sNSjw5SmZ0CKNrDlXBrDeUbjRCzgMqsFnJrWD CNErYQWFtapb2VLhGdAeQUMlQwkOgF5K2BQJXWkRUFTkUIF0uLnP/6emcRs2R72EpY hciIRdZDE0XaKKmfRNReRTc5H1LCzlvu4Mg3DtHFvuivRY6xw7iqcHsI1aMl/86YLD LeA8EoqJo7IrQ== From: Frederic Weisbecker To: LKML Cc: "Paul E. McKenney" , Boqun Feng , Joel Fernandes , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Neeraj Upadhyay , Steven Rostedt , Uladzislau Rezki , Zqiang , rcu , Frederic Weisbecker Subject: [PATCH 1/3] rcu: Delete unused rcu_gp_might_be_stalled() function Date: Tue, 12 Nov 2024 15:37:09 +0100 Message-ID: <20241112143711.21239-2-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241112143711.21239-1-frederic@kernel.org> References: <20241112143711.21239-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Paul E. McKenney" The rcu_gp_might_be_stalled() function is no longer used, so this commit removes it. Signed-off-by: Paul E. McKenney Reviewed-by: Joel Fernandes (Google) Signed-off-by: Frederic Weisbecker --- include/linux/rcutiny.h | 1 - include/linux/rcutree.h | 1 - kernel/rcu/tree_stall.h | 30 ------------------------------ 3 files changed, 32 deletions(-) diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h index 0ee270b3f5ed..fe42315f667f 100644 --- a/include/linux/rcutiny.h +++ b/include/linux/rcutiny.h @@ -165,7 +165,6 @@ static inline bool rcu_inkernel_boot_has_ended(void) { return true; } static inline bool rcu_is_watching(void) { return true; } static inline void rcu_momentary_eqs(void) { } static inline void kfree_rcu_scheduler_running(void) { } -static inline bool rcu_gp_might_be_stalled(void) { return false; } /* Avoid RCU read-side critical sections leaking across. */ static inline void rcu_all_qs(void) { barrier(); } diff --git a/include/linux/rcutree.h b/include/linux/rcutree.h index 90a684f94776..27d86d912781 100644 --- a/include/linux/rcutree.h +++ b/include/linux/rcutree.h @@ -40,7 +40,6 @@ void kvfree_rcu_barrier(void); void rcu_barrier(void); void rcu_momentary_eqs(void); void kfree_rcu_scheduler_running(void); -bool rcu_gp_might_be_stalled(void); struct rcu_gp_oldstate { unsigned long rgos_norm; diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h index 4432db6d0b99..d7cdd535e50b 100644 --- a/kernel/rcu/tree_stall.h +++ b/kernel/rcu/tree_stall.h @@ -76,36 +76,6 @@ int rcu_jiffies_till_stall_check(void) } EXPORT_SYMBOL_GPL(rcu_jiffies_till_stall_check); -/** - * rcu_gp_might_be_stalled - Is it likely that the grace period is stalled? - * - * Returns @true if the current grace period is sufficiently old that - * it is reasonable to assume that it might be stalled. This can be - * useful when deciding whether to allocate memory to enable RCU-mediated - * freeing on the one hand or just invoking synchronize_rcu() on the other. - * The latter is preferable when the grace period is stalled. - * - * Note that sampling of the .gp_start and .gp_seq fields must be done - * carefully to avoid false positives at the beginnings and ends of - * grace periods. - */ -bool rcu_gp_might_be_stalled(void) -{ - unsigned long d = rcu_jiffies_till_stall_check() / RCU_STALL_MIGHT_DIV; - unsigned long j = jiffies; - - if (d < RCU_STALL_MIGHT_MIN) - d = RCU_STALL_MIGHT_MIN; - smp_mb(); // jiffies before .gp_seq to avoid false positives. - if (!rcu_gp_in_progress()) - return false; - // Long delays at this point avoids false positive, but a delay - // of ULONG_MAX/4 jiffies voids your no-false-positive warranty. - smp_mb(); // .gp_seq before second .gp_start - // And ditto here. - return !time_before(j, READ_ONCE(rcu_state.gp_start) + d); -} - /* Don't do RCU CPU stall warnings during long sysrq printouts. */ void rcu_sysrq_start(void) { From patchwork Tue Nov 12 14:37:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 13872320 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C175A1FF7CF; Tue, 12 Nov 2024 14:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731422244; cv=none; b=L7oxWYfCRAen19+aGWH8bQ4BwmrQV8g2UPiGnpniF5lWGv4K4cIPssj0hOv8lCNwuEL6EQhgIlQ84JVjFQE0N6vI5+iBXDIyF582EydNHSLFuD4n1xRzwVA45jzNz6xjPHvc7bLdPOoL9H7rFYPxafLoatrcu6tTcghxQszeiJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731422244; c=relaxed/simple; bh=MBalVYHu+YCpiyEjXv1rcDKHPByokIPNarfrKVTvbcs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pLL7QUWtbpgSLyE1ilYbsK55gP7HsjJ4LDIv/gnRo9sUtdnwJ8Hgq/Owktyn0tkdxdvSZB5O3P5s11Iiz1G+tZaBOexa2F2/qer09glrQtRzCxAVHeULyDCLv5H1pBBXYGWtDg8unNC+0RloFJbsaB/oCp6u4gd/Yy/QcB38qUg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XV6VTGJx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XV6VTGJx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BA61C4CEDB; Tue, 12 Nov 2024 14:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731422244; bh=MBalVYHu+YCpiyEjXv1rcDKHPByokIPNarfrKVTvbcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XV6VTGJx3sVmn30yYPcPxIfsDI7uTGEFpf5WhC+FMNxH4TVUSy2Ju3gRNA88hppVv 8n0OP9bsJ2LxG4g0rRynF1hjifAaNgn2qzLWSlL4ddAgAi6ZI/1t9puf59psPqPSWP W2U5HoGgo8TYm0UyY9uBQd7oUGbTLMHeg2WPbp0Y6RwN/NVH+sdlc+KX7+9DktA9hZ PhA3UogJtR7qHAha32ecarjsxkmaTCic4LQx2eSMXs3JLsLoJ8YVXKEXycIdzwg6x/ jVbxf9k3NVBOjChYLo053Xahdlf6rgSGvZJyUfZ7oksXH1Rj6r2X3YN4ylxuNX65Aj BZXWKoHWcwlzA== From: Frederic Weisbecker To: LKML Cc: "Paul E. McKenney" , Boqun Feng , Joel Fernandes , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Neeraj Upadhyay , Steven Rostedt , Uladzislau Rezki , Zqiang , rcu , Frederic Weisbecker Subject: [PATCH 2/3] rcu: Stop stall warning from dumping stacks if grace period ends Date: Tue, 12 Nov 2024 15:37:10 +0100 Message-ID: <20241112143711.21239-3-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241112143711.21239-1-frederic@kernel.org> References: <20241112143711.21239-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Paul E. McKenney" Currently, once an RCU CPU stall warning decides to dump the stalling CPUs' stacks, the rcu_dump_cpu_stacks() function persists until it has gone through the full list. Unfortunately, if the stalled grace periods ends midway through, this function will be dumping stacks of innocent-bystander CPUs that happen to be blocking not the old grace period, but instead the new one. This can cause serious confusion. This commit therefore stops dumping stacks if and when the stalled grace period ends. [ paulmck: Apply Joel Fernandes feedback. ] Signed-off-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker --- kernel/rcu/tree_stall.h | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h index d7cdd535e50b..b530844becf8 100644 --- a/kernel/rcu/tree_stall.h +++ b/kernel/rcu/tree_stall.h @@ -335,13 +335,17 @@ static int rcu_print_task_stall(struct rcu_node *rnp, unsigned long flags) * that don't support NMI-based stack dumps. The NMI-triggered stack * traces are more accurate because they are printed by the target CPU. */ -static void rcu_dump_cpu_stacks(void) +static void rcu_dump_cpu_stacks(unsigned long gp_seq) { int cpu; unsigned long flags; struct rcu_node *rnp; rcu_for_each_leaf_node(rnp) { + if (gp_seq != data_race(rcu_state.gp_seq)) { + pr_err("INFO: Stall ended during stack backtracing.\n"); + return; + } printk_deferred_enter(); raw_spin_lock_irqsave_rcu_node(rnp, flags); for_each_leaf_node_possible_cpu(rnp, cpu) @@ -608,7 +612,7 @@ static void print_other_cpu_stall(unsigned long gp_seq, unsigned long gps) (long)rcu_seq_current(&rcu_state.gp_seq), totqlen, data_race(rcu_state.n_online_cpus)); // Diagnostic read if (ndetected) { - rcu_dump_cpu_stacks(); + rcu_dump_cpu_stacks(gp_seq); /* Complain about tasks blocking the grace period. */ rcu_for_each_leaf_node(rnp) @@ -640,7 +644,7 @@ static void print_other_cpu_stall(unsigned long gp_seq, unsigned long gps) rcu_force_quiescent_state(); /* Kick them all. */ } -static void print_cpu_stall(unsigned long gps) +static void print_cpu_stall(unsigned long gp_seq, unsigned long gps) { int cpu; unsigned long flags; @@ -677,7 +681,7 @@ static void print_cpu_stall(unsigned long gps) rcu_check_gp_kthread_expired_fqs_timer(); rcu_check_gp_kthread_starvation(); - rcu_dump_cpu_stacks(); + rcu_dump_cpu_stacks(gp_seq); raw_spin_lock_irqsave_rcu_node(rnp, flags); /* Rewrite if needed in case of slow consoles. */ @@ -759,7 +763,8 @@ static void check_cpu_stall(struct rcu_data *rdp) gs2 = READ_ONCE(rcu_state.gp_seq); if (gs1 != gs2 || ULONG_CMP_LT(j, js) || - ULONG_CMP_GE(gps, js)) + ULONG_CMP_GE(gps, js) || + !rcu_seq_state(gs2)) return; /* No stall or GP completed since entering function. */ rnp = rdp->mynode; jn = jiffies + ULONG_MAX / 2; @@ -780,7 +785,7 @@ static void check_cpu_stall(struct rcu_data *rdp) pr_err("INFO: %s detected stall, but suppressed full report due to a stuck CSD-lock.\n", rcu_state.name); } else if (self_detected) { /* We haven't checked in, so go dump stack. */ - print_cpu_stall(gps); + print_cpu_stall(gs2, gps); } else { /* They had a few time units to dump stack, so complain. */ print_other_cpu_stall(gs2, gps); From patchwork Tue Nov 12 14:37:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 13872321 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C93D8200133; Tue, 12 Nov 2024 14:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731422247; cv=none; b=Cgl52mhqn4Gy5qkDuFY1djEaXW/3anjnclgybaGg9qD00LanWpuRvz92vqLM1h83rkhW1LLwxxQJSdTXLE7fqG3yOfanzNAMOlQYSDH7Wq0HTtVi1kb3K8Z1ctDEa236zicqaplrb6LZWDG46QYOVVaxMWuvFqaPq3s7jhSTZb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731422247; c=relaxed/simple; bh=2S3GF9YgOUVpSAFE9yXBXJbkzVZbHzXUYGcIPmCPbZ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lemDlobhfEwA5M6n33CGZbTn1SEEtzy/WrwZKrVSt2a/KctboSYY/zGsey2r7R0ORTs7D9qfRnWS6FGw0/lZ3Js8Phk6hKkAN/7xNbSpuANxGOQqKKpSwk05q3qj0iS4ilZ2vAMko9FRms6NwA6pMm4laBqhxnWW6qF5HAPtgIo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E2Mn6xzC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E2Mn6xzC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6B26C4CED0; Tue, 12 Nov 2024 14:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731422247; bh=2S3GF9YgOUVpSAFE9yXBXJbkzVZbHzXUYGcIPmCPbZ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E2Mn6xzCC22m1WxtxUGNvC2lSrvLRNlRgjRuhrdlOyrUOIZnLSVP/Yo8k6WcGze6j 9Ka9JBu64D+JMdH1PueyIoUUZ7Ewhn+9XydE01xmBhQSbYrvI14/RUqaLpGiMUfZSo ICkvifnHUUskFbqBVJBqCmnrYzAlAc12Scwz1WFNzzQbJRRzYNmSM3btCBo4Imvvzu NyK0w8YG1qwmtjE2AaU2W/InanaH9tRBAsxwvsjYCC4vrnInjCKMsYJXngjaxmDOzu r0UJhz50sJdUeYTgJE9dwar3Kmcg4s0z/wsFvHzjx3PXfMyvIqI7vg5TkA8whm/jXn mvaFriSbpmkBQ== From: Frederic Weisbecker To: LKML Cc: "Paul E. McKenney" , Boqun Feng , Joel Fernandes , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Neeraj Upadhyay , Steven Rostedt , Uladzislau Rezki , Zqiang , rcu , Frederic Weisbecker Subject: [PATCH 3/3] rcu: Finer-grained grace-period-end checks in rcu_dump_cpu_stacks() Date: Tue, 12 Nov 2024 15:37:11 +0100 Message-ID: <20241112143711.21239-4-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241112143711.21239-1-frederic@kernel.org> References: <20241112143711.21239-1-frederic@kernel.org> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Paul E. McKenney" This commit pushes the grace-period-end checks further down into rcu_dump_cpu_stacks(), and also uses lockless checks coupled with finer-grained locking. The result is that the current leaf rcu_node structure's ->lock is acquired only if a stack backtrace might be needed from the current CPU, and is held across only that CPU's backtrace. As a result, if there are no stalled CPUs associated with a given rcu_node structure, then its ->lock will not be acquired at all. On large systems, it is usually (though not always) the case that a small number of CPUs are stalling the current grace period, which means that the ->lock need be acquired only for a small fraction of the rcu_node structures. [ paulmck: Apply Dan Carpenter feedback. ] Signed-off-by: Paul E. McKenney Reviewed-by: Joel Fernandes (Google) Signed-off-by: Frederic Weisbecker --- kernel/rcu/tree_stall.h | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h index b530844becf8..925fcdad5dea 100644 --- a/kernel/rcu/tree_stall.h +++ b/kernel/rcu/tree_stall.h @@ -342,20 +342,24 @@ static void rcu_dump_cpu_stacks(unsigned long gp_seq) struct rcu_node *rnp; rcu_for_each_leaf_node(rnp) { - if (gp_seq != data_race(rcu_state.gp_seq)) { - pr_err("INFO: Stall ended during stack backtracing.\n"); - return; - } printk_deferred_enter(); - raw_spin_lock_irqsave_rcu_node(rnp, flags); - for_each_leaf_node_possible_cpu(rnp, cpu) + for_each_leaf_node_possible_cpu(rnp, cpu) { + if (gp_seq != data_race(rcu_state.gp_seq)) { + printk_deferred_exit(); + pr_err("INFO: Stall ended during stack backtracing.\n"); + return; + } + if (!(data_race(rnp->qsmask) & leaf_node_cpu_bit(rnp, cpu))) + continue; + raw_spin_lock_irqsave_rcu_node(rnp, flags); if (rnp->qsmask & leaf_node_cpu_bit(rnp, cpu)) { if (cpu_is_offline(cpu)) pr_err("Offline CPU %d blocking current GP.\n", cpu); else dump_cpu_task(cpu); } - raw_spin_unlock_irqrestore_rcu_node(rnp, flags); + raw_spin_unlock_irqrestore_rcu_node(rnp, flags); + } printk_deferred_exit(); } }