From patchwork Fri Nov 15 01:48:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 13875812 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB6763B9 for ; Fri, 15 Nov 2024 01:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731635291; cv=none; b=soMo3+a/HjOxp8hmBDPOGpmkg9BCLDsTs1neD8pZjqGJEKCGpg4ZLDj/UuTcGbozU7wCL8tkMo4JU2OOQLAqet3QH2TVFlROom4kSPVN+oTconsUdO/1TVIe+GHmEeCdw1LMhgJZ9Oa8pg8RtM/ZAVdgq4EDCU3EmSoIkcIEzxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731635291; c=relaxed/simple; bh=HgvV5xE6qEOFstn5OpN0rAnQ1tp2xgtwtx2zzjBPPqM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Oz8+pSfJBuwWjslb8OVIOEaWXMABUsAdhfHnebGJXtorsHcj65ufFvC+H3pOgZQ5c1UULjWcvuVg6byrCv0Y9FFarF+c3OGiMsCJKAVGJxkzaGSBQe+aE3fd4gr0KKBi613oWX4oIaVcmqhNcmAnwIZqWbdVJMXI9R5+x/Ge31c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=te67Nzol; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="te67Nzol" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3BFBC4CECD; Fri, 15 Nov 2024 01:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731635291; bh=HgvV5xE6qEOFstn5OpN0rAnQ1tp2xgtwtx2zzjBPPqM=; h=From:To:Cc:Subject:Date:From; b=te67NzolkzscDGy3eBCLgEVN0uhqeTsoddXpKykzLd9q6HMZExfoDb2sQjeUHAzQr 8QrBh//qcE/Yqox0vQrpErsFLddak9EYCmIrA0BZyjBGGCY1zIkySiO+WcVUvKiaOR ZE3GUx4A3tyjZtZxabZwFpi9axUTRwb3XcyP0fC8/fNyYH40EjT8uUG51eTVQkviLz O1VyX6oCisZ57vIwPQEAUtGWKanry7BEzmDRv+smriVZJ8tA1aqtLgl9cxNerJDp/E q58PVD38GaEMLo7PGLIl0K2l8IUiioCmFhBuG1EDy4wTfwc/pgr99/RyUNn9P05JH4 u3ZWj/ex8Hmow== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, Jakub Kicinski , alexanderduyck@fb.com, kernel-team@meta.com Subject: [PATCH net] eth: fbnic: don't disable the PCI device twice Date: Thu, 14 Nov 2024 17:48:09 -0800 Message-ID: <20241115014809.754860-1-kuba@kernel.org> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org We use pcim_enable_device(), there is no need to call pci_disable_device(). Fixes: 546dd90be979 ("eth: fbnic: Add scaffolding for Meta's NIC driver") Signed-off-by: Jakub Kicinski --- CC: alexanderduyck@fb.com CC: kernel-team@meta.com --- drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_pci.c b/drivers/net/ethernet/meta/fbnic/fbnic_pci.c index e110c2ceafcf..32702dc4a066 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_pci.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_pci.c @@ -334,7 +334,6 @@ static int fbnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) free_irqs: fbnic_free_irqs(fbd); free_fbd: - pci_disable_device(pdev); fbnic_devlink_free(fbd); return err; @@ -367,7 +366,6 @@ static void fbnic_remove(struct pci_dev *pdev) fbnic_fw_disable_mbx(fbd); fbnic_free_irqs(fbd); - pci_disable_device(pdev); fbnic_devlink_free(fbd); }