From patchwork Thu Nov 28 15:42:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13888190 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A41951B6CF3 for ; Thu, 28 Nov 2024 15:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732808543; cv=none; b=L59en22ms5DO2J+c+yKCxOV4uhRrn2smEXaST7CnDL9c1Vq+igyLcKHvogyF2w9I361f0eiGIqANjBTUCZK1XK0LuWTXMsZI9DwWVnxccfhQ1S90PUQ7hJjjwpHL76UJ/StFSeMNZU0Y3t3R782/lvKxHlhcvRPCXZR/6s56mck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732808543; c=relaxed/simple; bh=kxUjkLK5TukTfCZxyFHlZM9Z+ms3ahsOHr/fS55R+Q8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MNOF3XWGWcJhxZ0n4C6Bys0mrO+ixIQh72kTwOVX6Z6nFFVmPS5IfX7lQGkIof2rvatzA17rl18+kvpUm6m00DfKKvvASV2Agqzwp2J3Ugar2iB4CaaKK0WEb22GnHagcUKqhdCkRDG7MdRPDZDoKwKqas5hxD5O8JLRt2sgvdc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cEhSjoFw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cEhSjoFw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732808540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ya5MmXd9atYRw/V1bAU9JDQtj6xaWRPwiwaxSyuszuE=; b=cEhSjoFwWBw0jFRJOKkqh+jVtwf6K7WxJcn4nk4Q/xIPLuiqY17TIfoL51/zSVYEXOsXXy FfJN2fN/BYVNEZEBxfN+1nkxjtYB07olJkSlzNdQJCFDI1PCAqAgbNhMan7qI04aDdMtsF k9kG5/8wN48yIwbWvByWDMuxGaSsBbg= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-QSdCrnvSNgimUDcbVbZOgg-1; Thu, 28 Nov 2024 10:42:17 -0500 X-MC-Unique: QSdCrnvSNgimUDcbVbZOgg-1 X-Mimecast-MFC-AGG-ID: QSdCrnvSNgimUDcbVbZOgg Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4DCAA1955D8D; Thu, 28 Nov 2024 15:42:16 +0000 (UTC) Received: from x1.localdomain.com (unknown [10.39.193.119]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 72693195605A; Thu, 28 Nov 2024 15:42:14 +0000 (UTC) From: Hans de Goede To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko Cc: Hans de Goede , platform-driver-x86@vger.kernel.org Subject: [PATCH 1/4] platform/x86: int3472: Check for adev == NULL Date: Thu, 28 Nov 2024 16:42:09 +0100 Message-ID: <20241128154212.6216-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Not all devices have an ACPI companion fwnode, so adev might be NULL. This can e.g. (theoretically) happen when a user manually binds one of the int3472 drivers to another i2c/platform device through sysfs. Add a check for adev not being set and return -ENODEV in that case. Signed-off-by: Hans de Goede --- drivers/platform/x86/intel/int3472/discrete.c | 3 +++ drivers/platform/x86/intel/int3472/tps68470.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c index 3de463c3d13b..15678508ee50 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -336,6 +336,9 @@ static int skl_int3472_discrete_probe(struct platform_device *pdev) struct int3472_cldb cldb; int ret; + if (!adev) + return -ENODEV; + ret = skl_int3472_fill_cldb(adev, &cldb); if (ret) { dev_err(&pdev->dev, "Couldn't fill CLDB structure\n"); diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platform/x86/intel/int3472/tps68470.c index 1e107fd49f82..81ac4c691963 100644 --- a/drivers/platform/x86/intel/int3472/tps68470.c +++ b/drivers/platform/x86/intel/int3472/tps68470.c @@ -152,6 +152,9 @@ static int skl_int3472_tps68470_probe(struct i2c_client *client) int ret; int i; + if (!adev) + return -ENODEV; + n_consumers = skl_int3472_fill_clk_pdata(&client->dev, &clk_pdata); if (n_consumers < 0) return n_consumers; From patchwork Thu Nov 28 15:42:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13888191 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48C391BBBC4 for ; Thu, 28 Nov 2024 15:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732808544; cv=none; b=Y69dA1k63HaIVsjPRuDvFrZpFpibLktyIpVL2wTvuhhrSAtcefMnn95IWGfewwDMBqgB4y+DoZZfAxmHspfTllkJaE2e4+0aRmTZH8ic4lnyvz0ZgzgbrTd1FVpFm7AhfLl2C5+9r2RQbRe5NLnXpbXx+6WctEZfcWjQDK3G5lY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732808544; c=relaxed/simple; bh=wgNqM+Kn/wiUr0nJBp6KaGMRX11zLJJ0RHzh9P7q2UY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VblDUgycNHdCZR/xm55eptPgUfcfLoUTubzN91l4psTFkk2vq5dL+UlmruBVAmOXqqpdrGixX+9zk+62J6VEHveNKTjFHpH4Y1Q5si1vJo5uJD3Bw8K2gM+51hOIBOnzxnM3FvaNyq54U5Zjdkkq3iWVMXPourdewb5l5zrTXwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZbJ7cmDV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZbJ7cmDV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732808541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=abPdtoj+mXJDoghrBr0nCAfl6WZxElb00nmLj90LDyA=; b=ZbJ7cmDVqEY4NkAbmsxK8vBp8zEdRWl/nzEPpOQ0N5zRdicRoocemlsQWQzX7i8EHh/LM4 /Um5kBHwN4B+b3HY2bSgpdTyhi9MFO/OAjDQj1kBblqIkyL63xcm3ab+QTBrC5joDmloW8 exNKi1zBwrGiDdj9XFHbT/5QSJFJUws= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-jQ68UsatOuCym-QQyj6kJg-1; Thu, 28 Nov 2024 10:42:19 -0500 X-MC-Unique: jQ68UsatOuCym-QQyj6kJg-1 X-Mimecast-MFC-AGG-ID: jQ68UsatOuCym-QQyj6kJg Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BD2A61955D58; Thu, 28 Nov 2024 15:42:18 +0000 (UTC) Received: from x1.localdomain.com (unknown [10.39.193.119]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 13E4C195605A; Thu, 28 Nov 2024 15:42:16 +0000 (UTC) From: Hans de Goede To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko Cc: Hans de Goede , platform-driver-x86@vger.kernel.org Subject: [PATCH 2/4] platform/x86: int3472: Drop "pin number mismatch" messages Date: Thu, 28 Nov 2024 16:42:10 +0100 Message-ID: <20241128154212.6216-2-hdegoede@redhat.com> In-Reply-To: <20241128154212.6216-1-hdegoede@redhat.com> References: <20241128154212.6216-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 It seems that Windows is only using the ACPI GPIO resources and never looks at the part of the _DSM return value which encodes the pin number. For example on a Terra Pad 1262 v2 the following messages are printend: int3472-discrete INT3472:01: reset \_SB.GPI0 pin number mismatch _DSM 103 resource 359 int3472-discrete INT3472:01: powerdown \_SB.GPI0 pin number mismatch _DSM 207 resource 335 int3472-discrete INT3472:02: reset \_SB.GPI0 pin number mismatch _DSM 101 resource 357 Notice for the 2 reset pins that the _DSM value is off by 256, this is caused by there only being 8 bits reserved in the _DSM return value for the pin-number. As for the powerdown pin, testing has shown that the pin-number 335 from the ACPI GPIO resource is correct and the _DSM value is bogus. Drop the warning about these mismatches since Windows clearly is just ignoring the _DSM pin-number so invalid values are too be expected there. Signed-off-by: Hans de Goede --- drivers/platform/x86/intel/int3472/discrete.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c index 15678508ee50..01da18b426ae 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -189,9 +189,9 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, { struct int3472_discrete_device *int3472 = data; struct acpi_resource_gpio *agpio; - u8 active_value, pin, type; union acpi_object *obj; struct gpio_desc *gpio; + u8 active_value, type; const char *err_msg; const char *func; u32 polarity; @@ -219,12 +219,6 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, int3472_get_func_and_polarity(type, &func, &polarity); - pin = FIELD_GET(INT3472_GPIO_DSM_PIN, obj->integer.value); - if (pin != agpio->pin_table[0]) - dev_warn(int3472->dev, "%s %s pin number mismatch _DSM %d resource %d\n", - func, agpio->resource_source.string_ptr, pin, - agpio->pin_table[0]); - active_value = FIELD_GET(INT3472_GPIO_DSM_SENSOR_ON_VAL, obj->integer.value); if (!active_value) polarity ^= GPIO_ACTIVE_LOW; From patchwork Thu Nov 28 15:42:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13888192 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A771BBBD3 for ; Thu, 28 Nov 2024 15:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732808550; cv=none; b=a4GzWkjytd/nVZHDw58yG9zw2faGwXxNgbepTBKIZa0fWnwSmvD24OtIbhF5VlrBLlllbX9mIBp+Bz/LKsqXjY51NbpBrE/WTcNBvF7LfmR13TpAu0pyhjBHi7CPB9pPEQxvSJ5cUvaeHmnqBBNpUFWFZuEBx7AsLLRSz7h/XCY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732808550; c=relaxed/simple; bh=mHH/FbS1tGHMCkj+uNFfA1x6oVs3dCjQzjwUwW71hkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FE4zIx6E8qhpUdVxHNWD8wmUjoNmwlugjZE+khtz5iRZF5H0hil2jY9YRNUNrTMxUccYWX25y+lT4xQiqbkbrF94uao0nwQUL3aQFZkbW6tJxWA/UGwTf2v+AF8EJShb+fFA6oQx+UVsjFxnluGbMnN2wbUkV2FFM5nCMCtBKbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=foWQCMPB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="foWQCMPB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732808545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qCIeJ4ahMS0NYqhuzopp8hefBazYBzOwG6rJ9SmztBk=; b=foWQCMPBGuwM0+B0/b1vTSKIvXp610qgIf9jx2fWRuKl5ZeEO0j4VIMvZVjAFj1QsT7W7n 6myYabEQxg8SsjWpALOcS0Nknz6P3TrkbaeaybQf0UDeRIyAZoIgCyR+f+cbSujnYKD5IP ZpjxtDkB09Cg7g7yRMxqDSrFzF6+Ek8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-A8V7Rv9rOKy3hcf26WAcVQ-1; Thu, 28 Nov 2024 10:42:22 -0500 X-MC-Unique: A8V7Rv9rOKy3hcf26WAcVQ-1 X-Mimecast-MFC-AGG-ID: A8V7Rv9rOKy3hcf26WAcVQ Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3974D19560BF; Thu, 28 Nov 2024 15:42:21 +0000 (UTC) Received: from x1.localdomain.com (unknown [10.39.193.119]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5C617195605A; Thu, 28 Nov 2024 15:42:19 +0000 (UTC) From: Hans de Goede To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko Cc: Hans de Goede , platform-driver-x86@vger.kernel.org Subject: [PATCH 3/4] platform/x86: int3472: Fix skl_int3472_handle_gpio_resources() return value Date: Thu, 28 Nov 2024 16:42:11 +0100 Message-ID: <20241128154212.6216-3-hdegoede@redhat.com> In-Reply-To: <20241128154212.6216-1-hdegoede@redhat.com> References: <20241128154212.6216-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 The INT3472 code never wants a copy of the ACPI resource to be added to the list-head passed to acpi_dev_get_resources(). Make skl_int3472_handle_gpio_resources() always return -errno or 1 and drop the now no longer acpi_dev_free_resource_list() call. Also update the inaccurate comment about the return value. skl_int3472_handle_gpio_resources() was already returning 1 in the case of not a GPIO resource or invalid _DSM return and not -EINVAL / -ENODEV as the comment claimed. Signed-off-by: Hans de Goede --- Despite the "Fix" in the subject this is not really a bugfix, the old code works fine too, so no Fixes tag --- drivers/platform/x86/intel/int3472/discrete.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c index 01da18b426ae..05e442078f8f 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -178,11 +178,11 @@ static void int3472_get_func_and_polarity(u8 type, const char **func, u32 *polar * to create clocks and regulators via the usual frameworks. * * Return: - * * 1 - To continue the loop - * * 0 - When all resources found are handled properly. - * * -EINVAL - If the resource is not a GPIO IO resource - * * -ENODEV - If the resource has no corresponding _DSM entry - * * -Other - Errors propagated from one of the sub-functions. + * * 1 - Continue the loop without adding a copy of the resource to + * * the list passed to acpi_dev_get_resources() + * * 0 - Continue the loop after adding a copy of the resource to + * * the list passed to acpi_dev_get_resources() + * * -errno - Error, break loop */ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, void *data) @@ -283,7 +283,8 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, if (ret < 0) return dev_err_probe(int3472->dev, ret, err_msg); - return ret; + /* Tell acpi_dev_get_resources() to not make a copy of the resource */ + return 1; } static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472) @@ -299,8 +300,6 @@ static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472) if (ret < 0) return ret; - acpi_dev_free_resource_list(&resource_list); - /* Register _DSM based clock (no-op if a GPIO clock was already registered) */ ret = skl_int3472_register_dsm_clock(int3472); if (ret < 0) From patchwork Thu Nov 28 15:42:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13888193 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6D61BCA0E for ; Thu, 28 Nov 2024 15:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732808550; cv=none; b=AGcpAP2tVyJD4l5rJu4EkVae7boFunQrA9Vi7pCRyD7pHDJ4ZDpZV+ylpeMNmsHyKZFILOzr/FvHEjFOeudSVk7m4Kpv3w5QyM5qOREUtBk3N6ehNGnvwbo1YjunG5UrcKP7gYkzDVA+gcyuqRgdnuztRi6Fqx7HwhBtDbTF8R4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732808550; c=relaxed/simple; bh=+B6Ca2370MIMWIgyY31aZ53DrtlGS3rHMkur1C3YVEI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GcftfXYoJ/fOBerk2TN2MTD/5XF9kaXAFijB9n1YBj2f4asTb8Sn9S+8UCchODTDUoktUKKReGl+zQbXEYLbjhN+VosyKMf0oLNg7atoqB9BTR3ZQ+jheGn/OXRbSH+SshcfzGOjky98653P9xbCNgxbLpvdSLX2XJN0FeJnYcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VmHc4wWs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VmHc4wWs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732808548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bLZv1/k6sDu5Vb/hLvpl/z2rTUjG3nOGcr1Qb+GvGbY=; b=VmHc4wWsXht2OxkNLcRdDHZ6BEUckfh6A6NxNstmZdWHo5nN9t2N1x66YUGOzmM4ThiqcE ZymuuDySTkDGa3DFLImp0t+qjKNtOaGLnYpc1NyEjSzugXOIiqsh+6qXM3HlsTvbC+WGCI 29is6VvGHORHGqWMq4GEI4TXLFbuK5M= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-5X3zSXXbN-upLBsWkfvt5w-1; Thu, 28 Nov 2024 10:42:24 -0500 X-MC-Unique: 5X3zSXXbN-upLBsWkfvt5w-1 X-Mimecast-MFC-AGG-ID: 5X3zSXXbN-upLBsWkfvt5w Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA28A195608A; Thu, 28 Nov 2024 15:42:23 +0000 (UTC) Received: from x1.localdomain.com (unknown [10.39.193.119]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CA392195605A; Thu, 28 Nov 2024 15:42:21 +0000 (UTC) From: Hans de Goede To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko Cc: Hans de Goede , platform-driver-x86@vger.kernel.org Subject: [PATCH 4/4] platform/x86: int3472: Debug log the sensor name Date: Thu, 28 Nov 2024 16:42:12 +0100 Message-ID: <20241128154212.6216-4-hdegoede@redhat.com> In-Reply-To: <20241128154212.6216-1-hdegoede@redhat.com> References: <20241128154212.6216-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Debug log the sensor name to make it easier to figure out which INT3472 device is associated with which sensor. Signed-off-by: Hans de Goede --- drivers/platform/x86/intel/int3472/common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/intel/int3472/common.c b/drivers/platform/x86/intel/int3472/common.c index b3a2578e06c1..1638be8fa71e 100644 --- a/drivers/platform/x86/intel/int3472/common.c +++ b/drivers/platform/x86/intel/int3472/common.c @@ -70,6 +70,8 @@ int skl_int3472_get_sensor_adev_and_name(struct device *dev, return -ENODEV; } + dev_dbg(dev, "Sensor name %s\n", acpi_dev_name(sensor)); + *name_ret = devm_kasprintf(dev, GFP_KERNEL, I2C_DEV_NAME_FORMAT, acpi_dev_name(sensor)); if (!*name_ret)