From patchwork Thu Mar 14 06:42:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 10852219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 47B7917EF for ; Thu, 14 Mar 2019 06:42:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 265272A1BF for ; Thu, 14 Mar 2019 06:42:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 168EE2A1C4; Thu, 14 Mar 2019 06:42:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9B8F82A1BF for ; Thu, 14 Mar 2019 06:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=dsvkKTZ9O4mex+lju7xMhwetbFmG2WxlvmqneRupHuo=; b=Kiz Mc0uxHyduOs9EdB+n40mFlPkoGu5noDy6v3AiRNeZqRiuI/UpQam1y8OsllUgAQlqW/4Emqix3F2W oceN0CUCb44m7v1EEkC5sU9+1UbGPp8tm2HFZ9xAiLSNDjvv+PIO5R2btJvB1Ictr+pOl7GNwccgl U0o/rKDfULJgUoynsYGfW5Cn1O5hZwJ6LM34xsTy8EhKbwGZq0iOixtTtZcjeuEJxKz8jCVZ6JIkD pt4FngMDlIptx54SFolrVBVa9WPBXM1fC6M4dKcMNKL2R/C7zTY0BvgjZ9pKD/Kcze0cohj91rlHB cei34NCurNl0Nkwf44TglPFzH87/wag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4K4D-0003Fz-Bf; Thu, 14 Mar 2019 06:42:13 +0000 Received: from mta-p8.oit.umn.edu ([134.84.196.208]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4K4B-0003FN-7p for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2019 06:42:12 +0000 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 2522FBF0 for ; Thu, 14 Mar 2019 06:42:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1LikGcljDFHE for ; Thu, 14 Mar 2019 01:42:09 -0500 (CDT) Received: from mail-it1-f199.google.com (mail-it1-f199.google.com [209.85.166.199]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id E4865B8E for ; Thu, 14 Mar 2019 01:42:08 -0500 (CDT) Received: by mail-it1-f199.google.com with SMTP id i4so3827011itb.1 for ; Wed, 13 Mar 2019 23:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=djczHsp7CBHav0Hh11ppVz3UNxAxa2JmLPeSFnm+Eo0=; b=kmyO8qFyE1SjY3hAgU214XoSWSUVUuJ2n01JQgoIQgmEZXZ7rMRBfBBPpwWcyvO2+7 aNuTUlaeMfM0GNCy+i8PW53dEgjpJBNN5dhIHVyhUvGqb2jOmb7hzlCXGT1xXioXgtu7 RnaBOcb3fCWKpzBEmxCQMS/yPKk2CfAU4u+D2t1J06uJE3sy1pN2ZFkFGdy5PgMpY8zq UkGpugDiA5/I8EyMpqC0UgR5PyK59zThunc2BKLk2QfjuV50ZUmcbpcZPK/mzbKFDG22 YblhXV5KeRY/Zbuxq7uMDO8HOg4BRA1wjzlj+iUtxm4qQhRC8dfRv5YWk2zaKDGFBFXo jE2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=djczHsp7CBHav0Hh11ppVz3UNxAxa2JmLPeSFnm+Eo0=; b=KgrOvywadLGV8qXvhTvS/T/K8rXOkLOmhrbdmLicJZpxNk+xdopIrEQc/mU/yc+RJV PtWfuGUtGtdPcB6q/CDRcOHoWEMPsIETKoe/A72YiFqHrME2T0MklPWWXHhlmB5TN336 yNTczNnY5N/rVNwO3o+UnXGpd+TKivgshFTkOhVg7HTqoTTxcDvRgFMTSCPAwsOaieZZ vBgOFGoE+njq96MrACBX5tXy9ky5dmeBPJW8CwlVf7TRZJ6nhaZJkfx+dQMt8r0B0Oea zQw2F4E5+Pjwiz0E/Dor8k8A1Jkso6ZcW54GRBn8WnUKGizLFxhPLb2ejiztpdsfrCye LaUA== X-Gm-Message-State: APjAAAViwcQMm762/ewuHh36Mv8Pm39u+AUMvLcYUsfwifoCDNOQJLVA HWgnlxwS3ApaHmrdJaKGvd6qI3nNrx0pWwTc+a/LqDXCNDH/hu1TcVv4Y1kiv/tvnP8IrnCDE6Z CF0X6yT4B3aSGyj1EOAN3OXxuex/16ATNwCpVoU8= X-Received: by 2002:a5d:9455:: with SMTP id x21mr26922708ior.250.1552545728500; Wed, 13 Mar 2019 23:42:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFWKuN/f6S7G/2+tGu7Ix/FMi6al4o5VH9Mwnfc1piVdtuHnK72QxIfLkreCKIJli6pvenZQ== X-Received: by 2002:a5d:9455:: with SMTP id x21mr26922698ior.250.1552545728284; Wed, 13 Mar 2019 23:42:08 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id p4sm6132871ioj.36.2019.03.13.23.42.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 23:42:07 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Subject: [PATCH] spi: fix NULL pointer dereferences by checking dmaengine_prep_slave_sg Date: Thu, 14 Mar 2019 01:42:01 -0500 Message-Id: <20190314064202.14864-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_234211_389776_D99DDA46 X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , pakki001@umn.edu, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In case dmaengine_prep_slave_sg fails, the fix returns to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/spi/spi-s3c64xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 7b7151ec14c8..3a5f161ce558 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -293,6 +293,8 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma, desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, dma->direction, DMA_PREP_INTERRUPT); + if (!desc) + return; desc->callback = s3c64xx_spi_dmacb; desc->callback_param = dma;