From patchwork Thu Dec 5 06:40:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manikanta Mylavarapu X-Patchwork-Id: 13894746 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D3BD18FDDC; Thu, 5 Dec 2024 06:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733380885; cv=none; b=fspsqxO9/WQhOgZHFb1gHnbhENzA+71VT1BlKdUrPSjuvB+ZkfeA07kMJUAzpoczM9tIYNF6v7aJAYsUkZfyOBYOQFs/o1a5MhxTJmcAwdwB41TD/BxZONPwdzyBpNJ6K9i2Umxc59dVIn0DG+hFiYN0IBILuJ6wuyphr0XbOjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733380885; c=relaxed/simple; bh=pnQ7lrd5rJR2VwEgYT3foFAOMi1xJ0apXrQnyBre3WI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J23ljrUSYj7BIKAa0c6Y4EfHXf9rrFN/gfWO5YBU0WhOZ21fUZ356IKKZPLM0BgswzJCIaq9RIs2xdX9wy3cZNxe7I1Khz7C4FDxbqAIv2kfMMR33tHhJ9I4MocTyJEINFve9h6Bv5Z7dk2fssTXOhTXTvUFaxeSvqc/vTM1pic= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=h3CMn8MD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="h3CMn8MD" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B4HRtKw031023; Thu, 5 Dec 2024 06:41:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RIum3ECAP3cphxVispyZ3KDCFW8Nu1CKDyKVVZCtLrc=; b=h3CMn8MDs0UUXnj7 RFNtT7iDxBK9/NdDfCds+rHTpM/UaXhFJlgl2iedR5vuPI4h7Z7TPAyYJDeZT8OZ Y9fyzVKThB9djC2i6eeF0FqFzKM12F+nQX6ACKaN4t0wuV/vJaQHsTJw9KVHy+4f CZmlMT0jEyccx7T9NlQjVktrM9B3dpWJpUaOA/oWLq2KG1YWFQ9dDFbCyTbYBmjU LGYujQp7/oOwdE7e4unY06wNno/mlHQC3tv5aFjht//JMyHHc97Nn293hixjNaO/ RScb5aZvzthbQSUuNfGDOQah6FnYjuZqfkFqXZh2jsoe4kz28dS1eTOckEbxAoC7 JbsIAg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 439w90xkfu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Dec 2024 06:41:20 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4B56f7Cw022285 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Dec 2024 06:41:07 GMT Received: from hu-mmanikan-blr.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 4 Dec 2024 22:41:03 -0800 From: Manikanta Mylavarapu To: , , , , , , , , , CC: , Subject: [PATCH 1/2] dt-bindings: clock: qcom: gcc-ipq5424: remove apss_dbg clock macro Date: Thu, 5 Dec 2024 12:10:36 +0530 Message-ID: <20241205064037.1960323-2-quic_mmanikan@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241205064037.1960323-1-quic_mmanikan@quicinc.com> References: <20241205064037.1960323-1-quic_mmanikan@quicinc.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: EvW-3B3r_eisskxLUgrBqyYwzPN-iDc3 X-Proofpoint-GUID: EvW-3B3r_eisskxLUgrBqyYwzPN-iDc3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=955 bulkscore=0 impostorscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412050050 Since gcc_apss_dbg_clk has no consumers, the linux kernel will turn it off. This causes a kernel crash because this clock is access protected by trust zone. Therefore remove the gcc_apss_dbg_clk macro. Signed-off-by: Manikanta Mylavarapu Acked-by: Krzysztof Kozlowski --- include/dt-bindings/clock/qcom,ipq5424-gcc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/dt-bindings/clock/qcom,ipq5424-gcc.h b/include/dt-bindings/clock/qcom,ipq5424-gcc.h index 755ce7a71c7c..9f14680052a0 100644 --- a/include/dt-bindings/clock/qcom,ipq5424-gcc.h +++ b/include/dt-bindings/clock/qcom,ipq5424-gcc.h @@ -12,7 +12,6 @@ #define GPLL2 2 #define GPLL2_OUT_MAIN 3 #define GCC_SLEEP_CLK_SRC 4 -#define GCC_APSS_DBG_CLK 5 #define GCC_USB0_EUD_AT_CLK 6 #define GCC_PCIE0_AXI_M_CLK_SRC 7 #define GCC_PCIE0_AXI_M_CLK 8 From patchwork Thu Dec 5 06:40:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manikanta Mylavarapu X-Patchwork-Id: 13894747 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BAAD192B76; Thu, 5 Dec 2024 06:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733380887; cv=none; b=Ay63sIl9eSBZoNncXuSIkerXuPcX660q10aEEIoUfoppgj65i27t1kuc3teLCpc/f1Gdw2C1hIn2TxxyppAcZljcgKh97IFT3j9IAYNSAIpeYcvcRaCiHieX2yHtGKn+f3O0nNEptBfqklGBKGNUsEljLUvjEPHi+BBheTp/XLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733380887; c=relaxed/simple; bh=7y61Szbo0YZxuNPGNDdpdVPsSX+fxhyqqHTf4XyuW6o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pBCKyuWCWCxjkw5fi8i3l7cvAWDXecvp4WvLILQpjPDG2LZdaJ0pOb8TRPYgeq+rZCKSAS7R3OoKPIqF0sNbMhrgmL8PeNtYUCieCGAnfKjDgTWB4y0q89AxwjcM9E0Fqr2GmuiwUAW5rWJhVV1oPlIx93t3eDfSarEEhiH16vo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=jz0vKuk7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="jz0vKuk7" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B56fLYo010466; Thu, 5 Dec 2024 06:41:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IwikryN/Ak1h1HjtAKPExiwApiVcG0AzLSv3BuQt7Tw=; b=jz0vKuk7Pp3pkHvO cn2giSeqn6KOjKb1McJl4PmRcaAeErLgTiUnbW6Fcl9XokortIjI9YfleiDbCD6g saN2Chc3SyolkhtpzEJ8yQ3NrjSGU73k+N6Ck2bhS8zFhegbSMWZ5v5j80It7dkr k7YdoWQnE6jy+2IfdOYktkPhvlP47Q642KdQD4Czg+kqZJ/MYANMI+3w/CtImvUs azBeXWWcNmOijcvixBXglaECs2wOySvTgefS4TuhQTuVB/aI2BAEiNiZPFPprzrg +OHcX0ty9frc5L0dYKdqEOinYU+msewefmnPk6MXx8nlvrjrt2D+5V5sj+q6wU2S peQbRg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 439v7yxqsx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Dec 2024 06:41:21 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4B56fBu1022434 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Dec 2024 06:41:11 GMT Received: from hu-mmanikan-blr.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 4 Dec 2024 22:41:07 -0800 From: Manikanta Mylavarapu To: , , , , , , , , , CC: , Subject: [PATCH 2/2] clk: qcom: ipq5424: remove apss_dbg clock Date: Thu, 5 Dec 2024 12:10:37 +0530 Message-ID: <20241205064037.1960323-3-quic_mmanikan@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241205064037.1960323-1-quic_mmanikan@quicinc.com> References: <20241205064037.1960323-1-quic_mmanikan@quicinc.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: FAEEP8NQ_ew9VowwCYlRyb_5ozL2Ynlw X-Proofpoint-GUID: FAEEP8NQ_ew9VowwCYlRyb_5ozL2Ynlw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 impostorscore=0 adultscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 suspectscore=0 mlxlogscore=934 malwarescore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412050050 Since gcc_apss_dbg_clk has no consumers, the linux kernel will turn it off. This causes a kernel crash because this clock is access protected by trust zone. Therefore remove gcc_apss_dbg_clk from the gcc driver. Signed-off-by: Manikanta Mylavarapu --- drivers/clk/qcom/gcc-ipq5424.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/clk/qcom/gcc-ipq5424.c b/drivers/clk/qcom/gcc-ipq5424.c index 88a7d5b2e751..5f42ac6c8cdc 100644 --- a/drivers/clk/qcom/gcc-ipq5424.c +++ b/drivers/clk/qcom/gcc-ipq5424.c @@ -1097,24 +1097,6 @@ static struct clk_branch gcc_adss_pwm_clk = { }, }; -static struct clk_branch gcc_apss_dbg_clk = { - .halt_reg = 0x2402c, - .halt_check = BRANCH_HALT_VOTED, - .clkr = { - .enable_reg = 0x2402c, - .enable_mask = BIT(0), - .hw.init = &(const struct clk_init_data) { - .name = "gcc_apss_dbg_clk", - .parent_hws = (const struct clk_hw*[]) { - &gcc_qdss_dap_sync_clk_src.hw - }, - .num_parents = 1, - .flags = CLK_SET_RATE_PARENT, - .ops = &clk_branch2_ops, - }, - }, -}; - static struct clk_branch gcc_cnoc_pcie0_1lane_s_clk = { .halt_reg = 0x31088, .halt_check = BRANCH_HALT, @@ -2785,7 +2767,6 @@ static struct clk_branch gcc_pcie3_rchng_clk = { static struct clk_regmap *gcc_ipq5424_clocks[] = { [GCC_ADSS_PWM_CLK] = &gcc_adss_pwm_clk.clkr, [GCC_ADSS_PWM_CLK_SRC] = &gcc_adss_pwm_clk_src.clkr, - [GCC_APSS_DBG_CLK] = &gcc_apss_dbg_clk.clkr, [GCC_CNOC_PCIE0_1LANE_S_CLK] = &gcc_cnoc_pcie0_1lane_s_clk.clkr, [GCC_CNOC_PCIE1_1LANE_S_CLK] = &gcc_cnoc_pcie1_1lane_s_clk.clkr, [GCC_CNOC_PCIE2_2LANE_S_CLK] = &gcc_cnoc_pcie2_2lane_s_clk.clkr,