From patchwork Thu Dec 5 16:51:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13895789 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2076.outbound.protection.outlook.com [40.107.22.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9515E22577E for ; Thu, 5 Dec 2024 16:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.76 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417493; cv=fail; b=ReUdq3XAy2FVGqLw6k0+Vz4kpjmEIGUmlXmDGiabn+8JMr+l86B5e19sVM96cM1ZFaKPpQB2uZ11SkDjCGtB0UeBqWTWAt+2APZAIIHGZRfdB22rweWGlWnRRpx8vD75yZ+7/XSZZa7r8kJSQHWgAFWDCk2rZOF0YGBp9ctAifU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417493; c=relaxed/simple; bh=E/9uxdBtjF0j6zPxcwv3XbWI+yAR6dXtQGZlNmZDiU4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WdMYcFQSRp3l9gqj+N/psqd3KWVy2lAF6RPZ+ne/3rXexE4r1OVzPsu+Zq1AMJNdA2gxjnIdImKcRl/tLuueCPPQSfH1+tnXINzOCI2v/AAvZwh6JXjPJnFuXoRliMEkD/OnGf3kb7V5LAr04uWxRrrNJqnR4I7mhZmjWO6C+pM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=VrGtP9+c; arc=fail smtp.client-ip=40.107.22.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="VrGtP9+c" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gHY4mPNFdNC5sn6KzXlE1xbbSEmRH3G2kG5KDcRffWR3BVSo0ASvswLui26WJLF9bUKxsLDwneI6Ko7OUr2ipdew1LmMHORNTz55jyPq0HLbdElA3YniZB3YL5czvPqb8v4/ih7tP+DUQAl6ZAwugNsgCtw0E83XqKXCxY1dbrc8lilGOB0/5eV65c2o13JFDsN6S/K4c1bF+AzoTahMyPX8XofetC6rVK7D/ILSJ2kimdbyl1rWg0drbgwDRV2/VFpA3HlQlgrc2Kxux6SDJK+MLOVN5Rx5htHEqpzXW8EoYWfYjV5Dfj0Htwg/FHMJAZwheOCSTuktNI9uI+HnMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6sLpS2YJwvojP2Rq1CdHzqmGzIPERE+0rD2KZt8p0Vc=; b=kLnVYrn62Hru0da+xUZNSqPGjuOdm6XGW8xIAo8OwBe9DVhuQovn6pCHFQdyNKMAR+vxoa3iZXTebEdA6bDGfy/BVuVn+n7/TtKk0gvSXLb46DjkQuWuwu4JQtqJ2rnszFz87WFbH/E+RkflgCnRO3NdVG+DrchFIkxahuBv9/Hx/BkeyrmmyvZed897snKZUDgTFzT6vRV0cQvS9sjlRoG8m5btB/VhYCp7jzOZJoHyUoFdXiQLaaAJLo8aNmOQY5GLltp/JBqXs7sbg1ib/o3H5oHQV9oIG4c7iX7z//gFvKKaapeP7jO5rIRjEzgetNOkZJDAW1mvpEJfz+n9/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sLpS2YJwvojP2Rq1CdHzqmGzIPERE+0rD2KZt8p0Vc=; b=VrGtP9+cM00tHMrwtb7t7ZbO6BhBsbTiBZl/LRMna2SnSo87T4Cg/+jXGJ1BCVxiRFsBTKee5bTgnaYiC6pdSfcoDmxCt2FictsZggzA0qxVL947XmQHAphLLV5/i+Zv3Z40L3Mj6bOJzQQZ6Z8sPadnV4j7uepAqmokAC/hU4tXvmUgeNQdXXLhMHE3UziooQb0vCs6EjTwAdzMUII/fSVt8vht1wav3wRanL2zFKAkqt8HScd2QbdwMHveN9EACalqAh4GjQaezoi8TPJhkLMS1GdqM3G0JOwS9lVW8LELRn/XO/81vXHrFCKvwcMcVz6ZRST2zkmqM3D1f8GbNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by AS8PR04MB7511.eurprd04.prod.outlook.com (2603:10a6:20b:23f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.13; Thu, 5 Dec 2024 16:51:29 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%4]) with mapi id 15.20.8230.010; Thu, 5 Dec 2024 16:51:29 +0000 From: Frank Li Date: Thu, 05 Dec 2024 11:51:09 -0500 Subject: [PATCH 1/5] regulator: pca9450: add enable_value for all bucks Message-Id: <20241205-pca9450-v1-1-aab448b74e78@nxp.com> References: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> In-Reply-To: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin Gong , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, joy.zou@nxp.com, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1733417480; l=4660; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=w0wr4uNLDwl95zI6sHN+f9rDrooK+8cDnt8wPRzm9bc=; b=qdUn7TI9xxJdccSA3p+UtGamFXi39sMiW/XoATXHbl09sXZPD7lSCGomd95FiS9uqApO5qX6F dNTTCMcAn0vDRkFHwsv2/ZvXeyxPos2Ea0jhk32Z8Hq+Qiw+qHjBVAy X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR02CA0029.namprd02.prod.outlook.com (2603:10b6:a02:ee::42) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|AS8PR04MB7511:EE_ X-MS-Office365-Filtering-Correlation-Id: 887a29e3-8a75-4820-1a9e-08dd154d109a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?jf4SeNIOh3CV58GHRsqkFYUpZ6xwTep?= =?utf-8?q?6oqPJhvb/oCTHfBe+M4zqca+aFKXxDUXsl0nAmdiF0z22/HM52UulomGZ/HvBFORv?= =?utf-8?q?zob7jsVrjHvSdWNWHlqNEHon24nNs9sHMZrhzWpXvBaRrm29XlW4kO1cDZKDfotrv?= =?utf-8?q?gf4ENsen/n2dYQLbWp1VBPpAbwMsfKA8ntVSXV4JfrPFBwWeGMk23xtCREbWEZBpQ?= =?utf-8?q?hgj7YxuZ6enQhg/6ljdeAiH+IEdlAppX9gI9hnaQeib8swYdQH2qd4J9pTvutULDq?= =?utf-8?q?QHhiaJG97GQKoXnoOsC27l4BEsHfnQk7NDp2SS1srg1lCpvVB10ruiZCJyPkMuksM?= =?utf-8?q?QvCcG1GJl5VQ9EiMd4RUzQBXMEpUez5URzO+zvQDvA2eiIBPj0+MnEP50vgiPx0/2?= =?utf-8?q?Qt0rCI04vb6hhYPmzwYedLg+zOuDPfPlNmvZ33m1STLuOWHF7d5ZXf+wKrmWRxnho?= =?utf-8?q?E4IwWI3Ub0EvoWI9UkTsJlqtxppP4K9NC1aPSlp//KkxCQsjXDbptG0nxEXjGJ03N?= =?utf-8?q?ndn3gD942bqwvZPRfhTnRhCkZ+pg7W2yTjXV/nfR3y3vq+VYv3wiCJGNKnFdT1Rdk?= =?utf-8?q?zDPZj8jPM7qZEije4Ss0nMCOmht9BJRRSAHijSmsKwnCfwiNU8rc1c92FX1DDjPU7?= =?utf-8?q?c49s0p8cO2lJg35v+vHqcm2tcbevf4rZlTikqtJpx6BuYJbPS3dqTomzSxEvZM2nN?= =?utf-8?q?wQrQrfhWwPtPiSopWB9avN22QHbpJd3qXu09qEZHbeMHd2q4/wxyDMyGINT417kDc?= =?utf-8?q?NtuIxnI1VZzyCxPwRhey4ZCxh8ebn0/e3LEwESiM+HEywfZk73fnNNimMkgVninwk?= =?utf-8?q?PlF8Q2yClE5+FfqZ7aKdIGO/E5SjsQCTwjST40dtjMmDHJUSkgQ8uGOh3FwV7wRi9?= =?utf-8?q?+tJ2X6hi+l+hbEshn9j1tABZRu2f7hkMgQILwX9zPpqnytTi6RSebyIeLdEpiXYki?= =?utf-8?q?yh5NRRd9viCewuvvIUqodGlJ5+vj9VwcP2ep2FT7BXYkVjN6vIMyu5z/EBm9oCKxx?= =?utf-8?q?o1UQqYDITulceiz5HEEYFh6GUurJgPRLnOwWJvmalDsNrIKF3RqIJP9ixBxQ7JxD5?= =?utf-8?q?lRPZHk4jt1C1SsLNn235dv4eF59PB3UbHZ+TlLbtbq4x41uA8oBJHHBVM9AhdXYAh?= =?utf-8?q?O5DPU2iJqvAsTb2UIpo4L76HjP8SeCsnsE91bHZNn2gklAIDqHV2MSHWK+pD5GLjq?= =?utf-8?q?FJ7WRjN9LXzfNJTuI8xWCTCh+KXG6NsURIi3sWA2ccRPPM7TH7nL+v0GsuLvQa1S6?= =?utf-8?q?E8P1szu1SNDT2blbWcsPXduNws6PifnYZ1s7sdQAwAoMgQxpIZGiEhBf+XbnZiEaf?= =?utf-8?q?VAQtXosgfdSIP1oUWq6at6m1Ov8lmoJZ2a3Wzkb/3V5W7sRDwrVOap8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?VXSvimFMBS990Ol2MxJqzDF7ZOjZ?= =?utf-8?q?ZAza2JWOr23NPYIkwqaa7jeO8r9fd4SthlQQ6snXgHXn+KQY/DPpD6CyRJovliqDH?= =?utf-8?q?5Sr8U99lk23x+JNwT5SJMNaaLQPNj6/9rD//4y0lNgvGlLeQf1zxuHiFfWnSDVgdQ?= =?utf-8?q?oN09mr/5hx7YRf99bQoeKmuxsFeJzwqXZjJRMQ0NuqE6iGAQqGLICsaA8hgDT2idZ?= =?utf-8?q?fJNQ6ibU4aAQR1Vn1fvkaYtvo0EnsTJZ/c45Uq8MQZNu2kBRVzNUhDVb8P71/OiiP?= =?utf-8?q?WU182bSIvvlcWF5zzSEAGsUusaFCmOWUQkn9ifaTlrMZscgWu75SadUZJcfUpFXHP?= =?utf-8?q?lQHm+kiB0DBFi0rcBIWjt7jE+cS1j9LeyrqFZYJIqaRQxx5yp+RiIz3vcwhv3Hp4j?= =?utf-8?q?DplBMomy7aE0QkI/QtejZEts6LvqcFTj0NSqz/0+o9qkY+pZshSLDvqG2kALg6hzZ?= =?utf-8?q?F/HplQXdSrbhSgiB2WnqxYmdNzyQVjENxTD4pvMRMd/XqXosmcg7cnYaSviUevjbI?= =?utf-8?q?A3rUSY0j1ihh+jaZhcsCvWPqdYsJp0PH1Cz1KppFeiUDWzvhwCkVwqw4Gg821GNbD?= =?utf-8?q?i/RZTpymdwlLpkOm7Yr+pJVsfqXVaOx84pjrtKFwwPUyAlnNBcNDopfpBEeFO6r9d?= =?utf-8?q?xPonVEknOImmZ65J45PAliXlCqH1sd708sVyzZ17ps4uivCgaBOYKjI/XS7atxJrt?= =?utf-8?q?QJlrq+RYq/B6O45EciDYtl9KI7aulIt4mVBjVchGjYlo+/LQdgLmu5mKaZ8Op6jAU?= =?utf-8?q?A9NRYcUqkMz5FKIrAg7WDxiowO7oCgIBZm2wFxYPosBTitE/9WdzaatOjLPFjUZPr?= =?utf-8?q?5vMdKh3NjvArL4PZOplFdOBLDnzTb434ZgEhIScrUPeUKYg5DEjeLHkiDuEvJ1lIm?= =?utf-8?q?Q64N2R62vtilOkbXaCg6AG1y9AzsuJtjL+tg1VcWWMd+5+cebB+akjOTasbi81KPh?= =?utf-8?q?q8ZnhFJBPKhSSWF2S43WmVPhHcCaF+wg7RKvrmdHD2qNXnGKnXbZ+kv0qqN+9A/fF?= =?utf-8?q?edLUyvnwsiXiad8nYIgbW5BLd/ldooyaQm0dS0w1Db9GSNoYfbMEVYAbWqjfOomig?= =?utf-8?q?OwhL27dNnGI6LLUI3aULLYNmr+OJtX9WlQy52CJsgiJNfndFnX3ocDjzfnTjPr/4O?= =?utf-8?q?M1oCxJC6VAKeyGgnoWS9SHJ011LQQyiLiW1oLmpzYC89uVJUcNb0GDCOwFuvndAe8?= =?utf-8?q?yO2b0R3/rOOIdHTHzF9goVItfluaqyh2U7h00Rudpn387ZhvRYNZBXMKCRGwdNcik?= =?utf-8?q?ISKUUUBYjaaCiOkPx95PU4v8HIeogtaWuZmmNkHiw2EYaF47cKVKRaW22BVVua6RY?= =?utf-8?q?Ej++HSpPE4vL2lXFgP1uzOBBkw9Ddw3+xQ0L/qx1J9tYt5JNKCK03njeUmlWylVuk?= =?utf-8?q?sIFWh1cFuZPOU59riLUpYIG4/B/vkrDrY2Fm09dIIE8VHAFIZFXYELibtmljYqDQS?= =?utf-8?q?nCdCACRTN3kWG6lLcwc0cfUlfPPKtr+jrUVppYW9NsK/RHbRGqrcyGFVACG6UmKTU?= =?utf-8?q?r8GTnlz+3xG7?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 887a29e3-8a75-4820-1a9e-08dd154d109a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2024 16:51:29.5233 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VCvNJOHlRwi42a9aDNULj+riWjtAEOi80JCv/qmggsbasVsDtWYSdusXYwKh9CinSGgX3CO8bv1HvMs6s4+R9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7511 From: Robin Gong Set 'enable_value' in the regulator descriptor for different bucks to manage their enable modes: - 00b: OFF - 01b: ON when PMIC_ON_REQ = H - 10b: ON when PMIC_ON_REQ = H && PMIC_STBY_REQ = L - 11b: Always ON Ensure appropriate behavior based on the intended design. For example: - Buck2, designed for vddarm, should be set to '10b' (ON when PMIC_STBY_REQ = L) since it can be off when `PMIC_STBY_REQ = H` after the kernel enters suspend. - Other bucks remain '01b' (ON when PMIC_ON_REQ = H), matching the default setting. This avoids the need to re-enable them during kernel boot as they are already enabled after PMIC initialization. Signed-off-by: Robin Gong Signed-off-by: Frank Li --- drivers/regulator/pca9450-regulator.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c index 9714afe347dcc..caeeed433165c 100644 --- a/drivers/regulator/pca9450-regulator.c +++ b/drivers/regulator/pca9450-regulator.c @@ -247,6 +247,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .ramp_mask = BUCK1_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, .n_ramp_values = ARRAY_SIZE(pca9450_dvs_buck_ramp_table), + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, .of_parse_cb = pca9450_set_dvs_levels, }, @@ -272,6 +273,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK2OUT_DVS0_MASK, .enable_reg = PCA9450_REG_BUCK2CTRL, .enable_mask = BUCK2_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ_STBYREQ, .ramp_reg = PCA9450_REG_BUCK2CTRL, .ramp_mask = BUCK2_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, @@ -301,6 +303,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK3OUT_DVS0_MASK, .enable_reg = PCA9450_REG_BUCK3CTRL, .enable_mask = BUCK3_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .ramp_reg = PCA9450_REG_BUCK3CTRL, .ramp_mask = BUCK3_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, @@ -330,6 +333,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK4OUT_MASK, .enable_reg = PCA9450_REG_BUCK4CTRL, .enable_mask = BUCK4_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -348,6 +352,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK5OUT_MASK, .enable_reg = PCA9450_REG_BUCK5CTRL, .enable_mask = BUCK5_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -366,6 +371,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK6OUT_MASK, .enable_reg = PCA9450_REG_BUCK6CTRL, .enable_mask = BUCK6_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -481,6 +487,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK1OUT_DVS0_MASK, .enable_reg = PCA9450_REG_BUCK1CTRL, .enable_mask = BUCK1_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .ramp_reg = PCA9450_REG_BUCK1CTRL, .ramp_mask = BUCK1_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, @@ -510,6 +517,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK2OUT_DVS0_MASK, .enable_reg = PCA9450_REG_BUCK2CTRL, .enable_mask = BUCK2_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ_STBYREQ, .ramp_reg = PCA9450_REG_BUCK2CTRL, .ramp_mask = BUCK2_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, @@ -539,6 +547,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK4OUT_MASK, .enable_reg = PCA9450_REG_BUCK4CTRL, .enable_mask = BUCK4_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -557,6 +566,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK5OUT_MASK, .enable_reg = PCA9450_REG_BUCK5CTRL, .enable_mask = BUCK5_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -575,6 +585,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK6OUT_MASK, .enable_reg = PCA9450_REG_BUCK6CTRL, .enable_mask = BUCK6_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, From patchwork Thu Dec 5 16:51:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13895790 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2074.outbound.protection.outlook.com [40.107.20.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8097226ED4 for ; Thu, 5 Dec 2024 16:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417498; cv=fail; b=iQe3ckSzYZgM+G8eIVEhFJA3g9NuG388bLIjvcDAmh87IsXJ1gxUMbf3tAA3yYOCnHYIfFDEXKKEGfPTIbVe498BM4SjX7+EcnMhXUqBQ+JTLoIrn0DY+5hKeu8uJ7TM11nILFBlt1MUGOVxFBd4km0VHMJvrFh6Dn00wuYNVds= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417498; c=relaxed/simple; bh=a+/tdvfNrna1Hxq1r+zVZqlrUGxbeu/wyD9Dmoa9nNQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=N5jRdbHIkP4vJ2tXpiQ8yAyGHNBxQ/n9QhXB1821qhbSTZHd/uatB2rgcuh8bVzdT02wtrV9pTrJQujjF4Kp405mNBQYdy64Dw3Ii4l08RxAPs8dEoFDo2nY2JT34cCpEBqOx3b/leZIuSk+Srnt8zAhazlulKE+ZBKUV5YCTU8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=c33WNS/K; arc=fail smtp.client-ip=40.107.20.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="c33WNS/K" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=euZUYETpnlbVgx1Y/ZiNbk5O6UqVw0ChMtXX4xBNusWgLPxsd+iYAH3sa6+vHnhvMAD0wVlUv70FbNCjuHc+oX1ZUHp1yxxucFAdddgTKSPlZvULWAB5JSMWfmOazv1yTDxRPH908qVN/YTFvSAIfd+SXQSQTxzZZele+x2UHV4DjwsIJ4GMaMXOKmCeQBHVxNXtUHepjKFaZywXa6z5BDHbx5Hr+wy0OLogu2Noz6UwVYGAGq7Z8B37JdCjBwCLK/FSzKc/eWpQtKPH7pb55ambjcHZ0XRuaaJdCmz/ejODzK8cA3NFrXHGRxfIEuDkm9IfJCPRW5rThwDuilmUbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yLDBtNfni/M0yr6E6A9udqNvO4y+WKxsbN6N+QmozXQ=; b=Rq5+DQ+Bs3e8/yEGLDMFgOE8fkCu+bnXwy0UEemwLNoDgYBkRpScjL5DL8eFIEG5QfsdIMfLiX97Ytlws/yUXv/o0ju7h0ITc4TA0joq+JhNjsvn3p2PlSjlNGoyYsXSyXgTqqZ6wcqzZu+Kl1aUrW/+BOymyCGkMQ/z1CvrwbcL4sx9grnt9f5KOL7uUquCAgAc9YYl+EYdB5Ej5vurMEl8uWF+NSpbj2blxdd3sQApI7CnHNeCKhJq8g6wINlVjZo1dMPeSNTIaeAGg/31RYr5xdCRUQIlFGKcvhO+jhPhuT9DnOGlz5Hl7ogiN3sZpbkPkp+Ob8blQ1s43uXkGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yLDBtNfni/M0yr6E6A9udqNvO4y+WKxsbN6N+QmozXQ=; b=c33WNS/KfisrULUGfVAvZeFW0GbE6Uhql+OUdrhu5OzKPJkwYsqC9RI9nVb3imWD58idRpjtCwHMJ1uJMuTXuXYOHvf78f1A1W2HWESWL48tnuhuRXpes28SZ4RjN1ClPXBOSxLkY/JDRFrvBSsFthTpDyO6CF+LZWFE8Dveh92TpFdbsT5IV4+TpxncqlfApCDxJUA44RwypLgjSnrT3alLEuu7br5K1NXBZl8CpoUxatxh7THFKQTLlVda/42lIr7eCgRYH1Pbl3i7ioY7uP4/v5P471VaLC5Av9+eEvFGcIrM/kjVF6G7d50RV8twA2Uka8fqi2+VdtDkOaXKrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by AS8PR04MB7511.eurprd04.prod.outlook.com (2603:10a6:20b:23f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.13; Thu, 5 Dec 2024 16:51:34 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%4]) with mapi id 15.20.8230.010; Thu, 5 Dec 2024 16:51:34 +0000 From: Frank Li Date: Thu, 05 Dec 2024 11:51:10 -0500 Subject: [PATCH 2/5] regulator: pca9450: Use dev_err_probe() to simplify code Message-Id: <20241205-pca9450-v1-2-aab448b74e78@nxp.com> References: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> In-Reply-To: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin Gong , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, joy.zou@nxp.com, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1733417480; l=5056; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=a+/tdvfNrna1Hxq1r+zVZqlrUGxbeu/wyD9Dmoa9nNQ=; b=SYZYkK/PEqkwMefZC7ZooIhhLiJ/UCY8lzC4yOl4E83iuDh923XrnTWkcwNCeTGLkAShsBAta IGSacrTzwH5D5LKTDq2HfaIRE/0vAfbCkanfgs+DT4z7IisWh0BTZQt X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR02CA0029.namprd02.prod.outlook.com (2603:10b6:a02:ee::42) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|AS8PR04MB7511:EE_ X-MS-Office365-Filtering-Correlation-Id: e59cf302-1fd8-4f24-6375-08dd154d1344 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?v4p8FK39Z20nAV3uD1Qtw29BkG2S2Qe?= =?utf-8?q?3CnVbBodTE0GUQPg1U+9c/19RC5mOMOC2TCWBIuIgMmPadltOpsyiHjj6FAEd0LvQ?= =?utf-8?q?PJ8Filom4gVREmBgLYkxP8j9rOkLnibm6ZV3UavHnCv2R7gINLUXa5ky3afPKHgDW?= =?utf-8?q?sTcqMPmYdZRczlxVNLEE94w8Erk88Fs2ZMkNXW4yGjwaTHAXsP7GMHnxTpxTDqHLC?= =?utf-8?q?5mXkoJaM+pRfWyAfiSOPS+cR0gOvX6ffSoP3+xQ/o6Z20HMKlr//ub6FDcLH24T5O?= =?utf-8?q?U/kXmI5Fl9016dsVWpsRRU0c6Bm93SAV27wGFHjnm376QvTmeXNtwQJNO9it/vXnb?= =?utf-8?q?VKfi5nMQSzBPBVFzkRPRM2IT+odl6Dw30kLOLLlFwT5GLR9UJgUxt+tLTHD93Lcta?= =?utf-8?q?bKzoFva2wz/+vQ/mmS9ogrn7tFty0ivGlEs2Po8bVk+hTNATIGrrHcXzb6DmSDKOH?= =?utf-8?q?DDJQGC0zbRpsYmpWY5wALGvGVPLHAzE6P4/3FHb2fnXbKx6rNfkrZAqPYW8w7ZbsH?= =?utf-8?q?APRkLLEEtaZpVo7kHgYP+C3Iljib6FU+Og0Dm8hgBv6VIFACTwC4grO+8vrd5laQL?= =?utf-8?q?7Yivnm9EIh2Si/NSUtwyFl+6BOegaWA+GXFMJkklG9Av+T0Te9OMpAfGdd5pwWM34?= =?utf-8?q?g36dDY1ZF9yO/V+ZbD70PmZA3V9yQSfyNq/gzYTi9HV2qbeOZm48AqoC+IO09Byre?= =?utf-8?q?4ZFV/JhTQzBBwAkb0ifJ6E+G+UVLJF9kPn0Auxi/UII2hhuB41kPeGOBiJRvttzgR?= =?utf-8?q?Fb8+zDbMBNRryAqclPltuHm/67NeCdxRu90DUPHME0dh5jVQaNQNBb0EPE7kL3VD0?= =?utf-8?q?rxtqMd4fqdXGpxFtjDasSel15HEjMpw3mOExej6sPnj6d9UmY3X4N6LrfP1HG0X1Q?= =?utf-8?q?fW4skLh+qPABr882xtiHn1QxSWxCRT17yxmbZKH3wujor7Hn9gQrVOSzAx+xY29b7?= =?utf-8?q?aK041wLD+wo6L9FL8lErcfmX7AzZfYgxHAkpifGMT4Iw88vJdl6jGbz9Vd/7FBjPT?= =?utf-8?q?+56Py8H4CKaNxUSTyiNgYCbR/ZOW6Rf3rPOBOCe05iTSa6oUS6pOWGqNLcqQQe9R8?= =?utf-8?q?AbGxFPI/v9LdKqPqa1AJyBVIxeRgiZ03MoW7aLgS2V0UeH5xwNqwjIaAM4xE5T80P?= =?utf-8?q?R/w8gOdVusuVBt2zng+aaWtv8bULV6en6p57WsqzzOPbn0mz/dUAbAO+D7qOBcwLm?= =?utf-8?q?k78OCrvdVlkYyaN++m7WVMBLHUs+DNRPR10uVKDAR4E0SQrtll50sHOqkXYlupP1Y?= =?utf-8?q?yWSMl/K7F9c2h8NW4hpcTwrW5UVCIlk0SPcH8Vh8pUOx4ux00lkq878scqmYQh9W4?= =?utf-8?q?4HRG8l9tkPbSgGCH8igKx2XeBK4gsn4RrPGw7i+Tq7jEDoz+AerXSo8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Fx2kfAINsT7jdJ3fz9ovb6WP1VGA?= =?utf-8?q?h6sU9nsy3szm4b78BKtA3zFTORVm/0YZT7HcWnxybdUcqJyA2suoJRjCtpEaLxpxE?= =?utf-8?q?LYudjjifTIwa6Z1TLz1+s26lh4imB1RtM4cpp94TGnKDK+4+BZ/eoCWKukB0bPojt?= =?utf-8?q?3WuCVQc7QIapi3ykMNDcnUSJ+zCxkZLAX0cX2hoWX/9Z4zI75kUUGSSdqyF7Ft9ET?= =?utf-8?q?u9M0JW8Ms3Xlz20yJe0lfkU9OAEucg6hHAkOVdIuB+mCDXWnfwt2FkPHhSGtykLyM?= =?utf-8?q?jUMXvVbSCUYn0LO4sA1JCg8Z5kU9HREOm6u0g3ORLgVGZy0smcJsU6VEYnn+PtkW7?= =?utf-8?q?QKlegZSwGalweBLKk1JhAJa7CSkC9J2tU5Gg4jx1/vHuJ8ZrajzMlS2xz0qxbrR9E?= =?utf-8?q?Jdxp+tc8ySnUqRNln2BJ2QUeI0GDv+E2FtvgVKRyhIzjxOmUgHrrFnNTOxthLxei1?= =?utf-8?q?9da0X25Vt8+q6T7rltDfLFyWWsA/Il7PD5YdBqsj7KitCZ62f7xYxk+gisRo9c34J?= =?utf-8?q?0xeSg15Yyv9u4HzY6RwWbP9IxWtcF1WSMKAkuA/KTIgVskrV1nCcHM1do5J1SRM40?= =?utf-8?q?TptYOTg9/cwqmfotV/o8MO4eKgE0AR1lDmnGRg0cWcMQE/iY06BNsXwQ/R8cmgPHo?= =?utf-8?q?QPgd0GhXf55qRqx9DBQWapba4L/9L6pbCnYadutZJopfm+3ewZOrDo4ol3GpLnX6Y?= =?utf-8?q?Mxc6ZAZOLPCoRW01Q1zYBcss/p9TJLaF/DxZYwjvOWP+Ahj1tWpqEXXyb1ANr1DvZ?= =?utf-8?q?Nze4ipACtmcaBrQSXn8SBYt0NBFDLa5ZcPdupBdqonsyuvEqVWZZvU7hUeWKNLCJs?= =?utf-8?q?HhatsXmyLTWApfHUeUag+OpZEwDDJR2U2snMF0O/yGOzrr+ZatYUR8gi8W3C934/L?= =?utf-8?q?A7DxvpN5o54YYX0ema4k4KAMEtpNLKQLNHdqYV9XcymSLtGdsjTB4P2c9cPvibInx?= =?utf-8?q?RqGJ3uwI8sGCSzUMiH7wblWnThB4MEt4vZo8eYvpzlvjIJh/CERgfJLUE0xWlJgYc?= =?utf-8?q?VRO6KvD3EwdbBcaNVx04P+C+/uR1wy2ENF302l3JzZ2FGOd0Kn1wUuPtGrQyxP6bK?= =?utf-8?q?PFKb5pxXEgC5MyaK7BXhlolvypso+w2Q3otzeiqSZI2KG4FguTkU6n0FRrBZ/fb6R?= =?utf-8?q?WwnqQSXl95TgoHZksOjvQSTV8+Y300ZexA+6kAIYxPhSqlQ/yyUeP64IPkqFGjmjF?= =?utf-8?q?Jn/D9U2jM4f0kUGxRxdRClQinoaSDy5rNiJQkL8O75z4hb/y8kMlJqTc9tV81jBfW?= =?utf-8?q?8Qtv4yK/6xRf5rV6LMnI4UiPFs2nHaTGscxBjMpB+XFFOhwH9VW1hEnlzfhPcwcpL?= =?utf-8?q?vwaPmirejaHT0wY9OjvNekyMk0OexEln3ut3Ykji/cn02OyJOZhTROOa1eMhHU0nd?= =?utf-8?q?oQdbrvMI6mdvlTNIH3CL6nBVMjKTJLhq3l1bLkAqXEYxsCoAHR3qshE6p+Xshhacc?= =?utf-8?q?TvRHOmMMmChe2qMkwLpaMOy6bxNvVdyfr56hyFsHGYq7SX5SgxEFQ544KuSp+yfXt?= =?utf-8?q?ZVB7q8aTeQDZ?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e59cf302-1fd8-4f24-6375-08dd154d1344 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2024 16:51:33.9525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Phmuumb5fWrRD0RqXTm4P2Jqp/Lt7lf33XkOhW7btMTgVcAll681YXW83Ox4BYD2Pc290A7hF3Bm9fE/4tQROg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7511 Use dev_err_probe() to simplify code. Signed-off-by: Frank Li --- drivers/regulator/pca9450-regulator.c | 73 +++++++++++++---------------------- 1 file changed, 27 insertions(+), 46 deletions(-) diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c index caeeed433165c..0b1f099fdd5ee 100644 --- a/drivers/regulator/pca9450-regulator.c +++ b/drivers/regulator/pca9450-regulator.c @@ -932,25 +932,20 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) pca9450->regmap = devm_regmap_init_i2c(i2c, &pca9450_regmap_config); - if (IS_ERR(pca9450->regmap)) { - dev_err(&i2c->dev, "regmap initialization failed\n"); - return PTR_ERR(pca9450->regmap); - } + if (IS_ERR(pca9450->regmap)) + return dev_err_probe(&i2c->dev, PTR_ERR(pca9450->regmap), + "regmap initialization failed\n"); ret = regmap_read(pca9450->regmap, PCA9450_REG_DEV_ID, &device_id); - if (ret) { - dev_err(&i2c->dev, "Read device id error\n"); - return ret; - } + if (ret) + return dev_err_probe(&i2c->dev, ret, "Read device id error\n"); /* Check your board and dts for match the right pmic */ if (((device_id >> 4) != 0x1 && type == PCA9450_TYPE_PCA9450A) || ((device_id >> 4) != 0x3 && type == PCA9450_TYPE_PCA9450BC) || - ((device_id >> 4) != 0x9 && type == PCA9450_TYPE_PCA9451A)) { - dev_err(&i2c->dev, "Device id(%x) mismatched\n", - device_id >> 4); - return -EINVAL; - } + ((device_id >> 4) != 0x9 && type == PCA9450_TYPE_PCA9451A)) + return dev_err_probe(&i2c->dev, -EINVAL, + "Device id(%x) mismatched\n", device_id >> 4); for (i = 0; i < pca9450->rcnt; i++) { const struct regulator_desc *desc; @@ -964,13 +959,9 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) config.dev = pca9450->dev; rdev = devm_regulator_register(pca9450->dev, desc, &config); - if (IS_ERR(rdev)) { - ret = PTR_ERR(rdev); - dev_err(pca9450->dev, - "Failed to register regulator(%s): %d\n", - desc->name, ret); - return ret; - } + if (IS_ERR(rdev)) + return dev_err_probe(pca9450->dev, PTR_ERR(rdev), + "Failed to register regulator(%s)\n", desc->name); } if (pca9450->irq) { @@ -978,29 +969,24 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) pca9450_irq_handler, (IRQF_TRIGGER_FALLING | IRQF_ONESHOT), "pca9450-irq", pca9450); - if (ret != 0) { - dev_err(pca9450->dev, "Failed to request IRQ: %d\n", - pca9450->irq); - return ret; - } + if (ret != 0) + return dev_err_probe(pca9450->dev, ret, "Failed to request IRQ: %d\n", + pca9450->irq); + /* Unmask all interrupt except PWRON/WDOG/RSVD */ ret = regmap_update_bits(pca9450->regmap, PCA9450_REG_INT1_MSK, IRQ_VR_FLT1 | IRQ_VR_FLT2 | IRQ_LOWVSYS | IRQ_THERM_105 | IRQ_THERM_125, IRQ_PWRON | IRQ_WDOGB | IRQ_RSVD); - if (ret) { - dev_err(&i2c->dev, "Unmask irq error\n"); - return ret; - } + if (ret) + return dev_err_probe(&i2c->dev, ret, "Unmask irq error\n"); } /* Clear PRESET_EN bit in BUCK123_DVS to use DVS registers */ ret = regmap_clear_bits(pca9450->regmap, PCA9450_REG_BUCK123_DVS, BUCK123_PRESET_EN); - if (ret) { - dev_err(&i2c->dev, "Failed to clear PRESET_EN bit: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(&i2c->dev, ret, "Failed to clear PRESET_EN bit\n"); if (of_property_read_bool(i2c->dev.of_node, "nxp,wdog_b-warm-reset")) reset_ctrl = WDOG_B_CFG_WARM; @@ -1010,20 +996,16 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) /* Set reset behavior on assertion of WDOG_B signal */ ret = regmap_update_bits(pca9450->regmap, PCA9450_REG_RESET_CTRL, WDOG_B_CFG_MASK, reset_ctrl); - if (ret) { - dev_err(&i2c->dev, "Failed to set WDOG_B reset behavior\n"); - return ret; - } + if (ret) + return dev_err_probe(&i2c->dev, ret, "Failed to set WDOG_B reset behavior\n"); if (of_property_read_bool(i2c->dev.of_node, "nxp,i2c-lt-enable")) { /* Enable I2C Level Translator */ ret = regmap_update_bits(pca9450->regmap, PCA9450_REG_CONFIG2, I2C_LT_MASK, I2C_LT_ON_STANDBY_RUN); - if (ret) { - dev_err(&i2c->dev, - "Failed to enable I2C level translator\n"); - return ret; - } + if (ret) + return dev_err_probe(&i2c->dev, ret, + "Failed to enable I2C level translator\n"); } /* @@ -1033,10 +1015,9 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) */ pca9450->sd_vsel_gpio = gpiod_get_optional(pca9450->dev, "sd-vsel", GPIOD_OUT_HIGH); - if (IS_ERR(pca9450->sd_vsel_gpio)) { - dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n"); - return PTR_ERR(pca9450->sd_vsel_gpio); - } + if (IS_ERR(pca9450->sd_vsel_gpio)) + return dev_err_probe(&i2c->dev, PTR_ERR(pca9450->sd_vsel_gpio), + "Failed to get SD_VSEL GPIO\n"); dev_info(&i2c->dev, "%s probed.\n", type == PCA9450_TYPE_PCA9450A ? "pca9450a" : From patchwork Thu Dec 5 16:51:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13895791 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2075.outbound.protection.outlook.com [40.107.249.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F70A224B0A for ; Thu, 5 Dec 2024 16:51:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417503; cv=fail; b=AOawFMd4f8RUvoY95TIjseBG4bhjnikOys/B0Jy1WA8w9TuT3PAseNmn0lkPK/PyCTFF/mdMMEV09vs3wqnt/JMNGc9gGmQHCr4eIq6qQfBJPKyIotDmYBbGTjRpuRI4CXqVFjU+FgjpJOYeQJD8QFP5wMS6kIRfyUF6uw52mXA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417503; c=relaxed/simple; bh=LWpolkjMVGu0r7DvGNupncMS///BISprVKBCOfaLE40=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=G++CGUg6uT+6n7iHNvpQkpGASkJlgZbavltmJAbJuE7OTpS0HearIgX4AzVH8j7OmNnpYTzJlBLYdMku9GQsuVDoMFmoTpj5lIStePxGmQ18J4uDyinXZJNNWsiitrQPJQ7MmLqAj3Cq4D/+VXfal1gMNkH765gnRUkBIwVldxM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=RlX5q8e8; arc=fail smtp.client-ip=40.107.249.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="RlX5q8e8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KMW/Gi3HGt2DG2+6f9AwD3lrOMBGqkE13dWNvHSiydExkj7RGZieojhasZJKQ9ksgip7PcjF0Riq+szplw8SY+PYNaJcDJLu4mrBFmHbBIIgFxje9Au9chKY/XEH5PZWIRc96rhlO6FV1JlUbgKBp2/UynidvPc4x8UVGXsNATjSCq9OvYNF5PQecNugJZg1Uq8cW/mEpAIkx07Zr8S2dUbOzfA9IfV45sdkCGvOIOno83TgSMQN95K7uMgivuibetxdeBlErY8tfTaT+djuqDCs+Iri0sWqgTcXRNPoimaiHI9jQB1IIb/WQ4yhSidxyTXzOR4sK/8NIEmvvbnZ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Qv+G0aN0fxo+eJyWD7tRd65AwEwgzuXjj7y0WGiV5Y=; b=xwgSpt/v8D01cKdsRD2GPj7j+Hvjx6utX9kkXHc53LKJA8fsCMQEXI4jbjsLs0W9OQSV0jfLTNlGC1em6pHWmoXIioWbbyz7x5/bfrC/NnrsALtSSoE7sHctokmHEthHkXGd1pLdY5gbf9b/LR+xfg5avYjLv532XBgX/8g8/aNIxbJ7b0a82pdO1DQL3+5yL3bHRH7xxjZc4VuHiZrH4Y4R4eZHs6jXu80kOQR7gg4crPNTLtb+XS8G5g4o1SOexAPiqERPW5oRCx7XcSmaJ0ApjKH2dk5flkdQCkBBVuqXdn+onsRwRj4mv9VPIVZtAkf2oNVDXjAfSoFD4vRHvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Qv+G0aN0fxo+eJyWD7tRd65AwEwgzuXjj7y0WGiV5Y=; b=RlX5q8e8kue9QpWdfDmTjFCx58Z9sMs0L+hpuJHpH80k9BgqPTkv3UvJqPEgjJohcE2R6ICU6H6eK58eS1gg+jfGZvBwhkbo7qGjs5dc/OQyMYXGTTmkbbP28EePuZW0y9hp7tAX8buYcaNWBJTE/ZHSscZRNBgQngZGI5KojWUAzdSDn0EhVMpjOIDHWighAxhDjx3SBMT+CS4TUe5oXKPJJc7DUj8AWgXYbaG8unVgUgXbCW+LSDNN+4UdAirLLbKoR/IOTi2ZffFsHFHauRjZK60gcXD+oewQD7RShErOzOSso0fQYwQeQfbxj0c+YnSjJX4S5xS/++LM/DFG1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by DBAPR04MB7446.eurprd04.prod.outlook.com (2603:10a6:10:1aa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.12; Thu, 5 Dec 2024 16:51:38 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%4]) with mapi id 15.20.8230.010; Thu, 5 Dec 2024 16:51:38 +0000 From: Frank Li Date: Thu, 05 Dec 2024 11:51:11 -0500 Subject: [PATCH 3/5] regulator: dt-bindings: pca9450: Add pca9452 support Message-Id: <20241205-pca9450-v1-3-aab448b74e78@nxp.com> References: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> In-Reply-To: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin Gong , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, joy.zou@nxp.com, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1733417480; l=813; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=bEhg17FlqwWgEaGk85QiltrgdH1mfNZULFNEUwHv3ts=; b=gjUBT5yuu7VBCxchE1FH/tqzkGT6gmeQYB2uZl1u5WM0k4fP6aeMnxpqamwa61cA21FNVkF+L tAvtg8yQmb5AwkwKwRoEdeE8F+2Qefc4SibvWhedHVP0uCo5Q4NC06q X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR02CA0029.namprd02.prod.outlook.com (2603:10b6:a02:ee::42) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|DBAPR04MB7446:EE_ X-MS-Office365-Filtering-Correlation-Id: 220b1491-337c-4267-d898-08dd154d15e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|1800799024|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?B4TTSpWvU8NWt64OysV8toGwGy93hDO?= =?utf-8?q?3Dc5PR4OvWUPLJb5lzExd3uxDpewfBmug+bKmyK6fB3aV2OgAKPb8o8Ga1FgeNBqc?= =?utf-8?q?mLwdgMxiZpl1Hdr6K4uaJjGIkBhv+1+a1U8VY+HMdFjum1tKSiuR3pyEDR7HQYIa+?= =?utf-8?q?uSsgL/dZ7IKaooebmckoOoQjH+K+8dL5EAcqxFpAW2cI1YqOhW39sc5Bl3L4YZ0+y?= =?utf-8?q?5A1jB7lDYP6QFWMe9KCe33hRVOcfacsR7YZHKElNaU6MEtw0af+g+OlCQtADu+IEo?= =?utf-8?q?vqisKtnctxGsk2vBL/yrV7TnB+jhcKHcqFlvJ1NcPrEAkWy9eVx20bNEKuFp+Q8R8?= =?utf-8?q?eh2JboMURVvYwNtdHLbeKILu34aHHSB/YLmuautbNJc+bkO1ziL18FVyJMM/ZWMUy?= =?utf-8?q?4UTFb6KG8x+g8gPxSm7j51uOPYlKRbeDgU0dOPV+7PVtuilrUB/6q0d7elFtclwZM?= =?utf-8?q?aOdZfIWsRLyMXOUx5DinzbP1nNkzOYN734ghqE4FOuacOazWra8fgOWeNV7sOtw19?= =?utf-8?q?0s/Vz+aS2k1ZLpttRmzcn90ruqv0+YKv9MqChYITIY97vGhQWNSnQMuEh41ML9V07?= =?utf-8?q?yx46UlFaERfbX1mx2OxfNJodb/eqGqnVo+Nb6GpFXNIKZIqtY+VCrrJMkSBNyGKhT?= =?utf-8?q?bVc/+l8NVO1PnhMZfT1p8NKW+XHqZ5REevU2IS3obi/g4JchhadSwCKnKHK5iF14Y?= =?utf-8?q?QXj/VvLB+12v/gKI/mq3539bWVJv4SjIPdJR5DnOZDb0m6bwsDFd7DASp3C2TvjVQ?= =?utf-8?q?4SjrDdcnMSBCrhqmZ72uyuIFcsJah116HqKf/HlKBbH+OUWW9SHwqUdGbhD9RGwQl?= =?utf-8?q?qEaC7ywodG/vUdVQ4BUWJRdNMB+nGU4TYf1NcXBjqMr322ewjlrmmHWAqtBC3vzsT?= =?utf-8?q?4YvljwToJeRARgKR5PhqWj9hGJtUv/BvgvZCiGkLfz8mHl2bsIMHGnJhMWtKVjAap?= =?utf-8?q?EVtBN1nGrQeq1EVuohF4LnXnxqXkr7ISESk5GxWHC/Gan/J+8+bEPxecl/gBu1cSs?= =?utf-8?q?NrDFZeyNMcyidC39JZKUDJmQSuuMq48Yur63GI0Z9L7jSDNJD6HrReWv53Od/Kxlk?= =?utf-8?q?JVax1svD7z/xodhi3oUPY3oeVzcjz3aQ8vsJQ1AW/R5qoRUHmyAkkwNtlcso6kV8z?= =?utf-8?q?VzD6tS3HM5iZxWrAW7ZeSyZvVgGcKlFIoNUTW+lwQfUeUBrmK1DmhPXretRoHQ73O?= =?utf-8?q?UivhbE0ro/oguChjoVM2vRHIf2Rxyifi8WtTTs7Jr30TfAf72YuZtPYUfJ8PTTaL2?= =?utf-8?q?VLgKC99X+uddfPWNv5aZ7ojb4cVkUk7t12gpfkZXY364dUZd0rJCAh0rid65jbf9p?= =?utf-8?q?Th2c6A59fERe58tIha0QqamhcR4GWn8qVYXDde0pOy7K90YYq55u2mQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(1800799024)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?fvAPNJZjmrGTKLC11TI8HsflU+1i?= =?utf-8?q?Q6cVM3TpdH/nAhGuzhVZKFuBM4LtRaiRsHbjPlChfX5WdxNTyD2XI6pHK0xDWELD2?= =?utf-8?q?uIO6GY4pEXp3SVwIe4EV7ixoJDlPio8XitN/eN9KXlOy4Jv30b7vwiOMuvE4HHJIb?= =?utf-8?q?IWw7SfbvR/y1v/vYds8+CJBLAzr9Nrzru+icHBTyWfWIZJXbNmMbIWS90yEPNsNTA?= =?utf-8?q?bGQFrWRYbJxYrCZ0fXMqsH7PP//cJKy3Yh9djufTcEFE94YXBcwQXINebXpuA5OGu?= =?utf-8?q?rLXvB7ZW2DJfTYEw3dNN5vyIYCm761yRpE+2uuVeTZKAl/6jGzEQYl9Yhi6038zq1?= =?utf-8?q?DyeKBMfeISOICgO/VSPHD8y3HIWBJ8lW/RdmjSqyjiZnetiBNqFnxV2JPvLtpegDY?= =?utf-8?q?zShwf5Qh9azKBuCDs7eLgliEOmvcRaAlvL/FISldvENtm7sO1b049tStroADS98FL?= =?utf-8?q?djA+fzwiRcg0e+aLDyQIcgCwyt0qAWKIwwiC78Wd98zyieCt11RhpUI7NnB3t+tl3?= =?utf-8?q?LWKQdjhjDF6f9v6GqzqPnfKLHvx5VManCzTFN7JLUgIH9wanLCmfsF3GW6cq0CqMq?= =?utf-8?q?YSRlrGpSJ7p3AgEMxwR5xoBzU5NOAgF+Siqyo+8yVv7crAOKRH1T98AnEq6iakovE?= =?utf-8?q?QN7mTijet1aTkpQyjUwxB+23fM5lqf2X499MxWMOuwfe9b+G6IYeRB0ACvyWV6R/e?= =?utf-8?q?pLsUSFBTFgzStg8jLbKY5VuOZlSfkuUnHHnYckVE+cVRr1ij6H8SLS2XV/Tabo6IA?= =?utf-8?q?cPhM19UEqouhXGtKWPjx2USnV/kAhZs1rs9V36BqY3EHaKphjtxYU50iHnwrPxCT2?= =?utf-8?q?0uuOVpY8DCvXMToUqwG6iTxfWYZgRP8YY85qgjdF323Oii/BomC4vDJWH2kWQDtm4?= =?utf-8?q?BAUadC6ZNOMouQHgPWdzytgv+kF5dcUN9Aww4FDZJk2f8kB5eN5N8Rk/n9OXKzquH?= =?utf-8?q?U5du9iO2BwTiA7Y7DQ9lsyiwYxW5eRdCbl8R4uy5B7md8cJI7AoRFDV+Sz0Sf2Mwn?= =?utf-8?q?Q9ZEG7GV1XTBWOUFOlzjr3cIGIx5AP54HGfQnbu2Vv6WM03sX8JI6bJKIsOJAdFjs?= =?utf-8?q?codwnF3dTPMmu7trlq0S8fGbyJ4bZBx80l1WdCPAaPqA05gRKYHuXCgyrPlq7fGcT?= =?utf-8?q?EbO7GsPc/n7m5IT4Jni+w/KXCyO54+xnKAjz/L273ISrwcK6FcR0PUsegGAdkhMxa?= =?utf-8?q?s+xEyFX2IRWreEh7k89KJxFcB27fT0APWGUDCGfsJQFvLzSNOXAQuIjfOd+AeivrP?= =?utf-8?q?BP/EP3nqZ+eaFpjadAqqOvg9wnoc2Xfm+KKsuMPTpFs15QaW+WsMU/JYN8OS94bP4?= =?utf-8?q?luG/uDs2883s4rpT4OfXognByJ8KccTc+R6ub7Od7kkLdSqFZm2gN4oGQnR8qclxo?= =?utf-8?q?Aj3Hc8u1JrOxqC1+R5KZ0Olv2yqksswtaG5MxUqetCstYFpSmWFKvW7XXCyYk3Rqb?= =?utf-8?q?+cEn1jMnQ8IWYIAxFntEgzIH31JJ8Ov1YVNeRSZU1Z1pnynghG92jKhBDDnAnWX+X?= =?utf-8?q?EvX8W0KqcSmg?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 220b1491-337c-4267-d898-08dd154d15e7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2024 16:51:38.3759 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N1bfj9wFK2BcXfoxUpj9OIzKOPoLom/yCOn0OBQ8f7sonKhfoQreMrzLH2s7gLODAeVfWRYsumZRZ/y6k8p4/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7446 From: Joy Zou Add compatible string 'nxp,pca9452'. pca9452 add 'ldo3' compared with pca9451a. Signed-off-by: Joy Zou Signed-off-by: Frank Li Acked-by: Conor Dooley --- Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml index f8057bba747a5..68709a7dc43f1 100644 --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml @@ -29,6 +29,7 @@ properties: - nxp,pca9450b - nxp,pca9450c - nxp,pca9451a + - nxp,pca9452 reg: maxItems: 1 From patchwork Thu Dec 5 16:51:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13895792 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2055.outbound.protection.outlook.com [40.107.241.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95F62227B90 for ; Thu, 5 Dec 2024 16:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417509; cv=fail; b=TSje3yYqZXwPWR1Xj5h9R0lvOTyhCbJ1gmnI+xHoL1nfA3vgoPwua71j41wfxSBVNw2r/QHYfMU2Jwxx/Fr50f0xUob7TlZq0BFnouQ4eSzFyfR1y5vH7GbWG8aZfMeXnmnlKK4iLYEGE6tcAkA8+oqpHEagMy3XSoRLylnPMWs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417509; c=relaxed/simple; bh=A6EGTfjYKIlj3aLC4u90rwGEbg95UGx6KHV3w/eCA1U=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=D/B0OLAx+pp6wCsHDvgI8jyC6LS5GHQnLK2CnWTS8BkHAPA365dfMjsL5/DtKgEqieYN0hor4cHST82BKXvRtW+DF131YFcFFUu+WP7ONcjAfjuIg8Ub990VqcEMppl0WZM/gK79uKiu42uIM0myS+xtyQBoVk/hOb8nX6eo4fQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=JFXqK96s; arc=fail smtp.client-ip=40.107.241.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="JFXqK96s" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Pey/FepVroH0o30gxNagJ4BMrh2slsCQKoaNPOrfcgwi6kBPXlPTFVwv/j7zTPS/+y57xQyhAYrIPyVB2KEzfEdZC/98acf67gSKuZAjT21Ilawi3ymI1QgUIOodqfkzcxtcl1WvYBXC1xGQAFmBHhCqi7tAKaYuE2RG9VPaVsn+k1377/Fr+ilSxymr1idB4rkZGiRWGeUNu/c/mlTldwCsBYwtovLpvySRB6fam8Ci0pClO4KZYyxH0z9O532g5sGVM4LMHvgwSBu+IiLS/nP16b+8WRDBTZruscfHImAWuLBZtkBopi/MjVo6Q9PdKgTxSW9WD3Zm6cObH9KJhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9iOsC7M6f/+sDyrSnuCZDi4tzufpgAqP+k9gXU0kg3g=; b=mojQsTgLttfRqBELrpXGUWDl4hIIhDx1lZ40SY4GtvYiQ7lB1vnLwCNXnNM6sUNRMYfoaqs/9FNObYScEoBtGNDsZJPDhODSS807a8yWGruVMus/PBPnLCSPhtgzQJDos655lN/qxrw3raN7Xhd/fBr1UKv1KpKnntxQ+fiukm7nohJz+nzwscPmXYG4LhA5I9TM5FZVTZsvRL3oVfeRLcitdg8PLvlZHh6MDV1U05H6W5eBdxQTlEjEoW/Xi+Hsb6odGaE1TaF97jx7zsB8FtbmyzjdjiO4y7eA3IXtgP41qGK51nKQ+gdW0WUs3+7L9u3B6XPSh92Cc/tmvoSuqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9iOsC7M6f/+sDyrSnuCZDi4tzufpgAqP+k9gXU0kg3g=; b=JFXqK96sDADyltipA4j/g70ZWHrI1/gM59Tv7wbdwbvNN4PAPth3QuScfiu/vffe/dyaGTaQ7bbkBXv2m7tGGzn3hmKYGcRL3O9x/w91VnhBDxcOVEASnKpzMMguYOBbUD6DOdVF02zluXcMGxBlhEtDVkzulyb+rKqAU9tcVAkhwfm189I1YYcxt8s/1Zcy1FrrkIrZ3GZ9d3diy7tepaviWNHUHbrEHXamJ1N7KFuoSjs7aQuD6+2SlP+5qH3pu/Vm+blSp6cfGRrPrm+DmrZ3TGtCrjzWgzzhw8mmyKMQbFfjdzL5iZMPrTnsho5uEmrgwoLJBmnGV17lPoo5kQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by DBAPR04MB7446.eurprd04.prod.outlook.com (2603:10a6:10:1aa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.12; Thu, 5 Dec 2024 16:51:44 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%4]) with mapi id 15.20.8230.010; Thu, 5 Dec 2024 16:51:43 +0000 From: Frank Li Date: Thu, 05 Dec 2024 11:51:12 -0500 Subject: [PATCH 4/5] regulator: pca9450: Add PMIC pca9452 support Message-Id: <20241205-pca9450-v1-4-aab448b74e78@nxp.com> References: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> In-Reply-To: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin Gong , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, joy.zou@nxp.com, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1733417480; l=3178; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=YhFm3p5cBgT6Des25s41MlZZ8qNGl5iYh7kvogdCttY=; b=8oYM0LYk8ORGCJI5h+oKgyIGzWgqX6Eu41kI3ln2PepM11O9RPorP2B6SmZb8CuqDvA/bunzO z+qlisrKLDoCUS5ZROrR55fvI7F8KdX8vBE7ahrC1IBYrcCFLFyShpd X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR02CA0029.namprd02.prod.outlook.com (2603:10b6:a02:ee::42) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|DBAPR04MB7446:EE_ X-MS-Office365-Filtering-Correlation-Id: 85d9e0d1-b387-4c24-5fb8-08dd154d18cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|1800799024|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?X4KEtf87CDqBf0MvvuK/os1j9GnpChd?= =?utf-8?q?WpZtoX/so2n0oDHnlrIuyCCoBhXeT00+etQSmmTZmsWd2+HuoC+3OtCGCnOoBfM29?= =?utf-8?q?8UqaxwjPHwsm3+49zv1ynWx2CdPwNphVjSeyMJwNeUquKa+/LPWyDXL5Lko9ZksV0?= =?utf-8?q?eXhQerI9z5uzHjm8or+ZG+cwGjNaJGF0xAQkTEZ/B5gzsBvv7i1ZvAvYtcmkNIyxr?= =?utf-8?q?rlze1K9lPV5DxdXGmF/0tnMPupBznkONCtyKLVuMpO565GzzoDc2TbQNQEJ/D9EGn?= =?utf-8?q?BRQ4U3ZdC9o1xrU4EAOilH1i65gDURxBQBiGglunzYZLAU4weLQM4WqbynqMNc3c4?= =?utf-8?q?7xSRVBaBm25rlOQXvLTuprCxF3AbzCXh7TLHHoksr5AaQt+PQivhNK0UNacLqNzJ3?= =?utf-8?q?2eI4ITY25QbZFtQ/oNnp0Yqg6OCdz44s15f5pDWtLMI+TygViTRDDKhnKBEqTaYlU?= =?utf-8?q?up4FeTY/8x2QbJkEmIv3BmgDq5FVxjQYTWnRurm0hYID0ZLP7KRDrfgceyYwpYICZ?= =?utf-8?q?YK2L5Eo6w95VR7+hZ0IicLySlf3Vmwu0lrqpn9OXZ4F4dqHSTss4Exefo5TSnZ5W5?= =?utf-8?q?V8wAox6owbaZ7B93e/Ni/XQCVVVZTkVkmG3/j5goz+7oL/M5VSCBnf10pm8GCjjHY?= =?utf-8?q?tY2L3pX2B87M60SnF2YGH/2ykH8xm1138edAIpfMv1xXmUtxmSP0UMPSzua9I+MuB?= =?utf-8?q?Filt1yluYa6tLiSlx33FvaQ2kIxyc4QDaJ8+CX761GggWAOQopexmq1kfKjmCEMC9?= =?utf-8?q?TyhmuskREFLJslkljn76At7Pg0x6TugtGHsV9yC4rKNf89fvxTyb/ZTCArWnsv5v9?= =?utf-8?q?F565F0zn7juItPvM1jPhTLFP78qK8BVDqNWpsnMWL3XFlg+9ED7SmE/6j1MXDdsbl?= =?utf-8?q?1gJk4htgNoCMDFLkcXIeb1wOnEcxgGSu/5y51s25dOOmtBijJMhbF6tPPja01tH2C?= =?utf-8?q?nDs8Jl/gdMd4YmKFb46mW3DEmJJ2O/ErN9VS/VJJVZzZaRMKdh6lZiM50QCBgfkIX?= =?utf-8?q?FW8MNdn/aNVO3Alcu97X8MzljrHfAZrhdve4JqQkef5ek/mGQRyVLKmCFyXkSeOSD?= =?utf-8?q?vC3TCWZQIp3o3KJ/3JQ38rjtaw0EaWTF5ysbkgVokAkOrQH+QYKWG9zHyRzO3znXj?= =?utf-8?q?ehrIs4OqmAAqfwWI/Qv+d1LKbVPE3NhyjpTOa4V8QAEi9XYEXfPObhSsxAdxvjqkh?= =?utf-8?q?3KJbT+kea0Epg3DsdsP3+jA7Szvc8vg2N8wSFEjYzB/PKnCH3LrfmEj8x44XM9pFW?= =?utf-8?q?QY1mEZgji99/7sVTXjP92bDB96nQ0UaJChl/LpWbqYgwFzid2HIa6q/9lCOHRDrMf?= =?utf-8?q?XhOQINqGxmK8odYPpnyqdxFj71SGfqdoUvBoTIuqTBCLMM68OQqhEk4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(1800799024)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?5KX6MljCZWFPNCtabUAOC3CGgiLe?= =?utf-8?q?ELDI+vITqqMk3SUSdSX8yOtEj8wSfp/3X80w5NV4W7wO+tzrs/xfmql5FXxc1+Qh0?= =?utf-8?q?IQOLiNPSkItmL5F/PLEw97JfbFaTPPfqld73HOOYp5nz6Hp4Ey3nNfryh4EY0Zhoj?= =?utf-8?q?cCite51kpwmS1ruKHVZgNRW7MZDzS8JUO2ZGCgQeSgq5gXZhKbKF4eJQ9ONuXFIqb?= =?utf-8?q?2ga7gPRNpIiyCqIpGY5I9ZKfGvu30F106HIZIumh/aphjuImYgdWl1887JIm66Se5?= =?utf-8?q?V5uwUocmTDlGGDl9mj/cxhJBrKA5JCIOMafw/VFGM/4EkCwSaavplgLGw/PQDeaol?= =?utf-8?q?y44Ei/ekm+zesh95p8wstQRA1d4t3OZKwlg8oFe3Sj4bkDXU6iOXxgnt9M5j0le5e?= =?utf-8?q?KiiGwoab6Ky8W7rCYtLmkFVv4oqD1ahHD4sR/KzroirlVqq9/WR8LRwPXl1VboDos?= =?utf-8?q?WBOgcA4c80XQQPQn6yJ3EELgYWStf01tBmDhdc4pF9H753ZCjrA951YhHtOnCK8qC?= =?utf-8?q?a3JrLuYmhvNoeRuQvzB0G6tIfKhoV/j1CgK/YWMFid7IdwJT465Ev+4AQhjAV3RJW?= =?utf-8?q?AqGUpbDGU2lFuce2/LVqeCZJdhNwEOVBCIi3fcMowk/o7IGajKGDH6gYPCnz3bJm/?= =?utf-8?q?pfhKCrbKx0FFrCsalvvsOReXoXCCtLu9FTI2pyvAypO6UF3yIj022btONiPdxXmRn?= =?utf-8?q?W6yzxR8RVhFpv2rDt2sHMtI4Hd8A0qAv6zrA7DN9ai2hteqpUSwjOs5WyrEdsqovR?= =?utf-8?q?yIfrBN0usWKhlgmag18D/YEMnD8PRrsAQWXVMT6ny1CQRb3uxaXbRkpo6II+KtKZn?= =?utf-8?q?NaBFEtZK4atikSLTVuZl+Li6GuUEhPmuIzvhhTgxhXigzOZqHdN2xQAtqkdJgOz+r?= =?utf-8?q?PWBWg4iGSLSoQydbfEuUp+nqJH/fj6vtYrRZvZoUPftJPclJGcykYCMYWKfKmX0uB?= =?utf-8?q?kxf+OkXeViwhzRZjJSgVy3sc4iKitAEYHT6Di7crr/11ZX9Fb1Jsr1IK0uJvwXaUp?= =?utf-8?q?9cXtYmIpZrBvfF3GkkizJqMHssk4V9ieNetHSk37E5uGVayhq+KITnEraYGr/+C+k?= =?utf-8?q?C2x7xNWU/b5Y6b7r7F0KmHcWzd2+F7rUESDsdk1Fh68GfRqw7lSt5wYy8Fmjus974?= =?utf-8?q?sP6rwxoa8PK3HTTD2JNL27pkP0nSDmCQYFLT/SwQ3envxJ51Oeij3OXJotRC7REWW?= =?utf-8?q?TxcRGm2kdiaUTiGujZv/6HSAAj6UDy/+hmAqvvSyjQm8pElGdIUWjV3qJsmcB2PWc?= =?utf-8?q?R9yvxH2I/NcEcYfH6biT6YZ/1QWsC0BOIQf6452t1zLJpovLcWoBjnuwHw6UPPwXy?= =?utf-8?q?VNOqnRhopEvwG8C3Rf8ScrvKIIHhcrj0TDVffK5WLNt9z3XdcL4V25pa6/k111RND?= =?utf-8?q?MZbfDuFh9962DVzqokN2WWjusmzMyVUdSV6mJG7QdKKSL2z7QVQIVYiELANbNlGz1?= =?utf-8?q?DRcdD8n8P6rqDXCAcCFCHKmWE3O8RMxHuhXUne5Af5ZIS3HGWE19lfIYMc7+mEboi?= =?utf-8?q?4O42atOBqdso?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85d9e0d1-b387-4c24-5fb8-08dd154d18cc X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2024 16:51:43.2223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zcwiqlSE7AZLSb5hvFX2wVcq4/aTbxeGPt0Knbqp1Exl/YIp7BPMhZlaJe5p4iP2QDqvjY2Egj3+XsdF8wvtqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7446 From: Joy Zou Add the PMIC pca9452 support, which add ldo3 compared with pca9451a. Signed-off-by: Joy Zou Signed-off-by: Frank Li --- drivers/regulator/pca9450-regulator.c | 29 ++++++++++++++++++++++++++++- include/linux/regulator/pca9450.h | 1 + 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c index 0b1f099fdd5ee..faa6b79c27d75 100644 --- a/drivers/regulator/pca9450-regulator.c +++ b/drivers/regulator/pca9450-regulator.c @@ -815,6 +815,24 @@ static const struct pca9450_regulator_desc pca9451a_regulators[] = { .owner = THIS_MODULE, }, }, + { + .desc = { + .name = "ldo3", + .of_match = of_match_ptr("LDO3"), + .regulators_node = of_match_ptr("regulators"), + .id = PCA9450_LDO3, + .ops = &pca9450_ldo_regulator_ops, + .type = REGULATOR_VOLTAGE, + .n_voltages = PCA9450_LDO3_VOLTAGE_NUM, + .linear_ranges = pca9450_ldo34_volts, + .n_linear_ranges = ARRAY_SIZE(pca9450_ldo34_volts), + .vsel_reg = PCA9450_REG_LDO3CTRL, + .vsel_mask = LDO3OUT_MASK, + .enable_reg = PCA9450_REG_LDO3CTRL, + .enable_mask = LDO3_EN_MASK, + .owner = THIS_MODULE, + }, + }, { .desc = { .name = "ldo4", @@ -916,6 +934,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) pca9450->rcnt = ARRAY_SIZE(pca9450bc_regulators); break; case PCA9450_TYPE_PCA9451A: + case PCA9450_TYPE_PCA9452: regulator_desc = pca9451a_regulators; pca9450->rcnt = ARRAY_SIZE(pca9451a_regulators); break; @@ -943,7 +962,8 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) /* Check your board and dts for match the right pmic */ if (((device_id >> 4) != 0x1 && type == PCA9450_TYPE_PCA9450A) || ((device_id >> 4) != 0x3 && type == PCA9450_TYPE_PCA9450BC) || - ((device_id >> 4) != 0x9 && type == PCA9450_TYPE_PCA9451A)) + ((device_id >> 4) != 0x9 && type == PCA9450_TYPE_PCA9451A) || + ((device_id >> 4) != 0x9 && type == PCA9450_TYPE_PCA9452)) return dev_err_probe(&i2c->dev, -EINVAL, "Device id(%x) mismatched\n", device_id >> 4); @@ -955,6 +975,9 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) r = ®ulator_desc[i]; desc = &r->desc; + if (type == PCA9450_TYPE_PCA9451A && !strcmp(desc->name, "ldo3")) + continue; + config.regmap = pca9450->regmap; config.dev = pca9450->dev; @@ -1043,6 +1066,10 @@ static const struct of_device_id pca9450_of_match[] = { .compatible = "nxp,pca9451a", .data = (void *)PCA9450_TYPE_PCA9451A, }, + { + .compatible = "nxp,pca9452", + .data = (void *)PCA9450_TYPE_PCA9452, + }, { } }; MODULE_DEVICE_TABLE(of, pca9450_of_match); diff --git a/include/linux/regulator/pca9450.h b/include/linux/regulator/pca9450.h index 243633c8dceb3..b427b5873de1a 100644 --- a/include/linux/regulator/pca9450.h +++ b/include/linux/regulator/pca9450.h @@ -10,6 +10,7 @@ enum pca9450_chip_type { PCA9450_TYPE_PCA9450A = 0, PCA9450_TYPE_PCA9450BC, PCA9450_TYPE_PCA9451A, + PCA9450_TYPE_PCA9452, PCA9450_TYPE_AMOUNT, }; From patchwork Thu Dec 5 16:51:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13895793 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2055.outbound.protection.outlook.com [40.107.241.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA5A6227BA6 for ; Thu, 5 Dec 2024 16:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417511; cv=fail; b=D6ftQPdOopPanTXh7BYnQqu5a+CZVRvsxcnmz078f0I5Nu2kj9bHNDKbrHzCpLH+yvXLz2GccAOcH9rtndrVyOHokR+Yw3SHDEQsjSBgB1/JUx8dSrMOhtTX/1wjj44nVmitkrOC1JaLeaGUUTdTcnwdPwVRGoCKWjRRy0P9qoY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417511; c=relaxed/simple; bh=mGGN37OWp+aduPI+3e4Y8ziQnmTHSWKE6eHA1Bzp21U=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=sGY0QpHfRiziN8zp1+m/LRTG2mJuKgetJf68Iox0Zb7HKs2QbFAuSrdHpo/HnnCf2ppV6A2y1ZSI4BCf+Yr1B8sIZo+B43eZjZ+cSf4QEmqIbUAEA46NLFAXRdmonnneJpSuFEEptzGbhbCzneeLF/lKQRo2FGcKJ3r7seIRCbQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=BDCxse5b; arc=fail smtp.client-ip=40.107.241.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="BDCxse5b" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gB8xNoytgnCJcEJc2OyYYKvmtPLuV/1OqP/RBtetemAhHUzlNiBYdJiJ+iqKOoQMCtiECTF2SupKfIy4zUyzJZUeLl61Z7lFXar7KTGJJ+/AQyO6jHt+K+yf20wuCYDmufgqb4iEuuU3yTBIqw8Z0TXj75cA9NU06S5g9/EpJhUQzvMhq2k1FZveMmKa5kbpT3jzeC+L+NyR5KKfPHs1IZEXzFP/lvlY+lZlbSQC6kbljmIih+D5BCB21tyjNVHuxNW++FMktexs/Qe56RvCyWuTuFQART+Q79DSV6YQWOXttDb3TtDMjBWmgV5RbSRMRXzWsDREvSg7ljCJndgGIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oy0HT+FTy7m40dkT7/0R42A2NWHtIKcoyDetvr0QoP4=; b=Ue3sEXGDlb1nP7ZtO4KfCmqU4qBwKXwSVwuOnU9hJcZ5w8bnFNa/IRxJHEeKkKSqEzPO3VX6KAgI0jWk2Gdk4uLkF2PrF++6vtrZgykBEQo3jYB6BHhNbjzy0/JTPwNYFMWefw5pTsc1kgMdD+u0lvPvkeaH/9ZOK2F1k7cLnmq13OArNI0uWmuA5WCirX/kbliKrR3IXwENS2YMVMHqPZZAKwI+MPrdI1AlqN7AyN1S5+PjU4q/uAELgpjPvLAkV/vtfPQrRydUeh7Hxoq7YqGF9tzSPFMjV4R3bmxMg/hKgCdGOP/KDO962PfJ18tMvlSjBM17Gu1F1H8YroEUAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oy0HT+FTy7m40dkT7/0R42A2NWHtIKcoyDetvr0QoP4=; b=BDCxse5bnkXizwlsaffaoKritnP4SdG2n9YGcrxadDWXGVEKs98C28djetJRZPdbOYJSXV1va58jm45bpoq13gRLUnMCjkxC3OGB5+qxvgjvXK7aZQHQEp8xbtf4GaNb7wKRqkhmQVP3xNX8p2EmLPq9DYV+fgPMtypfGr0Ts6dME1E4TPZhfaHl5cmD4v2FJeBOVBUQ2N9A5XjLeAnWSodJFuq0oI/Wze+z0QpnnRedS3Fh8xjjH2ArSD8iP1IEW9dFiMhBaXQmODakcMI9f5l9RjBqhK9LIswd/y6m4o2h9gHsqRsxn8v+z1wfu2Xq2qQvCLyh5YqDTThSgKLAPg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by DBAPR04MB7446.eurprd04.prod.outlook.com (2603:10a6:10:1aa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.12; Thu, 5 Dec 2024 16:51:47 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%4]) with mapi id 15.20.8230.010; Thu, 5 Dec 2024 16:51:47 +0000 From: Frank Li Date: Thu, 05 Dec 2024 11:51:13 -0500 Subject: [PATCH 5/5] arm64: dts: imx93: add pca9452 support Message-Id: <20241205-pca9450-v1-5-aab448b74e78@nxp.com> References: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> In-Reply-To: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin Gong , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, joy.zou@nxp.com, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1733417480; l=2719; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=ByZmZVMFQefEgEbYLBGLsWjBEQTR+hvttxmsOxhU1a8=; b=6o3DE36F1ZRWFqj5Ixp7eqKhrNzHnu5dazVfAJSFPDbPPz2V2YRKRSsHPS5oFcHLK8IOc36vm eKExD5fL48HB9Vn2POYlNGs+fNREdWkF8eUasBgtYMKX8RLxafOcu6a X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR02CA0029.namprd02.prod.outlook.com (2603:10b6:a02:ee::42) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|DBAPR04MB7446:EE_ X-MS-Office365-Filtering-Correlation-Id: d131d831-caab-495e-5e23-08dd154d1b71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|1800799024|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?68IpgOkl5XJO3dqnFyIQ0j1sOIlebmx?= =?utf-8?q?NKA/C3jEF7h4Jx8+8Nk2ov5yv1l0ItMbAAML6+lUz8YgzoNDlQB190cEayKzRUKU0?= =?utf-8?q?XAY6Pn+OjtRsZVVLy6uztbZ0VxP/O3qLV4m1Txm+ISBlRarNgVGzEqgSyF5X+Cn1O?= =?utf-8?q?y4WaD7l2smrLLukJRcHzI/WjEg9Rh/MGc1NTo6IiYC9P60WjCyrytT2GrV+myM4cA?= =?utf-8?q?+8Wd+Fnzb48kdSDswL3W7Ignl/BY9SvKT5Y/O2zIWklTPGUz2zl4LBtemyLnCXuZd?= =?utf-8?q?xw/JOSRJm2y7ebOPLTx719wOWdvAaYUllLlExUXDHuVAcQbMko/NWYQwxmwBKRH2m?= =?utf-8?q?8TZEac3LvxpxnPdPMzp3lHQhNGvS3ccxZMQ2zQd3+Eu+Nebw3bfsUDXTR9cMLB+Xy?= =?utf-8?q?Ly4RMQ7Z6wyqSsaYrghGflBCVnjOaZV/KnVk0TCV//AkPgfNFkb6LNeWO4tfGiKcJ?= =?utf-8?q?ceXyeFIdsiaFHpDHgXMDYoR2MLaD0Zk08upCHMn5Yc74vSANPnIwOjgqSM3+n//rZ?= =?utf-8?q?EDXJiRFGfUAh5IATvttUDf81dcPR6XDfHloSXATtlJh7vyRB3CTFn63RF5dBnqD5t?= =?utf-8?q?2jZlYCWkaCWjfm+Nqnc+QnpOP9WR+GOZuZQ9Fd2mAWcheSkobj9iQtsxjsjbVSdv1?= =?utf-8?q?R93qj+BDPlHoSWnp9RjSTmCBImOLGXDuwurciUyjzSIXzB7lPfqu6hEVsRvrTlKo1?= =?utf-8?q?UBhlWqlzOVS8jqb052ZJ/TMQaFPnxA7YHFhQBhLtKNCfaaJu6wAdexmoWxEZktuiI?= =?utf-8?q?pLIEVDz3+7mGyrETxEhGrSkgB5yuLi7TzdWlU8FbQE1q2l+Hd7jhHerjyk6+Jt+3s?= =?utf-8?q?iMEc1cjmpr0odswknW8JTZ1LS3DpnmrVfATvZHYc3RBN/CZ/UbTt52E71JLjORbaT?= =?utf-8?q?yljgo8phIw/pEvHrstdzjXmkuji3krGShz6+Nu6ADEBkXu6qIBblVKt96pWXw6b0p?= =?utf-8?q?nqbqp/0eD3FlbudhQT5YbzuBPZKiTe6K/meXCUbKbClQP9tOHVMDK/5PO4WfH3xT9?= =?utf-8?q?if/gMoNf8ckLZweyDxCDF8awLQO9oXwuB/opmsmlj3H7wFpCVlhkEFiwA0+ZedT/N?= =?utf-8?q?6rnp93Z5bNilq6Fz8pus8k0dkUXTHeBCgksyaAm9caVgHtLL20BzGEL7CVSY6Kbf/?= =?utf-8?q?vndjppIGWgz7Wga1zkd5ojD6sMaUG7mdKbaYMj485/28OM9mJ+ovEwAXU/oMM2NTC?= =?utf-8?q?rr/Hg/NdOoR4IagmpRe1P2X93K/Uz7Hhs5zF4TXgVTOa8CjIsbv4CRCFQDFQI4QPU?= =?utf-8?q?67NUlpRuMwnnwWc6NSMKlYDPc/bBPeIlIv4y47b1+APOwRribrg7n0bj9Njd/TPDv?= =?utf-8?q?QYiiaziamb0G7QeoRvE7UHrA5NRUXSWlDmoXsBdSPtaS41rqeudnBNs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(1800799024)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6cnF3YOKdQHD34MZ1yUxbHmSXTEE?= =?utf-8?q?l07h4ZSZ6YjR8EUZyVocfXSF2tWqdJYyw26tYcYR1nIzW6c6cO5RSjfZcZ4pbS8Fl?= =?utf-8?q?b2oo3enBY3pk6lNsj6Kmqfj+W04agG6EyivzwqB7n+VZ+EE3oLxF3UCNGS96irzHp?= =?utf-8?q?UBi9/Olu9IfH56r5UgwlYpAHqBosUHq04XWyWroo1369LqneEnuJxCerNXudI3DTq?= =?utf-8?q?6v2tRbRK7IyPbu1vmcX4+mPuANtxL0SE4/6TDAE+Zc7FlURo0eUjw3SYNPymi7qLd?= =?utf-8?q?dadaWfWoxtfs4zRFzoQ5X3LzKneBjQih3M29HMGIWpihZA4Y7eeM+V0KeXXf7eY52?= =?utf-8?q?g/T2OQYeqd0vWPfDHlYDyz5tt59jFG6zBcijnqwCKpuzBe/xotAk88EvXpHAUk3w7?= =?utf-8?q?gPguDpYccV/XVoYKKPHmFSw+8clrv8c3WEdY4ka5ju315Qp+5AbW+HElnnfUpfXQL?= =?utf-8?q?S8rxQ83J5dsyeNrr416PiZcgdS2X0718T4M9abyd1CxpkxXAMgCalu7wbEErZcjp6?= =?utf-8?q?EbI+5YApFvjoJPH9PVmUQq2dXyaXz7G1STbtdJ2l9IHP2uteOoWb/46NoiGHnFlPG?= =?utf-8?q?y0pxaBKSFAfMj9p2w0d1LyAZQQow8/BYeEWdmSq3NXZRE5DOpdgzsfcDOIFWVwUkO?= =?utf-8?q?0Fbm62LOp2QT81+CqiO8IelSSKXTsEY/iMym4jlUatDk34x0gV8d4QhOzZJ+nwlhI?= =?utf-8?q?WS/XgkgukJp6dZz562QZPXeOjirDBvQb1xchP7zlKhZJfb26UGyO1QkC3ZRH8TXw8?= =?utf-8?q?5jAK/BZ3kwNO1D2dZZ8+XBVCk9wUzMblu0eZBZoGLRRVuRNdHn+Ja/+ZXZYD/o4/b?= =?utf-8?q?nEarZmkbTxr7ufAn00LhLx7gVud5OdvMh5yT6n2v3R1/imfPuqMftrS0iSCkM0ttG?= =?utf-8?q?Ozqs9MBHk2PG6NNR7yGNgKtvpaM6BJkx/rz+AuzUKz0NNhUV5kLTIKoxINWPVmrKZ?= =?utf-8?q?CMWINaNLdyKBhNrv3hJvYpK4ZqsjHJ1DCrgUSJVWh0R0PyfkgtYafbdzfXKx6Gr1F?= =?utf-8?q?Zmpw4ZSSSPX7HvPOuvsIflv6bzOZUFtBTNkUEAMFipEGdsZ1QLngrboFqlup+qomM?= =?utf-8?q?OwHX+YETHg1GI3sdos5ZJXPD7TVf2UDUYYV2EMvdnOwyAkWhKQgQRfICfMtpBdAms?= =?utf-8?q?jrr9NIUhvHibWz/3CqI9SuT04pYJ0B+bkUdn6ogk0SzGgBmF1rjIEqxwidBhEplLU?= =?utf-8?q?rC6k16ycGoUMoW7VTR+J7/m2i4Sqx5zF3TuZM/kJICM+3Ha8QH9nHF/i/2tTJsSHK?= =?utf-8?q?e8WJ3w7poYRZpElMQRD4Lc1XEXuEjE9uq4MdZiCUWJ/kgaPz5357YVlXaK+re4m0T?= =?utf-8?q?GtuJm7EfW55WoYcaErq0lijSfV3Wc2Q2PWHkV4/TS+qImDDEWuomrx/H+BnIdyf2/?= =?utf-8?q?GYSTG3/pii30yQa9gMMa05MY0633QmZ2ZQYtHQTVUjKg4vJCkrDR1ytHc4dD0y+YA?= =?utf-8?q?GIk1eOrxTwewkIWnR83X7/nd3OmwnIXXgC+3nVYkT8n710wrYmmpJVyDtOIO+c0Ew?= =?utf-8?q?l9ucAJPD52FH?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d131d831-caab-495e-5e23-08dd154d1b71 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2024 16:51:47.6701 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dwwxBZDaSDu8wQG0+EqcRjkuSJZqpGy2xZM1OJnb1pxR/5dWb9grRkIgEYqWpohOsew+rGcKcK91ebg8rhPlQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7446 From: Joy Zou Support pca9452 on imx93-14x14-evk. Signed-off-by: Joy Zou Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts | 83 +++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts b/arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts index 236a44c1782ae..348abb9ceae19 100644 --- a/arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts @@ -219,6 +219,89 @@ pcal6524: gpio@22 { interrupt-parent = <&gpio3>; interrupts = <27 IRQ_TYPE_LEVEL_LOW>; }; + + pmic@25 { + compatible = "nxp,pca9452"; + reg = <0x25>; + interrupt-parent = <&pcal6524>; + interrupts = <11 IRQ_TYPE_EDGE_FALLING>; + + regulators { + buck1: BUCK1 { + regulator-name = "BUCK1"; + regulator-min-microvolt = <610000>; + regulator-max-microvolt = <950000>; + regulator-boot-on; + regulator-always-on; + regulator-ramp-delay = <3125>; + }; + + buck2: BUCK2 { + regulator-name = "BUCK2"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <670000>; + regulator-boot-on; + regulator-always-on; + regulator-ramp-delay = <3125>; + }; + + buck4: BUCK4{ + regulator-name = "BUCK4"; + regulator-min-microvolt = <1620000>; + regulator-max-microvolt = <3400000>; + regulator-boot-on; + regulator-always-on; + }; + + buck5: BUCK5{ + regulator-name = "BUCK5"; + regulator-min-microvolt = <1620000>; + regulator-max-microvolt = <3400000>; + regulator-boot-on; + regulator-always-on; + }; + + buck6: BUCK6 { + regulator-name = "BUCK6"; + regulator-min-microvolt = <1060000>; + regulator-max-microvolt = <1140000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo1: LDO1 { + regulator-name = "LDO1"; + regulator-min-microvolt = <1620000>; + regulator-max-microvolt = <1980000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo3: LDO3 { + regulator-name = "LDO3"; + regulator-min-microvolt = <1710000>; + regulator-max-microvolt = <1890000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo4: LDO4 { + regulator-name = "LDO4"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <840000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo5: LDO5 { + regulator-name = "LDO5"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + }; + }; }; &lpi2c3 {