From patchwork Tue Dec 10 14:26:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13901508 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 930521AC450 for ; Tue, 10 Dec 2024 14:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840782; cv=none; b=OJFeCK9CoNCtWksX4dyga8GW07yrOPjrHOAJmSjsmipapFVf5EtWXFV4ENF04v4wyz5yEdOY25Gh+PhC+EBWKMHCfHeJgFgJk5zX+ScFMNcLGY0UH+r1WWmMAzSfdJLZF8BFKxjuuDy820ZzXY6rSj+CPW42iKT0V7kp0X5AbS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840782; c=relaxed/simple; bh=YzpJ5Ech2tFBRwr/fykFM9OhktbULEwUTNk+beKXWC0=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=tC7jxwmA0IlD9ls+F5AIyBQvyfpoxTyRSFqdajvZxUr1gGHO0WKYl3nDeDVouJmNuB7j1OgdoxWbkoo48eM0eSGFSalZ6G51FeRvFfnWrpP7hfsCNKVvZ5jE0jsmXYcRUrGCtPnaY7U+h94+wkSI5zUMIYGT1XG8IeK6BKrNlYU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=pkzwFEux; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="pkzwFEux" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=id/jB4M6wcjUq20SRtsYBj8Ele73YRBxaOIY46wXcf4=; b=pkzwFEuxQQmiRhV9HJtbLr7E8h Vi0vY/wRxmIPNz2hHWHAS1rXfiiQu5tVzfaYBcmIPhohOUKqGtJyUXEwBIKVQJxs18sms+SsUk0xK 560CIU9dAyfEio9PdKOshwzT4tmAcKjWWyJQd9P7bQG054UlmgMVn5nHx5JROZPaw+dQHMJ18x/j3 FFjLYR9BE6t8vx39uvGp92MQhyPOspKAbRDeZzJKergIDh+VfO68eBfkIDfTh+LOPcIFTdlvLDBcG 6US9QOJ/YGodFWNYvmXU80Mv6jw/MxsaaFIZk/5s9eWQXNz+L66EuzOH0QG0bfaTB21fZxQo7yRhY 4Z0CsfVw==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:56478 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tL1Bn-0002XT-35; Tue, 10 Dec 2024 14:26:16 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tL1Bm-006cn4-Gr; Tue, 10 Dec 2024 14:26:14 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Simon Horman , UNGLinuxDriver@microchip.com, Vladimir Oltean , Woojung Huh Subject: [PATCH RFC net-next 1/7] net: dsa: ksz: remove setting of tx_lpi parameters Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 10 Dec 2024 14:26:14 +0000 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC dsa_user_get_eee() calls the DSA switch get_mac_eee() method followed by phylink_ethtool_get_eee(), which goes on to call phy_ethtool_get_eee(). This overwrites all members of the passed ethtool_keee, which means anything written by the DSA switch get_mac_eee() method will discarded. Remove setting any members in ksz_get_mac_eee(). Signed-off-by: Russell King (Oracle) --- drivers/net/dsa/microchip/ksz_common.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 94f9aa983ff6..9a48b4438a6d 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -3480,14 +3480,6 @@ static bool ksz_support_eee(struct dsa_switch *ds, int port) static int ksz_get_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e) { - /* There is no documented control of Tx LPI configuration. */ - e->tx_lpi_enabled = true; - - /* There is no documented control of Tx LPI timer. According to tests - * Tx LPI timer seems to be set by default to minimal value. - */ - e->tx_lpi_timer = 0; - return 0; } From patchwork Tue Dec 10 14:26:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13901509 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 921C91AF0D4 for ; Tue, 10 Dec 2024 14:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840787; cv=none; b=pY7920B2Uiry2qkvA3PAwY3GRhQewfJ84WHcr6/QrCxp8A7akGQ4pwpZzaICSVCMGzL7F4o/kdjuFXpEl4RIeEVFv4nXFlLNqKnrzaE1W9ItBpac0rVrHVtYozU4dUH/R4LbfzSbWzlxuUwg1XI9FlC3TIMxG1vpGYbPtP6hHXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840787; c=relaxed/simple; bh=3602MzZdwPzpCopK5RcCRGLU+UA2OARQRwHQT373Hgo=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=f896ZWGc41uPjDlNjx6P0t5gSe/kSBukSUaw0M7dWjklcb+kAO+r6kHjO22QOgxC+T5S7noB6+u3183i5uILLcT0wbhWtmoCl54G/tJPWF3Xd6545DAay0I+0RFD2z/HrH29spmAh0NsH2+9jHmv6lgwusrZnewhnmQyMmv08uY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=Uzf1Z5S+; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Uzf1Z5S+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=B4OyUUHYIuqjy441HVi5jgLLiexrDfZmmrvvYn9QIIQ=; b=Uzf1Z5S+u2+um/+JgXPSby6giW 2x2WpnC8Zd9XnsqhUeM39sEY5YHr7TSCk/49McBvaHfViQBStz1TV5IQeMwh/aNEKAjUSzwS0H/7f M+7Jks5xmfPxGyu5rZxdMK1QMHb36nq5nsArRr8aMlYlXMOrB6bm6+7E50LpjRmf4/+V+aIQ8i+PX EGR36BEXlRU7ckrrMhG3WWrjiQuI8apdISDutb0X9rH1Y/+BYNr02PigDn/JLrn/bi3KQinmtb42/ 6uNkvnCklaj5cl8HfY0lHhGnakEC0dtNTU6CI1Mb4QNmSKIJgsT/CSPTiXBdEWsCmjmmxqLA8LRN+ 6WpXrEeA==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:44522 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tL1Bt-0002Xe-06; Tue, 10 Dec 2024 14:26:21 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tL1Br-006cnA-KV; Tue, 10 Dec 2024 14:26:19 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Simon Horman , UNGLinuxDriver@microchip.com, Vladimir Oltean , Woojung Huh Subject: [PATCH RFC net-next 2/7] net: dsa: no longer call ds->ops->get_mac_eee() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 10 Dec 2024 14:26:19 +0000 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC All implementations of get_mac_eee() now just return zero without doing anything useful. Remove the call to this method in preparation to removing the method from each DSA driver. Signed-off-by: Russell King (Oracle) --- net/dsa/user.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/net/dsa/user.c b/net/dsa/user.c index 4239083c18bf..fb38543b29db 100644 --- a/net/dsa/user.c +++ b/net/dsa/user.c @@ -1250,23 +1250,11 @@ static int dsa_user_get_eee(struct net_device *dev, struct ethtool_keee *e) { struct dsa_port *dp = dsa_user_to_port(dev); struct dsa_switch *ds = dp->ds; - int ret; /* Check whether the switch supports EEE */ if (!ds->ops->support_eee || !ds->ops->support_eee(ds, dp->index)) return -EOPNOTSUPP; - /* Port's PHY and MAC both need to be EEE capable */ - if (!dev->phydev) - return -ENODEV; - - if (!ds->ops->get_mac_eee) - return -EOPNOTSUPP; - - ret = ds->ops->get_mac_eee(ds, dp->index, e); - if (ret) - return ret; - return phylink_ethtool_get_eee(dp->pl, e); } From patchwork Tue Dec 10 14:26:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13901510 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89A841AF0D4 for ; Tue, 10 Dec 2024 14:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840792; cv=none; b=YnHJ8Mh97qRWpbgZBIDErfpM1BnzERbCy/4N/1wRPy5rloPfY69AHoldkr43O5nLHOKx3BvREMM5GN699EIiVYSl7bu37igNoC+isIhIlw77fNArzvrDE3YDlsUdu1rcOFBAJFLbzmBqH8FTExBWzo/ewWqncDoLKOeuoMEN4jw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840792; c=relaxed/simple; bh=mOmAUV7MZzW0ms7CgYI2pKwscSPrxGS1mmgv7kNt16E=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=Uw0jVpFaVfOGBEixVTV73DCrzX5h5tsbSfSQOXuDgkUC1NniNJ4D1BNbSifdPNrPJTugwQHuYJIKC6ajp1+ooZzUpDrUrtyxVf+GTtNY+9WoCMDFiXOFALVN9RcIm7Fp2JAVx2U2RSvNPLknLRyBR6edAlSwXqUpjAtfCgIAmqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=M2Hpqv0g; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="M2Hpqv0g" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8eCDYc5wLE97wROsRuo0M5NubJXjSHY7FvadaMmC9eA=; b=M2Hpqv0gQgSfcET/rvJtHpwQmR cleZB6E2949BKpOSQXRzF7Z3lTplXyvzZvOfYZEc9PQfQu3nmjNRc7ayM92wIBqNh3D/MjKKZ97Cn kB+8Q8uSRCnOZlFzMi42+VJ4FiC3uMgJq3/11FhgIEM2xC9r0Zyyg5TrklqqfZtmIKyzoqn6Cevw/ Y5qVYe97uuoSVebAFdF9tLTfSf1RJJR6puc1VmRjgXRuSMVpSC4ZjLFJUriNQGyKozjW4n2vApHBx kMX/5F8QoSOanhbfWTZftp3nZatN/pwlgVFnxqgloNn0/apX9sjpDqEAm5eT2hhNRGWXKrU9CzDum Dan+7vxg==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:44538 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tL1By-0002Xu-0c; Tue, 10 Dec 2024 14:26:26 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tL1Bw-006cnG-O7; Tue, 10 Dec 2024 14:26:24 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Simon Horman , UNGLinuxDriver@microchip.com, Vladimir Oltean , Woojung Huh Subject: [PATCH RFC net-next 3/7] net: dsa: b53/bcm_sf2: remove b53_get_mac_eee() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 10 Dec 2024 14:26:24 +0000 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC b53_get_mac_eee() is no longer called by the core DSA code. Remove it. Signed-off-by: Russell King (Oracle) --- drivers/net/dsa/b53/b53_common.c | 7 ------- drivers/net/dsa/b53/b53_priv.h | 1 - drivers/net/dsa/bcm_sf2.c | 1 - 3 files changed, 9 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 0561b60f668f..79dc77835681 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -2232,12 +2232,6 @@ bool b53_support_eee(struct dsa_switch *ds, int port) } EXPORT_SYMBOL(b53_support_eee); -int b53_get_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e) -{ - return 0; -} -EXPORT_SYMBOL(b53_get_mac_eee); - int b53_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e) { struct b53_device *dev = ds->priv; @@ -2299,7 +2293,6 @@ static const struct dsa_switch_ops b53_switch_ops = { .port_enable = b53_enable_port, .port_disable = b53_disable_port, .support_eee = b53_support_eee, - .get_mac_eee = b53_get_mac_eee, .set_mac_eee = b53_set_mac_eee, .port_bridge_join = b53_br_join, .port_bridge_leave = b53_br_leave, diff --git a/drivers/net/dsa/b53/b53_priv.h b/drivers/net/dsa/b53/b53_priv.h index 99e5cfc98ae8..9e9b5bc0c5d6 100644 --- a/drivers/net/dsa/b53/b53_priv.h +++ b/drivers/net/dsa/b53/b53_priv.h @@ -385,7 +385,6 @@ void b53_disable_port(struct dsa_switch *ds, int port); void b53_brcm_hdr_setup(struct dsa_switch *ds, int port); int b53_eee_init(struct dsa_switch *ds, int port, struct phy_device *phy); bool b53_support_eee(struct dsa_switch *ds, int port); -int b53_get_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e); int b53_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e); #endif diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index a53fb6191e6b..fa2bf3fa9019 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c @@ -1233,7 +1233,6 @@ static const struct dsa_switch_ops bcm_sf2_ops = { .port_enable = bcm_sf2_port_setup, .port_disable = bcm_sf2_port_disable, .support_eee = b53_support_eee, - .get_mac_eee = b53_get_mac_eee, .set_mac_eee = b53_set_mac_eee, .port_bridge_join = b53_br_join, .port_bridge_leave = b53_br_leave, From patchwork Tue Dec 10 14:26:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13901511 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A821B1B6539 for ; Tue, 10 Dec 2024 14:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840797; cv=none; b=YuhjtuWI5o44kgr/+etb2E+5llcjXjTPJZMhjGd2WCxx8USSpI2Vd6Sg00YIHgQMbgdSA6TTWHXocYZqFdHPievNxv5LgGa9BgO8v2Umx80HoiMFjayhmwrltsTqBKBOEaP1AC7QmVKmrBKlPo3oi2MLAn/wXUmgOCKjYGK+OcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840797; c=relaxed/simple; bh=L6r0mw0fOkSALhi4Db3ctp0gYZxYehJ0K+gV4X0Il/k=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=jqKQGxkcw1A/EQppEHMyWP4GsasWfUBOq9XCrrgHFakTKpoJeXJZkNetWcy3eb0TjPnZ2WZPjWrR7PaSJlw7t0pa2wIPx7fddYNPK160D+36efSGUkCXJIMRlNs91SSGbje1kpz3xe5TjtgYZnin/DMKFETRDIDVpesIsIqJQFg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=CEi7nUBb; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="CEi7nUBb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cvdvBlA9Ko6LAHPWyefb3uu2oXGYH3k/JYtRhZiz8wI=; b=CEi7nUBbPaNQwdh/WeyCdGUXaK cBjc+pt8eXjb6mqBcgKjp3+4zrqwtboexfC+u7M85qBZ6Xc7v0FYxH28/Bp6KuLj07apc4N6K5DkH B5EVeR79ksjwSPujBfYYD16eDcPI37f7kRGPMgOjFQpx7UsnDqjUEJykhVhTZ5rj4HSBY05wPWyC7 G+fi1OgZ1ntD9ndLQyzsnsJXrxpFupbgwUn1AwDJdZuUHShDiVivzyf317PSPiZExsK2hqBZC/+vr AtgoyQEGIQsSg3jtnlGMvWlveEGAo/Z373+l2OJmbJK1JsQ7y7XDRjYcHpWhoU4IcCroTy03ui0ld KDHjDU3Q==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:35626 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tL1C3-0002YA-0q; Tue, 10 Dec 2024 14:26:31 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tL1C1-006cnM-S8; Tue, 10 Dec 2024 14:26:29 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Simon Horman , UNGLinuxDriver@microchip.com, Vladimir Oltean , Woojung Huh Subject: [PATCH RFC net-next 4/7] net: dsa: ksz: remove ksz_get_mac_eee() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 10 Dec 2024 14:26:29 +0000 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC ksz_get_mac_eee() is no longer called by the core DSA code. Remove it. Signed-off-by: Russell King (Oracle) --- drivers/net/dsa/microchip/ksz_common.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 9a48b4438a6d..807a37112a00 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -3477,12 +3477,6 @@ static bool ksz_support_eee(struct dsa_switch *ds, int port) return false; } -static int ksz_get_mac_eee(struct dsa_switch *ds, int port, - struct ethtool_keee *e) -{ - return 0; -} - static int ksz_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e) { @@ -4633,7 +4627,6 @@ static const struct dsa_switch_ops ksz_switch_ops = { .cls_flower_del = ksz_cls_flower_del, .port_setup_tc = ksz_setup_tc, .support_eee = ksz_support_eee, - .get_mac_eee = ksz_get_mac_eee, .set_mac_eee = ksz_set_mac_eee, .port_get_default_prio = ksz_port_get_default_prio, .port_set_default_prio = ksz_port_set_default_prio, From patchwork Tue Dec 10 14:26:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13901512 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF88F1AE01F for ; Tue, 10 Dec 2024 14:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840803; cv=none; b=KKBAkaz8OdBZoMPdLUSLBZSdYzC9p1A0WsRia9rM2eQrYCZLTzkt26QEC4Sb7OpPzW1mK7lYAh6twXmw0sWZf7oR0q8srF+KNf3bg/x2Ljpus8ELkXkkD6++eNYm2n8KYce7K3+TYfnnxqfm5iRFEZgaqWOQH1BzVqqxXrb4LYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840803; c=relaxed/simple; bh=DNTQ3ShBoCjk8va+MLNGtNI47YmEdkuV5fB1VcYuoHI=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=nPbf/t5tAFkOiDKbrW6LEW565inGu0obYw46JbcB+5OpkQ7ntkOUjMlbKBcUTX/+xxf8KX/2/sNRc8d11rz1O/lf3Y1T0ZeLSi3WipTlaDNHhbGvXBNbSg8J0mWJhqCus3pDydu2Z8z0m3roq+JcYKB+oe3U89aJz6UxN3MU6+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=0LAdcsn6; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="0LAdcsn6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LZwopWdr1tHwFB7ck8nb8zB5YRGvsSmHjucSGkcKBg4=; b=0LAdcsn6YNHPX2L7YqP2LHh58R BKl1mTvt6Sl6eHut4OMKRw96eAhg2kOZeDeBfs6x7RwoAJ5BLqLNEd79+ihA1yLzxYLNTOl2D0EyM 7aHm5lUy9E2483O89JmsVxg0nqzAQZ7LIp6PJn0yxdQ8/sty5L2f8JLlsUM3xAvorNJm7KU78DLuj kbLpgMxVrxbYkBK5llNCrUh1YhbLlHRmSsx1eo23mbe2Y/gYQBkO3SBif5nkG6tttrz4cXm43jjeD U/YE23/TfucB5mp9B5EXQyuYFNvFEFxgwNOoPdvtaS6oC64MUXlsuKb4iCy8qb2veoc/ufiFMzKaU HiWEev8g==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:35634 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tL1C8-0002YU-1P; Tue, 10 Dec 2024 14:26:36 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tL1C6-006cnS-Vc; Tue, 10 Dec 2024 14:26:35 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Simon Horman , UNGLinuxDriver@microchip.com, Vladimir Oltean , Woojung Huh Subject: [PATCH RFC net-next 5/7] net: dsa: mv88e6xxx: remove mv88e6xxx_get_mac_eee() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 10 Dec 2024 14:26:34 +0000 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC mv88e6xxx_get_mac_eee() is no longer called by the core DSA code. Remove it. Signed-off-by: Russell King (Oracle) --- drivers/net/dsa/mv88e6xxx/chip.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 1d78974ea2a3..ddb70047098f 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -1522,13 +1522,6 @@ static void mv88e6xxx_get_regs(struct dsa_switch *ds, int port, mv88e6xxx_reg_unlock(chip); } -static int mv88e6xxx_get_mac_eee(struct dsa_switch *ds, int port, - struct ethtool_keee *e) -{ - /* Nothing to do on the port's MAC */ - return 0; -} - static int mv88e6xxx_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e) { @@ -7075,7 +7068,6 @@ static const struct dsa_switch_ops mv88e6xxx_switch_ops = { .port_max_mtu = mv88e6xxx_get_max_mtu, .port_change_mtu = mv88e6xxx_change_mtu, .support_eee = dsa_supports_eee, - .get_mac_eee = mv88e6xxx_get_mac_eee, .set_mac_eee = mv88e6xxx_set_mac_eee, .get_eeprom_len = mv88e6xxx_get_eeprom_len, .get_eeprom = mv88e6xxx_get_eeprom, From patchwork Tue Dec 10 14:26:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13901513 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302871AA1FD for ; Tue, 10 Dec 2024 14:26:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840807; cv=none; b=g6u3inE4fo34zIW/nhGPrYbDshamC4HoImWefKwyyonTIUzU9EnB5VxDakQ+K4KBAizBRMvMim9+BmIWzYhY4h1vQ3zCrOHtcsswkPXfuwsXjWssHRge9jZdZyjgj0meOD6NLt4ZudPlS2yyi0CQPRKApi1lOw/Lx+G5LstMYd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840807; c=relaxed/simple; bh=VJ5hq5cH14c6P+fcjHbFrh1FneZgUgeM0T3XRlKzlh8=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=enuPBsueC3V8OpWcZVoIacer461eyJ9HLmeDGQ0RGOfmrcNY6X671wIqKbUitrKZsmFAul/5GcETi2/Ury/6TxGxa/ZadVzNva0zW6PO9oJrjeuTgQZNCozfDXHm16aeegtrZzoPGNnYg1wH1FwTXtLBLdiRYgY7uNZ9J5X+4Fc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=dQZwhsiy; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="dQZwhsiy" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LpgMeDj97We01J44ueWyghgSoa7S5VUOV3d2kaBDb/M=; b=dQZwhsiyZW9gxtERc3p3B2dUS3 fEBUpDEgZ+VLXaiclhKgtjfnn51Wm8+bugxYV3JC3POW9BHJoLrZDu/3ILUa1cFJ0g9qry9PsHyDn ZaWyqcRHIHo9HamAu0MuHutqaMzKJC4IDPJYNX0TsTSzRFhvgmhZjkTszp1DrGFyAoLERJCSJwukk RkOpROI9uyrY2s7o2U3CApLaVdaXXat86E7khmaKm6wSgPtC0QuWHBENsxJ63u0IlQ/jQVRi7N0bI rTgVEhkijDwzpul5jhcfdhgdmxhWIDKLo6cQoQV3tHHFj3/Vsb2kD6Ih3xpN9sall/WHCPlA3v1ek tom34HRQ==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:57154 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tL1CD-0002Yv-23; Tue, 10 Dec 2024 14:26:42 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tL1CC-006cnY-39; Tue, 10 Dec 2024 14:26:40 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Simon Horman , UNGLinuxDriver@microchip.com, Vladimir Oltean , Woojung Huh Subject: [PATCH RFC net-next 6/7] net: dsa: qca: remove qca8k_get_mac_eee() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 10 Dec 2024 14:26:40 +0000 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC qca8k_get_mac_eee() is no longer called by the core DSA code. Remove it. Signed-off-by: Russell King (Oracle) --- drivers/net/dsa/qca/qca8k-8xxx.c | 1 - drivers/net/dsa/qca/qca8k-common.c | 7 ------- drivers/net/dsa/qca/qca8k.h | 1 - 3 files changed, 9 deletions(-) diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c index ec74e3c2b0e9..4c68524ad8af 100644 --- a/drivers/net/dsa/qca/qca8k-8xxx.c +++ b/drivers/net/dsa/qca/qca8k-8xxx.c @@ -2017,7 +2017,6 @@ static const struct dsa_switch_ops qca8k_switch_ops = { .get_sset_count = qca8k_get_sset_count, .set_ageing_time = qca8k_set_ageing_time, .support_eee = dsa_supports_eee, - .get_mac_eee = qca8k_get_mac_eee, .set_mac_eee = qca8k_set_mac_eee, .port_enable = qca8k_port_enable, .port_disable = qca8k_port_disable, diff --git a/drivers/net/dsa/qca/qca8k-common.c b/drivers/net/dsa/qca/qca8k-common.c index 560c74c4ac3d..13005f10edb7 100644 --- a/drivers/net/dsa/qca/qca8k-common.c +++ b/drivers/net/dsa/qca/qca8k-common.c @@ -557,13 +557,6 @@ int qca8k_set_mac_eee(struct dsa_switch *ds, int port, return ret; } -int qca8k_get_mac_eee(struct dsa_switch *ds, int port, - struct ethtool_keee *e) -{ - /* Nothing to do on the port's MAC */ - return 0; -} - static int qca8k_port_configure_learning(struct dsa_switch *ds, int port, bool learning) { diff --git a/drivers/net/dsa/qca/qca8k.h b/drivers/net/dsa/qca/qca8k.h index 3664a2e2f1f6..961d14f0336d 100644 --- a/drivers/net/dsa/qca/qca8k.h +++ b/drivers/net/dsa/qca/qca8k.h @@ -520,7 +520,6 @@ int qca8k_get_sset_count(struct dsa_switch *ds, int port, int sset); /* Common eee function */ int qca8k_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *eee); -int qca8k_get_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e); /* Common bridge function */ void qca8k_port_stp_state_set(struct dsa_switch *ds, int port, u8 state); From patchwork Tue Dec 10 14:26:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13901514 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E401AA1FD for ; Tue, 10 Dec 2024 14:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840812; cv=none; b=WLP9ZWhXE6SbJM9OXRJGdUk0T9yWxB6KDpLsyVWqnS8OER0SSpKFXaT2MFioqZmwrRsFRYglFnEuHDMbyiS+7xj+hdGvd6neu4FZaI3gOx5lKAwd52AMjNg0TmbN+7RfTfQTqbD21QwvfVNNG0ty+fjaJO7uZAXIbMVtimN3JDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840812; c=relaxed/simple; bh=kSiA94ParQtd16g2J/Kqqgn323ohU2UmPfI21Z+U53g=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=Ig/TVSUVUUSqkVzO4U+DN31oa4/S78kAUvAV3sd++nV4kS4DNUQtYM8mByNDLPW65ER3bd8pTudPGC5P+hkHnZxL0bRQkD3tWwYfHvbYwOYH7RAECYQynxVyWfCxNCJvcXlo8U9GgMS4eSzwRe4Q57NGIxbUoTV4Oky39PVVUvc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=clLNwCGf; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="clLNwCGf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G8t1xaI1/GugJIK8OBprVbaU/A8jM/gJsPmAeiSAzxc=; b=clLNwCGfyp0oG0TR9gNUeWxtyk O/sqKL9Nnwn2JsaJYTOVv5Yi4rQFnRjbCtmhmqV3H81dEzXZ+98JQOq/qhYPsUz0bF2esFejz50Kh ofsUKa13GTz84FEsBZMo8XaPRlcR2Ujh2ikHIHsfccfIpMqAdT5f3CawMAxTvMoQrq5XXooasDBki zw/2An9fRPKKn8ZJliJ3JEc01rqy7AmnIhwMcXKCIMWKAHTRaz4yte7Z+PBrn/jRMgjBCQGVxtvh6 dHZMojHN9cDWx3X4VXNph+cuIjANb3hdxSUTBgssE6ucCd/G2r2egpJ2TjmdueEc4fLEgvDli2qrD atJzBSYw==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:57170 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tL1CI-0002ZH-2C; Tue, 10 Dec 2024 14:26:47 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tL1CH-006cne-6W; Tue, 10 Dec 2024 14:26:45 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Simon Horman , UNGLinuxDriver@microchip.com, Vladimir Oltean , Woojung Huh Subject: [PATCH RFC net-next 7/7] net: dsa: remove get_mac_eee() method Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 10 Dec 2024 14:26:45 +0000 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC The get_mac_eee() is no longer called by the core DSA code, nor are there any implementations of this method. Remove it. Signed-off-by: Russell King (Oracle) --- include/net/dsa.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index 4aeedb296d67..9640d5c67f56 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -991,8 +991,6 @@ struct dsa_switch_ops { bool (*support_eee)(struct dsa_switch *ds, int port); int (*set_mac_eee)(struct dsa_switch *ds, int port, struct ethtool_keee *e); - int (*get_mac_eee)(struct dsa_switch *ds, int port, - struct ethtool_keee *e); /* EEPROM access */ int (*get_eeprom_len)(struct dsa_switch *ds);