From patchwork Thu Dec 12 14:38:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Ekenberg X-Patchwork-Id: 13906650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4197E7717D for ; Fri, 13 Dec 2024 08:18:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20C2410E452; Fri, 13 Dec 2024 08:18:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=axis.com header.i=@axis.com header.b="Md77kE50"; dkim-atps=neutral Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2075.outbound.protection.outlook.com [40.107.241.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4F4A10EE16 for ; Thu, 12 Dec 2024 14:38:54 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JQ7vMp9bdmr+GqmR3Y/mBmMw2wtKyIVak+vJj4H7EeCZooUZ+aXicG3KSqCXIbrvwN8WvkrffamDMdxTYaAw0z0H0+SB0iR1FWb6bJJsY06c0igXOeXKT+cCiKwruRhBhhnT0o7Qd9CnLS4R1/Zxn3HVCvjSH5oYsxYUh+z4vImhwLdCGXIs/HRW+zAbhD0xund9hmV98ncN/gHTNVSk1ZBI9epvX8vJVRG+XmmA0S8bWQp5z8eULUnDuziWQtWcScJo6rnnbYX55tOGF2dMZo57g7ltAmU9V/Tz6I6VDuf+BmZbBtu2F9kpsm3R+eh/spX3dgfRiaXYN86L4WSSig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u30tsaFF0rybH8MkBjkpC0TaIPLlaSaxtdJHc2toSV8=; b=KTy7zk4rtNB4lNVsxaVHQuL2k9MGC6xYvnLW3jAlkMR8nVCDSFGJnpYf2M86EgBen9aUAsfS96p4bZZiddBSx38X2XIkGBKy/kiWGGJpBlzyeq2eDXF8F6TAO+8Rh1ugJ4GZc2wWh/Q+gwp18QQpp8dFEABeuuBoOTQ7GuIrwHrSSkbmwhweYtakr/pQ1VQDBwM1y7YfIMe/dVJ65g/yOSzjERyw/0Oo+Vy4f8qIRG8PDyPzPsk+gcX0vTUfQIwIEEQtgLMkapy+TvwBydmp+3mp51fr+7gnRmqruJnQctMgK9C/xsSjGdFzRoj8jFCH2t9GcYqUJKud8KkAuSsrkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 195.60.68.100) smtp.rcpttodomain=bp.renesas.com smtp.mailfrom=axis.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u30tsaFF0rybH8MkBjkpC0TaIPLlaSaxtdJHc2toSV8=; b=Md77kE50G2kg/2hbACb2IaEaB9Gj0HBkNsmCbVNxk916AvPOexH3Fl4YD3wMb6gptTC2Ab9qo4kVb/XihQfmP/tIIIR/AgTnAa58SVXmeCC3HKP2yDRdItRg46UvwqnhrcQThEVXjVudzr4KBk0QiTraHzU8YdTS+Oe5ZWP5M3I= Received: from DU2PR04CA0182.eurprd04.prod.outlook.com (2603:10a6:10:28d::7) by AS2PR02MB8950.eurprd02.prod.outlook.com (2603:10a6:20b:5f1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.16; Thu, 12 Dec 2024 14:38:52 +0000 Received: from DB3PEPF0000885E.eurprd02.prod.outlook.com (2603:10a6:10:28d:cafe::7c) by DU2PR04CA0182.outlook.office365.com (2603:10a6:10:28d::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.15 via Frontend Transport; Thu, 12 Dec 2024 14:38:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=axis.com; Received-SPF: Pass (protection.outlook.com: domain of axis.com designates 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; pr=C Received: from mail.axis.com (195.60.68.100) by DB3PEPF0000885E.mail.protection.outlook.com (10.167.242.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8251.15 via Frontend Transport; Thu, 12 Dec 2024 14:38:51 +0000 Received: from SE-MAIL21W.axis.com (10.20.40.16) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 12 Dec 2024 15:38:50 +0100 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAIL21W.axis.com (10.20.40.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 12 Dec 2024 15:38:50 +0100 Received: from se-intmail01x.se.axis.com (10.4.0.28) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 12 Dec 2024 15:38:50 +0100 Received: from pc39391-2017.se.axis.com (pc39391-2017.se.axis.com [10.92.82.2]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id 884841AE; Thu, 12 Dec 2024 15:38:50 +0100 (CET) Received: by pc39391-2017.se.axis.com (Postfix, from userid 10612) id 837174373974; Thu, 12 Dec 2024 15:38:50 +0100 (CET) From: Stefan Ekenberg Date: Thu, 12 Dec 2024 15:38:40 +0100 Subject: [PATCH v3] drm/bridge: adv7533: Reset DSI receiver logic MIME-Version: 1.0 Message-ID: <20241212-adv7533-dsi-reset-v3-1-c6b9a5c524cf@axis.com> X-B4-Tracking: v=1; b=H4sIAG/1WmcC/23OMQ6DMAxA0augzHWFE0KhU+9RdQiJKR4KKEERF eLuDagDA+O35GcvIpBnCuKeLcJT5MBDn0JdMmE7078J2KUWMpcFYl6BcfGmlQIXGDwFmqCoKlu 2TaOpkCLtjZ5annfz+UrdcZgG/91PRNymfw3ViRYREEqLeVmT0q1TDzNzuNrhIzYsyiNQnwEyA YTS2vQPSW0OwLquP/b6YzfyAAAA X-Change-ID: 20241108-adv7533-dsi-reset-488c6fbb5e42 To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , "Jernej Skrabec" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , , Biju Das , Stefan Ekenberg X-Mailer: b4 0.14.2 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PEPF0000885E:EE_|AS2PR02MB8950:EE_ X-MS-Office365-Filtering-Correlation-Id: cd1dd496-de1f-4ab3-be9e-08dd1abab26c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|36860700013|1800799024|82310400026|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?q?FdbvpqmMR8nVfQFIfIXGjBcU28IRfbh?= =?utf-8?q?8x0zbWvaZ2+2CNcsZnxOmWTcLUDrhCxylRb7gAwWS3M24mZawB4ZEYu8VEvTUHXyz?= =?utf-8?q?tYAbKttEvVHFaflNzrFVm9BkIgoeiLMcINtzr/BkJaeAUd0RnlswZjI0FCzVZ7ITR?= =?utf-8?q?lk05MPsHuNqQLT5+0WetLDUf38iESOU1Bd5Q0O7DyGSNDo6EE1mOOUUB0HaJmrvuc?= =?utf-8?q?Hw/h5oreySUpfETWcGk/J3M5DdjqQ00IuEV6/zUzk7a5KIsw5gwLMpmNw7BsPtBv4?= =?utf-8?q?YvymJqOf2S/6q19pq1nInA1JGZGz8B+hzL8FLuK+2W+OpV8zxiscMskHW9NnqrTk1?= =?utf-8?q?s8PepbJRtK2VeCVOhfwEhCOTnvvZxUFEicEBFmTRL6uIZWgEZX7KnJ3fH9KUKt6at?= =?utf-8?q?F/QTWJIve+vORkUAmsR+Cm3DB8ZB/0QjHEtDskeabWrF8mWl220eYt7fjVy5jMw1u?= =?utf-8?q?bijZ1sQOU/jx99YEQXwIgCxixoUD/E/dE5o525QjG7b19Vu94GNaIJY/TJ/zY9yDR?= =?utf-8?q?CQJhvNH8FHnbQ4zgy5fbGDTtgSclCdS+rFwRAxbg2rVp/Et4re3kPtlsbvWnEJr8T?= =?utf-8?q?r1UnyZj+aB4oaQTWbZIRHPjWCh8/9BfY5+NTFIy7dMm791IvgHkwImUQ2on3jAZiG?= =?utf-8?q?+YHHW2OCzfQsm4oBJJa7RCJcZ8FhOPe0FfaFw581p0C9wX2LXgQ8LAJARETg0rmFL?= =?utf-8?q?BKk84ej+WEJ1TiuDvqmDUkkKQ9wTl8nXpd1PdywZADqxD7lVx68bUXHAfsns8NMtJ?= =?utf-8?q?F3oBhVZ1/6SlILbVkCIOIT//7gbNZHV8qUeVT9KcbSZ+RMZgb6yW6kBIajAVeyRBx?= =?utf-8?q?XbNI3NuB487lBl6vvCEUEL+e+tdNypmeu6XNgijx/TqGldBy22Fh76TIZov/CI38g?= =?utf-8?q?rDXGV9hKSoKrklyd1q3d6qQnNOI0uDzTt3qJIC+b4sH89KsVAAXScrbjvQ1cpYlEe?= =?utf-8?q?q6uiakBSjKstxcVUW1FcW39gjKFixVg5SAw6jxv+zYbMz/zlBICQzfXyLWr1tQTPT?= =?utf-8?q?0J99X21EbD0e/F+njYJrL4JK5XIgbWQ92ZIL8aRNtPAHwL7L9Ap0nc+HBJuhoGS0z?= =?utf-8?q?pfGZ8qmeoNyFus5wGHRfMZjJaDGi+OoSw/OYNPGdoan9jSna0ZWmi7tPtO6yY/5NK?= =?utf-8?q?q/NpiantYHcO6le5timmmu4I2wygLhmVdwlEDzc/CFkpbLmPSyHH9cXIi/fYf50LS?= =?utf-8?q?Q+mqPL3XYQRhT9KRKfXQ99Q3Jcb0MenrjjAcq8T2z9irTSCeEQZCNIkV9/Y5i8yi4?= =?utf-8?q?Qtw8UXNAzXnjOTIYo1ndeQmUiFH4mkDKPU3QfJF2cSXqRI4Rm4y6rFKePccguvO9r?= =?utf-8?q?JOs8blY9XCqpHN4EdAn9wLRWfQ77XzaUhIks3yBr18v6geQNe9/b9KRI2l3p9lStu?= =?utf-8?q?VhXNmOv6huhTaNj/glLr8Oo9gbY4eUNjA=3D=3D?= X-Forefront-Antispam-Report: CIP:195.60.68.100; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.axis.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(7416014)(376014)(36860700013)(1800799024)(82310400026)(921020)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2024 14:38:51.5563 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd1dd496-de1f-4ab3-be9e-08dd1abab26c X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af; Ip=[195.60.68.100]; Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: DB3PEPF0000885E.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR02MB8950 X-Mailman-Approved-At: Fri, 13 Dec 2024 08:18:23 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Reset DSI receiver logic during power on. The need for this change was discovered when investigating issue with ADV7535. The symptom of the problem was that ADV7535 continuously outputs a black image. This happened for about 10% of the times that ADV7535 was powered on. The rest of the times the image was as expected. The solution in this patch (placement of reset and sleep time of 200ms) is implemented as outlined by the Analog Devices support team. Tested-by: Biju Das Fixes: 8501fe4b14a35 ("drm: bridge: adv7511: Add support for ADV7535") Signed-off-by: Stefan Ekenberg Tested-by: Frieder Schrempf Reviewed-by: Frieder Schrempf --- Changes in v3: - Add Fixes tag - Link to v2: https://lore.kernel.org/r/20241119-adv7533-dsi-reset-v2-1-e12cce42e25a@axis.com Changes in v2: - Add Tested-by tag - Link to v1: https://lore.kernel.org/r/20241113-adv7533-dsi-reset-v1-1-6c1069e35fd3@axis.com --- drivers/gpu/drm/bridge/adv7511/adv7533.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- base-commit: 59b723cd2adbac2a34fc8e12c74ae26ae45bf230 change-id: 20241108-adv7533-dsi-reset-488c6fbb5e42 Best regards, diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c index 4481489aaf5ebf164313c86cbf3447d2d7914ab9..93085c2b872ed98f4ee394236dc66c568c0e5ccf 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c @@ -67,6 +67,15 @@ void adv7533_dsi_power_on(struct adv7511 *adv) { struct mipi_dsi_device *dsi = adv->dsi; + /* + * Reset DSI receiver block logic to avoid ADV7535 startup problem. + * Without this reset it sometimes continuously fails to receive + * incoming DSI packets and outputs black image. + */ + regmap_write(adv->regmap_cec, 0x26, 0x18); + msleep(200); + regmap_write(adv->regmap_cec, 0x26, 0x38); + if (adv->use_timing_gen) adv7511_dsi_config_timing_gen(adv);