From patchwork Sun Dec 15 05:34:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 13908670 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF12BE7716A for ; Sun, 15 Dec 2024 05:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zWB9xUbuC9ZZF7GN4R9hjYXfuiqehEyAMCDY4g5eDqY=; b=SdoJtu5lKkQJAGk1cqWW0E2d9M 385L1mWSubCYM3ygra81sXahMnBKFte1q5UxGdU+eUN0DoM+bZSnMNG3FsNNIckxGrI0UHadDKYIn rQz4xezPu6/sWg9w1Om3xWiciu5Ew38JLvqbCYI0rNe3WX7wfAf7dvMHJ4pzCSa7xIlkePSkBJ7lg pWhGBcwHugTavdCBOfPUslJfxoc/19iMjn1mQPC6+hf0Qs0I/9B2UyJUXKQjNREC0VKfXxdCs8aHU 4IGrZbdFYKTjcikJPr5rjNryUOQnTnru0qRK2YFzYztn/jSaE6jfDlL+sx2cFz3i7iV42kIhf7GWq Pz6SLhdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tMhLS-00000007S1Y-1czB; Sun, 15 Dec 2024 05:39:10 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tMhJL-00000007Rj2-0XDS for linux-arm-kernel@lists.infradead.org; Sun, 15 Dec 2024 05:37:00 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-801c081a652so1924556a12.0 for ; Sat, 14 Dec 2024 21:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734241018; x=1734845818; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zWB9xUbuC9ZZF7GN4R9hjYXfuiqehEyAMCDY4g5eDqY=; b=aBatdac6nUVhwbgbrAeIIQGXXKSwli3+2/os0RVxLaSf/lIYWUeTFZJc8kTrNvGxvk aSt/lwfYEgkry7qcbjgHmSIO3LIGoyizexCI9ZUErJ4lOk4jy0yzg8W9TEdl64alZuop pZZ4oNik62kPk7jZFYLylSa24SCBZCQPYIRFFKX4Q12QjaeLB+GnqZSsZstRXrj48Mny Nv1PDNiWoCqZNjRZSlDQPANNjtbw/6QIRPfmlaUTtJhyqIY4/YAqmReJg6hWJyK8Cbqm SJ4D9rNnic1ZSWEZGMuEyyVAYc/b94UtI6tgdMtng/uq5fX3L+H6qrqNx8HfV+0ZvWft HyVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734241018; x=1734845818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zWB9xUbuC9ZZF7GN4R9hjYXfuiqehEyAMCDY4g5eDqY=; b=dCNmTRa4YnF0Sz32EGg3xHbWoHPtv02bKTYRk+gkxp/1nAAYfa6/7fLwcAk/pQNWsV p+Zy+XWp3MiPSona9OuWjA1ZXzXVIILfJeWVTsDWDLgwlEphvpblfoYIKRqaFY75N1Lh IbZhWe/6PikU9kHGnGXGMIMuiqHtENNfkE3RFS75iQi1YEHdX3mnJQnjTRJsqgL5Va39 oFecfKvtk79GnYtKJEqYafnPKlUtIYLfQHIwHDLYfXq3GLy3J8jo5qU/db/mEpf8jh9j rOf1a8vZAYPVBoNA4F7TqZLyyISVbQM/9DavKjdgNVG80mk4vKP7AbNqeeowSvghqa/3 L6Bg== X-Forwarded-Encrypted: i=1; AJvYcCWmf6BZpvqHeFFFI2cS/KAj9uztFftsTQ5y+WdmDJhcBY2QcbJmrCdJM6hRAPcB8g+uMbXnDGyNCIpSJ8I/huOZ@lists.infradead.org X-Gm-Message-State: AOJu0YwniSKeDX0BD1cq8OsCrYvBalVUQM9QOl4q9TBB0RktTGtj5wLX uYJr4Ek3NLeZjbHg80q0BoGjKV7A7vRDDXu5c9ZfUNNT7F6uUzza X-Gm-Gg: ASbGncs1G2G0XgqsmYUce6cPsBr3n8cUCIMerkm8iNFa3LQ998IIrDlc7nkHBYszI2t ChyXBITEhHGTAKJhKzprz0M4cFNoWSrflA1cpPjVRMa+tmijKW9Z2B3edhtONo1pJ8Nzcb27ABS uL48avwOUddZ/iiiG+Qd/TOquTk25Zs+JlobGtlt7TJJP0quocCIpddgO/OhFM/Li63uWXIM44z 8IIZhPsis0toYZ7WE3W4E758SNlfDKlOhDWVUs1Qz+Awe0NcA== X-Google-Smtp-Source: AGHT+IF2jjiTuuQytVaWgmoT11AJ2AJQUADdSWheU2GdN/FSM7l8KDl+72eN5xP8lMEWk1y6CvNoFg== X-Received: by 2002:a17:90b:3e82:b0:2ee:edae:775 with SMTP id 98e67ed59e1d1-2f29153c0c4mr11837653a91.3.1734241018179; Sat, 14 Dec 2024 21:36:58 -0800 (PST) Received: from anarsoul-xps15.lan ([2604:3d08:7780:1ca9::398]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f142fa1cf8sm5729803a91.38.2024.12.14.21.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Dec 2024 21:36:57 -0800 (PST) From: Vasily Khoruzhick To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Vasily Khoruzhick Subject: [PATCH 1/3] dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and PLL_MIPI Date: Sat, 14 Dec 2024 21:34:57 -0800 Message-ID: <20241215053639.738890-2-anarsoul@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241215053639.738890-1-anarsoul@gmail.com> References: <20241215053639.738890-1-anarsoul@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241214_213659_164568_D4EAE9A9 X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org These will be used to explicitly select TCON0 clock parent in dts Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux") Signed-off-by: Vasily Khoruzhick Reviewed-by: Dragan Simic --- drivers/clk/sunxi-ng/ccu-sun50i-a64.h | 2 -- include/dt-bindings/clock/sun50i-a64-ccu.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.h b/drivers/clk/sunxi-ng/ccu-sun50i-a64.h index a8c11c0b4e06..dfba88a5ad0f 100644 --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.h +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.h @@ -21,7 +21,6 @@ /* PLL_VIDEO0 exported for HDMI PHY */ -#define CLK_PLL_VIDEO0_2X 8 #define CLK_PLL_VE 9 #define CLK_PLL_DDR0 10 @@ -32,7 +31,6 @@ #define CLK_PLL_PERIPH1_2X 14 #define CLK_PLL_VIDEO1 15 #define CLK_PLL_GPU 16 -#define CLK_PLL_MIPI 17 #define CLK_PLL_HSIC 18 #define CLK_PLL_DE 19 #define CLK_PLL_DDR1 20 diff --git a/include/dt-bindings/clock/sun50i-a64-ccu.h b/include/dt-bindings/clock/sun50i-a64-ccu.h index 175892189e9d..4f220ea7a23c 100644 --- a/include/dt-bindings/clock/sun50i-a64-ccu.h +++ b/include/dt-bindings/clock/sun50i-a64-ccu.h @@ -44,7 +44,9 @@ #define _DT_BINDINGS_CLK_SUN50I_A64_H_ #define CLK_PLL_VIDEO0 7 +#define CLK_PLL_VIDEO0_2X 8 #define CLK_PLL_PERIPH0 11 +#define CLK_PLL_MIPI 17 #define CLK_CPUX 21 #define CLK_BUS_MIPI_DSI 28 From patchwork Sun Dec 15 05:34:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 13908671 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81F99E7716A for ; Sun, 15 Dec 2024 05:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OhrQlN2vwbW+HH5J9QciNO8jVjYFc2SW7Nua2x90G3A=; b=jhinEnv5j83hpR8PpmQR2zfCn0 VrQ1szNjFUXQmxY5e+xWp3dWcoJ9yV38WJ1dRiFq5lwHsrXhsK3DCFSXedcTciRTRPsu+Zf8NF9T5 nNZfDU0UWj/JlASo14d4a0rVA7dWMmZ6t6kKyCm0ngiZmOi3Dsz6xXZpPNuXLMTOcHAIxAmHRibET aGm6vcUVAqOcdHIkB9pfpedEeePLzISWFFeuyxCMN2TRMiShTDjON4aVtT1yaSJSQMJelre5nrN0h y+ScZoVKr1kpCm4jUovLYUE9bnKOp8Vv7ROkW5jm3/gILeY4AiT9gl0o1Yx7/9Yvd8uf7yeqDPUf0 pTaUjyDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tMhMW-00000007S9Q-0Cyp; Sun, 15 Dec 2024 05:40:16 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tMhJM-00000007RjT-4C46 for linux-arm-kernel@lists.infradead.org; Sun, 15 Dec 2024 05:37:02 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2ef714374c0so2223738a91.0 for ; Sat, 14 Dec 2024 21:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734241020; x=1734845820; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OhrQlN2vwbW+HH5J9QciNO8jVjYFc2SW7Nua2x90G3A=; b=PbT7r31U/Jq5HWDk5t3v/4FWbO2ibDVckTXndPnaUlIjZ6sZc668g//2KXihXS9xSJ 0JJXatV+hvai32I7Y0Q0KZSlKW81/D31s1nlToti8+ezi9lkpBH/6nPMCaMA5JymhrfI JuQWruhbOsCVaj8rps/u4OTdrjzT7ZbxiMNvxe3Bvvare3Ck/oeFk9vCnk7iQ6SwIgnd on+v9vuh1HWLI6YGyVKUCxtnpeWCLTfUJwoF5CfoIwsvrRBK036ybAO1FgoHr25q1eSs wiwLUhtv7osByvK3ZBKsFpn4mJ0Kq/xr4og/fHoVOfhkKxm880u2txkojZcAW39e0KiB tZLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734241020; x=1734845820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OhrQlN2vwbW+HH5J9QciNO8jVjYFc2SW7Nua2x90G3A=; b=Ez7CnSI+BpurANFFmd7FD5IyT4pw0qgOb+JpIVVkLY/5lS5Ppl3ctON+lbGtleu/8u AX741wW0kUp8hlrlVlksh1Js+jELJamoPkhzbb4wxr2f3U+aA/M/gsuU0zVnMchGsBqq hle87OAdcaAS73qoPFY2uAh4bNdfEopzZYdxSzWbfQGdLWwMlMaZ5+l13SP8YF7Fe0dx JlSee/xgiCSRe4q4LL2zhIXqlvpT1m5IhnT8WsP5fRFnp19Ncvhwfnb2fO/Idw+cnfMD Pm5ZWFROWOsG5W9E4LeTQEuFVPUgZhtUJYCTJupBP4MDfG9c5i+lcYzg7IsO20JJSpor 3OCQ== X-Forwarded-Encrypted: i=1; AJvYcCXTZ60gPNzvbsbqFW+D4FMnsFd9w2HgV5roSMy6HToWsRzYuINySxNSqSuLs1KtgStwIOVInhAfLWSGaG/X1bxT@lists.infradead.org X-Gm-Message-State: AOJu0YzPjujoUde++52wA3pg8XNYco6i4rFwge8WhNl9ARv0sFaQTI4a uMMB/0KBYH2K6/axlEyO8I07GwsWBWyTkRBgYAh/NcumofA9l62M X-Gm-Gg: ASbGnctrj209gM62pmPEIUlUe6DQEJybv2dRbxA03Z7HbKHuF/d5o3dwkCgJH/0ygP/ J9Q4qPkYXVwIQYE8+Bep7L2CG/WufepofROnA5AoEyNZHXpqykvNCpIoP+Cp1Ee77HFvkcgeeGk YwWZ9oA7aQJjt5/0wuHTRH6b17E7nHektblLyW5c7upd3hy8eQBczhk5i9j0jmm7Nnpvu74fJU2 KvyyaqX7CA6PW3uMCml0wRexNjxYJLCOC46Yr5lrmULhLyNtQ== X-Google-Smtp-Source: AGHT+IErUG9RW0X9xHdH5/Ssxiqt3RncarH98/x9Df651+JEpUXRrMwQ+2RKrQ87NQ7RiDs3G7ovLg== X-Received: by 2002:a17:90b:4cc2:b0:2ee:5c9b:35c0 with SMTP id 98e67ed59e1d1-2f29166acd5mr12192019a91.9.1734241020112; Sat, 14 Dec 2024 21:37:00 -0800 (PST) Received: from anarsoul-xps15.lan ([2604:3d08:7780:1ca9::398]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f142fa1cf8sm5729803a91.38.2024.12.14.21.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Dec 2024 21:36:59 -0800 (PST) From: Vasily Khoruzhick To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Vasily Khoruzhick Subject: [PATCH 2/3] arm64: dts: allwinner: a64: explicitly assign clock parent for TCON0 Date: Sat, 14 Dec 2024 21:34:58 -0800 Message-ID: <20241215053639.738890-3-anarsoul@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241215053639.738890-1-anarsoul@gmail.com> References: <20241215053639.738890-1-anarsoul@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241214_213701_038176_D25D5CAA X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TCON0 seems to need a different clock parent depending on output type. For RGB it has to be PLL-VIDEO0-2X, while for DSI it has to be PLL-MIPI Video output doesn't work if incorrect clock is assigned. On my Pinebook I manually configured PLL-VIDEO0-2X and PLL-MIPI to the same rate, and while video output works fine with PLL-VIDEO0-2X, it doesn't work at all (as in no picture) with PLL-MIPI. Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux") Signed-off-by: Vasily Khoruzhick Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 2 ++ arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 2 ++ arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 ++ 3 files changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts index 379c2c8466f5..86d44349e095 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts @@ -390,6 +390,8 @@ &sound { &tcon0 { pinctrl-names = "default"; pinctrl-0 = <&lcd_rgb666_pins>; + assigned-clocks = <&ccu CLK_TCON0>; + assigned-clock-parents = <&ccu CLK_PLL_VIDEO0_2X>; status = "okay"; }; diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts index b407e1dd08a7..ec055510af8b 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts @@ -369,6 +369,8 @@ &sound { &tcon0 { pinctrl-names = "default"; pinctrl-0 = <&lcd_rgb666_pins>; + assigned-clocks = <&ccu CLK_TCON0>; + assigned-clock-parents = <&ccu CLK_PLL_VIDEO0_2X>; status = "okay"; }; diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index a5c3920e0f04..0fecf0abb204 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -445,6 +445,8 @@ tcon0: lcd-controller@1c0c000 { clock-names = "ahb", "tcon-ch0"; clock-output-names = "tcon-data-clock"; #clock-cells = <0>; + assigned-clocks = <&ccu CLK_TCON0>; + assigned-clock-parents = <&ccu CLK_PLL_MIPI>; resets = <&ccu RST_BUS_TCON0>, <&ccu RST_BUS_LVDS>; reset-names = "lcd", "lvds"; From patchwork Sun Dec 15 05:34:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 13908672 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D66E3E7716A for ; Sun, 15 Dec 2024 05:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SKFdza2xHFDC8vmuSIt7kUvA8GVJhpwFBfkUic7sJXg=; b=h+brlioR1Eyp5utHjbuV2ygw2S oEdCYz5x0y7hApUiShUXbSv4w4wBj87od5vXzsvXG/a593ud3uUC84V4X4Yo60KHtFLvjGRGKAzJ6 R2MNQ7dzuNVa+EtCRs/hpmUgmpnshyID9BGdX2RmKaCKYZob0IOqU/skJBW2BX5v+yS2E2uBawx8Z O5UvBZhrIGSPtw0WDchbrnRV/99UFj3MxBqmlGB/V90Q/NKJ3DyuRLE8UvuMevIc2XYEo0c/0e8g6 J6YEgJ39+Fi1MJgWJRfktiIudHMvQkWoog7COCLOgT94n8ey4vMZ9X85BV1++0QFf27vYkk8KlL4j XnqPVZcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tMhNY-00000007SG9-32GS; Sun, 15 Dec 2024 05:41:20 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tMhJO-00000007Rjk-0C9k for linux-arm-kernel@lists.infradead.org; Sun, 15 Dec 2024 05:37:03 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2166022c5caso23703605ad.2 for ; Sat, 14 Dec 2024 21:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734241021; x=1734845821; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SKFdza2xHFDC8vmuSIt7kUvA8GVJhpwFBfkUic7sJXg=; b=CmE4cLUxPy5Sb3v3oHly1wutpC19nUjmLTJp5KH63NHqhTKmmpguB0LDA6OTeEOYK4 pbJvyhfuQRgiGMLgiWAxE3Rg+VtJsJi1TXoMwf8ZibKorRNrhJtIBbQ55bFhkrLxhrSG BqevO+lPJDvztb/N5MKq//9h2bxO+mlmJ+KQE6dQJxof9fyDLd5iPeApoXTyh6ypzNW6 QtODCNUHsj0uIl6qfEDoFcqF8TlL7tTU2033VmBDGHNygesiueQhZ/dj+egftQsE7hw5 4kxGu7a2eqb3wEJ+cX9ksvOlftTJMqUIsuWJ/ElIvU+G+i7EqX2oBJnusnKQ3B4hvqJk reoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734241021; x=1734845821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SKFdza2xHFDC8vmuSIt7kUvA8GVJhpwFBfkUic7sJXg=; b=tcfdYFv+CC9zcC/5Tq7CTV3QalVzEUq2fOepaEmmipGnzSpXg4WI52t6Fkm79GHd8a ujdZgdCeGDxuOCRSqRvrgSHjKX26ADnvi6AXSL6Scs0IVL8aK48n1y2h5YG8WZsaKfb1 20pLIVXIVxriAg5NQbokbajzWkSYwdW9c9gdcRGswMvw5Z1VKdWUFVb4Y7GD6F7mkygI BnZHPW+8DRzMiddB0tUJ/D5Z4F8gAIlgmU4yeF+n/IkCaFdBFCbCN363QeTJ88CqQbVI yQBsDbJPrR8Nx3Ri+W0+x8ZOys4pAv8hNA4TeJb0KGbNtZy2c4rcLcJOfVpQ0ikoSJG3 dmRw== X-Forwarded-Encrypted: i=1; AJvYcCVx8KiE45sEvu3tEtUl2rUFQepoefYNmHkItMdxlPnFDtfgbBhX/1PBbVT/dD0IrMqQfPlVLYwEAXHhe6K1NMBK@lists.infradead.org X-Gm-Message-State: AOJu0YyRB3ELEFEWCxfrXYuBMf4YfyJPWOpS87hutWknucpku8sxi5hJ feKcbAXLx7XvO8t3Cw5zvmuXCs5K0n8nh1ShlRGE+D8xkvJriQti X-Gm-Gg: ASbGncsQcMGWG8e9bL08LN7ZokPzCoVdV1JEqE3IAE//++R43BZXqB/AIJ4zZfnTgSE qjkLzfWASrttfFheE0rl/SSwfGg7l4JSpXIcJ/djBYpxULdNGUmIpvruue9Ex12Qnkw+Rg/OPPP NIjkBeW+c+kCX87tJucVBJ1qwE/0jKQswNOQkVUFm/d28c2u/8E4SSYohtzk4uPXAwmahk4dMZO uC+cOeTJp4BZFMk5+67wM+pFoP8Usxj4aIjxmlP9xIHh/dPjg== X-Google-Smtp-Source: AGHT+IEEzrDO6PorFmWAnRKn8AWTVLTL53SlxdJAzLW6ec4NvsVjzDB2vdV68Sh9tldHOdGI/Sk3FA== X-Received: by 2002:a17:903:c10:b0:215:7b7b:5cc9 with SMTP id d9443c01a7336-218929f0ea8mr107798965ad.22.1734241021173; Sat, 14 Dec 2024 21:37:01 -0800 (PST) Received: from anarsoul-xps15.lan ([2604:3d08:7780:1ca9::398]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f142fa1cf8sm5729803a91.38.2024.12.14.21.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Dec 2024 21:37:00 -0800 (PST) From: Vasily Khoruzhick To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Vasily Khoruzhick Subject: [PATCH 3/3] clk: sunxi-ng: a64: stop force-selecting PLL-MIPI as TCON0 parent Date: Sat, 14 Dec 2024 21:34:59 -0800 Message-ID: <20241215053639.738890-4-anarsoul@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241215053639.738890-1-anarsoul@gmail.com> References: <20241215053639.738890-1-anarsoul@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241214_213702_146883_83BAB3DF X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Force selecting PLL-MIPI as TCON0 parent breaks video output on Pinebook that uses RGB to eDP bridge. TCON0 clock parent will be selected in the device tree instead. Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux") Signed-off-by: Vasily Khoruzhick Reviewed-by: Dragan Simic --- drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c index 3a7d61c81667..cc8de0bfbc67 100644 --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c @@ -534,12 +534,6 @@ static SUNXI_CCU_M_WITH_MUX_GATE(de_clk, "de", de_parents, 0x104, 0, 4, 24, 3, BIT(31), CLK_SET_RATE_PARENT); -/* - * DSI output seems to work only when PLL_MIPI selected. Set it and prevent - * the mux from reparenting. - */ -#define SUN50I_A64_TCON0_CLK_REG 0x118 - static const char * const tcon0_parents[] = { "pll-mipi", "pll-video0-2x" }; static const u8 tcon0_table[] = { 0, 2, }; static SUNXI_CCU_MUX_TABLE_WITH_GATE_CLOSEST(tcon0_clk, "tcon0", tcon0_parents, @@ -959,11 +953,6 @@ static int sun50i_a64_ccu_probe(struct platform_device *pdev) writel(0x515, reg + SUN50I_A64_PLL_MIPI_REG); - /* Set PLL MIPI as parent for TCON0 */ - val = readl(reg + SUN50I_A64_TCON0_CLK_REG); - val &= ~GENMASK(26, 24); - writel(val | (0 << 24), reg + SUN50I_A64_TCON0_CLK_REG); - ret = devm_sunxi_ccu_probe(&pdev->dev, reg, &sun50i_a64_ccu_desc); if (ret) return ret;