From patchwork Mon Dec 16 07:58:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinas Rasheed X-Patchwork-Id: 13909345 X-Patchwork-Delegate: kuba@kernel.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2B091FF7DB; Mon, 16 Dec 2024 07:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335955; cv=none; b=XVejgWBOIgA7t1hA77UtjyvD1u5bUROvxtUVNlprwkieGHee/bkJyE+uI2zlFaQnZRYtxdAR5LflrJdbUB98Z0DFHuhKJREMlO989qUx9tnvw0DoXX0nOey+3xXQ7eoJKQwtGbTgjwbd9dTOm6eBkLi4Jcb7SCOQp6OrtervRlc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335955; c=relaxed/simple; bh=ssDqcCgzEoWtlVVfnRDhya+2gXFCsOmvrBa6MVz4QOY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XVeKonpQHJ/vv7Hw9ypm9tAiJHOYWpbOBIEa66vUDx7EAivjAevhM/huPVFLNlr4byM3vVRQkGusCk+6agrozK7zdX2slKpMarzSnSK/lufiM+o8irxTLowkuwk5GgzZQbvZd28ncOdeZoCzs0v7GZ70hPm7FuQ/K5VeVJaXODg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=IzafjUYY; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="IzafjUYY" Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BG7CEF0012568; Sun, 15 Dec 2024 23:58:47 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=q DexZD0ryRFyegN1Eft2ZfZa921SAV6HTxGNha+KCZM=; b=IzafjUYYqwepG7vP/ LUGJAFe9Ozsl8QYZa4uZbXBotEMAr6v7VAGueJ7/hY0nyTLkte4FQAPyI4bI7dIP f+sellzxHf9dOV1F7H8BVOxObfYgl3DdYwxQZLi6Z4rJPTYFQD8M5H4X659pNKnT 1ZpH2evBrj7pfOfvS0DzMdcqfIlHam9MO57T7k9FjZMstX/6W+GjWtKc2JbKP5EX 6RfuQ6pnYOwIqWnOQiIr8YRNu+J1L3Yl+PC5yvLeIfmLd/ZLIBWA/RCsu1ReyU5A jTiGohfQVuNoN8XnoBy0ybhjrmYX9Gkdq/Q6IJl9yzqi1wiFtOm0f1BkZ2md93bP lMqzQ== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 43j6am85uq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Dec 2024 23:58:47 -0800 (PST) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Dec 2024 23:58:46 -0800 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Sun, 15 Dec 2024 23:58:46 -0800 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id C85443F708E; Sun, 15 Dec 2024 23:58:45 -0800 (PST) From: Shinas Rasheed To: , CC: , , , , , , , , , "Shinas Rasheed" , Veerasenareddy Burru , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Abhijit Ayarekar , Satananda Burla Subject: [PATCH net v2 1/4] octeon_ep: fix race conditions in ndo_get_stats64 Date: Sun, 15 Dec 2024 23:58:39 -0800 Message-ID: <20241216075842.2394606-2-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241216075842.2394606-1-srasheed@marvell.com> References: <20241216075842.2394606-1-srasheed@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: rQU4JAyjZBOP_xFLS3UVZjRuRNdI6Jnb X-Proofpoint-ORIG-GUID: rQU4JAyjZBOP_xFLS3UVZjRuRNdI6Jnb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-Patchwork-Delegate: kuba@kernel.org ndo_get_stats64() can race with ndo_stop(), which frees input and output queue resources. Call synchronize_net() to avoid such races. Fixes: 6a610a46bad1 ("octeon_ep: add support for ndo ops") Signed-off-by: Shinas Rasheed --- V2: - Changed sync mechanism to fix race conditions from using an atomic set_bit ops to a much simpler synchronize_net() V1: https://lore.kernel.org/all/20241203072130.2316913-2-srasheed@marvell.com/ drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 549436efc204..941bbaaa67b5 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -757,6 +757,7 @@ static int octep_stop(struct net_device *netdev) { struct octep_device *oct = netdev_priv(netdev); + synchronize_net(); netdev_info(netdev, "Stopping the device ...\n"); octep_ctrl_net_set_link_status(oct, OCTEP_CTRL_NET_INVALID_VFID, false, From patchwork Mon Dec 16 07:58:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinas Rasheed X-Patchwork-Id: 13909344 X-Patchwork-Delegate: kuba@kernel.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 090F9171BB; Mon, 16 Dec 2024 07:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335954; cv=none; b=FvqVJ41+csWsNgpUQGLhD6piBdAOvKEWfYrhXo+5GMOjm86XOCiqlxz6/kHs3R1tLb+BYBlR30dkYqisz6yP4my5LNubJzaorRuiJct7nrfoufd/hsYXxq+VNBC7pZ0w3C64u0//cUnYqlGpyW6AehQe3EFPBVZtrI1a0N0JM/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335954; c=relaxed/simple; bh=YT4MhSWXLaJ4G19F08MIiBjpl/rMd8bcQ3wsbLUKSqY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=o7oFiVGA6n3p5+0wToVAQkiNK4Rme9iwd4KuX+J277f0GNCfFdQQOGYLb7nK4W++DB5N/26Bwx8NG3mK8J03BQsSRuMFgcaddHEJBF85A9uiGAj/odhvkN9DJUiGAKugXuDoe8DEbJEtsdMp3dEVAFSAeDFw8oV/CKaPvJmc/6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=DWg4xv8m; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="DWg4xv8m" Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BG7D0BT019859; Sun, 15 Dec 2024 23:58:49 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=R SFaqyBXq4nDGx2YR/iyM/tbb/ts8LDzba8h7rO1Q3s=; b=DWg4xv8m5nclFp4Zo JT4TTrl2zj8idlReIVWwYamH0UZTtMaM/ej7ziFHIwMwiSzu/QB0rOcYUoRcZMrx O9C1MZ05cr5IY+oDHOUg4V2BrQaKjfjKdEJIG03V3On5Xw356sq6bK9yaChGbKS4 YYBlipJMw84IgafuGA+KhSTzgnq/9Z6b78gM0tq8OfDt0owT+eEDl7JJotohGzqM ZMGOQi8aLrnTiVswybkySBcwMLT89+EdWSGVX9+JRgedh3FE60/Y4P/rBeQrrS8c xi9rm1ln93iP4DK/T3C/4XXsRbceYspF0T7jEomJCwyCKU67AoC9qV8K11429Eic HT5zA== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 43hadjrgtw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Dec 2024 23:58:49 -0800 (PST) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Dec 2024 23:58:48 -0800 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Sun, 15 Dec 2024 23:58:48 -0800 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id E3F9D3F708E; Sun, 15 Dec 2024 23:58:47 -0800 (PST) From: Shinas Rasheed To: , CC: , , , , , , , , , "Shinas Rasheed" , Veerasenareddy Burru , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Satananda Burla , "Abhijit Ayarekar" Subject: [PATCH net v2 2/4] octeon_ep: remove firmware stats fetch in ndo_get_stats64 Date: Sun, 15 Dec 2024 23:58:40 -0800 Message-ID: <20241216075842.2394606-3-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241216075842.2394606-1-srasheed@marvell.com> References: <20241216075842.2394606-1-srasheed@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: x2Aq5uedk_wEw3fmgBMOfZSiUmQ60VHL X-Proofpoint-ORIG-GUID: x2Aq5uedk_wEw3fmgBMOfZSiUmQ60VHL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Patchwork-Delegate: kuba@kernel.org The per queue stats are available already and are retrieved from register reads during ndo_get_stats64. The firmware stats fetch call that happens in ndo_get_stats64() is currently not required Fixes: 6a610a46bad1 ("octeon_ep: add support for ndo ops") Signed-off-by: Shinas Rasheed --- V2: - No changes V1: https://lore.kernel.org/all/20241203072130.2316913-3-srasheed@marvell.com/ drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 941bbaaa67b5..6400d6008097 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -996,12 +996,6 @@ static void octep_get_stats64(struct net_device *netdev, struct octep_device *oct = netdev_priv(netdev); int q; - if (netif_running(netdev)) - octep_ctrl_net_get_if_stats(oct, - OCTEP_CTRL_NET_INVALID_VFID, - &oct->iface_rx_stats, - &oct->iface_tx_stats); - tx_packets = 0; tx_bytes = 0; rx_packets = 0; @@ -1019,10 +1013,6 @@ static void octep_get_stats64(struct net_device *netdev, stats->tx_bytes = tx_bytes; stats->rx_packets = rx_packets; stats->rx_bytes = rx_bytes; - stats->multicast = oct->iface_rx_stats.mcast_pkts; - stats->rx_errors = oct->iface_rx_stats.err_pkts; - stats->collisions = oct->iface_tx_stats.xscol; - stats->tx_fifo_errors = oct->iface_tx_stats.undflw; } /** From patchwork Mon Dec 16 07:58:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinas Rasheed X-Patchwork-Id: 13909343 X-Patchwork-Delegate: kuba@kernel.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC1451FF7D9; Mon, 16 Dec 2024 07:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335954; cv=none; b=j+MPbwAPl6gSun4Z5fQ5L2K0MqtsmPmqVQJ0L3znnlQKI/oGZDf9F7zvdyGlWkRj/wCjCdhH8coIv3XX9ZaGRj2xMtXoclcN4/rudrbItnVL8tt2rvBuW45hj2sSzDwRnd0w85hIeUAcaUoTW3xRc4hUghef9lchgxPQ/a1TcGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335954; c=relaxed/simple; bh=L+Gtdbhy8yJh5XdrYNJ13jqwvCm+XEUIvr8CJlYQyyQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=us+cHkLKlBvy5zzv3dSdB+77MvBsQmoaPCbZXXnRTlk7ptR68AosBV+yTgl4s2qnojaVhEa+y5Vsfn8/Wh1QEboFvcxF05wYjjcbBbatQN9D3E4ToptCgkDlB7SGbfgZOdh+n58kIrbv1pu07s55p7pKbFLNbXoNboSowtAaSWY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=LQJbQ9uB; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="LQJbQ9uB" Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BG7CEF2012568; Sun, 15 Dec 2024 23:58:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=O M+al3o6cApvisGFEdMKQ3up9fNrnhkiTr2tJcYTiUQ=; b=LQJbQ9uB2NHECN3+x qE6BVyKQJOxR53dnEkn0+P9/XWu7x/8N7FXfxPcs22SM6kqRqvJnW3/6S4LwNRbk +3bJJntQF8pSX0DN9SPn3r5iymYv2Kcql2j3cYCfkpIFCxRXQtwr3YRklyXIuSYz eZB9sZlrEkLzo1wJ+emiy8Q2T0KDp8f4ki4fDrarrSZSLHxWlJTpUt+LbNv/jzea dawyPt/ryd7im+77An36D68nOQdngTNv00Lrf5H/wJHeOr7JWWiSL1IxVi5ymMNU GvKMHWeq9KbRaswgEYhMfi8fiZJeF+7umhaP8wqYyiSx9HJn1eBbZT/46VDtKay2 HVuLg== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 43j6am85uv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Dec 2024 23:58:51 -0800 (PST) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Dec 2024 23:58:50 -0800 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Sun, 15 Dec 2024 23:58:50 -0800 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id ECB513F708E; Sun, 15 Dec 2024 23:58:49 -0800 (PST) From: Shinas Rasheed To: , CC: , , , , , , , , , "Shinas Rasheed" , Veerasenareddy Burru , Satananda Burla , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net v2 3/4] octeon_ep_vf: fix race conditions in ndo_get_stats64 Date: Sun, 15 Dec 2024 23:58:41 -0800 Message-ID: <20241216075842.2394606-4-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241216075842.2394606-1-srasheed@marvell.com> References: <20241216075842.2394606-1-srasheed@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: JS8Nc-C82QeJjlorOwMUDxobu1Wl74Fe X-Proofpoint-ORIG-GUID: JS8Nc-C82QeJjlorOwMUDxobu1Wl74Fe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-Patchwork-Delegate: kuba@kernel.org ndo_get_stats64() can race with ndo_stop(), which frees input and output queue resources. Call synchornize_net() in ndo_stop() to avoid such races. Fixes: c3fad23cdc06 ("octeon_ep_vf: add support for ndo ops") Signed-off-by: Shinas Rasheed --- V2: - Changed sync mechanism to fix race conditions from using an atomic set_bit ops to a much simpler synchronize_net() V1: https://lore.kernel.org/all/20241203072130.2316913-4-srasheed@marvell.com/ drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c index 7e6771c9cdbb..e6253f85b623 100644 --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c @@ -523,6 +523,7 @@ static int octep_vf_stop(struct net_device *netdev) { struct octep_vf_device *oct = netdev_priv(netdev); + synchronize_rcu(); netdev_info(netdev, "Stopping the device ...\n"); /* Stop Tx from stack */ From patchwork Mon Dec 16 07:58:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinas Rasheed X-Patchwork-Id: 13909347 X-Patchwork-Delegate: kuba@kernel.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70C9B203D44; Mon, 16 Dec 2024 07:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335958; cv=none; b=oHYV/ldwE4CkU0A64/QK1KDIOmX5bGRL28VVa2gSuMasEin/uod0wyEQuCQgZjUR7/o9kerUjzR8yU6ni/muKg/OF0Yi4qKI2si67AE4iahzYz8C/4K+aYFxY8SyF8xVM2z2l3qI4lk8a0jV4haCLC+VDlifO1Z7Z6Mn+EO9saY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335958; c=relaxed/simple; bh=hWiwd352gG0Jk0qYwP9z+eCt7x1/kt+aXvZiIcs7bqo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HpwEGLFnTucVx91f0IMROKGJUIBLtljiO7VRqhuWxYKEcgLvkc8Amq5lw0wLz1aDjlc4O1VjX+5/wdRxPW+CjDbtF99LPBbLqL0ZRWGP2DE7dsP7Xy8TJpOY9giX58XQYH4jYALxHjJfqwZH/+KfJdyavZbugJfif/eHnjv5Kc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=IiyXc+Iv; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="IiyXc+Iv" Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BG7DmDa020853; Sun, 15 Dec 2024 23:58:54 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=o wPjE3bRvlhjpMJO1d2yUzHys/+I4YY3gxyhpf/M1bw=; b=IiyXc+Ivcb260XPS/ 5hCeFIPdMcuhnGa/7RjQ1uiJqY7H/Tg/qn2H228mHqV63zWRK0E5OvG2Iip6pdZ7 AVmbsnKgijTmlW9+21m4FfpIls3rhAQgjTlMDDtXMIKiI1GtHBXLuLpvuBKi5YCa +UgFEkRkD4Jn9aR1aQaBlA6ZYut0lAvW7uKNz2/8PE2Cqh3dsYSXYJZBkV2OCNe1 uI5gJJmlda+ctkzDtPW6EYukzmFBum7gXmFvmsxUObG4/HFGLwL7eBX/JtKTPNIN Ssg/Zuzugz1E5qtrDwY0UT44rN18LjNeYnP6JO4Pw3enbtQq2ObPe+nzb+beyUmY XM0YA== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 43hadjrgu2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Dec 2024 23:58:53 -0800 (PST) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Dec 2024 23:58:53 -0800 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Sun, 15 Dec 2024 23:58:53 -0800 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id 5AF9D3F7091; Sun, 15 Dec 2024 23:58:52 -0800 (PST) From: Shinas Rasheed To: , CC: , , , , , , , , , "Shinas Rasheed" , Veerasenareddy Burru , Satananda Burla , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net v2 4/4] octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64 Date: Sun, 15 Dec 2024 23:58:42 -0800 Message-ID: <20241216075842.2394606-5-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241216075842.2394606-1-srasheed@marvell.com> References: <20241216075842.2394606-1-srasheed@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: CG0_WbA_rzFsAGu7zIRDOM0YGH3TO9t0 X-Proofpoint-ORIG-GUID: CG0_WbA_rzFsAGu7zIRDOM0YGH3TO9t0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Patchwork-Delegate: kuba@kernel.org The per queue stats are available already and are retrieved from register reads during ndo_get_stats64. The firmware stats fetch call that happens in ndo_get_stats64() is currently not required Fixes: c3fad23cdc06 ("octeon_ep_vf: add support for ndo ops") Signed-off-by: Shinas Rasheed --- V2: - No changes V1: https://lore.kernel.org/all/20241203072130.2316913-5-srasheed@marvell.com/ drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c index e6253f85b623..75dd3bd2b9ba 100644 --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c @@ -800,14 +800,6 @@ static void octep_vf_get_stats64(struct net_device *netdev, stats->tx_bytes = tx_bytes; stats->rx_packets = rx_packets; stats->rx_bytes = rx_bytes; - if (!octep_vf_get_if_stats(oct)) { - stats->multicast = oct->iface_rx_stats.mcast_pkts; - stats->rx_errors = oct->iface_rx_stats.err_pkts; - stats->rx_dropped = oct->iface_rx_stats.dropped_pkts_fifo_full + - oct->iface_rx_stats.err_pkts; - stats->rx_missed_errors = oct->iface_rx_stats.dropped_pkts_fifo_full; - stats->tx_dropped = oct->iface_tx_stats.dropped; - } } /**