From patchwork Mon Dec 16 08:38:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lukas Wunner X-Patchwork-Id: 13909387 X-Patchwork-Delegate: kw@linux.com Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 201B31FF615 for ; Mon, 16 Dec 2024 08:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.78.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734338320; cv=none; b=Z8qDob9Ag5tKAvRuvS6DTTZxFMtJhBkNDZJZFXS+LRUCJldjEjMmIIgN4w7wqA3hT6TsJ+jgaP8131PXmUjK4USenRceaH+sxgDDnmU3AumA/RBgFvarC1meor026pKCEVoGXjR0YMxrNIexI+nJFv+Fm7mGa3FKFNNep7nTLnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734338320; c=relaxed/simple; bh=RHUufyQouFfc9Yt63kJIBMpJSz6NHu1pZSISb5Gqb+0=; h=Message-Id:From:Date:Subject:To:Cc; b=sG/QVu7UU2qiYufrhPsgk67/lcZjVP88S4Eeee1ds+AUchg4/83AmOZuE7JDYMgRr3zM0xoIQ1T0ajgoJG61eeivcNuE9K6Fw1lyiHAY8PICZ68fIGXPaDXc3YMArTE9svIgtg5laCTS1WSqvdk9ePwGCuXCkl+SKD09fw3gTwE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=pass smtp.mailfrom=wunner.de; arc=none smtp.client-ip=83.223.78.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wunner.de Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id F3CC02800B74B; Mon, 16 Dec 2024 09:38:33 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id DE3304A5CC3; Mon, 16 Dec 2024 09:38:33 +0100 (CET) Message-Id: From: Lukas Wunner Date: Mon, 16 Dec 2024 09:38:21 +0100 Subject: [PATCH] PCI: Update code comment on PCI_EXP_LNKCAP_SLS for PCIe r3.0 To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Niklas Schnelle Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Niklas notes that the code comment on the PCI_EXP_LNKCAP_SLS macro is outdated as it reflects the meaning of the field prior to PCIe r3.0. Update it to avoid confusion. Reported-by: Niklas Schnelle Closes: https://lore.kernel.org/r/70829798889c6d779ca0f6cd3260a765780d1369.camel@kernel.org/ Signed-off-by: Lukas Wunner Reviewed-by: Ilpo Järvinen --- include/uapi/linux/pci_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h index 1601c7e..521a04e 100644 --- a/include/uapi/linux/pci_regs.h +++ b/include/uapi/linux/pci_regs.h @@ -533,7 +533,7 @@ #define PCI_EXP_DEVSTA_TRPND 0x0020 /* Transactions Pending */ #define PCI_CAP_EXP_RC_ENDPOINT_SIZEOF_V1 12 /* v1 endpoints without link end here */ #define PCI_EXP_LNKCAP 0x0c /* Link Capabilities */ -#define PCI_EXP_LNKCAP_SLS 0x0000000f /* Supported Link Speeds */ +#define PCI_EXP_LNKCAP_SLS 0x0000000f /* Max Link Speed (prior to PCIe r3.0: Supported Link Speeds */ #define PCI_EXP_LNKCAP_SLS_2_5GB 0x00000001 /* LNKCAP2 SLS Vector bit 0 */ #define PCI_EXP_LNKCAP_SLS_5_0GB 0x00000002 /* LNKCAP2 SLS Vector bit 1 */ #define PCI_EXP_LNKCAP_SLS_8_0GB 0x00000003 /* LNKCAP2 SLS Vector bit 2 */