From patchwork Mon Dec 16 10:19:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sicelo X-Patchwork-Id: 13909511 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4A492010EF for ; Mon, 16 Dec 2024 10:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734344444; cv=none; b=Tsxv4vlw98A2lheT26fHsDebjEOOk0TlVmWEW6680g0c4xnLeW1Fgnr4bILirzvhKe05apjpI75WXF6lD2H41mB26rh24YXz9RNZ1iJM2shE/K+eNpBHuRZswK7IWDJ8H7zzic/4qq1z7O2y+PMAzRDB7TnrLf79+vxC8ucPJiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734344444; c=relaxed/simple; bh=ILZAYwUk/DSCT7EuUJZ2MMDiq7SKf25AU6N/814bC+E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RymrCSZcM4p2v9TOzqL3Ats1x5m/shz12IYJarW0+8cwkZ9wesjbnGsHQay+CZ4p2wj1Q9kzstg/zfDN9hYrxURnGDCJgDrIV0dyR19k0gsusfplKDFGxA6P2m2HlSBdOUI5lB/oFzUd/CWsT4+e233yYazALZIOdWqmghmMxYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=km6MY0Lj; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="km6MY0Lj" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5d4e2aa7ea9so7404794a12.2 for ; Mon, 16 Dec 2024 02:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734344440; x=1734949240; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KJsc4o1c6jnSv9LOCDTRbPOWWQRnItGG2p5/yupt4Hw=; b=km6MY0LjFEVsFcITArt+KcFS7RHzy0BDkBS91kMgIthR5uEa9x6lrsG0lOHO1n7+FI uR9oJZ8ws6+vuQvnbk0SxgJ4+QHnj/69SD8TdZHEBkyyJDFQb/cgIH366m3JmK7PnuyQ qn670om8YZ5+0zQ0M/sgfj/+/fnJ2lxQszcy7l7tAbG3o36pGqzm4gBP8H+UUv40c75t sUBjYFMGq6MrEUg/Lfkq6rnwgXxlbGLuprB6GBUk6OCenvv3Ohrh6oDezHhjjk7L0IFb nIZ5c3sP5o5EOziboPsqSWd9+7NodyXAhwwyaU1ctiuaChsGRQpaakdSJxROI04ZdYMe Wh/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734344440; x=1734949240; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KJsc4o1c6jnSv9LOCDTRbPOWWQRnItGG2p5/yupt4Hw=; b=b/sddAhPQtqL+eUQHb95FpIiBwBlehiTHSKWvh6Xs8bQz/ZHcbDXzJFEsJxhqzRyGZ yLN2qfCr2E18m2NPveG0oLvCrscafiGsVS8cZdlRd7Vdp/ykvAYfpdBA02EWdppd32iP SwXJLgQO+RwG2ijayyQbUdL3zuXI5MpyDkGkCVBP6sIsghIbsZiFzS7gbyBrd8pFVddH +87d4a1NxistLTMjT5rX6IPZQnoZW7FxEoui1bJpjD9Ze5e3f0RZtfLVknzR4fAK0Mm3 bs4aE0XbUvq442TBmoROYRiaAIVWpfe27ZQ6Cr0XHW4io0x62tk8PbQ679LVQLz+QrYf mgfQ== X-Gm-Message-State: AOJu0YztUm6nGHwVopkGKLJfdIYZuCHtCTeyLqTFmPTBrX9GoYRT1MOE DGkkw0CbQDwpn+TuQAvNDawxS5Uf9sPqzdtwvUdlqACAQFQA/aGY8ODutw5K X-Gm-Gg: ASbGncsAqRFGMWjb/lYxYW2aU06jGNPiyXG1TUTXUSW25EVJdX6qNz0b2TIhMbaSsgl sGPKvi3U8YbeWeREI2vHsUQQEfaIFMcEK3CjJntOBscZcv3Bpo/Mwni1Baqbm6hv6/am4sXKMbk 5a9CVkeP9/m/hVIy0UVtWYk5rlMrzJGvyjPWHZy0HeVS2jqL8ibGBoWhWCtJ9UyajkIn+qY+Yha ITdXmxr6OAEx3y7C/szcnFdWnw/GqS0c57qFmUDP18r29tLEuM+g4r4 X-Google-Smtp-Source: AGHT+IGcyK0pxLycJG6lmbRUV5Ec/9sx23ZXY2ijDp3BUltQk3KQ9o11Cuvip6wJ3evdlsE/1GR2gw== X-Received: by 2002:a05:6402:1f8e:b0:5d3:cd5b:64a9 with SMTP id 4fb4d7f45d1cf-5d63c3c08d7mr10886777a12.34.1734344439816; Mon, 16 Dec 2024 02:20:39 -0800 (PST) Received: from tpt440p.. ([69.63.64.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d652ab604fsm3026099a12.2.2024.12.16.02.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 02:20:39 -0800 (PST) From: "Sicelo A. Mhlongo" To: ofono@lists.linux.dev Cc: "Sicelo A. Mhlongo" Subject: [PATCH 1/3] util: ensure decode_hex_own_buf is passed a valid buffer Date: Mon, 16 Dec 2024 12:19:42 +0200 Message-ID: <20241216102021.345566-1-absicsz@gmail.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --- src/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util.c b/src/util.c index 53d55d7e..bfe46ef2 100644 --- a/src/util.c +++ b/src/util.c @@ -3181,6 +3181,9 @@ unsigned char *decode_hex_own_buf(const char *in, long len, long *items_written, char c; unsigned char b; + if (!buf) + return NULL; + if (len < 0) len = strlen(in); From patchwork Mon Dec 16 10:19:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sicelo X-Patchwork-Id: 13909512 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435C92010EF for ; Mon, 16 Dec 2024 10:20:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734344448; cv=none; b=Eo6ocr6pDDJfaNBfWb4u2GJwyWiUWCC/Vtr1fgH6Sw+RvsTbx3+S4xaxvKT6KDjdERpIN7pVRNMC+n5VYEPv5yqSGawd7LnRll6mrHfB0gbu5c8ZipgqPTyk+FLNLOH2FSbAPusAFWeIn2jm07tvc8He3bsGb5pjqJSGifw7/UU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734344448; c=relaxed/simple; bh=Z7FUISwGq3NCBE4HNzA5UaKjU//VkE0IqBFqt1tcncc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oxxndpN8PacpxFV2YkFc0bKCz76UJ02ClQEG4rR1UHUP+B3r2sMx6z55xnZuYYBYBfoMVGIXa6z0qTO+Elq10TUyiQbTHYFmKACkBfzPDYxxbi3+k0IldX4wlX+m9iTxpUGCQke/XuHse+pTi9OHdjBMioZON2aKBrumDSif0/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cb1CFNRn; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cb1CFNRn" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5d3ecae02beso5079142a12.0 for ; Mon, 16 Dec 2024 02:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734344445; x=1734949245; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5HaeFCI0v0RRUOYUOomKWEm8VK/jmjTKhzD6K3j9K0A=; b=cb1CFNRnrdiE6XU1IsM2CpkEPrL67SxB489jdPIIDuUx9tWSNYSHOYiK5osk05VGeU d/hDjn3hbpUYifTmj49lWwBUcF97aWZ+orTCuSkuK6Fwb+OkjtpqnWCEw/nA4J3lNVXo XNi0mZxJGmoGEXVOLxvE0n/0D2KymOyjOEbeSl04yVvSGREs7eL4coWC9fmleOUKoOmp 63hZ3jhWfeFNXAZMChVSRk5dx1l6V2I43RnYAYFNWSt3b9zIGzkvC1gz2jaizmB3J+jw 1n6yItCOHsNgH/iGDY4bQ4kOwyR0k5+kTJwGPF+TS8xZwXg0aS6ZWy/jK/mEiZV4AIbb wvBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734344445; x=1734949245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HaeFCI0v0RRUOYUOomKWEm8VK/jmjTKhzD6K3j9K0A=; b=jmeV0ECEd9mEtirKOYJTn29VTvbG8PRQ/33cMRUN7fYvpogvx6CuuVOo/pWEPLX8QH QtLrAoevdIidPIv5237tNJo3JJXTWe1DHim/UEpZ30bQ1uqZh0Osw0FqgfAUiLLrScDJ SzS2BLlmrUgkCjyW7WJ6DH2askz47vehpupIzw7Et6A0bMuRoZfoQoovP8QnGDwDdNES muEiORSm7J7kY1LTq+bwcbKtnvhAfkhthHhmzwiyOahpzGmwN5QYTNmlyZu0qGdx44nV C6WzmA6HEoe21S8PwhxP+T4yU5glybDvBvh8/yDU6jKzVSBddqzxYM5F8+Yon3BDC3pQ 6GcQ== X-Gm-Message-State: AOJu0YyZ3pkXxtGcWS/8zaQ1TFcuH7kDB5RHjwsZ4UQnbZjTC1GP1m9p axRErlKeH/qvtNFxyIKmKnoIdDMrlXEhSa97zM3AcesjJykjzkEd2rS3/bj5 X-Gm-Gg: ASbGnculmkyb6HUxiXSCURUcCEdnIfjhtMnNNvSRlUlWE4jZFSHIO/ZbF1Q1mlD2OKf iTSni5A7nhcE2OR9KlJUX3dHvu+ed9yFmxYGzoNYJC2mCjwYBdfyIuDSmIKj3GrH/LWtolV6fDI n4HG/S8WAV0LLChzGbIXeUb0oc7MGPgfnuDaDSXMDoeguX5TEKwysB1q9p9/JSrnHIUBUNu3E+I iXY4STSlTqK3CSFXXy2nP1660rTRXzYx6Eyd05tpSqRILQJwLO62P9T X-Google-Smtp-Source: AGHT+IEys/8VmrV8URIufPxa91LdRtfuRlvtGtuTwpQKy4a1Zz+RPJZrgKYnlRP503mmtQebC2u8Pw== X-Received: by 2002:a05:6402:3550:b0:5d3:bc1d:e56d with SMTP id 4fb4d7f45d1cf-5d63c3bc40cmr11172255a12.31.1734344445498; Mon, 16 Dec 2024 02:20:45 -0800 (PST) Received: from tpt440p.. ([69.63.64.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d652ab604fsm3026099a12.2.2024.12.16.02.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 02:20:45 -0800 (PST) From: "Sicelo A. Mhlongo" To: ofono@lists.linux.dev Cc: "Sicelo A. Mhlongo" Subject: [PATCH 2/3] atmodem: ussd: ensure ussd content fits in buffer Date: Mon, 16 Dec 2024 12:19:43 +0200 Message-ID: <20241216102021.345566-2-absicsz@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241216102021.345566-1-absicsz@gmail.com> References: <20241216102021.345566-1-absicsz@gmail.com> Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes: CVE-2024-7539 --- drivers/atmodem/ussd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/atmodem/ussd.c b/drivers/atmodem/ussd.c index 32a9fe91..775c74d1 100644 --- a/drivers/atmodem/ussd.c +++ b/drivers/atmodem/ussd.c @@ -121,6 +121,11 @@ static void cusd_parse(GAtResult *result, struct ofono_ussd *ussd) DBG("response charset %d modem charset %d", charset, data->charset); + if (strlen(content) > sizeof(msg) * 2) + status = 4; /* Not supported */ + goto out; + } + switch (charset) { case SMS_CHARSET_7BIT: switch (data->charset) { From patchwork Mon Dec 16 10:19:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sicelo X-Patchwork-Id: 13909513 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E6F42010EF for ; Mon, 16 Dec 2024 10:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734344452; cv=none; b=X/mSc4VrQ03ScAvMipzFpJyrLdno8XX/j55gr7fcFgMGuz7A/aGNoxILTFV51k+N6L/LDEmF0BeDK+2cnNylu1WCio+MkzUt8HhPRhfrjV9+kXjvhOx8VWX7gJwR79GQ0iLjZdaHfvdXag9Lu59sDpS6X15Z2wwQRsNqWd5+mfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734344452; c=relaxed/simple; bh=sUjNE2HMyoX4vb1YpfYId71c4OT4L/kFHF/x3yQZY8E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JMOKpivDL2vywS1aPw18OIvPOOVGxiNxJEHCCJCAJCTJyaAx/svqaMuIC8uJdNOQTc546byKgGUUZviqyFsEHgTmuHUFOIuvZcfXZLimMUdEocY17SiCVY8kkymNVSCV94/ZSUFSiUr4kYZHrJ4Rm8uDkfFOhCK3zdcSg02DZP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZJ6uBdA+; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJ6uBdA+" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-aa6a618981eso642982366b.3 for ; Mon, 16 Dec 2024 02:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734344449; x=1734949249; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NevN2wwzyAP5C+vyw3UFiYN66h6ehOD991ZX3ZcigO4=; b=ZJ6uBdA+/4ZvHiH6E98v+l7pAfH/X/07eMNxUn3pE7JS3E1Pw6cXOYB85m83xFPNG8 iph1r+hH2D0Rhtjd5J9Md8k9DC1o5/ycAx4Z0vHQSLPuJ+a6aqtBZ7uMLK7pZTdYCWWH UxeS9uNV0jjf/PHLYHjDbu7UXNd/VgLzyy7OxQgqVCtBrCjlfK+4yMQQh21/DKbe5zFA E4eQlbxcUoQ1aatYEWA+C/RQZgBst5smbeXD+loP0ituZLNZwoyFBIIwfpsl5F5SHuad 3T5P4Hz4xzW7EwR+ItCzVx17YRZO/YSYPXaNlXIXLowgDe0zT+lkJhTK/ATEiVFdccjG IaqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734344449; x=1734949249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NevN2wwzyAP5C+vyw3UFiYN66h6ehOD991ZX3ZcigO4=; b=SWEXJ1Zfm3tINGbhqXTukTfZOZie99vC8oNy2epFTxIr8YUZ4LqoKXhiQVwnqWM7xx ZymisCI+Ysxoj+VymkFO5CzC2aFzNKDcC/lMmCRChyufgT6DuaYDjNevXHNN4TcaZSpn CJHMw90NKryFPJuMTns4ldSpiCe7ZcK+NGezWqDDELdHujNHrVGo8JN52+MNsm4t8j+N 3dap6X2qAJAs+lAfvg657uQ94iVJaxqqFa9rGMFWKYqav0XTrIS1jUbm8bCIeCm+AZzF GCgayLl0t04/1cDEgwMbe/HiZpIv94WIOP+q+CKEDyJ0mA+K4s0Ep0NVOAh6r0RDuZa8 6iUQ== X-Gm-Message-State: AOJu0Yxd6hgtz3yte/5/dg+iAI3gj84XczYK9lVNzPi7zD2W5Wxn7Zmd p5wnaq+vTLO+iqztjf6jktzGlbbATo0U5J8yYVtnrbXUuVZEa7upOYpu+AGn X-Gm-Gg: ASbGncuaPZqSENcUrSdC4tbULN6U0TCGe2uvjawICS5xiPlD14m8nc2j7uhSMfQs9Lw iRfIFYvzkheoCZQRLu386TOJTcxiUA/9jWYwP+76NDVHJmJyvHBhjDErZGlPBZeRof9nEY+F9Ao FnM0qTuRz1MWRledvg+39GQruGPINJJRmHi+NuweehYKHX7M22lAKkxrF6yS8VwthH4kJP5JzmZ Hs6BcgdWcuB8Ymfhrx82q76hDNKXE43SqVQpoNJHfrq8ZqgmzYC/KXy X-Google-Smtp-Source: AGHT+IERPaS8hNu4lQWrwrUCHLQ/mNpvpLFY83CAtc00iPFHwvk9VNwwRGUs7iHOdibnHANblDy7ww== X-Received: by 2002:a17:907:9450:b0:aa6:7d82:5413 with SMTP id a640c23a62f3a-aab779b3f5emr1219086866b.34.1734344449017; Mon, 16 Dec 2024 02:20:49 -0800 (PST) Received: from tpt440p.. ([69.63.64.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d652ab604fsm3026099a12.2.2024.12.16.02.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 02:20:48 -0800 (PST) From: "Sicelo A. Mhlongo" To: ofono@lists.linux.dev Cc: "Sicelo A. Mhlongo" Subject: [PATCH 3/3] atmodem: sms: ensure buffer is initialized before use Date: Mon, 16 Dec 2024 12:19:44 +0200 Message-ID: <20241216102021.345566-3-absicsz@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241216102021.345566-1-absicsz@gmail.com> References: <20241216102021.345566-1-absicsz@gmail.com> Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes: CVE-2024-7540 Fixes: CVE-2024-7541 Fixes: CVE-2024-7542 --- drivers/atmodem/sms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c index d994856b..0668c631 100644 --- a/drivers/atmodem/sms.c +++ b/drivers/atmodem/sms.c @@ -399,7 +399,7 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data) struct sms_data *data = ofono_sms_get_data(sms); GAtResultIter iter; const char *hexpdu; - unsigned char pdu[176]; + unsigned char pdu[176] = {0}; long pdu_len; int tpdu_len; @@ -466,7 +466,7 @@ static void at_cmgr_notify(GAtResult *result, gpointer user_data) struct sms_data *data = ofono_sms_get_data(sms); GAtResultIter iter; const char *hexpdu; - unsigned char pdu[176]; + unsigned char pdu[176] = {0}; long pdu_len; int tpdu_len; @@ -648,7 +648,7 @@ static void at_cmgl_notify(GAtResult *result, gpointer user_data) struct sms_data *data = ofono_sms_get_data(sms); GAtResultIter iter; const char *hexpdu; - unsigned char pdu[176]; + unsigned char pdu[176] = {0}; long pdu_len; int tpdu_len; int index;