From patchwork Wed Dec 18 10:29:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913369 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E9F11DFE0C for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=fJiJ5el9fpNscA5CjkeFj41A63vuG2xtyGaurHO34DlBiBv2WU4R+KHPY0lSYEpESzxKCBA10CB3+D/zTqBQkyoqX6Y1jpQbY9lHfRCw5dJ6tcM0TR0EPwy2Jn5Pk42/9TjjraAT6TZ2fehSMYsELWLwW7wUHKwv2T5lOZLiiRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yywic2yj0AJExnTldt2oR0KLRW6vzHInI/ygwIaOGdVJJVgP1KGvmuvsnJre9Rl7SnE/Zpl5uBe5+SO/HpBTD8lv6bX4fFRtoR7mYmr6PD/B3Mh8GyABtpkbGlV7cswcNhpZN2mcH6A6xjxJijBDUBAisyVicqsLYkA2ASxaPHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cJ1py/yL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cJ1py/yL" Received: by smtp.kernel.org (Postfix) with ESMTPS id 2C66FC4CED4; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=cJ1py/yLEhR5Baa6p5PEn5mGlGfPXKEbJoH6E9MndQJ0yiBlIjfaVqbGfNZEVkEf6 0lSHM6Yfg8e2AFFFWXHkLdtHOVtyqOZgATj3K006uv/7vcgZdCbm4Gl4QqSOf8x1Tr eiAN0TqU0I40+0nwVdx6CWvhNdhArtbIkqP/VwToDCnR9eTTrvTVnjfRjOsJZgf16+ Vq3g1uYuYZ/SOzC3q6s4oueh/KTsIBqLD2hckWroCMGna7uYEgQ/i+I4g6XfXpsVJ2 5jblcsSpyVlccWxFnZ2C4fqcX8/gv+ZDuBGPA2Rk4FZIik2QFLBr/Rf24y0qGKFtj3 1oIfFqAVy/8Fw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 153D4E77188; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:29:55 +0100 Subject: [PATCH 01/12] Kconfig: Add error path in conf_value_to_yaml Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-1-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=1224; i=joel.granados@kernel.org; h=from:subject:message-id; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipCvz1wWmZEZZi5o483Dz4xKiud6OXcXxQ KCwDJyO+BRUiIkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQrAAoJELqXzVK3 lkFPnYEL/01tgYp2GYYNMRI5uF5MJH6jcZWuHSDVpJFaH/wDq8ATxBNf3N7w8qa+zlhUK/vDbQT DHOnSSXYwHMySR1491FITI0up8nDub+XunxYdQmEXWdkQ5TQfezIsFpQP7+N52xlt/kIZab7gKi jd89QKMLoEpA+C40E3CzIjimuEI2SLhZRI0FBjNtHGoy1Yg6kv6hlDhfhCQDZUCm7L0t2WOidNz 6yP2SIDss3X98e9XFVxv77VlWOWaLVtR6CaSbn56N9lJaczgoCyStTsNo36b2vlRc7oX1HUxC90 MSefx5ByGl8B5kSZjaSUfeP1KT9tkUTuF/KUueIJSS/i5QMgpWscT4I+Ik2fOEQ4Awtmpa+FauZ 51VqdVHtYUPERjX7M2o0ed/zxLmd8TneMq8Ay7UVRDeeCHHM27m7TgTkun/csVqyuNhe2PHH4BF 7yh+I/qOxtLHCX944qo62TSL/NqkJ7peOYLep7AcTrmQw43G7Wi+5KThuji1ZtXeUgPpvsq9K66 Jw= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 The asprintf call returns -1 on error. In this case the value of yaml_value is undefined. Return NULL, so the caller can handle the error. Signed-off-by: Joel Granados --- scripts/kconfig/confdata.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 0156b38..49a5729 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -669,14 +669,14 @@ static char *conf_value_to_yaml(struct symbol *sym, const char *val) yaml_value = strdup(val); break; case S_HEX: - asprintf(&yaml_value, "0x%s", val); - break; - case S_STRING: - /* Wrap strings in quotes */ - asprintf(&yaml_value, "\"%s\"", val); - break; - case S_BOOLEAN: - case S_TRISTATE: + if (asprintf(&yaml_value, "0x%s", val) < 0) + return NULL; + case S_STRING: + /* Wrap strings in quotes */ + if (asprintf(&yaml_value, "\"%s\"", val) < 0) + return NULL; + case S_BOOLEAN: + case S_TRISTATE: if (strcmp(val, "y") == 0) yaml_value = strdup("True"); else if (strcmp(val, "n") == 0) From patchwork Wed Dec 18 10:29:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913368 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B5411A23BB for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=hEpKavlrF4WxoLh51YM7dwzA5LnRFHBDiOwgmGbWvBePC2N78C05SQ2vTT2QIb5HHgqCYTbnYOAPCaXDjBBlxkRXH48jOb9QM4Sqr9leXEYSRWeL10Ja460SddwrYo47kTNM9MvzfAMOPIV/csSoZJeN/+X85oJltW9JiOB8VYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=l6fdWgpjKbFsO8OSF2C8SwibeLtb/ff0owgRzjJFREo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A2QgEuhiQw3ew9A9DEzsFGzIxHx34WYQRBcuDIIRPo/j8pZAiiHlknMsbIFbktf+9mu5FIrxXp2PJ1Vq2+2vSvVuQEt2zrGrMV8zFUtitwb1YgaVKKja/P+OLGRtFV46Hli3CMe77nzWn9FBmTQ6WcOxe0PKP4Lxl6t/IUcPUZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YI7naJ/6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YI7naJ/6" Received: by smtp.kernel.org (Postfix) with ESMTPS id 430B8C4CEDD; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=l6fdWgpjKbFsO8OSF2C8SwibeLtb/ff0owgRzjJFREo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=YI7naJ/6mWLxv08NfwZIaaeqCcVbyuIcbQC+doRFgmb2TPMVMFRVS3CxGcMadJpF2 8pVB8PHiZ4RrZMC6LnYxFsMoeMWnTghHeRys47L9AZoWEIX4CaQAZ/ZichY2jC6Upd NPpnA6w8vmU3dbU1DS5jOYuKIY45gFO67WG/IotVmLAtdMlFhATAHarLVnP+Vj1r2m FttV6yhTeoHbmHNZJZ/mvNPh1rlA89EMkkOCKgKrW9RXej60kbTQtYF2YEfHQpN7cZ l0giOTSEKzBfBp/jSGhsofg9WtxhtONsRh7fpGpsLvPd3jOM0jWOW093f30Q6QBXD9 RxLYSJ2vw4wzA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21160E7718B; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:29:56 +0100 Subject: [PATCH 02/12] scripts: Adjust heuristic to see if current user can sudo Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-2-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=2158; i=joel.granados@kernel.org; h=from:subject:message-id; bh=l6fdWgpjKbFsO8OSF2C8SwibeLtb/ff0owgRzjJFREo=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipCsPpkIX2JhlRX+z1rL10+Zhgtf+4MRzD AENts0jzDlM04kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQrAAoJELqXzVK3 lkFPuZcL/jSPgS8nN0XdsUdhi40eNWjTWD+6rPmZ90OgmAjS0Zj4f7rpcTX3nQN4lBHbOYM/KXs KOZcYx00ZkZUjoBnz0furKziOeA0o6HGjHODWs19G5P0P6RfT/w48EPSTvDBaKoiuiOqEv+P84x YCq/61C3OqY03Y06Pqq1DYKhM8wwFle4Wj8deifpS6MeowsZepV6Rre57qRO1TQXJ9SSqeNqPHZ 5AcEwn5jykIkES9VQh1e5RVdlP8Z2WlbET+GS86+FLbXo6Ialk7T7y+RtojjsuA8NRnRJ09pv4s ueV9wxC6W3CA5umovDZaoUfWsW8FliWAQtWEaWQzrZSq+aSntVjRDyGy8mP7NrapUB4RGLohfHU YM/BOI+5JxIuwr1+euvlbuWjgujom2Dn4kQpBDNYNQE0u/K7kLj4QrN0ve4Ix0neq2D5uajTEkl gfbXf2tS/ELYlb6Q5wcv0RvBMKD0Ur7HpZNx2kULqL3U2VqDbYwSUS7O0vt1VqmpBdt7AAv4M56 rY= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 * New heuristic uses the following sudo command options: -n : "non-interactive"; will prevent sudo from prompting the user for any kind of input. -v : Update the user's cache credentials; has distinct output for users with and without sudo: 1. Without sudo the output is "Sorry, user __USER__ may not run sudo..." 2. With sudo it has two messages (with and without password). But we ignore the distinction as both of these mean that user can sudo. * Avoid setting SUDO_ASKPASS. This env variable is suppose to have the executable that will be executed when asking for sudo instead of a boolean. Signed-off-by: Joel Granados --- scripts/libvirt_pool.sh | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/scripts/libvirt_pool.sh b/scripts/libvirt_pool.sh index f8c309e..ffae928 100644 --- a/scripts/libvirt_pool.sh +++ b/scripts/libvirt_pool.sh @@ -1,6 +1,26 @@ #!/bin/bash # Helpers to work with virsh pools +get_can_sudo() +{ + # Heuristic to see if the current user can sudo + # -n : This is the non-interactive argument in sudo and will prevent + # sudo from prompting the user for any kind of input. + # -v : This tries to update the users cache credentials but also has + # distinct output for users with and without sudo: + # 1. Without sudo the output is + # "Sorry, user __USER__ may not run sudo..." + # 2. With sudo it has two messages: one for paswordless sudo and + # one passwordfull sudo. But we ignore the distinction as both + # of these mean that can_sudo is "y". + if [[ $(sudo -nv 2>&1 | grep 'may not' > /dev/null) -eq 0 ]]; then + echo "n" + exit + fi + echo "y" + exit +} + get_pool_vars() { if [[ -f $OS_FILE ]]; then @@ -10,10 +30,7 @@ get_pool_vars() fi fi - SUDO_ASKPASS=/bin/false sudo -A whoami > /dev/null 2>&1 - if [[ $? -eq 0 ]]; then - CAN_SUDO="y" - fi + CAN_SUDO=get_can_sudo if [[ "$USES_QEMU_USER_SESSION" != "y" ]]; then REQ_SUDO="sudo" From patchwork Wed Dec 18 10:29:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913367 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E38A1D9A48 for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=k1m1PPYFTKb9yyYKwp+DWV0ExHowjJPNOlc//z48B3nUeFeskIfCfRiye1Lk/2l+ge6m8ajnUkKUwJG7TnXBxnxAHdjM7Y9Sm3uakfci++48bWSI5oefRCIOoA803g8vwLU3vpmFBL+DqXZzsiOFu4xP5tOfcVfheZaOMzIeRUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=XsFfSuOHOo7PdvXANRbQAmVGYrxSHmsJL8YTfwlMjVs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=skHemeJvmWJ/4lci2kCAzMwnI/QKTpgfEdrGRFscwQZKPb/ZWNAIuRbztkmF/8sqhZWtGWIGzndTjpGph3ga8BN9JgnVYUtxag/rMx6uJMuG0+/efYmiVml52kcncCzaaSRvZ1x+hjtAmLC2r0MO3iyHFe8gzeDdewhoKhgRG/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q/XVe3Gw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q/XVe3Gw" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3D871C4CEDE; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=XsFfSuOHOo7PdvXANRbQAmVGYrxSHmsJL8YTfwlMjVs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Q/XVe3GwQ2/Og9zUB2V0dzCAPCnr+6zgsf5UNNb8sAj+loBbqSJad/6VO5uDkfp7z 9IKSqif/huiLQSMcYxM+Hq5ikjUsC/dY8092uc9UO5paf/Nr3IAMESh9aa2Ea6S/5+ Ve4YfdcxhuyI5NO85ufiWCA4j/f6hiwzJjd6ZjsvwH+9xkSU1Rxp1isRi/Xedtby1N w46gla+bYBIT3ngZJB31KBvRNcXtaGVRbLg/E2AxkPsr6YQMNMOCNqT4n3o2eFDMDO bKJLUQxNy8lDWamW8zqlTUBHZ20j783kPVYq4OK+jzdjuvaY/QFOwLowBou6GqexFf PRMs6QLBOaTYQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35032E7718C; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:29:57 +0100 Subject: [PATCH 03/12] ansible: libvirt_user: Install additional pkgs for debian Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-3-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=1055; i=joel.granados@kernel.org; h=from:subject:message-id; bh=XsFfSuOHOo7PdvXANRbQAmVGYrxSHmsJL8YTfwlMjVs=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipCxwO69w7Vp2qva3tWlzugL0gj/d01iO9 7r4RPbzRYB8x4kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQsAAoJELqXzVK3 lkFPMBIL+wRoqMDOlRiF1oJnbjYUP4sOFNjSuid59226mRUpQ9sjmFhYis0rOx9xJBMqFihHpYY 64aYFaF/e9JgW9jeLXyrZOkS1Lq5y+2q1mJQDi6OrtOW+iZM8ijC6wvH6K0hiFTLPFj8dAcwWAL E2adFfYz/p1GuFRXcKYkt7I7Ov7S5IE9A3qd/ivLXYf+gVNIoKVZHOLdYDqwuQKmo+nAeWtxyTZ 439YleEu5UQXroKTBVSBrW1/lHVTkuNtYKslHs4fD/82eBRJUulEDoCz2VGPTXH7AAT8Vrw7E6Z NwqXyhSn0GKahIwI5Ls0m/lFs8AuyXBZqP+6IRqkSmmlCrdB8hGz/i5EDf1hTPS701ihgUf1Byz NexREccKYxsB/d+GkCuopCFXEpIDutAZbsQmpwBhpKBpEkBtLXgGrKms3RHDiJgx9qW6kGh/lhY 2/hRPkqq9FI5HP6U4gnTc1o6w4WMn3B4OHRLXhBrK/KBIlQepNHsP/PkG1jijYjHw9PUrUxMZp4 F0= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Install the following additional packages for debian * libvirt-daemon-config-network: So we have networks/defaults.xml on the system and are sure we are able to generate the virtual network if needed. * guestfs-tools: For when we use guestfs directory. Signed-off-by: Joel Granados --- playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml index 792597f..98d0007 100644 --- a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml +++ b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml @@ -13,10 +13,12 @@ name: - libvirt-daemon - libvirt-daemon-system + - libvirt-daemon-config-network - libvirt-clients - qemu-kvm - qemu-system-x86 - qemu-utils + - guestfs-tools state: present tags: install From patchwork Wed Dec 18 10:29:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913366 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CAF51A2544 for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=mbqvw8omQh1DO8cGHzgrJvadnFDI4ymBXpa62FtJzJRM2s/R7EPgaWKWq0UhIur0ahUKW+3qyMW36sn9UxkaDAFuqyeQp/MRi8/yW76oUxIRg1emk8E0dlPnDwHB3mMct/Occ2kg38qnDRvWh5IylwVdGM21PXqBwpFO8hXc+t8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=Kt0zBkpB+Wq/cF1K12NdeZvH0eWmgaNhm+yWtxTqcHo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rjlko/RG2oZPBxd5qSrJyntqXdHLQn+ApPZmMMuMxDgcCW6ldAh9A8dB8FkGT93B1xQ1UnBDQRJKUmfN+OgOpeEDZwuC+sNTDgYshoVpb19B8ihh8scQ71XEXlPAvyTPCDAZ05vYFL1V3GC+UMZE9geOj1FQbHHyEXjo1CwSrGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZasS2oUV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZasS2oUV" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4FB83C4CEE0; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=Kt0zBkpB+Wq/cF1K12NdeZvH0eWmgaNhm+yWtxTqcHo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ZasS2oUVfBGwFuCD/3wsm2kCxoc/WZTHyFuwsWgohvjZk8x5jAzK0WCKXLE8pJBwv I8igXYPqmiww1yYZXvupOz5B3ExWxf4JmcUddrIiRZrgb2WeSdmZ9rvN5RwI3QplPZ 75WQth7zU3lwqwQ1ZvglcINjEYTE/8U9R9EZ70noNAYKNeU98n+U04tNz2RmiV2NGr ummeMofU3FKOjB/FQWJw7sP3mCJNmekr3+ZIfQbecbR7krQXMWP4Xjr9sHlWp1gpOq UlVDoevOyzmAs6sfctQJABpbe+HMiRIZbCb1p5Jw0WaXrpiYUWDm+Gfz+6EjTPza/W /OL6YfXUFnT9Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46398E77188; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:29:58 +0100 Subject: [PATCH 04/12] Makefile: Add virsh and libvirtd to minimum dependencies Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-4-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=559; i=joel.granados@kernel.org; h=from:subject:message-id; bh=Kt0zBkpB+Wq/cF1K12NdeZvH0eWmgaNhm+yWtxTqcHo=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipCy0uiYOlG+25TwBqI1CJcSaX+aGnTDHm lUzR5cOo27GaIkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQsAAoJELqXzVK3 lkFPSAcL/i77XX3eLwproRtsl2ol5fTYtfBOza7ek+DuU56YhkLXQ+6oX71arZwjdZyki6PFeCJ FYVv58IDauE/soUHFJSIhxZlf5ZyiraUu7fjzXJp8OVH0vNKRvXKY9cN5pdRyaaBbgDMshz//SJ yAPuI31SHz7GFnY2X1I0myQm4QowaSOGDeCqYhxP49ztlS1QYf+ggC4JU9HiHsa6l2ZOLSbIUez gKc/A4PQ09B3vBaOygyXUJJlD2ztkvSNRfWZnSLMjG3u+cBDX0tK7PSwgVv4YGSqXUUVZIXTKcj 8YKq18ds0YQ//XARV8xg8I6UBzvVxCUm/uN2g0zCROvFvnSiLkTDgZLupXBt/FOW/Zdo78CorKY RdDLLgkoinDy6ktndZfnto7lpaGPuC1OaI4+hL4DtZtRqLKATpUYHk+BR5KK4fZdBwhx8FHYi4f 9fCla+AM6nI+2cmISzbKWJoTjd3Dr2WeaoQ8Hk+3Ue1AYSP/3Ez/rrM7neVNVUtCFH5t+LzoSM8 3c= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Running scripts like bring up depend on 'virsh' being available. Signed-off-by: Joel Granados --- Makefile.min_deps | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.min_deps b/Makefile.min_deps index a1cb99a..d1251b4 100644 --- a/Makefile.min_deps +++ b/Makefile.min_deps @@ -13,6 +13,8 @@ BINARY_DEPS += ansible-playbook ifneq (y,$(CONFIG_KDEVOPS_FIRST_RUN)) ifeq (y,$(CONFIG_GUESTFS)) BINARY_DEPS += virt-builder +BINARY_DEPS += virsh +BINARY_DEPS += libvirtd endif endif From patchwork Wed Dec 18 10:29:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913374 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E25A61F37A0 for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517813; cv=none; b=bd15vRXljLMzXTRkCjRQXBg2189VM7/APhxZihWbHJp5OfER0rm83gMWJAS6vPXTu9tMRDP8zgOWM0Vg1AZRFXzupnQyf+KL2KWpx/1V8UHdE+DZW0nkphg+OIX9BtO3N5JDwalqnDluYEOhNM/pKvj3rs7Pf1rnUlXQXeNCrSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517813; c=relaxed/simple; bh=Kj8tG89mwj8PU4V97afgamZ3sTf5UN0mvrsoVFXiIVg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SyAfU+w05IoAnvEFGUdenhJ4essppiB4a514Tng23IZNnLyJbx8iCOn5F0cCbwHu1q0vkY8hFriahhdDTH5Hz6gBPNLWkXmS4PHvPcY99H4hji7UCsIKDGPyCG+2XiJ+0Qhl+wJkPxh3fzKmWF/yde+NFC9WbMmVutpWGaPTdOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qMCux50i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qMCux50i" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5AFFAC4CEE3; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=Kj8tG89mwj8PU4V97afgamZ3sTf5UN0mvrsoVFXiIVg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=qMCux50iYvZEMyLaMPSfWPTZt7nV60EN9wxnCWY+QLptVBu4A68POSrmPhHlYWlNQ hbvWqytxin75dGvNhSXjKzDU+pDd/mphYTjNImleav2efV+cC0pxTujg0f55IXrXG4 5EsZNuSWVV21nXO+CAe2lDkZqhs2/LKEUiQi8N3QlHQynIAdYgd4G19JetEuERg6Rw XU4mkcNDaScgEjXyIOp0MGadd80D+kaDIO8jZnx48k2RLY67VzvElCfZmwHpNbbJKC Yo8CDDDRTeVD8P9N7B06uleeJns9z+y0uQL+EBrs7yLGtnYf2IQ5xmZlV45egTCFhe 0cXKueqh2Azww== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51ECCE77187; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:29:59 +0100 Subject: [PATCH 05/12] ansible: Add build-deps tag Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-5-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=4391; i=joel.granados@kernel.org; h=from:subject:message-id; bh=Kj8tG89mwj8PU4V97afgamZ3sTf5UN0mvrsoVFXiIVg=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipC0vTFCqIVpjdbbPEJRIefkKcGeOQGTqs 61CixbFj4kqXIkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQtAAoJELqXzVK3 lkFPwH4L/0FJwTP7TFAJz8mSk4qBqmp1g7Mmay+nn3Ara86b/yUJrDr2Gz5bvMHV6IIi9ZqdFfF EUtLKFOIk4Exk8Bn9gEQnPftUy/txE7jeknm0/0BgvQ3HZ2ALO33MMnCGSNMBH04GpRCU8UMRAD rLOuFKvbEMRHTiqlmC6TrP9It+pfQy1v1skPDunDTYTIVSgUCzVi2YH2wdkKXKyH0Zct3ZGdvge o7OU78seX+J+mBoQWmxs4bsM5Xgmelcdv7st/F/sU5F1qZwoAmx5VRRO4qMPRemUjKCeWhCOHim 99mcCCefghqQeLTzBpx3t8Z4r9pAa3bjc4upi81ZHwXZ8izOUYRcZtlc/QiCRVDSecPy0hcXhc2 pcSCGHWnIkIKbQx+RUa9nqLH/D9NOX5l6z+PdTL0kGWG8JCVRNcQA9fOVmu6rAu5oK0qd2+RONx VpyxzmS6u4GUp19PnE+7PsSYG47NFxZOBERymXr44ALgUVq50yRS0fWUD1xs6xovzg7+xXa0037 xw= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Add build-deps tag to enable-user and install-deps tasks in libvirt_user role so they can be used from other roles. With no tags, these tasks are skipped. Signed-off-by: Joel Granados --- playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml | 6 +++++- playbooks/roles/libvirt_user/tasks/enable-user/main.yml | 4 ++++ playbooks/roles/libvirt_user/tasks/install-deps/main.yml | 7 +++++++ scripts/guestfs.Makefile | 2 +- 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml index 1ad7f17..5797bd6 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml @@ -9,12 +9,14 @@ when: - not libvirt_session - not only_verify_user|bool + tags: [ 'build-deps' ] - name: Check if apparmor_status exists stat: path: /usr/sbin/apparmor_status register: apparmor_file_stat_result when: 'only_verify_user|bool' + tags: [ 'build-deps' ] - name: Verify if AppArmor is disabled when applicable become: yes @@ -26,6 +28,7 @@ when: - 'only_verify_user|bool' - 'apparmor_file_stat_result.stat.exists' + tags: [ 'build-deps' ] - name: Verifies user's effective group allows to run libvirt/kvm without being root shell: groups | grep {{ item }} @@ -41,9 +44,10 @@ when: - not libvirt_session - not only_verify_user|bool + tags: [ 'build-deps' ] - name: Ensure our user is part of the libvirt/kvm groups - tags: [ 'journal' ] + tags: [ 'journal', 'build-deps' ] become: yes become_flags: 'su - -c' become_method: sudo diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml index 04f8e31..364d625 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml @@ -2,19 +2,23 @@ - name: Debian-specific set up ansible.builtin.include_tasks: install-deps/debian/main.yml when: ansible_os_family == 'Debian' + tags: [ 'build-deps' ] - name: SuSE-specific set up ansible.builtin.include_tasks: install-deps/suse/main.yml when: ansible_os_family == 'Suse' + tags: [ 'build-deps' ] - name: Red Hat-specific set up ansible.builtin.include_tasks: install-deps/redhat/main.yml when: - ansible_os_family == 'RedHat' - ansible_facts['distribution'] != "Fedora" + tags: [ 'build-deps' ] - name: Fedora-specific set up ansible.builtin.include_tasks: install-deps/fedora/main.yml when: - ansible_os_family == 'RedHat' - ansible_facts['distribution'] == "Fedora" + tags: [ 'build-deps' ] diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml index c652ab2..c2f58c8 100644 --- a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml +++ b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml @@ -11,11 +11,18 @@ - name: Distribution specific setup import_tasks: debian/main.yml when: ansible_facts['os_family']|lower == 'debian' + tags: [ 'build-deps' ] + - import_tasks: suse/main.yml when: ansible_facts['os_family']|lower == 'suse' + tags: [ 'build-deps' ] + - import_tasks: redhat/main.yml when: - ansible_facts['os_family']|lower == 'redhat' - ansible_facts['distribution']|lower != "fedora" + tags: [ 'build-deps' ] + - import_tasks: fedora/main.yml when: ansible_facts['distribution']|lower == "fedora" + tags: [ 'build-deps' ] diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile index 52397d5..dbfb372 100644 --- a/scripts/guestfs.Makefile +++ b/scripts/guestfs.Makefile @@ -78,7 +78,7 @@ bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) playbooks/bringup_guestfs.yml \ -e 'ansible_python_interpreter=/usr/bin/python3' \ --extra-vars=@./extra_vars.yaml \ - --tags config-check,network + --tags config-check,network,build-deps $(Q)$(TOPDIR)/scripts/bringup_guestfs.sh $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ --inventory localhost, \ From patchwork Wed Dec 18 10:30:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913375 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E24FB1F2C56 for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517813; cv=none; b=kDWPCuDSYULAjUhkUXsJYBO71Egr6tiJPaUIM4/bKYNnF8JWVgccwaU+Jix26xNKjjXEnXQF3f7G2tGybgDE1wNhpzmDwZXm01UTFjKgWN7yKMQ5uIT8LMBp4D83FAMxn9noD4CzDbl1b9C+gGSIOXP71qvcBHFrOd8LKk7Uipg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517813; c=relaxed/simple; bh=kK8WYlj3lCiI+bWD9/rTi5l4rFK8spbgf35AT9VzodE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NTadSnwznZe9UnjIduzNLIaDupcnVrm9oXgxCSZQatAtdcL84Wwjo0fCyMHpIvThF7xAEevd1tIh66IP6Sn5vi7VUvSdylFQKInYCRfIfsS1xXE2TWigG6TDMDHZlzW4jExXajXes+icBhS5LoO0Dalrs/VNOKPlwUcwQu7XIKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V+i4xuuE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V+i4xuuE" Received: by smtp.kernel.org (Postfix) with ESMTPS id 64DDCC4AF09; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=kK8WYlj3lCiI+bWD9/rTi5l4rFK8spbgf35AT9VzodE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=V+i4xuuEuoqlRX9PtgBBXNUA1rwYN+MJrgZlEwfoMc4RN0Ug5VSwhtcVYTjXp9iJW P7TteihNLjpmjydDZA6/TELo5erBHUjfH80IDrH9J454SyIvpT6xV7mQjg7InfF7Hd mfzw3H+zHPg8Ji9Tg6TF1bOBA12rD1uFVz9ydrJz07obOAeMaTOzEYkZnKzIVX+22C +9fuYXi2BARHiOYb7K8LewjLP+rSQYdL+i/3i3xeHx+IDdOnP3/VtXhBW0RpF/W9OQ ROHk7lkr1p5MgnkF6pPbDARVH+4dF4m6t0CS6c8Ff1FHoD5sY1HOSFrjZYvafcPOQx dflzEnGmbOnkA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DAFCE7718A; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:30:00 +0100 Subject: [PATCH 06/12] ansible: Use full paths when importing tasks Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-6-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=2953; i=joel.granados@kernel.org; h=from:subject:message-id; bh=kK8WYlj3lCiI+bWD9/rTi5l4rFK8spbgf35AT9VzodE=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipC6D2kfNXdSiYIv5376WGvEHBSzx9icVb hvGBCN2Oq6hqIkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQuAAoJELqXzVK3 lkFPR/oL/jDdSWI032qQh8cY/srGHs4q851KoAsBXAMVq2bux1tIxgnc8dUhk1B0XH89fITOiWH 8rKIp+ee/gF0+2gISxDqxjRpYSlL8dgn134g530h/q4pdDLqvardnLPrCQJQFotU4DZNJn6Qnck qeUitnKedTW4+CVn1H3FgXdSlWrMjdaF6jCe3tPH/jHMwOUTem8DiAkC/UumfWrgo7BoFHNRecQ YP71vNbmQm4TQz+b7hZVA+FEfu1oApHKObszaizDUihQUgu5zgYTnfNEK+mjqtCKtXSz2zNzSNj 76t4lycehSsadFvTXr8pmzcByB6bAYeKSc8d7ba3Tzy58GUltqScRNhTSTyd12w6g8F4Xge+xXD HoEU84JOnsbMgAg5tjTR16p5G/gs2mpUmv4VD2shUnK5CgJ76WmlqZyKrJn0Q4DlqVlUTluKTqh jt0U3S9qVyQGZRv96beOgGH+mdoTCwwUYK3GfuCl8RnaP9PB4vc8qGYHd+GTvJ4/RBWFAYNXij5 BU= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 This allows importing libvirt_user tasks without the hassle of changing relative paths. Signed-off-by: Joel Granados --- playbooks/roles/libvirt_user/tasks/enable-user/main.yml | 8 ++++---- playbooks/roles/libvirt_user/tasks/install-deps/main.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml index 364d625..2c632f2 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml @@ -1,23 +1,23 @@ --- - name: Debian-specific set up - ansible.builtin.include_tasks: install-deps/debian/main.yml + ansible.builtin.include_tasks: "{{ role_path }}/tasks/enable-user/debian/main.yml" when: ansible_os_family == 'Debian' tags: [ 'build-deps' ] - name: SuSE-specific set up - ansible.builtin.include_tasks: install-deps/suse/main.yml + ansible.builtin.include_tasks: "{{ role_path }}/tasks/enable-user/suse/main.yml" when: ansible_os_family == 'Suse' tags: [ 'build-deps' ] - name: Red Hat-specific set up - ansible.builtin.include_tasks: install-deps/redhat/main.yml + ansible.builtin.include_tasks: "{{ role_path }}/tasks/enable-user/redhat/main.yml" when: - ansible_os_family == 'RedHat' - ansible_facts['distribution'] != "Fedora" tags: [ 'build-deps' ] - name: Fedora-specific set up - ansible.builtin.include_tasks: install-deps/fedora/main.yml + ansible.builtin.include_tasks: "{{ role_path }}/tasks/enable-user/fedora/main.yml" when: - ansible_os_family == 'RedHat' - ansible_facts['distribution'] == "Fedora" diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml index c2f58c8..cd12e05 100644 --- a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml +++ b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml @@ -9,20 +9,20 @@ tags: vars - name: Distribution specific setup - import_tasks: debian/main.yml + import_tasks: "{{ role_path }}/tasks/install-deps/debian/main.yml" when: ansible_facts['os_family']|lower == 'debian' tags: [ 'build-deps' ] -- import_tasks: suse/main.yml +- import_tasks: "{{ role_path }}/tasks/install-deps/suse/main.yml" when: ansible_facts['os_family']|lower == 'suse' tags: [ 'build-deps' ] -- import_tasks: redhat/main.yml +- import_tasks: "{{ role_path }}/tasks/install-deps/redhat/main.yml" when: - ansible_facts['os_family']|lower == 'redhat' - ansible_facts['distribution']|lower != "fedora" tags: [ 'build-deps' ] -- import_tasks: fedora/main.yml +- import_tasks: "{{ role_path }}/tasks/install-deps/fedora/main.yml" when: ansible_facts['distribution']|lower == "fedora" tags: [ 'build-deps' ] From patchwork Wed Dec 18 10:30:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913376 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E26691F37A9 for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517813; cv=none; b=J3CsWMVtYSQj5JJjXFq0Egr9bAaRcsn8oKsoRQFOgEfPWxBHuJGUJcP6uldsLinkyBX5vYBOfLQ5RJzsARtm3TDm5XE2nhc8Oy/fms1Tn3FZnSuZYgKZVWpw0MZBD1tcnCTqPuSleI7Jd9I3/e5pqaPwnvG1JMLe4zv4jBNd1J8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517813; c=relaxed/simple; bh=FVJUFjxaM/R8fpk2NV9PoLz5rdhcjKBPNJtHwh5TkzY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Lfo3jqQkM3eL5x88V88E3CXrL7ouS0mxqkB8EIw/3l9qhAEM841UTfwSaUDLoGlrV5A47zJxkkwrOqUq4SB0a4+o+9Dv3aDOs6JnNzGWRGsLQCfzvAjBkwz0R4UnSsWgL05gGNES69P7mJrhD+SAZvr3NSuoitMLHMpov2ATCjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i6Vht73+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i6Vht73+" Received: by smtp.kernel.org (Postfix) with ESMTPS id 74B8EC4CEE8; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=FVJUFjxaM/R8fpk2NV9PoLz5rdhcjKBPNJtHwh5TkzY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=i6Vht73+xZw/mX6USHjFt5QqLJEClFuENrhzozJUkCJ1RwqeIwfPyhRI27RWO1dLt dEpzY8oN3nFnNWG+94z+DyiFyvlXRweGyOGlPPc5vGYXtsbsmYa021zKIM2edObgKJ yMPyjmMW//uZvy+mBx+duCEU+XhHRUbsejVT9tXpUp4o2TSJeODGLB+FpliR8EZO2u sw1A/ZeW/qkiYkjlDvDmkZsm86LDpjC3DTO0MN6ptHRtKE557w46WWAKbefdlOXEsr CLXgrFGidQ3qKuzBAv5Sydfq6kTU/H4+OVjKJxmB7j22otmbXWN53BDZlX0r5xYRfI M251eXlzvA8Zw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A95CE77188; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:30:01 +0100 Subject: [PATCH 07/12] ansible: Run sudo by using the '-K' ansible arg Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-7-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=3240; i=joel.granados@kernel.org; h=from:subject:message-id; bh=FVJUFjxaM/R8fpk2NV9PoLz5rdhcjKBPNJtHwh5TkzY=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipC4gdQq2TzX3Y5Nmmx4B7pV5lZiBpo79t 2Yh4kKPscSUGokBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQuAAoJELqXzVK3 lkFPU6UL/iM0QCsX5b1n1abec0yzUENXsBRsTPmQHqS6WIsthhTYv/24FSVl+ujpUxMgut7SIO/ 0E9+yvVy1Ni1YyND1LmA0w+W98SYJ7IwiTzBWCC8tVGehibJJqOBFIFL90YM26MFRV/eNLG9SVz iKKrTDBzxazLNwVVLV9ca+G9gVdQDjjgUfawklqN8AZ3Rm6mZnPNazdnz9tDhczj9jOilzmrsX4 jndAqlsfG1OzNJEc427/kiBqR9XOKBB1WuWx1iB2vKw1sqi8k9ZEZWHL5/oUUxuzIW8NMng0+s1 kYrHMTVRtiaFS8kEsfO3i4dn8z9YpUZMMGCD9i37UXLCf0rt3D5/8bYqcuLjgenzRnksIdsQHMf XgI/WMzkYedmFOHFx5TEWq0NqZjDGWxz2cAY3XnockDeWakgCtxACLAb/0iz0CRDB23StJ1L5A5 rfyq2eIhF4SMDFdeIb6YLkChHrauO2UNyfvQoR0yyh3+91G44V6MaggYfvD8KNPrF8mwzoajoc6 Wk= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 This patch does two things: * Remove the become_flags from sudo tasks in bringup_guestfs and libvirt_user roles * Call the playbook with the -K argument so the user enters the sudo password just once after the playbook call Signed-off-by: Joel Granados --- playbooks/roles/bringup_guestfs/tasks/main.yml | 6 ------ playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml | 1 - scripts/guestfs.Makefile | 2 +- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/playbooks/roles/bringup_guestfs/tasks/main.yml b/playbooks/roles/bringup_guestfs/tasks/main.yml index 07e0fc4..95631aa 100644 --- a/playbooks/roles/bringup_guestfs/tasks/main.yml +++ b/playbooks/roles/bringup_guestfs/tasks/main.yml @@ -59,7 +59,6 @@ - name: Check dnsmasq service status become: yes - become_flags: 'su - -c' become_method: sudo command: systemctl is-enabled dnsmasq register: dnsmasq_enabled @@ -72,7 +71,6 @@ - name: Check if dnsmasq service is active become: yes - become_flags: 'su - -c' become_method: sudo command: systemctl is-active dnsmasq register: dnsmasq_active @@ -94,7 +92,6 @@ - name: Check if libvirt default network is running become: yes - become_flags: 'su - -c' become_method: sudo shell: virsh net-list | grep -q default register: libvirt_default_net @@ -106,7 +103,6 @@ - name: Start the libvirt default network if not running command: virsh net-start default become: yes - become_flags: 'su - -c' become_method: sudo when: - 'libvirt_uri_system|bool' @@ -123,7 +119,6 @@ - name: Look for console.log files in guestfs subdirectories to check for CI enablement become: yes - become_flags: 'su - -c' become_method: sudo find: paths: "{{ topdir_path }}/guestfs" @@ -137,7 +132,6 @@ - name: Ensure console.log files are owned by the main user for CI monitoring become: yes - become_flags: 'su - -c' become_method: sudo file: path: "{{ item.path }}" diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml index 5797bd6..2fa31ce 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml @@ -49,7 +49,6 @@ - name: Ensure our user is part of the libvirt/kvm groups tags: [ 'journal', 'build-deps' ] become: yes - become_flags: 'su - -c' become_method: sudo ansible.builtin.user: name: "{{ ansible_user_id }}" diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile index dbfb372..480bc4f 100644 --- a/scripts/guestfs.Makefile +++ b/scripts/guestfs.Makefile @@ -73,7 +73,7 @@ $(KDEVOPS_PROVISIONED_SSH): $(Q)touch $(KDEVOPS_PROVISIONED_SSH) bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ + $(Q)ansible-playbook -K $(ANSIBLE_VERBOSE) --connection=local \ --inventory localhost, \ playbooks/bringup_guestfs.yml \ -e 'ansible_python_interpreter=/usr/bin/python3' \ From patchwork Wed Dec 18 10:30:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913377 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4C331D9A48 for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517813; cv=none; b=REUW4iovhMwoke0HTplqQvsibUBmtdg/ftN5F8vG6tGMU5jsqYhGiiSrvVPsoLHMSI9V1aHE81QvY/TZtsRw2hwvjMAN5XdOf1TOI3KznoMzpxezT23f4omXE2m7TmVEPKzWoxpkBqwYdVwYLexTnmhUXWHYSFMT/JNIjG/e4U0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517813; c=relaxed/simple; bh=DvGfd4CLkmhlBD3vAsOZb4k3P/lxx9nbk6oF98SgWGs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H/poT6Kl/RKBUw1H4cksK26Kgijgfz73delyJgn/3NF4y7GrAWJrqo/ZFSVjgnw7ExAko4ZPkYj8RILMlYj+FPHEmfPYDPEq+fxM8k9mMZXqR+0cm0ua7Vs5MJxP47ptrkeTqtWN4Ut+nDF3+WLb11DmOu0xPypZo9gVMr98Yt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J+tlpaKM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J+tlpaKM" Received: by smtp.kernel.org (Postfix) with ESMTPS id 809BBC4CEEA; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=DvGfd4CLkmhlBD3vAsOZb4k3P/lxx9nbk6oF98SgWGs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=J+tlpaKMejeJkdn+0WcMTLKGWunxU5XFx3XE6id5QbcMB8wFxnbHUxuDRcYODlb34 9NV93BuL6si1UFeVHkoipOsG1wWVtQfReRQlqOvQzejSFedRZLxzYJRsa3fNtlBoyO UEfOqDLZ5DpBvd1oXqGcq3iu6txC6EmWDNl/7Y3hYwqAoGS2Sde+yT8rBapmXAKxnX NqxZG5VNCHVGFwdXUc34BfTEeoP5qcfMTpsHBsSx3hu/kqcteyVEAECiyFDv2vbPvp /sv/Cr9WD8rdfwJGCChg3wT5PQL8syDFLDqMkvkR6wwyksUnMF/IwRthSe2mRWws6+ x+Epy/UsSutnA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 775B1E7718B; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:30:02 +0100 Subject: [PATCH 08/12] ansible: Install libvirt deps and enable user Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-8-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=1171; i=joel.granados@kernel.org; h=from:subject:message-id; bh=DvGfd4CLkmhlBD3vAsOZb4k3P/lxx9nbk6oF98SgWGs=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipC+/TB4qp0GWlRWlwn5A/+4LBYTHGLv+j XDeZ/mZSGrr8IkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQvAAoJELqXzVK3 lkFPfLsL/0e+fVA/cbaMh0OyeYAz0gnO8felFvf45m+NBVC4zcG4jiXUgZT1b41d4AcvROplyqO fK2VrSatvGW8IDp9C74A6vKjhxdmrD98CI+Xa8CVbSiNkCM2mXEjFXStNDC+8Vry4hyOGFAnRtP WYBbl07rZFcPCg8HeTalwGaJDn1NSkgRkrxWkRM7GUFFvkK07GklnEdVuImwk8S0MqQP9x4VslT SeNHE4JH6lR6H5CLHHK7Q7f2GudwD9rbpfLxdyDeD9J4pi+x/1kGb1uxNaL5w3JYFyBa/8rc9f6 ULXL+9OcKbTik2HFs8evyiNUXnpUWrL1x4bL/GNJvNzn7FwoAAfrGrgKnhn0E3WpBKTetDawkC5 4EPlAth7NR9mBAq5cvViq3+DTu9tsc5Nn2gXNK/eQLqpOqEOoWo09c8bu7sj0b/7+pwkn4rGdeq Cap7HNo6osF/1rBcNGnwdtZV/HDlSilFxahtJfxSLi+IiBJlV74M+HJ4pl6J4NFHUQQbBV6mch8 po= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 There is a need to setup libvirt when running `make bringup` in a system that does not have libvirt installed. Call the dpendency install and user enablement roles from the bringup task. Signed-off-by: Joel Granados --- playbooks/roles/bringup_guestfs/tasks/main.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/playbooks/roles/bringup_guestfs/tasks/main.yml b/playbooks/roles/bringup_guestfs/tasks/main.yml index 95631aa..c764ae4 100644 --- a/playbooks/roles/bringup_guestfs/tasks/main.yml +++ b/playbooks/roles/bringup_guestfs/tasks/main.yml @@ -38,6 +38,18 @@ when: guestfs_subdirectories.matched == 0 tags: [ 'config-check' ] +- name: Use install-dep tasks from libvirt_user role to install libvirt deps + include_role: + name: libvirt_user + tasks_from: install-deps/main.yml + tags: [ 'network' ] + +- name: Use enable-user tasks from libvirt_user role to enable user + include_role: + name: libvirt_user + tasks_from: enable-user/main.yml + tags: [ 'network' ] + - name: Check for dnsmasq configuration files stat: path: "{{ item }}" From patchwork Wed Dec 18 10:30:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913372 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE2511F2C4C for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=IEp9oTeYjiNetf/JGGmQvy+ageEFr5UlBsBOm2wQ5A2uu4QknNwkmjj8hjtOe3LsmO4VCh1CK83kgerO+VJGJIIoMVXXZZ/fhN6AhqsY1HtMC4kJ4W/heY9oaUhL5aIoUEmoZD9FKeia2ndMS7gjk3dAYkQdC0lF0Zu3BhSYz0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gNPAQthuAnQiAyQzK/1MS8WWdtmtdD2m5CvkXa0ABKhkvdCAculawPsDbY0oiu0thBU2VPsBEyI+ve5J3SjbZLg3NcnxkBKzlo5jiB4Rj2aOzkXUtbInquRj4mMWsqmObOYQSZjlCuLCUjrXbWisizM3sXDdd/ngezi3Dpn/Wx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k/jC4ri3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k/jC4ri3" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8B147C4CEEB; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=k/jC4ri35eGt5siacx1tfPl5RFd+2Lnr5eKYrZ59m2mFH3864wn9vNjjGKaLUshFk LTPPpfW6BLn9pE6Lb85bOXIdMSZwLcmDnbeW1xuDtmgglySBcry1/4TprR8A5eZFDf DZ48Thq/7tyLadB0LXgtB+h4mc5hPvU7v5FuwbiZlWdgCWCXwrqzC0Lfvtv66Xgk1B 8MT2A/XmfZnzL+MtKykMyH0/HfFZf/NhEGbX/sMIOOyQZIjWualtFeMzQw+DgiLY5P f8+EZ33ZuKRRPTwkkM3hPC79LMyzCUkmWt0tCO4s0DrJiMmhKzPYEE7c3ZOse+ML02 PBa8FwgND5EQA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D27E77187; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:30:03 +0100 Subject: [PATCH 09/12] ansible: Reduce long ansible messages for readability Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-9-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=2148; i=joel.granados@kernel.org; h=from:subject:message-id; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipDCeCuMToaZXCrHAMoZ3iDZ/n9RrydmVq YRo5MDHjS8oJ4kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQwAAoJELqXzVK3 lkFPnDYMAIB4hVQFCkHQoCFUSdP8aajmUUSgf78c023y7z0//ISY2ehdY8lAYTAiNzxxRUx1t1a RTfEMK9A0egAgxFb8NnU9ZGNVzIaVrNnE0J0rt5R6g3c8BhF/808dzFeEJjdqRUj71dBdFZnZE6 BQdGf5wQPCyTesRjuCMPxzJ+9mhhQ/ZH8ralHg4pAc2Py2enYnXAzpcoBgESTSNtfr6h8TZ1QrF Bod5NEg5nuIjdvBVO/FcyIDxP5X0BoeLkXglM/93y7qWtBzFj5sGAr3Bdirl+5m5Hib0HAu0PAM BQcWOgdcrCr4gNsI9WQM0wJzIalKShnjmnk3gup1MUGhQSzrIaFVw4JayT9I0RHNK9aOQK8ghtj hmAC2+dWmSkTeTy8+jaEHpELEfcimljM/uZZPh80+9FGhvuZFZ0SIgrzan/1AdRWYBvhNCAW9xx OJZKjaunOSPcMPQ1iuQVTbN0s3AJxFELloxVrynCeWjfCCOfsXy6NmPybq4Lpdf+MoZXXVpFT64 0k= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Signed-off-by: Joel Granados --- playbooks/roles/bringup_guestfs/tasks/main.yml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/playbooks/roles/bringup_guestfs/tasks/main.yml b/playbooks/roles/bringup_guestfs/tasks/main.yml index c764ae4..fbbb378 100644 --- a/playbooks/roles/bringup_guestfs/tasks/main.yml +++ b/playbooks/roles/bringup_guestfs/tasks/main.yml @@ -6,7 +6,7 @@ - name: Fail if {{ topdir_path }}/.config is not present fail: - msg: "You have not configured kdevops yet, configure kdevops first." + msg: "kdevops is not confgured. You must run 'make menuconfig'" when: not config_file.stat.exists or not config_file.stat.isreg tags: [ 'config-check' ] @@ -63,7 +63,10 @@ - name: Fail if dnsmasq configuration files exist fail: - msg: "dnsmasq configuration files or directories still exist. Please remove the following to fully uninstall dnsmasq:\n{{ dnsmasq_config_files | join('\n') }}" + msg: | + dnsmasq configuration files or directories still exist. + Please remove the following to fully uninstall + dnsmasq:\n{{ dnsmasq_config_files | join('\n') }} when: - distro_debian_based|bool - dnsmasq_config_files.results | selectattr('stat.exists') | list | length > 0 @@ -95,7 +98,12 @@ - name: Fail if dnsmasq service is enabled or active fail: - msg: "dnsmasq service is {{ 'enabled' if dnsmasq_enabled.rc == 0 else 'active' if dnsmasq_active.rc == 0 else 'present' }}. Please ensure dnsmasq is fully uninstalled and disabled. Run 'sudo systemctl disable dnsmasq' and 'sudo systemctl stop dnsmasq' to disable and stop the service." + msg: | + dnsmasq service is + {{ 'enabled' if dnsmasq_enabled.rc == 0 else 'active' if dnsmasq_active.rc == 0 else 'present' }}. + Please ensure dnsmasq is fully uninstalled and disabled. + Run 'sudo systemctl disable dnsmasq' and 'sudo systemctl + stop dnsmasq' to disable and stop the service. when: - distro_debian_based|bool - dnsmasq_config_files | length > 0 From patchwork Wed Dec 18 10:30:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913370 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9C91F2C4A for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=Suq+nAMuM7LkoQDg25bNcMukpLZj/cM7Rlj1XYBG8Pcb8UAe/Oht1LvHdEkAvujRXNHcHFyxQKxfLjbtCsnmXJAXgwW1W0M7kEIck/UdX/C5jHNw4Hx7Tl10mPQAxQjdQ3fgFbGSCyEdt60cj+r44kDVDurjsbURCz0f0qvrIvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=l/flaod/aZKoU8m0yBnBUBZzRVVykVMk2fVKTOumNQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FfEVGRoELjV9GVKMJzdcWkLzQBf2mQ9daOEjjbwg8gL8PcuOHBDjzBpQnT30ouUhtMp0Gicpv0XsNLxFpeRfOq0QaBxhpj7yMQkL/I6JCJK78Vhi5Ea9tda4cqqlSDAW2ZB3QOWyE9CyuISBkfegKs9FMtg70wFES5FvBDVfDoY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CxNwz7iC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CxNwz7iC" Received: by smtp.kernel.org (Postfix) with ESMTPS id 99A81C4CED0; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=l/flaod/aZKoU8m0yBnBUBZzRVVykVMk2fVKTOumNQU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CxNwz7iCDazR6QGI3L64/2bCYC/6MZlC/vPZVLzxOEbulvPPoUNZYFg7AD0pweO/d xIdHo6Fq9xU0JytLn5U50rH9eUqmwvtMhXGpvVf2S5JPxlRfim0CMyBP6oOjjk3yWL VIT5Hbj1Xegu0aLKOdfGa9EtnAdfF95WMmLglVrneC1xYsbkiOVaJOf1pT+okgpED6 jKmXOaIqGzLO3rwOu5wiejZFQ6hfq3VwY+n7+DaFytR3lp0CJ4J9CwnNJ5JOaE0rgL sRVINOP/Q+DhrafnThiha2GA8Iqrm69sNx3+F1QSUreqOzjMG1U1KROVd0zjj3BlMN zqsf8izYUvkCQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FCDE7718A; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:30:04 +0100 Subject: [PATCH 10/12] bringup: Use full path when creating custom_source file Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-10-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=940; i=joel.granados@kernel.org; h=from:subject:message-id; bh=l/flaod/aZKoU8m0yBnBUBZzRVVykVMk2fVKTOumNQU=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipDC19P9j5CpqAmnwsR0L2mlmJ1dunLF2q ILFlLYc4AD5R4kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQwAAoJELqXzVK3 lkFPee4L/3DDhjxLkW0GUmv7nGfX4HLGs/+Ucgx+wkO7d8o4yFpTOfJXOFWqC41DMW73GFYoHgA r+MQnew3TWK7JEWqDLHBhKd7opkojk72iEp86PZREzzhtxTuDg6baYU4jamwo/AloJoF8SP/bIN +1ceMQYHOHWYcjJCl4jww7bJZ9h8aNPa+6fiF6ktcs1FxzqArD+VDIEEfAmGlkCd0zhXFMFZnAB QczwqBtWbB5kUfBQSNDJe5x9o/r95D2Fck6ZqMcsTdMe0Uob6ACYEt27GPjQfzBgSOl2Gp1Ptbu JHsSuNs3NYHTLNngzdktPIoYhgt4oB7IxWOgRibRandWvUeHpd8kHnEtEU4Bl8sOEijWiRPUUKi aIrvx1JOLntuInJlZ4aI1gnULLPEbIAzJyTIB/fdxX8BEUBmhETfwuPwYkvk9X8WPWJukjF17tU +9ak04Qy9Ten8kAj15qYiir8O0a1RWbfPF9wOWMsClfc4JyhmfWeLuzoD9l8aBc/qR+V82uah75 Dc= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Avoid "file not found" failures related to relative paths in custom_source Signed-off-by: Joel Granados --- scripts/bringup_guestfs.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/bringup_guestfs.sh b/scripts/bringup_guestfs.sh index 74eecea..f49fd12 100755 --- a/scripts/bringup_guestfs.sh +++ b/scripts/bringup_guestfs.sh @@ -34,7 +34,7 @@ build_custom_source() SOURCE_TMP=$(mktemp) cat <<_EOT >$SOURCE_TMP [local] -uri=file:///${CUSTOM_INDEX} +uri=file:///${REAL_CUSTOM_INDEX} proxy=off _EOT sudo mv $SOURCE_TMP $CUSTOM_SOURCE @@ -111,6 +111,7 @@ build_custom_image() CUSTOM_IMAGE_OK="${CUSTOM_IMAGE_DIR}.ok" CUSTOM_SOURCE="/etc/virt-builder/repos.d/kdevops-custom-images-${OS_VERSION}.conf" CUSTOM_INDEX="${CUSTOM_IMAGE_DIR}/index" + REAL_CUSTOM_INDEX="$(realpath $CUSTOM_INDEX)" mkdir -p ${CUSTOM_IMAGE_DIR} From patchwork Wed Dec 18 10:30:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913371 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D017F1F2C4E for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=Otu3ZNG/2mG1YIn1E4gGX7iuD8pqOO6c/aM1SuNVjDMmuBD05M6T0igGyDx89qdIpIm33Jy1ErKJvzp4OqzJP7oJEBVOEGehd2EpiRJfClNjhk8xlxUdviJmOWESmV9FwcqJUgZOuY7vpOlLz61dZTEYugL8dMUQpXb5iULc8Vs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=Kv/ycEEjWStHBxJuRHp2jefllpU4iYXDCmq1ZbHsqLs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oGeobNuouuE5xUMf7V8TLomLtQrf8/DmpvDK6sH06qihK2qZwwrfd1g7mXI808nBv5gI1P/mPXly4QiktBUeINQr1KMxr42MbWYzYEHh1wBud2TeYydIboaOLzgRscMdtfHjX6wN9pXLNWaDEMta2D4oqZjDGcnbv9QYGgJQNFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RDzWbeR7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RDzWbeR7" Received: by smtp.kernel.org (Postfix) with ESMTPS id A8CF3C4CEEC; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=Kv/ycEEjWStHBxJuRHp2jefllpU4iYXDCmq1ZbHsqLs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=RDzWbeR7ftSyPvUV5+Iv29xqzRfU49oHQoBUEtlCip0RzsqUdywLw+wS92EjO8Ibe ff5tC8Ne66d9Kdf2RpuwRvwCRsuc6+5jxVz0WMgR/M9XGDgDBUyK2J/GwOrGnnnaSU BZz0BoESGHJqEHIUbvv+pmdKoHAphoXufo8mnF6QIwVr8wvWHgR0n5k/RF3G80k7du Dji6wt9mJbWit2oSPxY4WgHKw+uZgxBY7uArjUJBrK1H1opA32Xlua3dBuAJdZ3N7c 0retRb2YM+sQC9qeR587SvTaExh5LdhwdqPhMadzqlEt5kgyADeu+Dqwy8rOMWRzgo OCYvlV/DjeazA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0EEAE77187; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:30:05 +0100 Subject: [PATCH 11/12] scripts: Return the full default path of the pool path Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-11-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=618; i=joel.granados@kernel.org; h=from:subject:message-id; bh=Kv/ycEEjWStHBxJuRHp2jefllpU4iYXDCmq1ZbHsqLs=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipDF8wr0zfKRwI7Ai6EumFq+tcl5KmaZEm rSG4u2tOE11hokBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQxAAoJELqXzVK3 lkFP/xEL/j3qisqcUPCiG3GE6uRl38N7m4ZzmhW4DPZec+m+tzvqW5fluncQeC1mPJ3k7PlDgGD R/UrtnIqJRxu8lUMqt9QXD/x3wLv9Bpar4ATzGm9kVO/i4hawIKfKVRRCAfM9EwJ8e0mVzobOH3 G9VUe/Tw47LbZIgWTKvFsugZ8KGhUeezj1aWVcs3er1F/YHkCPLM13+zDQeM9Wh+b+XSPQHB1y4 tzzVYvtqgwD2jl66b8N8Md7XdZT23Dub7rcXMpvb5FUM7DlEHaEXPOXtfCpekbB06pIv1fU9L8Z OyTQDYg931Vs3Hcka+KTvwRvoF7yDS/9XXVGDkaKgxT8MEyvrivdvv8tMrGrxotnKgX19dS9mgj PjZ1Ft4422C9Oj4ivWe9JAVzFVRbOfxk3eQZ8J8Q3ucuGdkivm56dJj69dSMxRiGwY2VUqaXA3k oF6phCu3vP4JDDt2aIyPgcSb7lg97YTvayMlqjoeruZlWiD16aijXQ3REl84nUJipuvt/Jrvg+8 f0= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Avoid "file not found" failures related to relative paths in pool paths. Signed-off-by: Joel Granados --- scripts/get_libvirsh_pool_path.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh index 92901a8..c036777 100755 --- a/scripts/get_libvirsh_pool_path.sh +++ b/scripts/get_libvirsh_pool_path.sh @@ -17,7 +17,7 @@ POOL_LIST="" get_pool_vars VIRSH_WORKS=$(virsh_works) if [[ "$VIRSH_WORKS" == "n" ]]; then - echo "default" + echo "$(pwd)/default" exit fi From patchwork Wed Dec 18 10:30:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913373 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBE6D1A2544 for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=stOKoqnlk89ntCAs/NfU8FP/yKWk7jNZU/rs7Z/a9UDDKVDpgxVu2hjTzL/kRhBVZ8Z5j+z2YAyVxmsV2Wf3+ReNQT6AekGfgQak9kNhAMpuuv5BO3VBekb6z+x2ZWpLI7FquzOHKyFUvsiQh1wMQb6VufeVxHeuh9b2TK7pZ5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=jRfRt47UG+s1NGe9WMjH6iz6cKXD6GqKWu00bPFiEVg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lIAKt4dzAIFw0xz0WAPlDgQDmYvmLemry3fepvno8wcypB9Ss6uXi4efNOIGNEo761/0VNyxxfvlsTkIzm7CqmTziquxI4hOYZSZ384h7KILd2eXq4JDLGPE9ZHI3GhAaEB6WycDzADrm9rvTgt6ibUxxl+UUDLyy8JYNv7LiUg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GkXHbilC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GkXHbilC" Received: by smtp.kernel.org (Postfix) with ESMTPS id B5AB4C4CECE; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=jRfRt47UG+s1NGe9WMjH6iz6cKXD6GqKWu00bPFiEVg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=GkXHbilCGvEpmoIs2yLel5YRIbg1H0U+OomXO1TIUjfaE5eMVngJ3rVFIw1UyRqR6 NEfgSVFewD0SfjT12BDiR2SneNdgug77kq+fNLAU5jx/4NQxDQ23SSF6JyQgjuLNz9 4PVi8e/6UksB6ZXq+1hzyhR0dyTkesltqjmejXwO5BD35Jcy1ioIciUiVh+dEVC2Uk Egn16d0R0Dxc9F7gI5h6G9hYpQ4AAWYzeV1rLTDTYoItQzTpJ/OX6zV7TikMwZbTuM A5CODQ/JBVb9tA8aUSIcFzImV4RdkM5eF64AEYz6xTtr2GCIZ33FqY5sHCdDVwgmI0 6gTOfreRuRKDw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADBBFE7718B; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:30:06 +0100 Subject: [PATCH 12/12] ansible: Set running_user explicitly to the USER var of the script Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-12-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=643; i=joel.granados@kernel.org; h=from:subject:message-id; bh=jRfRt47UG+s1NGe9WMjH6iz6cKXD6GqKWu00bPFiEVg=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipDGa3SrpCmkBmvrXTdNWDCU/X+w6tW43b E4Uugj0ChOqlYkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQxAAoJELqXzVK3 lkFPgWIL/1ctWbAdJMTzWrWqR0Vmhh6uc4qGcgUVpb6T6cDM5qjnm5tiGFek5m9edl/p/4WLlbe DI926Xgfep6pHW64vRqj9ZfGLD1yUniZPUPoEUaIpDxfnAd6hb4cDFdLrZgap5imX0IJ9WFkHir eJAm/lXU6nHKmybmNrRLiwbYZrSEHyLuuKUrVBZDfGgDsVNCGV/m7mQrUOHGNM/p6ticVnTP4j6 mWoE8oP3tCPPDoOgLP5a0pSIeQMGzbYdziZbtx2751QQFTjc008W5XDSf0H6k+viqV/efOZRV3W qiuCCbW/fWDjzmi2CdrCQfsENeVXFmMlWBp9ELJDRviYRP3XvLssNqj+jGCOEwm81Pa53kcB7y4 oMFi+RunITuyl/A26fvZQShSCo5ouFicEdfUL5k05aOjmCb/vTTWKoLpUM+nIuCjgoD/3U0Igrd KNCIDLOdbpXXQF02W8trGpR+36n99V4YSIiG/i8GKof8VuQrD7Rq76Otv6+0sKbiZamixiW4zQ6 g4= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Signed-off-by: Joel Granados --- scripts/guestfs.Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile index 480bc4f..f463ecc 100644 --- a/scripts/guestfs.Makefile +++ b/scripts/guestfs.Makefile @@ -77,6 +77,7 @@ bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) --inventory localhost, \ playbooks/bringup_guestfs.yml \ -e 'ansible_python_interpreter=/usr/bin/python3' \ + -e 'running_user=$(USER)' \ --extra-vars=@./extra_vars.yaml \ --tags config-check,network,build-deps $(Q)$(TOPDIR)/scripts/bringup_guestfs.sh