From patchwork Wed Dec 18 11:21:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13913521 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5C1B19E7ED; Wed, 18 Dec 2024 11:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520919; cv=none; b=SmACTn0Pv8Yqz14hcc7jXNGnDit2Bl4q6nHHyBeDh3ksYmfYZ2rOlEZJsVpZhMIR+IHUf0+NpygFzzGHeP1Fo/T4GFJRLjun/xgCsCEYuS8d9eKTq53WZs/NjUonNMy2oCmL+Oklz8SOvVUvsdSJClLN/93fMFmyxCoZeFW7Pxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520919; c=relaxed/simple; bh=8r4gGTWPzlILiLbetBZnbcnrC8JAxuNPm9Ga0RRHTS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LBYjX7BF2/JQC1jmsuLi71ZKF1olltuRnadLQFyhVUlw9DdcfxDZY43l4rvKyI9DDwtsL7BY9wzQYPGnyoT6WosannNJY6l09gFyb66ksJK4lIIiSngPVkp/I5lwKygPqPpUpEZKG4bWnbZEO4Dd8duO+dSftWg0uRiGZlvUzTE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=er9sJQWU; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="er9sJQWU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=AtOhcyeyDLfXWPm1hwV+4pH60DjH2HtjIYCmg3gb12M=; b=er9sJQWUEupriCV1uJLNVvXRK5 EXRthyitipvWpqJ93IGFDSa6CgfLtBgmMFxUC1+lsqmv9G96/infKHywiG7RO1afIivcwUuGSO1c6 jRKwmPJ17w52MGJt6YmEBWLj2cuhTRqWmq5UZ6wlk6q6lW4DiSyh2IYBTaf4kTl18e9cGzEYclYna to9jHPewdvYhAxJSBKrBKdKTH4hW/HA1YxZfuu3SB1xwqGHQN1GZIMHRYVvY2+LIJ/CZleP0w6+qP RlYfTWypK2Sr8KEZJnAMh0Bhk+JjvL1CJ4gh75Pi9o5awMUwdGA4xkyuLh48AzXma4sN1+v4ntNKK lgqte9fA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tNs7o-0000000GR80-3r2G; Wed, 18 Dec 2024 11:21:56 +0000 From: Luis Chamberlain To: shinichiro.kawasaki@wdc.com Cc: linux-block@vger.kernel.org, hare@suse.de, patches@lists.linux.dev, gost.dev@samsung.com, mcgrof@kernel.org Subject: [PATCH blktests 1/4] common: add and use min io for fio Date: Wed, 18 Dec 2024 03:21:50 -0800 Message-ID: <20241218112153.3917518-2-mcgrof@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241218112153.3917518-1-mcgrof@kernel.org> References: <20241218112153.3917518-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: Luis Chamberlain When using fio we should not issue IOs smaller than the device supports. Today a lot of places have in place 4k, but soon we will have devices which support bs > ps. For those devices we should check the minimum supported IO. However, since we also have a min optimal IO, we might as well use that as well. By using this we can also leverage the same lookup with stat whether or not the target file is a block device or a file. Signed-off-by: Luis Chamberlain --- common/fio | 6 ++++-- common/rc | 10 ++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/common/fio b/common/fio index b9ea087fc6c5..5676338d3c97 100644 --- a/common/fio +++ b/common/fio @@ -192,12 +192,14 @@ _run_fio() { # Wrapper around _run_fio used if you need some I/O but don't really care much # about the details _run_fio_rand_io() { - _run_fio --bs=4k --rw=randread --norandommap --numjobs="$(nproc)" \ + local test_dev_bs=$(_test_dev_min_io $TEST_DEV) + _run_fio --bs=$test_dev_bs --rw=randread --norandommap --numjobs="$(nproc)" \ --name=reads --direct=1 "$@" } _run_fio_verify_io() { - _run_fio --name=verify --rw=randwrite --direct=1 --ioengine=libaio --bs=4k \ + local test_dev_bs=$(_test_dev_min_io $TEST_DEV) + _run_fio --name=verify --rw=randwrite --direct=1 --ioengine=libaio --bs=$test_dev_bs \ --iodepth=16 --verify=crc32c --verify_state_save=0 "$@" } diff --git a/common/rc b/common/rc index 0c8b51f64291..884677149c9e 100644 --- a/common/rc +++ b/common/rc @@ -387,6 +387,16 @@ _test_dev_is_partition() { [[ -n ${TEST_DEV_PART_SYSFS} ]] } +_test_dev_min_io() { + local any_dev=$1 + if [ -c $any_dev ]; then + if [[ "$any_dev" == /dev/ng* ]]; then + any_dev="${any_dev/ng/nvme}" + fi + fi + stat --printf=%o $any_dev +} + # Return max open zones or max active zones of the test target device. # If the device has both, return smaller value. _test_dev_max_open_active_zones() { From patchwork Wed Dec 18 11:21:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13913518 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5C7519E960; Wed, 18 Dec 2024 11:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520919; cv=none; b=NnEnRYr5VpRYIbZ9L11WapTkdM2pXsnb3EDPBrNArteWEnBZ59rtMzvU7u+VBArtcsbIu5vzQBOHi6LIkCZ4TelXITKkMvS5H4eX+Vq/Ee1WrqrsBEQE9a2/u0gGgFRw8K7QrAsOqgVfyTrIb8sHr+14lyVDAGwLlhuQWBe+7TI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520919; c=relaxed/simple; bh=wY/7hF5PRSZcYzzsthu++8A3kOn20EmjgReMJ7MrJNo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cgSwv79dcA/N5kBPKhOng0wvKP6RtwWdEOsfrBVSIjRuX9/0Tgzz+LJWIVoXtiquQCMkqyD8VPci1jvCQriHcni5TTu64H4ksCBW6qYW/ma6IhX7B8fgwPIGX2DoO1rs4wSLpy9GfLTE3APu94heF8HQuJd6v2q9ZzqRgurYt1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=nGC7kMO0; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="nGC7kMO0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=drrnbmYw5yknCAZIExrvfSIJUoiJeJ3WQdEq1X5C6vw=; b=nGC7kMO0MsyJEJ50VX/9EC1+u7 CfDdDSAwgAdN07IHzDwiNxwdQSllNNg0j25GeIBsc1CFGCyUYtd5dLzzgorrS4KWDKBKgTivKYI91 OYM4zMWT52lbQiDIeplAaMbPVGsskDF3IWVJlnlIMJELWBwcspe5n+OhKo0VdkV4+kPzbeaW81A6m PU7wVictLHixYRU7SuaRLDiXORPfYLKoKXKUci5XnJbc50FNkOrJCALtqP1vd/nWjRm6QmHtT4Ua8 xJ95Tw7zfYrZdBseQ9xNV9aTRL9COC/wm6qqgQec1vSx0J1m4/t+jWgU6lPI7otvMVO6E1hDtNn3n 6metfIvQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tNs7o-0000000GR82-3yQT; Wed, 18 Dec 2024 11:21:56 +0000 From: Luis Chamberlain To: shinichiro.kawasaki@wdc.com Cc: linux-block@vger.kernel.org, hare@suse.de, patches@lists.linux.dev, gost.dev@samsung.com, mcgrof@kernel.org Subject: [PATCH blktests 2/4] common/xfs: use min io for fs blocksize Date: Wed, 18 Dec 2024 03:21:51 -0800 Message-ID: <20241218112153.3917518-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241218112153.3917518-1-mcgrof@kernel.org> References: <20241218112153.3917518-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: Luis Chamberlain Use the min io for the target block size. Likewise we need to increase the log size if using a bs > 4096. Signed-off-by: Luis Chamberlain --- common/xfs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/common/xfs b/common/xfs index 569770fecd53..9a13258789e6 100644 --- a/common/xfs +++ b/common/xfs @@ -13,10 +13,16 @@ _have_xfs() { _xfs_mkfs_and_mount() { local bdev=$1 local mount_dir=$2 + local bs=$(_test_dev_min_io $bdev) + local xfs_logsize="64m" + + if [[ $bs -gt 4096 ]]; then + xfs_logsize="128m" + fi mkdir -p "${mount_dir}" umount "${mount_dir}" - mkfs.xfs -l size=64m -f "${bdev}" || return $? + mkfs.xfs -l size=$xfs_logsize -f "${bdev}" -b size=$bs || return $? mount "${bdev}" "${mount_dir}" } From patchwork Wed Dec 18 11:21:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13913522 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5CD119E97C; Wed, 18 Dec 2024 11:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520919; cv=none; b=EBIqjjHQMUYwVypl8jp18i8YcLjgbQZawOEJzj4WMy6i7gvawVy8PTeRzlmHOk/g/EpoqyFZAJ5ctqfPRsAIl4wOyUNLtLK1RRHfGYgbMW/HeKGz7wA5Z7JKB9HVBCJMIcyu/Uhv4pbIYhMqoCovmDrn2LQYoBJDADFRuetaHN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520919; c=relaxed/simple; bh=1xD77kve++4w7+ixwrVcbw1MRbG3nG3vmLdmb6krfuI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iF3AIxvBVUKECPlyBhDVYjyA4+xEEj5kOncWpNOn4tQ+yY7pvWn13xm5lbGyoNyAR9ptbWRryQPXeUVtBx8JM+dDdPIbJ11kII1dYAq6p2vqvCemEOvRSekmDHMcPnKQjVZ0QWIyFRBsVXp8Lzk4IfKOvHfVFGB3Fhll438dduU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=YoXbY49L; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YoXbY49L" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=PBOI/RSiWVX6KS2NYMUn31dr6SwjWOaTlfliT91lavE=; b=YoXbY49LUaokQ4CeQw9YCQ//tx sEdae+u8Id5zeIQL9BLZBdZDa3w65myp0GsEIqBDHPqpFHMw8Hk1VI1LjbmVJg+vheUD2OhSodfI2 S/W+Lh7C0CYUXSRcWp8LF3bKEyZEczGdy3hb9ZLsHKLk+ANWI4TbRtQfm505O1IpgFvkuZEIZmeNm qSsIrkQvUa4Pv4ExsOc4DQomdYhgbJ/3RixSeykyeVVAom6BQKvTU9Ww7ioCVq6/68w6Rna2auIbr LH/B+xmc7lYw5QXGKtSxFhbP9uopatuv/sy6fb/EBbeVJ6k8Lw+RR0CcOIhwstaE6d9p+AfJwU0uT y11yP5sA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tNs7o-0000000GR84-45s5; Wed, 18 Dec 2024 11:21:56 +0000 From: Luis Chamberlain To: shinichiro.kawasaki@wdc.com Cc: linux-block@vger.kernel.org, hare@suse.de, patches@lists.linux.dev, gost.dev@samsung.com, mcgrof@kernel.org Subject: [PATCH blktests 3/4] tests: use test device min io to support bs > ps Date: Wed, 18 Dec 2024 03:21:52 -0800 Message-ID: <20241218112153.3917518-4-mcgrof@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241218112153.3917518-1-mcgrof@kernel.org> References: <20241218112153.3917518-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: Luis Chamberlain When a block device supports a minimum block size > ps we must ensure we don't issue IOs below what is supported. Just leverage the min optimal IO to also ensure we use the optimal IO as well. Signed-off-by: Luis Chamberlain --- tests/block/003 | 4 +++- tests/block/007 | 3 ++- tests/nvme/049 | 5 +++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/block/003 b/tests/block/003 index 2af9b89ec3e5..e57d76271b8b 100755 --- a/tests/block/003 +++ b/tests/block/003 @@ -18,10 +18,12 @@ device_requires() { } test_device() { + local test_dev_bs=$(_test_dev_min_io $TEST_DEV) + echo "Running ${TEST_NAME}" FIO_PERF_FIELDS=("trim iops") - _fio_perf --bsrange=4k-4g --rw=randtrim --norandommap --name=discards \ + _fio_perf --bsrange=${test_dev_bs}-4g --rw=randtrim --norandommap --name=discards \ --filename="$TEST_DEV" --number_ios=200k echo "Test complete" diff --git a/tests/block/007 b/tests/block/007 index 3b68d0deec35..793bb4c45c05 100755 --- a/tests/block/007 +++ b/tests/block/007 @@ -31,13 +31,14 @@ cleanup_fallback_device() { } run_fio_job() { + local test_dev_bs=$(_test_dev_min_io $TEST_DEV) if _test_dev_is_rotational; then size="32m" else size="1g" fi - _fio_perf --bs=4k --rw=randread --norandommap --name=reads \ + _fio_perf --bs=$test_dev_bs --rw=randread --norandommap --name=reads \ --filename="$TEST_DEV" --size="$size" --direct=1 \ --ioengine=pvsync2 --hipri="$1" } diff --git a/tests/nvme/049 b/tests/nvme/049 index 88d4fb122988..6bb731f84fbf 100755 --- a/tests/nvme/049 +++ b/tests/nvme/049 @@ -19,10 +19,11 @@ test_device() { echo "Running ${TEST_NAME}" local ngdev=${TEST_DEV/nvme/ng} + local test_dev_bs=$(_test_dev_min_io $ngdev) local common_args=( --size=1M --filename="$ngdev" - --bs=4k + --bs=$test_dev_bs --rw=randread --numjobs=1 --iodepth=16 @@ -35,7 +36,7 @@ test_device() { local fio_output # check security permission - if ! fio_output=$(fio --name=check --size=4k --filename="$ngdev" \ + if ! fio_output=$(fio --name=check --bs=$test_dev_bs --size=32k --filename="$ngdev" \ --rw=read --ioengine=io_uring_cmd 2>&1) && grep -q -e "Operation not permitted" \ -e "Permission denied" <<< "$fio_output"; then From patchwork Wed Dec 18 11:21:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13913520 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B3C19DFA7; Wed, 18 Dec 2024 11:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520919; cv=none; b=ruGRBSzZ8BBipnPSy5pIZfEQstjzA9We6woARVt/hcWGYiEXK4nU1Z4AF2ModLPXWnSDGTUNAGY5660kHElksVXR1tTF0TwgwHbKAMTjXwACRehy1rXEzn3btch46Dtojbr21LMP1YVj+9F9oYsLjeD25hzv6U5UA2BTkfyXPFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520919; c=relaxed/simple; bh=oFO6f2vLIX6tz36grittk65OSBJQMGeVT8ObtjtT3LY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FlIM9br+Gzdylnjp9Q+tJwg6ZpLnP0vfWyJYno/ggpYsMlOv0NcfVn03LBU1hjiaduSkEzGSDQBw3WnfGwS9KGQI6Pmof9jriG9ZT07411D2JbLeFhjBBidqa4REb4F0vOqz0cbfJfTu6pCjZnAoWyJhI9Da1bpiA+ymIkzToQE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ACsTUmqn; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ACsTUmqn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=zfPvADUsyhBuK258g6VAKZDD4++/y+8fJPzRmJpcJ/A=; b=ACsTUmqnOHlp1Jg15vxzzLpq27 OG2fR20yS7jopiaIEM8/+LAmA8mKs4BWGsX7KFd/WJUiymDaf3ubopXQ9+hbLbVCxlvpYyuJHx+H7 qJ/wJ67XETHYwXHmhuE4NdNb2XdWWKuqW1iJdZukEFhqU3QBUUa3IBNN5odB33sxnyShy8WNnDy4W UMODkRJIr+8F3VKvTQi7DdkGLJy5XNs763ASDkqSaO9bPiQv0IqaCufIaEE0k/61e2+CFhgtN6N5q UQg4fK+mGhLoCN/2yCLTZhee+gPb30KRGVpb6UDdsKUxLRISIaDfkbUySmbjry/6Jv6PrdWDVvbbc rX+HLFyw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tNs7p-0000000GR86-01PV; Wed, 18 Dec 2024 11:21:57 +0000 From: Luis Chamberlain To: shinichiro.kawasaki@wdc.com Cc: linux-block@vger.kernel.org, hare@suse.de, patches@lists.linux.dev, gost.dev@samsung.com, mcgrof@kernel.org Subject: [PATCH blktests 4/4] nvme/053: provide time extension alternative Date: Wed, 18 Dec 2024 03:21:53 -0800 Message-ID: <20241218112153.3917518-5-mcgrof@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241218112153.3917518-1-mcgrof@kernel.org> References: <20241218112153.3917518-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: Luis Chamberlain I get this failure when I run this test: awk: ...rescan.awk:2: warning: The time extension is obsolete. Use the timex extension from gawkextlib I can't find this extension either, so just use systime() and use system(sleep) for the sleep command. Signed-off-by: Luis Chamberlain --- tests/nvme/053 | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/nvme/053 b/tests/nvme/053 index 3ade8d368be6..65a7b86519bc 100755 --- a/tests/nvme/053 +++ b/tests/nvme/053 @@ -27,13 +27,14 @@ rescan_controller() { create_rescan_script() { cat >"$TMPDIR/rescan.awk" < path; close(path); }