From patchwork Thu Dec 19 11:45:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 13914994 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 444D41FC7E4; Thu, 19 Dec 2024 11:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734608748; cv=none; b=b4JgBiGNEBpS++Sg5+SrnipKMymr8OQ4igeDUXpA0jB3V4gfXdEhq0CynoqYkPw+T1rDpJ36nUo5wH938C/ECGg4Te2hAVyPSQQ7hxsNYubbJoiCt1NC3Itx4a8n2kWtxejVUqLD2auWFufQNussnvEITtK6jvF5h5PzvBycciY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734608748; c=relaxed/simple; bh=tKRlCQo1yPtpI6+IGDepdsCFpBfExBiin5ApvQ7BwcA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fpD6GW6T4JXPOG/Bxm8FkezcHCfCyaIfIxqqcUSv+BB3+gNZ9wAhRyqQE8jKqO4PgpwHHjt2IuqzehTBFagd6tVOCqC/P7TC6BP6LclGmUZxp5dti0wbbTAyn9YP5pta2hfx+XSo+OcT1LZ5bYX6rzznEaez6fg9CQRhlK9oUkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dFcaPXgQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dFcaPXgQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED6EBC4CED6; Thu, 19 Dec 2024 11:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734608747; bh=tKRlCQo1yPtpI6+IGDepdsCFpBfExBiin5ApvQ7BwcA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dFcaPXgQ7f75fkNWJM7oEiwZLSZKXIjO9fIKKReI6kgwm3m4noO+sXA9wsGVbh5QZ pJ8LXuTiHwa7Bq83c5oILTJAQjNBxHLfpyxXzZxm5nete09eWshpsjk4MUQGmQVbU0 xmn6WohOCG8Oan8/FS1x7OXzlF4MGwC3g3jXWb5v2L2WyMPdXZd2V35yQmvfCdUWSF YZR+DnjiZZXks6S0dBRFnqcmv/v5PIrqqLiNQdMS/nGr22fWwRXbAcLEugwKADw2mT WTMJGvsvjjutNXlCAh/cwkMDfQEvQElDzsvtjF3ZmHENPId+Yr9bNazOYDUKCwJ+NT oP+bbxa9OV0GA== From: "Matthieu Baerts (NGI0)" Date: Thu, 19 Dec 2024 12:45:27 +0100 Subject: [PATCH net 1/3] netlink: specs: mptcp: add missing 'server-side' attr Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-1-825d3b45f27b@kernel.org> References: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-0-825d3b45f27b@kernel.org> In-Reply-To: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-0-825d3b45f27b@kernel.org> To: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Kishen Maloor , Davide Caratti Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1554; i=matttbe@kernel.org; h=from:subject:message-id; bh=tKRlCQo1yPtpI6+IGDepdsCFpBfExBiin5ApvQ7BwcA=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBnZAdlWHYeaFy5vuTVCZbZgyLmzNkZWJkgfX2xt qJvmGLsSlqJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZ2QHZQAKCRD2t4JPQmmg czDMD/9NDqXEvQPodr6KdQOMkEkWVXl7FKD0OqEd7se86ajLu2bU64EV+hs4KKgBNfZxUoYNmH2 s7Swv65NUZRUZ1rRhr+hNm99PVtLcwtHcJLge6w28L5TB+fTlvtRLI1GqAclN1VNxzh4yjg3Zwq Zwa7MbMgiKTPSaxLK6YzroTQvE6lgvxLGXuO7arSkJjf7uNz3rKSCE9pj/bArrXexfx5Zypu6Ey 1YGcDz3bz8/L9lBL7OZ6ClUcTjPwb+C/NR1oJRwDnBlhQkBYQJfhXbyQ9J9mYSTdw5a8JoVZxDa MHUEOI3IwNhw/9K0hzRZdNo5bRV+t7le/VoCrlTwDCuLieu+sJxiXj02VvAelxYEX63ZUFeLb2r I1xo+OWJYItjE5T7jUowWCdyvf4jiKX0Yh0xWei3KG1FryRJUGS8cFJv2zaAoFuGidA0jB4S+U3 YzfjUJCsfwssaImDNwecmsB8w/sofE0s3ojjwVluGuqVnAwtNqq7oymyLvZixcWFEyPIO84CIBq ooZfdgkCkGs0xhoFCh4RTPKTHy8HQSRsqu74vAiZLWwpQ0Nxp3RVK1bUhgL1xtDP01MCZtd9FkD b/TyOoj1YTtIVFl3z+JStOv21T9NIn8ePmOJ4ayJiwn1ysweGaSCmtHiU9XzDIlOFKOz9+gCXXr 1qnkkgByaIK7xjA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 X-Patchwork-Delegate: kuba@kernel.org This attribute is added with the 'created' and 'established' events, but the documentation didn't mention it. Fixes: 41b3c69bf941 ("mptcp: expose server_side attribute in MPTCP netlink events") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) --- Documentation/netlink/specs/mptcp_pm.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/netlink/specs/mptcp_pm.yaml b/Documentation/netlink/specs/mptcp_pm.yaml index dc190bf838fec6add28b61e5e2cac8dee601b012..fc0603f51665a6260fb4dc78bc641c4175a8577e 100644 --- a/Documentation/netlink/specs/mptcp_pm.yaml +++ b/Documentation/netlink/specs/mptcp_pm.yaml @@ -23,7 +23,8 @@ definitions: - name: created doc: - token, family, saddr4 | saddr6, daddr4 | daddr6, sport, dport + token, family, saddr4 | saddr6, daddr4 | daddr6, sport, dport, + server-side A new MPTCP connection has been created. It is the good time to allocate memory and send ADD_ADDR if needed. Depending on the traffic-patterns it can take a long time until the @@ -31,7 +32,8 @@ definitions: - name: established doc: - token, family, saddr4 | saddr6, daddr4 | daddr6, sport, dport + token, family, saddr4 | saddr6, daddr4 | daddr6, sport, dport, + server-side A MPTCP connection is established (can start new subflows). - name: closed From patchwork Thu Dec 19 11:45:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 13914995 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B64A61FC7E4; Thu, 19 Dec 2024 11:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734608751; cv=none; b=mkO92fs04s6Nn6ozgDL8u6GRjkKwAYYkfPTe7nHn8GEGCGYs0v+VpStMlApuZB7EGDtopqi/su32g5cAHuqGhcByAn+tnf12VFaIq6cEB++xFXBxApMUt7BpMQU2hiQiKSv3J8mqNHzGVgSvUVtfZjORymF5Y7bsC9ui2KwDsw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734608751; c=relaxed/simple; bh=aiSPkoyBjAXUDkzk8JUHVfdu5Q7meDKM18WsgqCRG9c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l4LgkjSqsr6tWktdw9rP9Otl2q5WTpVkhUYL/vIefJQAQrKqjphhxepCrVY8udRyQiPnI7lfn6lyNbki24mwLje+OXO3WQhWcF8LYkA+lEKPKQ1kbhXoXlMIXxHLV/g3R6fzqpzIhzpekzGcb/XfwkKfZm6QGInWE2/35Ex3n5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JJgR9Tx6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JJgR9Tx6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65C77C4CEDE; Thu, 19 Dec 2024 11:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734608751; bh=aiSPkoyBjAXUDkzk8JUHVfdu5Q7meDKM18WsgqCRG9c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JJgR9Tx6JlOJDoo1od0cd2OlNdHttiSpT0sMrKOs43bN1aUh//OSbr4PdhfRY4MKt Rs2Ar0bfEJ+Eu2s+qpGTL/sgzP8XFHb2O/PThRIer38iTar3TQwKzu4d9MXZFQnObo fB//b6ib3T0p5zSybOncw+QP6i5yF+NvvmMi5wCjZQB280Q3iC/xbc0I0ypSevDUP8 ZRcDUwAwJ0Mrv9aHmWN3O+TuRyx/VYfjbjaQQLABeFSyJBU7YqNW3uvQiZ6JEy1cR6 Vj2zBCWfwA5TECcm+bII09YumHB2y9DCKiMURkelWRvHH6gmT4lKldxtoNl/PVaP1w o2yz1q1tGMU+g== From: "Matthieu Baerts (NGI0)" Date: Thu, 19 Dec 2024 12:45:28 +0100 Subject: [PATCH net 2/3] netlink: specs: mptcp: clearly mention attributes Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-2-825d3b45f27b@kernel.org> References: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-0-825d3b45f27b@kernel.org> In-Reply-To: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-0-825d3b45f27b@kernel.org> To: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Kishen Maloor , Davide Caratti Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4438; i=matttbe@kernel.org; h=from:subject:message-id; bh=aiSPkoyBjAXUDkzk8JUHVfdu5Q7meDKM18WsgqCRG9c=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBnZAdlCBfJAU3WbKdSZ1K4eoEHCPCgX18g2hWOy ldA1JSlc92JAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZ2QHZQAKCRD2t4JPQmmg cy4sD/9nPcp+7EFYRLaDsAaFLARrPE8zefDq+QehJqA3KHLAguFqzle7eTLrx5bCO3zAs57K/zw l3v2Xtl6OSbiaR3zorWVYS5Cw412hp21ZdRMLmTTy4fxdCyoPWdjQoL8++WqJUEXBxLBmMCfSI0 t28Y+AcpkMIWl5iQxW0CmuX/TS0iYxubvk1q6lmlwRAXvEx8ZYErcxjB1/eFnGGInexFRrwDwRT +TyRA8O4ghWnP0ShhdL2zOaJjEIx4CpRibYVH0iBsXhdDET10CKkvgPybigRLYiYANP5qkGd5j/ RT1x/7V1Bc1ID0OHocrTvmh3neSn0YO8h9iO3hnlUJcO5N+1Vzp9TBHtd77Xg6FgDOqhurX8W+N gON6XGaPKABxs4IlNoUQLRdwoCG41sp1HeCKw+gD2BD1e22sTFdiL6iy0ANyJELQsyJ2/ypmYJn pUUfGpHX1xZQjeaHY+lutJTGaS/B27sdYyiQTL8KXqMFoKWxAou2rz2JB40SZ5gQk/0kG3tjIyL I5YKoN1n/b4XdL8Psoxo1NwvtuHkxRj3oEMdfYzAQBmD8jcoZP5m19tvVZuOELKxRh8Pp2YA+v1 7NzCEfneJ98yzpGj485HfHvI1p5GwvO0xpfzZqMji6tA2Zei/WhoWrQrnWCUo29RIrx+2m3yQLz j6Bkm1u5eXfapRg== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 X-Patchwork-Delegate: kuba@kernel.org The rendered version of the MPTCP events [1] looked strange, because the whole content of the 'doc' was displayed in the same block. It was then not clear that the first words, not even ended by a period, were the attributes that are defined when such events are emitted. These attributes have now been moved to the end, prefixed by 'Attributes:' and ended with a period. Note that '>-' has been added after 'doc:' to allow ':' in the text below. Fixes: bc8aeb2045e2 ("Documentation: netlink: add a YAML spec for mptcp") Cc: stable@vger.kernel.org Link: https://docs.kernel.org/networking/netlink_spec/mptcp_pm.html#event-type [1] Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) --- Documentation/netlink/specs/mptcp_pm.yaml | 50 +++++++++++++++---------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/Documentation/netlink/specs/mptcp_pm.yaml b/Documentation/netlink/specs/mptcp_pm.yaml index fc0603f51665a6260fb4dc78bc641c4175a8577e..59087a23056510dfb939b702e231b6e97ae042c7 100644 --- a/Documentation/netlink/specs/mptcp_pm.yaml +++ b/Documentation/netlink/specs/mptcp_pm.yaml @@ -22,67 +22,67 @@ definitions: doc: unused event - name: created - doc: - token, family, saddr4 | saddr6, daddr4 | daddr6, sport, dport, - server-side + doc: >- A new MPTCP connection has been created. It is the good time to allocate memory and send ADD_ADDR if needed. Depending on the traffic-patterns it can take a long time until the MPTCP_EVENT_ESTABLISHED is sent. + Attributes: token, family, saddr4 | saddr6, daddr4 | daddr6, sport, + dport, server-side. - name: established - doc: - token, family, saddr4 | saddr6, daddr4 | daddr6, sport, dport, - server-side + doc: >- A MPTCP connection is established (can start new subflows). + Attributes: token, family, saddr4 | saddr6, daddr4 | daddr6, sport, + dport, server-side. - name: closed - doc: - token + doc: >- A MPTCP connection has stopped. + Attribute: token. - name: announced value: 6 - doc: - token, rem_id, family, daddr4 | daddr6 [, dport] + doc: >- A new address has been announced by the peer. + Attributes: token, rem_id, family, daddr4 | daddr6 [, dport]. - name: removed - doc: - token, rem_id + doc: >- An address has been lost by the peer. + Attributes: token, rem_id. - name: sub-established value: 10 - doc: - token, family, loc_id, rem_id, saddr4 | saddr6, daddr4 | daddr6, sport, - dport, backup, if_idx [, error] + doc: >- A new subflow has been established. 'error' should not be set. + Attributes: token, family, loc_id, rem_id, saddr4 | saddr6, daddr4 | + daddr6, sport, dport, backup, if_idx [, error]. - name: sub-closed - doc: - token, family, loc_id, rem_id, saddr4 | saddr6, daddr4 | daddr6, sport, - dport, backup, if_idx [, error] + doc: >- A subflow has been closed. An error (copy of sk_err) could be set if an error has been detected for this subflow. + Attributes: token, family, loc_id, rem_id, saddr4 | saddr6, daddr4 | + daddr6, sport, dport, backup, if_idx [, error]. - name: sub-priority value: 13 - doc: - token, family, loc_id, rem_id, saddr4 | saddr6, daddr4 | daddr6, sport, - dport, backup, if_idx [, error] + doc: >- The priority of a subflow has changed. 'error' should not be set. + Attributes: token, family, loc_id, rem_id, saddr4 | saddr6, daddr4 | + daddr6, sport, dport, backup, if_idx [, error]. - name: listener-created value: 15 - doc: - family, sport, saddr4 | saddr6 + doc: >- A new PM listener is created. + Attributes: family, sport, saddr4 | saddr6. - name: listener-closed - doc: - family, sport, saddr4 | saddr6 + doc: >- A PM listener is closed. + Attributes: family, sport, saddr4 | saddr6. attribute-sets: - From patchwork Thu Dec 19 11:45:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 13914996 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112BE224B03; Thu, 19 Dec 2024 11:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734608755; cv=none; b=aofaKv/7St7UrESLkaB6oOF1JjN/5NZldBkO3so9uRGPHCYMWCQOXoM5wsVxx/qS8L6VpulH7kmhBO/p9Ap/8e0rydGBOgJo8QQzwMzfNVrPHGxuv8163RIW+BGGDlENZ4YELqrBeMy+8W4lj6GP06FpkSMyS/gD4lIv2iq2+eA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734608755; c=relaxed/simple; bh=ryauDGaV2QHx9bvaKw23915p8KRYzK7ghEvxtEuqeVs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L96gBFbVcoPknC+W12ia1wtV34puiPtj0etnkxO1O1VRaBovgiZPqbYEDmvxnXrFyukL0tZxRqMtvrAU5fmrZiKVQ4j8atrYcOBBHDCRgy2NwbnvcHpzLa1v8Q0DGGw9JUIsxSwexJ+MrNQg0npB9uft9ZFf7grGcfAeiFEIJZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FTakhQcu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FTakhQcu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2397C4CECE; Thu, 19 Dec 2024 11:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734608754; bh=ryauDGaV2QHx9bvaKw23915p8KRYzK7ghEvxtEuqeVs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=FTakhQcuXVIcAfb7YSnh1oSxVg4mNdSZuiKxYjqKOh9e6N+krS80zq1jrHJrfGL31 7taezG7624oRU3jTlTRzue+hiluGcAm3NJqFNEqXZ2eTf+XzxqcPBPWPhKnol4Oilb bIElwSnCTpX96o3pT2azCW0RY7LRDGDUSPqQUmFC9qxuyboVfREac2j+j3o1EtJ6Zk 2ry4w8hDYU+mcgb0H5chh8gE2ZOM7NVwgpMQd7KIeMrpDl8mtgMvHcIL83IyUWIn8j hbtuJe8xzjN9RAxJI9+O8ZON/97uql7bCZnnThmm/PDbrxAxGrmZzqZU/dpgV3vp+z wihcfRRCRS8FA== From: "Matthieu Baerts (NGI0)" Date: Thu, 19 Dec 2024 12:45:29 +0100 Subject: [PATCH net 3/3] netlink: specs: mptcp: fix missing doc Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-3-825d3b45f27b@kernel.org> References: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-0-825d3b45f27b@kernel.org> In-Reply-To: <20241219-net-mptcp-netlink-specs-pm-doc-fixes-v1-0-825d3b45f27b@kernel.org> To: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Kishen Maloor , Davide Caratti Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2303; i=matttbe@kernel.org; h=from:subject:message-id; bh=ryauDGaV2QHx9bvaKw23915p8KRYzK7ghEvxtEuqeVs=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBnZAdlzuGXzA3A6/O1SLyvTrLBmTTpkRX/zu2sc CR+BFyISraJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZ2QHZQAKCRD2t4JPQmmg c3+rD/9rVcEyFP0Ktq5YY/84fhUL3T0aWD/ASYqjrP7likvyMhmCUQ9owuywqB2Br0AwbB+pKZy dtc//ZWPjQEH5M2bBh3neR5iuRwYq9BNe5kO2FwLGEFL88wLdbJPHqbRrTHeZWQtKg+vCOufUvO ATPImKIGu7HYplkaNL6ZybBWSs3vYyQ7MgdgV2NPf8Vi+3z3lakdrdxBKb7HkGbSIRuQysUrj4G Y1scL6twCmTajRjo5TVcu0suaSa/k+fWmvHNvq3BmmlP1Bkc1Nd5sswwVU5Fto9+zDFMRfvF3QW /OXb3u+pkDQgxb//WUVkkOUsGMuUahCYvOVTx+Qsq4b5kMUL/R8ef8USZASAGZhcQ6u0/sowoEn Ye6yuVJ784OHN1B5EsDH64IWHcDaoDD087X1gMP98un18QjBfP0ZLMLmYv9ElURAHkiwfOR4q+q Xv2GzpywGJjD0JRVdlyJ/zvxB+aLBaujYItbGw5mm4BcASmvj0lGYlbM3FiOQ2oac+SRj+D//Z2 BDZSHYPYy4ou9ODdYR8jLQFkK6QiO2Qr8lRX6VQMehSW+9OF4uCuiuVfjcsV9XpIfceeGzucL+6 MlevL948W9sudHl6olk+biOVICmMdOhoD2WfXXklwsZkuICCi3ocOZVJo/XwQla6UCQ6Tj1SOiq XAnYKZ+UwYaSCfA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 X-Patchwork-Delegate: kuba@kernel.org Two operations didn't have a small description. It looks like something that has been missed in the original commit introducing this file. Replace the two "todo" by a small and simple description: Create/Destroy subflow. While at it, also uniform the capital letters, avoid double spaces, and fix the "announce" event description: a new "address" has been announced, not a new "subflow". Fixes: bc8aeb2045e2 ("Documentation: netlink: add a YAML spec for mptcp") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) --- Documentation/netlink/specs/mptcp_pm.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/netlink/specs/mptcp_pm.yaml b/Documentation/netlink/specs/mptcp_pm.yaml index 59087a23056510dfb939b702e231b6e97ae042c7..dfd017780d2f942eefd6e5ab0f1edd3fba653172 100644 --- a/Documentation/netlink/specs/mptcp_pm.yaml +++ b/Documentation/netlink/specs/mptcp_pm.yaml @@ -308,8 +308,8 @@ operations: attributes: - addr - - name: flush-addrs - doc: flush addresses + name: flush-addrs + doc: Flush addresses attribute-set: endpoint dont-validate: [ strict ] flags: [ uns-admin-perm ] @@ -353,7 +353,7 @@ operations: - addr-remote - name: announce - doc: announce new sf + doc: Announce new address attribute-set: attr dont-validate: [ strict ] flags: [ uns-admin-perm ] @@ -364,7 +364,7 @@ operations: - token - name: remove - doc: announce removal + doc: Announce removal attribute-set: attr dont-validate: [ strict ] flags: [ uns-admin-perm ] @@ -375,7 +375,7 @@ operations: - loc-id - name: subflow-create - doc: todo + doc: Create subflow attribute-set: attr dont-validate: [ strict ] flags: [ uns-admin-perm ] @@ -387,7 +387,7 @@ operations: - addr-remote - name: subflow-destroy - doc: todo + doc: Destroy subflow attribute-set: attr dont-validate: [ strict ] flags: [ uns-admin-perm ]