From patchwork Tue Dec 24 14:01:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Borja X-Patchwork-Id: 13920140 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1223C1E4AD; Tue, 24 Dec 2024 14:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735048968; cv=none; b=TgaQ2zFqdeehRWlKcM/riVeLFP1GrLOXgvOaQUgoz0OZlv+g5BnAti1ViyRNINDZuVq+P/NNmMUFLxbEKPacRc9CWeA7xZv8lc3ZsWuoPKQSIt0hOlCYNZgLKHAUUYjeRCdnvPocngYwchtod3K/35fmT5LbifFwjT2k5rok9Jw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735048968; c=relaxed/simple; bh=mm5t+vDZxpcLfc+zLossESBR8FPFq8TgP4dqWpK16Yw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oTVug+s0fBo20Stx/wLXoJ4JeT77cT14ooXHKSFatcgj/z6AzF7Ws31Nvret/IfJt7b7zfmODq3T97ANj66OyZ2UWcfjDtd4IHs+PuyAr1UqdB73Iiu1h+GKEHZKYbV1jq56BdJ535UfzOUo4ACWKDXmylKdpYYn4eHNU6lKEcc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LECwDeSW; arc=none smtp.client-ip=209.85.219.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LECwDeSW" Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-e3a26de697fso4410846276.3; Tue, 24 Dec 2024 06:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735048966; x=1735653766; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VMT9wD1DBkXEsFu4JGsu9qb/61ZjdOZDRwzwISnYJTc=; b=LECwDeSWI/TnQsNIN2Ikhr50EDi3/mU4wzL3mpVvQcqHhdSuMgKTVA+0L6CniyyZks gSAS6m96kVA6ZBnmYVKZbiiQDxH4t7uTxz4Y2xV5zZy8WGtL7bPrFcHQllWdIrA36+W4 XxriPk9p37ZWeY6vdCUztqh4d+WuGn/C0cbtpmsi4KhADHJA6fuSi82nsV4ZimSB7mmV yns5nTpM5u+4uth+Hv9n8wG7fWfGsYRlXLq1sCkm+/Y4iwPJ3JfoNhf9qKVjek4R20BD 5cDz+Q5fGM8IAdzq5SkeacbSbOjxsK3IJix+NgW9zxaGyA/Ww554jmmEpGBpj+j6ZusG Bsrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735048966; x=1735653766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VMT9wD1DBkXEsFu4JGsu9qb/61ZjdOZDRwzwISnYJTc=; b=DRpr+o7cHExnREgq22BNee5bNm1tpFzW167uTtbovVDz3TIokOZA7BZmAFVZ9C6JW4 VzbvBLwBM76pgSoUM4vuelcIBRw6+u8lwsnezuDrj48gsin2n5L1veeGvQIsnrG9X1Tk Zt7Rfs+kSn2NkAgfuYzNJFSNPZBlaKUTV+fr8YRUEiv6Q/zvE5eKSGd90cdF2klPFU0P gNUnV9CTbEUcgu5XEgSc8PGbSFY9ZrgdCGu9mAMz9nb4+biF+3Vlxf7F67eG/0rFhCYe GKPDncfQ185n3thbqwvVdoRHAlNOcTqFnkst2wgffTf/INkuqEBOGAFLQ/R2dEivgSpv 3yFw== X-Forwarded-Encrypted: i=1; AJvYcCU9n3VppfXBBhtB2t+XKRNo/H5SKh+9fDnU5zFYWSvQAPfAQCoxirx1KZcXgqcoRaaonJEnuhywg825@vger.kernel.org, AJvYcCXU0NztpTlIp2RX6fdREthKjq9nd+B1nSsP9OLJJRCA3tVncndI/dK3ty/Zi61N9mz9dIAjq4T3KKItjuRw@vger.kernel.org X-Gm-Message-State: AOJu0YyCz4oKuP8cj40RIdnuhMgi7i2vEWxkaapDsrwST9p80yzvVWf/ 0K0XA5iqdd9sJ9wRhSaaKFwp8ys2Ro3/zwwhnKpq0AFQ+caI1E1/6DmhAA== X-Gm-Gg: ASbGncuMulX4MGEAs9p7CV/qHZsVAmTYPax65ysUSapdNnEoGl/2rOjnJIhANoThbpa kTb1eXP3I1k4WO8pRl86Ea4ZS7RrVqIOyecsUwteVkVFKYn/mLBL6vcya1wdxNT50iD+HWFlUuB VwTAkWHVVskQOp0rDaTMmZT8kYOtUcdMH005WlVDk8K2s/+9HaJpz2eZyc3M78RthAOawhOYKnq UzzQSw554QayX6gbvLOxz1YrPc4DFgJEZfJ6cgi4QfKTX37Cp5B+6cpQp7rFnyU X-Google-Smtp-Source: AGHT+IEy/ulUa/tD1bs/d0nlRXNcAVSpuHSqQGlMdmCDtsIRfOCa+C5DZsL3MOwiXTiJKlX3CfXqSQ== X-Received: by 2002:a05:6902:2801:b0:e38:b85c:31a4 with SMTP id 3f1490d57ef6-e538c25d2d7mr10675561276.14.1735048965729; Tue, 24 Dec 2024 06:02:45 -0800 (PST) Received: from localhost.localdomain ([2800:bf0:82:1159:1ea9:11b1:7af9:1277]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e537cc79049sm2976051276.33.2024.12.24.06.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 06:02:45 -0800 (PST) From: Kurt Borja To: platform-driver-x86@vger.kernel.org Cc: W_Armin@gmx.de, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, mario.limonciello@amd.com, mpearson-lenovo@squebb.ca, rafael@kernel.org, soyer@irl.hu, Kurt Borja Subject: [PATCH v2 1/2] ACPI: platform_profile: Add devm_platform_profile_register() Date: Tue, 24 Dec 2024 09:01:32 -0500 Message-ID: <20241224140131.30362-4-kuurtb@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241224140131.30362-2-kuurtb@gmail.com> References: <20241224140131.30362-2-kuurtb@gmail.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Platform profile's lifetime is usually tied to a device's lifetime, therefore add a device managed version of platform_profile_register(). Signed-off-by: Kurt Borja Acked-by: Rafael J. Wysocki --- drivers/acpi/platform_profile.c | 29 +++++++++++++++++++++++++++++ include/linux/platform_profile.h | 1 + 2 files changed, 30 insertions(+) diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c index 75a1415190ac..4c4200a0b1a6 100644 --- a/drivers/acpi/platform_profile.c +++ b/drivers/acpi/platform_profile.c @@ -519,6 +519,35 @@ int platform_profile_remove(struct platform_profile_handler *pprof) } EXPORT_SYMBOL_GPL(platform_profile_remove); +static void devm_platform_profile_release(struct device *dev, void *res) +{ + struct platform_profile_handler **pprof = res; + + platform_profile_remove(*pprof); +} + +int devm_platform_profile_register(struct platform_profile_handler *pprof) +{ + struct platform_profile_handler **dr; + int ret; + + dr = devres_alloc(devm_platform_profile_release, sizeof(*dr), GFP_KERNEL); + if (!dr) + return -ENOMEM; + + ret = platform_profile_register(pprof); + if (ret) { + devres_free(dr); + return ret; + } + + *dr = pprof; + devres_add(pprof->dev, dr); + + return 0; +} +EXPORT_SYMBOL_GPL(devm_platform_profile_register); + static int __init platform_profile_init(void) { int err; diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h index 0682bb4c57e5..f1cd4b65e351 100644 --- a/include/linux/platform_profile.h +++ b/include/linux/platform_profile.h @@ -41,6 +41,7 @@ struct platform_profile_handler { int platform_profile_register(struct platform_profile_handler *pprof); int platform_profile_remove(struct platform_profile_handler *pprof); +int devm_platform_profile_register(struct platform_profile_handler *pprof); int platform_profile_cycle(void); void platform_profile_notify(struct platform_profile_handler *pprof); From patchwork Tue Dec 24 14:01:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Borja X-Patchwork-Id: 13920141 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B340E1CCED2; Tue, 24 Dec 2024 14:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735048971; cv=none; b=Q/ibSypMPBRpB0Yju+1rsHsjgH3AxLN13B7Te0k9XBC7JWbnSLIYsmpRfd2ganYDvcJvQOMtkWuMqFUJd8C0a1HIApP7D8u22bYvD+nLiC8WqqiOdsWXOCnJQ7vtK7XxZ4ECtL9C4Ks3I6wlmdr1uwkcDvR1rx7vYa2jh0zbErQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735048971; c=relaxed/simple; bh=tzVg25RDibZ0h2wOq5+IoBh873Kpk7iGS9SUDQe1Sfg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TKevpfvO62M9QekXIWcpzJbzTGi3fPofABw421tT88b39qob2GHhBkFk4zh1cIKeseU17tD2t7U2EbNslwFsLF/ZbWVr3XU7btD2BgYs08idzaPNnFmMdu4wLEYCbrygu/5pGYLa2wQl/EYkZHgQCYh0tIgNUzelc0J4tGg+l+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hWR/qUTu; arc=none smtp.client-ip=209.85.219.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hWR/qUTu" Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-e3983426f80so4764799276.1; Tue, 24 Dec 2024 06:02:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735048968; x=1735653768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rv0BDzn3CZSKo6xwZQLoVWwerOwVOOmdArHSd9iduis=; b=hWR/qUTu9PmLekfK0mvzJ4C4Zk73r2Mwj6+hgk4B2kuG5dx/sGUc95ABDY3Y1XMzdr MXLcwlH1tD5auYfUYOWxY2BgBP1I1uXctPNNHdHImBuZE2LUjZF4VFglCWaHQWcUbNw1 EgD2tzSF4EPXPBttgfvo20PRzCj7O0vcVXpZK+369LO5gynOTh3K4KjoDd3/cmZzLNaR bbMR948TXQCZ0JZ6+bf0863PBChcdnZzTGtQyU12l/xCeLNEf/zbEkXC/XRtfrZOL95c nXzbTtFBvyAf3V+mhUER2MmaGGJa74QXXsPoMo+I6svdntfpYEcwc9xIx1MUp9DDcmB7 jXCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735048968; x=1735653768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rv0BDzn3CZSKo6xwZQLoVWwerOwVOOmdArHSd9iduis=; b=KChwmVLXDQUnjBhN422OvOnAi6NC/zY8tCIqb+i5Ko2AHeWcje9UGun/SODC5Mg4Et /vt6phyOaMJ50oVwFEGqaX2QS/yfox3LTmBolqUXSZcNIpV9efB+a0C+eNh6sHCB0aoD RgIARIVOwL4mTasAwOSfBgjV6KG5RmzyXBAbh2TlW7Ya33S9info/tSmka/GhcoS+WY0 Yb4DnxLvXB/jubldJsholCnrpkmAIXAO6PE8ya3vS6wwb7MWKJRNiWkhhDQIgiTSnb9F 7X102uCQttJB9O6n87R0AYjHiZniBzTrMCrEtoZ2vgoQGOBJyORaaEMz8xj0+Fwy4g4k 3H9g== X-Forwarded-Encrypted: i=1; AJvYcCWa2nPg1aMQoxAxE9uVBqUUhbcqfUDJYnva5g7bw0HfeEK3xHZ6SL6GFRr0LbDLTH8UTk9nhB/sl4W0@vger.kernel.org, AJvYcCWj7C3Py67a88j2deRpetp0/MQvZzq8+sMbZGzgMi6laDypqLCAbxT1ggpTFf+u/XVqoOPTSIO+d35XlsjI@vger.kernel.org X-Gm-Message-State: AOJu0YxAdmMDkic/t54RFG0gcx6RpHQjk0ZDNhfIm0/r2qjsARbGXGr+ 7J7q7yVb9CQ9lb6ameo/6ZoxAepuHxhvyOkg/vcfa3cC2ylWonmsVPD4XQ== X-Gm-Gg: ASbGncv/qAoQsg5Inn0smrDC95z+RCrMFjL21ZT1bRxUfqLHcOlR283dSJg8D7KNzuM enRHgdxKfz1ndqrA5etDIO81ImYzvtxaacnBseJBpG28fwR/1BLT09i7UDyGsu/w4CUtCiSq7Fc hDHKHexkTq/Fa/b8TvEVET4rxzg0gYML+3OtIstuvDaeUSxbdKyXzTpCW5zDGcIGiMUdwwCIiIp /Foc4X3QMLXecI999jlvvgzM+CaSIrlAi82qbc+6ipvvDuBsw84Ug/jvYo7I+06 X-Google-Smtp-Source: AGHT+IFov0+kxCPQtgOBgzfblQKgpZIZJy/XfD1s2N23DEvLfTumzDzlRhLxLcZ3C4AY8bc1WL5JEA== X-Received: by 2002:a05:6902:2603:b0:e4c:35c4:cf03 with SMTP id 3f1490d57ef6-e538c223610mr11549701276.18.1735048968104; Tue, 24 Dec 2024 06:02:48 -0800 (PST) Received: from localhost.localdomain ([2800:bf0:82:1159:1ea9:11b1:7af9:1277]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e537cc79049sm2976051276.33.2024.12.24.06.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 06:02:47 -0800 (PST) From: Kurt Borja To: platform-driver-x86@vger.kernel.org Cc: W_Armin@gmx.de, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, mario.limonciello@amd.com, mpearson-lenovo@squebb.ca, rafael@kernel.org, soyer@irl.hu, Kurt Borja Subject: [PATCH v2 2/2] alienware-wmi: Use devm_platform_profile_register() Date: Tue, 24 Dec 2024 09:01:33 -0500 Message-ID: <20241224140131.30362-5-kuurtb@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241224140131.30362-2-kuurtb@gmail.com> References: <20241224140131.30362-2-kuurtb@gmail.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Replace platform_profile_register() with it's device managed version. Drop remove_thermal_profile() because it's no longer needed. Reviewed-by: Armin Wolf Signed-off-by: Kurt Borja --- drivers/platform/x86/dell/alienware-wmi.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c index e95d22c7b60c..7b3ee2d6a23d 100644 --- a/drivers/platform/x86/dell/alienware-wmi.c +++ b/drivers/platform/x86/dell/alienware-wmi.c @@ -1159,13 +1159,7 @@ static int create_thermal_profile(struct platform_device *platform_device) pp_handler.name = "alienware-wmi"; pp_handler.dev = &platform_device->dev; - return platform_profile_register(&pp_handler); -} - -static void remove_thermal_profile(void) -{ - if (quirks->thermal) - platform_profile_remove(&pp_handler); + return devm_platform_profile_register(&pp_handler); } static int __init alienware_wmi_init(void) @@ -1239,7 +1233,6 @@ static int __init alienware_wmi_init(void) fail_prep_zones: alienware_zone_exit(platform_device); - remove_thermal_profile(); fail_prep_thermal_profile: fail_prep_deepsleep: fail_prep_amplifier: @@ -1260,7 +1253,6 @@ static void __exit alienware_wmi_exit(void) if (platform_device) { alienware_zone_exit(platform_device); remove_hdmi(platform_device); - remove_thermal_profile(); platform_device_unregister(platform_device); platform_driver_unregister(&platform_driver); }