From patchwork Tue Dec 24 19:13:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 13920451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E3F7E7718E for ; Tue, 24 Dec 2024 19:16:24 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.863125.1274597 (Exim 4.92) (envelope-from ) id 1tQAO0-0000NM-WC; Tue, 24 Dec 2024 19:16:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 863125.1274597; Tue, 24 Dec 2024 19:16:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tQAO0-0000NF-Si; Tue, 24 Dec 2024 19:16:08 +0000 Received: by outflank-mailman (input) for mailman id 863125; Tue, 24 Dec 2024 19:16:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tQANy-00005t-Ur for xen-devel@lists.xenproject.org; Tue, 24 Dec 2024 19:16:06 +0000 Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86097919-c22b-11ef-a0da-8be0dac302b0; Tue, 24 Dec 2024 20:16:06 +0100 (CET) Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 24 Dec 2024 20:16:06 +0100 Received: from ntu.. (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id A14892BBF; Tue, 24 Dec 2024 20:16:05 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86097919-c22b-11ef-a0da-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1735067766; x=1766603766; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3AbJ+S1D48+s3L5V4rG7JKluw1lLPGgBj5Py4O/wfeM=; b=gGuut6YAri5d73RVFOhsDFimrvo7a5o4lXmT1qHPF/uzrHbvqiLNFWNf qyNZ0bRZgnpy0z4gmXVlTO7M8crJx+xk7F6mZOw0TLtuAwO32ItwkBP/V A5/2qQnIqWLtxqz40i8eqQxZm6ITuSwC9GHTNwieITiMcZ75iXtSye2/d 0=; X-CSE-ConnectionGUID: ZIivuxDoRzum+HBN+8Zilw== X-CSE-MsgGUID: VOJRqh9WSairvbFdcR7hEA== X-IronPort-AV: E=Sophos;i="6.12,261,1728943200"; d="scan'208";a="28314861" From: Ariel Otilibili To: xen-devel@lists.xenproject.org Cc: Anthony PERARD , Ariel Otilibili , Juergen Gross , "Daniel P. Smith" Subject: [PATCH v2 1/2] tools/libs: remove dead code Date: Tue, 24 Dec 2024 20:13:54 +0100 Message-ID: <20241224191529.138119-2-Ariel.Otilibili-Anieli@eurecom.fr> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241224191529.138119-1-Ariel.Otilibili-Anieli@eurecom.fr> References: <20241220165837.937976-1-Ariel.Otilibili-Anieli@eurecom.fr> <20241224191529.138119-1-Ariel.Otilibili-Anieli@eurecom.fr> MIME-Version: 1.0 Default switch cases skip these steps; these instructions are never reached. Coverity-IDs: 1056148, 1056149 Fixes: 0a69ea908d ("libxl: ao: convert libxl__spawn_*") Fixes: 643b106b40 ("libxl: do not use tap disk backend other than for raw and vhd") Signed-off-by: Ariel Otilibili --- Cc: Anthony PERARD Cc: Juergen Gross Cc: "Daniel P. Smith" --- tools/libs/light/libxl_create.c | 1 - tools/libs/light/libxl_device.c | 1 - 2 files changed, 2 deletions(-) diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index e03599ea99..d0271bef7e 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -1890,7 +1890,6 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, ret = ERROR_INVAL; goto error_out; } - abort(); /* not reached */ error_out: assert(ret); diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c index 4faa5fa3bd..96046803e1 100644 --- a/tools/libs/light/libxl_device.c +++ b/tools/libs/light/libxl_device.c @@ -392,7 +392,6 @@ static int disk_try_backend(disk_try_backend_args *a, return 0; } - abort(); /* notreached */ bad_format: LOG(DEBUG, "Disk vdev=%s, backend %s unsuitable due to format %s", From patchwork Tue Dec 24 19:13:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 13920452 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D3CCE7718D for ; Tue, 24 Dec 2024 19:16:24 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.863127.1274606 (Exim 4.92) (envelope-from ) id 1tQAO3-0000dR-5q; Tue, 24 Dec 2024 19:16:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 863127.1274606; Tue, 24 Dec 2024 19:16:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tQAO3-0000dK-3A; Tue, 24 Dec 2024 19:16:11 +0000 Received: by outflank-mailman (input) for mailman id 863127; Tue, 24 Dec 2024 19:16:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tQAO2-00005t-1W for xen-devel@lists.xenproject.org; Tue, 24 Dec 2024 19:16:10 +0000 Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 880b1e13-c22b-11ef-a0da-8be0dac302b0; Tue, 24 Dec 2024 20:16:09 +0100 (CET) Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 24 Dec 2024 20:16:09 +0100 Received: from ntu.. (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 0BBDB2BC0; Tue, 24 Dec 2024 20:16:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 880b1e13-c22b-11ef-a0da-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1735067769; x=1766603769; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=p+XiT9wY1Ed3nislo24Z9ZFwlemo29xWJsjCkC72kpA=; b=WPUPx60prGHuBpP4//Vb2yeca9QdNeAhuNB//WefRft35P4Nmn7ZZcoc Mgn/2ttvia9ngE+CuLH7JFwA7XSmvkN/lHOppkVxyV59LedfJ/tS0vCNq NmL/uNFhXC87n6SRmaG0eJ9rE9Vbsan8VWL7K1nUM49c3ik/ZY/SfQX+i E=; X-CSE-ConnectionGUID: W6qU7jSvSXCB1dz6r37o6A== X-CSE-MsgGUID: bpSynhVWStGaiOLyAugljg== X-IronPort-AV: E=Sophos;i="6.12,261,1728943200"; d="scan'208";a="28314862" From: Ariel Otilibili To: xen-devel@lists.xenproject.org Cc: Anthony PERARD , Ariel Otilibili , Doug Goldstein , Jan Beulich Subject: [PATCH v2 2/2] xen/tools: remove dead code Date: Tue, 24 Dec 2024 20:13:55 +0100 Message-ID: <20241224191529.138119-3-Ariel.Otilibili-Anieli@eurecom.fr> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241224191529.138119-1-Ariel.Otilibili-Anieli@eurecom.fr> References: <20241220165837.937976-1-Ariel.Otilibili-Anieli@eurecom.fr> <20241224191529.138119-1-Ariel.Otilibili-Anieli@eurecom.fr> MIME-Version: 1.0 The original file was imported from Linux; patched the entire expr_compare_type() with the diff from Linux. Commits wherein it might have been fixed in Linux: - dfe8e56fc604 ("kconfig: add fallthrough comments to expr_compare_type()") - 9ad86d747c46 ("kconfig: remove unreachable printf()"). ``` $ diff -u xen/xen/tools/kconfig/expr.c linux/scripts/kconfig/expr.c | \ sed -ne '/expr_compare_type/,/return 0/{N;p}' static int expr_compare_type(enum expr_type t1, enum expr_type t2) { if (t1 == t2) @@ -1106,30 +999,27 @@ case E_GTH: if (t2 == E_EQUAL || t2 == E_UNEQUAL) return 1; + /* fallthrough */ case E_EQUAL: case E_UNEQUAL: if (t2 == E_NOT) return 1; + /* fallthrough */ case E_NOT: if (t2 == E_AND) return 1; + /* fallthrough */ case E_AND: if (t2 == E_OR) return 1; - case E_OR: - if (t2 == E_LIST) - return 1; - case E_LIST: - if (t2 == 0) - return 1; + /* fallthrough */ default: - return -1; + break; } - printf("[%dgt%d?]", t1, t2); return 0; } $ cd linux/; $ git log --oneline -1 --pretty='%h ("%s")' 8155b4ef3466 ("Add linux-next specific files for 20241220") $ git remote -v next git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (fetch) next git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (push) $ cd ../xen/ $ git log --oneline -1 --pretty='%h ("%s")' 6419020270 ("CHANGELOG: Mention LLC coloring feature on Arm") $ git remote -v up git://xenbits.xen.org/xen.git (fetch) up git://xenbits.xen.org/xen.git (push) ``` Coverity-ID: 1458052 Fixes: 8c271b7584 ("build: import Kbuild/Kconfig from Linux 4.3") Cc: Doug Goldstein Suggested-by: Jan Beulich Signed-off-by: Ariel Otilibili --- xen/tools/kconfig/expr.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/xen/tools/kconfig/expr.c b/xen/tools/kconfig/expr.c index 77ffff3a05..84af124626 100644 --- a/xen/tools/kconfig/expr.c +++ b/xen/tools/kconfig/expr.c @@ -1106,26 +1106,23 @@ static int expr_compare_type(enum expr_type t1, enum expr_type t2) case E_GTH: if (t2 == E_EQUAL || t2 == E_UNEQUAL) return 1; + /* fallthrough */ case E_EQUAL: case E_UNEQUAL: if (t2 == E_NOT) return 1; + /* fallthrough */ case E_NOT: if (t2 == E_AND) return 1; + /* fallthrough */ case E_AND: if (t2 == E_OR) return 1; - case E_OR: - if (t2 == E_LIST) - return 1; - case E_LIST: - if (t2 == 0) - return 1; + /* fallthrough */ default: - return -1; + break; } - printf("[%dgt%d?]", t1, t2); return 0; }