From patchwork Wed Dec 25 08:20:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13920650 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2059.outbound.protection.outlook.com [40.107.247.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6134315359A for ; Wed, 25 Dec 2024 08:21:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114889; cv=fail; b=tojm8DOpr9gjH19RhOfP9c1tdRCZ+pIzL14UShxcXyKP4o8nHhuTh+SntozzO4CTbx9omDn5MFYu+8K14225TOOZNqQCFJhf60ZJZ/S7pl+Jnt/zJYgj7x9PZNlW2vO30Hc/Ob2Qx09+Qo+7UqNfeZGaafIDKKF/wabu9GkodYw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114889; c=relaxed/simple; bh=ztTNvBjyM2GdOIbjICjOms+n4ACWCVHnpgjWYX6R7oE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=g07uUHbbJ8vVVD3Q8kMLwkkyHjDe5K5WLfkvbzQkqH9wyuE7pEnvbxK8S5nU3tkbKXkWQpHG+CN1C21aVxryM5gUxZIcY31+7+WbAS22Ap495d65+4FMvTn9dyDrAxYK9hzLO3M+ZQYKyfFjkyk3M6xlc0AnMV4rLCvxkxKjpzI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=paW91xgq; arc=fail smtp.client-ip=40.107.247.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="paW91xgq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iIxdhKI16bl6Z2tOV4qm5+0cScsl92MmGalAK3FQVwbPOSsuORWh3HkU/omHRHKnAQgmjafj/UxQ3bYrdpxk9uYkufpbPwBvjykStyIab8WIn1KWs0O5LD3xuxenpQSZaI65jaVEkxcyW1/MFDNkJZAx0rcjPm7fbfWV1R3ZMvG/E3Tix3m6ZN28/k0Ng3CPHUm1SCq5Q/8JB/bCvUCCE8QELxptVJ0TpCooNyFy9gBnimdnMZ0lBYW4bKUcoO/D+EKeiyGbV62b/1N0uDEuflx8VG6wxFFhduxYbODw6KNvEkz8SbYqS54NNbg8a5a6/ZvBwUWboj+UboM6hycZEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4lgjoIelcFWeO/3uQ6g9StYO1DWE3pRbCcbM6dX6/yk=; b=ZfHgNUdi1HpxKKdU2HdiPdqBUNx/H7MUhJh7onlPodPH6XI53KwRPcFOjexIeuuOFtU1DDHicAmoYjiKWFJ74FIEKJ/rfqD3oVESkcZb9CNWoD1bpG39vewuJk/xFnCXeenxN54ZcIuu8jVS0bzi+iOtVlDm4IKwIuVElWcR2/TsqcIz4UfN7IYtUhFgkwF5lN2aGHUFUW98eAiYdCRJ0dhHdKLQzn6SfnRA2bVVwZj7ZDextHvfK63kmHZ4MwbphmAAXkeAR7Gi2t/CCe+EQzew2IbHi1jE7hsOeuWB5CS8LF/5Ct1yJZ+AaonIljSYdpiCpZk2K5aUkBHjzKUnOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4lgjoIelcFWeO/3uQ6g9StYO1DWE3pRbCcbM6dX6/yk=; b=paW91xgqGDS8lG10ly9LC/5NiE66KymtM71Gfj2U3pv1RgsSXdXGoFZ/ixk6pKn3kioppPQy6uI6SinMWjTmR1T57GvLBvsXzseNJUvHr/ab2T0QyMSg0kbNhb60eWk+HQm1z71K+xOq5x1RvnWatVU1wpUx0aniJmJO9OqUzB+1VgvIxBQNGol3rFh1NFQ6WuTrOy26cU8kt5DGjb/8o3ZFfEFteWl78DTwrtAeH97mm1KGLiiiGL9UWgKyDIw+YxJhz3QMdnV6PNxLbfyQbmTrHGvxubzx1302uEsDH5g30UD+sHT4m90/bEiEKI8I8DRPnOcVUkgWwxAhmXcMcw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) by DB8PR04MB6985.eurprd04.prod.outlook.com (2603:10a6:10:11e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Wed, 25 Dec 2024 08:21:23 +0000 Received: from DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197]) by DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197%4]) with mapi id 15.20.8293.000; Wed, 25 Dec 2024 08:21:23 +0000 From: "Peng Fan (OSS)" Date: Wed, 25 Dec 2024 16:20:44 +0800 Subject: [PATCH 1/4] firmware: arm_scmi: bus: Bypass setting fwnode for scmi cpufreq Message-Id: <20241225-scmi-fwdevlink-v1-1-e9a3a5341362@nxp.com> References: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> In-Reply-To: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> To: Sudeep Holla , Cristian Marussi , Greg Kroah-Hartman , Saravana Kannan , Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735114854; l=2342; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=JW09hdqF5JaCHbplXrnEbMAc0+E3O5ENXdWtWvzXaNI=; b=Ggq8/JPv3bg3R3clWpvIw5WzQ65da95nsyi11ZHMwhlRLA0qYBXUdZZzfUjJ6GK+fvYgFkqUd 8anqAeKysNHCp+9BCMrs/5YJMCQCC4vkgxsG7X/T+AwuiEwC6vX4Ucy X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0003.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::20) To DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB8461:EE_|DB8PR04MB6985:EE_ X-MS-Office365-Filtering-Correlation-Id: 53ae3737-8719-4a34-56e8-08dd24bd1e3a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?HUFQzH0FjjT0CTkopUXgZjqH11lJqia?= =?utf-8?q?/bOW8Suj95m8VaN6BoftgoSscdiS5IXPr9HdD1AAAzQAl18N9JwJj2dhUFu5D8UOK?= =?utf-8?q?L7MJs3S0L//FGgglSCKRG0cG56DmWyQnU8YE5ZSfpm+w0RIIHCPD4DcYFcgHHjjbC?= =?utf-8?q?VXrx30uRg5hM41OyP7bEXlffqwsEaarxwQ3MAYQifFlxbcr+y16U379O57JL2ZJfV?= =?utf-8?q?WZ8RhMSip3iFX3g0TV/XugE2KqXzc26OOqu8OStNT/J7I0rSEV7VwPEXfwhLq0ohk?= =?utf-8?q?7yoGU2v7mp/23rQUSvbzNSrWUomcHAS8ZERD6rzN9pC6PpkHdGlpMgcFXsW0UWvDH?= =?utf-8?q?TbzNZnVfi1U71iHNh5IIsaookizvdTjlOUUN1m2likKGKON8wi6WDkY6eH53hqg/G?= =?utf-8?q?vTm9XxINCgE9TzhiPQ6WBBnSkvhz8oejktRsgKs32O5xDAq1vkXkOg+Z9q/bq9Iop?= =?utf-8?q?LO70/B+A/Iy9+zlH78Io0Cuv8qG2Ce0OoJ0rdkILDLCx09EbMz0jAni6ccMLL1gdA?= =?utf-8?q?OgQsfpDSALQSWvrbbnkLz2N5MD79KWJa8Xw1Sjt3sKCzYo9PsoA8vhvlD6MTez2G6?= =?utf-8?q?c4QxLcGfNPr06/icZLe9YUXGltAdTD7lOCYSgRe05IWTeSShjdfRXs5+Kc9+GM0F/?= =?utf-8?q?JBOTHTZVc7VxmS2PKdf72khoMysLxadOiCMExuKeH2aADnrYkRG5ImQ4SqlzQpkDG?= =?utf-8?q?CyXL8/fdWnEc6V5JYwSrlU1pWwtn6Rx8i5B1UJ0+1IaPRzsmuF8C1BXz5RMStCVlV?= =?utf-8?q?Wg5QPvdfKko+3gWQCKzOUy0gDT8o+SJd4PcUU20zeoJXNF10hQD38EdzQfMUVg3D2?= =?utf-8?q?HH4vbUZ/Cuf2EHW2y9DKloAZFZSpNpi9fdbcYvL4DDTVTsn2XGXzDWQ10KFjrddnE?= =?utf-8?q?isk4mrUYQrC1ZgCsa/CUTQHtQXNuJEo+hqhImodX5kqCISkNUVEjHfFvvF9MeCiUi?= =?utf-8?q?AiGaKLgiTGhnWG6G6NK98zWB8lf+qwo0Y39eO4iwM3kGZrncqoaYOqcAzQsGO+3Ns?= =?utf-8?q?9vJ+a+VkLLK2LW7zh3XscWaYKcBHqe5lkkK5bO0I7LlW+cmiCoUZZ8tp30F+sjKfm?= =?utf-8?q?P0TVOHFo/ppVpmOBloCl4eQkTLo8dCNh4yojQ5bILGRwLDf2lVtNkTICE+8shrodD?= =?utf-8?q?ofMyWBGyvSFCRv+DSeLgn4ckE3tP4/46YSN6Cu97R5kjWKzBGej5QIgsgJMkvJLfy?= =?utf-8?q?Y51uunRmIoK0ot5ubwrnaz0hE8Q418rveDXVwDlI9EF6DVbM5TiG3roj/SsdT5LB/?= =?utf-8?q?YvQpQ4fB0bs6mDCvi8xQ34XWrc1mgb3tytegPUxPlprieCui9R07E7NWNDL/TVriB?= =?utf-8?q?EtzHhSPsv1nhAjzClvsfBc5yHjeLO0s0put7sWu+etge8pAz/OkxVfW+Y0E97leG+?= =?utf-8?q?71Rb8d0gjyojFHE22eAS9Q58OjjldKdmQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8461.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?OAAdF0f7MyyxloxpWzVYZ7nPJH5Z?= =?utf-8?q?3C2ph/DVplC1EGpi719qj1I3OfORHVKldKGluQ1wWqOGAGaPwBl6+YiKO+7iDUDIG?= =?utf-8?q?CqgdHbwIgUTUFEfapdc0AC0tE4RdJDFDzN2eikH4ah1lWbbl3BuFexJsweToC+4fF?= =?utf-8?q?LAEv9iKQRuPslSVHm85WeRLqkvLXYOhWiyVOEidGE6qZzKwahklAqHwLHU3dmk6DM?= =?utf-8?q?WvbgOl6TtV7kVGzTaGlI/3ZKRiOzFf9iPjXTCuIMRb+yM03PABqaXl+ypNHcyzLUb?= =?utf-8?q?pRYRBdgf3XsdoEsoEgL5/6xuxG7cCa9w+8w2AgaAZaRcfIFNmVFIYxl/n7/aMr8WO?= =?utf-8?q?qO02S03T0LhSjN4qCxyUz0N40F8GIfwtL+51eRli0jhRuVl+peG4zZU8HOqV1AHF6?= =?utf-8?q?Jp422AyytJQCSEEG0wKSoCaN83issm1yXm/Zhj7Ff9zpAccklPoNrDw01b2ScdI/O?= =?utf-8?q?ja+1/5YwutuzsjwRjZnG2IRuE0rLBPvRACptOKU2LfZLRJxRJtM5CjZhbT5IY02Ya?= =?utf-8?q?FlcN9H+6DfChJwsZXE/ylo9AcAUgMiOAtkQ/Q/BKi3xTRoZLbxLjwQQmemyKY5dL6?= =?utf-8?q?+hqhooqY5nzB49NdgIY7lsgBvQ+0DbYZrZShixfjyZLLXPYzGpZ7hiubLc+Bx8cBu?= =?utf-8?q?geIHvPYnogWTxGZCmbLfCj6enHE9dTRhV4+eHih0ImcQybThzD9M/2JeoD1COFl0x?= =?utf-8?q?+BZmu52MtZP+WzJUz0eclzSz71xprIm7XMoODA9TKu9EeHKfUSsL8PFr39+EoI5+m?= =?utf-8?q?omjzUdLXOoSG5klM2Z2/NngGHtTkNvCOSGDeF9hHVdFyJ/wFH0K9iQe8Zs0H4e0vS?= =?utf-8?q?9fNMBAieW34tfcksqnmrNN71YgUnvNSC9TKpwVp3DUSi9wCLkrtlQ9rxTAh6vmf93?= =?utf-8?q?+EucILMI+7pFaw/ELNl8/LcMpZlO4yI4WdenuX6QY86hq8hfsyX9PKTDIvgA0Vlsf?= =?utf-8?q?A+XkfJ8Sms4cKi7DFSVzUpiTdU9GVNy1g7QLZXhD9Xw2fuLea9IFR7NYP+QjBSDLI?= =?utf-8?q?DLQZIXjxyyoWvUFzmSzvN1/QaKg277ReFFS5UpizBXRF1enrE+Q+bIgMe5dPHJE/7?= =?utf-8?q?OY53dGbzZQ18PU8OfKQ+xlBV630EIR2+G3di8I7Zxcw72zn2+xUlaHC/cjAV3WpEQ?= =?utf-8?q?jpgRmoxFHc4ZO1PnsCsIPHbt98snRUZuBiEuFNh1gNXYjM2DzmQV3VPzF++gm8dNu?= =?utf-8?q?q6OTaXdRBNZH5Py0ZxvpWdz/GRZOaxEPXBUj4nlp1wYumMK5SgqCohsoZvk+UTebh?= =?utf-8?q?EJ9rouiZiPjqZmsSnUkuwsNwIUEXS9U50lxHT9PbVJaJSLrn21fnb0CVCLlIgQMnc?= =?utf-8?q?iOV1Rq5SiV4qjjg+ni1UG9QAdyIdQrtfWZREOcZqPOZlFYlyh87sd74aeadNmlzRX?= =?utf-8?q?pO6cGzSJ0DryBvlfA9Sl3aQlKaAwshE6xI6D0fjFHSs9zofirarkYBUdmpYbt7uYe?= =?utf-8?q?G9djjBjp0ewJfsX6FfumDb1SQiKjE+VX1FzAKbDjkhT+GyqMwWnFQCjiIUgMbKVJ1?= =?utf-8?q?ahs8RChcHIDB?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53ae3737-8719-4a34-56e8-08dd24bd1e3a X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2024 08:21:23.2427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l1zklGKYHV8MJmod+zBN26ObWYUTK87puK3Ks0YOvXTY3yr+9FgFAUV+Ksat1Q4GM38SKjAm7q9zJxgppxKcJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6985 From: Peng Fan Two drivers scmi_cpufreq.c and scmi_perf_domain.c both use SCMI_PROTCOL_PERF protocol, but with different name, so two scmi devices will be created. But the fwnode->dev could only point to one device. If scmi cpufreq device created earlier, the fwnode->dev will point to the scmi cpufreq device. Then the fw_devlink will link performance domain user device(consumer) to the scmi cpufreq device(supplier). But actually the performance domain user device, such as GPU, should use the scmi perf device as supplier. Also if 'cpufreq.off=1' in bootargs, the GPU driver will defer probe always, because of the scmi cpufreq device not ready. Because for cpufreq, no need use fw_devlink. So bypass setting fwnode for scmi cpufreq device. Fixes: 96da4a99ce50 ("firmware: arm_scmi: Set fwnode for the scmi_device") Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/bus.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c index 157172a5f2b577ce4f04425f967f548230c1ebed..12190d4dabb65484543044b4424fbe3b67245466 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -345,6 +345,19 @@ static void __scmi_device_destroy(struct scmi_device *scmi_dev) device_unregister(&scmi_dev->dev); } +static int +__scmi_device_set_node(struct scmi_device *scmi_dev, struct device_node *np, + int protocol, const char *name) +{ + /* cpufreq device does not need to be supplier from devlink perspective */ + if ((protocol == SCMI_PROTOCOL_PERF) && !strcmp(name, "cpufreq")) + return 0; + + device_set_node(&scmi_dev->dev, of_fwnode_handle(np)); + + return 0; +} + static struct scmi_device * __scmi_device_create(struct device_node *np, struct device *parent, int protocol, const char *name) @@ -397,7 +410,7 @@ __scmi_device_create(struct device_node *np, struct device *parent, scmi_dev->id = id; scmi_dev->protocol_id = protocol; scmi_dev->dev.parent = parent; - device_set_node(&scmi_dev->dev, of_fwnode_handle(np)); + __scmi_device_set_node(scmi_dev, np, protocol, name); scmi_dev->dev.bus = &scmi_bus_type; scmi_dev->dev.release = scmi_device_release; dev_set_name(&scmi_dev->dev, "scmi_dev.%d", id); From patchwork Wed Dec 25 08:20:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13920651 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2059.outbound.protection.outlook.com [40.107.247.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDDF015359A for ; Wed, 25 Dec 2024 08:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114891; cv=fail; b=VS2qQtPKrOYjbxb9AvUokn4NOOHl60xRPXO1bnzxEj0pgoLw0MSeZ4/GgB2/nxJiWol+carlmozkbR+i85Gfkuc3N9DWZlCtMSGnILSKCzXRPKkS1a/FZaXy28V/rRMtFNAfMQX0Peh+8QjClDV5sI7RmI2ljJniOlsM1Pp2quI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114891; c=relaxed/simple; bh=7iuIvV2m5IZ80SX1aloRC2aqgayAU5xjIlmGvZAHaFg=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=rRv4Uf2b3FvfWRrOzR3sD5GV4GmrazKflYprZUMM8l8KP9wpLhyH8fd61wf/YmhlA3PJwZU1D/z6UFLnMGJBOCSfA+PIcg9mrVJLXPntjKimTCSmpvdJuTeb59exESdEocnTnQqBwtpqDEnM5WuhXKeTYrgJyzkDmfksN8icXA4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=E3SDPOIf; arc=fail smtp.client-ip=40.107.247.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="E3SDPOIf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CU80dJob9T1eAHIZwXdFhxxaauWxN8zC1RhsuRFsZj0MBIzIveUS6qa+4UeCl+K7qKxg0znOyfP7zY65A2iYE283q9UZFpZgT/9ntnu1tjMgMWfjahmezl6RIQL6sEoGh725cBGR1/1wfQuvL2amyj8Z4BrzqneJiYMy3exp4MwJbQBCTUgkO0iGPkeQ0An0PKdYGCLdQQ/v2THNc1sr1SOWE3xeOF0SL6v7AghEClDpA/6XODgAkqiDnFVHLyQmMgRe22VReOk36BU3K0uOQg99t8JfmZv9wgK90obzkvkqvYwD/CwN2/MCVY8kiyCI2NUkobJeRKhgOAUJoibRmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fhhg+l6MoCUoxwTXACUfTgJ9a/h9kDneVKWHJ+tjLsA=; b=MHX3XCjiNfYVGkq/S4o1SVCStxz+i4NnuPXmGS6d2gIYFB1b7zXwMj+zGmz1vhCcnhFsHRH46S627ATrshgjXAEWKICjywY+8W8wUCaYF9c8EFQzVXhz8HNKD+XAvP2lVcV3i2wjVQgI37y7uznKZjNkMPz2I+BqRKZFVUgukKds5m04HR4j0zqUk4pLJqhOZo7tG7U+akSGjcLBeWPXWybPQ2GikvIG4lrADLqxqrj5RqciJ3RGayuZdsFttUT0WBhnovCeEZETKu34/dmgXIZ/+dI3UxCx5/qruXOGjdfWkyRWuBcXhNIX3sB8OGP8U2N463KSGLH9LWwjaOF/aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fhhg+l6MoCUoxwTXACUfTgJ9a/h9kDneVKWHJ+tjLsA=; b=E3SDPOIfKTldbAb8ObU2KGmyrvi/CVg4eJk/wKcR7SKW9zeJiAQJtwTkQERFC65qkKL/wMxi7WLFS8Aaj79VdbfCwOBWknWqGdQFXqlMvEbJZr2+Qqh5ealYjQjAz0JDwxhGJUEJr21ww6oqiAbwFs19HzIt0eKcCnMhLV27LjtBLuQh8/IAHhJQUVqXxfnx8HU7pu8aG5tMFhmIqkmKF7Zxv7WW6skFW95olfVu+5IwAHZkj7vYkdBKhUHXqRksm6LgO+z3RfBOUGx9g3B5Rz7SCZ0/7aGA59BySPYzn02DZiVusANDGOEgkfQL4pX0VV76c5ZqXZL2zxH5cof7tQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) by DB8PR04MB6985.eurprd04.prod.outlook.com (2603:10a6:10:11e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Wed, 25 Dec 2024 08:21:28 +0000 Received: from DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197]) by DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197%4]) with mapi id 15.20.8293.000; Wed, 25 Dec 2024 08:21:28 +0000 From: "Peng Fan (OSS)" Date: Wed, 25 Dec 2024 16:20:45 +0800 Subject: [PATCH 2/4] firmware: arm_scmi: bus: Bypass setting fwnode for pinctrl Message-Id: <20241225-scmi-fwdevlink-v1-2-e9a3a5341362@nxp.com> References: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> In-Reply-To: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> To: Sudeep Holla , Cristian Marussi , Greg Kroah-Hartman , Saravana Kannan , Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735114854; l=1673; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=5L5SVCOWRLjb9DcnHQJM5/G+cN8CxkyjHX/FcgJVNpM=; b=mUSvpY9QNF3HFPIL0zyrm19xgzMCePqlX96tV456LFxPxrki7GROAnhN5Xxj3e5gWnslDW4jy eg9ygHucmFmCLJCc26ZJbnzba84l9OngWW4ufrc5Ev0igfpplSAe6GV X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0003.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::20) To DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB8461:EE_|DB8PR04MB6985:EE_ X-MS-Office365-Filtering-Correlation-Id: b691dbdc-7b5b-43e9-4512-08dd24bd2142 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?+oynV8YYIyP+Dqnlt+bptbcyamOrVHu?= =?utf-8?q?ZDrMvN61s1Cr47GOsge0XJmFEAqZUnAsn/pWujoH8y9e1RFysRRu1/ybMlz1hQUIu?= =?utf-8?q?6P9l3NVCE0Dhu5787D5WlMo2o8Z3cd8FsTjzvO5ee2N50Y/tDFQeuV5FIs4ogpNnF?= =?utf-8?q?7bmSlkUX1d0m338uve9sf4dM1p3z4KFQcvdVXlh3jWxoPe9vXnlNBE8Px031qaLHT?= =?utf-8?q?gOncPAHv3wv+hKBdA7hSvbf9x/CdD2vtuIoMcfl2KBJCui2qLjedzM3/6z4rNWiOK?= =?utf-8?q?7L6ou3VpBPt135NfbXwhMGIFNY5iysBZUcV4oB15vIkoviUB7tMUWPO9+Epf5vvgG?= =?utf-8?q?jZ8MIqJK0r75PxGFyv/tuZVu5tFwwxkg5JodT4YPU+rEZ3yZdiwyzt/NnluZVggp9?= =?utf-8?q?DSJHU8Xic+fsGGUdazVOH0ZkeMzygY7JGTKhBFHGYYAbbGVl47omYFSS982baIIPW?= =?utf-8?q?16MBhwkRSYdy1BjKqDh+R0daa3N4JAy5xAJoqRUqH+6nbiE9PYX609rABlZlU2LpL?= =?utf-8?q?901OVWqyltu6dFDgx0iPw8MOc1AjL9TusklqwjwO/UrNkURvv7/wHal0E/33ocvxW?= =?utf-8?q?0M+VcuCpTcm1dcug0cWVzam8KHRU/0d1KGfzoa+4xV246MOBSP8/mb9Va0Z3RWN36?= =?utf-8?q?S+Q0F3TPi8KTv3u2V7yYjGj5mq+8FCHP9tkzPjUWDS+eXXXNLXCl+2TW/gE24Ny4q?= =?utf-8?q?I2yAVosVeL2I2jGgi3yUKZtB8SxLUOsDd2cwJvEuhIG8wXBcZSOG0MMSjzUrAJaU5?= =?utf-8?q?g416IWCQRiVc2gPVTZCrqAkT51xEwr07kZ9Y1+621h32EYqRgvEhEwZjEkqJL5z/K?= =?utf-8?q?hW5Ho8hNkp6vyo3UQRNs042UrRghDgoua+O1YJO7P0WeaOg8UFpFtpPwXwPLDIvNV?= =?utf-8?q?F04bGOxDYeDZD3Z4oD2tWIfCHRzBNLXQws/NfogUX5t85RWlSh8kaeo2b7V0sK2rp?= =?utf-8?q?i78QpfVpJZdYl9KMQY0HrzLtEAKIxUxclYmnJ0oTWFobcakq1jEC4idvnxgE6lpcB?= =?utf-8?q?lKW5ech/9D8Q97WaKzNguXE5JFbePihncCE+366Inwd34ta07k7CpIZNBSwfq59DT?= =?utf-8?q?pvKuVrhGuTtF3VCOP9culO6Zya6Yyd/aujfkj5rJYvjJ7zDECC26q2kDW5sA5GiPb?= =?utf-8?q?IZ6Ae54Fd6ADfmhvdLUci1TtQGYDfAyMuAZLZcoYi185Q2GcaZ8+Xng0ZPBQeDv+w?= =?utf-8?q?7UL9XwiW9uKwGWmxyxDcsWCfxMwsIdjNj2J/v9F/CpNeVvpWrnXPWnOu6Tg8tdSlq?= =?utf-8?q?r8j1u6G8DgL/nFE/jM6I6IpjAsstNTbwkwVxRaemjeA1zZv4jaAUIFCsMZWwJm3dD?= =?utf-8?q?j0dwlyzzonFsjqcCl2lmuX+EnRQNGhu8QiOHLmgzoPwh5nHtgNSf93NDuzmXcDE9d?= =?utf-8?q?mSFy27aCpiqpqOvvUNCs0Nv8zaEz9Ssiw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8461.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?2vLcVKJTr9vZBab2mJoO0o5ZRHu9?= =?utf-8?q?T7KDRXMSf5oahHm17f5ctl6LxnpHX+sPnsxOhHEZbdHEUZfamFVmPg10xfustemaV?= =?utf-8?q?VS68sxtJ0V1XIzkveJniPxxcgsVyFEDCzBZ+RlsEHCi4ODn3kmnZqeOjv+usfVRAa?= =?utf-8?q?7RqMRhNnwWH13Y/dPMa53tgIpdmTXWl44FNBkXLykOWbmtOrV1bJUvz/mu5XgokaJ?= =?utf-8?q?91f+Glhb2xOflDnfP/wyTv2T4gM+vVc3NDipAsMoupAjuunf0VlImrVSpCaRVylDt?= =?utf-8?q?lFj7shV7Y39uqRBmFbSvwIUsJUSnJsjcSn1jISBmZmUI0WH32DE0ovR9mjiQ/AanA?= =?utf-8?q?9fejCuCqlQHQxdZAt56mnmpeKpT7Z0XV+Fl91TYb8BN207R1Xc9/oaVqGuyRKoshH?= =?utf-8?q?qufj4oq34UJmqInXH7bimrWC0twBWdesn8uTgqOllQ6v8vGOIJHN/ToERM4zg1V7d?= =?utf-8?q?uYTKyj1jVyV5//3ZDqp2B++5j802ohEpxFbq8df0veH5WZwhim9BidUPJEcWu/Mkt?= =?utf-8?q?hIvnyj/Z7mMo3un8XYfVYgp4NI8qTIlVmkcw01P/3+BletxRBIpTfG8YYm+Sud30+?= =?utf-8?q?c+MiHU+vSSKvfQE34N6oi7MBpF7/U8CucPNeWQ1E823EOiSvae21NWPOwiz5xBl+g?= =?utf-8?q?y5SoC1RD7tUAIps88tKOvG62UgDbIjXf9aIKaFO2IfchoAvi8DgL/bmcCTLOeXHyI?= =?utf-8?q?RT5JazHnqOd03xJjxp3ni91Y1V3d+rH7olarrFVTewk0dpobaT+IqhM97d1xkOMSR?= =?utf-8?q?mWMjRaxMFNES0k9CDxIk16DqBjieHAi5ldU244JjCTIg6HpfajVITUJh5BRo83gra?= =?utf-8?q?+1C3JMfVjibNnzsymE8wU5OpPiOQOa7drnsMxDUfsNcbuNNkUbCMNVIG6Z8xhEgVy?= =?utf-8?q?my61WIddAX7xK1jyKmMtv4wpb92wOb3K2K/qzBRfHkLwnSU0Z+NyDqHDLEezUc0o7?= =?utf-8?q?UzCUqgb0hEisv5+NtQI12VHRS5bzTKy44os7Y/FvUI6U0EcuJvqs6VM3EoSRMdVHj?= =?utf-8?q?EoSt7m0aNgg4BdcGmnCC6cUCFRTDfPtlwrwdMmD6+0pO6MjSbige40tNzy40Ng5a9?= =?utf-8?q?tamJslILdpNIsuW8+mvp7/GN+TE5q/yUyfwO2su8cFw4w7GbJaCNHre1jzINlU8Lg?= =?utf-8?q?iv5f9zuCx70ffLhbA3ytfWk2e+j2kPdzra+mWvWvsgHUQy46EMfeoGL2BQgQcE/vh?= =?utf-8?q?3wo79cQPJA1z4BuC59SFZ82LrA/GaM40Fjm2tXZZbl9fXNLhnY51bp4HBCXxHpwPZ?= =?utf-8?q?Z4PTkSP12ITrEuBD500Na6iJyzb1g3JVwyN7WUfSvjldRuzChrCq6CwfhqxsuK5fB?= =?utf-8?q?XtpwUMl7DGGfG1LLjcmDsEevR+8c6DDMwbU3LsmxVPdKHyEC9t6nllr/3AsBJBKrP?= =?utf-8?q?945fLMBOwW4etxBfm1pZZJpYnvZ3huBZGn5CPDYzZq9pOyD0zBErcvUfft65eldv/?= =?utf-8?q?F9BIdzHTr8qzCUdsP27PoINhsnwXhsTywfI/h0id7jcxg6jMTY6+Y9anB+8PRCfbm?= =?utf-8?q?mzCXAii03HNa?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b691dbdc-7b5b-43e9-4512-08dd24bd2142 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2024 08:21:28.2773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xZppLKP9pkpwI9ff/lm+ofeDJlAIMZbBjM0t1P9jlaWIqSEOH3J2ddUjUEJaj0exsPpZfMfdJv5Ap4l/YNqp9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6985 From: Peng Fan pinctrl-scmi.c and pinctrl-imx-scmi.c, both use SCMI_PROTOCOL_PINCTRL. If both drivers are built in, and the scmi device with name "pinctrl-imx" is created earlier, and the fwnode device points to the scmi device, non-i.MX platforms will never have the pinctrl supplier ready. So bypass setting fwnode for scmi pinctrl devices that non compatible with socs. Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/bus.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c index 12190d4dabb65484543044b4424fbe3b67245466..87665b09c8ff492953c8300f80ed73eab6cce4fd 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -345,6 +345,11 @@ static void __scmi_device_destroy(struct scmi_device *scmi_dev) device_unregister(&scmi_dev->dev); } +static const char * const scmi_pinctrl_imx_lists[] = { + "fsl,imx95", + NULL +}; + static int __scmi_device_set_node(struct scmi_device *scmi_dev, struct device_node *np, int protocol, const char *name) @@ -353,6 +358,15 @@ __scmi_device_set_node(struct scmi_device *scmi_dev, struct device_node *np, if ((protocol == SCMI_PROTOCOL_PERF) && !strcmp(name, "cpufreq")) return 0; + if (protocol == SCMI_PROTOCOL_PINCTRL) { + if (!strcmp(name, "pinctrl") && + of_machine_compatible_match(scmi_pinctrl_imx_lists)) + return 0; + if (!strcmp(name, "pinctrl-imx") && + !of_machine_compatible_match(scmi_pinctrl_imx_lists)) + return 0; + } + device_set_node(&scmi_dev->dev, of_fwnode_handle(np)); return 0; From patchwork Wed Dec 25 08:20:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13920652 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2054.outbound.protection.outlook.com [40.107.20.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6C84175562 for ; Wed, 25 Dec 2024 08:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114897; cv=fail; b=BM15P9ODA/fEqwYbs4zRxaMBo67FN1OYsS57ccZTe0/kH05eaFwf46nfY4rZ3P9QDLvMy7Kr1jPIrT4cqOyYM7o1i3ylzQOg0h9hb0mUb4W3W0DNdnxvvEtKLM4w/WgZyG/moitlNnYZdjyx9SNQSevNeqalfItcMbLOiF9BPm8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114897; c=relaxed/simple; bh=J+xcsLePAYp6f69pW1nBclIYRTJEk+tWmWlGgvM0K1o=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=q7dpJzGsBFwFsHYArnKH2BkAx7nmIausT4spPDtsoHceeOzt5exVNh3gv0M/AeNcFW/jm/6ckw+OjjVKtnLNLxO3Vv1muCGZ5afvLi1yNPw5HxRCABngmCBL+A67ABwFkw6FJWOFqtoR+thC+Y2+uBcmYWqg0GLRQUDD2k/eruc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=OPjdm5L0; arc=fail smtp.client-ip=40.107.20.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="OPjdm5L0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZhVHWtTGZnuFYUcpOW+0tP9h3EMj4qGfqi0fQMiROnPITbLfNYlygYeyr1DNCejj2tiOfTKMYRt3tyh1Ce4uD/pCsAZ/qnU47+n7QhNl7YDqqFwUsgjH3qjWbjdEcHjvJqQ+olRzkFADduiObzGA57jdYFVBPPK+8ZuD1+Umq7ctGZSxz3aY72sn/7PdVHo8V6Dfl+LXzrLONf8eoXOivLV8yL9vgiE5MD3qm7zP9KuYwQOvt+zCggbrV9j8SqUi0ife1B8DLg8HKXbKrOZk6GYalf9OD66KILZUa4lIiJe05nd72g6iGAAJQfoKAKBSw0ixyOqppFzW3RwQtoeJAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZaHgf1HOYINwmhIkfBnjW7uym2CkqF09G3XssNgoIvg=; b=h5lloh1y5HfCQv+nfmJ0dSJmeykNrNngL/i5zdUVl0fXlJKSbb25+ip1uX2thjzsPuRcBTdUXuNp7cvNKfh8Z9UcDUMqM8jNubmGgF2xKyV6j6iDB9efUctdkytbQNK5sYKhM2ehf6S0MxpQ0B7gpobhwyFixp5IbQdyf6ewODIMH3DD7MHjoatipOWzTUXZGttROgUaCAAHzHDYKbH6/BhnRpAb5HC7q790lpN5jhnmNR1gZ2ZljqTvs0E9OSUZDSWboheCmJWZcE9cicRTuMc6Vua9pp9DaO0vytwCR3t5k7P4W4OJdDAgIM5PGrPIGasVMc95QgFojO3YY3OESg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZaHgf1HOYINwmhIkfBnjW7uym2CkqF09G3XssNgoIvg=; b=OPjdm5L0ih07ZTvicZWYtfJNcXn8RgftnxN056Si6lyQCBAuuGaE8ek6ffSXDlyMN1hYgsDyb/c5uCaW4h3HB4IN65PV4ZsNjHVFetHxTlSKYF+o0W/AgB+RZn3uh56sXCDolL1ZODp+0ErgfbH9/tmRK+/5BMAMZ/fxcesedxVtOfFL2PBCH/FdVphwnZx5D12BT6i6RNnoxQqbMV1NcIOOt9joxvo5Srh5aV+0sLxqrYf0anrvpYmiRo7s9u+JC/fMxpm/9QtnDvS00O5kGnJ4yDGKpflP9ixfH3AsYp0YATsb4MFwjbZe3MB//HryaS1PdTfs+dzxxjNEMLd2Jw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) by DB8PR04MB6985.eurprd04.prod.outlook.com (2603:10a6:10:11e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Wed, 25 Dec 2024 08:21:33 +0000 Received: from DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197]) by DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197%4]) with mapi id 15.20.8293.000; Wed, 25 Dec 2024 08:21:33 +0000 From: "Peng Fan (OSS)" Date: Wed, 25 Dec 2024 16:20:46 +0800 Subject: [PATCH 3/4] pinctrl: scmi: Check fwnode instead of machine compatible Message-Id: <20241225-scmi-fwdevlink-v1-3-e9a3a5341362@nxp.com> References: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> In-Reply-To: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> To: Sudeep Holla , Cristian Marussi , Greg Kroah-Hartman , Saravana Kannan , Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735114854; l=1087; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=r4Ew8RhCTydbXQP0oQzzrc0X8D6H3LB9gfEADXdHfL0=; b=NjmxUSnfAhOUAHD2K7bs61CFhYAgc6OFQUZyMfQzZRBgrFCkQNjVg+Gs2lcy9mcjgj4vEisy8 KowglTrSVDfCEHozTXxH7ldb+qN+GN0SB9VvNCj4Dn51DtELE2MR5OZ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0003.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::20) To DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB8461:EE_|DB8PR04MB6985:EE_ X-MS-Office365-Filtering-Correlation-Id: c3490782-e556-4be6-8bcd-08dd24bd2440 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?E3bay6kLRUfIF6LjGfrnO8KKLnMwVek?= =?utf-8?q?YTzWD4cSBNlmlIJjD9W08nPx2W4254njtHxJ38s1Q0Fy0kYV+UIjBFROxGOL02oIu?= =?utf-8?q?D7Aeof+ENocEjM3sYM/86myLzm+gwLBc56lBLil5j1f//usb4G9WVCKwGzqU5M+2Y?= =?utf-8?q?BT9KuYWieKSqI7n7Eo4qdVAIDlcWxjvhHmUr26EbKHfxLuxz/BJc/ae49JT3p6kAY?= =?utf-8?q?pyIecNEAHqSRHau0xq+CyPW7Rwm31Tkr5H6xO29VLmFpVGq6o0V/xlJZKnDvyjMGE?= =?utf-8?q?4mLcQxSYIlZTiqrTrnd213jNxRG9xq3yZGdDb1GSS16XlYCpAk8a2TMoPti74hm9/?= =?utf-8?q?wiVp2rqIe6uWfxtZq6LbRusuJk+cKKSCcc8HOs/Q4roYuSjE8qYe92S6YUrrf9za2?= =?utf-8?q?sRngOnmP6qFouvPR7PHaTW67R9xRHnLxHsJ8F6nlAXqse/mf/KXRWcVLXK5whA0lT?= =?utf-8?q?gauZ7AUVp8tXkzJRBkXz3RNi0BQGCNqTnlX+3nX4c1by+VALc/GXMDBM/bs/pci6b?= =?utf-8?q?Dsf7FC0/Q+BDlagwKwqG9kfPWNfC0ST+ZLD6j/7/+WeoBoQpy8GXLdRvxUAEKKckp?= =?utf-8?q?oc53XKLg1FxH03lbdZ7RLvCsAldCp7JdlILbCxKneJ8mti4hdwScq4XKleCylLLpq?= =?utf-8?q?3noW0qdZNABFyrrON/fSHi03radY1fB7x5oJVzvXL2YjUHhS4+5M355Rq23h4Ebrj?= =?utf-8?q?cZIIW3L93l95EB/GOmQQ8R6OAN6SSkXcdNJf4NrUl+bkXVHvgUrsJqC2lvgiYrcot?= =?utf-8?q?toJcYBQV8kce8sc4KuByNgQlZjU9SWzD05x3pACiSmDNbhXJ5ujFgvGt10kI6V6tt?= =?utf-8?q?kJuM43W1ObFKN4TvD1fXDYrhcItQRUvAVOrV7ETSwIKml3QlY1CQyqvcA9f9fHYQq?= =?utf-8?q?N+ATwU0AcfP/TydW63WlLp5zG02vSA/QgNb/l8JGPBfY2GcY0y1rq7FkADs/yplvt?= =?utf-8?q?E38ci7nvrKc5DJE6ynbZvBxT++V7cWFuIf/2+NHcms0d2dQt0ipur6At8vy0+HwOm?= =?utf-8?q?BnYJDRTFZjR9M74col3lUvyAT16QlTJ8attJppwF8n54gdqY0o6GBFm6q/ZmlCM2U?= =?utf-8?q?wbi+OJ4mYpjwY6llRDX9UGV5ewahDYmsxfvUPBhOrf1MzFqUT+uQrBzVY19hBzvb6?= =?utf-8?q?4E35dX5ei4nR0BL6aa3Xyf+YM1e+Z/q5zT0iVvfT9iiSLmMb4AwlpXPGLaIyttMcZ?= =?utf-8?q?aDThQ80o7QcAKueoxUhrNIu4BPcgeRrtdeHDCHK8Znoo1fCidKU8wywuOEMOlzRMD?= =?utf-8?q?JkcVWe81y4Ok5T3A007h0rszKDHBSkPdoWQjeL2NQTo4b3LK9WEhca9Z7He4HGgAJ?= =?utf-8?q?DW1QUen/GQPqJCKQezJknMAlG0ve8Bru8j+m2tVyywgF9yj/1mZbgATWj+oMY/C0t?= =?utf-8?q?5NnGD0cauRj?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8461.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Rjq+RLQ0BXqGC6u2KoNy8G1jb09c?= =?utf-8?q?YBDhiuffIsKxDzW12Bx3JSQuh9vfZQYfNL9ZutEaSqc3Iw2rqniSZMVJ1AmFXiMy6?= =?utf-8?q?Yz/CMrjGyZ8DLbn58SHGJzjbOYBmnl47Gp9ix4SkWFsN1wPu2g/AT+dbps/Rtqbnf?= =?utf-8?q?2LN1Qco/C+NihDqbtNGfGpcc+vSOYpASpehgN8+P+XGJzExzLpY7Tcjtg7WDFCc5i?= =?utf-8?q?dl+iVYo6/dZRvel9yr092IQ35rZP+1HFGHsup5WyAbdGwvcynT+Tk4ckTTemoEGuZ?= =?utf-8?q?/3+kRKhcgBVVFA8L80L+PnL3YcBGsQYOeKd1wuZSN7QaoMuAcvYUm6iiZPSGZ7GnS?= =?utf-8?q?tGC459Gxe3WMcXQ/aeDR+UXIcDcR3w7MPZLzRAr1iNuXBDR/D4ZGIRjo/7q7CF7hg?= =?utf-8?q?kj9QMxpd9CiELmXvzyVW0qc0cgebSJ0ekE9prqg6V2tGDdv3GSMLjzyEXNu2NHdf0?= =?utf-8?q?SwKh42QYklxsad8CoLYbGiXInGBSbCDMDo1udUQWyGHNhjCM3A3jV4QCNxx4zZKLl?= =?utf-8?q?hJm0rFlziRojM1pXvXwta+ubXfeF3neQAdX0y+TOmazWbAGaLQkkwf4aN7UCgWQPQ?= =?utf-8?q?QxcLo9rUsvznD6rfrUrDDfQvmykt+QHzP6DMdhSc6iqJvuXBN5zeyEmgfQ7uF8/R0?= =?utf-8?q?uPcLCmVng0lZoLrhoCAFlYGDU4jtCOdeAsfrtpiI9qpbtaTYgIPp4a7iUNxBxUaoB?= =?utf-8?q?Omw8JEG6i10QtPiO/sVvHkWqxeDPBc9wAgu9C2VXlJKr0R4IKgxaWbqdjqCTOjzf9?= =?utf-8?q?2l5xHY1aLQaAE+ZpLGaU9wO8PPbh/pxfqGXxCBHmd99lpnooeHKqj0QRrNypdNssm?= =?utf-8?q?kZGVd8qMg+mjR6Kg83asWNNwvropWLdKpVpQz9nrNTjYpWrLlGHg26iLROi0UHpDq?= =?utf-8?q?282h4UB15jXI7jzbWyYn6tBUbJtIMWlmgr3C3akjIuZ0OgXh5992QVlJFtc0RuvoZ?= =?utf-8?q?5YDwJo6gyG73cRHR47YH6FCwzE2CdY0bZ3Fs69HP4eLU/fru4AhhkDCLKKdolPLAv?= =?utf-8?q?2TjLadCLTlUVxXwEAnQLshUQcnTO3ujC97CJeDaTHLV8cFDb9bEUp5gqdkOszRD32?= =?utf-8?q?ZkFc1SJvK/F8IyvW+AGJYt1/LpvN7ETcBPDqm0KqJ496i5GtGyir3FJKU1ahkRw+d?= =?utf-8?q?t6unfu7OfPDvXUkArg47GI/5SbxKqb9ekn+h7O3asSXHmHQHHY1eopVlb+eN29OsF?= =?utf-8?q?jIF+FLTjyUrVQltIi+zYwkUvowwh1ADTwLRQryzjW3jfixKW7WEqhGGnLPcrMUhZF?= =?utf-8?q?5FAcPed7BgWVR1JG8fiHcYhHl+cP+WAc+9PGvH2rkqLb51WUrnsQTN6x6RU/VE55I?= =?utf-8?q?X9IdhZtHUPZFzehpvOA4jDvo80pWS/MxYgbkNld2TV7GTQeqcDuZtaY9+A8sq/4xE?= =?utf-8?q?CQ90CLNFz7YFU3etWbYlLk7PtQzzwNRbnY2bunfesmGfJ1wtuCs+E1RLA6CSN+eUI?= =?utf-8?q?pcEGLPVaCk8ZuIxz0ujPj+fUiwQckGcEs3pKR6A1knrR5hvW/ZJW0U0b0VK5ATzqs?= =?utf-8?q?3Vws6o59qdva?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3490782-e556-4be6-8bcd-08dd24bd2440 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2024 08:21:33.3042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uJZn4eyONZYSzxUJoxGIIQFYHHwB/kl/WVd0ZVPRqfst+1QQoI49YdSIkQ0PIu7jxspGB7qjyJhgkI6H3+SJLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6985 From: Peng Fan For the platform that not compatible with scmi pinctrl device, the fwnode will not be set, so checking fwnode will make code simpler and easy to maintain. Signed-off-by: Peng Fan --- drivers/pinctrl/pinctrl-scmi.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index df4bbcd7d1d59ac2c8ddc320dc10d702ad1ed5b2..aade6df77dbb2c391741e77c0aac3f029991e4bb 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -505,11 +505,6 @@ static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, return 0; } -static const char * const scmi_pinctrl_blocklist[] = { - "fsl,imx95", - NULL -}; - static int scmi_pinctrl_probe(struct scmi_device *sdev) { int ret; @@ -521,7 +516,7 @@ static int scmi_pinctrl_probe(struct scmi_device *sdev) if (!sdev->handle) return -EINVAL; - if (of_machine_compatible_match(scmi_pinctrl_blocklist)) + if (!dev->fwnode) return -ENODEV; handle = sdev->handle; From patchwork Wed Dec 25 08:20:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13920653 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2084.outbound.protection.outlook.com [40.107.241.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5476E18E764 for ; Wed, 25 Dec 2024 08:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114903; cv=fail; b=RC+981xGSlS6O4s2I6OJ591Z4H3p/m2gBo2APfYhy5EZO69XgUfHP8TngfXzT1kqI+4mAI24ThYL1C9ymdfzonZPZOFZ0LjlgfGMMrgMqYCXX3rz73jDlH06yS6TLbWWLAeamzeErTY5/8ssf0VJDqZ3gLMw8g8YNsD74qvbkwo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114903; c=relaxed/simple; bh=B9UmoanG/iyX9ITVIsH+kcW+rPiNsQMH34VSNLslU9M=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=c06Wb94nhoAEPvGuBbaHicEwWC6IB3huqVGJ/AuQ8MWH/3RgUVBnnDfnpOCQaUjUIplgVlKYsWttSzXRk5grnpbx5jc2tW6DkCGLXTOQdHdxet0vi+T6LI0d5+/7C1Ieea3bI0X2BZnhXfzLSIwUAGuJhQQsXzFfQBiJYZ6eZZM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=bFajG8mY; arc=fail smtp.client-ip=40.107.241.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bFajG8mY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mg51SzQIqNXRDfUC/N+gBirlI1pA2G52eu6H64SE3U/Jqpr9/JvS60Ah/ia3ePWhx6/LhedyHoQ6Zu2Ev3U0VK0fYVeL7sHsx4XLQiPpR4jXLBUT9XTFLxfG0HedxypjfVnLqc1IhFNVaH5NkxcU3tda6q9eVrP2qYXkz7tuALfuo6+focTsvzptJlNLUPPK7MZooIjdBIBQ6emX/mNStiudLzIF5EzAcVsVYBqvARbIs44EiYO8Epuqq1jOgf5Mq5CvwNRlEe9bOy+Pit/Q90Pk7wBwg4Qw+wMh1Owd/bX1B8ig+G61/Sbbw0DY1X6GTYN3vFCqj3X6Q+6+HP4FuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C5DRiVkBY/Qmj5Xidop8UECBk7ZmAsnb7qNwdiy5bY4=; b=xKSZEbfaY+IP8pdu08QytQXl4znX/f0gjHsOiETo+FkGv2nPRfECJw0vODm+4GJe/yHy5U830WhEpFIsoZgT8GC1acJ+TYD2IRTWMEkr4dx2dI9AAtW5Uxpcm5k/NoGPt/guzCL/9dS7EY8i9E9r3ltVrThJ/mQi7tP0BsGbzc3lroqUC6U8mcM6KO89aKzumxlxPABImnwkGIn59B4gk3Cqy0IsaQofOlLafXTq3GPXoB+dEhsno+paVrJXTyrlUXtr9s25WybNigL91CiXn6D1ikNSsZ6ZIRdtAkzUsBmWM0RO6gqKQFY2j5inVw78835cnE4ervU/9eQGi6nSow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C5DRiVkBY/Qmj5Xidop8UECBk7ZmAsnb7qNwdiy5bY4=; b=bFajG8mYHqOlM70k9yjppPRRnOL2oMBL72QeUAJE8VNMDjJGTXQMTZr/ZtoPKU3gjU51XiOZCNVUHHYlgGFObJOkj8pa9UeZkMSJ4sfbw0Bh1qOVcB4baZzoPz03fcYS11pK8mc/zV/zvYo/fYC3EGH03UK4RoyzinsTU4TammtFPBUoTF7DyQGJ5TXlSxhEWg9aqnIiof1kICt0TmNKSgidTDCiMqCvTr4YTS22NWczSn/63ieunI3Nr8U2X9iZ4E8VJs5/jJspufG2UfwcMhD09mFVJ2tkUhKyPaqtHNUVjmnsY7CAyfOHlwub9YFjkbgfO6WW2GBcAGOSsjCaxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) by DB8PR04MB6985.eurprd04.prod.outlook.com (2603:10a6:10:11e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Wed, 25 Dec 2024 08:21:38 +0000 Received: from DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197]) by DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197%4]) with mapi id 15.20.8293.000; Wed, 25 Dec 2024 08:21:38 +0000 From: "Peng Fan (OSS)" Date: Wed, 25 Dec 2024 16:20:47 +0800 Subject: [PATCH 4/4] pinctrl: freescale: scmi: Check fwnode instead of machine compatible Message-Id: <20241225-scmi-fwdevlink-v1-4-e9a3a5341362@nxp.com> References: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> In-Reply-To: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> To: Sudeep Holla , Cristian Marussi , Greg Kroah-Hartman , Saravana Kannan , Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735114854; l=1266; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=7eG0vdViAcWDMFwtbA37HE71/cQbz9oKqAxOOgh/B3I=; b=cLKqzw+LzGbMbeOHj7yW2dtjr3VzNTWL+phBGvS3G1CzKImJQ4GFfOFhqIYFN7dLV2gd3Ff71 hlcHNN3vSw+DqQKqgXE/mG5faOEjXaIGrXwHXzG0P+Rw0qhGQKco8Ia X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0003.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::20) To DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB8461:EE_|DB8PR04MB6985:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e397cca-342c-4b2a-f7ba-08dd24bd2737 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?qVDdPJFogCE/MrXOu2uTSf3MlQ+NXgO?= =?utf-8?q?9QWmzq6h/T/jciWpduqJ9tv673lBoCywWRc/3NvzKmGfIRewTKJwFWxQL2+U+jYaG?= =?utf-8?q?p1TJHjCUm7vfm1SABEqKoeGfj4cY2a29MMTZrrwHB2AppCaqD8XwK0ztv+nwC/wED?= =?utf-8?q?rIZE8q6/UkisfjQmu2gYo/2NY0svkYMxs10hfHqO+f2t/kBnQpWQQDP+WN7k5G7fs?= =?utf-8?q?C/e/iwTkpTOeK6iO9ESBSEfqvx8BRzAnQCyQObEjC3AZ2Bl24aAxTxx4hNGDwNCuG?= =?utf-8?q?r8OXgN/4zbnfj8IgMSShGPOP6hnZnIdEtBW7/o3KWqSByUA5kUFHq2kLxQI/PH91f?= =?utf-8?q?/h9QK5II4fQ1Qp1P68t+S1vzI1fFgZTgNZbuIYw3JkPTyQkKiLGVzL0Fp4yVKn8AF?= =?utf-8?q?G0hfHKtLDEfkn9LLxQrBuGFZqzFOjhypZ3OgUfzI0NPYdOQjCcewr8CVe3UtquAB1?= =?utf-8?q?hHAmzkN5o0lgZ0Cf8qWADY+qeRBRtiqiooUf62ni+tXcyr4DCxFF2fpGja85XjdYz?= =?utf-8?q?S415uOypMBXivjjhivpQQ+TYhh53l7eCsl+r25fnGG3/loU4rrN++l4Z2/xymB5DJ?= =?utf-8?q?VADMhsOYAHkUu3CaEQch9l7sP4D8X1VojjQzfC6tSQ3XC2RT1UThjIa0CKseWVhFx?= =?utf-8?q?Puh1kgBcpC3NcaeC42xoaKelrGFZtZtbsmduFzMj5aLRpsNPO9mNMhJTmGB88Im4v?= =?utf-8?q?SjD1e0atiTDWIM/dPsQx7pbkjeBkndv+NHjKWMnAH+INMQvimczY3dnO44IBVyA7U?= =?utf-8?q?/Ie7D9/Sx1Q3idgEnaJu+LSaZ2M5kCk7JriSNYiDFBZlSOGZrm/Nb6Qn9g/PRQm9c?= =?utf-8?q?X9m5gX+QaMOchK2ssHkoJDYtpJOcB7NFCoq/BpG5s+4YC3ZtxJNbCzlcx3j3Mf9CX?= =?utf-8?q?Zwy3g1F0JUX51j4PtwkO90I6btcyP4do+87d7NIiviAiZtO6YlM02hSApQioei86D?= =?utf-8?q?CWnx3hlWWNGgRETuMl54mHWEauL9yFpTLZiT7Iqa8IXWr8ai2W5U3PgBoSGzf+fB2?= =?utf-8?q?oGp372jLQIXagJgawqq+nFZX9FIPnPL0Kf4dL3p54bi9NllVZ5ztVdxGITTwzd4/f?= =?utf-8?q?oZMiAasxKjeQzJrGlgAFV3sZf0eXmrUrISYQ+59sdrGixjE3zQUuGrE4LxUlQMVdL?= =?utf-8?q?3bMPo7SLnTcy7xWESaXlqKn7PB6BitHmZLAwrxKU3VEQXV1eRYoCqj23UGcG0GPSO?= =?utf-8?q?utdGtqcubepRk2JuDK9T991LZcD1z4aZA6cSYFvSfNvRnHEr2ZeqrDNDL3HCzTgbR?= =?utf-8?q?+8V8EzRof7GySkjZcc9oQ1znIXZNBTR/oQvXLv27AVcIhyGzTzu5e31z0Sx6Eptrd?= =?utf-8?q?VJR0JTBKnrUi0QIQH82Q8BHcACXcc/eDEmoLWcVe9uo/AppUEuLyDMPWyafOBXmrf?= =?utf-8?q?JqCG3qofTkm?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8461.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6++3Q9twts9oW5xtj4jgRpiZy5Dy?= =?utf-8?q?1z8kMmo3wP9l8TS6xY3G835OH658yrMcBVxzHlBv9aqimL53LNCVgpcOR32vWGxXk?= =?utf-8?q?f2pT474KZTXE/DUVYgZAIIqUSZtI9SEAVyCMFaBNtaY1VSGpYheYZ+mux1gO0W5zb?= =?utf-8?q?DXJ+WGZqP5UnpV5V/ZIKW58loXTetj+nXSXWjGi4IKtLl1W2pHY0clq+1s2Fhx1t8?= =?utf-8?q?+LR4hL7GKxB+OhCYxJtKGAWl7hOJMLGx8bGICOu3fLMxwTdSTLvohlDRFdocbT0hz?= =?utf-8?q?VEEXCi7Vlp4meK9NFtCdwAS5jr8buA7mBGc7mwvHwEkq/agTawraPwLrYy0/TTGTQ?= =?utf-8?q?vm+U4u0zRxPwRRs9p2f4Y8+20K0WwU43SY0hBYrNvQAEYkN9Y5zJad/Y9E+hQKbSx?= =?utf-8?q?BSca6lepPadsxaGeeC6uWQbgGOgQx3G139oHNgHrjSFH01HIR+3G08oilsbE9G053?= =?utf-8?q?2nyCjAu1bDg6cX4NIcCqWqmHDNhUh7QhrzwsVWbB/4DujS0YheLrs5CiZXntDDLva?= =?utf-8?q?9DVVKu/g1wR/k/qmWdj8n1PQDU8RfTsOvs4AlHmQWOq8BWg7YtOvOATLSfqGTVVge?= =?utf-8?q?sNNVnwwW3qnCzc1vjms/dibE8Uzcerq2IRzKnC0zkdJgRBA9njQAbUDJxU3RjDQ40?= =?utf-8?q?G3swMOxF59jIi3Bl5jYwvYcezK9r55v5Gx7SYFS99i/iz+0AdV4jvNVeosI3v7GYB?= =?utf-8?q?8flrgcNQRR6bqW4GJmn9DNSILkCFw0K8FRymi29Wqt35nkVkCBvc3+1dKUP5ZjiJ6?= =?utf-8?q?uATkd/bE4PjaNh0NFBBmTv9akYIeLCwPayfoh9ZrwioweYWR6ypsGre9OFoGACK6q?= =?utf-8?q?IcLjG6/J54ZPkRLatYdngOcj7TGMrkTAs75wvuuFafoFAZAP2c70YPvzKnp+zvTDl?= =?utf-8?q?vHp+rce3W9DwzcR8VA4csBNKK4mW8A6iGKoEQ+Uz/2nfAXdh+YrV6s2scXMoSgyTc?= =?utf-8?q?m2nmGIxXeDkxz93moPnnvSK/0WU9hZ/GowQLmwqRp9ja9xLgmv9UEicapq/1a00Fb?= =?utf-8?q?0MpRf7juMmqFkTxbnUar/GhRvpYWqUL8PiGNMvGWf3I/Tg5pHGGZnr4WN1RUG/Cmt?= =?utf-8?q?IgurrTXXCkGjk7avfTxZBAw7m453b468bB39fzyc/JEhdrjMJUtW4vWULiO2pV4CW?= =?utf-8?q?N4vZYlFmUlPl5r9w6VAUOhQ716/Re5e+VWbMrUfpe1qZrpNOPBWmsQhPD83ABWHmT?= =?utf-8?q?xpMtaOVJAlcNkQ1Ttr/EJkl0aSlMEAOgAUZUS3Qvh/mbiN9wsN4uWQAmOrxYdCisr?= =?utf-8?q?MNzSS7d2wVubfmwI0o3XdcBDricnl2r6dylG/u6KBsJ71W3P5XeoG/GjjAQhTX1dK?= =?utf-8?q?YldOwFvmNU3a1muvjJecosmVUXnK87GpMH1slCY+aMWxPVF6OjdYEhe4OI4B85Mk2?= =?utf-8?q?vqXVcnRY6qg942o+USl3rfA1aqb1rJnzWbIEpcoRmt4Qz+98EA8YTAin/qsx95IaW?= =?utf-8?q?BTucqWJEKz6sN9VDA2tv75j5w/i/oGdkL/aeKrqvA2fkfC2OX3+gtZiBT/3t25/69?= =?utf-8?q?XSGzh0CjMOU2?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e397cca-342c-4b2a-f7ba-08dd24bd2737 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2024 08:21:38.2799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yQ62ZNGJNnrecRBKfBALn7MdgWhKZTW4K/wkFu8XLb17Ju7upFQJATTv/viyVbiwecBJuW9gbqjQTwa8XGgMiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6985 From: Peng Fan For the platform that not compatible with scmi pinctrl device, the fwnode will not be set, so checking fwnode will make code simpler and easy to maintain. Signed-off-by: Peng Fan --- drivers/pinctrl/freescale/pinctrl-imx-scmi.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx-scmi.c b/drivers/pinctrl/freescale/pinctrl-imx-scmi.c index 8f15c4c4dc4412dddb40505699fc3f459fdc0adc..5277d30af7084b9bbf83e3523f09c8136d41705b 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx-scmi.c +++ b/drivers/pinctrl/freescale/pinctrl-imx-scmi.c @@ -287,11 +287,6 @@ scmi_pinctrl_imx_get_pins(struct scmi_pinctrl_imx *pmx, struct pinctrl_desc *des return 0; } -static const char * const scmi_pinctrl_imx_allowlist[] = { - "fsl,imx95", - NULL -}; - static int scmi_pinctrl_imx_probe(struct scmi_device *sdev) { struct device *dev = &sdev->dev; @@ -304,7 +299,7 @@ static int scmi_pinctrl_imx_probe(struct scmi_device *sdev) if (!handle) return -EINVAL; - if (!of_machine_compatible_match(scmi_pinctrl_imx_allowlist)) + if (!dev->fwnode) return -ENODEV; pinctrl_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PINCTRL, &ph);