From patchwork Sun Dec 29 14:44:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922731 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2231C1607B7 for ; Sun, 29 Dec 2024 14:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483510; cv=none; b=R7uoaoBCLMytTLAqXzMzDVXeY+T2h4pzWuv0ruYrzybVoU8d+XLqTLjy/S4EeFPXPKyJR9xld3HPHAQLKw0c/DZD7DP93fDfZMLF6ph43zH0YaU4LU+SBBA9+OQ3fYWutCCV9HqeHoa1ZiT75QuC732J/VJVrHLA4f99GxUzJCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483510; c=relaxed/simple; bh=X7d1g/MzFestKB8fyf2XWUC+/CtY4lYz38c5wuqbFOU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Zar5unpdDUaI/UUmdhoWrJOvgDKifzLa1AYT2wg05MyFz/3wfZhBDXIGjZjAxl+Iz0hdQ9DGUU33ZvKHbHi6WxjjjvDQiCK+ty8sfEAeCMAHPQss5o1RiEVSq6djJXIJqmVAMVYjlHYvgl8le24KLovq6gljsP7mOzTtzZvc5gU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nV6tbjig; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nV6tbjig" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483509; x=1767019509; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=X7d1g/MzFestKB8fyf2XWUC+/CtY4lYz38c5wuqbFOU=; b=nV6tbjigo8GOCwrCzUVKGkfCUNWBz+lq+kA0vDjYyFR3cz8AXqfj2U1Y /f26KyJcubm9f1SB00Ej7g97sRUMuGAIqyaACSpYrzoxR07NZv0UFIIlI Zr+K7vbekJr/qiuW3lOmzCnjcQvmtcW/igqXJQCWjf6OLcREYu6ye1EP0 kXfoFPcMIOmk9ADw7zF+vmZCKAZ1PXmfGIeKvbRVA0rt9AgPYjBSiDTXL yLkEpQGfoZlvr0x//yrrgb/gGQhg29dXJna5jIoz4/aRE2UOPAcyIiQlN pjWvoo2eJLX3e35aNSLJQFR6hn7nbtXuAeNws4L4R0fM3AhA56u6Bcjf9 g==; X-CSE-ConnectionGUID: q2koCFwkSZOf8BwwIv7paw== X-CSE-MsgGUID: plMwyQw/RzajzCGMDgR5/g== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572425" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572425" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:08 -0800 X-CSE-ConnectionGUID: tpuTzr60RtaUCctCxxqEfQ== X-CSE-MsgGUID: zYhmUGugQ4GTFkiVxiVITA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656779" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:06 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Emmanuel Grumbach Subject: [PATCH 01/17] wifi: iwlwifi: mvm: avoid NULL pointer dereference Date: Sun, 29 Dec 2024 16:44:36 +0200 Message-Id: <20241229164246.31d41f7d3eab.I7fb7036a0b187c1636b01970207259cb2327952c@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited When iterating over the links of a vif, we need to make sure that the pointer is valid (in other words - that the link exists) before dereferncing it. Use for_each_vif_active_link that also does the check. Fixes: 2b7ee1a10a72 ("wifi: iwlwiif: mvm: handle the new BT notif") Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/coex.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/coex.c b/drivers/net/wireless/intel/iwlwifi/mvm/coex.c index 36726ea4b822..21641d41a958 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/coex.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/coex.c @@ -530,18 +530,15 @@ static void iwl_mvm_bt_coex_notif_iterator(void *_data, u8 *mac, struct ieee80211_vif *vif) { struct iwl_mvm *mvm = _data; + struct ieee80211_bss_conf *link_conf; + unsigned int link_id; lockdep_assert_held(&mvm->mutex); if (vif->type != NL80211_IFTYPE_STATION) return; - for (int link_id = 0; - link_id < IEEE80211_MLD_MAX_NUM_LINKS; - link_id++) { - struct ieee80211_bss_conf *link_conf = - rcu_dereference_check(vif->link_conf[link_id], - lockdep_is_held(&mvm->mutex)); + for_each_vif_active_link(vif, link_conf, link_id) { struct ieee80211_chanctx_conf *chanctx_conf = rcu_dereference_check(link_conf->chanctx_conf, lockdep_is_held(&mvm->mutex)); From patchwork Sun Dec 29 14:44:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922732 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B60018E34A for ; Sun, 29 Dec 2024 14:45:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483511; cv=none; b=sBcJpFrSTzxu3Q5K7+NhZFh3IiedyxraghoDql+2aLqLxw1vP1Nwxhsgr3i84DQEppuDx+bjG4oAtRCQOkmCo3gi5HZSGfadZ8bdMKPTKYLlfmsqmKZmT2aCok9vanE49qRSqIKJPlKp8z3ltHhii5wx0LMpSrtTNM+FR8OXY24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483511; c=relaxed/simple; bh=xrTkA4CXCXZBqeSsOUcif0RrVXU2R0EvNOBlTA/cJ2A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KbRTo/a3rNaId71FIqAGNUkex+lEwQQZ63jk0lCmbck7/7SjbzfEm0hvFDlNwmFUdFr4px0l2P8JYV5b+xRlpUAN/meP+HADz8l2ewE9JYwc1+RYk9Jh7kCgjctIQNx8e/4a5uEFrFtXiah3OmUWY20eRIqayuUB/Rv2ZJEUwDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HaF9mnzL; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HaF9mnzL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483510; x=1767019510; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xrTkA4CXCXZBqeSsOUcif0RrVXU2R0EvNOBlTA/cJ2A=; b=HaF9mnzLhF3PEtbwPDFIqvCoZWIn93jbq00+xOEUkAu2nvZteAICZEls xboxqukA2X9LL9WnJFIIr6iXXaZTDyrng/5Qi+6whVvZsd8xO6ovhvr4B S7b907ICEZOGAd6x1taoCXqbvB0kfFDKfvZAlSlhs7cwufYSWc2T2RTak hoV1tW+UGSo4itQuNWUayC438mZ1xexuFSJAsoarRnUdj0o5YHavtO+5r ameKz1ykZwqmy60qEC65ZJIg5Qoo/HoJPbVvCFA1wc0PHIbbCRJDmZN3Q OaMYfKTKrvQtHYOjZ2ecttZZBHGftqhLdMlTal/Jm5E++OgalnVOwTKGj w==; X-CSE-ConnectionGUID: HgA2r1AcSt6b/yfd/krhUA== X-CSE-MsgGUID: BRCxfXOnQiaTLkzWtSFmUA== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572428" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572428" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:10 -0800 X-CSE-ConnectionGUID: O6vQ4zCqSrq8boLRJt6JuA== X-CSE-MsgGUID: aZU7YxYXRKSVRIOoGfkAxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656803" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:08 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg , Emmanuel Grumbach Subject: [PATCH 02/17] wifi: iwlwifi: fw: api: tdls: remove MVM_ from name Date: Sun, 29 Dec 2024 16:44:37 +0200 Message-Id: <20241229164246.66e17791c392.I6998e263973c26c1e22b4f470b974a519011b29a@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Johannes Berg The API isn't really MVM specific, it's just the firmware API. Remove the "MVM_" from the name here as well, as we've already done in many other places. Signed-off-by: Johannes Berg Reviewed-by: Emmanuel Grumbach Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/fw/api/tdls.h | 8 ++++---- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/tdls.h b/drivers/net/wireless/intel/iwlwifi/fw/api/tdls.h index 893438aadab0..cfa6532a3cdd 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/api/tdls.h +++ b/drivers/net/wireless/intel/iwlwifi/fw/api/tdls.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ /* - * Copyright (C) 2012-2014, 2018 Intel Corporation + * Copyright (C) 2012-2014, 2018, 2024 Intel Corporation * Copyright (C) 2013-2015 Intel Mobile Communications GmbH * Copyright (C) 2016-2017 Intel Deutschland GmbH */ @@ -10,7 +10,7 @@ #include "fw/api/tx.h" #include "fw/api/phy-ctxt.h" -#define IWL_MVM_TDLS_STA_COUNT 4 +#define IWL_TDLS_STA_COUNT 4 /* Type of TDLS request */ enum iwl_tdls_channel_switch_type { @@ -128,7 +128,7 @@ struct iwl_tdls_config_cmd { u8 tdls_peer_count; u8 tx_to_ap_tid; __le16 tx_to_ap_ssn; - struct iwl_tdls_sta_info sta_info[IWL_MVM_TDLS_STA_COUNT]; + struct iwl_tdls_sta_info sta_info[IWL_TDLS_STA_COUNT]; __le32 pti_req_data_offset; struct iwl_tx_cmd pti_req_tx_cmd; @@ -155,7 +155,7 @@ struct iwl_tdls_config_sta_info_res { */ struct iwl_tdls_config_res { __le32 tx_to_ap_last_seq; - struct iwl_tdls_config_sta_info_res sta_info[IWL_MVM_TDLS_STA_COUNT]; + struct iwl_tdls_config_sta_info_res sta_info[IWL_TDLS_STA_COUNT]; } __packed; /* TDLS_CONFIG_RSP_API_S_VER_1 */ #endif /* __iwl_fw_api_tdls_h__ */ diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c index d34ce4ffa980..6e0e12229672 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c @@ -3919,7 +3919,7 @@ iwl_mvm_sta_state_notexist_to_none(struct iwl_mvm *mvm, if (sta->tdls && (vif->p2p || - iwl_mvm_tdls_sta_count(mvm, NULL) == IWL_MVM_TDLS_STA_COUNT || + iwl_mvm_tdls_sta_count(mvm, NULL) == IWL_TDLS_STA_COUNT || iwl_mvm_phy_ctx_count(mvm) > 1)) { IWL_DEBUG_MAC80211(mvm, "refusing TDLS sta\n"); return -EBUSY; From patchwork Sun Dec 29 14:44:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922733 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB8B19259A for ; Sun, 29 Dec 2024 14:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483513; cv=none; b=EmmGDF0efUXNiv4j+lgrgs5sIKbCNwPWzRtsZT+S7Z9O80nJMh85I5BcbER12N8r465Dq393YLmLi/VBzUndjRBGCyA+voheFUdI6U0p3iHYJvuGMLhXVIP2cI/Qe5vemVlPIkmtPFVg3zCaIuX2MU2N63Z0KWDCycmCkTTjK5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483513; c=relaxed/simple; bh=Ul3G9q8SK/lsU1gEPNNwiD9JqH2XDjr8CzN8SRDASPE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FhA7C+0mrjL6uHQYRKfmw9NEeOe8eS5f2F2+GQi7cSh4UepRseIXRodzsCArEfPTjseyc8hT/Rt67VjLii5Cv69OGz95+KiSeMr8D/C7IHqgZjpbokxJIO8zn+RELUE5knPS+oa0lKBBfHcbuMJiMdNtsKJXQeVXky8Z3ujG6Jo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ilopc3kr; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ilopc3kr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483511; x=1767019511; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ul3G9q8SK/lsU1gEPNNwiD9JqH2XDjr8CzN8SRDASPE=; b=Ilopc3krPe6l297E53vTC0o1mERzVbc/nddGxR3PVUjg9oeVmIIjF2Mh ot6iHaBf7CXs2NAHzjEGeF/ze6DXlSson6mP98IOFC2MjZHRTizhDraCh CSnW27X8sW2bmePwgzwgArRmX5t0OqYeO4N/VIe2uRTWJSho/C/ZUKJbi jj/WXttVszh4BO9TNh0JpqEb9kvUdZygEe6iAhmT3YPvo/PJwtJASGfba OhtB2xPZb2bocZfMxX7iLRbwxgV5FNZcSpcPKo1cEl474XZwlCCTSOLht KRnGIgp1vuRpKt0s0pLLWDKE/54mR8EJVFmjsYC8UnU/pMBTEtEQFJyR7 g==; X-CSE-ConnectionGUID: YHmHFAONSs2SjXzBZRCPJQ== X-CSE-MsgGUID: lnoaYI7VTfev1jmyTuEM8w== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572430" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572430" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:11 -0800 X-CSE-ConnectionGUID: FlYl874JSUOSiE0LXKn9Wg== X-CSE-MsgGUID: rSfgF4RHQZWORFGQjB2lSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656824" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:09 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Daniel Gabay Subject: [PATCH 03/17] wifi: iwlwifi: mvm: don't count mgmt frames as MPDU Date: Sun, 29 Dec 2024 16:44:38 +0200 Message-Id: <20241229164246.80b119bb5d08.I31b1e8ba25cce15819225e5ac80332e4eaa20c13@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Daniel Gabay When handling TX_CMD notification, for mgmt frames tid is equal to IWL_MAX_TID_COUNT, so with the current logic we'll count that as MPDU, fix that. Fixes: ec0d43d26f2c ("wifi: iwlwifi: mvm: Activate EMLSR based on traffic volume") Signed-off-by: Daniel Gabay Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c index bd09bd0ca930..f67afb66ef2b 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c @@ -1808,7 +1808,9 @@ static void iwl_mvm_rx_tx_cmd_single(struct iwl_mvm *mvm, IWL_DEBUG_TX_REPLY(mvm, "Next reclaimed packet:%d\n", next_reclaimed); - iwl_mvm_count_mpdu(mvmsta, sta_id, 1, true, 0); + if (tid < IWL_MAX_TID_COUNT) + iwl_mvm_count_mpdu(mvmsta, sta_id, 1, + true, 0); } else { IWL_DEBUG_TX_REPLY(mvm, "NDP - don't update next_reclaimed\n"); From patchwork Sun Dec 29 14:44:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922734 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D0F91946B8 for ; Sun, 29 Dec 2024 14:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483514; cv=none; b=aGb3zfW5zjbJg0rmSCwCa7crj8Bk86bEqbCR4vQYrpnmnDhwUsBxf5JhTjgvjgL/XQmcWXBvDCpJmke066g6J5DveZ24smHWWPjXH/5kZBoz1K0c2LWG8dZKj/yML2sAEaE9AQi4Xo+zPMS0ej4JRK+sCACD5Cb2YAcdHbHx00w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483514; c=relaxed/simple; bh=n7ZzYv0/bSucDD/F3ZK36zL+wf+hjPXpPj1/JeCgtlk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Xb7Q0fvnJ46sRWjDT4zO40tbdn8b4YGHW1zfpOM1j9VfE8OlScIViwOpMNcWsxK9m33dE3LC9j1yJ9mcSUSU2uyrsYlIRYuzMY4x2ZTms2MrWrYRvLSkA6ifwOgX7Tp1Mul9chBBfrzS5HCfRRU+l96QSpoMk+i8/sN97bWgZ9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S3K5nUtv; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S3K5nUtv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483513; x=1767019513; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n7ZzYv0/bSucDD/F3ZK36zL+wf+hjPXpPj1/JeCgtlk=; b=S3K5nUtvSqvC3voMjK3lcTNF0gDwodkSAsaTLOxtYjK5b/6/GSDjyLuy e2k5h1fMM68e0gMWjxn/fFU2SzzcTFictq4A1VuAQ0A+YTAMZZTbwev2T bXheNHCIz0ammOfT8rcfF8E9bv0uYP7JueXCGGzSvY7gGbmol8zq2jrRE LCohQjWaUKDA7UwXq1osnA7NNWzj60MwfkYybyVmH+4O6OjMUV6p4N06X I88PYvznx9NBy1K2dTF9C8703XpblMOrxSvRGB8aRzTsqlojKW60SGJ0j ZX/L98p4LWfFKNZJ4R4LyAfyJHxmhAWKQb5OpHaqLDN09cXZnRoPzdwqb g==; X-CSE-ConnectionGUID: xydMeTWvSTS4jzPIP/erMA== X-CSE-MsgGUID: lpWO4SAsQbmvlA9MBwN23g== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572432" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572432" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:12 -0800 X-CSE-ConnectionGUID: OvgXBnkNQWSAu9eVOv1jcA== X-CSE-MsgGUID: qCruMnEcQJOVGP0OBjcj8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656874" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:11 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Emmanuel Grumbach Subject: [PATCH 04/17] wifi: iwlwifi: cleanup unused variable in trans.h Date: Sun, 29 Dec 2024 16:44:39 +0200 Message-Id: <20241229164246.1d04ce18a0ec.Ibfac364163b55b52196d30ff2b43945c5aa804a9@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Emmanuel Grumbach Remove unused fields from the transport API. Signed-off-by: Emmanuel Grumbach Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 4 ---- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 3 --- 2 files changed, 7 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h index 0a9881c3291e..45c5245136a7 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h +++ b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h @@ -633,8 +633,6 @@ struct iwl_pc_data { * @n_dest_reg: num of reg_ops in %dbg_dest_tlv * @rec_on: true iff there is a fw debug recording currently active * @dest_tlv: points to the destination TLV for debug - * @conf_tlv: array of pointers to configuration TLVs for debug - * @trigger_tlv: array of pointers to triggers TLVs for debug * @lmac_error_event_table: addrs of lmacs error tables * @umac_error_event_table: addr of umac error table * @tcm_error_event_table: address(es) of TCM error table(s) @@ -669,8 +667,6 @@ struct iwl_trans_debug { bool rec_on; const struct iwl_fw_dbg_dest_tlv_v1 *dest_tlv; - const struct iwl_fw_dbg_conf_tlv *conf_tlv[FW_DBG_CONF_MAX]; - struct iwl_fw_dbg_trigger_tlv * const *trigger_tlv; u32 lmac_error_event_table[2]; u32 umac_error_event_table; diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index 7250c85fb6e6..f5ff700d0665 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c @@ -1479,9 +1479,6 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg, trans->rx_mpdu_cmd = REPLY_RX_MPDU_CMD; trans->dbg.dest_tlv = mvm->fw->dbg.dest_tlv; trans->dbg.n_dest_reg = mvm->fw->dbg.n_dest_reg; - memcpy(trans->dbg.conf_tlv, mvm->fw->dbg.conf_tlv, - sizeof(trans->dbg.conf_tlv)); - trans->dbg.trigger_tlv = mvm->fw->dbg.trigger_tlv; trans->iml = mvm->fw->iml; trans->iml_len = mvm->fw->iml_len; From patchwork Sun Dec 29 14:44:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922735 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8579191F74 for ; Sun, 29 Dec 2024 14:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483515; cv=none; b=TQickiaOYpqyac7PtdZ/cxjcHWktYtg/OHzG4Uje6FiWD4uv6zCgcVf8v5KDRo9PDgH7ioBwCxpLo2ndALWB3fqaSU98gE25PI5L+el/az5AVku2RpPvhS1/tP6MR6LM2l6xoxgF8jiB093xCEGKxcg7JhiK9ErenPVYBrwTyBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483515; c=relaxed/simple; bh=4WPtpO5RmuL/owV5jmdMaAC6YaWYsMI6Fzi3DU/OuNM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rPhr7R7pK/IT3kQzcGZpRoBZDYJK74pf3QxTzmgwlqhukcl3pA7ZWIhLMIXR1Q3H11JvCpy4xzLpzH8uGj4XNWEbPeGhdiGmYJg4YvNmj01InYk3lAsy0qRFYITkEhsAErBJc2RL2XvBU99GHeWx10jnHG+kV+bTxpMtA1stevY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eEJ4V1M/; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eEJ4V1M/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483514; x=1767019514; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4WPtpO5RmuL/owV5jmdMaAC6YaWYsMI6Fzi3DU/OuNM=; b=eEJ4V1M/NaEnNdCgUIk2289B+4V3/8KjqESCoCv07Wp+q8FISyv9slT5 2Rsd4RlhOyF/NrCKjUyRQ38VoccHYFRRnPevTjIfdpmt7aopwNyH6EC00 PRNbhZsw7ExqFu/YoEYsri0FPsqjUx+isu0fTshbT7zshjt52YcPVMdvj vv0D14DdGn4ygwBuwK11LSUKNBWCcmqvSE9nVlZj/kzhEbzQaBDIMu44I 3ttfRJZCraMZCnAhfttFyConXLsJcZ7xGq7PccRwyMPQd8oR8hbL1gHiU ubl9+s1upr8hGeHqMrJET0blgeLAt7dGVxm556AwWTPDWDGdzXVN1G3QJ A==; X-CSE-ConnectionGUID: y86fnzxwSfOUpAQA+Wa9WQ== X-CSE-MsgGUID: V05HzJCqQlumnxS32l1MVw== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572434" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572434" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:14 -0800 X-CSE-ConnectionGUID: y2sZ/GEPT2+LvhTc4RkIFw== X-CSE-MsgGUID: TAzf2S5DQQmvlujlkfXtcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656904" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:12 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Emmanuel Grumbach Subject: [PATCH 05/17] wifi: iwlwifi: mvm: s/iwl_mvm_aux_sta_cmd/iwl_aux_sta_cmd Date: Sun, 29 Dec 2024 16:44:40 +0200 Message-Id: <20241229164246.ca3b97e29365.I70641851f9e5210ec3a7033db38a45d24814083b@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Emmanuel Grumbach This is a firmware command and is not specific to the iwlmvm op_mode Signed-off-by: Emmanuel Grumbach Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/fw/api/mac-cfg.h | 6 +++--- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/mac-cfg.h b/drivers/net/wireless/intel/iwlwifi/fw/api/mac-cfg.h index 37bb7002c1c9..232e20482e2d 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/api/mac-cfg.h +++ b/drivers/net/wireless/intel/iwlwifi/fw/api/mac-cfg.h @@ -46,7 +46,7 @@ enum iwl_mac_conf_subcmd_ids { */ STA_CONFIG_CMD = 0xA, /** - * @AUX_STA_CMD: &struct iwl_mvm_aux_sta_cmd + * @AUX_STA_CMD: &struct iwl_aux_sta_cmd */ AUX_STA_CMD = 0xB, /** @@ -641,7 +641,7 @@ struct iwl_sta_cfg_cmd { } __packed; /* STA_CMD_API_S_VER_1 */ /** - * struct iwl_mvm_aux_sta_cmd - command for AUX STA configuration + * struct iwl_aux_sta_cmd - command for AUX STA configuration * ( AUX_STA_CMD = 0xB ) * * @sta_id: index of aux sta to configure @@ -649,7 +649,7 @@ struct iwl_sta_cfg_cmd { * @mac_addr: mac addr of the auxilary sta * @reserved_for_mac_addr: reserved */ -struct iwl_mvm_aux_sta_cmd { +struct iwl_aux_sta_cmd { __le32 sta_id; __le32 lmac_id; u8 mac_addr[ETH_ALEN]; diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c index 019839604011..b9c0334daa43 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c @@ -121,7 +121,7 @@ static int iwl_mvm_add_aux_sta_to_fw(struct iwl_mvm *mvm, { int ret; - struct iwl_mvm_aux_sta_cmd cmd = { + struct iwl_aux_sta_cmd cmd = { .sta_id = cpu_to_le32(sta->sta_id), .lmac_id = cpu_to_le32(lmac_id), }; From patchwork Sun Dec 29 14:44:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922736 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC931957FC for ; Sun, 29 Dec 2024 14:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483517; cv=none; b=u8/Clh+w60V369vjZ95B1ssaWfKMxiyEmF2hwlZoLgETKTuIkEUw6I5wUZC8rubw5SSUuazW9qaHfViGK1zEL2BUrkWx4P7AXf+3rLtio8SpE/SlwUH0+tPx2kfVziWQcl5PLIYiC3SEY7HwdzOB1iX6omGCh1CM8U2pkuW46Jg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483517; c=relaxed/simple; bh=498tFDKw3O1/sO+AlB8SFBIny3nje5rH6LuY7qdcTCI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sG3LmpxbEmnu/70ad7aP6hRWevuZX2A8AkRZt6VfYkSLWCvYtLesHLogrN4e7esO126idMr7ODDcZLh3Kv30RWXmvOX2CkXi2g7PacLVgQf8s1IEspiiJb+1+N+pgDFq98pypt8rBf4QJCAovB5fIQ4FST2l45NpEP0XUr2RdrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h5n8Pghj; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h5n8Pghj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483516; x=1767019516; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=498tFDKw3O1/sO+AlB8SFBIny3nje5rH6LuY7qdcTCI=; b=h5n8PghjBs6HKKrWC0ABab87LV3ukBUIIfxCKIjSYnkm4mo/frDtq4Pd BNjpQgkJbeW0wcJqTzwbrOWdy9ljOOR+skT4iU+mRLGbXvrHv7H4AqKq8 5IPV/yKXsv5l7SmWPj7Eso4Xrm6HCDpkuhgIpclrdz6TeZi/8iKL9VtwN w5GxQswAAu/DRv0A1emCEi6RuOs0P6b/IDKYwq8OXT+ji9gILEOOo+C0m jMnSYHeVk4lgntePterjKv7HB8jJDKGUANxD2ZV9waB+GMZk9gPWD3enw /iakpLHFcEK1lS0Mz9sf3qFnJZ9ukennGP0L9yu4PSoFw5478wPfatAOf A==; X-CSE-ConnectionGUID: /zjBrCQVS6+HVLVx870ucw== X-CSE-MsgGUID: TQjXMf86RlKFQFAZerS4AQ== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572437" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572437" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:15 -0800 X-CSE-ConnectionGUID: MRPIyycNTYOzmSWEWDLm0A== X-CSE-MsgGUID: bQ1eBirBREKCHHbYL3BJDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656917" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:14 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg , Emmanuel Grumbach Subject: [PATCH 06/17] wifi: iwlwifi: mvm: fix AP STA comparison Date: Sun, 29 Dec 2024 16:44:41 +0200 Message-Id: <20241229164246.08b05aca37cf.Iba1a6a637a758691f710dc4f3f03bd1d960fb087@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Johannes Berg This should be comparing the AP STA, not the deflink firmware STA ID. Correct the implementation so that statistics can be requested for the AP, but not for other stations that may end up with the firmware STA ID matching 0 in the deflink, or so. Signed-off-by: Johannes Berg Reviewed-by: Emmanuel Grumbach Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c index 6e0e12229672..359b8bf25e49 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c @@ -6280,7 +6280,7 @@ void iwl_mvm_mac_sta_statistics(struct ieee80211_hw *hw, guard(mvm)(mvm); - if (mvmvif->deflink.ap_sta_id != mvmsta->deflink.sta_id) + if (sta != mvmvif->ap_sta) return; if (iwl_mvm_request_statistics(mvm, false)) From patchwork Sun Dec 29 14:44:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922737 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465F133062 for ; Sun, 29 Dec 2024 14:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483518; cv=none; b=FOW4gNHiKXqV0wAg36w1gGF/Lx/YKkq8TtD5IyPnABSpFAkPklGjBltLSlNl0QDYcvC6u2Jwg9g7ch48IsMnLUbmkPMTQOdT9AtMWGBE/AhHGXMtIM7xzFC+nj8EuIFsChmdnhI5b6k35i8EIjR8IE5oyGu8ZDf9Ab9XIV7qb3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483518; c=relaxed/simple; bh=ZC5pRzfuRIux8chj7mLzqB4WGR19U8Fd9ysW8qsUGfQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HXR8T+SYIX1QGlQEOPT8lacItlYG4HSsbShglvfyEewUJIpBticxOtEgHCWz8ZJPz6Ob/dLgj/4mdF1QVbKVVvZOsoe9C4aAd6fIwsQPlta9T09L0/Vcwrc8S6YSrAxo8yv9OfynIZFfcUNzNLnw71Feuh9dTK47CwudETfVop8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GI+0Q2os; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GI+0Q2os" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483518; x=1767019518; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZC5pRzfuRIux8chj7mLzqB4WGR19U8Fd9ysW8qsUGfQ=; b=GI+0Q2osy5Xt37mqELmPZr9EcLJBPc2WhEZFaJiztnvPaN5d9pl9SjAT KfJydnLumgz2cFT6ELrxJXzoUwwr9dX8IWCNZxeXHLcy0cng0Jdv+ck46 OAa1MiIQKu2Ty5+JVpIAg66Je9XbjhLQqLvvVdg/CaryM4OVpJ3Ot6Ybz pU5YtIWTgk8pDyqEQ77h83AplF+EnGmifR5qmSJon4RLiu3jBiBbt5Nb3 BFVcTIZEOQA9d5kreYpZOo/cpdfOVxPvqWwmqxcYrGnprwlptMXpoKjTR VvlPfvEuKJovE9YtiD1J/cGlBb/noRKWq/P8Y86+Eq7RjK+kZGoX2D+6D A==; X-CSE-ConnectionGUID: lqH5eD+gTBiX3Ykyiq/JDg== X-CSE-MsgGUID: 7ZUBsqxWShixB0w0TzAEDg== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572441" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572441" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:17 -0800 X-CSE-ConnectionGUID: 7JUms/FURWKI7Os+FEu0xQ== X-CSE-MsgGUID: h0YUmCpuSJ28pdob7+QaWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656923" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:15 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Emmanuel Grumbach , kernel test robot , Dan Carpenter , Johannes Berg Subject: [PATCH 07/17] wifi: iwlwifi: mvm: remove unneeded NULL pointer checks Date: Sun, 29 Dec 2024 16:44:42 +0200 Message-Id: <20241229164246.c8ce6e041e4b.I4dc19289e3f3807386768c846e08be3ea322cd15@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Emmanuel Grumbach Smatch reported that we dereference the data pointer to calculate the expected length before we check it's not NULL. While this is true (and hence needs to be fixed), this will never happen because the data pointer comes from struct iwl_rx_packet object which has the following layout: struct iwl_rx_packet { __le32 len_n_flags; struct iwl_cmd_header hdr; u8 data[]; } __packed; So, if the pointer to iwl_rx_packet is valid, data will be valid as well. Remove the NULL pointer check on 'data' to avoid confusing smatch. Also remove the check from similar functions in the same flow that were cargo cult copy-pasted. Fixes: 4635e6eaa0fe ("wifi: iwlwifi: mvm: support new versions of the wowlan APIs") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202411210812.0eLaonw3-lkp@intel.com/ Signed-off-by: Emmanuel Grumbach Reviewed-by: Johannes Berg Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c index cbb09389f3bf..6dd2729d9781 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c @@ -2491,12 +2491,6 @@ static void iwl_mvm_parse_wowlan_info_notif(struct iwl_mvm *mvm, u32 expected_len = sizeof(*data) + data->num_mlo_link_keys * sizeof(status->mlo_keys[0]); - if (!data) { - IWL_ERR(mvm, "iwl_wowlan_info_notif data is NULL\n"); - status = NULL; - return; - } - if (len < expected_len) { IWL_ERR(mvm, "Invalid WoWLAN info notification!\n"); status = NULL; @@ -2548,12 +2542,6 @@ iwl_mvm_parse_wowlan_info_notif_v4(struct iwl_mvm *mvm, u32 i; u32 expected_len = sizeof(*data); - if (!data) { - IWL_ERR(mvm, "iwl_wowlan_info_notif data is NULL\n"); - status = NULL; - return; - } - if (has_mlo_keys) expected_len += (data->num_mlo_link_keys * sizeof(status->mlo_keys[0])); @@ -2602,12 +2590,6 @@ iwl_mvm_parse_wowlan_info_notif_v2(struct iwl_mvm *mvm, { u32 i; - if (!data) { - IWL_ERR(mvm, "iwl_wowlan_info_notif data is NULL\n"); - status = NULL; - return; - } - if (len < sizeof(*data)) { IWL_ERR(mvm, "Invalid WoWLAN info notification!\n"); status = NULL; From patchwork Sun Dec 29 14:44:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922738 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9BD61946B8 for ; Sun, 29 Dec 2024 14:45:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483521; cv=none; b=oemzqgN7AYyt2yiOKRu44/bewEF+TX2eJP+CltsNtzI43rM8AoYpfsVNZNAWhn/6LP/o08c2HzP4pN+ZP91xH3PpoBZs5nTlyMB88uFMWRHHJRXj8FZASI0TTbnB/Y+GPq3wMKR1kqUkU9keJtPw8zbCVhbqvlO9FnHCfrYAz0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483521; c=relaxed/simple; bh=AL5RkbuBLKsz1OHUV2ua09/UByFdNAkcyTvP8CnhZo0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HPiDPezv69NXH5KEA+ZQsCNORP/A74rt/hdjr78ou8grgNnbrLGDVEaLM6hybwKPHd9Bt24JfjdEZi/lMyeQoBJo2PGVvbN2NZea3Vg/JGgGcjS41r8WISajcPRrT387zzuA/M0l0JdTPTsrA2Bz6OMMEuVeZ8eQ+VmnBi1DYI4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=N+IbUIc/; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="N+IbUIc/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483520; x=1767019520; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AL5RkbuBLKsz1OHUV2ua09/UByFdNAkcyTvP8CnhZo0=; b=N+IbUIc/FRjs/WLEFm+w7qPmjNxGkKwHDkseRh+q6lPF+Cn305XHU/4D woATnFJjSX8q3nDxbExINFGrbJUIjUOqxCssyYhzSlib9rFCjZ4TdnamX foRVFVeYZcbHUKyf4K6eBPPKDlgiTaW1EI8lJ3h7xNuqZxgZbxGC+Gx24 xKPWgxqapkyhN+CK5JS7YbQWfhd2wuXqlfRY48gUcpo3vYXcVK0SJDBmA 11l+N2LXohmq9b0eeMC4xXD7eV9X8rLDpmFzZs+FV7wRbXzUn8uUMUojA l/KwP9KUKdUDKzRjyvDdMdTnlkWjMAHF/1pOsLsnsUDnVwKH6A60wVwF2 g==; X-CSE-ConnectionGUID: 0VqWCnS1QDSe6FghNuZ1nQ== X-CSE-MsgGUID: 3/M7aUDHTnqnmj5/ta0BNA== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572446" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572446" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:19 -0800 X-CSE-ConnectionGUID: 3GjLyC+uSVOlUtsQWb9i4Q== X-CSE-MsgGUID: QYmNg75JTtaiqLyerG5hmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656940" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:17 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Gan Jie , Emmanuel Grumbach Subject: [PATCH 08/17] wifi: iwlwifi: fw: fix typo 'adderss' Date: Sun, 29 Dec 2024 16:44:43 +0200 Message-Id: <20241229164246.ad8978ee5673.I388e314a4be8333192b3994f43efa5dbd3ac715d@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Gan Jie Fix typo 'adderss' to 'address'. Signed-off-by: Gan Jie Link: https://msgid.link/20241101143052.1531-1-ganjie182@gmail.com Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/fw/error-dump.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/error-dump.h b/drivers/net/wireless/intel/iwlwifi/fw/error-dump.h index e63b08b7d336..3af275133da0 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/error-dump.h +++ b/drivers/net/wireless/intel/iwlwifi/fw/error-dump.h @@ -169,7 +169,7 @@ struct iwl_fw_error_dump_info { * @fw_mon_wr_ptr: the position of the write pointer in the cyclic buffer * @fw_mon_base_ptr: base pointer of the data * @fw_mon_cycle_cnt: number of wraparounds - * @fw_mon_base_high_ptr: used in AX210 devices, the base adderss is 64 bit + * @fw_mon_base_high_ptr: used in AX210 devices, the base address is 64 bit * so fw_mon_base_ptr holds LSB 32 bits and fw_mon_base_high_ptr hold * MSB 32 bits * @reserved: for future use From patchwork Sun Dec 29 14:44:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922739 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCCB333062 for ; Sun, 29 Dec 2024 14:45:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483522; cv=none; b=OckAGc6WKI8ty0+WveV/rFp8TC1MoNFNr/U5NlU5LM2rahPY4gb6zr5GffUk9YWbtuRdDf8BjyvHGY8nIu72okqt+AZJdTuDPHHDldXwXrDZF4LIx+LcFNILsqQ48AUovKdoJ5NMIJXnKpLUKabQvIUcsvHVHpFuCsVXg6yUseU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483522; c=relaxed/simple; bh=uKqlbpHUiUxla3RYXQ+fDOG9wrormS+g6kpW8WK1g8U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=jOJmUEl/FfoGKmz47t1I7SRtC+0F31NYs0JjcoXtMmjM8GHGm1pdcMxH9XOcby1WlkPObfWjvkiLiqfTINoCYKCwzst7w/JaDLmcRHzn6Z9wLxKfZDDcIJ77QpRfBDeAKmoBIl70utZ+7ZfALhciMXbI/kITmjNClw8yDzeAol4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Obv9x58s; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Obv9x58s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483521; x=1767019521; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uKqlbpHUiUxla3RYXQ+fDOG9wrormS+g6kpW8WK1g8U=; b=Obv9x58sJ3rQn9OzwnQfv4Vzh++RXcw1u73f3D3+wko8AQaGSirAcc35 A+BChKSY3/cglEhUdm+dzFwVj+VdIGZVqHL/JuTDY5jApKYsq7GFmojcd sWfdCaLQtVSthtr7KlCnZWj2uPbeZOGDQkXgx/ZLnhr70J9L/0Hfh7iQp 4f398GWwvP+4AxVx8ZOVD2zMRkQqN5NdQx8t7ptG/JUqpahIpe35/WWER SfW+20BI7KilbI2gxe9jqU0YxVhkKyFuCvow6Q9cDp8TzaXqR3Imj1Dq8 sE1AhQA78LCbhA0IUjeiddf+aWsNBZVtNPXusA2urMqYCuQVNY9afwO81 g==; X-CSE-ConnectionGUID: zwGl4xceRnGXi91RLQ7FtA== X-CSE-MsgGUID: NvH7ZLUPQLGRj3lWCSgf0w== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572449" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572449" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:21 -0800 X-CSE-ConnectionGUID: 6PKHQ93PT9aUTrCQPVSKvg== X-CSE-MsgGUID: NyIbmbVpRGujf0zvOl2Gyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656954" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:19 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, =?utf-8?q?Juan_Jos=C3=A9_Arboleda?= , Emmanuel Grumbach Subject: [PATCH 09/17] iwlwifi: mvm: Improve code style in pointer declarations Date: Sun, 29 Dec 2024 16:44:44 +0200 Message-Id: <20241229164246.f09a200be4f8.Ia564ae1c59136bd3c2864ccfb3a244b3257dcd5f@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Juan José Arboleda The changes ensure that there is a space between the `u8` type and the `*` character as preferred by the guidelines. This change is purely stylistic and do not affect the functionality of the code. Signed-off-by: Juan José Arboleda Link: https://msgid.link/10b6d4945675cada713e819f7bd6782a66a1c0d2.1724103043.git.soyjuanarbol@gmail.com Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/power.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/power.c b/drivers/net/wireless/intel/iwlwifi/mvm/power.c index bc363e8427e4..a386b315e52f 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/power.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/power.c @@ -567,7 +567,7 @@ struct iwl_power_vifs { bool monitor_active; }; -static void iwl_mvm_power_disable_pm_iterator(void *_data, u8* mac, +static void iwl_mvm_power_disable_pm_iterator(void *_data, u8 *mac, struct ieee80211_vif *vif) { struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); @@ -575,7 +575,7 @@ static void iwl_mvm_power_disable_pm_iterator(void *_data, u8* mac, mvmvif->pm_enabled = false; } -static void iwl_mvm_power_ps_disabled_iterator(void *_data, u8* mac, +static void iwl_mvm_power_ps_disabled_iterator(void *_data, u8 *mac, struct ieee80211_vif *vif) { struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); From patchwork Sun Dec 29 14:44:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922740 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 303CE1946C7 for ; Sun, 29 Dec 2024 14:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483523; cv=none; b=c0LYRnox2CpDizsf/3kBgoh7g/Kib6UDk3D8W1JWWxBSKVZc86QFz/cb28QloPoC2YphGO0g9m7SvA0VAwgqwmnfA4Yz/b0FiNgoAiutirWvr15oJqA+Q1FX4ufEv/+vJexVEVznhJLxUl4fxUGUHltVTavTe1Jy/OmRJaFidqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483523; c=relaxed/simple; bh=PSlhmhoil3Ppz0VBwfhl2ml35moev8IikXhJ7ayYrO0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GxB8/py5OZdhEuFKpCjAgugXECDD0Y+DDjNcR85Faehww9eKDIz9fLF+AsRKhpuiMCeinnc7oe1lx9sPsILjTePiv2sHpOQ9ej+8jPZa4UXv3yQkHlIkLOt9Yv1vXEkZJ8UZnn3XFwhn7z9oGyZKBPdPR8Lse4UrkbBdY2LRi/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V3jZiVrL; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V3jZiVrL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483523; x=1767019523; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PSlhmhoil3Ppz0VBwfhl2ml35moev8IikXhJ7ayYrO0=; b=V3jZiVrLQcNvcH29oeyLoFp/QVVLIPHsuH7xdd4S5ED3ungu4wnDLK49 Afr9Vr8B0JGveQzOw/G+n+cyY13vawcSIv7Q5iN/OV/yaF6I52oJd8K9o ng83P5FxyAoUU9ZvfcFIQOSyTFwomPYflj5DN/E3oWQQYka5YhOEM3avV Zlo/8CC4oU0XFC4gFQTKOHxOBUjibgmk5q88ytJlIBfkZDoF8x/7urJ7H Xn/TpYLTwFpQ7KduZUr6W1pnD1gJZUQowBThc4fNG4qqdwXdlwN3ZNo/w YEBHOcijsXL/PqAc2HSR6huxa2zJ4GIGGoDnjrWPCKly/PLGtNKgyioGa g==; X-CSE-ConnectionGUID: F4W9D440RwuVBpuKPXrW+g== X-CSE-MsgGUID: 35sIMY5FTkWJHZU1ThVfzg== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572452" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572452" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:22 -0800 X-CSE-ConnectionGUID: jUzQjTZJR6e9KK5edieZFA== X-CSE-MsgGUID: wMGwGpa6SfmAH0JRT0VG1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656960" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:20 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, "Bjoern A . Zeeb" , Emmanuel Grumbach , Daniel Gabay Subject: [PATCH 10/17] wifi: iwlwifi: mvm: fix iwl_ssid_exist() check Date: Sun, 29 Dec 2024 16:44:45 +0200 Message-Id: <20241229164246.4471cd3d8dba.Iab8409b22bf6f01d05571ecef1e97dd3c8b1cc75@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited iwl_ssid_exist() seems to check if a given ssid/ssid_len already exists in a given array ssid_list. Correctly compare the ssid to the SSID of each array element (with a matching SSID length) to better remove duplicates. Signed-off-by: Bjoern A. Zeeb Sponsored by: The FreeBSD Foundation Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach Reviewed-by: Daniel Gabay --- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c index 0bcd1fca31bc..60bd9c7e5f03 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c @@ -462,7 +462,7 @@ static int iwl_ssid_exist(u8 *ssid, u8 ssid_len, struct iwl_ssid_ie *ssid_list) if (!ssid_list[i].len) break; if (ssid_list[i].len == ssid_len && - !memcmp(ssid_list->ssid, ssid, ssid_len)) + !memcmp(ssid_list[i].ssid, ssid, ssid_len)) return i; } return -1; From patchwork Sun Dec 29 14:44:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922741 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42213194A73 for ; Sun, 29 Dec 2024 14:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483526; cv=none; b=knCa/VpMkCCoKdSpUKtXyd0M0oXHtrlVqevxtASkSj/thk+Z6OqugM2aimGqDEazHqX9CZeqnLYKkGaAzvr+qQiCaROZegNVRw5vVZX6VYPK4H+umwadz3OuzDYFJAigBrHQUnD3pEZ/t1imDtoA+nv87HVmSiMvWOlFBb6/mbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483526; c=relaxed/simple; bh=h9V7NrYliYLzH+AHIcTKwb8kkK/KeGVbpX/vg8UogcI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=d+Z55Uj7LHhnA271numeb8QtNYWTh7/75xeCAkRh6aX5XrbnOZ26Iic1qVcdmo+3Q0C4p94zuJgonnd7REiN25UNi+qONLtiGAaiuDXgBwLMLpF9o7jGSCuj6Q9E/OZYCL7LdO2/dMLP/pUcQi/dKBdu6udAruMDqeUMyN4AyDc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=L61P9Kfx; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="L61P9Kfx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483525; x=1767019525; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=h9V7NrYliYLzH+AHIcTKwb8kkK/KeGVbpX/vg8UogcI=; b=L61P9KfxaMWvd/ung4QKxtOKORpvrrrT9kb8i3jGRHpmXjuCrRx8GXdb 5YnZ9HwmCmr38ujx6C+fv6S0g5AzaRuHC46Sb33EXFy/kxknsTMJGa+lD 1hKu7htHNtSiJw63urp4QAT1BpOtqQRBOCZOgSuu0eYwYqlqqwq5e9YoK B11LuNbjDX43+HsknHgcLitqZzYaVuA/fRljLSozCVpgQWPSAtna0Nfv0 LPvnpHmY8+6ui/IYVQLaME7y5JAc/r2XDSE9jBNJvnI/CM1btbCkEGlx/ I/WosbvEq8umhIRbDGNz0N8rDNOmRjVc4zMDT3M1zhZtrgy6aNwBy0p8t Q==; X-CSE-ConnectionGUID: VYs9D0F/RbWMTKOSyjyh9g== X-CSE-MsgGUID: 0E5GWL4MRe2kOU/zsu6fww== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572455" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572455" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:24 -0800 X-CSE-ConnectionGUID: tH7CjvuaT/iMQib9fZNM8Q== X-CSE-MsgGUID: 2Pdem4ptR3mBfg1jnY5gAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656971" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:22 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Deming Wang , Emmanuel Grumbach Subject: [PATCH 11/17] iwlwifi: api: remove the double word Date: Sun, 29 Dec 2024 16:44:46 +0200 Message-Id: <20241229164246.7b385f337e46.Iae60151e718f344098058b0e4fa6f6c1e43cb414@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Deming Wang Remove the duplicate "the". Signed-off-by: Deming Wang Link: https://msgid.link/20240318054853.2352-1-wangdeming@inspur.com Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/fw/api/tx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/tx.h b/drivers/net/wireless/intel/iwlwifi/fw/api/tx.h index b9807dd4f255..0a39e4b6eb62 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/api/tx.h +++ b/drivers/net/wireless/intel/iwlwifi/fw/api/tx.h @@ -191,7 +191,7 @@ enum iwl_tx_offload_assist_flags_pos { * cleared. Combination of RATE_MCS_* * @sta_id: index of destination station in FW station table * @sec_ctl: security control, TX_CMD_SEC_* - * @initial_rate_index: index into the the rate table for initial TX attempt. + * @initial_rate_index: index into the rate table for initial TX attempt. * Applied if TX_CMD_FLG_STA_RATE_MSK is set, normally 0 for data frames. * @reserved2: reserved * @key: security key From patchwork Sun Dec 29 14:44:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922742 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D0E192598 for ; Sun, 29 Dec 2024 14:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483527; cv=none; b=ZTzmnfC5nDkr2pLAJviEqoGnefWymBveLqX17xxqjHVe+UVX2sgoPsa6R8Xp4G2h7kHvOHVObozwwonVEYV2oBRKy/yqqpqDUfUAgk8LyAYjYmQ1qjLgh4J8cqf6YEoVtLm8dd6dvvzA2CDDo9Ir497t+YCDSrtUPw09YWjmrjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483527; c=relaxed/simple; bh=9hVgdxZwZatw2wmwvxjUIB8dpsOq42FdWVlDY8lR/Gg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Gig8dScHkiFQIIC8Mhh8IoF1lsgyA6NY5R6PtvmoNu+ei028xtPAlLiWzCIlM7643YIHSCTrk5hcO6bDEjm2ajl/6P+PdeDN57Zohut0NY8WR/o7jy/8z+8zolTX2WukY/6WM92Vke7ZdVKhDGDh9miknAO6mGWlyHuzDQfTW9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cEE3A2/O; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cEE3A2/O" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483526; x=1767019526; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9hVgdxZwZatw2wmwvxjUIB8dpsOq42FdWVlDY8lR/Gg=; b=cEE3A2/OMC8Jjh+IYMv0+veT1yY/+J/aj/uMmY3CbS9yf+EWfsLsvCLd 9IYW15uswxUodAfu7gfCSSFohM1ik6ziP/rcEGXb4Oo+BXHFQ1SGFxU2T nRs2Sf+Mkhl1s/BEB23aB/u2wS/DuhVPxEgjELwH3pQp1VV3BaGyKeulz MCNvjOByYHCO+ofLnJyborl1VSYZzkWVOFJeVH4ACJby94aE94FJUOW8K BbJc9jbswJWT/CHhOa31atESS3uZtdF6XDaroFOD/SYwzaQ3H/1inNFvS FL24sra3iCzQcBXvY/8L33zy9WFMc/U6+pJBTG7x2e/9rQwWoJ6o00G9N g==; X-CSE-ConnectionGUID: i7gLXLIwRcWXde55suXW5A== X-CSE-MsgGUID: htZG3xXYQv+40WP1n4KUew== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572458" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572458" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:26 -0800 X-CSE-ConnectionGUID: Idbs8qazSE2OTD5GjFNzhg== X-CSE-MsgGUID: e4ans1BST1GoOTRn9U59iQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656972" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:24 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, shitao , k2ci Subject: [PATCH 12/17] wifi: iwlwifi: Fix spelling typo in comment Date: Sun, 29 Dec 2024 16:44:47 +0200 Message-Id: <20241229164246.c79c132f811b.Ie07a0007b96359b3552878e23c4b9efeb07bba8d@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: shitao Fix spelling typo in iwl-context-info.h comment. Reported-by: k2ci Signed-off-by: shitao Link: https://msgid.link/20231212093424.3104329-1-shitao@kylinos.cn Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/iwl-context-info.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-context-info.h b/drivers/net/wireless/intel/iwlwifi/iwl-context-info.h index 7abd153d56f9..dfd44fabf237 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-context-info.h +++ b/drivers/net/wireless/intel/iwlwifi/iwl-context-info.h @@ -6,7 +6,7 @@ #ifndef __iwl_context_info_file_h__ #define __iwl_context_info_file_h__ -/* maximmum number of DRAM map entries supported by FW */ +/* maximum number of DRAM map entries supported by FW */ #define IWL_MAX_DRAM_ENTRY 64 #define CSR_CTXT_INFO_BA 0x40 From patchwork Sun Dec 29 14:44:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922743 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEAAD197A8E for ; Sun, 29 Dec 2024 14:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483528; cv=none; b=Rpsyf6QviMOYsHV6oOSI3Dcy6zIhrww7zE5frBNArZ2hCjwc5UPEEwUw0yyHq5+EWcGxMbL6UM/yg9ezxgPgfaGqeQuIOA7+IIskYEh1G+N77tKSMWpiB4dyMYt+CUk8cEUhSIp6ehhFnthOxvKgJRC1yEG2tl5u2Y538cOwCuU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483528; c=relaxed/simple; bh=BhJojQ3XYGLVpmd8UbNE9TZR54T6i37Tyf/JryGoY8Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fyuBi7g8ilcZyLmdpSvGNZRs/FNAIN3pWcreOKOw+zlE1zNXPST5nD8lx0VaAxnHTdtoD1U+BnHwAi8eiTXBSGAmIs+Lge+Iex7l2lYW9mIM4y7Uq8erPj/kLgx60Gitlta6v7tUi4k5P1PlQIQTAv4hFkwcXEjZIbRcIaYqeVE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OhWPeoiT; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OhWPeoiT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483527; x=1767019527; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BhJojQ3XYGLVpmd8UbNE9TZR54T6i37Tyf/JryGoY8Q=; b=OhWPeoiT32Y7c1+E+Kid8yt5v74Cbtt4lWsXjD+tnDPqa8UimZYnqfSv ZG0XzNCDWP6io9wVgItP97vBXMY5+Vpx2Xc89lQSoHInyjLY3cmLTvbpi CV0hbva7jApknOpmcIs3AHU2GsCVnnL13WCPJC9tbFYogamtNzntHQCQv VYRQ79ZFFzmZQdTMiBinnnTyVRtnhZgU++XDGSmnNezVZB2CQ63nml9n/ 30uqIUe2p2sQWv5/dwfbrv8sdsm+32ZGbp5KvdQDICyLcR1AF2klO3xEI CaHDBcP/vOz5ptGcxiDOyIp1AomXdxIOa8f3rKW1rr/1B92fogDSsaJbS A==; X-CSE-ConnectionGUID: EwzphfQYRvq5oWisVLoFbw== X-CSE-MsgGUID: mTWOc6ZQQk+e69WWGxWATw== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572461" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572461" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:27 -0800 X-CSE-ConnectionGUID: +jCzXOLMT3mQOvNMIx/+yQ== X-CSE-MsgGUID: nA0kyRv2RYSGlkmzFeTH6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656977" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:25 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Ruan Jinjie Subject: [PATCH 13/17] wifi: iwlwifi: mvm: Use helper function IS_ERR_OR_NULL() Date: Sun, 29 Dec 2024 16:44:48 +0200 Message-Id: <20241229164246.d3423626d981.I3b4cc7f19d1bfecdb2e6a4eba8da1c7a41461115@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited Use IS_ERR_OR_NULL() instead of open-coding it to simplify the code. Signed-off-by: Ruan Jinjie Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/mvm/tdls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tdls.c b/drivers/net/wireless/intel/iwlwifi/mvm/tdls.c index 65927ebbabb7..36379b738de1 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tdls.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tdls.c @@ -24,7 +24,7 @@ void iwl_mvm_teardown_tdls_peers(struct iwl_mvm *mvm) for (i = 0; i < mvm->fw->ucode_capa.num_stations; i++) { sta = rcu_dereference_protected(mvm->fw_id_to_mac_id[i], lockdep_is_held(&mvm->mutex)); - if (!sta || IS_ERR(sta) || !sta->tdls) + if (IS_ERR_OR_NULL(sta) || !sta->tdls) continue; mvmsta = iwl_mvm_sta_from_mac80211(sta); @@ -47,7 +47,7 @@ int iwl_mvm_tdls_sta_count(struct iwl_mvm *mvm, struct ieee80211_vif *vif) for (i = 0; i < mvm->fw->ucode_capa.num_stations; i++) { sta = rcu_dereference_protected(mvm->fw_id_to_mac_id[i], lockdep_is_held(&mvm->mutex)); - if (!sta || IS_ERR(sta) || !sta->tdls) + if (IS_ERR_OR_NULL(sta) || !sta->tdls) continue; if (vif) { @@ -472,7 +472,7 @@ void iwl_mvm_tdls_ch_switch_work(struct work_struct *work) mvm->fw_id_to_mac_id[mvm->tdls_cs.peer.sta_id], lockdep_is_held(&mvm->mutex)); /* the station may not be here, but if it is, it must be a TDLS peer */ - if (!sta || IS_ERR(sta) || WARN_ON(!sta->tdls)) + if (IS_ERR_OR_NULL(sta) || WARN_ON(!sta->tdls)) return; mvmsta = iwl_mvm_sta_from_mac80211(sta); From patchwork Sun Dec 29 14:44:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922744 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF5CA19883C for ; Sun, 29 Dec 2024 14:45:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483530; cv=none; b=Z7V+HUBUfEdOPiOTT4vs00hx1P8ruipwXH/2mKhgQ0+nPL0rYDvxMhH5hKFUub12yEOkJ0LzN1VS/Brwc9/jCjqNEDZH8BzkDq7r/0c0o4luFc/3ItsPE+NtXro4ZfgF4cv8ExPgBujLr08PSKCQ+BJlbmajZTNYX94Ug2eaTFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483530; c=relaxed/simple; bh=CFvbiM7q2ncfW/FkuHO+TjO4es/gYLM4+ocmcO6p688=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aIjoOBoZpPIxR4ZlTZkXj2x0/lTL+eqk206jHB80UgWrBgmw3MSZky+0+L4frAlIyAq7t2bk86k7JGF3SASZIChf8jUis9t7MY+7mf6xUsM8elcmTjmNfgghiJ1AYxgAO8hy1YQQtO/zzDQqqR3E6OKed8eMDMifn7BYpFijYxI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Gfev4JAr; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Gfev4JAr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483529; x=1767019529; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CFvbiM7q2ncfW/FkuHO+TjO4es/gYLM4+ocmcO6p688=; b=Gfev4JAr26xjKzgSbnNXLKl97OprS35YdViqe7s2goG5Tf8wx08NpGic 2jwkMi6MkG4ULQtCw/DKsIls7yLaIbyyRPOS74vH/dzE4XvNNeioNPtuS +uM4YNMl4/25NeUALD4uJhXi5Rb9A+GpZ8awPKch+olZe7GQnKHcNizjd vkFv2Eq1PaLWi9q9yUgl40GbImXlt5ov2T1ulB5xmyG7yJZ9qmubIGDnU b8YB5h/nhLuFbjjNjFtfzb58+vgpx/TOSO/EHBACufcSS+BfLAk/j9+0z rWBRmLUDhIZ6mTGKh+sIQU8FbL+a5jEinPFOmzmOQcMutrkev3N96eTbp g==; X-CSE-ConnectionGUID: p0JPTqG/Raa1bcx/znZrAQ== X-CSE-MsgGUID: INgDhFnfRsC9vN4HZOUdMQ== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572464" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572464" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:29 -0800 X-CSE-ConnectionGUID: TMgDu8U8R4qXuJVtfsHJtw== X-CSE-MsgGUID: dVvKoIZPTWqqOicrVFvV9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656988" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:27 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Minjie Du , Emmanuel Grumbach Subject: [PATCH 14/17] wifi: iwlwifi: Remove a duplicate assignment in iwl_dbgfs_amsdu_len_write() Date: Sun, 29 Dec 2024 16:44:49 +0200 Message-Id: <20241229164246.b1b0dadc2e9e.Ie57cbe8039b9f388632141447ac910b6fcc3d0c0@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Minjie Du Delete a duplicate statement from this function implementation. Signed-off-by: Minjie Du Link: https://msgid.link/20230705114934.16523-1-duminjie@vivo.com Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c index 2472a78ada47..6ec1cae5314a 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c @@ -463,7 +463,6 @@ static ssize_t iwl_dbgfs_amsdu_len_write(struct ieee80211_link_sta *link_sta, if (amsdu_len) { mvm_link_sta->orig_amsdu_len = link_sta->agg.max_amsdu_len; link_sta->agg.max_amsdu_len = amsdu_len; - link_sta->agg.max_amsdu_len = amsdu_len; for (i = 0; i < ARRAY_SIZE(link_sta->agg.max_tid_amsdu_len); i++) link_sta->agg.max_tid_amsdu_len[i] = amsdu_len; } else { From patchwork Sun Dec 29 14:44:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922746 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B704194091 for ; Sun, 29 Dec 2024 14:45:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483534; cv=none; b=k59mWtVuV7STLhOcijwoitxJVwjuUsW6uYboE/eBBqSD7/oRar73/RRsYnvFrCLadPwfjt7mlYEGJxoadsklCCoVm+qzCpXDGLYQMINtUftjs9O1tSWgDQqOxRrO/pU5KWokc889KXQ0360IdYDHxVcAdc0WCQNpTmvZ6/GqR20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483534; c=relaxed/simple; bh=iWIOczPmNbj8ZGAP/RLFtTe+BfAiYhVYBuo2zzcTuw0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oSXToPtcgBu2gp7iiRT+OsKfphKktJlSCtPjtRwXjepgE2bAwIibLwIFYTTBtBI/HWJFjhASAHsbBb1GAH44oQjGw5iJs+A8Hv3HL7W8D7a/UOjfvG3oAH9M6QG+XBDmx9eLa3zQp564klSUY33E9oaJsZZTV/CQ8dMO4D3gxZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EyTQYmwh; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EyTQYmwh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483531; x=1767019531; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iWIOczPmNbj8ZGAP/RLFtTe+BfAiYhVYBuo2zzcTuw0=; b=EyTQYmwhKIOnXmp9UxR2ssSZuSa3g1KIOw6r1d04Fbv7SR/sbRrse+tS Wzrx+7d5QzfxMcUZhd14i37p9bFaVjoFcozlgWL68g8M2TUUPwSMPYniZ ZvR5QBJtgB4/VLAB8eNe7B+8lWfV91n45Q2w2E6IYKhmaKSwPpWJrCiob R/LurnoHHXDZhK2CUt+4s17F4SCJDLWrvQNqq/2oXIWu/i8ar1fyA1EWV 65DxulsT9zjsodGV0LVOyh6LK4LZTNvEq3EZkDJeKzHe80S3q+Ppg1nKi 3e8MEZtOpazaCBZFMT/Zjhos+S0Xsswjs8mEY4zhqA1ItcOuxLYfpWE9b g==; X-CSE-ConnectionGUID: sI338saST5eydC62hK49Cw== X-CSE-MsgGUID: BXJeGr+HSPWAZVWamwA7YA== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572467" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572467" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:30 -0800 X-CSE-ConnectionGUID: 8mJkzrZaSdGwt88lp63lgw== X-CSE-MsgGUID: TTXT8PhqTqS6w+19UpfquA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656995" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:28 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Jason Wang , Emmanuel Grumbach Subject: [PATCH 15/17] wifi: iwlwifi: mvm: Fix comment typo Date: Sun, 29 Dec 2024 16:44:50 +0200 Message-Id: <20241229164246.9d8c224e9d4c.Iaacfbd1e9432f31d5d7d037ad925aadbb0d5c4d6@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Jason Wang The double `if' is duplicated in the comment, remove one. Signed-off-by: Jason Wang Link: https://msgid.link/20220811115958.8423-1-wangborong@cdjrlc.com Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c index ede053507366..c1363b790277 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c @@ -2915,7 +2915,7 @@ int iwl_mvm_sta_rx_agg(struct iwl_mvm *mvm, struct ieee80211_sta *sta, /* * The division below will be OK if either the cache line size * can be divided by the entry size (ALIGN will round up) or if - * if the entry size can be divided by the cache line size, in + * the entry size can be divided by the cache line size, in * which case the ALIGN() will do nothing. */ BUILD_BUG_ON(SMP_CACHE_BYTES % sizeof(baid_data->entries[0]) && From patchwork Sun Dec 29 14:44:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922745 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9863E194A60 for ; Sun, 29 Dec 2024 14:45:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483533; cv=none; b=JtILOmrlgDnw7eNvnYVx8z6mSCVeICdBj3O1Whm6+MZuBXdeOoHXnVVznvPlqKoZ12cMBLGIQxwPTnZDQfXzre6Tgm6cS6ShDBOX1/Uy4bV8lrTFJyCx1zKSRjZ3OAaiM1JBRaFVzgn4H9eT0RmClwjHA5wPfn+U/ASp04iGA4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483533; c=relaxed/simple; bh=WVPIIrJyx/rnJptzHTWXvKZeRVttxjQbmGLLRr70Tb0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MAFWfQwi3sM8FAqFIm+oCNNa4AVH6KBoATYdFQ6zmN4fl5eO5rEFg01PafuruMeZScGs3BsgRARCsVdPZiT6z22DROVHefkym08fwMUEFN1UEcbeHKzI2a/tchFmxEKdNOZisoYLN68xIx5+tnj/uAT+6tBUOVzjNXXPmojPzPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RIiOuOTS; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RIiOuOTS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483532; x=1767019532; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WVPIIrJyx/rnJptzHTWXvKZeRVttxjQbmGLLRr70Tb0=; b=RIiOuOTSj0opJm7M9fmav1K4+0EYdxbD6ZO79Rt5qAAiaJEGKyiMYYBm cZVdFdI16HZHdk+tf+Zsub12s+u/mK96mFiCHdbzQND3XGLwMSMGHIsni Bs58O4RuIr4O9fwW1zTDqEiMT0GhhgxQagL4+BHO6QL9AutOmdjYyW0tm C/jyzVTpQKzv+xZWgFXRr8Zgn55iNjvKzUgnLlpmbpIuiE6153Ur8zdCM 6Ovxud6TU6ZbGDmWudtJHxtZPtXonweuK++YBgzuC1Eij7lAn8XRePYUr L1qbjIZqiV6CVAnf0epwOHl6NlAxg4b2qPFjCPVp40pa+Ly4JkKurXh6o w==; X-CSE-ConnectionGUID: IzgLaWawRqWvBUW85C/s/A== X-CSE-MsgGUID: OP11MJBfSxGHjcu9HLlx1g== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572471" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572471" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:32 -0800 X-CSE-ConnectionGUID: wXW3qn2pSQa+MAW0ecBZkg== X-CSE-MsgGUID: LyUHdP8tTHqB54ILy7JzuA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105656999" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:30 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Jason Wang , Emmanuel Grumbach Subject: [PATCH 16/17] wifi: iwlwifi: mvm: Fix comment typo Date: Sun, 29 Dec 2024 16:44:51 +0200 Message-Id: <20241229164246.76502dda646b.I0a1d012eaa1cd8d39430cde981cae8c4cc058442@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited The double `the' is duplicated in the comment, remove one. Signed-off-by: Jason Wang Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c b/drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c index 7cab5373c8ae..5e7e2926be0c 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c @@ -31,7 +31,7 @@ u8 iwl_mvm_get_channel_width(const struct cfg80211_chan_def *chandef) /* * Maps the driver specific control channel position (relative to the center - * freq) definitions to the the fw values + * freq) definitions to the fw values */ u8 iwl_mvm_get_ctrl_pos(const struct cfg80211_chan_def *chandef) { From patchwork Sun Dec 29 14:44:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13922747 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 611EC18858A for ; Sun, 29 Dec 2024 14:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483535; cv=none; b=LbM16awtCYzXV6z0evBRdcFxsITbipV6mxhY1+YHuCZIXuYmwZMtXtqBuU1ncqXPVaOCOS2H7dHCK4mTaNrbUm9YJ0XIiAZBTCFKvzU9jU7VLD4F3XyvMDPvEVLzZwIhFVgzO5WfB8FZQD+iNXY91EBbjRLQ6hfTDj1gltTOHhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735483535; c=relaxed/simple; bh=DudXzUWQMviBDrQP27WOMvgT9tjebUl0SkTCcNnojoI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=b2qeD5kLuTjGHTovKLsxd9YkpknWW0VB3zVHkpWwcfOTl4mLvRwKJMkZxoP+E1vVSqDQvLaNNBnna6oqWYZyV3Gr99myJyz1zz+/BuGYSiVhpsd620egi7KY2GSXyLy4kGvbIlbUkaIIx9MjB3ohJESCeR3zS1mXDmo/X06u5eo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=J1Fvauwr; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="J1Fvauwr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735483534; x=1767019534; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DudXzUWQMviBDrQP27WOMvgT9tjebUl0SkTCcNnojoI=; b=J1FvauwrIp3KMI8eKKJJSfCjeaO/QFkyUBW3dfOOC6mjZvS1uWhhqBgG 13VuSqJ8McRsfJ28TTw6d3qP7yrTVJMBFWqiquwFweCtY4DXvdf7irz+x GPEsZb3iLLw+eo1StROmsxQBWs1/fyRqA8KoLjRSsU555muO4wGgSIEJ+ jNH+URHkLVPzftAf2ObSChtRpgJNn4VutFE3Uf1ziuKs6koFqOYtLry7m uL67OH0hDFdbOeN2oBjHzVSBcQDxAjVnYj/hQ0Dk8sdEQO3ZpgUlxJ6wO ZjG+3oAe3w6EXErwvazM0SgeYZLPb6p+U+/5OaNIsWED+CT1IPcYdCQBu Q==; X-CSE-ConnectionGUID: KUIfUgDjSJSFDGokxPR31w== X-CSE-MsgGUID: MoQg83CtROiuYh82cH8QJw== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="39572474" X-IronPort-AV: E=Sophos;i="6.12,274,1728975600"; d="scan'208";a="39572474" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:34 -0800 X-CSE-ConnectionGUID: XizIEBuWSLSYi1kUZs5m3A== X-CSE-MsgGUID: dxn9FWThQgyN8pqiEK1lNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="105657007" Received: from weis0040.iil.intel.com ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2024 06:45:32 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Jilin Yuan , Emmanuel Grumbach Subject: [PATCH 17/17] wifi: iwlwifi: fw: fix repeated words in comments Date: Sun, 29 Dec 2024 16:44:52 +0200 Message-Id: <20241229164246.2981c3b5a40e.I96ebda41f230d453d4bc0afb01ac43011c13a182@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> References: <20241229144452.3151163-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Jilin Yuan Delete the redundant word 'for'. Signed-off-by: Jilin Yuan Link: https://msgid.link/20220709140036.48913-1-yuanjilin@cdjrlc.com Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/fw/paging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/paging.c b/drivers/net/wireless/intel/iwlwifi/fw/paging.c index 945bc4160cc9..a7b7cae874a2 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/paging.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/paging.c @@ -249,7 +249,7 @@ static int iwl_send_paging_cmd(struct iwl_fw_runtime *fwrt, }; int blk_idx; - /* loop for for all paging blocks + CSS block */ + /* loop for all paging blocks + CSS block */ for (blk_idx = 0; blk_idx < fwrt->num_of_paging_blk + 1; blk_idx++) { dma_addr_t addr = fwrt->fw_paging_db[blk_idx].fw_paging_phys; __le32 phy_addr;