From patchwork Sat Jan 4 07:36:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 13926126 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFA4914A0A4; Sat, 4 Jan 2025 07:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735976446; cv=none; b=iF1bbCB6BxpWFw9JDSztVgjvH49QSLiHwUyud6X9ny2XblPpH89RFlMGidfCEGEWBMSfHkUCVwlNE9Q22EPkX5vrPiXf0/caLMWhS8qKs0P+LheeonVrssJDBk3K172WQQX45riw3AoXMpfSbniL61AYfkg06kX0ZWojH5fGV58= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735976446; c=relaxed/simple; bh=RfLscubGTBY69+mRUuhbjHJSwn0LVQ7XlGs0ZPQCMek=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nI/9DouNYV8F+BzfI7l38M47ILgrDWeD/jRjrqBdmNdYFaSh1145T8IdmIwc4RqyuAwcwWae2fX/aXYaLeKMJCjNV8wtZ59VOTWRIT743Qf75jFP1hvrDeCEPJ761YmuuGiQX99HbIyr9aqgkGej/6PKdHOR6kZTFrEmc2Z55SA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JAOG3q90; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JAOG3q90" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2167141dfa1so177661985ad.1; Fri, 03 Jan 2025 23:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735976444; x=1736581244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q0utCftucvwNjjKL9gp7cLeehqJP0aygJTF/mR/QXhE=; b=JAOG3q90/G2r+waI/ZAI5ZcNVFCGBYsHFk24bHBguB6kbRkntHToMFdH0jFFcKFUlG cf160Aab93yVijLuxmMupFdWA4zv/aJUQ/2QrZOXnr6Mfa+PVxY2rO1kb8hAaT/Yac6z mG1Ju+ONit0n31cMBkLHk24CI2mQqloZ0kQZxYBqvjL+7LGlcGmYGa6aqNoGS9reGNZn s1D1KGG5qOyhslCN1B3AxiG6bst/wmiCENuz4906Fj+CBbB+Rp4v1cKTs4q0RBjRB99O 7Mch1gLTQ5qzAEtX8rKzKVxL23g6Iqst5iNjqiShD/l4Q3zJp7g6utX3Xw0lQKub3MqN YIvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735976444; x=1736581244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q0utCftucvwNjjKL9gp7cLeehqJP0aygJTF/mR/QXhE=; b=WXniGKRJZ9ZCCtN22ER74522umSRcA8JcSeOgHSQdMssRqqYJhhchQZnBztROqE2Ek 760Yt3XamPNG2I55U2H4BGhPNJZjuEmETRQUL4V5T/60h0xQq95h1xDr6yAIw7Y7dLvb BlhUF8LRm+/wx/2qiTGE+4ozJR8tn8EbARYzoVp6TD/5viRezW8kZL8dFtqHHMj9GxiZ +cvIImoPy51LeyWRFyPSdvJCVu024crTDscGnky0Qkjt/x0gNNFlmUVaKhb1PgP/SuMI RgI+9L45OWbG9iwQ59ba1zbsqsS0sbBlcz1E807iniIrChSifTgGO/FEz9/xAjDj2NK/ 14Rw== X-Forwarded-Encrypted: i=1; AJvYcCUjWJm+kznHDm2VF9qKzHInSClJ5fC/JQWUNNUOv22PNGhKMaBWifKiHRxSm6RrIcdWrR4uMwTi25O8WbiD@vger.kernel.org, AJvYcCV3LvxJ6peVnNfDdiaOTEzoQ8iwiCcG8bh05ka92hVuz4H+UAyWF2YlFs2C4XHMelMNA2mD1yPmDl16@vger.kernel.org, AJvYcCVxGd0vTcb+9AU6W3NNt2U7SNXsRqiiP9qhgiOdfVOzSVrYxr4M8mvW9+0yQpbZEzQdFuSL0ZxONAyR@vger.kernel.org X-Gm-Message-State: AOJu0YwoqqkAbar5amAGcvAHQMm09taxZVt1ojyOG4mOpPrZ5DRXt6jy nhDfkYWgri5cx014eX2hE+E8LwyC39euQMI8wg1vI5o9K4FOMTwS X-Gm-Gg: ASbGnctq2bGHupSrKnLQibJy2vWCpX/wOAF0BnSgmw8W3LGACXT1qrdnDd7Eywqueec V2hjwJ3E9qtHMd4D4usdY8nCK1q3nmqb0xZA3Q6lKu+1hoggrNzc+vTl0/ZF267LXiHhy/wSPR7 O14ep45as+O5nnjhwBnBNa0X2ViXDzG1xJ9jgDPNaELtfPh08Pnk2D2jB9do+slo0aPSniN7TUW ZuOx/p7zfTfzVt5LqZYFFA0TihDcyH9DZ4yNNqwjuAaMbZeEw== X-Google-Smtp-Source: AGHT+IG16aEsUt31gOxPdEHIOiEhly+PPdwAHUbVPWapyCabc4BBxAcFCsLxS2WeCaHdQrCno+H+/g== X-Received: by 2002:a17:902:c408:b0:215:758c:52e8 with SMTP id d9443c01a7336-219e6cd83eamr662739295ad.12.1735976443882; Fri, 03 Jan 2025 23:40:43 -0800 (PST) Received: from anarsoul-xps15.lan ([2604:3d08:7780:1ca9::398]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02b34sm256562565ad.252.2025.01.03.23.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 23:40:43 -0800 (PST) From: Vasily Khoruzhick To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Vasily Khoruzhick , Dragan Simic , Frank Oltmanns , Stuart Gathman Subject: [PATCH v2 1/4] dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and PLL_MIPI Date: Fri, 3 Jan 2025 23:36:57 -0800 Message-ID: <20250104074035.1611136-2-anarsoul@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250104074035.1611136-1-anarsoul@gmail.com> References: <20250104074035.1611136-1-anarsoul@gmail.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Export PLL_VIDEO_2X and PLL_MIPI, these will be used to explicitly select TCON0 clock parent in dts Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux") Reviewed-by: Dragan Simic Reviewed-by: Chen-Yu Tsai Tested-by: Frank Oltmanns # on PinePhone Tested-by: Stuart Gathman # on OG Pinebook Signed-off-by: Vasily Khoruzhick Acked-by: Krzysztof Kozlowski --- include/dt-bindings/clock/sun50i-a64-ccu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/clock/sun50i-a64-ccu.h b/include/dt-bindings/clock/sun50i-a64-ccu.h index 175892189e9d..4f220ea7a23c 100644 --- a/include/dt-bindings/clock/sun50i-a64-ccu.h +++ b/include/dt-bindings/clock/sun50i-a64-ccu.h @@ -44,7 +44,9 @@ #define _DT_BINDINGS_CLK_SUN50I_A64_H_ #define CLK_PLL_VIDEO0 7 +#define CLK_PLL_VIDEO0_2X 8 #define CLK_PLL_PERIPH0 11 +#define CLK_PLL_MIPI 17 #define CLK_CPUX 21 #define CLK_BUS_MIPI_DSI 28 From patchwork Sat Jan 4 07:36:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 13926128 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC6A8152787; Sat, 4 Jan 2025 07:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735976447; cv=none; b=QpzylGlHa2IX/4tPCwWZTrqEO3knOD/r2KlopKfrIBfEzstwNDTX37D/Gg8ASVKPFi/u1T3e0QwyMBJ77xzc4S2jSnAKcnn6UYdzrLrb80AebS7fmonFAmqM2OVKlZTolFdjOC0WQczpi0n7b8+LB+qXIGOQJq49+GeRy71PStg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735976447; c=relaxed/simple; bh=TbcHVKRkFJB98fhajLRM7Bw4MBvD1k0xqRdfdhNbxgE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lv2sFUWGVjWqnHs4JW+X0jo+UCco/+MlOSaGUn24/BvvZzHGyA17Qktq8QZ+GLU7VBrp14czGOq+OUj7tMxljhpCYCiCT2Skh2r4hiwmVId243R+YosJPPFaI1S6Q0Esrk5GOZ4ZngZVVLwe+c0W/TMy4YMi4ZLgvWE2qAKDG6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JJvidv+9; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JJvidv+9" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21675fd60feso238879725ad.2; Fri, 03 Jan 2025 23:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735976445; x=1736581245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gI4bkaQLizbo3HOuEzTTJL5LyowGuTN5RlRxoRNNOp8=; b=JJvidv+97EO30+raYoo0BTcPOZd1dLMkJr5Dg8MVqgM6avHsqAlS8hHKdQT68pcsVA bCEy9wRo5SlZTmr/cqslFkHB2qZUXjY/yEUeqTXpKBo7B80m34tVC+Kw1b0Q6SzVNtZP E36sdXmnz0bMCX2Lj3beyKXRbRlfNrbKQrvLxzEVIQEeQVqp+CQdMKHYCnF3Js3IkYQy 6PODgVr4bgPfraiW4Yyj92sNKqWZ1eFP17aNmOfdIHOT/R2GOFkq94ELvuJ17C9n2GHT MhRqGXLs5eHkah/SCKl9uRHAbmkd7di7D83TzqMT9pWIqgc2ACH3tkkL6/N2DgYCwS6D 6a9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735976445; x=1736581245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gI4bkaQLizbo3HOuEzTTJL5LyowGuTN5RlRxoRNNOp8=; b=wk5sbYamaGD7Zws/aJJQXjt9mKqiuK6wAPOFZiiRdFh5KblCXy9hlpLUrQG5m+hXMw odFPw1Ms3y0ZBi1fOjNQ7kb26V5sdAvesw2aqnps5zVr9U1KUwbrLB2BlAGMUkW+uijt 7v2/L+i82vVW6RvUd2rYaZ4YsQoN3TS8TvNR1WH+7T3v+Mi/aQRmgGwYiHjan/QajI9c D8w1rxwxxUDIif/K2fVekWf5paZgIuYesWY/5TPQQz2AUP5+7d2ruEVKz87t57y76bOs MIA5wJyD5ruF1qvRLdPG9+KiKxQ3kMbjBj9ee5bLPDKo65t6ie6ZwvDvDeM3CK4zMUcy 3LJA== X-Forwarded-Encrypted: i=1; AJvYcCUFbfNmYjcVeH4dpWaIZ5+vPVFsze7XSLsT9xjvzViNGykBvJHjLKf4uwXv4zJTUXFwizSzgTFfAZ1x@vger.kernel.org, AJvYcCVTT8V3cnYg5qEsIzV1aPIvdQVNc7xlUn6FOp3WfGbcZjhwFBBDN2M9eiHYmcsJu4BJg9nLtosDg3zr@vger.kernel.org, AJvYcCW+0o5iN17yn0FOxbtwucIdn5dYfhleGybpO18dOVYCeWEFDqej42ZYhZnmSm51QDxJU2YsAc/0oyWQhFte@vger.kernel.org X-Gm-Message-State: AOJu0YzosbWp1NvzgxmdYzSCGihajlOfkVNg2zm3KIZRjo0VX/vpq/bM h8+cZVb6/n+KrFfjdkLuj5xYRH8K9J/5HXhsayZSUwugkpvCQZI5 X-Gm-Gg: ASbGncu/iQHGL5HAkNhty0RpYkKO5KhIVD3bauW+BQtiKw09yvCqhZ7Zv7gpoI2jpMc scq5nQ6DqD50uRv98eQUdpf+4NSNh50akhek9wUNDDizraLqvRqjw9RHMvX2gxN4ANoZIyPzChW owVAWl8cUHK616k6zzOrUt2HJmFlzldFICfC1fp4nscitvkdr00EeUkEjrwoJwTLEJRVrtRJ5Xh 6Iuz0jT/ZM3rnET3+R7ClQouANlioqAziDQPtFSWpx8C7BFnw== X-Google-Smtp-Source: AGHT+IG0CS21q53dEVGA2oPLK2te0e5w/JAMFEKzZxo/+YczSEWdTkdKuJD2Fisbi6FzS2oAnAex1Q== X-Received: by 2002:a17:903:32d0:b0:216:6c77:7bbb with SMTP id d9443c01a7336-219e6e9fb45mr689469915ad.17.1735976444999; Fri, 03 Jan 2025 23:40:44 -0800 (PST) Received: from anarsoul-xps15.lan ([2604:3d08:7780:1ca9::398]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02b34sm256562565ad.252.2025.01.03.23.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 23:40:44 -0800 (PST) From: Vasily Khoruzhick To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Vasily Khoruzhick , Dragan Simic , Frank Oltmanns , Stuart Gathman Subject: [PATCH v2 2/4] clk: sunxi-ng: a64: drop redundant CLK_PLL_VIDEO0_2X and CLK_PLL_MIPI Date: Fri, 3 Jan 2025 23:36:58 -0800 Message-ID: <20250104074035.1611136-3-anarsoul@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250104074035.1611136-1-anarsoul@gmail.com> References: <20250104074035.1611136-1-anarsoul@gmail.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Drop redundant CLK_PLL_VIDEO0_2X and CLK_PLL.MIPI. These are now defined in dt-bindings/clock/sun50i-a64-ccu.h Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux") Reviewed-by: Dragan Simic Reviewed-by: Chen-Yu Tsai Tested-by: Frank Oltmanns # on pinephone Tested-by: Stuart Gathman # on OG pinebook Signed-off-by: Vasily Khoruzhick --- drivers/clk/sunxi-ng/ccu-sun50i-a64.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.h b/drivers/clk/sunxi-ng/ccu-sun50i-a64.h index a8c11c0b4e06..dfba88a5ad0f 100644 --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.h +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.h @@ -21,7 +21,6 @@ /* PLL_VIDEO0 exported for HDMI PHY */ -#define CLK_PLL_VIDEO0_2X 8 #define CLK_PLL_VE 9 #define CLK_PLL_DDR0 10 @@ -32,7 +31,6 @@ #define CLK_PLL_PERIPH1_2X 14 #define CLK_PLL_VIDEO1 15 #define CLK_PLL_GPU 16 -#define CLK_PLL_MIPI 17 #define CLK_PLL_HSIC 18 #define CLK_PLL_DE 19 #define CLK_PLL_DDR1 20 From patchwork Sat Jan 4 07:36:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 13926129 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9A8B158DAC; Sat, 4 Jan 2025 07:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735976448; cv=none; b=jaOtlngnOCLZBxCAo/XSLvPAsBBQS7kS7U2teaktUwkryr7Wx17r9A5GjxHfO28z4NNxcYnSuY0tJSib9EtioEVi7nmczdnftet/T3mxKsTxFeGOf8K3s40Bw5BFIcu2eyHJo7Q8Hs/OGC85PN4nk7k2AaHjWqTMldqSlebap8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735976448; c=relaxed/simple; bh=YjINOz4Xv+YahkPpQKBJM0qt92m4mTvbJuNABy6+7Tg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dFVhWEn2U67d1GqWYQBb7h/XSjjXeZB0/lZOgDdVS2dbqjhDDMimKTaGZkfjb23aAS07aedxIzUObGyLS44BhXwJxh1yKDnQr1eKSzQbtT9BcNMWEJDdac/cIljoAk9Ns9C5v+eAZdtuFt0o3mYV+WtpQvx54S7EIQ/WCYN8fro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dKU9sNx7; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dKU9sNx7" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-216395e151bso131873295ad.0; Fri, 03 Jan 2025 23:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735976446; x=1736581246; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RemTwaYzBS1si26CVDrNGu9vkTiHrmOVmvsRlAFTpyQ=; b=dKU9sNx7FdSX7YaLeACqt2s9UpL72UP7fnVtIQ3eZPwgWDaer4oY55JozWyXS5s5IM 3TnxKVFafbO+w5+tWFSc/tOTcjpbbjBsNnfUFYTi2n7hfyaRmdpPVr4ZK+EUr3OJ8oWT HhHDmkg2+othLQcAZtovkzmkNICe2q/FvAbAioFZ8aqARMzVQY2s83vx/IkucgAY4yho zFzGcHoJMUruyDcNcO9jc+h5CpeWZfzZdbY8AD3UOMBHHC3Vtny8zz7qKN/9MQURAlHt ioxHMFlY0SNykZwIBEmvj6sM6jdrKQlFRVKSSGBzPjZH8Gu8eGQlsVDN7QuJyTBwPxBj DiKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735976446; x=1736581246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RemTwaYzBS1si26CVDrNGu9vkTiHrmOVmvsRlAFTpyQ=; b=p/asM5QB85d6/ZAeD7s9E99MbJLAD5fYDTNlyVkeXiNqoqrYyZbmDxMTKL+h3cjjWY 75okBNoIr0nOyMDQ6+/3fnfO4agO+l2qRgzfFxyfRZSXHMeZjpVF9HcuxRz8rcsTeqGJ xSWxKyWVqVMM2wEZjat1tiyyLbjQ3hrNARhcqZhqhp3vM+AQw4V67ce0wvib7hRUnUqi JwL1VKaBtUhdY+oa4tPmlElygxjzhq0W1sjne4wz3W/p1snDpPj4/jZs2B3nkWsV0uQF DGPKKj7CJ2wGC0fy7i3fBEc+dow0GdzCKl+mFCGig28A5ZmtPZRxwbFr5HZaihAMmKwu K1KA== X-Forwarded-Encrypted: i=1; AJvYcCVINzgGvOLW1GiuWHOqwUd6wpRfUmmXe5COJUw1A3FOJyZNhpN6NC6pCabonBWTZKXCaLQLcdy8dhbPzwwl@vger.kernel.org, AJvYcCXLMcaTMfR4f6rKdxFhMWMvOebOoM4uLWEbZ8lOOC//WIztmIZGniz8is9CEfknjxBtvpMB0CgyscW6@vger.kernel.org, AJvYcCXkXNjb9s2yXosTO7zpZsHG6PdCEckwet4kMtYT6E93rOBcdlui3NPnViM3FBvZIT1jDacjvRzPuOWh@vger.kernel.org X-Gm-Message-State: AOJu0YzbOAR72D0qQkyz1AqU/mxFxo1PuBSShmWM7OC0GO3cQDvYQTw2 ZzGhy103So5vb7UFEBSuDmz4EHzkeqAV0qT/if/l9D8XulStQQD9 X-Gm-Gg: ASbGncvJmoQxOUwvw2issET0G9QBjaDNtOoV8n3WE3wyMwJNwlb3zsFnwuRtLiuz/0b YmkoyshOqGDuDz7Kg/B1qkpzssc8spD9OHaFA68PA4TcZhZ4DGV2TBX/YM8M9X24e3r9jXkE1lY z32C4WP0TXnhsH0lQmm4LejBmFoFGgPm+4LrHFlAjiSBDHuy7G8d7vYG6KDJwPdRhbze9+BR7BW NhQBxMGyTlJ4t3li/iquOCHRI2w5s/UplN5gHzs7JsWKkRKKA== X-Google-Smtp-Source: AGHT+IFzAL/sWxagDkVX/+NamzAgakEA8UUO4OYdQZ4vgwAgnJ6fLVP3LLXGLkf1UZM4Gkgyz98S+A== X-Received: by 2002:a17:902:e746:b0:215:a303:24e9 with SMTP id d9443c01a7336-219e6ca6c2fmr758900565ad.3.1735976446069; Fri, 03 Jan 2025 23:40:46 -0800 (PST) Received: from anarsoul-xps15.lan ([2604:3d08:7780:1ca9::398]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02b34sm256562565ad.252.2025.01.03.23.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 23:40:45 -0800 (PST) From: Vasily Khoruzhick To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Vasily Khoruzhick , Dragan Simic , Frank Oltmanns , Stuart Gathman Subject: [PATCH v2 3/4] arm64: dts: allwinner: a64: explicitly assign clock parent for TCON0 Date: Fri, 3 Jan 2025 23:36:59 -0800 Message-ID: <20250104074035.1611136-4-anarsoul@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250104074035.1611136-1-anarsoul@gmail.com> References: <20250104074035.1611136-1-anarsoul@gmail.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 TCON0 seems to need a different clock parent depending on output type. For RGB it has to be PLL-VIDEO0-2X, while for DSI it has to be PLL-MIPI, so select it explicitly. Video output doesn't work if incorrect clock is assigned. On my Pinebook I manually configured PLL-VIDEO0-2X and PLL-MIPI to the same rate, and while video output works fine with PLL-VIDEO0-2X, it doesn't work at all (as in no picture) with PLL-MIPI. Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux") Reviewed-by: Dragan Simic Reviewed-by: Chen-Yu Tsai Tested-by: Frank Oltmanns # on PinePhone Tested-by: Stuart Gathman # on OG Pinebook Signed-off-by: Vasily Khoruzhick --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 2 ++ arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 2 ++ arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 ++ 3 files changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts index 379c2c8466f5..86d44349e095 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts @@ -390,6 +390,8 @@ &sound { &tcon0 { pinctrl-names = "default"; pinctrl-0 = <&lcd_rgb666_pins>; + assigned-clocks = <&ccu CLK_TCON0>; + assigned-clock-parents = <&ccu CLK_PLL_VIDEO0_2X>; status = "okay"; }; diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts index b407e1dd08a7..ec055510af8b 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts @@ -369,6 +369,8 @@ &sound { &tcon0 { pinctrl-names = "default"; pinctrl-0 = <&lcd_rgb666_pins>; + assigned-clocks = <&ccu CLK_TCON0>; + assigned-clock-parents = <&ccu CLK_PLL_VIDEO0_2X>; status = "okay"; }; diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index a5c3920e0f04..0fecf0abb204 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -445,6 +445,8 @@ tcon0: lcd-controller@1c0c000 { clock-names = "ahb", "tcon-ch0"; clock-output-names = "tcon-data-clock"; #clock-cells = <0>; + assigned-clocks = <&ccu CLK_TCON0>; + assigned-clock-parents = <&ccu CLK_PLL_MIPI>; resets = <&ccu RST_BUS_TCON0>, <&ccu RST_BUS_LVDS>; reset-names = "lcd", "lvds"; From patchwork Sat Jan 4 07:37:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 13926130 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5DE169397; Sat, 4 Jan 2025 07:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735976449; cv=none; b=UG6KhD7HH2v1d57FaBUpz176eoolKcb6fk5UA4v0/b7MFWC1KUY+MVgKkDdoyLZ3feXwFgL0wsAqo9LCIRG10097UFIPzS1qNXibJ5RzgKlT5u47bA0+V81VcjldmUZSjnsBa3Pfd2+rj8Ovgu/AnzVKBB3RWfT+tnizm8W168s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735976449; c=relaxed/simple; bh=nFF6gWVnSc4ZHH6uufJVq5/QMSkXaG4JWqQjtwpwgzw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VQd8wr4FQoEVQZg2rdO0OPSRyuLgk11YSgsFDU1yuaXyAYsgU1+o2/oAOxXVhJfftAdNE/3s+nD6MSwOlcpspntX92r4L+ZuKfbh3TLo5vFa3aM33hDRWaIw0/coqAobaVt5JnInbW9q7I8kkc19+g1xxZ4ac3gDWfox+5qGugs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gsZfJR7o; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gsZfJR7o" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21669fd5c7cso183722505ad.3; Fri, 03 Jan 2025 23:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735976447; x=1736581247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qIxbJ2OQHNBv+4wB0JZ4sOT/J/UNSOHviGNvJzFTzY0=; b=gsZfJR7oK9jUnTKeZQaFG2+6GI4BI7riPgIvegHsbaQnRqobMRx556m8gWvjtLtzRI 6ZFSUJvpAG2b6mx8k68VyEVbi7ZtDpSTkxzEQZId288NL6M+sCkQq2/fChUgQfRT3fen TSKXtbh+TxxBZL7r4Xp8vSYXPdjXfeEtACpigQO3NPqW+JqLx/TCQSHwnUW8LCt6dNOk HtugGk2nwHO9ZJ0OVXr23iIrNFRI4+g/RZuQUsRkD2ek0G6VdTYzXqEhA+bAgcFvJzf3 us47Cs89HT/O2kIwy5z7bWOT/gZ8MIYZ6sJuCBlavyVyCKkPYnrXvl4Jvpplb9idybRO wA6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735976447; x=1736581247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qIxbJ2OQHNBv+4wB0JZ4sOT/J/UNSOHviGNvJzFTzY0=; b=DobCUAdT4TR//hlIEsfCKDuiTtCkI4qjG3MbvN/j/Up7mFIdLsCCIJHwCUMJHYDoVC +evtbg20NH3j7d0Siid1ro0/+fyruMMPkz13hyJQZ/5C+Um0j04gDX8hHJ7mi5jC0oA/ yaSgqHK4S3nDyWwJ9cIvzKTrFxWqzSSx6XiMSON+7n8ITVNKkymJ3OEtGTTxzOSlCowE qhHjWh8EJZbD54dZ2pIoj2tGrew88z/yPInGnjYql6JuLTJBQ8WftjkKKt+eBYfHYrom 7KhGK4BHBX8/QGw6eLzTz6OuoEYasRU9oZwpvO4EF9JgnOnYfG4DC8lxYQHxJCsyxODM wr7Q== X-Forwarded-Encrypted: i=1; AJvYcCXAxu4/aEZ+EBXfJDOx+XLhBIVWIvxqBuo3tfxI0HgsCisOHctM4RZKTTqx8XAQIB9UAHYLDEsCfeW/@vger.kernel.org, AJvYcCXdKmJ8GRyfHJ75vJYZcO9MFa8WkohfYt1jFL9t9ztCvJ17TYPT2i/K5Z9lljZ9W8MPByp0w3sk4qFhDg0h@vger.kernel.org, AJvYcCXreTUNPWLVkQMMsBKi0dqAS9pv8WNRoteHZm6WWPTtQA5klwuN5Ax++89Fy0RXcQuXBYkcJ7wSlixM@vger.kernel.org X-Gm-Message-State: AOJu0YyYpduYJepztDGSZQZITXD4S3s2xE/1AtfRcuYJ77jcgHET7u33 qdJb6YPgqXq46rTiAKh4jcTyJRzAVhGH1t3Rc7jYTZpdEniQFQ8cGb5kkyqp X-Gm-Gg: ASbGnctAhqlHzXHhDFvNieKjkdpx9EeMeHjZPeAhWHBckPMx90ptNS8wBob79ksAQ9P M3e3ibBE8bLXi/Zm1Z7BBV4JLFEHu0wAd0q5BkXbzQnmkq/6Ac1dF4Lds2x4xASX2GkZk/flgUo CoxfzRSXLun+1NLKlHfixCnomXOXJs0mDZH2XmDoB0lX3ibiM/Os2dAlHh3mBm7f/yWM9js3UCZ BLf5bBw3ZtgAtyfzEOlAzIZllGdFmnlHCblpgLOp94+uIjrqg== X-Google-Smtp-Source: AGHT+IGzouKoKcczOFE/BlEmlBfzMQU1FzvtTcHjF3vHVcWHcn0aI0SCAElSuL8sd9OBoHBrGue/Jg== X-Received: by 2002:a17:903:2449:b0:218:a43c:571e with SMTP id d9443c01a7336-219e6ebd140mr793188505ad.28.1735976447244; Fri, 03 Jan 2025 23:40:47 -0800 (PST) Received: from anarsoul-xps15.lan ([2604:3d08:7780:1ca9::398]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02b34sm256562565ad.252.2025.01.03.23.40.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 23:40:46 -0800 (PST) From: Vasily Khoruzhick To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Vasily Khoruzhick , Dragan Simic , Frank Oltmanns , Stuart Gathman Subject: [PATCH v2 4/4] clk: sunxi-ng: a64: stop force-selecting PLL-MIPI as TCON0 parent Date: Fri, 3 Jan 2025 23:37:00 -0800 Message-ID: <20250104074035.1611136-5-anarsoul@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250104074035.1611136-1-anarsoul@gmail.com> References: <20250104074035.1611136-1-anarsoul@gmail.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Stop force-selecting PLL-MIPI as TCON0 parent, since it breaks video output on Pinebook that uses RGB to eDP bridge. Partially revert commit ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux"), while still leaving CLK_SET_RATE_NO_REPARENT flag set, since we do not want the clock to be reparented. The issue is that apparently different TCON0 outputs require a different clock, or the mux might be selecting the output type. I did an experiment: I manually configured PLL_MIPI and PLL_VIDEO0_2X to the same clock rate and flipped the switch with devmem. Experiment clearly showed that whenever PLL_MIPI is selected as TCON0 clock parent, the video output stops working. Therefore, TCON0 clock parent corresponding to the output type must be assigned in the device tree. Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux") Reviewed-by: Dragan Simic Reviewed-by: Chen-Yu Tsai Tested-by: Frank Oltmanns # on PinePhone Tested-by: Stuart Gathman # on OG Pinebook Signed-off-by: Vasily Khoruzhick --- drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c index 3a7d61c81667..ba1ad267f123 100644 --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c @@ -535,11 +535,11 @@ static SUNXI_CCU_M_WITH_MUX_GATE(de_clk, "de", de_parents, CLK_SET_RATE_PARENT); /* - * DSI output seems to work only when PLL_MIPI selected. Set it and prevent - * the mux from reparenting. + * Experiments showed that RGB output requires pll-video0-2x, while DSI + * requires pll-mipi. It will not work with incorrect clock, the screen will + * be blank. + * sun50i-a64.dtsi assigns pll-mipi as TCON0 parent by default */ -#define SUN50I_A64_TCON0_CLK_REG 0x118 - static const char * const tcon0_parents[] = { "pll-mipi", "pll-video0-2x" }; static const u8 tcon0_table[] = { 0, 2, }; static SUNXI_CCU_MUX_TABLE_WITH_GATE_CLOSEST(tcon0_clk, "tcon0", tcon0_parents, @@ -959,11 +959,6 @@ static int sun50i_a64_ccu_probe(struct platform_device *pdev) writel(0x515, reg + SUN50I_A64_PLL_MIPI_REG); - /* Set PLL MIPI as parent for TCON0 */ - val = readl(reg + SUN50I_A64_TCON0_CLK_REG); - val &= ~GENMASK(26, 24); - writel(val | (0 << 24), reg + SUN50I_A64_TCON0_CLK_REG); - ret = devm_sunxi_ccu_probe(&pdev->dev, reg, &sun50i_a64_ccu_desc); if (ret) return ret;