From patchwork Mon Jan 6 05:06:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Gordon X-Patchwork-Id: 13926979 Received: from omr012.pc5.atmailcloud.com (omr012.pc5.atmailcloud.com [103.150.252.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6461C35952; Mon, 6 Jan 2025 06:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.150.252.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736145406; cv=none; b=fUILcyQKZjrqOFm3pMit4t+CFk41vyGP7U92pGH7bOu+eut3w99YHL6nVE2ajwbrqPPkxf+WjRTQQIl8ugGan3FQZrAV5JBmbVPEQBlDvcBweh7WMPQMWCHTdLmePDCxzD3BNyuNQTBxm/eDDeKnI0SzYo29VNNaZ8nENavlge8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736145406; c=relaxed/simple; bh=YDBqG8ZodRei6EMnn7YHhxSXmHKiCZpuzRzPbzsHWjg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FLzjLYbZjczi/no1qF2uno67btxQ+ZbIIHvM92ovXIZNP8zbKovOQZ6M0PAMde7+Z6TGEucDE/CqVaj0AHOrDJIs8RvNz/AkE/q61EpxmWzr/ZfIv0AMDTq7izLsmE28opqM0UtMzWQrxWZg01MnQ7RF2mc8LOigfOl06tl5l88= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iinet.net.au; spf=pass smtp.mailfrom=iinet.net.au; dkim=pass (2048-bit key) header.d=iinet.net.au header.i=@iinet.net.au header.b=SOakZ0QZ; arc=none smtp.client-ip=103.150.252.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iinet.net.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iinet.net.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iinet.net.au header.i=@iinet.net.au header.b="SOakZ0QZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iinet.net.au; s=202309; h=MIME-Version:Message-Id:Date:Subject:To:From: content-type; bh=fImaNO1Onx6YYT3AQQ+ELeKQYxi7TfonhPqKCCFip8w=; b=SOakZ0QZf7Kw rb36bAasRgCfMn/iYSe5QLjhhQfZEvzje7ZLxWgrQeQ4EzOHbvnQhxZ6zUZQUjEf45drs9j1kHiMU IK5SWYusSCMey+oVhGmtJIFghv/LyAUB51kF+VID2HK9X/akc8aHTdXxwkld+8YSWdu/yP05ie/a0 9knwnyVXtRReD+BpnEMFT0yEZGwJV7zvSwvtLJfcTBVgm07OnZW06Z5n56HGp9bXavHiiwlaR1HzF /1davEOdAZD1VzZUvgtKRZFefgIhZftBGj4g0/buI35A0wC7Xz/GqLnJzMdj3tUsd53xO1L2+PmmG FnfPJgLI5tkxfbAXURj91g==; Received: from cmr-kakadu03.internal.pc5.atmailcloud.com (cmr-kakadu03.internal.pc5.atmailcloud.com [192.168.1.5]) by omr.internal.pc5.atmailcloud.com (Exim/cmr-kakadu03.i-0cce97f01b2d699e6) with ESMTPS (envelope-from ) id 1tUfKZ-000000000CX-1Pmy ; Mon, 06 Jan 2025 05:07:11 +0000 Received: from [220.233.184.101] (helo=localhost) by CMR-KAKADU03.i-0cce97f01b2d699e6 with esmtpsa (envelope-from ) id 1tUfKY-000000005np-2Zsw; Mon, 06 Jan 2025 05:07:10 +0000 From: Stephen Gordon To: kuninori.morimoto.gx@renesas.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Gordon Subject: [PATCH v2 1/2] ASoC: simple_card: Improve debugging messages Date: Mon, 6 Jan 2025 16:06:58 +1100 Message-Id: <20250106050659.57924-2-gordoste@iinet.net.au> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250106050659.57924-1-gordoste@iinet.net.au> References: <20250106050659.57924-1-gordoste@iinet.net.au> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Atmail-Id: gordoste@iinet.net.au X-atmailcloud-spam-action: no action X-Cm-Analysis: v=2.4 cv=WdsKaVhX c=1 sm=1 tr=0 ts=677b64fe a=HSUqTxjWRdnMbJspRni59w==:117 a=HSUqTxjWRdnMbJspRni59w==:17 a=VdSt8ZQiCzkA:10 a=x7bEGLp0ZPQA:10 a=4jraHwQkAAAA:8 a=qSRHBturNNxlZSGQuJ4A:9 X-Cm-Envelope: MS4xfHXXG3pmW0cXQnOSakMhpu8zOJQoUB9jrEL2YqJRE80ZDU7L6UvnhzzCtwd7FRZxkG1BvhgYzRfWyQznK5mPiiwMEttGApJQfrLimpKSOo6Z4nqWzNCY tFHx5fULmi6Otw7+lGRLNdNMdjZB+4YmVxSr7D7opWoc8iUwx0+88RZayKZ1FhUwd9lzxlYJ1E1zm15YCCw3mfunpW8sicGHI58= X-atmailcloud-route: unknown These fields are from the dai_link, not the dai. Signed-off-by: Stephen Gordon --- include/sound/simple_card_utils.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h index 3360d9eab068..af79f680c72a 100644 --- a/include/sound/simple_card_utils.h +++ b/include/sound/simple_card_utils.h @@ -264,9 +264,9 @@ static inline void simple_util_debug_info(struct simple_util_priv *priv) simple_util_debug_dai(priv, "codec", dai); if (link->name) - dev_dbg(dev, "dai name = %s\n", link->name); + dev_dbg(dev, "link name = %s\n", link->name); if (link->dai_fmt) - dev_dbg(dev, "dai format = %04x\n", link->dai_fmt); + dev_dbg(dev, "link format = %04x\n", link->dai_fmt); if (props->adata.convert_rate) dev_dbg(dev, "convert_rate = %d\n", props->adata.convert_rate); if (props->adata.convert_channels) From patchwork Mon Jan 6 05:06:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Gordon X-Patchwork-Id: 13926951 Received: from omr008.pc5.atmailcloud.com (omr008.pc5.atmailcloud.com [103.150.252.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBBB417E0; Mon, 6 Jan 2025 05:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.150.252.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736140045; cv=none; b=okC3N+zkFfmhqIsAuFFQRZkAjHmFMCZfOXVq9l615oVyyTHVZzf1kxM4V5Yo0Zf4mQBqJhMEzT/K0UFcBZHGn5YSKWhD/3XX4+9ziKa93EtyGQDBoE0RtEroDpC3mSE9C0nhh0K4UpIbmFgY16Up0PUY0MgwhhmEtpg0sAz5Hnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736140045; c=relaxed/simple; bh=jRUYhxQ7NMExMlLwQP374k+zj9bliP3exrTVXAOWMo8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XcAf3u5mWZUIHHuM8tAlTlOm2I8M9MOqZLnjuRX3e9o5tje1+yur2QLLXKiRdHz6wcKV/UA4HmYnPCQ1h+n8fSmuxY/17bj/5LCrJgiQeBH0Ps8jxZnP0uApZiBo3Q1vzzjlOkFwUDCv2OPAp1RGEVOFn8Sk1HiJqKqNIKWWeMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iinet.net.au; spf=pass smtp.mailfrom=iinet.net.au; dkim=pass (2048-bit key) header.d=iinet.net.au header.i=@iinet.net.au header.b=KnoeJBS7; arc=none smtp.client-ip=103.150.252.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iinet.net.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iinet.net.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iinet.net.au header.i=@iinet.net.au header.b="KnoeJBS7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iinet.net.au; s=202309; h=MIME-Version:Message-Id:Date:Subject:To:From: content-type; bh=IMCtKiq/bz5Kf6LhiUoK+HLLlZ+iqlss2F1pw7iiIg0=; b=KnoeJBS7GmtJ YPu1eFlomS03NjheEbywV/D8eRCFP1cXRT0mNI+wFIl5kYDwEBvUBQrSsfsnHZLkklMtREdgjz2OT zzBzQXJDsaqgNMMkgVGb7KRfYnheZwGoeAvmur6gVhSttj4VPHeAnlnnP3SGhKDx3KjeVh5VN7coR GOjezL/77LKXja/S7IsBnagN92wZrdujswXkgG84d63nzTESv0eioQGOnQ63AUNwu0+ZaeASx0jEN 1V2U71TcpTl+e6sEd+psf+VWjqjuP0rFkZl2s9R7OwoAKfyC5QEzYEvijAnG57l49n25t5S5oABbQ RyDQ/NCWvzEVm4iuFHqd8w==; Received: from cmr-kakadu03.internal.pc5.atmailcloud.com (cmr-kakadu03.internal.pc5.atmailcloud.com [192.168.1.5]) by omr.internal.pc5.atmailcloud.com (Exim/cmr-kakadu03.i-08216fbfbb76706e2) with ESMTPS (envelope-from ) id 1tUfKc-000000005r6-308G ; Mon, 06 Jan 2025 05:07:14 +0000 Received: from [220.233.184.101] (helo=localhost) by CMR-KAKADU03.i-08216fbfbb76706e2 with esmtpsa (envelope-from ) id 1tUfKc-000000000TH-0hjA; Mon, 06 Jan 2025 05:07:14 +0000 From: Stephen Gordon To: kuninori.morimoto.gx@renesas.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Gordon Subject: [PATCH v2 2/2] ASoC: simple_card: Show if link is unidirectional Date: Mon, 6 Jan 2025 16:06:59 +1100 Message-Id: <20250106050659.57924-3-gordoste@iinet.net.au> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250106050659.57924-1-gordoste@iinet.net.au> References: <20250106050659.57924-1-gordoste@iinet.net.au> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Atmail-Id: gordoste@iinet.net.au X-atmailcloud-spam-action: no action X-Cm-Analysis: v=2.4 cv=MYZquY/f c=1 sm=1 tr=0 ts=677b6502 a=HSUqTxjWRdnMbJspRni59w==:117 a=HSUqTxjWRdnMbJspRni59w==:17 a=VdSt8ZQiCzkA:10 a=x7bEGLp0ZPQA:10 a=4jraHwQkAAAA:8 a=2_3RrZhEg9tCGMFQ2A8A:9 X-Cm-Envelope: MS4xfJWWeGDTY3xV8xTLwWtNakRvE7OrFWAP28LRBeMhax9aWAIcoCV5EiTBTij4SDDLeO7vdhuY1Li9WpXMMCtYJcA33cs/6U/oHqPDxtTrUgIqPhMN4qd0 2bsb/ibzb56yNAdjxfQ2V+u4ks7AEt7g8fXOyxb/UW+3PTJhQc0huf04jvY9dp8Rq6B8H9rNcJQ6MTCMHjsjJ9PenagDgMIZP38= X-atmailcloud-route: unknown It is handy to know whether the link has playback-only/capture-only flags when debugging. Signed-off-by: Stephen Gordon --- include/sound/simple_card_utils.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h index af79f680c72a..f6bfd485c31a 100644 --- a/include/sound/simple_card_utils.h +++ b/include/sound/simple_card_utils.h @@ -267,6 +267,10 @@ static inline void simple_util_debug_info(struct simple_util_priv *priv) dev_dbg(dev, "link name = %s\n", link->name); if (link->dai_fmt) dev_dbg(dev, "link format = %04x\n", link->dai_fmt); + if (link->playback_only) + dev_dbg(dev, "link has playback_only"); + if (link->capture_only) + dev_dbg(dev, "link has capture_only"); if (props->adata.convert_rate) dev_dbg(dev, "convert_rate = %d\n", props->adata.convert_rate); if (props->adata.convert_channels)