From patchwork Wed Jan 8 08:09:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Zhang <18255117159@163.com> X-Patchwork-Id: 13930272 X-Patchwork-Delegate: kw@linux.com Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B54E61DF255; Wed, 8 Jan 2025 08:11:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736323909; cv=none; b=XUOzsN0c7aUAhVFZuOZtkHcXF5bJgz2dAFkdNaA5X3ty5LoSkD6M7N70zwos1UtMwHLgGL4vbK+8U0Xhmld1BI6JcU31Ji4T2skASPgs1ITJpjYl9wUQuhT141Q9+n9NILiZRa7y1gbunE1fdUfpEpZf+5sYGn6TEizsXYL8JpU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736323909; c=relaxed/simple; bh=B20//Nxo7KrJRxecgE0VK6/BNTwWLzub47DZ7fWkh7g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FeDGgLiDhw2iZaCMHTST5R4aaltwasvSkvRyrWrLI1286ar7qp8sz4XMxRvxVjzBAc6V41dZtgol1d4fJ4MEQR32y8knu8IrhCgjryykoAsA588WOtP9jKCSf6+rzBVXo9OeaAKe6vXa1UgGfeOLzPZ7mbIcXDneF2/9d3pIRn8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=JpDtITPE; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="JpDtITPE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=qim/k O5p3rdm6ZjllT4hLqqhz09hnjs6wKFbgB7TGVc=; b=JpDtITPEiO0BSma2vni70 +F59B35+2MTz2yNymLkzkkiQp41NRW2H7d7T3eekZFbZc7D4XuP9z8zB7Rlj5L0r pCgQh3Iy33c7IJftL0hwxIXg6C72jblc6+AnFhEvURF46m2pgwe8E5MG/9LqOjfO TpBtdaZuERthJn35RQdL8Y= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-3 (Coremail) with SMTP id _____wBH9z0ZM35ntarHEg--.53777S3; Wed, 08 Jan 2025 16:11:09 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: manivannan.sadhasivam@linaro.org Cc: kw@linux.com, kishon@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rockswang7@gmail.com, Hans Zhang <18255117159@163.com>, Niklas Cassel Subject: [v10 1/2] misc: pci_endpoint_test: Remove the "remainder" code Date: Wed, 8 Jan 2025 16:09:50 +0800 Message-Id: <20250108080951.1700230-2-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250108080951.1700230-1-18255117159@163.com> References: <20250108080951.1700230-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: _____wBH9z0ZM35ntarHEg--.53777S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ww45Jw1rCr13JF4kGr4DJwb_yoW8WF4Dpr ZxCry0yF4jyry8Gw4xK3ZrCFyFya9rXry7JFW5Cw1FvrnIvFn5tF15GrW8Kry8CFZFvF1Y vanrAa1v9w17CFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jUYFtUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbBDx-Oo2d+Kwjf3QABsE A BAR size is always a power of two. buf_size = min(SZ_1M, bar_size); If the BAR size is <= 1MB, there will be 1 iteration, no remainder. If the BAR size is > 1MB, there will be more than one iteration, but the size will always be evenly divisible by 1MB, so no remainder. Signed-off-by: Hans Zhang <18255117159@163.com> Suggested-by: Niklas Cassel Reviewed-by: Niklas Cassel --- Changes since v9: https://lore.kernel.org/linux-pci/20250108072504.1696532-2-18255117159@163.com - Remove the remain variable declaration. --- drivers/misc/pci_endpoint_test.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index 3aaaf47fa4ee..f78c7540c52c 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -280,7 +280,7 @@ static int pci_endpoint_test_bar_memcmp(struct pci_endpoint_test *test, static bool pci_endpoint_test_bar(struct pci_endpoint_test *test, enum pci_barno barno) { - int j, bar_size, buf_size, iters, remain; + int j, bar_size, buf_size, iters; void *write_buf __free(kfree) = NULL; void *read_buf __free(kfree) = NULL; struct pci_dev *pdev = test->pdev; @@ -313,12 +313,6 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test, write_buf, read_buf, buf_size)) return false; - remain = bar_size % buf_size; - if (remain) - if (pci_endpoint_test_bar_memcmp(test, barno, buf_size * iters, - write_buf, read_buf, remain)) - return false; - return true; } From patchwork Wed Jan 8 08:09:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Zhang <18255117159@163.com> X-Patchwork-Id: 13930271 X-Patchwork-Delegate: kw@linux.com Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 167021E131A; Wed, 8 Jan 2025 08:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736323902; cv=none; b=dTTCu9964aTxcwFQj9iZKNOIsBmqB0bWxTjC2e6/a3M1wDc7GfG+f9+ZObrUt6TbuhfB9xvlh7l1oNF2Pn4CPLA+TTSABDGOxD6Ygf/Bph3MjzoYJ/GoPD0nh2HZkAqunido1qVt92ZkioywHIGGPkDymoNsoE1Z6N2HJmjwANM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736323902; c=relaxed/simple; bh=q9iRDQVQ78G1hGB1JPBL1qLU8lZPLaQJrJJ/dGPagIU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pI7a/SD+ab4ISeJHJ35tlKBlXLvcagPv8p4TKi40vzxxM3KyUQKM/bYnTD+iNBLHQX1LGVIofqx4dF0E1blNe4MhRLQbL33tE/KXGptMV1Sy//RiBxa69l2gEsHfZJkq+R5/Atr9BSJ7FtGC5OYzhhHNTSWfjpUFUbhIy///Pj0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=oAE5bP0k; arc=none smtp.client-ip=220.197.31.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="oAE5bP0k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=ZptBK 0K04q8zYSaMPbBz5I6UurDi65fUBNkXQbP03Wk=; b=oAE5bP0k77gaHiYWwuGoY 0n3KvucbSe0OctJBpSimONQ/Pl7CU0dgdMjs8I06m6WAV9TVirL1+53hnH+icWR7 hQ32chHN1oYlr2eLqAU8SKWf8GDxoQNiBUxzWBDcSWeTw2Yr08YjnwdgJHYsdg5K ZlwEfmeILdda1Y4rjjAeyk= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-3 (Coremail) with SMTP id _____wBH9z0ZM35ntarHEg--.53777S4; Wed, 08 Jan 2025 16:11:10 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: manivannan.sadhasivam@linaro.org Cc: kw@linux.com, kishon@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rockswang7@gmail.com, Hans Zhang <18255117159@163.com>, Niklas Cassel Subject: [v10 2/2] misc: pci_endpoint_test: Fix overflow of bar_size Date: Wed, 8 Jan 2025 16:09:51 +0800 Message-Id: <20250108080951.1700230-3-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250108080951.1700230-1-18255117159@163.com> References: <20250108080951.1700230-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: _____wBH9z0ZM35ntarHEg--.53777S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7Aw18Gw1ruw4DJrWxZFyDAwb_yoW8KrWkpF Z0kr1vvF4Ut348Gan7G3ZrCFyYya9rJry7WFW5Aw1FvFnxZFn5t3W0grWYgrnruFsF9F18 A3ZIya1vgw12kFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j4oGQUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbBDxDOo2d+KwjgNgAAse With 8GB BAR2, running pcitest -b 2 fails with "TEST FAILED". The return value of the `pci_resource_len` interface is not an integer. Using `pcitest` with an 8GB BAR2, the bar_size of integer type will overflow. Change the data type of bar_size from integer to u64, to fix the above issue. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Niklas Cassel --- Changes since v8-v9: https://lore.kernel.org/linux-pci/20250104151652.1652181-1-18255117159@163.com/ - Split the patch. Changes since v4-v7: https://lore.kernel.org/linux-pci/20250102120222.1403906-1-18255117159@163.com/ - Fix 32-bit OS warnings and errors. - Fix undefined reference to `__udivmoddi4` Changes since v3: https://lore.kernel.org/linux-pci/20241221141009.27317-1-18255117159@163.com/ - The patch subject were modified. Changes since v2: https://lore.kernel.org/linux-pci/20241220075253.16791-1-18255117159@163.com/ - Fix "changes" part goes below the --- line - The patch commit message were modified. Changes since v1: https://lore.kernel.org/linux-pci/20241217121220.19676-1-18255117159@163.com/ - The patch subject and commit message were modified. --- drivers/misc/pci_endpoint_test.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index f78c7540c52c..812508308187 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -280,10 +280,11 @@ static int pci_endpoint_test_bar_memcmp(struct pci_endpoint_test *test, static bool pci_endpoint_test_bar(struct pci_endpoint_test *test, enum pci_barno barno) { - int j, bar_size, buf_size, iters; + int j, buf_size, iters; void *write_buf __free(kfree) = NULL; void *read_buf __free(kfree) = NULL; struct pci_dev *pdev = test->pdev; + u64 bar_size; if (!test->bar[barno]) return false; @@ -307,7 +308,8 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test, if (!read_buf) return false; - iters = bar_size / buf_size; + do_div(bar_size, buf_size); + iters = bar_size; for (j = 0; j < iters; j++) if (pci_endpoint_test_bar_memcmp(test, barno, buf_size * j, write_buf, read_buf, buf_size))