From patchwork Wed Jan 8 18:40:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 13931486 X-Patchwork-Delegate: matthieu.baerts@tessares.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B8A201262 for ; Wed, 8 Jan 2025 18:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361651; cv=none; b=uXaDwaNK3Z+TL0fpu/+rOfXfYVprHstO7zCvR1fkmWb+REPx5b5TPP5HKv32v07X6XFmn7J40sPyKB1B/32tM+VJVcYDLo13d/KImh/6Vcfqbqmxt6FEYSiU1GuzcyoG4vK9jWlvXk0T+ip8Wl6qvsezFFlOv3QP9ci5CS6KIf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361651; c=relaxed/simple; bh=b3PI71NHstCMhsZXMoP+IwTs9UVTtOoekjnzXfP9sQk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c9cBBx9h2lO73Y42yZyYuPkaR1RruGmDVxCTrrT/CX3G9ERo3JMEzh32lCqRjedrfy4tvQhRAP9xIztHwvRX1Q8I3IfAUP6P50zrblwfDZxAP4eQzmX6sycE5lPELBZmvin45t77XET0eDHQ9vGfvl6U9IGYbzL2BRk5fEXWpPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BX+Svqo/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BX+Svqo/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E91E8C4CEDF; Wed, 8 Jan 2025 18:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736361650; bh=b3PI71NHstCMhsZXMoP+IwTs9UVTtOoekjnzXfP9sQk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=BX+Svqo/sL59QbqXVLh5ou8p3HyiTEoEN8LhXy58P1R1l8N575eX4GdiqmzLAR763 biRQPS32XqkAscyua4rhTMOgguGNV3rkgTI+B772iiSBZq+aZr7G6/XZ0ZPk1g3D9x Yu5G10FwskTN6qbj2oyEHx5ySz+HdKRmzLEfnZ2zKq2pTf1m7R5zHnpDiUUXJabzjS 809YrnoEL/ey3seGR7cO4Gy4DOa/OaWjWJ8U3G0Xlt2lKCoiWBnjiKh7G6Mk6zSlS1 ZoELcYsDATU/u938TSPVbyqPu8kjm0Z36Zx2MzbPLoXn8AQ50uw0AXm6DjrtNVBdxU mBxh+K3ub/P3A== From: "Matthieu Baerts (NGI0)" Date: Wed, 08 Jan 2025 19:40:37 +0100 Subject: [PATCH mptcp-next 1/5] selftests: mptcp: simult_flows: unify errors msgs Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250108-slft-mptcp-conn-misc-impr-v1-1-bdfbdba48a1f@kernel.org> References: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> In-Reply-To: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2627; i=matttbe@kernel.org; h=from:subject:message-id; bh=b3PI71NHstCMhsZXMoP+IwTs9UVTtOoekjnzXfP9sQk=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBnfsawOZzVDzL++OVvJ4jXqgOhMECTeGAL0epwE Ewfu60LjzuJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZ37GsAAKCRD2t4JPQmmg cw7qEADpRWgixFKXShqt4WQvxN2wRXm3Ctf9k+RJzuSUjWtrAM9qXZCoRZOG1hI7TogashbxoQn KeSwlJaMjyBRfIySopfxVV4KtnoYlhTaAujlmwRKePYBSt7a05qNLqsGt6CpKvxE4isen+tO2cF N9rerrUFmv3i7bttQAhtJnaBwX9UiTONr7e0a48FW5vlgRfug2dJ+aceulHjXi0NsV5551C6hHq B5OGcMqEWrkhS9fVkaHa9s43vnWF1rxpUjsDvmFGunAy+SalLu1hUwMIhXmRGvyu0L17GPmG3MV T9vQzNZoJsBtNIt9nUVvtE/TaXTerFpVK3iX14XZ5H4rG/MEM/KziXorkgo+pn8UO3zEkPpazDF evuk5iP31aM25rYMorPEGWaw7cPoYKpEY2wVDpDdF9YfmA7iRqh3rVbS6sNUhuSAGVLlR6ZAZ6z B1pLLkFZ+mfqgtgMRRLGglybZ33lUA+c4YJyRov0DCmCKQVGg7zFqO2uF8T8ArWl6w6HBpH/TE+ aM+Ko+WifSHG5XHHwIBh3t7x9Q51d/oj23k5TTsSSZkCf4c+SSIZYLhGszeDCt4WnsDrEc1y9QX YawlxqA6zVaApw2N0LPd1QdFcJCmGjU5GLOCsjxDZvfMoCxoBMmxTWFP4UY+JwSnKI5AfreLiDF nTo/WnSss4DGgWw== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 In order to unify what is printed in case of error, similar to what is done in mptcp_connect.sh and mptcp_join.sh, it is interesting to do the following modifications in simult_flows.sh: - Print the rc errors at the end of the line. - Print the MIB counters. - Use the same ss options: add -M (MPTCP sockets) and -e (detailed socket information). While at it, also print of the 'max' time only in case of success, because 'mptcp_connect.c' will already print this info in case of error, e.g.: transfer slower than expected! runtime 11948 ms, expected 11921 ms Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/simult_flows.sh | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh index 8fa77c8e9b651171a34c89bfd5c9ded0288a5bde..e98e5907d52c2d0e9c0152efda82176861905cf1 100755 --- a/tools/testing/selftests/net/mptcp/simult_flows.sh +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh @@ -155,6 +155,11 @@ do_transfer() sleep 1 fi + NSTAT_HISTORY=/tmp/${ns3}.nstat ip netns exec ${ns3} \ + nstat -n + NSTAT_HISTORY=/tmp/${ns1}.nstat ip netns exec ${ns1} \ + nstat -n + timeout ${timeout_test} \ ip netns exec ${ns3} \ ./mptcp_connect -jt ${timeout_poll} -l -p $port -T $max_time \ @@ -180,25 +185,31 @@ do_transfer() kill ${cappid_connector} fi + NSTAT_HISTORY=/tmp/${ns3}.nstat ip netns exec ${ns3} \ + nstat | grep Tcp > /tmp/${ns3}.out + NSTAT_HISTORY=/tmp/${ns1}.nstat ip netns exec ${ns1} \ + nstat | grep Tcp > /tmp/${ns1}.out + cmp $sin $cout > /dev/null 2>&1 local cmps=$? cmp $cin $sout > /dev/null 2>&1 local cmpc=$? - printf "%-16s" " max $max_time " if [ $retc -eq 0 ] && [ $rets -eq 0 ] && \ [ $cmpc -eq 0 ] && [ $cmps -eq 0 ]; then + printf "%-16s" " max $max_time " mptcp_lib_pr_ok cat "$capout" return 0 fi - mptcp_lib_pr_fail - echo "client exit code $retc, server $rets" 1>&2 + mptcp_lib_pr_fail "client exit code $retc, server $rets" echo -e "\nnetns ${ns3} socket stat for $port:" 1>&2 - ip netns exec ${ns3} ss -nita 1>&2 -o "sport = :$port" + ip netns exec ${ns3} ss -Menita 1>&2 -o "sport = :$port" + cat /tmp/${ns3}.out echo -e "\nnetns ${ns1} socket stat for $port:" 1>&2 - ip netns exec ${ns1} ss -nita 1>&2 -o "dport = :$port" + ip netns exec ${ns1} ss -Menita 1>&2 -o "dport = :$port" + cat /tmp/${ns1}.out ls -l $sin $cout ls -l $cin $sout From patchwork Wed Jan 8 18:40:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 13931487 X-Patchwork-Delegate: matthieu.baerts@tessares.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC6A4201264 for ; Wed, 8 Jan 2025 18:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361651; cv=none; b=u3/bseTUr57jOo4FQGdce9MTC5qj2xhZF2pX+zfJTiNHllSsc46yNo+gQlhJVokyxYKEfDA9nMU4fgqej8TzkcnHiK1dZeQThHH9Lqz7jqYPQ34yfVkV+8IfSPvmfD7nT5H2K44fbcfkk8tO3bN9PG86rl9pbnt4ORqCE6d3IwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361651; c=relaxed/simple; bh=Ecko4f3i6j9yEeSjVkzAmdTOGM/LUREIPjpZDI4Qxzc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XbPJXQu0ha23E7Q2c04bQMZmQPw20qNmgBaogqtcBiKKp/aGYsBIjU6GNfnDU0Hd8DYmZKr1ACbd2K38VYl/PcqXesf3d+p+AvH6WSOIVN6tIgpiEQfPLhC8co49/pKYNFarD5PZyjhG4sai9a+QEiSxAMoVIND5Q2Ml23wtJlY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OJ/N2X04; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OJ/N2X04" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7297C4CEE1; Wed, 8 Jan 2025 18:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736361651; bh=Ecko4f3i6j9yEeSjVkzAmdTOGM/LUREIPjpZDI4Qxzc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=OJ/N2X04C3P4uVXQMja1FoSoQTg/7N9ehHS2KjASS8jMeJZUnuYhRLwldKzXnTEa7 1ADEZlOWfn6EBqZPOM1VJ4R0gzuyfBkOGCXZ5V72czUiO1cwEg/v1Edj6ljsHHUX9L dRupez0w3gadBC8fJrsHGAOR9FE9p8B+nN7zEDfFy9MpGDEQ73LgRkbaZ5fbiVgXL/ jenH23Dou68sGl3crBO5TmdYgVWTHhaA1fwjCdygtdq+iOnJG6ufwlhdKwrmOl63aT ZD0YVaMIbtYR9TSJGKA/A33gVNpVgGBAm7ZMXFlR6Zpl96ynEZY7oqdz5SSY7peS/o Ibr4nmjUREcNw== From: "Matthieu Baerts (NGI0)" Date: Wed, 08 Jan 2025 19:40:38 +0100 Subject: [PATCH mptcp-next 2/5] selftests: mptcp: move stats info in case of errors to lib.sh Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250108-slft-mptcp-conn-misc-impr-v1-2-bdfbdba48a1f@kernel.org> References: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> In-Reply-To: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5825; i=matttbe@kernel.org; h=from:subject:message-id; bh=Ecko4f3i6j9yEeSjVkzAmdTOGM/LUREIPjpZDI4Qxzc=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBnfsaw6fL/uTAvmLZdpHs+Rw5eZRbOZFbG9lGti MHOloGFALmJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZ37GsAAKCRD2t4JPQmmg c6JnEACQpaLyQGKr8IvZnEov+gGk7KtfxJPRywzHW2FWpYTb+jaSdNRWgORUWgdaMCZbjTvR7px GvGZfk7pRuCOV/jKOuL86CPpmNsGM4tdSl2qXDoe3TOW/Bd0fiPUJpQqFtu2Xjy0aLOwxCXmjWy aAD7fTHcpFRASAXsajuGWBVwRSCGA8FfFxussW+4bU84WbM30PcmIimEenn/KPKI1UYixm/zdal lIHQMYs0SE+08Og5iRGC8SnMC5ronoE5Vg7AIGilkQe5+HEcEGG+4gqATd4ovFZklyDlmPJz5Ke gfI212xFZD613Kozbl8QIHDyVrTNwo582Qn7anrkHlbQqfGmIYlZt3YKjEZFzQyTgIXPl5GSrGO suvoDC7cBC38n35CRXX5p7+xHVAwgkSJfQZIRQ+PsWiFNQ1SBF1AXL4MgFtyYCjX9qRdE6INEO7 ozcKATBWpV/89fHey3NS41MC+lly5QoOSCjRgrkLZu6rFRXCuXTUOpKFyGZ+pnYfSyL/NP0uU1X i5+SJTleKtvimhVstXyXTmpmjvhumrjTKk1mXCoOF2Py9tftbAW5MS5aibCloXyFtz1l8iu2JCw 78YOjn47BGRD355Wf7sdM74juulPRXsLR+EvH34GN1s/259n2KE+yDMVqE2zFGE+0dMD8Wd7lGH khKpwy/DF01bsfg== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 A few MPTCP selftests are using the same code to print stats in case of error. This code can then be moved to mptcp_lib.sh. No behaviour changes intended, except to print the error in red and to stderr, like most error messages. Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 8 ++------ tools/testing/selftests/net/mptcp/mptcp_join.sh | 9 ++------- tools/testing/selftests/net/mptcp/mptcp_lib.sh | 21 +++++++++++++++++++++ tools/testing/selftests/net/mptcp/mptcp_sockopt.sh | 6 +----- tools/testing/selftests/net/mptcp/simult_flows.sh | 8 ++------ 5 files changed, 28 insertions(+), 24 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh index b48b4e56826a9cfdb3501242b707ae2ebe29b220..bfdaecd0a6a0564020530345daf91bed296bc15c 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -445,12 +445,8 @@ do_transfer() printf "(duration %05sms) " "${duration}" if [ ${rets} -ne 0 ] || [ ${retc} -ne 0 ]; then mptcp_lib_pr_fail "client exit code $retc, server $rets" - echo -e "\nnetns ${listener_ns} socket stat for ${port}:" 1>&2 - ip netns exec ${listener_ns} ss -Menita 1>&2 -o "sport = :$port" - cat /tmp/${listener_ns}.out - echo -e "\nnetns ${connector_ns} socket stat for ${port}:" 1>&2 - ip netns exec ${connector_ns} ss -Menita 1>&2 -o "dport = :$port" - [ ${listener_ns} != ${connector_ns} ] && cat /tmp/${connector_ns}.out + mptcp_lib_pr_err_stats "${listener_ns}" "${connector_ns}" "${port}" \ + "/tmp/${listener_ns}.out" "/tmp/${connector_ns}.out" echo cat "$capout" diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh index c07e2bd3a315aac9c422fed85c3196ec46e060f7..13a3b68181ee14eb628a858e5738094c3c936b74 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -1039,13 +1039,8 @@ do_transfer() if [ ${rets} -ne 0 ] || [ ${retc} -ne 0 ]; then fail_test "client exit code $retc, server $rets" - echo -e "\nnetns ${listener_ns} socket stat for ${port}:" 1>&2 - ip netns exec ${listener_ns} ss -Menita 1>&2 -o "sport = :$port" - cat /tmp/${listener_ns}.out - echo -e "\nnetns ${connector_ns} socket stat for ${port}:" 1>&2 - ip netns exec ${connector_ns} ss -Menita 1>&2 -o "dport = :$port" - cat /tmp/${connector_ns}.out - + mptcp_lib_pr_err_stats "${listener_ns}" "${connector_ns}" "${port}" \ + "/tmp/${listener_ns}.out" "/tmp/${connector_ns}.out" return 1 fi diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh index 975d4d4c862afff2e685e86dc08a892dbd09d783..50ca64357053b14cd4989e6647d825337978fdba 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh @@ -107,6 +107,27 @@ mptcp_lib_pr_info() { mptcp_lib_print_info "INFO: ${*}" } +# $1-2: listener/connector ns ; $3 port ; [ $4-5 listener/connector stat file ] +mptcp_lib_pr_err_stats() { + local lns="${1}" + local cns="${2}" + local port="${3}" + local lstat="${4:-}" + local cstat="${5:-}" + + echo -en "${MPTCP_LIB_COLOR_RED}" + { + printf "\nnetns %s (listener) socket stat for %d:\n" "${lns}" "${port}" + ip netns exec "${lns}" ss -Menita -o "sport = :${port}" + [ -s "${lstat}" ] && cat "${lstat}" + + printf "\nnetns %s (connector) socket stat for %d:\n" "${cns}" "${port}" + ip netns exec "${cns}" ss -Menita -o "dport = :${port}" + [ "${lstat}" != "${cstat}" ] && [ -s "${cstat}" ] && cat "${cstat}" + } 1>&2 + echo -en "${MPTCP_LIB_COLOR_RESET}" +} + # SELFTESTS_MPTCP_LIB_EXPECT_ALL_FEATURES env var can be set when validating all # features using the last version of the kernel and the selftests to make sure # a test is not being skipped by mistake. diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh index 5e8d5b83e2d092879efc179f1a450542be4e575e..6b366c604a9eeccdb759f260be4feafc380ccb0b 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh @@ -192,11 +192,7 @@ do_transfer() print_title "Transfer ${ip:2}" if [ ${rets} -ne 0 ] || [ ${retc} -ne 0 ]; then mptcp_lib_pr_fail "client exit code $retc, server $rets" - echo -e "\nnetns ${listener_ns} socket stat for ${port}:" 1>&2 - ip netns exec ${listener_ns} ss -Menita 1>&2 -o "sport = :$port" - - echo -e "\nnetns ${connector_ns} socket stat for ${port}:" 1>&2 - ip netns exec ${connector_ns} ss -Menita 1>&2 -o "dport = :$port" + mptcp_lib_pr_err_stats "${listener_ns}" "${connector_ns}" "${port}" mptcp_lib_result_fail "transfer ${ip}" diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh index e98e5907d52c2d0e9c0152efda82176861905cf1..9c2a415976cbf7a0b56cd4b2fbdd36c9e1ef3c8c 100755 --- a/tools/testing/selftests/net/mptcp/simult_flows.sh +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh @@ -204,12 +204,8 @@ do_transfer() fi mptcp_lib_pr_fail "client exit code $retc, server $rets" - echo -e "\nnetns ${ns3} socket stat for $port:" 1>&2 - ip netns exec ${ns3} ss -Menita 1>&2 -o "sport = :$port" - cat /tmp/${ns3}.out - echo -e "\nnetns ${ns1} socket stat for $port:" 1>&2 - ip netns exec ${ns1} ss -Menita 1>&2 -o "dport = :$port" - cat /tmp/${ns1}.out + mptcp_lib_pr_err_stats "${ns3}" "${ns1}" "${port}" \ + "/tmp/${ns3}.out" "/tmp/${ns1}.out" ls -l $sin $cout ls -l $cin $sout From patchwork Wed Jan 8 18:40:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 13931488 X-Patchwork-Delegate: matthieu.baerts@tessares.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CCEE20127D for ; Wed, 8 Jan 2025 18:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361653; cv=none; b=QSlIlWKTHEqUEH/L1To6+WEVDGNYOXMw7MSohF1Iz6eC91VL841fFeKf5uD7OJ8mOYlaMMRbskEcC+I1muYG4UkpNqVsF6k7tWafplWlLR5f8/F9ndoukH6iYKVs7obKqAo8zGAmWoceyyaXDjg511Ic4gklax79t88tBF8bhow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361653; c=relaxed/simple; bh=jZkqChmu9ePLM1fa7rNUJvFCnQbqLD0cF/N/c0hN6/s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NCVVk10OpV8AtDxbH2ci4Np/JFwPe+t+f6/gagYF1dIeLpbfyI/j8kXLgZc0mHxCrHn1eBWz2bEXR4BJM82D63r8qMOdF/QS5ocTXFGYRPVPfUYjeNq34YsZgO0xXD9W0ddfjsza3HpAar7TD9IMzW25mKvzo8OG9Zosr6Qya+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kEI1HyIb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kEI1HyIb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7016C4CEE2; Wed, 8 Jan 2025 18:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736361652; bh=jZkqChmu9ePLM1fa7rNUJvFCnQbqLD0cF/N/c0hN6/s=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kEI1HyIbgdeK5HIjVKQomaAT8uJaS0m/QdHNp/jbywd0odIkWdwrTFMEiX346s71X sgcW42/2vRKufhmv47V+WEwB2f5s6PVhULvwzd7clog7yvmscJCqC+1tF+9uGOhNFC GEWSFe7QxSlDI4Msw2B5g6akoSudkpdMJLUN/4q86xsrlmOrJCTrUTkGZR4jtM1vNR b0I3vN6wdnd3FQfIJImxBgARenvTsYjNdeIfcFoOHt6oVnS8decH9JcIgBRbeEt1t4 fotTuJ066om0tS7sTeUWT+v23QVCjqLxJmBIrM6ZPdubivID5yVXGll8J9l2qVJVj8 Y+nkxTBSdTm0g== From: "Matthieu Baerts (NGI0)" Date: Wed, 08 Jan 2025 19:40:39 +0100 Subject: [PATCH mptcp-next 3/5] selftests: mptcp: add -m with ss in case of errors Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250108-slft-mptcp-conn-misc-impr-v1-3-bdfbdba48a1f@kernel.org> References: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> In-Reply-To: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1316; i=matttbe@kernel.org; h=from:subject:message-id; bh=jZkqChmu9ePLM1fa7rNUJvFCnQbqLD0cF/N/c0hN6/s=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBnfsaweR3g8RC6yESsjGYd9MmyN8MkDl7XjaSTo T5Y16xwgnaJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZ37GsAAKCRD2t4JPQmmg c7RdEACTnixNS6o+nkckkVdYoknrTPV0DjWrE4AmhGMCTKMklJKTiFLV7YiRtDu5VAazbBAEEPb EG5/3/nSwGJm6hT/BBDMTwSRA0kwYdkZAgyF4t9Jb/kBuZ/DWzr+qZD666+na5W2L86ueVjpHM6 /lhDdDZ1XljGGleMILONP3LSEpbKLaluwy9G+Y96MBuYNBZCWKOeHAAR5e77RplPBBzJkl7izOb KaH6EmFFgfZLqpXzqRD/ZeCghU7oqTVAqx+H4nQSV8PiN9XTgzl3+0gjyHtwmo4HoE8OfGee/Fd 2xR2czj8rC5YuEXPCEnaqhY5PtLUA9h7TOJWPROoKGn9zAsa8pvAjTftRJxeHJNsgh/uCCY4KEb 6r3scqacwu2GR4balFp9D4XGeoHZFZs2tNstbpWA/+5ZLHHPUF7++aLBKgSgRGqIOAMwk914jyx I+1x8MVWKrRwDy7t4I5di9FC0eZMkmHuSn9Xv5FdLQ6cqSUtEmhNGuzfomVp48MLA9x/R+UJQo/ kUP7PVzacAAo1YEOP0zGCUjBnV0VHZ7uEigbA0yWXMSxBy2fVt/Nr4wDutlyDFATcZrFnkg6uW2 BeLQRYlvSOcKvW/KMPu6yAWR/QH3SCOxTrtgR7mW353vjlMAj0pgMZffbS8mYmygNAI09qwTWCl nsiQ5E9XA2/W3Cw== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Recently, we had an issue where getting info about the memory would have helped better understanding what went wrong. Let add it just in case for later. Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/mptcp_lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh index 50ca64357053b14cd4989e6647d825337978fdba..1f797d5f5156ebc99e5e0be5ea27483bc9cb4c65 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh @@ -118,11 +118,11 @@ mptcp_lib_pr_err_stats() { echo -en "${MPTCP_LIB_COLOR_RED}" { printf "\nnetns %s (listener) socket stat for %d:\n" "${lns}" "${port}" - ip netns exec "${lns}" ss -Menita -o "sport = :${port}" + ip netns exec "${lns}" ss -Menitam -o "sport = :${port}" [ -s "${lstat}" ] && cat "${lstat}" printf "\nnetns %s (connector) socket stat for %d:\n" "${cns}" "${port}" - ip netns exec "${cns}" ss -Menita -o "dport = :${port}" + ip netns exec "${cns}" ss -Menitam -o "dport = :${port}" [ "${lstat}" != "${cstat}" ] && [ -s "${cstat}" ] && cat "${cstat}" } 1>&2 echo -en "${MPTCP_LIB_COLOR_RESET}" From patchwork Wed Jan 8 18:40:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 13931489 X-Patchwork-Delegate: matthieu.baerts@tessares.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A18C420126A for ; Wed, 8 Jan 2025 18:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361653; cv=none; b=utY49w4h7HURp7Ll63+rn+3F4D+ylsKQc3miuSI9e3t7R3RnZ4dhig/SQpwZwJTny+AKrvxa61PByaZjXcIHDa2QwwacUqdTPpiavMAZtnjh+6vy1uqPQy+Mckq+OrmPOdEIpK/az3abQ9S+f4L18wx/kdkfJ9Wa8oH+ZjBZt2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361653; c=relaxed/simple; bh=mTW6JkSxVzk1rEcOBRZptH409j4KIfEelzbeUwH2AJM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hRCCbnG6qpwNXizmteQVvshSaJPKMBgkAbcYITLhLNlwfKmb4Duy1IkwffcmiBybq0/o0BLcJtuH8aVoQNDoumBiaD3AS2zpRwn5gYbKYeJIoxhrxnaLG2Z/hvMwul5tq9YrNmsChJksFWezLkGPurMdoRc7NOShTY1kHpJqgRU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mREegjDC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mREegjDC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4FABC4CEDF; Wed, 8 Jan 2025 18:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736361653; bh=mTW6JkSxVzk1rEcOBRZptH409j4KIfEelzbeUwH2AJM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=mREegjDCtwmbKVOw0byhd5eFcniEAzarGx0AOVDs0Snqs5JswVorXeQuyZAJpCeK8 3PNB3LmBPx+emYtc8VDSfEjAlEZFsEOBtHpiT0IiSjzWx8i5j6C/TtoWc9DdMdDTTS nEtR8+xDircEyIV+C2UBOPvSsptqU89pE8Z6KIMw6uNXmTB5uVAaqWQw/ZfSV+HjJn OsQERqR+aPSaokEcT+41XRp08HosoSPbahTucIv7EwZjOl+XpRzMKxwxtLJd2PiUd+ ux3YRZa0CvRh1xuFFl/5sNwFIChibzKwKbp4mzQ2J1tcMj8IHfvVdB7mmbyEaEG+zZ 3ZWIPMeSCDClA== From: "Matthieu Baerts (NGI0)" Date: Wed, 08 Jan 2025 19:40:40 +0100 Subject: [PATCH mptcp-next 4/5] selftests: mptcp: connect: remove unused variable Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250108-slft-mptcp-conn-misc-impr-v1-4-bdfbdba48a1f@kernel.org> References: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> In-Reply-To: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1054; i=matttbe@kernel.org; h=from:subject:message-id; bh=mTW6JkSxVzk1rEcOBRZptH409j4KIfEelzbeUwH2AJM=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBnfsawMB0uE7axkKH9gLBTyY/49uu9I5IQ/xyr9 skKCP6t5ZmJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZ37GsAAKCRD2t4JPQmmg c/RCEADR/dt+oxI3sUKmyDJp/7DpzpIDPWRCTlPylE2muWjF8ga+wNOyZ2tzyXSWlcRI9Yjw5Dk Hnou4A+jgHnyDXmwsGL50oACu8+daIOEGQJlcrbIoVrsjzyAfgkcffs2g8COmy/EBvfDTpWJtX7 MNK6zxid+ecXcnNqrS7BIPJBNwe5xiPnjd0YDZiuiFBUuI8/V4soX9oc8+1JeWlMDDkGCFeH8ba ODkdTJ5Qek0TnzDjXH6CSkhcKZk1BDdomnx/kld1JBSxSF5bP9Vqz+f0SW6DdUs2bLw+oLD4pFN hmhxcYjAD1GezVGOd3/EKqNN5FBLFizfZGHQt4uahZg+D6/X7NihtRGHGGK6mBxJTWbUXIIKmTk oAPCt4M07PVgfL3MZVJELjNLE+ePoIU0iQEqGDYr3ThboxpUh3L2MRqMtOso7WmJEbbKgwztJ3v XYREGKS9Grh27eMDkukZkGEB8NUg24oa+jSZ4l2lwn4Qg0dEMBit+oPL2WLSTSguebZWzvkRLed /08UYLzl5kXxoJHoJpCIzdppqpQEiru9dgXZ/hN/QAeTQNV40OXOjFnh6tB3ZZWYQ/X0ZJZQ7dQ C9/0H3fuU2WQWfkC1MEwiPko0njfDm67P1ctyUi9mzm/z5xFPsHIODAHRCSqunS8y3iPkMhHvvF tXuaUiNzPt8q8gQ== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 'cin_disconnect' is used in run_tests_disconnect(), but not 'cout_disconnect', so it is safe to drop it. Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh index bfdaecd0a6a0564020530345daf91bed296bc15c..e508d356fcdaebbfb95750bba0fa834a8463e32a 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -137,7 +137,7 @@ TEST_GROUP="" #shellcheck disable=SC2317 cleanup() { - rm -f "$cin_disconnect" "$cout_disconnect" + rm -f "$cin_disconnect" rm -f "$cin" "$cout" rm -f "$sin" "$sout" rm -f "$capout" @@ -155,7 +155,6 @@ cin=$(mktemp) cout=$(mktemp) capout=$(mktemp) cin_disconnect="$cin".disconnect -cout_disconnect="$cout".disconnect trap cleanup EXIT mptcp_lib_ns_init ns1 ns2 ns3 ns4 From patchwork Wed Jan 8 18:40:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 13931490 X-Patchwork-Delegate: matthieu.baerts@tessares.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5EB92010F6 for ; Wed, 8 Jan 2025 18:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361654; cv=none; b=j9CPNZDKw6+zqNL62ZPznWASHwi5nGRjIaDtqZUW5soGPGWPrCb8wV5gby+ak3Jw7D6NMLKqhDjJ4rWYRAqryvNxwAr1XSewGfmwNr9zG4T8dPWtWYuGnDe4Co739ozRDYChvjlacXUxk3fORyi5nL7q7QQOgPEoHUXZaRPhl6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736361654; c=relaxed/simple; bh=ycmGt5JyUQGequhaveVetlbpGu3PFxdExfZ+jTLwQ0c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J2TH6Wo9VwHjq/G3MT8o7Ktsq92XgDtI3bdS1oyEAiVJMNLOyGOA8n6/ci8JCpigsCx9mlHzkAqnLA39hxK5I44TZ+nyqyVJQhISYjn4otqb8tNrhJUSSoUf+u4ODeMxVtBrjfQsMNhJsG0DwiLzG759OetUgquk8kcxQ53JXjw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EvkO2nkI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EvkO2nkI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E19C7C4CED3; Wed, 8 Jan 2025 18:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736361654; bh=ycmGt5JyUQGequhaveVetlbpGu3PFxdExfZ+jTLwQ0c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EvkO2nkISIJFg0RX+2FJLOmSKQx0VYGNCVictagie3oxfrS2b3eWLaS+vgVr7I1Bg s8E+52cUohWTYAdwBtZr02wXgnIk2AlhiGUiphWPDbcwQWsXFNjxOCTppLYmCiFeWA akYKA1VfbOSnkT3mTQ5yVPCOBUXZhZ5mzioFBzJ2ifulayBE48OA7NM4aqTPkLnTd1 bsuMpgowiK6ITUsB014hwrCerra7tSbIq5Zt3YmjxzmzwC5bEJwWdF23UJSNPpYb0T GoStnDuZ/AI31C0qoI34fO2ny0Ej8271rB4WXCbZEMMDK+yndaJGXCJEm4cLyQNhCt TYJjyTMKRc/VQ== From: "Matthieu Baerts (NGI0)" Date: Wed, 08 Jan 2025 19:40:41 +0100 Subject: [PATCH mptcp-next 5/5] selftests: mptcp: connect: better display the files size Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250108-slft-mptcp-conn-misc-impr-v1-5-bdfbdba48a1f@kernel.org> References: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> In-Reply-To: <20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1403; i=matttbe@kernel.org; h=from:subject:message-id; bh=ycmGt5JyUQGequhaveVetlbpGu3PFxdExfZ+jTLwQ0c=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBnfsaw89FuMejbgD/qgEK7MIkAydae+wGWEj1fv vc4abx/v/KJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZ37GsAAKCRD2t4JPQmmg c4WJD/4n87TMlm5weBfTO4heQV23KdJ2cssL3rWiJjZFWjRJaCy3uvgvBYNbZlOlvEPPF/21sf4 eGLtf6rQMwnYDun9NMuK7uJi3ULvNyF/D2nbijsNHgzJ970Fb/Ck22qND4RA8GzFVRXqKR/Dilh it6rccnx4uHiWxwr3AiR3tLfh1mN5Do+PoF8bl5nwq77ZPwrfVPyZr7Dmni7kBTq56GUBrKpD+H HmC5YKIF+xVE1AMjypo0L4SM318/m2X4p6uX6DTENxy4AWbaMd/OVqmEB+Sykn3AswIzG6i2EXO S8OVSt9XkD1LvN+Uyekh1xzOHljMA8trKJf5UsrnkvHxo7TpfpiuLvgjcYR6nZ9KWGBVLlr3TEn 46OOaZ0bd8/+zv/ehvfyOnG0vApKxyrkqiT6nWbzJkOwDziuG2g5o31IjtBUTArw9loE41aRVxI 9bxwcz22gjxEyNCWpkdH4ODV6+H2rfb8RKrRkZiMiZYqJT09VkM/61sQ/VeTlAnh1tiYj8HMcre LwFjGo196R4TjysATwmpIC/MO4nVFZUlCgpyXay/7d5I68Gshw49TqOdpRYzCCj4sTVqA0NbCLc /ZmfXad2nByAFl7B3qDBc/6Byd5szle6GGau5bTgmIJ6rbrTEW/h1x0sTeOcJIRvoZTeCLF/55t mIlrjypT4WTh7UA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 'du' will print the name of the file, which was already displayed before, e.g. Created /tmp/tmp.UOyy0ghfmQ (size 4703740/tmp/tmp.UOyy0ghfmQ) containing data sent by client Created /tmp/tmp.xq3zvFinGo (size 1391724/tmp/tmp.xq3zvFinGo) containing data sent by server 'stat' can be used instead, to display this instead: Created /tmp/tmp.UOyy0ghfmQ (size 4703740 B) containing data sent by client Created /tmp/tmp.xq3zvFinGo (size 1391724 B) containing data sent by server So easier to spot the file sizes. Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh index e508d356fcdaebbfb95750bba0fa834a8463e32a..5e3c56253274a1f938d2ed9986c4290fcea8b96b 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -582,7 +582,7 @@ make_file() mptcp_lib_make_file $name 1024 $ksize dd if=/dev/urandom conv=notrunc of="$name" oflag=append bs=1 count=$rem 2> /dev/null - echo "Created $name (size $(du -b "$name")) containing data sent by $who" + echo "Created $name (size $(stat -c "%s" "$name") B) containing data sent by $who" } run_tests_lo()