From patchwork Mon Jan 13 11:52:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937225 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89BC1CAA9D for ; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=YqIO6hZtq0x1PDcryCW0y2i+GK+1tS65DAQIoP8BqZpChAKrYQBY6beTufN5d7a8BOxx06SOA1rsLtOUbEbqLxiXKlCQa89LBHpSIYwX9QCe0XeGjWa+4CbNKwm97xTPSTZul+9EbpU7lpHHYP+Pi13MblkKadt6e2jtE82V1Yc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IMfYzBbIkbMsCkR6Rl2Qe2i/GQrPtRo0PqYbhTEdckD24nDPC/ihlLQNMiybX+OwhoEPLPotOcYnE8unQxMz/70gGp71gmHqHbmScrq1Om8KFKlKK4PO3fBQ3rCr7SmyKRJStQBjXryThPp2fp4/rtjxl04G1wuT2/aQRw3d+k4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rt8LRt4p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rt8LRt4p" Received: by smtp.kernel.org (Postfix) with ESMTPS id 83F4CC4CEE2; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Rt8LRt4pVcbiUCow8AAbz3t+2DPi33KupPqhlXh5WTvs+nleBSMtT9o8gvSfccNLH PhLWhkE3wNU34sxb5l653yyM5mR8zWLdTXk8Az22gbqOq9SNyx8IHgS8OPtdVXTCKJ M4a4z9hiqmBERoP/VVBn4lCMcohQJUmLpDLkRfG+OXbYV7qAStMqSRAVyjMxi4tNdZ ZjjXjdJY1SVst+gzX/ndPu5Or7VC+3IJZuXowSR5MxaKRbrQAkD8qVdzMZdBx2iqs3 HVPhkIjVJ95HixWsenDVuVXBWgqliolIOmceGnU8B6n2GWPcZ0ynnVhS60QEAEhffF e2F6EwJMYORrg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AEB5C02180; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:52:59 +0100 Subject: [PATCH RESEND 01/12] Kconfig: Add error path in conf_value_to_yaml Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-1-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=1224; i=joel.granados@kernel.org; h=from:subject:message-id; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qLccEOdp+Z9kH3Kj7HRdarmGvBKO+beK zqz4GVYI29D+IkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6iAAoJELqXzVK3 lkFPGaIL/RJEVIvcivcFaEOzQc9S4M1OxImLWFEDCAt1L7Y/htMmnTYrZQZe9RDOCbecOKpTRS3 4u2ELGIdMxWOrSoRY0Gm2QiMdziOpsGG2pkk8idx3/7CvnDERA62wpARPUpyxSsBL9Z/+kj9kC5 xL4qepsGc0PjDZjViWPEW3v7gc1kTKUwnlZeIpMhrW3+zJvqNrBAKR0LnvJ3JaRb4DTfXzSzi0H /hCOb0ebMD6JNkqNu4A96M+zuTv+hk0rvnnXwOpJ9oOyb5t0ZgFKN7JfHvv73r9RLOaiRgQQYxu 48aZtvJfKwTJ8uMVWKwzGoOEp5LP8SvQdCJQ83p4KaacaRrQYtuXhz57SOrTyWutyS6EUK0XSfQ hIvGzW4Ujo7dhYTfq4srYdj6kAiRoNbxMvRjSQkwvskdCB/Rweu1WFdUPvaL6u4qex4gzj4nZr0 G9wRZizU69l8338RGrAydZydtb1X9extqD0uG5WCT3e6dBFEzDagqZfFT7rOfkYUsA7LMOQQeA7 4k= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 The asprintf call returns -1 on error. In this case the value of yaml_value is undefined. Return NULL, so the caller can handle the error. Signed-off-by: Joel Granados Reviewed-by: Luis Chamberlain --- scripts/kconfig/confdata.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 0156b38..49a5729 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -669,14 +669,14 @@ static char *conf_value_to_yaml(struct symbol *sym, const char *val) yaml_value = strdup(val); break; case S_HEX: - asprintf(&yaml_value, "0x%s", val); - break; - case S_STRING: - /* Wrap strings in quotes */ - asprintf(&yaml_value, "\"%s\"", val); - break; - case S_BOOLEAN: - case S_TRISTATE: + if (asprintf(&yaml_value, "0x%s", val) < 0) + return NULL; + case S_STRING: + /* Wrap strings in quotes */ + if (asprintf(&yaml_value, "\"%s\"", val) < 0) + return NULL; + case S_BOOLEAN: + case S_TRISTATE: if (strcmp(val, "y") == 0) yaml_value = strdup("True"); else if (strcmp(val, "n") == 0) From patchwork Mon Jan 13 11:53:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937222 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B89DA1C2DB4 for ; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769195; cv=none; b=MuSB4cRG0ocLLGKvs0W3VteMezMxH3M72GUXNHMtcIVVns4UZRV1vzY80Xe0mxULLLQ77JKa8YdrUwerskjI6D6594lp6YLcJMyFztG/hNVDJ6CqlQtwYq1LWffclYZWhWC57h2kpMU1rWq5dV98KC8BXCD5dkhiE4hdtGLUOlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769195; c=relaxed/simple; bh=l6fdWgpjKbFsO8OSF2C8SwibeLtb/ff0owgRzjJFREo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Epai2lKrWZ70ZGHk58Ge8jYImQmKHyWJ9msjqEWxrthtK7+6zPiUMG0hGynv0yoj+mrOBiCqV9Brt9w3kLfwzmR53Cjn9qD3j3HfgTstICFjvMzxhiOvh+SVhGmSS8sdWKH9vVJ2Z6fzy1cuTF+neLvxTFMRh1gbyhdsUOjW5tw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SUpQKn/w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SUpQKn/w" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8E985C4CEE3; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=l6fdWgpjKbFsO8OSF2C8SwibeLtb/ff0owgRzjJFREo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=SUpQKn/wdGFdnUtQIQpf2szI8mNvS+HJh5R5lupVoL8D1eOXbDNO9EH/XlSldZf0K 356XLIJkDRjgIIofLp9U1lowulxs4fM2RdVd5coqgZjs1FSXzaPcTfCVONy1b9i+oG wBLGTM0oUqwVLrLcP6chm1wHULo9cPWhC25/awNX8M0aYIvUA17bxa2VEkGrMxfN3Y uew4elvBvc3B6Esnkf2/I3SeshOdxXvZoJebfxAMp9udBhMbpf4LU0/05O2QH1I+GJ pNyXqWELNamWhCSyGLSiSEqNKVy7I0Zzj6kBpqWGanPCPoiG4/za6AF6S8Veo4NqPp fHLWceF8SCz2A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78DB4C02184; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:00 +0100 Subject: [PATCH RESEND 02/12] scripts: Adjust heuristic to see if current user can sudo Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-2-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=2158; i=joel.granados@kernel.org; h=from:subject:message-id; bh=l6fdWgpjKbFsO8OSF2C8SwibeLtb/ff0owgRzjJFREo=; b=kA0DAAoBupfNUreWQU8ByyZiAGeE/qKhqs3WN4N4sdaFXPB9a6rZ1Vdh2hYcDaYSFePad3Onn YkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6iAAoJELqXzVK3lkFPEEkL/1F7 Yk9iCgc3wHGfmEWQHA8nOMz6aC3m5BPgfvCKRQP9xSjPDvyYjSpMaYCHn+fe4Ml6CAvevRdybhO uh3bn7ELojnMOBjrCYiXwiJoCwrGmXb1dIj6EvAuYDy2g352bqr2B6JJLU/gGs2a6pQrp4R+GjD n1ibbcXmZqRNUtZm0o3kqBE+xMQK1AAesM/DrsaukSOVM8pfkm3Dz/bOPCNacptNZ0kIg/miFuE AukJ2+zVcKrCPTArHAtDFpnGnQ0WlTtF1GyCQQiFDDNiPgtg24DLMkhjy4V/4F8kHk/C67ZlyN7 UKgZ6GZjN/J3GLjofC/Y75fgQi04wYnYP/r5ZQTy6UJ5Y3DcvlyayxRB0iN8iV2fVHBMof04X6r izUXuWMm8Decj27mWqz8nx/c1NP7HBCXCu00eFJjz/lx6FK2Io5n0IKvEdqZNkR48exM96A7Cic 1aHwmvQalnqNlTtwE1SEKoVptdTBz0WBJhGJpf5wSU/v4gglIk8l0pwLfJuA== X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 * New heuristic uses the following sudo command options: -n : "non-interactive"; will prevent sudo from prompting the user for any kind of input. -v : Update the user's cache credentials; has distinct output for users with and without sudo: 1. Without sudo the output is "Sorry, user __USER__ may not run sudo..." 2. With sudo it has two messages (with and without password). But we ignore the distinction as both of these mean that user can sudo. * Avoid setting SUDO_ASKPASS. This env variable is suppose to have the executable that will be executed when asking for sudo instead of a boolean. Signed-off-by: Joel Granados Reviewed-by: Daniel Gomez --- scripts/libvirt_pool.sh | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/scripts/libvirt_pool.sh b/scripts/libvirt_pool.sh index f8c309e..ffae928 100644 --- a/scripts/libvirt_pool.sh +++ b/scripts/libvirt_pool.sh @@ -1,6 +1,26 @@ #!/bin/bash # Helpers to work with virsh pools +get_can_sudo() +{ + # Heuristic to see if the current user can sudo + # -n : This is the non-interactive argument in sudo and will prevent + # sudo from prompting the user for any kind of input. + # -v : This tries to update the users cache credentials but also has + # distinct output for users with and without sudo: + # 1. Without sudo the output is + # "Sorry, user __USER__ may not run sudo..." + # 2. With sudo it has two messages: one for paswordless sudo and + # one passwordfull sudo. But we ignore the distinction as both + # of these mean that can_sudo is "y". + if [[ $(sudo -nv 2>&1 | grep 'may not' > /dev/null) -eq 0 ]]; then + echo "n" + exit + fi + echo "y" + exit +} + get_pool_vars() { if [[ -f $OS_FILE ]]; then @@ -10,10 +30,7 @@ get_pool_vars() fi fi - SUDO_ASKPASS=/bin/false sudo -A whoami > /dev/null 2>&1 - if [[ $? -eq 0 ]]; then - CAN_SUDO="y" - fi + CAN_SUDO=get_can_sudo if [[ "$USES_QEMU_USER_SESSION" != "y" ]]; then REQ_SUDO="sudo" From patchwork Mon Jan 13 11:53:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937223 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C02371CAA99 for ; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769195; cv=none; b=gHvBwBZ2hcjMQQ6Ldm6P8aNExc9cfA/8/oTq/ha7AciwcfXgjRalLPaZ4QPHJQhSvb7xXygniE336f26b6ywVBakuWxtb7grgvBCnSZOEcG1dPxYGfc8qI5yj763qwd+LSZFLAnVfe4jYRRi19R64V6XGVMBSiVvRf0jiq4/RA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769195; c=relaxed/simple; bh=XsFfSuOHOo7PdvXANRbQAmVGYrxSHmsJL8YTfwlMjVs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MeEa2NQqHK27lYnbSseWDpf9aNy606uMJB5RJZUXt4QIt9W/+TgDhwdAaajaGXXXZ1ubhSi3/jppkn/UhiTEoteZMWldRArscFjxrFU1btdLjqYlkM+43kH5vDiM9BzxBaVKOhaSria7i3H277CAwcxlPlAuhzZX7f01Dbb8t5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nvRleSYP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nvRleSYP" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9CE6AC4CEE8; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=XsFfSuOHOo7PdvXANRbQAmVGYrxSHmsJL8YTfwlMjVs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=nvRleSYPLBJZbRbNb43z7Fqu7/kT2ck49zo8TXoVYdmPv/EE08UKJgjBgeZnYyQYY Y2UtSQshGiguQFIQAEnah/BjwW9x2FNXWjBre7TL+DnRKxjgXK+bVVFSPrIYKfFn4h tvXOU7KY1MXHI+SP1+flJVqZ3hgO5HYU8l1eCFHOoAFV8bXmtg/k4T7c7M0O9JbrMA tH/bVwbruQcbhwi/KEJqwQ/ZtclmnVyZf1SuBRP447Mx5fGHu+aa57qRijXN70d5iP wKmGkEctG/X2Jc/df+c01TSiMHcTXZYy4YS+Ktr0nn/UT03yLX9n+zdtTzqfXjSSXa 4LwxZ4SJqCe5w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B44FC02185; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:01 +0100 Subject: [PATCH RESEND 03/12] ansible: libvirt_user: Install additional pkgs for debian Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-3-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=1055; i=joel.granados@kernel.org; h=from:subject:message-id; bh=XsFfSuOHOo7PdvXANRbQAmVGYrxSHmsJL8YTfwlMjVs=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qMfOY/45CzTw2XtBV8IN10ADkLpsyKsG +hM0SNMMhBXmokBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6jAAoJELqXzVK3 lkFPtq4L/iD3WV9gCbdbOUXcOCMM/ILjBZ2XG7fPsKH7JqwfqnJdh0Wf6a9QoHA9oMCnCJYu2YE 9OZFqdJdmotCLm/b5gSgiaq7PEFEF1gKvB9tof40JhhxV4spWvftZ07OYJ2FW0il5GpXm9maimN izn+yIWxuykVsFFZrBHdpPWisuiuAEBX7bacgeKKvHK2eJcujykUWe/eNUZqzWjV55VQasYVtUO h/PBv5evTyIA3zebxzTIo85bGKeA4aofinegbaqpQvwxDK0Q6F5Ylh1EkyYMwZUFyFy5MTfRXXc C9eyUDjeqZVzLjidPvLc3M35gzm+1/eakGAq0A7UgdSTJzrrEx0QfIzmhWLLb7WpLXeFubKqQtU ijdT86gjy1U+gdVwMtId4vWbHf9NrdkoPIirD2O/k4dIssLTga2/HS4K6FEQfPzs8uIF9dMIP9f i3i2ZrLuz2t0QdmRmM9Y+IEZ4mBD3LWIRlry9JM0khYQP0ZuKo7qTbrN1twS++5zkROJz2TgQP6 hY= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Install the following additional packages for debian * libvirt-daemon-config-network: So we have networks/defaults.xml on the system and are sure we are able to generate the virtual network if needed. * guestfs-tools: For when we use guestfs directory. Signed-off-by: Joel Granados --- playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml index 792597f..98d0007 100644 --- a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml +++ b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml @@ -13,10 +13,12 @@ name: - libvirt-daemon - libvirt-daemon-system + - libvirt-daemon-config-network - libvirt-clients - qemu-kvm - qemu-system-x86 - qemu-utils + - guestfs-tools state: present tags: install From patchwork Mon Jan 13 11:53:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937227 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F4C1A8F98 for ; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=Ec9/p7+JvECQIpGPlfPHIZPjFLJgEHX/fvyUxYIMfTQdG9d7bNfsoHzP+gHbXI99zV4xM/Ker9WNGxZjeHatO90aBwif1WYXI1SfAW7+GXkOyjAQpzbQdTgzSHMSAk2jSTScax/JByXmugE53ifqwZcju+Vg5II5sV2DfF9SM7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=Kt0zBkpB+Wq/cF1K12NdeZvH0eWmgaNhm+yWtxTqcHo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BHkuPnU8ndQN/YpBGViD5X+c7wQxIWEY5FO6+N1tKyBQwIgCDetHaWgPwniMQ/SOD7l94LMy7Irku/U/RdcwZaluziY8ThTKGsNhS4NYnX2ZQTcaytyVldf+AsQP8rRAIetYv4eXv5LQq+DnHeRhH3V0rwjn1dyLv1HqP0So7ss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hz62ig86; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hz62ig86" Received: by smtp.kernel.org (Postfix) with ESMTPS id A73CDC4AF0B; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=Kt0zBkpB+Wq/cF1K12NdeZvH0eWmgaNhm+yWtxTqcHo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hz62ig86boPg17FIckvLMWFxsXdTS4QbG7DWxBrhVuU7LG/jel6FILGVNcC+uzh8L vpPqMHjI8B+NYL7iAgUJ6YYWxO7wZnWg7BCWCURcnXqDLCprMHRzIpvOwbOt/AHgLC 88ZDvyu3DoBoqSYLdfLJdNd2t7gBGJOKLuW+UA1zMOsTiu4QWtRD5U2do+95mwNxCF c6RzTKeqwDoDajSGW6RrSFpJe1pgMgFLQ5OWvqWDkCYMGKwH1WMQ0wBSQVyJGcL2L4 IdqzuIF6Bvs2SdYM4PKyj+LKTX3TVJWCroXfc1uPdeEnnrWdTV0MfNKQPUXsCFwcOu GwYIn8kpykljQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A242C02180; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:02 +0100 Subject: [PATCH RESEND 04/12] Makefile: Add virsh and libvirtd to minimum dependencies Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-4-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=559; i=joel.granados@kernel.org; h=from:subject:message-id; bh=Kt0zBkpB+Wq/cF1K12NdeZvH0eWmgaNhm+yWtxTqcHo=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qQVaCgbzQ9ZJmQaOpa4hqjUUU4ZnZzZn 9IaSEx+6YzNB4kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6kAAoJELqXzVK3 lkFPeiEL/i+U/tdSF/p5fEuuko43+zECQyKSwGnA8IyR73DBr1lvWd5/n22Z7SGmbm1W6XrCfrl 9HzO1m3LTD0mUSf/AmkrTZ0XLcY4tERNEj6HFFJnHgx0DGJnQTujlYUuAFwB8LdGslKH1EBTWFF k+/ziP5rNm+zI0//vDfFfJrATsM1zPo4ebu6KIsSjQ0HphSqSqIsydo+E5o2H4B7mFDAw+ou+Vf sRVDzbeJ37uwYTmAhte5gsWCIFQNoqnp6RB4Oi7EgWkVtUnwOkmSrGMZcZXOmEyrYMpf0gGLBY7 TcRhZ6x6zNw2KfWRt4vvjwAeQv3+BhfDVD2HWyqaKXnUYLUpKN7Oq9kU3WXOd5/dXHdUq7fmEIe U6Rn1tt25jUoSErYvGBvUjlPqQ+eTVKKVMbFXboL18y52jvC+YQsX5kBmc93Bg9myvLe0enCWxD gu552smrBKnGVcGa/2vpy5RjL/ZZIRYUzyOC7+nUVH96F/7xzRl7OZVa2JQ80rc8hQw5eVxJkV7 aU= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Running scripts like bring up depend on 'virsh' being available. Signed-off-by: Joel Granados --- Makefile.min_deps | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.min_deps b/Makefile.min_deps index a1cb99a..d1251b4 100644 --- a/Makefile.min_deps +++ b/Makefile.min_deps @@ -13,6 +13,8 @@ BINARY_DEPS += ansible-playbook ifneq (y,$(CONFIG_KDEVOPS_FIRST_RUN)) ifeq (y,$(CONFIG_GUESTFS)) BINARY_DEPS += virt-builder +BINARY_DEPS += virsh +BINARY_DEPS += libvirtd endif endif From patchwork Mon Jan 13 11:53:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937224 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E387E1CAA9B for ; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=tjU659qpW+ryR5K3VvmgL8fmPhnOQ1E39XyUQdFsfKGC3EkCkY46qhHjDj2DFAGmFHERajCQbaikhYxvi7w0GqVtV/UxGptEx4wVTA09/c+OMRqD91ZMWIlOoUKgw9/gjhDyYfFe6fagEIdYa8wJbh1M9dc2bjPg5mCqGymkwTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=Kj8tG89mwj8PU4V97afgamZ3sTf5UN0mvrsoVFXiIVg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZYSEffI4qEwqL9HaTCpLPp1lN9eHOiQgXIWkvyx0S/T0PjaL4nXCMlQIwziWwkkJk46Y135o71oQ+bNKqYBf3JMtCBX6Fh+EGtLrCgYx5k0bqqQNMXHvSv5X3DGMGWm3Sql+l3yhNoA6ttJxUFbQwyS2fjghYS1hV3nWtfHjteY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u7jM6x9a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u7jM6x9a" Received: by smtp.kernel.org (Postfix) with ESMTPS id B47E5C4CEE7; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=Kj8tG89mwj8PU4V97afgamZ3sTf5UN0mvrsoVFXiIVg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=u7jM6x9awc6Nf7CKSRNgBbA+yXV2afu+Ko2m8hGeK0bi0wHvdekvnFOv3aNTHJjGj QgUyc3+o0eSKcQotHsdavGYVI7pEnLGl0Y9TTZNh4LYyBMrGSwoPPNqkjgxtSdGJcr rr+Dbu3lhiQ7hYT6hhxRjR01FegRzHq8Nlu35kPkLyX9+6xFw0fJS2ebw9J6t9fofV Hk5HmQd9+Uu4RsrcAC4hsyo5e92oyRire8El3xwG/rvu1Lk+maF6fXc2GUeICwYSIz 4zOin+q4FRbNAy6bSQn/89UWyk9Ao/z9EMEPvuZeMQPRa7YyQiIP0PBk8iV/LXsz7l VpXpH+NI1v7AQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83BFE7719F; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:03 +0100 Subject: [PATCH RESEND 05/12] ansible: Add build-deps tag Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-5-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=4391; i=joel.granados@kernel.org; h=from:subject:message-id; bh=Kj8tG89mwj8PU4V97afgamZ3sTf5UN0mvrsoVFXiIVg=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qTXNiUlGhdzLy5vPbCMHEDNSguT3LtWO GyobgsF2spZEYkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6kAAoJELqXzVK3 lkFPZIEL/1rWjKeAiyg6DTVOur54N4hHhEs+7inxL28ZA/u3LEFTS3imMEr+XP+G5PEUdOcwTiy CzO/XRsUoCF17qJsj3Jw/I69sOmDAceS9hY0SWIJtTWWolnMb8vxVP3VyoWUaesQ1j79M9hroCt JXL/nYzDpHjtUwmlV+dUd+yO452Wm7P43EZfmXjYnu8YZcOBG38TtfDB+uCQpESVkEbaFmy5exY JshdmhdwzMLD4M8pxo/KyI2FUZcSk86MPvdlKNGYollzIb6URcK0igvCRyAxP6kU/ylu4xqogi3 nZzGT4Y3aRWZoEn2lzMXju52VE/UW8ULaZ7ILbm/itYXcvWeGnWat8BoA/Jh8LHMW57iHlkqefh kGD/vcuk8EAdc2WwPMuR8oqO8oZVTuC3IO6Jiz1yDSSuWJR49evMUGFhXj6oSi6jlmkCjwaE9Qr 80Mv9A6mphU3iwJdhRoE4Yac4J/6kBoMjc2X57pS+Bn1TutxIHSzXCPVbt8v1alI3sT9QMFloV4 Ck= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Add build-deps tag to enable-user and install-deps tasks in libvirt_user role so they can be used from other roles. With no tags, these tasks are skipped. Signed-off-by: Joel Granados --- playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml | 6 +++++- playbooks/roles/libvirt_user/tasks/enable-user/main.yml | 4 ++++ playbooks/roles/libvirt_user/tasks/install-deps/main.yml | 7 +++++++ scripts/guestfs.Makefile | 2 +- 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml index 1ad7f17..5797bd6 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml @@ -9,12 +9,14 @@ when: - not libvirt_session - not only_verify_user|bool + tags: [ 'build-deps' ] - name: Check if apparmor_status exists stat: path: /usr/sbin/apparmor_status register: apparmor_file_stat_result when: 'only_verify_user|bool' + tags: [ 'build-deps' ] - name: Verify if AppArmor is disabled when applicable become: yes @@ -26,6 +28,7 @@ when: - 'only_verify_user|bool' - 'apparmor_file_stat_result.stat.exists' + tags: [ 'build-deps' ] - name: Verifies user's effective group allows to run libvirt/kvm without being root shell: groups | grep {{ item }} @@ -41,9 +44,10 @@ when: - not libvirt_session - not only_verify_user|bool + tags: [ 'build-deps' ] - name: Ensure our user is part of the libvirt/kvm groups - tags: [ 'journal' ] + tags: [ 'journal', 'build-deps' ] become: yes become_flags: 'su - -c' become_method: sudo diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml index 04f8e31..364d625 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml @@ -2,19 +2,23 @@ - name: Debian-specific set up ansible.builtin.include_tasks: install-deps/debian/main.yml when: ansible_os_family == 'Debian' + tags: [ 'build-deps' ] - name: SuSE-specific set up ansible.builtin.include_tasks: install-deps/suse/main.yml when: ansible_os_family == 'Suse' + tags: [ 'build-deps' ] - name: Red Hat-specific set up ansible.builtin.include_tasks: install-deps/redhat/main.yml when: - ansible_os_family == 'RedHat' - ansible_facts['distribution'] != "Fedora" + tags: [ 'build-deps' ] - name: Fedora-specific set up ansible.builtin.include_tasks: install-deps/fedora/main.yml when: - ansible_os_family == 'RedHat' - ansible_facts['distribution'] == "Fedora" + tags: [ 'build-deps' ] diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml index c652ab2..c2f58c8 100644 --- a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml +++ b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml @@ -11,11 +11,18 @@ - name: Distribution specific setup import_tasks: debian/main.yml when: ansible_facts['os_family']|lower == 'debian' + tags: [ 'build-deps' ] + - import_tasks: suse/main.yml when: ansible_facts['os_family']|lower == 'suse' + tags: [ 'build-deps' ] + - import_tasks: redhat/main.yml when: - ansible_facts['os_family']|lower == 'redhat' - ansible_facts['distribution']|lower != "fedora" + tags: [ 'build-deps' ] + - import_tasks: fedora/main.yml when: ansible_facts['distribution']|lower == "fedora" + tags: [ 'build-deps' ] diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile index 52397d5..dbfb372 100644 --- a/scripts/guestfs.Makefile +++ b/scripts/guestfs.Makefile @@ -78,7 +78,7 @@ bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) playbooks/bringup_guestfs.yml \ -e 'ansible_python_interpreter=/usr/bin/python3' \ --extra-vars=@./extra_vars.yaml \ - --tags config-check,network + --tags config-check,network,build-deps $(Q)$(TOPDIR)/scripts/bringup_guestfs.sh $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ --inventory localhost, \ From patchwork Mon Jan 13 11:53:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937229 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BB121CAA9F for ; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=OVfVenURafj8s8hz/e0pf5T5+3EIDvbvaB4OkYm/kXcLKUACxHSzq6mke9PPtsGu9vrD0kUgql6G2BiYnlaUfFqxcOIPNgSy4Ogh4EFIf94hNR13FdhgmuZp75ysnDsw2hAX6V3T3TONoHR3nrSa9dNBXWr7lTTPKdIvEW8LgWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=kK8WYlj3lCiI+bWD9/rTi5l4rFK8spbgf35AT9VzodE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zz0ez369rPPrxmatkynBTQfS79uePxqhPV5aXW4NOTNpD44DI8DECn8r/uYEwyYjaqDCgstjEK464w02YWgWmuM0VuBrS1kYsLThhUbgDr4R085AC8uMYFlFSQQdAS81Ii3y6CnUyRH3thEhrt8M++tq54bd4iEvgJ8Lhy+PkXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qlxPw571; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qlxPw571" Received: by smtp.kernel.org (Postfix) with ESMTPS id C7847C4CEEE; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=kK8WYlj3lCiI+bWD9/rTi5l4rFK8spbgf35AT9VzodE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=qlxPw571DjkIgCJsmtyb3PELxOg8Jz/7LKXqSIn5LHRxZ/6eSfERa97e1rb11ucYM 9/ShozYrWNWp2pmiGlQ8nO7PLaYJ/GJ2zoh78M++0HOUDREqrOo8OGfELDZksFlRtk kTeLTO5kl5TZNNSoKRG82IUNzGVI61fgC5e90TjTPE5iOLqT9hlkV/5j+pbLJELOd6 d1Wv/Q5r3C1L8vi7LsvqfdQLFM0TDwYxpKmB/8YkH66Nm2C4+fxPdyu5/K0Mw2ssHq xnxPY7ulG1Uy2/IhNCrcNCBugOUoGPKqBOkayj4gs2Swv50Nh4UENANmgBMYNIRy3L rX1ke0NIzp9uw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88A7C02183; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:04 +0100 Subject: [PATCH RESEND 06/12] ansible: Use full paths when importing tasks Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-6-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=2953; i=joel.granados@kernel.org; h=from:subject:message-id; bh=kK8WYlj3lCiI+bWD9/rTi5l4rFK8spbgf35AT9VzodE=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qW2akKCceaIlZdov3dN8E5BhqnWe1L/X Jss1o+eRPft94kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6lAAoJELqXzVK3 lkFPgNcL/jv2sT+JYlAjwgBRa1xH4d/OFJTDnhddeGwKOdymIOMPtXzO8/oq0CS5L7Ms7zXh/Gx yWge6T7J3RXv3Jl6VcKaIKontZaEMmj8QRv53IdvN6A/+JndTyTthnHucBKwXqV6OtqiP0zw1WD qVifuLf40Pig9AMjmAmrDiPbpKPfJ1rKStfaHxhU+7eE/uvjtwRbDxurTY5ELVRLBeIhgvR6iwM i2sgEjaWwx9KNevVbIrUsdI3/xpfmSTJ35yOvK/BznXBp3uyZljLLCMa/cz8fB1+cDlW9oE6UKZ zFaDdN1aeEGXwktcUxbRBadob5a5ECA3ClJ8t935eqLHrygnLOglsTw94Nlo700+Id7+0P7c6xA A4IiVpewoBZw1+ZOfgDUXwGbTCv/9veenivemR2M5GP4H8/jIrOsR/XqJMGFHNdy/Oxiff3xZHz icoLMOsFDxc0vsfNv1xUVFm9XfV50HMxhK2PAwo/upvcASN8DNK0OV1z71rJr5jXaRHh5mDNdF8 9Y= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 This allows importing libvirt_user tasks without the hassle of changing relative paths. Signed-off-by: Joel Granados --- playbooks/roles/libvirt_user/tasks/enable-user/main.yml | 8 ++++---- playbooks/roles/libvirt_user/tasks/install-deps/main.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml index 364d625..2c632f2 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml @@ -1,23 +1,23 @@ --- - name: Debian-specific set up - ansible.builtin.include_tasks: install-deps/debian/main.yml + ansible.builtin.include_tasks: "{{ role_path }}/tasks/enable-user/debian/main.yml" when: ansible_os_family == 'Debian' tags: [ 'build-deps' ] - name: SuSE-specific set up - ansible.builtin.include_tasks: install-deps/suse/main.yml + ansible.builtin.include_tasks: "{{ role_path }}/tasks/enable-user/suse/main.yml" when: ansible_os_family == 'Suse' tags: [ 'build-deps' ] - name: Red Hat-specific set up - ansible.builtin.include_tasks: install-deps/redhat/main.yml + ansible.builtin.include_tasks: "{{ role_path }}/tasks/enable-user/redhat/main.yml" when: - ansible_os_family == 'RedHat' - ansible_facts['distribution'] != "Fedora" tags: [ 'build-deps' ] - name: Fedora-specific set up - ansible.builtin.include_tasks: install-deps/fedora/main.yml + ansible.builtin.include_tasks: "{{ role_path }}/tasks/enable-user/fedora/main.yml" when: - ansible_os_family == 'RedHat' - ansible_facts['distribution'] == "Fedora" diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml index c2f58c8..cd12e05 100644 --- a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml +++ b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml @@ -9,20 +9,20 @@ tags: vars - name: Distribution specific setup - import_tasks: debian/main.yml + import_tasks: "{{ role_path }}/tasks/install-deps/debian/main.yml" when: ansible_facts['os_family']|lower == 'debian' tags: [ 'build-deps' ] -- import_tasks: suse/main.yml +- import_tasks: "{{ role_path }}/tasks/install-deps/suse/main.yml" when: ansible_facts['os_family']|lower == 'suse' tags: [ 'build-deps' ] -- import_tasks: redhat/main.yml +- import_tasks: "{{ role_path }}/tasks/install-deps/redhat/main.yml" when: - ansible_facts['os_family']|lower == 'redhat' - ansible_facts['distribution']|lower != "fedora" tags: [ 'build-deps' ] -- import_tasks: fedora/main.yml +- import_tasks: "{{ role_path }}/tasks/install-deps/fedora/main.yml" when: ansible_facts['distribution']|lower == "fedora" tags: [ 'build-deps' ] From patchwork Mon Jan 13 11:53:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937231 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA261CAA9D for ; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=tr/qxSr1WVU1vTGjVI19PGWrKLn80Jt4ZP3QqigVZp3a+JUPFC+/BD7SpYdrUAMqeyALRjONLVEvN2TdHKkOGP6A7aOsVSvCfeTifWR1IrBC1p98wDWqrP6lo6y6cuCSBOSFWB8HnTUdpSKH2U3/CVQbdEVkkUTUlI3B+hMpcE0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=FVJUFjxaM/R8fpk2NV9PoLz5rdhcjKBPNJtHwh5TkzY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sBmG3rvEJQyt7sUUPtnXnyXrbOpTzg16AetuLLyOXNhJvGYoVZ7JPvmFu1Lc7UYcNoUk16sVkIvP2fwZHuBvmTOhqUbElGRByiNqy9kFDYSspR5rFWOAaXMcpoGJpPY464yLUCt2E8+vsbLnHjAJSxXbIUiDu5M2zKm8CDSq5gk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aBwzjQh3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aBwzjQh3" Received: by smtp.kernel.org (Postfix) with ESMTPS id D228EC4CEF1; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=FVJUFjxaM/R8fpk2NV9PoLz5rdhcjKBPNJtHwh5TkzY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=aBwzjQh3VsCtP/8l+E6c4J+kFHJH4+CGxx9ST2foorA+PWFc0VPb/7pFICObmLr66 WlQC85TgcbleXyweRDfctevTjfOUhVKsPy3j8POt+KSuAwqNeDtblIwKPo8TmHMK2I hmWDyzWsG1oLP/U31MZGRnjro3qsk5Le9Ebtyjqz2wJl9+TMzxRsaGLfyX9AVDWJN3 FOqQQXLRtls5QTqG8y849yDqCiGQdkS8gBjoyhe0EEK2rNNq77MiEyf3LAySUZoMx6 k94wooLuAJ9xLgHgX1y0YGLBFUYc8Xv1Dh53xFzWT/mg19Tz/BgiwyMN7A4vI+IqXj 5MwCJpC361ZlA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA520E7719F; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:05 +0100 Subject: [PATCH RESEND 07/12] ansible: Run sudo by using the '-K' ansible arg Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-7-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=3240; i=joel.granados@kernel.org; h=from:subject:message-id; bh=FVJUFjxaM/R8fpk2NV9PoLz5rdhcjKBPNJtHwh5TkzY=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qbtjh6tlRNzC3rhNV22vS6dEpRScKjU+ QLoECBcRn7vAokBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6mAAoJELqXzVK3 lkFPoxkL/1wgbop1AiHixSqjBrHy/rURT+ip2Ub2wAJb/nmy5GApYHg8u/t4iTTgBMmDfI6AY1K B60nnMBffhw90zMoqSjMrH4jASh6+oR/bgWq55Ua8QNWwuoehAgjxWh7HAk6ytIVzq+GI3JAA5L rSEHD1UGTVS1sKdiFlis30YMYeIG3mKUAO0Vsic26RQsmIiY84Z+PF0EHLXRb4b9g1BFKpcjb+S 3/b56xwwR7VppNxypTV/N/SO+Z6M7nz14uUlEzpgfPMZmIY4bzHkOyOdq/sgDUUyMu3XJAxqLqK 7QHdD9Fzi46OlrhhRsqDDhwg8h6sWiL5MwdQ8INJ+TTvfs1gJ0KVJIyNgevl9skAcsdrPrME41t E1YmysPZpzpZ3+xe3zit1Dwi0tCKb9FM2wzR7bpp1/SpWhIPvwLsG45FuaBL2ukaT+uCjv55kP0 3IO5b/ql7XJHZcYYwCc/CWvHNwzMMiR6oNdCMcTFnZNoOM6j3PhUvq5T25ksGl1FAomsW94i1Q9 BU= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 This patch does two things: * Remove the become_flags from sudo tasks in bringup_guestfs and libvirt_user roles * Call the playbook with the -K argument so the user enters the sudo password just once after the playbook call Signed-off-by: Joel Granados --- playbooks/roles/bringup_guestfs/tasks/main.yml | 6 ------ playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml | 1 - scripts/guestfs.Makefile | 2 +- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/playbooks/roles/bringup_guestfs/tasks/main.yml b/playbooks/roles/bringup_guestfs/tasks/main.yml index 07e0fc4..95631aa 100644 --- a/playbooks/roles/bringup_guestfs/tasks/main.yml +++ b/playbooks/roles/bringup_guestfs/tasks/main.yml @@ -59,7 +59,6 @@ - name: Check dnsmasq service status become: yes - become_flags: 'su - -c' become_method: sudo command: systemctl is-enabled dnsmasq register: dnsmasq_enabled @@ -72,7 +71,6 @@ - name: Check if dnsmasq service is active become: yes - become_flags: 'su - -c' become_method: sudo command: systemctl is-active dnsmasq register: dnsmasq_active @@ -94,7 +92,6 @@ - name: Check if libvirt default network is running become: yes - become_flags: 'su - -c' become_method: sudo shell: virsh net-list | grep -q default register: libvirt_default_net @@ -106,7 +103,6 @@ - name: Start the libvirt default network if not running command: virsh net-start default become: yes - become_flags: 'su - -c' become_method: sudo when: - 'libvirt_uri_system|bool' @@ -123,7 +119,6 @@ - name: Look for console.log files in guestfs subdirectories to check for CI enablement become: yes - become_flags: 'su - -c' become_method: sudo find: paths: "{{ topdir_path }}/guestfs" @@ -137,7 +132,6 @@ - name: Ensure console.log files are owned by the main user for CI monitoring become: yes - become_flags: 'su - -c' become_method: sudo file: path: "{{ item.path }}" diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml index 5797bd6..2fa31ce 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml @@ -49,7 +49,6 @@ - name: Ensure our user is part of the libvirt/kvm groups tags: [ 'journal', 'build-deps' ] become: yes - become_flags: 'su - -c' become_method: sudo ansible.builtin.user: name: "{{ ansible_user_id }}" diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile index dbfb372..480bc4f 100644 --- a/scripts/guestfs.Makefile +++ b/scripts/guestfs.Makefile @@ -73,7 +73,7 @@ $(KDEVOPS_PROVISIONED_SSH): $(Q)touch $(KDEVOPS_PROVISIONED_SSH) bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ + $(Q)ansible-playbook -K $(ANSIBLE_VERBOSE) --connection=local \ --inventory localhost, \ playbooks/bringup_guestfs.yml \ -e 'ansible_python_interpreter=/usr/bin/python3' \ From patchwork Mon Jan 13 11:53:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937230 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA801CAA9E for ; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=GSjhydSqu/72sEnXN5gN1fHDt2rshj3WyDAtI5XPMva7GAY3+sdIKwRJONmeRxDZ70s4tUOuvzf45iIWjcSnFd3wyTbKYg6iffwfa4lnq+LqiotQ30Tk6zgypXAEAKl5dJPGBRsz2yT2wC4dFUQmyB5xw1WKaZAdIAVyIx/VVEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=DvGfd4CLkmhlBD3vAsOZb4k3P/lxx9nbk6oF98SgWGs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZNBfE6XwtQbnay9Db3HGoAwBe+ODyg5CVOfDbC++z9GQhFarFh0hTHSWxEgmu968KIn0TDysFdyfW+e13M76Z9qF9GW/NcyYA3WIZDYwSfW/XbPUJq6N23RaAqsEjeeO1vjSLKOiuDMmhFtaGcvSCAeUBFkAylzFtg9tgC8vYm0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cadf2Ise; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cadf2Ise" Received: by smtp.kernel.org (Postfix) with ESMTPS id DD0FFC4CEF3; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=DvGfd4CLkmhlBD3vAsOZb4k3P/lxx9nbk6oF98SgWGs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Cadf2IsewBZwfyg8M3+/xrzaRhp/znFduKWbCSAqA3c//HJgFsTG5+iid1+dnlkTE 5B1euei+JNDzTrKDPDYDixf5rltEuIU01zE7TRaaWfP+5PYKKjrYHzpcHACRkOa/2P qA6dJpj2XurC6HrnZatSxuIqhdXnLKb3Td2Ux6mOttwTNk+H/duNFNrplqmxUdl1n6 KOwGCwM4jxW/AcHt2tigc3URDsyned44+BiQPcfsoI4+GtUk2C8FJopwUT0rUzcZNK Y67q2hBgtGa0EJx3K9pm7RQkTa4f3TeO2QNgyjtgxJdxo+W7FWof18MsXlWI2bzs1/ n+lYubnWmGvEw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5961C02180; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:06 +0100 Subject: [PATCH RESEND 08/12] ansible: Install libvirt deps and enable user Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-8-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=1171; i=joel.granados@kernel.org; h=from:subject:message-id; bh=DvGfd4CLkmhlBD3vAsOZb4k3P/lxx9nbk6oF98SgWGs=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qY6S/o7dsMnXjGnA7CirAZQtD1pk/iMA /fPJIgXvhplx4kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6mAAoJELqXzVK3 lkFPvDUL/0/p19s3IJXY1YHnPfoLtjzvRJH7RY/w9dd24E5K+nHZ4WDiSQKsMxliYJWqkpld16O WkffVA6hUXrLI7Fn/IxjFoPzm229jKJE6LThrEYB9JfEZbgxVtYOumAFLMxmQsvRKmePPlaWyEk nCPsq3Ij6QAXfc6KdAixgccD2bmFfSMdQiFhHfkVIIjQ8G0rOw4IxuCSLvYL6M56/s80JSWJlTE hTtsJgzV6vOwuzUAnx9HPErrYTTB6fiIgLhQf0Jx1BlF28+2PERnyZzYlJCEzyaIvgzPb5gZwCX 2IS8y95G7O+3GiiKIFzScO4UZYleQJsYSb6ZxabIkEkvKdOJKAehF/WFPyStn5jshTPFL4mvDlF 4Ba+QBEfFZ8N5sLk7tqysKaKyXSHLJkeG6iK40Z7YD7Z6YHViuJk4BquxgCOwPQ8uD/4GkAV4gZ BHkT80gMwc4AE2IBvmXA+EC444w/7DX+qK77K40gimeFUnAjXlvZypLnxpsE8D+gGq6mLY5YmZ5 0g= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 There is a need to setup libvirt when running `make bringup` in a system that does not have libvirt installed. Call the dpendency install and user enablement roles from the bringup task. Signed-off-by: Joel Granados --- playbooks/roles/bringup_guestfs/tasks/main.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/playbooks/roles/bringup_guestfs/tasks/main.yml b/playbooks/roles/bringup_guestfs/tasks/main.yml index 95631aa..c764ae4 100644 --- a/playbooks/roles/bringup_guestfs/tasks/main.yml +++ b/playbooks/roles/bringup_guestfs/tasks/main.yml @@ -38,6 +38,18 @@ when: guestfs_subdirectories.matched == 0 tags: [ 'config-check' ] +- name: Use install-dep tasks from libvirt_user role to install libvirt deps + include_role: + name: libvirt_user + tasks_from: install-deps/main.yml + tags: [ 'network' ] + +- name: Use enable-user tasks from libvirt_user role to enable user + include_role: + name: libvirt_user + tasks_from: enable-user/main.yml + tags: [ 'network' ] + - name: Check for dnsmasq configuration files stat: path: "{{ item }}" From patchwork Mon Jan 13 11:53:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937228 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28C5F1FDA6B for ; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=pr4HmKwgOo28t3wPjDdGitPCkHEWRxIf4XA9qgY6BJPyhJrZ5jKpZr59UZvD4ON2plwxeZlXIN9/BpZ2QAhE/1++GbFR3UFqnXFLQ2FMEZ/92mr9r3Ss//0PywLw+JPhXGHvdsXYdvxDZ/c6bydCYQYq/UCmGM1pXUYnbA4ojx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=blpX8RLeBeGfkLAcRl9t/43jnD5+iwBVQKPqmTP/Ar+RFfjxcgOdK74Mlqfx/X/Of+DWMFqE6oszMDKrmH8z0sy5kuCOKPaBxBGfSDICDXdCQRlux6YX+i5fmZyxQFDpjwFQSberNTI681OnJSBMVibKQKi5mvxK8T05bS7NTC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AqRnzYd3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AqRnzYd3" Received: by smtp.kernel.org (Postfix) with ESMTPS id EBC0BC4AF0D; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769196; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=AqRnzYd3eSUM8jesWC3ddMIwSCSIpm0bgVVic1NS6t//kzV4BTgRYVNVL29JIQgtw ZvM5tzaCVHUmxB/oBPgWMaTzZ/DVcsNyueP0SemcSHGp+Me+kOrOtG4Aqgw8x69aie z+60u8HNTUAnzf6jVyjR3Kc5Bye5KwSl3yin7hs7sUdKCDma9y53IAUwvJSFkD9FKg dlztg3RFYNJZPDWWA+t2Lc8JrVFe+PkIWBdmHcmezCz4ZeKfBgZ9JIp9lkEa9Gt2a8 Cs69+io/ggfJw7IX9T0LwO5gn9W2vjYbYDmusrvjhIpxPZH4975ME60vmpZOpzAv1H Pwao1fdXM32tg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF2D7C02184; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:07 +0100 Subject: [PATCH RESEND 09/12] ansible: Reduce long ansible messages for readability Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-9-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=2148; i=joel.granados@kernel.org; h=from:subject:message-id; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qcC26qMbqNmHdjgUFaitOlkid3r9EnSo Nd3iKjqxvQOyIkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6nAAoJELqXzVK3 lkFPvgwMAIb+HIwcTbuPHRP3/kWOLEVgDMr2j13XDTaVNZCr4sz5L5VmNXP2ibTWIH8uUlkyK4A O918ns3s+ST3uBdcNpVcP/NesqgKSfHKHV+Z6uSqRx7IwOAoyWmkayYj63ERMxEWPjAdTD+iHPa 6auQAdyZp677dNieDkFROO5V/iLOJ90A31gy3iY13DZSMcaG2+z67ScADCrZbm0EEbzpgWb8CWS dAXb89Gz00Jumb2VkOVOkc1aIkUBqX2iy1pKX9mLo32hW7MO0v2DlVUNgAwd9xLGHEWP6uh21n6 JLuLBWzwlRGBwe3EHZsffnbZArdK+zy0hW61vfjJB+EBH08HovsFVlgOs8ZhmRD+anW5160TROo uWl2MAe86Bm5mQSldtp1DE9X2JQFdrOVP6XQEhzq/8xJ/sKA2b2vmVbUVWERwqQY5vB9mW7pNNX 3eeRG+fVDFof/+7S1C7wzAayi7+Jlw1MQ69oXP7lQKz+jhvV80zAP9kdgoj3665s5KApzhSkdm6 Z4= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Signed-off-by: Joel Granados Reviewed-by: Daniel Gomez --- playbooks/roles/bringup_guestfs/tasks/main.yml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/playbooks/roles/bringup_guestfs/tasks/main.yml b/playbooks/roles/bringup_guestfs/tasks/main.yml index c764ae4..fbbb378 100644 --- a/playbooks/roles/bringup_guestfs/tasks/main.yml +++ b/playbooks/roles/bringup_guestfs/tasks/main.yml @@ -6,7 +6,7 @@ - name: Fail if {{ topdir_path }}/.config is not present fail: - msg: "You have not configured kdevops yet, configure kdevops first." + msg: "kdevops is not confgured. You must run 'make menuconfig'" when: not config_file.stat.exists or not config_file.stat.isreg tags: [ 'config-check' ] @@ -63,7 +63,10 @@ - name: Fail if dnsmasq configuration files exist fail: - msg: "dnsmasq configuration files or directories still exist. Please remove the following to fully uninstall dnsmasq:\n{{ dnsmasq_config_files | join('\n') }}" + msg: | + dnsmasq configuration files or directories still exist. + Please remove the following to fully uninstall + dnsmasq:\n{{ dnsmasq_config_files | join('\n') }} when: - distro_debian_based|bool - dnsmasq_config_files.results | selectattr('stat.exists') | list | length > 0 @@ -95,7 +98,12 @@ - name: Fail if dnsmasq service is enabled or active fail: - msg: "dnsmasq service is {{ 'enabled' if dnsmasq_enabled.rc == 0 else 'active' if dnsmasq_active.rc == 0 else 'present' }}. Please ensure dnsmasq is fully uninstalled and disabled. Run 'sudo systemctl disable dnsmasq' and 'sudo systemctl stop dnsmasq' to disable and stop the service." + msg: | + dnsmasq service is + {{ 'enabled' if dnsmasq_enabled.rc == 0 else 'active' if dnsmasq_active.rc == 0 else 'present' }}. + Please ensure dnsmasq is fully uninstalled and disabled. + Run 'sudo systemctl disable dnsmasq' and 'sudo systemctl + stop dnsmasq' to disable and stop the service. when: - distro_debian_based|bool - dnsmasq_config_files | length > 0 From patchwork Mon Jan 13 11:53:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937233 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725EA1FDA6B for ; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=rztFpFdIz2a5y+7Imvn8WNB1BfAwwMCC5I/x/J1k8ye/HjNn6IiShTcmT+zxFklXRNghHUD5Ly6oLjugqf8ZiA6SjpODRY3MaFxBb6wYD+XVBcfea57WSeiT9DaE+23NZTgNzdDX/a43gIbGUareCRfaViBX1SiDyIr/MWXOD7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=l/flaod/aZKoU8m0yBnBUBZzRVVykVMk2fVKTOumNQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sj/Obw6tmJvW/T+dJHP7A7pBpcAHdzl6g3m+zoORrb/hjdcMW5ccHPQrZjjQVQLAc4PjAah5Eg3WhvWNARsS9kKYKdrD4rXwn04VvSF1B+PqFrwgp6d/hqrvSFndq8n0Vi6WZBTq5mAjA42++IRZ0LMZWREI6VQRd25KoVB7lOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X4lVxboT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X4lVxboT" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1625AC4AF0E; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769196; bh=l/flaod/aZKoU8m0yBnBUBZzRVVykVMk2fVKTOumNQU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=X4lVxboTvNTz4ghaXrXwdrhMwjI4BInnvxj3rumugH8ZjjPyhGksEoALkOwQ+9yYm YTbkbS9Nfgxnkz5jneQ83MSHKvj9Jr1PkHgyj6OQLTtO3ELiJG4xfPlBx1wpjnuYcl utdxUFCuW0PwM3UGBabYser/QidyW+qm9kdTPySkGlcyKoXU4sQy4OWWydJQ5Futh1 kdAMWwFdNQ24HokyYSezMUV+8cjRjD7Hvc7VqJ635GErVLH378dWOCmusXcaiczfWm JmYJ576xrOie5NfOqZtaDjk44hjYH/wxIicqWxYkJkZqj86dNwdyGiBGEAkJ+W5o98 4fk+SO9EHHsbg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC7DC02183; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:08 +0100 Subject: [PATCH RESEND 10/12] bringup: Use full path when creating custom_source file Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-10-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=940; i=joel.granados@kernel.org; h=from:subject:message-id; bh=l/flaod/aZKoU8m0yBnBUBZzRVVykVMk2fVKTOumNQU=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qfa1sJ/HfBa0mocYc6jdWvtDJGVW76R5 dtpfyE7fZXNO4kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6nAAoJELqXzVK3 lkFPcnoL/06qw5gdDicKVyr0fk5l2fgFSOjzS/iUc9mc3MNq7gk3d0oqKcCby0EIifsUgnmQN9F 4HeisSoWUbyf2t9+qjyoeaIAxa6CaI0biYnEK7tWBNFQJqHbIHFJUx+45eDTPXci7AeiwpiQtb/ pMtai2YWEcofAoMH24Ne8kr6dv7I1azhQGLs2vzgJML5sHTPAL0nYDcH1s32N90QFUffdaPMVox i82sTQr189RRrpoUnFANqxSybYpfV9za0848o2rtnQLm0HNrnr5Bj+xsbdGe2BJLMOyVEiYDacY 2aXsLmZhsGpuommtJfekJM0Dy07bvcNePtxDvDhA1xMgXqNcM3H9xFuJsYNv4vihJvj8DPbnLCJ bbdmdL3ADwukSbLlzTPUwBA/+3fnrGDNMNEfBG5f8KEJORUtCbpxFwbJLzsU1FclS2RpAz6flO5 xFLxaQXr3VI/fI8z4hZjqI0FWCWPQxPJPPhTTD/jbHyHg6L6kz6BOFzeUjUBfJvyMa7QFOqfAD6 Dk= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Avoid "file not found" failures related to relative paths in custom_source Signed-off-by: Joel Granados --- scripts/bringup_guestfs.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/bringup_guestfs.sh b/scripts/bringup_guestfs.sh index 74eecea..f49fd12 100755 --- a/scripts/bringup_guestfs.sh +++ b/scripts/bringup_guestfs.sh @@ -34,7 +34,7 @@ build_custom_source() SOURCE_TMP=$(mktemp) cat <<_EOT >$SOURCE_TMP [local] -uri=file:///${CUSTOM_INDEX} +uri=file:///${REAL_CUSTOM_INDEX} proxy=off _EOT sudo mv $SOURCE_TMP $CUSTOM_SOURCE @@ -111,6 +111,7 @@ build_custom_image() CUSTOM_IMAGE_OK="${CUSTOM_IMAGE_DIR}.ok" CUSTOM_SOURCE="/etc/virt-builder/repos.d/kdevops-custom-images-${OS_VERSION}.conf" CUSTOM_INDEX="${CUSTOM_IMAGE_DIR}/index" + REAL_CUSTOM_INDEX="$(realpath $CUSTOM_INDEX)" mkdir -p ${CUSTOM_IMAGE_DIR} From patchwork Mon Jan 13 11:53:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937232 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F85B1FDA86 for ; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=RilXxrJssDXI1YlDOzagm4DrdMw9jEIfq3T4pptLkl1cdoHzCHiFI4h/3Gp0cn1KDKLzlkRDPAeD0m6J8pHlMBM+YSBHP5i0EoIeOc7SdwaoTrSE+zoddr8VegdoZCr7jBjJNWaA+KOQAVQXk2qdYAbGmypgz8ZKVo7gwwnhDNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=Kv/ycEEjWStHBxJuRHp2jefllpU4iYXDCmq1ZbHsqLs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NyUpWjdg5GDkskg+JHyUiOwBj3yDIq5iEjJx4EOeMbJyTXxOzqomKfx/sZ/SrRohK5iB/sIaiBHqNNTZX5eyLSKIBSAFtqydvlHauUqo/TMmd7tkWu1veD9KMmnWOfLyhFzaHHYmO7fWwnHs7ovx3+LS7azP3H08zwJcFefjT08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rT0ISAPC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rT0ISAPC" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1A7F3C4AF0F; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769196; bh=Kv/ycEEjWStHBxJuRHp2jefllpU4iYXDCmq1ZbHsqLs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rT0ISAPC/pfgUeqNBTVCjUb9u/hK0zUdfUZYR6Irmj4GjrZbv/ppU39wRtXPJaDQt 69B353kEJSc4FIrBaN3pbuFicl4vXnS1r7fD4mZqg9tG9LZNHyvf+MCqeg1OdAQ6p8 zgxUkR/G89RDDQ2XVN9hxVuibarP57sj/ITVekUhb7qy7pS4cJ58M1nKFfqulwdlqV aDHdOoQlvczd0os3lD739oa4vPh8E6WMLdW0n2vQHGVH3AfpC095agbUY+5GZwigb3 rvm+tNw95S3ORCM7QpNSVJt6MugQz90TPe+/cRcaKTZtWTS9LpjpxYeOD3J6F7cIMd 0LRpCN5n/8CRw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B786E7719F; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:09 +0100 Subject: [PATCH RESEND 11/12] scripts: Return the full default path of the pool path Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-11-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=618; i=joel.granados@kernel.org; h=from:subject:message-id; bh=Kv/ycEEjWStHBxJuRHp2jefllpU4iYXDCmq1ZbHsqLs=; b=kA0DAAoBupfNUreWQU8ByyZiAGeE/qihjTAk+t4sfpUIDKRspIW+2P/vcvk64I4+wMMVgMihs YkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6oAAoJELqXzVK3lkFPBkUL/iQ7 29G+y0NWZtSazP+onjmYbre4TAvOP7k8H3SthkNre8mq32inh72bk3d49yBF2q2CPmF26RgG6yU zAKW1ygddXSYcUTPzYtIMyo5aNYRt5DK6x4iOFffMXzbqSCpLmJ8J5arSjHcLUrh1aujtvVVXvC tSVYmMj/4PrHZIH0LNPmb3ytSQ8FnV0GCg9ZdSh1ODp5ijO9IidZxktczRH8s0RGbGUBi9Siq1h Y8ozvxbrgaLWHZePxDpRbMKk5gEVuI+EEFgGZhOXORgvD9Xiuzd1a3Gaag2wRnnCgfycL/seYY9 yvKDk9vt1P5zhtnOtiUXYtNMQXYZhla7VjRgi6hhSyQiSolzk0KqrBlCOiGjRsRj81JrOyC3E0O 0G900liW9dn6UR5LhoM86nCgoKslPxz0og/WkTTg+DKRNefxTDgdK/urh6KJh1lE/w0BZouqjCG NSX/NXRxHi4Mh5ket712I74IwWzEUKAhYMx3/8Z/kD6YZrZH3/YuBXweGKvQ== X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Avoid "file not found" failures related to relative paths in pool paths. Signed-off-by: Joel Granados Reviewed-by: Daniel Gomez --- scripts/get_libvirsh_pool_path.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh index 92901a8..c036777 100755 --- a/scripts/get_libvirsh_pool_path.sh +++ b/scripts/get_libvirsh_pool_path.sh @@ -17,7 +17,7 @@ POOL_LIST="" get_pool_vars VIRSH_WORKS=$(virsh_works) if [[ "$VIRSH_WORKS" == "n" ]]; then - echo "default" + echo "$(pwd)/default" exit fi From patchwork Mon Jan 13 11:53:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937234 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788C71CAA87 for ; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769197; cv=none; b=tKff5yQQae01FH/SQHkmxoimoAnx+9+zOkyeywVevLkNqRKYYBPtaEeQLNU2HqVHOaO3zVCT4LstNZVse/pL6DSnVcw39LGYNCLLzgO5C/ySEgJOnZEuXbL9t4NKGMqV+aQDzgFIvVVmMXiNzW7hiiBuW6igWamTmop3WZgiglw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769197; c=relaxed/simple; bh=jRfRt47UG+s1NGe9WMjH6iz6cKXD6GqKWu00bPFiEVg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UjIq+laU/yOVWa2o17xvlzxwaHiOsFQsb7QZWksiOnKrCWdpAI6SnoPvHfI1vBCcmxE5AHV+s8WrJttCnoNRKu0uR6da1Pyk31gIJZc3ZCl8a4wE1G+RY4o8A+rjFuXtnqgvoV/3Amq+1TVAz4GDFzh0iJynIKBdZ1VW4wUUv6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PzyKYv6U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PzyKYv6U" Received: by smtp.kernel.org (Postfix) with ESMTPS id 25623C4CEE2; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769196; bh=jRfRt47UG+s1NGe9WMjH6iz6cKXD6GqKWu00bPFiEVg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=PzyKYv6UW+T5uIgaI2POLCiTKMjGybnGkCoxZc1kKuO51o/rMt4PJIyQJp9cCST3A 5ev+hAt0s8Z05wqS0nFxC2cpym1AQtzVv2xvSfDHQL+q9W7OoetTDB/AxyFYe4W8Yj dka4uV2A4sCeaUq7j5JUiOYl9Rk3FHQGo977Uo9pGTkcuHWwZW+Tq5moN/u+Oydxgr B7nvOw2vFu22DmOED8T2atp9HALoryf3xZ/U1RM6mY6urbu/dJzYPUtzlHtwQk6Y6y u+ME0X5INCTjHSlfMfyQ0Yeh3z4+1+Mg4gg0B5LGbUFdTj3od/5FUa3hElgKg0uO6Y SnDrD2Ean3+Wg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBAAC02180; Mon, 13 Jan 2025 11:53:16 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:53:10 +0100 Subject: [PATCH RESEND 12/12] ansible: Set running_user explicitly to the USER var of the script Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-12-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=643; i=joel.granados@kernel.org; h=from:subject:message-id; bh=jRfRt47UG+s1NGe9WMjH6iz6cKXD6GqKWu00bPFiEVg=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qnVU5Nc7jZ9JN+KPKbgPppv2umrILvZf lmHbnh7bRo65IkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6pAAoJELqXzVK3 lkFPsrUMAIM2AyiSK0gYw/qlHsMMqNAEEcxtDLAiWxhq+s2c0578cB6JhHFdoWbYVrCT69n7zmQ xZ4D6JvS203XGn1IUqH09gJylZT4W3a1N42Iiye8vprt1LTdJg/y1jdbjCiLu4dZfTOUcH7Yl0p l2v/JQWpFu0HFpLLpiEcBj9GL3W3cCqbUe9ZJgBaHiVBGtWudzJU9i0wfFa5c6CukB7w8zrhz2t /5HSKVEke9kRNd2fVGCyHtOIz7SJWKK0/fY2cFHx9AvnopBn2tTKJcfShanINMgk3Q/FUPR96+J tIj9xbNCQRF5WKE8lKV7WKwq7upyn7/ofqKZt/9JIWxLXGqwLwgXK8ODINpsDPtwI0rBdrVcywB +TAAKLBIQ6h4r2SxEXY6yvcehUCqI/RVA9PG6lA7xC5mGHhgkb3WdUSfAFNMMqG41UQUtq0UrJn MdrRLN1zyO2JaN/hZuZeVfVGqf6bUWhhd6XIRcL1Y+KS/4SGjqGLmfJWwa8HKqM+ZRKWcPnzfz5 Kc= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Signed-off-by: Joel Granados --- scripts/guestfs.Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile index 480bc4f..f463ecc 100644 --- a/scripts/guestfs.Makefile +++ b/scripts/guestfs.Makefile @@ -77,6 +77,7 @@ bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) --inventory localhost, \ playbooks/bringup_guestfs.yml \ -e 'ansible_python_interpreter=/usr/bin/python3' \ + -e 'running_user=$(USER)' \ --extra-vars=@./extra_vars.yaml \ --tags config-check,network,build-deps $(Q)$(TOPDIR)/scripts/bringup_guestfs.sh