From patchwork Mon Jan 13 17:44:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Price X-Patchwork-Id: 13937849 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00CFB1BD9C1 for ; Mon, 13 Jan 2025 17:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790293; cv=none; b=WxwuliOSjMTmh2hJibO0NQ7aZ/ihKIuS4wUB8XVVMl8os8l3DiEpX0W1NxpL216PA43o7xswvlJgiAqGae7YolCj1Azg01w6ySmkERIg88BETZWAqxdFOssSkTIdvk3gUxkrOwTMSYKr6k1cbaa0Gxe/QmfgsgiFPXSEIg2yqqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790293; c=relaxed/simple; bh=F2KZg16EBTp92ge3DrBqc9jy1V79LKncQdKxeIVxUOg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DIA6bdctMcmUQmgzBE3XW7CqvIKviB5knFtrkeuX4vxaKyI2pyeRtInQ0m1wICdwze15NmyrW9pNV+eOi6WQDQnZJ2X33ZFeu2tR6pQNf0UDBPypzXHMynsHLVSXSxvzWPRLzon7VgfL4gOXb2aXoUVxCmBTomKP+h6CnUDok0E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=jpABpXlW; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="jpABpXlW" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7b9bc648736so409886685a.1 for ; Mon, 13 Jan 2025 09:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736790291; x=1737395091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5lYIOjwVOiyZSO9nrORqGYqQ+1pRAYOeyq4Co+ahKG0=; b=jpABpXlW3rerS4GsjVOihPJsh35EflWQAd+8/TNnwQZ8/sX9dn0HFUdIQRnOXsLpuR Da6G2ChDus8OxbgIaIQfNbOvMTFgUOgpFsHktPuVXkppHjxu5v9xOi2fW1+l1rNbKjuq 8MRqeqz0IgLv41kLCmu9I/+5grrB+D0nLwMn0Pdc+c9IoMvuwRudqwdIOyENL2VwWfEY 0VB0cT4ALEkxOxGmgPZWDVW8HkRuDlZDG4azcDwhTr4dOyV14OpGuC2YsK0f8PEGWUN+ Dfgq+mx8SFh+jPrPY056TRNlzSQRhkCU6WkShXZv1ecp3Hm/8i2+pzuVI3W28N2egMx+ MT6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736790291; x=1737395091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5lYIOjwVOiyZSO9nrORqGYqQ+1pRAYOeyq4Co+ahKG0=; b=dJ+fXDrvMpeBE+QXD9bq9y0YcMM1hg2eVGLI6f+FMN1pK47tkklktvTYdSfKl/THyM QEsvRyvuUaXus9M2UI24n2DPIIXZ8X61JYah1uIihSNlF0IDfqRDjbaBIjhxKWF5fa4B OUjeFAxLF4VeHPKjM192ZQysOmsd2/vNufvCp4Get2TDac1aJucpBerkFGQgbqaCUcTv 5H6beZeE+xpbIyJIU5Tv/45s0FoWMXzIy5p2Tm6kR/OGPyQxKjdom8zdMKKIfneI757i SGjefTwQ+cAlyOatZAsHjQnZs/oJ2OLrErNtVCfdVe2MEpieKPyNgLykV9bqK8g7PGtH A05g== X-Forwarded-Encrypted: i=1; AJvYcCX16HFB6QINUBo/WO7s69Ue4rS7kl9lKsoli8YT8nm3B1IdZs9R6OMLY0oyKkzXPfM4Hk9+Gt6Ek3qC@vger.kernel.org X-Gm-Message-State: AOJu0YxhOkynl0jdhWu6GgQ/Tc77+WoPQDGxmXNePmcgKlhT98QaMk0q 1tqHPyP4DF9jcB059kSDLFoRuvjNyUsSP+IgcMjYK+NZQfV1miNbSixptao0guc= X-Gm-Gg: ASbGncsj2d7GySSOIDe+DM/UsbDH27ULi5Mv+77YqTB7qb7wSQI7GUkGdSbkVxYymvV 8NfOTWuE/jFktI0KW38VikUipYC57w4ueqH7Msh1e4V65LWi6G9nKQlLdcp4twntvHrm1rmIYM6 We4kc2h8n0jfngtWPJgL5GSkxFPwLe543cO1zUqYIjnMqpFTDhh/Fst4RvDvI3Br+7gpaVQfEKb idssqHIIGfY7w9sxhw6hM5p5x29TIuZgQ5AVOHtLyb97JbB+Eba8PMYymunUGVJYM/swqlDyy3U ++Q/vf3HKzngEYkAZ8ZsxWqCgWPOzrQ6fdxlPJj17FTJ X-Google-Smtp-Source: AGHT+IGji/zdVSjj+QKuBorX8KRhL5U0vYxcdcXprimxamnxuQtc2su0NPyPj8UIhAzTvvuSrnfbyg== X-Received: by 2002:a05:620a:460f:b0:7b1:1d91:5d06 with SMTP id af79cd13be357-7bcd9759e0amr3397038585a.46.1736790290892; Mon, 13 Jan 2025 09:44:50 -0800 (PST) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3248c80sm511214185a.49.2025.01.13.09.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 09:44:50 -0800 (PST) From: Gregory Price To: linux-mm@kvack.org, linux-acpi@vger.kernel.org Cc: kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, gourry@gourry.net, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Ira Weiny , Fan Ni Subject: [RESEND v7 1/3] memory: implement memory_block_advise/probe_max_size Date: Mon, 13 Jan 2025 12:44:37 -0500 Message-ID: <20250113174439.1965168-2-gourry@gourry.net> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113174439.1965168-1-gourry@gourry.net> References: <20250113174439.1965168-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hotplug memory sources may have opinions on what the memblock size should be - usually for alignment purposes. For example, CXL memory extents can be 256MB with a matching alignment. If this size/alignment is smaller than the block size, it can result in stranded capacity. Implement memory_block_advise_max_size for use prior to allocator init, for software to advise the system on the max block size. Implement memory_block_probe_max_size for use by arch init code to calculate the best block size. Use of advice is architecture defined. The probe value can never change after first probe. Calls to advise after probe will return -EBUSY to aid debugging. On systems without hotplug, always return -ENODEV and 0 respectively. Suggested-by: Ira Weiny Signed-off-by: Gregory Price Acked-by: David Hildenbrand Acked-by: Mike Rapoport (Microsoft) Acked-by: Dan Williams Tested-by: Fan Ni Reviewed-by: Ira Weiny --- drivers/base/memory.c | 53 ++++++++++++++++++++++++++++++++++++++++++ include/linux/memory.h | 10 ++++++++ 2 files changed, 63 insertions(+) diff --git a/drivers/base/memory.c b/drivers/base/memory.c index 348c5dbbfa68..e59378ec5b00 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -110,6 +110,59 @@ static void memory_block_release(struct device *dev) kfree(mem); } + +/* Max block size to be set by memory_block_advise_max_size */ +static unsigned long memory_block_advised_size; +static bool memory_block_advised_size_queried; + +/** + * memory_block_advise_max_size() - advise memory hotplug on the max suggested + * block size, usually for alignment. + * @size: suggestion for maximum block size. must be aligned on power of 2. + * + * Early boot software (pre-allocator init) may advise archs on the max block + * size. This value can only decrease after initialization, as the intent is + * to identify the largest supported alignment for all sources. + * + * Use of this value is arch-defined, as is min/max block size. + * + * Return: 0 on success + * -EINVAL if size is 0 or not pow2 aligned + * -EBUSY if value has already been probed + */ +int __init memory_block_advise_max_size(unsigned long size) +{ + if (!size || !is_power_of_2(size)) + return -EINVAL; + + if (memory_block_advised_size_queried) + return -EBUSY; + + if (memory_block_advised_size) { + memory_block_advised_size = min(memory_block_advised_size, + size); + } else { + memory_block_advised_size = size; + } + + return 0; +} + +/** + * memory_block_advised_max_size() - query advised max hotplug block size. + * + * After the first call, the value can never change. Callers looking for the + * actual block size should use memory_block_size_bytes. This interface is + * intended for use by arch-init when initializing the hotplug block size. + * + * Return: advised size in bytes, or 0 if never set. + */ +unsigned long memory_block_advised_max_size(void) +{ + memory_block_advised_size_queried = true; + return memory_block_advised_size; +} + unsigned long __weak memory_block_size_bytes(void) { return MIN_MEMORY_BLOCK_SIZE; diff --git a/include/linux/memory.h b/include/linux/memory.h index c0afee5d126e..8202d0efbf46 100644 --- a/include/linux/memory.h +++ b/include/linux/memory.h @@ -149,6 +149,14 @@ static inline int hotplug_memory_notifier(notifier_fn_t fn, int pri) { return 0; } +static inline int memory_block_advise_max_size(unsigned long size) +{ + return -ENODEV; +} +static inline unsigned long memory_block_advised_max_size(void) +{ + return 0; +} #else /* CONFIG_MEMORY_HOTPLUG */ extern int register_memory_notifier(struct notifier_block *nb); extern void unregister_memory_notifier(struct notifier_block *nb); @@ -181,6 +189,8 @@ int walk_dynamic_memory_groups(int nid, walk_memory_groups_func_t func, void memory_block_add_nid(struct memory_block *mem, int nid, enum meminit_context context); #endif /* CONFIG_NUMA */ +int memory_block_advise_max_size(unsigned long size); +unsigned long memory_block_advised_max_size(void); #endif /* CONFIG_MEMORY_HOTPLUG */ /* From patchwork Mon Jan 13 17:44:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Price X-Patchwork-Id: 13937850 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8752E1BDAA0 for ; Mon, 13 Jan 2025 17:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790295; cv=none; b=PPmGdUJw3aASxNrT5kB+xPKsup1e3ki0YvOSsgYaQvi7RN/5ZlUI/RuZ/fuHQ2eySpUuiYV8xl2eDwLEC4y8i64uKRJVvBBVZXU/jq+07XSkOrmQ/kFJsdzeujLO+T6++m3ZOyTs443FXb3UcQT+UybqqzeWz6xiemN1W5Bs0hI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790295; c=relaxed/simple; bh=Z6hmuojvYtXTroj1JJWHKwTtvZg1ohkoBA7CDtsjZso=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K0XT+o6OdZxrogoxH4BPxKfPtxB9BoOgoF8hlXKEnwd5yqalKU1B3OzsI/+ubmocFMsY7soDJLuMjGRJOiPOJOHx3AXFVub/WkdRRFGhJzw4skzuQFir1UwK9gkpIzJEfHeC0ai3uR9Wa4pHNTFszH7RhdaJxpIT0b/CGWFv9q4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=cDLsdk0w; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="cDLsdk0w" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7b6c3629816so260199785a.1 for ; Mon, 13 Jan 2025 09:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736790292; x=1737395092; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xZSM7cd0rzVSNSrAghH4+54a5vGC27L1Y4nGLMrRkSY=; b=cDLsdk0wSNVC6HsXeucUQLdvPy3zy9q05WcNaAUzzEnlg8Cxf8l0nVVrDC/i6zRhCy 2Jxx1UmKL6UgEv2mXTz71gQb9puPzYSiiJ2ifHX4jBL7h/uFy9LuLKOKSbd5i0iLBQds YYRrbIKgJdvYyJwHaT5omy8i3fWcDoc+gfHVBq7O9QGfaLosivCDBlNCiPEy2xwFQ8Fs JdqBC3vleqV4naM5YGU8N148XpoB1d6LcUzM9YkAV/4jnTHmwA5q7gHR4yKnKOzD7Zo1 ZEhU1knkgyTRDbjnofPWcew3JFYvKZ8LB/Z3TnAPMTh52lC7BTUfVFGGOENOO2dnpKlK u43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736790292; x=1737395092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xZSM7cd0rzVSNSrAghH4+54a5vGC27L1Y4nGLMrRkSY=; b=EnQYVV+uMottwezXNjerhIbw47HgIIbLKk+th5wIcBH5Fcgkefv8vzNsgT2LyUu18T zSsW9k5k/qRD1iYuwMMfIESaXUDNazNZeH9l6V3/GJz0seHKuKNI3IIXu0Qd0ulhei/R lLMryN20zgdJzixVK9eTklfS80ohoKjy/elxakNup9/enN4DAYx5als1FJ/riAPlh120 b3OoHNYDnM/8FrNI7TV7EzyyQioGxbmGSVf4HVUCPDeUUbIBnBiVFE63eVWXKF2aeu+k G81/5inu5544fpZuAnb2zj7179dbYhyMsHj+UnEGPMiyQEZIK0o00WeIT6au5tIakxaa dJIg== X-Forwarded-Encrypted: i=1; AJvYcCVodFf1MY0gJv1kO2CM3nf6WIQLypIZZZlD9SnYNs6Ht76L6DV8Tl7TS7Mji3hdx/nhUzd/NqEKoY4f@vger.kernel.org X-Gm-Message-State: AOJu0YxeUqmE3uWrNqdsx2e6R6R0wuA4sCDggihvJNz/W7UbuhfH/iA2 NqQyEJmBj+JWPprwUbruI72uezmGV4GvcRPe+O1137luffuDyCaQarZZoO/fuLM= X-Gm-Gg: ASbGncuwL6dlIHQZX3WFD9I9KbhJeDSUTYWqPgskzip8WhsHjXpEroWWISoMHjJaKZ8 abp9cb8NEMYF6CLfc+X74KwyAyekRH1mbX7CZKkYMvKbFHYUadkvl+arY/oJXWXEOb0oInEMkYw wxidKNZGUh5+6Uhd7zqza51e4vAm/5EFzBWay+ZWJ1VidoTSigFlSkvO1D8vl/RyIEo05ijoOJM vgIYOmV2ddlaUIu/p211I0kqUARyjBa/re+q396iOykl0m2r791QRImE8J/WOD2tkZJpy0/AGwS EN5zQWPSejdRH6TAFEcKxFsmtwqIQd6FNcgjD0hckRbi X-Google-Smtp-Source: AGHT+IF+IF6Rv5no47DpWYrkZUPK0sDnR8tgi7nlXfUyokU9C1+7BbgLKk1J4eOLXpCwFls4u2oImw== X-Received: by 2002:a05:620a:2697:b0:7b7:24b:dc58 with SMTP id af79cd13be357-7bcd97627d1mr3005432485a.43.1736790292471; Mon, 13 Jan 2025 09:44:52 -0800 (PST) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3248c80sm511214185a.49.2025.01.13.09.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 09:44:52 -0800 (PST) From: Gregory Price To: linux-mm@kvack.org, linux-acpi@vger.kernel.org Cc: kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, gourry@gourry.net, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Fan Ni Subject: [RESEND v7 2/3] x86: probe memory block size advisement value during mm init Date: Mon, 13 Jan 2025 12:44:38 -0500 Message-ID: <20250113174439.1965168-3-gourry@gourry.net> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113174439.1965168-1-gourry@gourry.net> References: <20250113174439.1965168-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Systems with hotplug may provide an advisement value on what the memblock size should be. Probe this value when the rest of the configuration values are considered. The new heuristic is as follows 1) set_memory_block_size_order value if already set (cmdline param) 2) minimum block size if memory is less than large block limit 3) if no hotplug advice: Max block size if system is bare-metal, otherwise use end of memory alignment. 4) if hotplug advice: lesser of advice and end of memory alignment. Convert to cpu_feature_enabled() while at it.[1] [1] https://lore.kernel.org/all/20241031103401.GBZyNdGQ-ZyXKyzC_z@fat_crate.local/ Suggested-by: Borislav Petkov Suggested-by: David Hildenbrand Signed-off-by: Gregory Price Acked-by: David Hildenbrand Acked-by: Dave Hansen Acked-by: Mike Rapoport (Microsoft) Acked-by: Dan Williams Tested-by: Fan Ni Reviewed-by: Ira Weiny --- arch/x86/mm/init_64.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 01ea7c6df303..58ace82874eb 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -1462,16 +1462,21 @@ static unsigned long probe_memory_block_size(void) } /* - * Use max block size to minimize overhead on bare metal, where - * alignment for memory hotplug isn't a concern. + * When hotplug alignment is not a concern, maximize blocksize + * to minimize overhead. Otherwise, align to the lesser of advice + * alignment and end of memory alignment. */ - if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) { + bz = memory_block_advised_max_size(); + if (!bz) { bz = MAX_BLOCK_SIZE; - goto done; + if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) + goto done; + } else { + bz = max(min(bz, MAX_BLOCK_SIZE), MIN_MEMORY_BLOCK_SIZE); } /* Find the largest allowed block size that aligns to memory end */ - for (bz = MAX_BLOCK_SIZE; bz > MIN_MEMORY_BLOCK_SIZE; bz >>= 1) { + for (; bz > MIN_MEMORY_BLOCK_SIZE; bz >>= 1) { if (IS_ALIGNED(boot_mem_end, bz)) break; } From patchwork Mon Jan 13 17:44:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Price X-Patchwork-Id: 13937851 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A7021C2325 for ; Mon, 13 Jan 2025 17:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790297; cv=none; b=Raxj3AWFVSwMBWaOS03/gwtVTHexXuBlVufCyU1E4FBXp52Hl2ZMeaV8MUIFsJS6XnnJ+hR2BRYX9JWEcxhV0oDLF+4IwNQBqW/u6y33TSEydI84t19Ava5gIuVq+4iXaDzJgREG0fu4BS+voihklgDEyevl8RqRLr+XKSO1vyE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790297; c=relaxed/simple; bh=SitMIzrEMABnbqzeLxJFSLv+X+tguAv/sqKQ/L0nmKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WGYlrzp0o66VDKm43AkYooJm443i7KHOyUqLsgISrBlZ2MkBh/hj2YSmAJ39u8wynakgjYQ4f5LS9S+0kZ0tkCWo4ZySuOzi6Otqh5/a8untL0aDjuOyDQyHxYoz7EEsKBw8xfffh0RpRhm1zhdlbQTt1dk8iDa2sNCRbwW39RY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=LNAylknn; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="LNAylknn" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7b98a2e3b3eso250255485a.2 for ; Mon, 13 Jan 2025 09:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736790294; x=1737395094; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yl2EwUT2VKVvGiWjqp0to7EI8yUq6Zt171XOZkuZj5A=; b=LNAylknnjFzNU9MVUCWp3UGc2ajCWX5qmD9y0ccgh2fX7Rfgs4g2D2PhiJXfSIIGnX 4ZV0fDcpJH9wS1pOws5mqBZdZ74hlkXPWVwSi4FuvVP/jWdWPv2AoPGnPSkLDgeBGmvf qyp7Fjk88zLExKFNhRoDTHWGJmNeiToG8GfU6wpBAWwTFJEzyBn7YlNg3/CmUEF8NbP+ g/Hl6nnHlbrCcP2EkuHCDFOMAo+0w8hmDmJDZb310vklVIRI0vklsNJvnQheJfy6ynai Bx/vaoZoT30X/GLzzHQEtvOQyCVpQSdSqhIb6EkKW8jwT7+HwxGvWx93iz26//dIZ19F 4Hlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736790294; x=1737395094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yl2EwUT2VKVvGiWjqp0to7EI8yUq6Zt171XOZkuZj5A=; b=fn6wg/X2072qUf1gIOB8WywOy4bWByez7t1cyhd6vBoNToo6S1o2ZtUDOcW0rSYdju +4i0B/lD2XaroBy+ZzwSZCbJ/KmvW27cDOZjirkXImiST2iPafb8J8EP+ZT8+e4g0dlf 3pxRUi5yViO5D21VpO1LYQyu7I9tYqPjbWDn/whG84RJe8A4zoraK6vh8UmoafBSuJYQ 5jyEJCBTLm3iRq2uKS8Ude8nnJjy6SI343LId6I/NeYkZggCC/EHq1gW5rj1mvRmYdSS m6cV3rtTcRNEiIEp+Naq1CeZJi+ImaSL+tE/BzygJFr2aT1iwoYtmX0BC0BjgJpj56QF vGGA== X-Forwarded-Encrypted: i=1; AJvYcCUGDXJP7nsSm8R3VS4qrnLDcNS+1v9irpkljp4kv/u3BSJEmo5QYgSIaK4GHR2prP7yb9GuWBLVlaoF@vger.kernel.org X-Gm-Message-State: AOJu0YwCfAPr6hneUP/zewjs6DNHJmLSaWY0siOwPENKimKDGAM+0Xoh 1zSVY8fRz97j8j/O7TQ+RW21bMXM/cVOZeykQASuCijyXzPHgvLNSWtEeIfpV1g= X-Gm-Gg: ASbGncu+nyuLA+d87yMCdjPoHVwpoksZzoeDNjZMelEgyNV6A15jjjMaC1mkQ00eyqV FqHANUFxmjIn0bcXadbiakxH++vq70OgUtIqqOCFNShXxSSWjktttCRNfG+s/qQPeppSGn6oqG9 9amcvZyG/ofbb5MiVARsYXLF5Yzju7V9ukTxHSUdGndjqTPEbZ/z1MF/briV83MSq9pfWX5jMSG m/GjPd5/lTin8n0RvP5rsNv2dS9Aeculv605bRcazSgkkRXYZaYeWuvA3bAFE0OcNlEVDAM8c5t I9OevKUJEftso+fmwcNPs/En4RtxZ/uXoYy/V/gN+4UN X-Google-Smtp-Source: AGHT+IHjZNO++490q5I1chUVLoFtrxzaVQ8wh+7ZzlHK7PMYF+bXoOp6mvzhXoNAdBo9KngXvoeIQg== X-Received: by 2002:a05:620a:4095:b0:7b6:6b88:cc00 with SMTP id af79cd13be357-7bcd96e8d37mr3639424985a.5.1736790294598; Mon, 13 Jan 2025 09:44:54 -0800 (PST) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3248c80sm511214185a.49.2025.01.13.09.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 09:44:53 -0800 (PST) From: Gregory Price To: linux-mm@kvack.org, linux-acpi@vger.kernel.org Cc: kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, gourry@gourry.net, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Fan Ni Subject: [RESEND v7 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Date: Mon, 13 Jan 2025 12:44:39 -0500 Message-ID: <20250113174439.1965168-4-gourry@gourry.net> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113174439.1965168-1-gourry@gourry.net> References: <20250113174439.1965168-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Capacity is stranded when CFMWS regions are not aligned to block size. On x86, block size increases with capacity (2G blocks @ 64G capacity). Use CFMWS base/size to report memory block size alignment advice. Suggested-by: Dan Williams Signed-off-by: Gregory Price Acked-by: Mike Rapoport (Microsoft) Acked-by: David Hildenbrand Acked-by: Dan Williams Tested-by: Fan Ni Acked-by: Rafael J. Wysocki Reviewed-by: Ira Weiny --- drivers/acpi/numa/srat.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c index 59fffe34c9d0..7526119fe945 100644 --- a/drivers/acpi/numa/srat.c +++ b/drivers/acpi/numa/srat.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -425,13 +426,22 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, { struct acpi_cedt_cfmws *cfmws; int *fake_pxm = arg; - u64 start, end; + u64 start, end, align; int node; cfmws = (struct acpi_cedt_cfmws *)header; start = cfmws->base_hpa; end = cfmws->base_hpa + cfmws->window_size; + /* Align memblock size to CFMW regions if possible */ + align = 1UL << __ffs(start | end); + if (align >= SZ_256M) { + if (memory_block_advise_max_size(align) < 0) + pr_warn("CFMWS: memblock size advise failed\n"); + } else { + pr_err("CFMWS: [BIOS BUG] base/size alignment violates spec\n"); + } + /* * The SRAT may have already described NUMA details for all, * or a portion of, this CFMWS HPA range. Extend the memblks