From patchwork Mon Jan 13 23:15:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13938219 X-Patchwork-Delegate: bhelgaas@google.com Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE9B61F9F69; Mon, 13 Jan 2025 23:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736810164; cv=none; b=jpshLfujMV9zsqZfHLDUNprN0OSgge8knLDvzqUOdxgiyldF4nXHn5+QwSunxa/1TPOUx4Rg/bKP0uX8fqOR5j7KTIpRzp1ztN8o+nHDfjIsRqTcZqpDXTPYB2QnnVsWCxpD+kAkouj/g190tqdcV7xKfiZRc93RMuqf5jqHsxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736810164; c=relaxed/simple; bh=rJrGMPdpmfczXiBtXgEmpnCFtaz2UlUKLGSFOnqDBm8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=m83KgCP0tZuD9zU/ZWX9qZTuSmIa+kmesofNPHD/3oyXkTqjm5K8WvujfZT0QvhDauoLd29pLI9ltIXGrnukVDOA2arpsSTmE2MkKqW2YBk2ZeMV3BD/MZhsWZGMMJXH3PQozDmctB9xCzP/JwMTubrAtViteUCub4+UR3RGwbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O3sDAR08; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O3sDAR08" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5106DC4CEE2; Mon, 13 Jan 2025 23:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736810164; bh=rJrGMPdpmfczXiBtXgEmpnCFtaz2UlUKLGSFOnqDBm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O3sDAR08F962mcs3ki8IOzWP7rivPtJ2qpHrUQMXPpm1GJEEKszI1vDHa6P31E3Yg r0lajE3QL4FYVhREhuv89XKOJSqse/xOdMZLCnN1lrALLFrzYYCaWNerKDgQMpXjC3 PHr1YU7oAvwoG6owgb/Zxu9Vx2fwmbNdDdo/VUMjccfdMoGSoZXlKP4KJ+s8jrNjQw 87e7pIKM+YTqPt5TtEpQ/3SlSFdb1Job0hDB6s2V69Wu+AXhIIZRf9dKFOPSi+bTHo DJ4tVO2J8T3WD6lTkzT/BqRtBpEyrWC2Zal5IKlIWZOe8DTqzbiB91JukHplxjUQYH mzYr/Ae0BThOA== From: Bjorn Helgaas To: Rob Herring Cc: "David S . Miller" , Andreas Larsson , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Subject: [PATCH v2 1/4] PCI: Unexport of_pci_parse_bus_range() Date: Mon, 13 Jan 2025 17:15:54 -0600 Message-Id: <20250113231557.441289-2-helgaas@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250113231557.441289-1-helgaas@kernel.org> References: <20250113231557.441289-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bjorn Helgaas of_pci_parse_bus_range() is only used in drivers/pci/of.c, so make it static and unexport it. Signed-off-by: Bjorn Helgaas Reviewed-by: Rob Herring (Arm) Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/pci/of.c | 4 ++-- drivers/pci/pci.h | 7 ------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/pci/of.c b/drivers/pci/of.c index 52f770bcc481..2f579b691f8e 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -190,7 +190,8 @@ EXPORT_SYMBOL_GPL(of_pci_get_devfn); * * Returns 0 on success or a negative error-code on failure. */ -int of_pci_parse_bus_range(struct device_node *node, struct resource *res) +static int of_pci_parse_bus_range(struct device_node *node, + struct resource *res) { u32 bus_range[2]; int error; @@ -207,7 +208,6 @@ int of_pci_parse_bus_range(struct device_node *node, struct resource *res) return 0; } -EXPORT_SYMBOL_GPL(of_pci_parse_bus_range); /** * of_get_pci_domain_nr - Find the host bridge domain number diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 2e40fc63ba31..35faf4770a14 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -797,7 +797,6 @@ static inline u64 pci_rebar_size_to_bytes(int size) struct device_node; #ifdef CONFIG_OF -int of_pci_parse_bus_range(struct device_node *node, struct resource *res); int of_get_pci_domain_nr(struct device_node *node); int of_pci_get_max_link_speed(struct device_node *node); u32 of_pci_get_slot_power_limit(struct device_node *node, @@ -813,12 +812,6 @@ int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge); bool of_pci_supply_present(struct device_node *np); #else -static inline int -of_pci_parse_bus_range(struct device_node *node, struct resource *res) -{ - return -EINVAL; -} - static inline int of_get_pci_domain_nr(struct device_node *node) { From patchwork Mon Jan 13 23:15:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13938220 X-Patchwork-Delegate: bhelgaas@google.com Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C5AE1FA26C; Mon, 13 Jan 2025 23:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736810167; cv=none; b=oLE4/ZWoCMQXCu6RszjRDoB7/yp45xXwn9/GdxUWA2HY8R7zu+ZiymTSanIEelJLn10exVN6d8pwPc5zONVsUR8LZI3cndzqD8IX30fRh01irw7JjoPMsnZs1PHj0SYl7qtYFjQoF/OX8t2xxHZ55Kc8QkhpSrc3tsw2az2cmSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736810167; c=relaxed/simple; bh=KOXOGe97ehqKsZKwVKNcpQJHClrkPCwZgqXe+REa9p0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Fbgr69Pbq2iHA4tArx+ov67pelI75gEK09TlS9BuclFD9yfH3bQxDukAW0hbT0soynUMRZY5pSnAI2/+I2lQsLh0dlOVPS7Jv+cVKCshFQIEiizkUDZq6dxamMdvW+E9qneT1WmFnsT14XRQq1xZg2A29l7WSf9YU5vr39xr68I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uJMk1SlK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uJMk1SlK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA8D1C4CED6; Mon, 13 Jan 2025 23:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736810166; bh=KOXOGe97ehqKsZKwVKNcpQJHClrkPCwZgqXe+REa9p0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uJMk1SlK0p74odfX9wVVMd7Rlgj/T/RT5wX1KdH3wcz3w0BglMh49fiVCxXMPqlb2 ZcDJfy0iXjAhGJZAy3xGWYFOLr/rQkiiF1SPy1tyHn44fFSORfYjmMe1ca8NPRc9dk GNpCMnbDbxBob+SOmMd1jn6RR3IwV50lo3VKtKxgXhSZlZ5ly0XlCejucsZF3lTA7y uz8iZvQ7UWE45xx/45GJ/uWo2cnSgqZlOzXuH5PxggJwo/3Cc17LXcRGkNDfqbYMiN YDMT1eOBJyqooOjpMglM21YUZ7rlKogyC1kZOXx2SHfE/8o2mR+TAMsme6JrNUG8fi hDEjxvxovn3Fg== From: Bjorn Helgaas To: Rob Herring Cc: "David S . Miller" , Andreas Larsson , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Subject: [PATCH v2 2/4] PCI: of: Drop 'No bus range found' message Date: Mon, 13 Jan 2025 17:15:55 -0600 Message-Id: <20250113231557.441289-3-helgaas@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250113231557.441289-1-helgaas@kernel.org> References: <20250113231557.441289-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bjorn Helgaas The typical bus range for a host bridge is [bus 00-ff], and devm_of_pci_get_host_bridge_resources() defaults to that unless DT contains a "bus-range" property. devm_of_pci_get_host_bridge_resources() previously emitted a message when there was no "bus-range" property, but that seems unnecessary for this common situation. Remove the message. Signed-off-by: Bjorn Helgaas Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/pci/of.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/of.c b/drivers/pci/of.c index 2f579b691f8e..48b9274b846e 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -346,8 +346,6 @@ static int devm_of_pci_get_host_bridge_resources(struct device *dev, bus_range->start = busno; bus_range->end = bus_max; bus_range->flags = IORESOURCE_BUS; - dev_info(dev, " No bus range found for %pOF, using %pR\n", - dev_node, bus_range); } else { if (bus_range->end > bus_range->start + bus_max) bus_range->end = bus_range->start + bus_max; From patchwork Mon Jan 13 23:15:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13938221 X-Patchwork-Delegate: bhelgaas@google.com Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0884D1FA8C3; Mon, 13 Jan 2025 23:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736810168; cv=none; b=sjXXNSvcxGiyl8Ywz+uRNMk22ITkiS0U1gTgfolaxVx+zcJFzAjMI+UUX+OOt0AWJCfORPvgMkFlQp+0QVGOH4S+Xj3H9J2wGQW714NxplcppAH7AACgSij+SHht0rFWrJG4YJmRXVeqNY7zqC9KAqJFRe5fZSkUA96qEUW9sRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736810168; c=relaxed/simple; bh=v1mS/gitgZcQKO+LBDc6/XGqUnicGeeNQepGI6TNS0Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FmkeyL59DPZwkxzJFR+aqtKodOExV3ETuKWv+Z4DHdosSuf7AXb7xx3ScDJRm9Bxy3dN+P3EOlVps85/WHgLs2xSMZD5LwwIAJAVW293I3zul5ADZqdoQ0a5cqZuviZ1Q+lWFwmQoA1p+oLcIt6YIjcRJGEn4c1nocfL4wAwbBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=anx6QIs1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="anx6QIs1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB6D9C4CEE2; Mon, 13 Jan 2025 23:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736810167; bh=v1mS/gitgZcQKO+LBDc6/XGqUnicGeeNQepGI6TNS0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=anx6QIs1oxoTknp6/h7OoEy7M1yY1A6GkWOxXXeWB2EmiA+XAzI7einz0DnKjOVoQ 9ekqAPzMJzKPzGYak/TgKPmEvHVauOl9VPzFLjDdOZQnIN84yUQyd0+NTqEwOYHqJS RML/YR0ZcFpWlljUYS1eSH9rZRAI6sSL24pG/ACtm2ybjquXGOmn0cS6LiNWtgXIZd RxH3YqJ9J6/hwSfXwy8Zakzg7tcX9LOg2RuKYN1Rgt60uPcVvPlBWbdTrK/33y+tNR e+nLYb8VUAx+9ndLv2KnSvTozlyuzhgK9wy7UFt38NEHvmpHIMNgRYfTgr+jytyaHp FVS/TZBag4CdQ== From: Bjorn Helgaas To: Rob Herring Cc: "David S . Miller" , Andreas Larsson , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Subject: [PATCH v2 3/4] PCI: of: Simplify devm_of_pci_get_host_bridge_resources() interface Date: Mon, 13 Jan 2025 17:15:56 -0600 Message-Id: <20250113231557.441289-4-helgaas@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250113231557.441289-1-helgaas@kernel.org> References: <20250113231557.441289-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bjorn Helgaas Previously pci_parse_request_of_pci_ranges() supplied the default bus range to devm_of_pci_get_host_bridge_resources(), but that function is static and has no other callers, so there's no reason to complicate its interface by passing the default bus range. Drop the busno and bus_max parameters and use 0x0 and 0xff directly in devm_of_pci_get_host_bridge_resources(). Signed-off-by: Bjorn Helgaas --- drivers/pci/of.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/pci/of.c b/drivers/pci/of.c index 48b9274b846e..a2acfc52caf4 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -302,8 +302,6 @@ EXPORT_SYMBOL_GPL(of_pci_check_probe_only); * devm_of_pci_get_host_bridge_resources() - Resource-managed parsing of PCI * host bridge resources from DT * @dev: host bridge device - * @busno: bus number associated with the bridge root bus - * @bus_max: maximum number of buses for this bridge * @resources: list where the range of resources will be added after DT parsing * @ib_resources: list where the range of inbound resources (with addresses * from 'dma-ranges') will be added after DT parsing @@ -319,7 +317,6 @@ EXPORT_SYMBOL_GPL(of_pci_check_probe_only); * value if it failed. */ static int devm_of_pci_get_host_bridge_resources(struct device *dev, - unsigned char busno, unsigned char bus_max, struct list_head *resources, struct list_head *ib_resources, resource_size_t *io_base) @@ -343,12 +340,15 @@ static int devm_of_pci_get_host_bridge_resources(struct device *dev, err = of_pci_parse_bus_range(dev_node, bus_range); if (err) { - bus_range->start = busno; - bus_range->end = bus_max; + bus_range->start = 0; + bus_range->end = 0xff; bus_range->flags = IORESOURCE_BUS; } else { - if (bus_range->end > bus_range->start + bus_max) - bus_range->end = bus_range->start + bus_max; + if (bus_range->end > 0xff) { + dev_info(dev, " Invalid end bus number in %pR, defaulting to 0xff\n", + bus_range); + bus_range->end = 0xff; + } } pci_add_resource(resources, bus_range); @@ -595,7 +595,7 @@ static int pci_parse_request_of_pci_ranges(struct device *dev, INIT_LIST_HEAD(&bridge->windows); INIT_LIST_HEAD(&bridge->dma_ranges); - err = devm_of_pci_get_host_bridge_resources(dev, 0, 0xff, &bridge->windows, + err = devm_of_pci_get_host_bridge_resources(dev, &bridge->windows, &bridge->dma_ranges, &iobase); if (err) return err; From patchwork Mon Jan 13 23:15:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13938222 X-Patchwork-Delegate: bhelgaas@google.com Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899531FA827; Mon, 13 Jan 2025 23:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736810169; cv=none; b=cTmp7uuvx1D/d8x/g88oa173JKHp1Wj40UG02E/HcTd1chetDK39G2ZvTUmXZSTNKCNWAS5C0z7wYNkBFyzKrILx4fKEtdxcg3KwU1xxtw4+ASWtxVeZHz2/rCQ6ee6htXn5UCKe4J2YX0tUe9CowZxSqIjZd8Fr8ff1QGRLNuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736810169; c=relaxed/simple; bh=THCOc+6FhZ0Ytb1uKtGAy7Kq8WlBqzKDbLOKYQldIPE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ur2oUhveGdsPRxFkllM6sQmsE40WXpIn71KN+hJ95nJF6FaluEDVGIdRzbLMyu2QdUz60e9STjinugLAfa4fdGq1ksDxft87Ri+HwenQJFDaKmWlegKa74NqJOby+y9kOqEBNHX0jIX0pZ7HYfI6ErnNGFcdd6WCRFlRAe0SqXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cD1EB+uS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cD1EB+uS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46885C4CEEA; Mon, 13 Jan 2025 23:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736810169; bh=THCOc+6FhZ0Ytb1uKtGAy7Kq8WlBqzKDbLOKYQldIPE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cD1EB+uSpXwfHZ9Xm3u0gJv7DkooqWP544zNM6/rgOer0bnHJ2PXcKpaZGq2uZkpG FadackyBCRSYs0VCjI8hTHjO9VHl6d3d3Bki1V821YguHB0v5hCtgwUjTEe/fk/9lo +cBKqhMnOIi4lRiMr4fTrm1OQ65iQLEbp8P48JxxeDLQSBN8+MNLKhj+/wXidVwKSG do/Zcs+IQQKRihi1bFz7c84hbI8Ddnc8M13ks7A4iCaiHAEFB7pUNYDiUCDgznhR6b lw7Uz0jqrNcMnCtwgb4tq9D81p7UCjwoO8aj8nNufWkuHREZaz/1tmrd36ERVqb9fJ P/u4889RNmVHw== From: Bjorn Helgaas To: Rob Herring Cc: "David S . Miller" , Andreas Larsson , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Subject: [PATCH v2 4/4] sparc/PCI: Update reference to devm_of_pci_get_host_bridge_resources() Date: Mon, 13 Jan 2025 17:15:57 -0600 Message-Id: <20250113231557.441289-5-helgaas@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250113231557.441289-1-helgaas@kernel.org> References: <20250113231557.441289-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bjorn Helgaas 5bd51b35c7cb ("PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()") converted and renamed of_pci_get_host_bridge_resources(). Update the comment reference to match. Signed-off-by: Bjorn Helgaas Acked-by: Andreas Larsson Reviewed-by: Kuppuswamy Sathyanarayanan --- arch/sparc/kernel/pci_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/pci_common.c b/arch/sparc/kernel/pci_common.c index 5eeec9ad6845..2576f4f31309 100644 --- a/arch/sparc/kernel/pci_common.c +++ b/arch/sparc/kernel/pci_common.c @@ -361,7 +361,7 @@ void pci_determine_mem_io_space(struct pci_pbm_info *pbm) int i, saw_mem, saw_io; int num_pbm_ranges; - /* Corresponding generic code in of_pci_get_host_bridge_resources() */ + /* Corresponds to generic devm_of_pci_get_host_bridge_resources() */ saw_mem = saw_io = 0; pbm_ranges = of_get_property(pbm->op->dev.of_node, "ranges", &i);