From patchwork Tue Jan 14 09:36:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Chien X-Patchwork-Id: 13938554 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46B80E77188 for ; Tue, 14 Jan 2025 09:38:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tXdMS-0000U8-CB; Tue, 14 Jan 2025 04:37:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXdMH-0000T7-Gi for qemu-devel@nongnu.org; Tue, 14 Jan 2025 04:37:13 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tXdME-000509-HF for qemu-devel@nongnu.org; Tue, 14 Jan 2025 04:37:13 -0500 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2162c0f6a39so111545715ad.0 for ; Tue, 14 Jan 2025 01:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1736847427; x=1737452227; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=w/J421GUH7Mao74hk7jOCSi+yLl4BP1uUp1Mb4ir/rU=; b=Uol8f4mQYZ25V2K4DaE0M9oBhMeRhsffkvy61/KQBLBI44dIAyMHFwHJwGpyj0Cn6/ BEh8EUe6HNp8f0p0bjh4rU+fS2WUo00wwEgH0YNGXGUdk2SaLvIzd7eLLUZKmh9Dj+CU WA89DM/YnGZv5MyaDV0whW5R6VwmxQpFas4sV1rlqtURXqxJwgZiQp5W2yxFRa+EMyWe r/TqCwfPooSiRx172fp6q/gL9S+PbQBLdFZU4vbrL5C2zv9aU+oLYeniI+XQx1r2HO9v OaiFmo+PvR3vosxXy1rFZ2eg9ebur6AT2SSUV/tOg6FLrhp8BVfABCtQWXiHWLT0QZJR d/Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736847427; x=1737452227; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w/J421GUH7Mao74hk7jOCSi+yLl4BP1uUp1Mb4ir/rU=; b=k2zmjVRM4VgJJFIwtamzQi+tbTSlV2Fnw69UOwqfDhK9nrt6i28F+1yycxVOvU3NBa awzV/G8Jhcn+3SvAhmj5g3Y1zw2gNLoktm5s3oNwq/kCbEAl3Hh9IGhrDFWQbITqm5X4 HOzROR1mCXMgkenYR5ZoRol60YRtdl72b+7cJHXFGFWCBPlqgVnrR7Aur9d5IN4NwxjW XT8qxnL7SMLLQ7Ej2PWVeXy15gvf9hHitWFevCjS0450KHiB6LN02V57K2Th31Blguvn H88KzzGVEkALBN8Zti/L1qzN7jbvBr7CfAlSCLcuf8nSwz9C7Xv+SwoJhGDHnQBVt536 M6EA== X-Gm-Message-State: AOJu0YyJB7ALuAvMmJhSrvvUdk9GchIedg2ppo8w7ORPID1G98005Z7Z OWRzxyuVN4zWeg5vvcDshjzwJTU/yOpAXBdyZduQ6qv4ts6yRanrauv/x8VyB50M1UnhDB3z6Ge hjx5EPJu7jmV7wGLgqsl1Vccb0vwrJzOn/ORbfEkP8fOgS2zF5GTZySJZ4NzzqIdK1Th/gv5QZu FafDbMXR4gXGeeusRoTfX26o9jUoyhZTlXkQJhC3w= X-Gm-Gg: ASbGncueUmn3nzTDFbPJwWlkpqQcRJwwSSgcE2ch2eaB6HAcuNp7gqppfQfL1TJJxh4 gP8oQLdg3cUcF7AKqqYEuGPkPTVyztHvhLTEIn6fxk57uAO9U70rguus/NcWepi+iJlOEZQXxNq 0bGblFFFxhTqYd2s0RKbai46zi6sp3oTi4JQL4qqDkpTvv3Ybxy/GqYGD+URdIX37WZMbDEBYHb tts989Ix/d61MKBvnjCRqfiIaoiIWvajKQzJyJrtBEDw9wqQgSJHzlZRA441Jciu+2mHJE5nMk5 0VPoVG48 X-Google-Smtp-Source: AGHT+IEfFytGMS3sZIXK8rwGevqErUOvVDSCaSQoav987u4WTQMho52KEY473oivczemVOQpz5iZhw== X-Received: by 2002:a05:6a20:c896:b0:1e1:ad7:3282 with SMTP id adf61e73a8af0-1e8b13d1ed6mr27046085637.7.1736847427183; Tue, 14 Jan 2025 01:37:07 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d40658dccsm7300718b3a.92.2025.01.14.01.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 01:37:06 -0800 (PST) From: Jason Chien To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Jason Chien Subject: [PATCH 1/2] hw/riscv/riscv-iommu: Remove redundant variables Date: Tue, 14 Jan 2025 17:36:45 +0800 Message-ID: <20250114093647.4952-1-jason.chien@sifive.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=jason.chien@sifive.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Signed-off-by: Jason Chien Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones --- hw/riscv/riscv-iommu.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/riscv/riscv-iommu.h b/hw/riscv/riscv-iommu.h index 9424989df4..fa8a50fa24 100644 --- a/hw/riscv/riscv-iommu.h +++ b/hw/riscv/riscv-iommu.h @@ -58,11 +58,6 @@ struct RISCVIOMMUState { /* interrupt notifier */ void (*notify)(RISCVIOMMUState *iommu, unsigned vector); - /* IOMMU State Machine */ - QemuThread core_proc; /* Background processing thread */ - QemuCond core_cond; /* Background processing wake up signal */ - unsigned core_exec; /* Processing thread execution actions */ - /* IOMMU target address space */ AddressSpace *target_as; MemoryRegion *target_mr; From patchwork Tue Jan 14 09:36:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Chien X-Patchwork-Id: 13938555 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6304DE77188 for ; Tue, 14 Jan 2025 09:38:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tXdMa-0000XJ-Rr; Tue, 14 Jan 2025 04:37:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tXdMN-0000U9-8x for qemu-devel@nongnu.org; Tue, 14 Jan 2025 04:37:21 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tXdML-00050m-Nk for qemu-devel@nongnu.org; Tue, 14 Jan 2025 04:37:18 -0500 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-21634338cfdso80546055ad.2 for ; Tue, 14 Jan 2025 01:37:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1736847436; x=1737452236; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B9/JjQJ3HM6kitYi8wCHcCHbHqMkmYFZQmnTTQp1QYM=; b=GE1p3/GL4up3rYQvpcQFDMgczg1x+X7zCx2NLLm+j/sCJ9fbaXXMMO+uZy4bXOSNh+ HpX2Vo3Jv4NwvwMJD/7vv4XgAQzkqlefmSV3XXSkf0UntKyMmifVyT61k6OEEmhncx2Q CVmBsEqSpjjERzTY4vO4vCjTv+ZBnZGlPATQV7lIgAvZx+DXKi24u9sjtcYK62czz3cC AjPz9Opa2ff9dFAI/vSw1d6IyovwB+0b7//ACvZnvuPO75mnQoKgA/pw/fMXhW4Zyfz/ Vf1opo8pNox3xDJPp3LTEYM1JEsawLUvCu6y7EwLCFEV8Cz8hgAzKSPZB4eqeigiViSF uVcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736847436; x=1737452236; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B9/JjQJ3HM6kitYi8wCHcCHbHqMkmYFZQmnTTQp1QYM=; b=DbyqmLsRbfvyhjnDhzyWCot0t7orI8B+B78sNnDmzf4RSMm9lX/h+xj79Ov3HpKXPQ 0Gf9d2J4EOO5RFVeGQvy4x3ePbtVmFrZDdJCIUB2iZNfG0DwkjU8i7OwF3wxaGfrRUIt ybtFGRO+K5e1efL7FWkjaKulTDSWI+1wSner4LawF5cQdy8zraGigYRjZPxJ//GXVze7 iMWu1dQD/ETMQuTv+BSgr90A/A6SN1UY56YIzbdkWTf9mJZJYURsH9IQXwQloGOrbB43 PigLaMr+7RauYsmsTWwKcLeqzgIePQNjWdbCsDwyEAjSWYiBUeB+wie6d+4WW5MTmcMw vxXQ== X-Gm-Message-State: AOJu0YxmW+MyQ5ZFxT6HO2chbZfGEEwxzO9VzMT+vXR6eh4r9bqb0Vo8 HXnshFDd5PQOL3KLkzCGkZol1gK1V9CmYRR8JEgx5HVAAGwedDJFzBnaXzOwhtHK4SPBRoyGnVI IS2obQLSuwcOfPul6ULiNqB8azLMEKgsLq7jS9b9H7Xx0KyYNz36OZGIAe1poMnU5lmPCpUxOO4 ehJ2wkW7z/aK/LsXnZugtkhY27wluAv7A7hq7bLdk= X-Gm-Gg: ASbGncuXqPj3oi9Y/3ifdOnGJM/n4/AljVX+9zyTqPwx/Iaau1d13FLhIMEdCxLXFER /WxB2xSyVoOCULXeUCn6QAYyvsCWtmy1q576hSz/EWixP2pu9jr9YXsPI7Z2C16y7XThOqrnYui m+DOz5Y55zTmNhewrEGYvBurBd11iZVPejoBLk9pPnFuqcGugE8y1e4k7WQlGz8i2CVyp5DKEUx 91Ywf2IBxXVn5QX4U1As/Oo7dnpHDSLQy/q3DXvaodA5M2d2KpkkY3lrHsjwri0kcSmtRpfByk1 6pWFce9F X-Google-Smtp-Source: AGHT+IFD9TBPDpKn2f1NoqV+RF4ZoiMvkPpQe4Nq4LFizSjzfngGhWTa3m/DV7J6HDA5e54bt+tbyg== X-Received: by 2002:aa7:888c:0:b0:725:df1a:275 with SMTP id d2e1a72fcca58-72d21ff51e4mr36320676b3a.23.1736847435587; Tue, 14 Jan 2025 01:37:15 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d40658dccsm7300718b3a.92.2025.01.14.01.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 01:37:15 -0800 (PST) From: Jason Chien To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Jason Chien Subject: [PATCH 2/2] hw/riscv/riscv-iommu-bits: Remove redundant definitions Date: Tue, 14 Jan 2025 17:36:46 +0800 Message-ID: <20250114093647.4952-2-jason.chien@sifive.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20250114093647.4952-1-jason.chien@sifive.com> References: <20250114093647.4952-1-jason.chien@sifive.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=jason.chien@sifive.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UPPERCASE_50_75=0.008 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Signed-off-by: Jason Chien Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones --- hw/riscv/riscv-iommu-bits.h | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/hw/riscv/riscv-iommu-bits.h b/hw/riscv/riscv-iommu-bits.h index 485f36b9c9..de599b80d6 100644 --- a/hw/riscv/riscv-iommu-bits.h +++ b/hw/riscv/riscv-iommu-bits.h @@ -50,8 +50,14 @@ struct riscv_iommu_pq_record { #define RISCV_IOMMU_PREQ_HDR_PRIV BIT_ULL(33) #define RISCV_IOMMU_PREQ_HDR_EXEC BIT_ULL(34) #define RISCV_IOMMU_PREQ_HDR_DID GENMASK_ULL(63, 40) + /* Payload fields */ +#define RISCV_IOMMU_PREQ_PAYLOAD_R BIT_ULL(0) +#define RISCV_IOMMU_PREQ_PAYLOAD_W BIT_ULL(1) +#define RISCV_IOMMU_PREQ_PAYLOAD_L BIT_ULL(2) #define RISCV_IOMMU_PREQ_PAYLOAD_M GENMASK_ULL(2, 0) +#define RISCV_IOMMU_PREQ_PRG_INDEX GENMASK_ULL(11, 3) +#define RISCV_IOMMU_PREQ_UADDR GENMASK_ULL(63, 12) /* Common field positions */ #define RISCV_IOMMU_PPN_FIELD GENMASK_ULL(53, 10) @@ -382,22 +388,6 @@ enum riscv_iommu_fq_ttypes { RISCV_IOMMU_FW_TTYPE_PCIE_MSG_REQ = 9, }; -/* Header fields */ -#define RISCV_IOMMU_PREQ_HDR_PID GENMASK_ULL(31, 12) -#define RISCV_IOMMU_PREQ_HDR_PV BIT_ULL(32) -#define RISCV_IOMMU_PREQ_HDR_PRIV BIT_ULL(33) -#define RISCV_IOMMU_PREQ_HDR_EXEC BIT_ULL(34) -#define RISCV_IOMMU_PREQ_HDR_DID GENMASK_ULL(63, 40) - -/* Payload fields */ -#define RISCV_IOMMU_PREQ_PAYLOAD_R BIT_ULL(0) -#define RISCV_IOMMU_PREQ_PAYLOAD_W BIT_ULL(1) -#define RISCV_IOMMU_PREQ_PAYLOAD_L BIT_ULL(2) -#define RISCV_IOMMU_PREQ_PAYLOAD_M GENMASK_ULL(2, 0) -#define RISCV_IOMMU_PREQ_PRG_INDEX GENMASK_ULL(11, 3) -#define RISCV_IOMMU_PREQ_UADDR GENMASK_ULL(63, 12) - - /* * struct riscv_iommu_msi_pte - MSI Page Table Entry */