From patchwork Wed Jan 15 04:16:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuntao Wang X-Patchwork-Id: 13939828 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BC05C02180 for ; Wed, 15 Jan 2025 04:17:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F76B280001; Tue, 14 Jan 2025 23:17:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A7B86B0089; Tue, 14 Jan 2025 23:17:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09715280001; Tue, 14 Jan 2025 23:17:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E10A36B0088 for ; Tue, 14 Jan 2025 23:17:17 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8703DAF5BF for ; Wed, 15 Jan 2025 04:17:17 +0000 (UTC) X-FDA: 83008376514.04.39A563B Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf09.hostedemail.com (Postfix) with ESMTP id D9E2A14000C for ; Wed, 15 Jan 2025 04:17:15 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EJGlp4W3; spf=pass (imf09.hostedemail.com: domain of yuntao.wang@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=yuntao.wang@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736914636; a=rsa-sha256; cv=none; b=ZiS+qOU9vCvN8l8/Vbhih539tOZpVqJswhNVw/x4qgycwARS/zXOZAaXW6FWbR5C5FqcY6 iktCFRuZ0kxzWHL+mto+4J6Bh4yLPbEXJNAXGlwbwSirR+rS4YgGgDvHlirlHZBZMxEeTu 5LmaFYqhHaQmYrFN5MSDlHLH+EzCbL0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EJGlp4W3; spf=pass (imf09.hostedemail.com: domain of yuntao.wang@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=yuntao.wang@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736914636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=JdFpeBw9FNCn+nyVTPYmxKLD8Uqyow1gj92jnx8VEF4=; b=ApkZ427/isZgkVnqYuOB/S4VWSxTaTwjY6A7R0lJv0avTSj0SmTfV5UGOHw8aGGG4w7SQI MCPumEq/CIc9+R72hOI/+HREyAj67bePkYNNYTRNmDTFYuCNyMEHMXcNSJID2Gk73adcnf NNvJ3KItdYGeKHUTywzKXpfb22f1JOA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736914634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JdFpeBw9FNCn+nyVTPYmxKLD8Uqyow1gj92jnx8VEF4=; b=EJGlp4W3gaQX9s1GFyLxTHw+NoR5b/SvAPQOrUbSp6ywmEuclSZCUXhmMHPQBFsx1U+wYo WjJSPvtGfpXl6EwMoYv9W816AKhCJdTAr0ez2VG4lPj229SZ+bF6lE0P+6afdDeNxUdEoD mKO9siwGq2sIStKhKhUA5j2e4V8AVL8= From: Yuntao Wang To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yuntao Wang Subject: [PATCH] mm/page_alloc: Remove the incorrect and misleading comment Date: Wed, 15 Jan 2025 12:16:34 +0800 Message-ID: <20250115041634.63387-1-yuntao.wang@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: D9E2A14000C X-Stat-Signature: nxsx6dktwuauhnff6h7jh16aeoiih4h1 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736914635-616085 X-HE-Meta: U2FsdGVkX1+wyjmtgLfuMn3q3O0+E0I8K58w/ZRUapskLIiyogOO/XcKw6ox/9ePgS6AUxbxs0udKy2kqKn67N2E+NuO1ORN2EMMcn/b3bPnz3a0LvKPeM97vrgAVe6aiu1jg1iULGMCb9VU770FGVcEAl6qRQjKf8HPXnmPLkPdzky5Sk70O2jdYiPLLeU/tSBhGt3Wtrti6GwglCDn0qboOPrh1NSAaSw+UBuT10WPnfgNZCIlwS3Ii6A3iX/5CFQmAsg11p7GqXsbOmCPPz6xthp4kXPRimZbiDtFGPhQ8JnFIFFcV+d8poBZZXQohnj2Toh3g9HleqHPPKO+Zu2lstm3QvhGDywQ5+CvABv3rtRp2RLrRA8TsZeL3cmrRgfoM0CPKNS/kcMcxXPIs9Si+hrCv0UxuiAfgof35VQcbonz2FWQaFq9dmG5mJTUBHbk3qfX/7I6pMSZWmqMqhMtzs4G4asuzodVN7letwsIm93OU8AgZdFdb00nugklSd7JfU72gCQIqdapHcxExLWmUGKQ6UIp6G9IjSIQ6Bq2NC1wpJkgrUhIRP2a9UwCTBXK7QTNO3mlZbnuGouh2Stxri+hXa/NSCh70dyjlbJd7RpI3fe4IRZRoEQlsDZ41YVG+0INa5wVjBOuQKOiGzvE2L0aj6YkCVLu3S4zHnH6rx9bVVmNx0/M6TNZztYi5EZU4J501b1T35Rrv1sqIlnmhVDw4/ZBIXhVmuI4b1lI+yX9cQwPK6Nloi/gr3zdWbhHwhwD/K2/LedyzITJ66KAp/bfsQnScKvUB2UDO97Q27TaGY8Ibvb+8h504VLlDPlEBl8aPLeQa0MtRCMwipb55CivIqzy+FnzLlJ4nrDf7OOM4JxTp9/y35E9wWVVwrsjT58tsgRZ0eGGiJKo6hrNf8zVpo7Wg85yr7WgDyf3wwo8t86s64YAHvCzatXTYMKtmzVUZiQa/Do78A2 efaPHaOd y6nWYnYrUYbg22htBMPMsNFYhTewseXjWgHQV3vuAX2eO5E8aDGQdrsRF1G2nM7qQ4E/EvDEbmpZxhSSz7Sc9ILqr5qzLu1QoJNdUK5vK0tCUhTUpeSvVmbUVvcz3nO5fBK66ojKCs9+hXXPvlk98AW/DPy5BMeJpp4tBq2m/yOicpQdC4g3WxwAb7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comment removed in this patch originally belonged to the build_zonelists_in_zone_order() function, which was introduced by commit f0c0b2b808f2 ("change zonelist order: zonelist order selection logic"). Later, commit c9bff3eebc09 ("mm, page_alloc: rip out ZONELIST_ORDER_ZONE") removed build_zonelists_in_zone_order() but left its comment behind. Subsequently, commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization") moved the node_order variable into build_zonelists(), making the comment originally belonged to build_zonelists_in_zone_order() appear as if it were part of build_zonelists(). Remove this misleading comment. Signed-off-by: Yuntao Wang --- mm/page_alloc.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index cae7b93864c2..ff23296e30dc 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5161,13 +5161,6 @@ static void build_thisnode_zonelists(pg_data_t *pgdat) zonerefs->zone_idx = 0; } -/* - * Build zonelists ordered by zone and nodes within zones. - * This results in conserving DMA zone[s] until all Normal memory is - * exhausted, but results in overflowing to remote node while memory - * may still exist in local DMA zone. - */ - static void build_zonelists(pg_data_t *pgdat) { static int node_order[MAX_NUMNODES];