From patchwork Thu Jan 16 16:24:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Stevenson X-Patchwork-Id: 13941936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4C61C02183 for ; Thu, 16 Jan 2025 16:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OVz8bC00NcJv/IZ0bhV7772W619cZqGGdaBgIBaPg8g=; b=QCqMGISnWLwQARzf4Fpr8FAuQU 5S8chU5MFRhQkFbhCoEhOR+o4DwCwfhqmSK78mVTNRIUAIRqHHjj1TxStOUXRDciGT8Ips3pMtJnW hF5EG2+WvrmsUIElE5rtfZEvt8J32Rmy75IEbibgh6oZGDKhrUyGPCVJOJ1uB0D72d7VsX6tSL97J k/4zS+XelUSg2kmWoffXjNm0SA0l0cJ3agFZ5jU4ES+aaQqNrr7cMziaMZbGvFgstAvfKTxWjgl7B dzN/330RrCUjTKCBvIXi6bENYidYohX2+8KGVtq6WuSnKcZ4KafgzsDj973HucAt4RsQiKQl0yPO9 wbSInaOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYSho-0000000FW9n-3rxA; Thu, 16 Jan 2025 16:26:52 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYSfH-0000000FVRF-1EiS for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2025 16:24:17 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-436a39e4891so7512925e9.1 for ; Thu, 16 Jan 2025 08:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1737044653; x=1737649453; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OVz8bC00NcJv/IZ0bhV7772W619cZqGGdaBgIBaPg8g=; b=J913Avw1IMpA/8m9QV+2T9wOm/SCcOg0NdsSRc5D6Tp7eFr0cn4nJH6WeHydAzVzv6 gIrFh/OrrLhYeN/+7/2/OAYoaZG8bC9efpy6KQxjcRA2YuCBdHrvTd/+ytlBIr69175W zJskSy3hqQAIslF9y/x2ij5JKLjVGbQmy2eNcr5SwbxEYl95AMtiCAaLGP03H/ElVV+5 Lwo5D/ZMmzi/engZrAcoo4+vSAM6uhZOWIHA9IjPCg6AYzFYcLR95bFATJVxhUQ8D2GQ sFwKLOeUuqQUiGoaNnTxt+0AKVSJGk6z+0cQPhkiPtXeUbBeaSZSkQvHtk/rTWgojCgo WQjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737044653; x=1737649453; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OVz8bC00NcJv/IZ0bhV7772W619cZqGGdaBgIBaPg8g=; b=RwvwoRr0evxJFvUOItsBLQEgYEVLZOrMyIIJm4wI8YOVc/zA8otPAz8yTQkwW7vx04 mWo1W84Fq0EIiOk9140C2G08AZ5zU+xoxEqUyT6LecaRQUa83AGEHvW9Km09p0uyzQ9t MFS+AcGv/jY/FrwpFyhamEFDm6Da4GjggYilB9XFy9k52dU1bakPHlHNuLm7xZvK/0Rq xYsF6jdXMIBmlSa9d6In1V+lcf5KF9JOLY+chg5+oXYADt5U6mhUjL0qnKIEr8qOHrb6 DD0Gbt6krFbzRJ30bbjbmXHH2juJxdH/TBnEfid20UVImBLpMPKgQTNbTexBd3O5CFnF lBlg== X-Forwarded-Encrypted: i=1; AJvYcCUm/Or56GNqSrT9ypzTJH8JLVHgKKU+54ivm66SNfeRnFYIz8J/bC/m/1X44ZcfKumsXBkCVSjKFg4Ab7BGX6Bm@lists.infradead.org X-Gm-Message-State: AOJu0YwT+iylOquI2fHwID138/7nkOKJjoCwhb9UtR2V5rRY3sABvRYK hD3qjrpZmQauS4YdTZWpbzI0Ffg6kvq2b++5N/jsczMzCqIjvxtaNZQUQJ2eKTF6V2OPm5+YAz/ s X-Gm-Gg: ASbGncuatprtkYzyQBhD+1JKd7K0aYIr7USAApRXAI2CqBTfYlfhYeoaGUq0qPCvPml F7mqnYqwmMzbHTxYBj+Y/t7wVHChAiqfiVySL96TwQLGtftcXxEYtQhGaZr3h0ociOkycFcIAL9 2JNcBkgYPyC+BleuKOZBJ0RhhaBehpxfKcG2ZJ3bl/OCvHdPcSvlzCFY8XbyO+NJJenuqOljU7n JxkOV0JMOVxobF/9F7bL/PEsYIT08y4/R4mfocbUBX3dxzp X-Google-Smtp-Source: AGHT+IFsOpMBJ93/MMR+dU+EaZC/TmrWLHZaiOoyuDyhD3Z2W0qeIr52x3Uzv4hcGCmCAktAv12ABA== X-Received: by 2002:a05:600c:468f:b0:431:52f5:f48d with SMTP id 5b1f17b1804b1-436e26ebe46mr326154805e9.31.1737044653375; Thu, 16 Jan 2025 08:24:13 -0800 (PST) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43890469ba8sm3715955e9.37.2025.01.16.08.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 08:24:12 -0800 (PST) From: Dave Stevenson Date: Thu, 16 Jan 2025 16:24:08 +0000 Subject: [PATCH 1/5] clk: bcm: rpi: Add ISP to exported clocks MIME-Version: 1.0 Message-Id: <20250116-bcm2712-clk-updates-v1-1-10bc92ffbf41@raspberrypi.com> References: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> In-Reply-To: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Dom Cobley X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_082415_323923_341D1458 X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dom Cobley The ISP clock can be controlled by the driver, so register it with the clock subsystem. Acked-by: Stephen Boyd Signed-off-by: Dom Cobley Signed-off-by: Dave Stevenson Reviewed-by: Florian Fainelli --- drivers/clk/bcm/clk-raspberrypi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index a18a8768feb4..6d5ee1cddded 100644 --- a/drivers/clk/bcm/clk-raspberrypi.c +++ b/drivers/clk/bcm/clk-raspberrypi.c @@ -118,6 +118,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = { [RPI_FIRMWARE_HEVC_CLK_ID] = { .export = true, }, + [RPI_FIRMWARE_ISP_CLK_ID] = { + .export = true, + }, [RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = { .export = true, }, From patchwork Thu Jan 16 16:24:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Stevenson X-Patchwork-Id: 13941937 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F20DC02183 for ; Thu, 16 Jan 2025 16:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MZrp7lu3ubP7SKqqGTTc2bgd5NE4OnqPzvBDDl400Q4=; b=r2l7ZBmfjsP8ql0hrgTfudz7cj j1T0bInqXwx2J1ddFnXSuLifcBa+SBT1wb/zUOt5sGXk6lviGK//BuIN0A1befBD4JjOko1umVw+D tCWYZTmXPu1z5fDweUXvb5W0fV0AnR/LL8csRwRPJNRcswb1hpf6ZNrizRC+fBKbwnFSIUJfSD3nD wICo6vDhiF3lvxnnfddWwOd80Zjad0V1C2G70z+7eqbqPE83JUCXFvr8iUuMepZntX232CbJMFWhV Swq8bjHzUO62Kx+SZ016MuTtrLFEKJNeu9CabNF6mynFcvL0R/ROt4LcpPc1cha+Vk9suJO3xYy7/ 81d0SVKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYSj3-0000000FWWH-2Ogd; Thu, 16 Jan 2025 16:28:09 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYSfI-0000000FVSB-341e for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2025 16:24:17 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-43634b570c1so7670635e9.0 for ; Thu, 16 Jan 2025 08:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1737044655; x=1737649455; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MZrp7lu3ubP7SKqqGTTc2bgd5NE4OnqPzvBDDl400Q4=; b=Jp+pTSAuR4AyzfzTvB3qIy2W00hE0gBprf26e1uFhLT2rezxrye7QCnp9njLNsUmVp GU9hj1R3lSUy9J33hCpczeYjnAB+AxZGul2SaXHwM0SnhR8LvSpNqHviZ1qWUBc0ZrMS 3oXCM0InMvJUzOV6KN74FCi4kpQZOMfTf/nL+ytwuMs7WVclr4DPrs1ttmDJwiU6OPIB Djm11XSCYsCZvOWLCBJ5LzzW/SwLy9D8ROXrRc1b9mozovo3B1dxlmq+KwbMDeC75o// FgrCLGAHb8yAqa1MbQW2IK3VXg0QX6KlGJsljUznLY9PlyXSYkgHLpBVPvDVIOas2vaF rAZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737044655; x=1737649455; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MZrp7lu3ubP7SKqqGTTc2bgd5NE4OnqPzvBDDl400Q4=; b=OIa1MXWS2cMX3xV+pX20Hi1LvBSV3M8uCCf9HkSd2bH8zSTUUx6fg/VAWIsoosL+4w dwboQ/K7tqv32TbHnytYnQt2zKIIeg9V6v4SqZ/hbqw9A6HKjuni42T6GwjWbCVQ0Qu7 UDlmP0H6goWlN/n7B6aTmDOJ0gDoqa3FN3MjCy2uclYOhWsWWobhpDV6tN8MB+lmeGhy o0mSruM774q5apm5ljIVMdc3QD++wveqAK2fSuc7ecsO5Sokwj5nxXH/KTysQtoVOAcm Joqwa6B1Vx6vNPfcNrg9fIaxUxUCfV/jSBbe3+OEenlnozBjaP/Vr6Z9QMXM89nNRhpX Jg9w== X-Forwarded-Encrypted: i=1; AJvYcCW/P9iF3YC8+4H1dJRvvYq1faxV505Qajg9OrHXEFk9vI8YfjIDmQAsdsszaCip2M7e+tp+u0b16jb/vh8IKTEC@lists.infradead.org X-Gm-Message-State: AOJu0YxR+oeXRcvyBBNtU4tGYRlijmJD6tlMDYPdln2p+ci/XVKWJs5j ER8ZbiEETQ8+VlMRV8BGXb1NcJe7n/8CbgAhT5CKoSktPv5zgA1eZlhG0YSq8shSaKT7vLwknVQ 9 X-Gm-Gg: ASbGnctbrdbj7kG0jDE8k5M2qY3SwdLxKaxSzeBoFpHMeAugGpU/mCWk3HxC0ZI48Ms 9xBlEp4eh2Y5BmGjbtO1OjEixf+iLoXFM7mReOj2OL8JYo7kXV3nNnXcpLZYfEzEHRpUV2EJXtQ +1EcDHY0rzlF7oOqmZ473GKC8qmG/iMfxaK+DzFljnUA2XMGjbKg1rZu5OcFMJ8c5iN/uMUmgLp YAhz55Td3I2WgfH+5Bq/zN1tMndSD5g+WpKOzjWerAjef25 X-Google-Smtp-Source: AGHT+IFiO4THDwrkWPkgQut59S8Z05jEzJwPXhwEqlw3rbldrlTNRXl4E+qRkkCpAywZLqr8fVkHTg== X-Received: by 2002:a05:600c:3584:b0:434:9dfe:20e6 with SMTP id 5b1f17b1804b1-436e26f47efmr243629215e9.23.1737044655043; Thu, 16 Jan 2025 08:24:15 -0800 (PST) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43890469ba8sm3715955e9.37.2025.01.16.08.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 08:24:14 -0800 (PST) From: Dave Stevenson Date: Thu, 16 Jan 2025 16:24:09 +0000 Subject: [PATCH 2/5] clk: bcm: rpi: Allow cpufreq driver to also adjust gpu clocks MIME-Version: 1.0 Message-Id: <20250116-bcm2712-clk-updates-v1-2-10bc92ffbf41@raspberrypi.com> References: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> In-Reply-To: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Dom Cobley X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_082416_759754_8C470BD7 X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dom Cobley For performance/power it is beneficial to adjust gpu clocks with arm clock. This is how the downstream cpufreq driver works Acked-by: Stephen Boyd Signed-off-by: Dom Cobley Signed-off-by: Dave Stevenson Reviewed-by: Florian Fainelli --- drivers/clk/bcm/clk-raspberrypi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 6d5ee1cddded..d374538e7108 100644 --- a/drivers/clk/bcm/clk-raspberrypi.c +++ b/drivers/clk/bcm/clk-raspberrypi.c @@ -156,7 +156,6 @@ static int raspberrypi_clock_property(struct rpi_firmware *firmware, struct raspberrypi_firmware_prop msg = { .id = cpu_to_le32(data->id), .val = cpu_to_le32(*val), - .disable_turbo = cpu_to_le32(1), }; int ret; From patchwork Thu Jan 16 16:24:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Stevenson X-Patchwork-Id: 13941954 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAB9CC02183 for ; Thu, 16 Jan 2025 16:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iqi4zrR14V9nobpcwSveNX0mOCCq13/co3EtArUhSLU=; b=oFTOaqVR0oWH0cH5LPVmsRY55Y WSLUV1nSSZZIr5Tkl4xndpYeBJLQH9l/JUHgDPQYv1igiKyHYusnToR6qoEh+NNarTBOlPP3iP0zf mkMYBYKIFI5FOjEJACh0jhukuPUSO8cscOuApkxr0qBbyg4O2gSu4VhQv5HOZFRAKi1sWqZLe0QVL YrtPFLH8eO8akh9zHMX7Yy3Rb55GeJ0jGHFKdpjWUjVeATcLm5CDtsGiYy7/7UtiWpccYDinxux6p cgCjWGW+goMdwdCaD3R4w+ZkGJF4tvHUSkaUGZzBnLQM84t0uNJG9197pCCSzCo55QqV5wJQpFj90 6i2IivMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYSkN-0000000FWpY-2tmU; Thu, 16 Jan 2025 16:29:31 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYSfJ-0000000FVSN-1jok for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2025 16:24:18 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4361f664af5so11982505e9.1 for ; Thu, 16 Jan 2025 08:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1737044656; x=1737649456; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iqi4zrR14V9nobpcwSveNX0mOCCq13/co3EtArUhSLU=; b=F9KzjD+VofBUvE2SUtXgIQlU8PFuPQAg0kbmL4LSO0qtPEOv7O2GtBLYrxnkHkmsfy Hdi6tCMAwXDni0QVKcJJf7rtvGzfl+FUuqOcwDAJ3Mkl7fjewsCa8X6CQSfVCjKv9yIt ADOLdL40F9DgUwlynNCY1tPTxHAQlg/uiTo0hrWO3yFnMSOBqSoaDloby6WnU5XDBPTC HzhDYw0zf48DGBva2tWLVi2fDZMSlJo9PsJNTnK+qNIJFF8B1INvvFHWIKu4v69IQVen hKPBnhUsDaj7esYar2h05pjO0TmqvRaejDxbFphR1ryvHy2R9YOL5d8n5fdZTKNRwpzL 2X5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737044656; x=1737649456; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iqi4zrR14V9nobpcwSveNX0mOCCq13/co3EtArUhSLU=; b=lzFZiTOBOo6ku88kYmamxTvRzxNaGgKkiUWAt5xz7ILQnXeCrXghVVePbpJ850JLdY 99aa5kZqhuxXotfEs5UVx0hjn8fCoUsXW9Aicq7G0Z+iUh0GrSdWtN2kt9ye5No8vhkS mFWMtl6BfoEdJoCo7j9s+v+sqXrR395XF/UJYJPUZFkNenVOMBxEtCpwH72g51W5+o0Y 9DBWk7eE6mfTD/V88DfirYSc1C0PTu6yyF9Ky4VmADfSBFCG3bLMWfdPIbeQdCwejltU cL0K4HeK0VI7w44r9zK6jDzjy9FeN6b4k/FIap9bFvI1yyYalLNTMVI4YGFQKy3saKek hAjA== X-Forwarded-Encrypted: i=1; AJvYcCWPKF4ewK2Aqq/xoUGT2m/HFNYiNnXi36/JB/pkXK0rPiElqxrjzjl3o25ikxzmYnS6xjpyAbi0O/28bZP/OENN@lists.infradead.org X-Gm-Message-State: AOJu0YxWyy/pmY8vbei0L/nH1HCTMNlQmKJLdkjgti19g53gniSP8jji RGfRUOkih2jlheyWd5bCNCJp6H4/eD8XUVEIgqVnHjBr1xxChXaEbkh/AQkSHVM8tQZr1wSyPd9 v X-Gm-Gg: ASbGncuPgRGXy3+nf5ph/enEn00vI1IP8sujlgeV2YvqszGQRuydV/K5YlESjonDcgu 8qZ+wFSn2IZwSRTK/02Gk11JPs03Q902VvQ6K4lQWc9TlQzHojAM3yR72sRXrgiTOyI+I70oFsB Rm9DIznHvwyWN+aIP4WrTrzpNTR6enZxEhXtSo1z39LLe7rQs5CqUbLaXu3ivrUE5PnBEGj7VE3 njAqSIYt5AdFTB1LGiRaOJj8Wz1HPdBk1ss5l6UVEqEH1Av X-Google-Smtp-Source: AGHT+IGYVMhTyECS8mk7dbNPcu0xv+jBr3muLUHN1CCOwv0ti8nhpLb9Y/RxEUO53LqAtFGOLogLig== X-Received: by 2002:a05:600c:138a:b0:434:a781:f5d5 with SMTP id 5b1f17b1804b1-436e271bcb3mr341342715e9.30.1737044655871; Thu, 16 Jan 2025 08:24:15 -0800 (PST) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43890469ba8sm3715955e9.37.2025.01.16.08.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 08:24:15 -0800 (PST) From: Dave Stevenson Date: Thu, 16 Jan 2025 16:24:10 +0000 Subject: [PATCH 3/5] clk: bcm: rpi: Enable minimize for all firmware clocks MIME-Version: 1.0 Message-Id: <20250116-bcm2712-clk-updates-v1-3-10bc92ffbf41@raspberrypi.com> References: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> In-Reply-To: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Dom Cobley X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_082417_450840_972B432D X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dom Cobley There isn't a reason not to minimise the clocks, and it saves some power. Acked-by: Stephen Boyd Signed-off-by: Dom Cobley Signed-off-by: Dave Stevenson Reviewed-by: Florian Fainelli --- drivers/clk/bcm/clk-raspberrypi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index d374538e7108..9f716b2223ae 100644 --- a/drivers/clk/bcm/clk-raspberrypi.c +++ b/drivers/clk/bcm/clk-raspberrypi.c @@ -111,21 +111,27 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = { }, [RPI_FIRMWARE_V3D_CLK_ID] = { .export = true, + .minimize = true, }, [RPI_FIRMWARE_PIXEL_CLK_ID] = { .export = true, + .minimize = true, }, [RPI_FIRMWARE_HEVC_CLK_ID] = { .export = true, + .minimize = true, }, [RPI_FIRMWARE_ISP_CLK_ID] = { .export = true, + .minimize = true, }, [RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = { .export = true, + .minimize = true, }, [RPI_FIRMWARE_VEC_CLK_ID] = { .export = true, + .minimize = true, }, }; From patchwork Thu Jan 16 16:24:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Stevenson X-Patchwork-Id: 13941955 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3868C02183 for ; Thu, 16 Jan 2025 16:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uEFDRD3uDacyEzKnD/0X8FofWYQVCs9dgJI0dD/G5mY=; b=2LnvMKMd1TDp25cpcdG+nU8Ik/ 7rho+/d0sUVv2ER2ByyYqulf3DJEH4pW+BJnvj1GyBhcIrdTqohRVCrRUq2geFNvSD8ZgCUr7ZvmN 0+05VKvpqcCdLr6HotoDY35k5LTZWdBTXu5EnxP6w1DNDq+lKxFLxkoJfFZQh8oZvMUX0n3lepf+l j8gNNI5mAgQsMlACF/9wMKTjUv7/boiKO0StVug3yuzRyBaT2WgIcnAgrTvD8j4RP07oNqTRNR4la 45rECIdx3rlijwsJ2vb5wOE63lWBmeRDX3hiIAC8nnZjbpZycTeoS5HfiYIXcT780FOaYlZDDM0pU U87smKlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYSlf-0000000FX4L-1hD7; Thu, 16 Jan 2025 16:30:51 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYSfK-0000000FVTc-3t7h for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2025 16:24:19 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-385f06d0c8eso672953f8f.0 for ; Thu, 16 Jan 2025 08:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1737044657; x=1737649457; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uEFDRD3uDacyEzKnD/0X8FofWYQVCs9dgJI0dD/G5mY=; b=UNsiGNTWjTWXYjCbE0eBEM3xogjlOp9QSUBGT7egObWPpX0wEd+1F2vDiYMgQhmckY XZVyxx9zTT9VNi6DCxypNk8ndCMAkvwXV0IKTHfUteFR9yOIomXI5eWCwxORCGCdG/bQ 3iPXuRkiKVQH7m0XplliQwJ5lFxaB3C3PMe53vbwOYXubrXF5Sr+vnzYLkMqIhyh25WH S3Z63YziCgPPpEUmK1lVzI4AOAUGPfqBf3PdE62k/gmMQSxiYlVF8M4b8z2B6+uxslG/ hOGXZ/WkyMaQpoY0pf3HkkXwMePv8fvFJOrSpXJGTkSE1Rj+2aNBAGcvcOxfnuOTcwbx IxGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737044657; x=1737649457; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uEFDRD3uDacyEzKnD/0X8FofWYQVCs9dgJI0dD/G5mY=; b=hOXgkQMKAMxL8hpTv60WbbO+cwxRcqyxi7zeqsUCPA9hKfziwaIhcSXP2Gq3k/EYZu +FNGsxQHOn4wm7fDyCVxdrP2Ovs63Jz4LuArSsJq0QKL3Ua+i37lf4Helm3IaCtTxo5y p+nExnk8jhHaQSANCx0YmzUlgFQt/P0z9k/Z32tHdX64ljq2Mq+plzYCRV8QTlZKwaq0 H8jnWNqOQazxBTtC3N7lXdU/9QrxkQpcA357j1M639z9DU7+/4O0kxDcZq+4unsQ4A+W /vaSIj3UCLXHZEiEoh8J8tTMLja+BxQOBS6zZMPABNQsKwz6stxFh4uoWnZsOxfZecpp Fa/Q== X-Forwarded-Encrypted: i=1; AJvYcCUZM9fYivy903gxgm/qvOjV3Y1LncGlkzR2da7sr/oU3FIEYMqeQOGMDtrNF4MJJ4KFgwACbu+xZJT37hc56FgG@lists.infradead.org X-Gm-Message-State: AOJu0YxAC0NhGj5uxxMT897gKi6J4pmfQSwf1DuK5k7jHLmGR7u693Ek hB6tS+cp976tXXZs4svCBAnJbK8NWo+Zp9BejYcrLI0jzFTiapxVnjwRT7dqVGaX9IG3MFTlW5V r X-Gm-Gg: ASbGncsxyNkap2akXKWD/UkZI/3icE44SmRARQvX2gJE+LswOn84JlyfDGNar3ZeMlT kNAkDsXMHS7bQV2AUvpEclrjtYi0PpL3DIwuLETnq6kfnyzGjTKqT18m18E+0Y/5iJvAA38my8A rmIQStXGP73uchQ/2SccGRssAA55RAbjMlfn9C8o0/OQYUUXR/lWJY+MhDlF8+aOCU68AqTmRS1 U/ZfMRXW4NUI1SU+X8mF9VRnQhZPn9EQFAURvYUQlc4F0iQ X-Google-Smtp-Source: AGHT+IFvRvbv+LmIOWTmcellM9NY1ElhZhfaIceOIssMpjdEdZEj6E1fUiTUX+H5C5fFTitYvcXPPQ== X-Received: by 2002:a05:6000:1844:b0:38b:d7d2:12f2 with SMTP id ffacd0b85a97d-38bd7d21481mr15783737f8f.54.1737044657080; Thu, 16 Jan 2025 08:24:17 -0800 (PST) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43890469ba8sm3715955e9.37.2025.01.16.08.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 08:24:16 -0800 (PST) From: Dave Stevenson Date: Thu, 16 Jan 2025 16:24:11 +0000 Subject: [PATCH 4/5] clk: bcm: rpi: Create helper to retrieve private data MIME-Version: 1.0 Message-Id: <20250116-bcm2712-clk-updates-v1-4-10bc92ffbf41@raspberrypi.com> References: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> In-Reply-To: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Maxime Ripard X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_082418_958374_8F51C6AA X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Maxime Ripard The RaspberryPi firmware clocks driver uses in several instances a container_of to retrieve the struct raspberrypi_clk_data from a pointer to struct clk_hw. Let's create a small function to avoid duplicating it all over the place. Acked-by: Stephen Boyd Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson Reviewed-by: Florian Fainelli --- drivers/clk/bcm/clk-raspberrypi.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 9f716b2223ae..b12d86720207 100644 --- a/drivers/clk/bcm/clk-raspberrypi.c +++ b/drivers/clk/bcm/clk-raspberrypi.c @@ -56,6 +56,12 @@ struct raspberrypi_clk_data { struct raspberrypi_clk *rpi; }; +static inline +const struct raspberrypi_clk_data *clk_hw_to_data(const struct clk_hw *hw) +{ + return container_of(hw, struct raspberrypi_clk_data, hw); +} + struct raspberrypi_clk_variant { bool export; char *clkdev; @@ -176,8 +182,7 @@ static int raspberrypi_clock_property(struct rpi_firmware *firmware, static int raspberrypi_fw_is_prepared(struct clk_hw *hw) { - struct raspberrypi_clk_data *data = - container_of(hw, struct raspberrypi_clk_data, hw); + const struct raspberrypi_clk_data *data = clk_hw_to_data(hw); struct raspberrypi_clk *rpi = data->rpi; u32 val = 0; int ret; @@ -194,8 +199,7 @@ static int raspberrypi_fw_is_prepared(struct clk_hw *hw) static unsigned long raspberrypi_fw_get_rate(struct clk_hw *hw, unsigned long parent_rate) { - struct raspberrypi_clk_data *data = - container_of(hw, struct raspberrypi_clk_data, hw); + const struct raspberrypi_clk_data *data = clk_hw_to_data(hw); struct raspberrypi_clk *rpi = data->rpi; u32 val = 0; int ret; @@ -211,8 +215,7 @@ static unsigned long raspberrypi_fw_get_rate(struct clk_hw *hw, static int raspberrypi_fw_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) { - struct raspberrypi_clk_data *data = - container_of(hw, struct raspberrypi_clk_data, hw); + const struct raspberrypi_clk_data *data = clk_hw_to_data(hw); struct raspberrypi_clk *rpi = data->rpi; u32 _rate = rate; int ret; @@ -229,8 +232,7 @@ static int raspberrypi_fw_set_rate(struct clk_hw *hw, unsigned long rate, static int raspberrypi_fw_dumb_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { - struct raspberrypi_clk_data *data = - container_of(hw, struct raspberrypi_clk_data, hw); + const struct raspberrypi_clk_data *data = clk_hw_to_data(hw); struct raspberrypi_clk_variant *variant = data->variant; /* From patchwork Thu Jan 16 16:24:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Stevenson X-Patchwork-Id: 13941956 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B22C1C02183 for ; Thu, 16 Jan 2025 16:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZibngSwY8argeZ7qofhjDrNbekU97d1TCMP7QCVWYG0=; b=wV1vIceMEET67Mbaxb8O0IPZb3 EYauArwkBhgchfsn1Z+0cJFM19i6To/EB8wavbyZ35pu5ZWb2OtSksd6jiXugc+9dr5+JFe+iY4HI 7BuECBwS+1oiW1632hf6pzl819sOD078U7LyYvZYIzyXpcYUDlixMRg6lBxVEbU8vCI70GVW0HzrN ovgiseq9E+rTjv77rqqgLxN8Y805g+OSn8ouz/O2a1X9LCLkkXdVysinK3/1qZrhmTAcHqJER1n3g i4wld1r6yEtYBEMo8Uxx0iqs5VTFc5SoG8XIsJc8T7X4/JtMQC2v6FrGulhBKgAF7Ne52+v2k7ALu TYeAsewQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYSmu-0000000FXN6-20be; Thu, 16 Jan 2025 16:32:08 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYSfL-0000000FVU7-3LKA for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2025 16:24:20 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-38633b5dbcfso1264192f8f.2 for ; Thu, 16 Jan 2025 08:24:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1737044658; x=1737649458; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZibngSwY8argeZ7qofhjDrNbekU97d1TCMP7QCVWYG0=; b=AEhIiNMZCxkNQ6YCTwpn+UL8z3+SLu2eI9cX1+YTt2JxtbbUqU7KDsvZ6d5PaAUZU9 BAJRhg6kalGY0YfaaWSDgUXutMS+LdYNq475iZJllaZT1DdcXJfWXb0E3Gm2HTGX62tp EmaGA0G0IV+2dEQjnnZoE9245TLztV5uVGlb8WlWxvSaKbcL+9Ueui6r09HXXkitq7js ZdIjz5ru2FEN87Jyece/ubRzJmyeYvGfRkuhu8yKjkTDe2qD4x+PrS5lmWQgv/Nv/T+Q CYPj/A3fwiNyR6fo52rJuhvOX1p3IicjHiT88iLN1rPK/cHxeTPzBigQzICIS4/7/WKl qN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737044658; x=1737649458; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZibngSwY8argeZ7qofhjDrNbekU97d1TCMP7QCVWYG0=; b=WOqtZNi6fF055mSBh4gOv3kYneouJPeyf1qVgcRZOeDq4W+8rPslsaIoupjki7SwpD NE5LxJj61zvcLKXdpt2k9tfcufsnMMtr0LtvHpqbSFEnwg0QSILJn42ZtAcr79+UrZWp Ow4QVBcDZryIvQzBBtNUy2ggKWj2nX+Itw29c8fG6/1iczLdzBZpGzDlkeFq8zNFOCC0 YUGsJnIkduEiP+Wm+eWCgobDI8QKyFwuWmnD4xiDmBVGyo67sIonGfi39/gwhvNqATXe x6xSwclpesALcftilSCViJ6gdRKeXhWNYSc8xaen4QS6xpg/q57uF6u6raUpk0r/vTlE XLHQ== X-Forwarded-Encrypted: i=1; AJvYcCXkQd2dzdnf1KzRpywRZ/D1fdfa3ilaJgvzZrcQwuqhQmJnG26yJSGDAjGbw2+2qGTqcH8Sw4y0gQApkaE0kD02@lists.infradead.org X-Gm-Message-State: AOJu0YwvRK+uDtpQ6ba9/lyen4SWEpzETa3FGd1rSxEDg6cbcW7BMcYm 2n1V0sP3PrpoHYMpsfm3vhQ0yT5lYuetNlFUuaUebzYB29VZkbd4x1iPoM8Q2lZlSmBuXA7mVqt A X-Gm-Gg: ASbGncsXnbGmA9VTRA9jBuPTFWtGcgpZfVkBcBbHLVMRXDU1+1vu9cXxrsT5K3Qzerp gtgY6qD9heMgrVqjUtOBXMFZX39np3kZ1mRXY9z10erxLXFMO74JkvawSYwOeiq2j1MtAjMcK8f SAlAncm19qORtZ8UVzVieEKAlRMChuCBZ2DSfwqv7UoJH6N8YgeQjx2OJt7aqzq7Y33TE8OA4q4 Okhay7uURaSvxpgsXcCa01vU2YpHAVKwxeap/QrpR85UmZE X-Google-Smtp-Source: AGHT+IFovdSUCLFl6t9Ci8wgrQdUI7v7DsdIkG9yNGdgleot+0dJp6sFALS6PaK+5Ttm99jIsf+Dng== X-Received: by 2002:a5d:584c:0:b0:385:f6f4:f8e with SMTP id ffacd0b85a97d-38a873573ccmr32438272f8f.50.1737044657836; Thu, 16 Jan 2025 08:24:17 -0800 (PST) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43890469ba8sm3715955e9.37.2025.01.16.08.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 08:24:17 -0800 (PST) From: Dave Stevenson Date: Thu, 16 Jan 2025 16:24:12 +0000 Subject: [PATCH 5/5] clk: bcm: rpi: Add disp clock MIME-Version: 1.0 Message-Id: <20250116-bcm2712-clk-updates-v1-5-10bc92ffbf41@raspberrypi.com> References: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> In-Reply-To: <20250116-bcm2712-clk-updates-v1-0-10bc92ffbf41@raspberrypi.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Maxime Ripard X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_082419_826093_796AC540 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Maxime Ripard BCM2712 has an extra clock exposed by the firmware called DISP, and used by (at least) the HVS. Let's add it to the list of clocks to register in Linux. Acked-by: Stephen Boyd Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson Reviewed-by: Florian Fainelli --- drivers/clk/bcm/clk-raspberrypi.c | 5 +++++ include/soc/bcm2835/raspberrypi-firmware.h | 1 + 2 files changed, 6 insertions(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index b12d86720207..0e1fe3759530 100644 --- a/drivers/clk/bcm/clk-raspberrypi.c +++ b/drivers/clk/bcm/clk-raspberrypi.c @@ -34,6 +34,7 @@ static char *rpi_firmware_clk_names[] = { [RPI_FIRMWARE_M2MC_CLK_ID] = "m2mc", [RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = "pixel-bvb", [RPI_FIRMWARE_VEC_CLK_ID] = "vec", + [RPI_FIRMWARE_DISP_CLK_ID] = "disp", }; #define RPI_FIRMWARE_STATE_ENABLE_BIT BIT(0) @@ -139,6 +140,10 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = { .export = true, .minimize = true, }, + [RPI_FIRMWARE_DISP_CLK_ID] = { + .export = true, + .minimize = true, + }, }; /* diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h index 73cac8d0287e..e1f87fbfe554 100644 --- a/include/soc/bcm2835/raspberrypi-firmware.h +++ b/include/soc/bcm2835/raspberrypi-firmware.h @@ -152,6 +152,7 @@ enum rpi_firmware_clk_id { RPI_FIRMWARE_M2MC_CLK_ID, RPI_FIRMWARE_PIXEL_BVB_CLK_ID, RPI_FIRMWARE_VEC_CLK_ID, + RPI_FIRMWARE_DISP_CLK_ID, RPI_FIRMWARE_NUM_CLK_ID, };