From patchwork Wed Jan 22 10:59:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Henry Lin X-Patchwork-Id: 13947151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01ACEC02182 for ; Wed, 22 Jan 2025 11:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=o7gEYR2g8G3qbuyH/5Ipw/hSb3/1jX/ezZHsSmDcjXM=; b=nvOE/et7Kp4stu t3xEteO8Buw4LH+nPREW2WNmYw904GEmCTrFAJqxxOCqT08kb0GAO7oIzuRy2GfE2UqbLZxYn4JgQ yiecnmjFFCJwt4DbBUtc4UA6ZJHOnqKokkgXOF08B/XLkD1MAPiQSE9yXvOUmfHjmV5zAsuaTTxRq 1AgJVoK+gACBYQX4wum5sBzFAM1LsJ7e6FvCMW12Ur8bnt4u+aMAfJo+U5zmclmnOOuqRPxUVujEE vXsY9F7rtSDdjRTutv5BnnwOPDHZYdXS+uhs5oaawAIRGU8ORzsP/PnvsFzOYZ/cQCUs72WOHCEYP bb92CLEy6xvZn80rKchg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taYTu-0000000A05h-23i7; Wed, 22 Jan 2025 11:01:10 +0000 Received: from mail-bn8nam11on2060f.outbound.protection.outlook.com ([2a01:111:f403:2414::60f] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1taYTq-0000000A055-1u4b for linux-phy@lists.infradead.org; Wed, 22 Jan 2025 11:01:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CTPJXHcWQvHXjqXk8UzhkSYyhb8QybGOc30fcip+LFgdBoMP0xr88FMQ0Qg3LzD1+zyk0CVVcPtXc0UHjSyDjmbpDS6+4/zaL6J7/i4+xS9NRn5R3AWyA3G+HJwvlDa9B4GWLusIsYHYYcY8aSVP0gxOe29dUZbjhBKDSJ37/lET2D2Vm85K9phthdDOa7OGBnrlEvgd+NbpSq5PQArrvfineT5QUT1T3DAnFEV+5ITnu3+4jvSTZRCC/f+zp6J6cCuWh/xduTuCKQenY8tVIkcwmN9Wip8d+WfJTsduTieNJSkBkD3FTRbQiLW6mQgLy9pIFy9gDrpDOca/EnyW6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YYRCGQqe7z1BA4/Y0gzr8WvAv+UpOf/IxI5XfI6TszA=; b=P5Elt3InnIuxqfZjKC+zHwx3XlgvLWnWyI9o+zTtjmVj4SNfLsEAqsrZ0FEG660EglkShzdwqvre0EpHzUj2O1KcevrNzcr8KJrA+IT++VAFR1eKxKm4ywwtKCwzZhBqMM8NXy+KP2ReRASCX3NJhU7jRP3mTvZfd1cMKu5b09lmv3W6tqdDTRGKqikQD9JfePiilInmIFMZdxYwmv1IRBzJHS2mQlNy75L2wCj8RVOMwEwuwdG0bTkX8ozZp0Qe/dEt15QeaEQRDx+h5DohPRtTi4y6IPbnvsF0rmIF6HCjNBrxlnsyHXhff4MiRTucb2K0UBxFXB81qyQI8VtK+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YYRCGQqe7z1BA4/Y0gzr8WvAv+UpOf/IxI5XfI6TszA=; b=J5aMQVGFqbozdl8QP/bu423juSXGdiLwSNaFYQR2bpNTXy6deWfN9QyYLslJiJgx41eWnk5O15EjMdpG7J8DqXZJCb27mGe9Mfp3+PwBtujrth5ifT8it+/c9DFSzwUdunRMSLNkH7jL3SRY7WrpkOst48SRyhIVtKy2n3iN2SRUs/4bognOPQwgzP9VhRLl5Zf2zbyxNx/2OZakRG1fBg2X3JZm5BRhw+3y7VRTt4iZguswgUfteMRhPWave5UYd2XsVrkeH50TKoUKPQ9/plbAW8bYGL47klEFzVGiSo6JS5GkazfFEMv/q9uV6hyTPnyyGxBodpRA9+pLkysuVQ== Received: from BN9PR03CA0654.namprd03.prod.outlook.com (2603:10b6:408:13b::29) by PH0PR12MB8050.namprd12.prod.outlook.com (2603:10b6:510:26e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Wed, 22 Jan 2025 11:00:54 +0000 Received: from BL6PEPF00020E63.namprd04.prod.outlook.com (2603:10b6:408:13b:cafe::1c) by BN9PR03CA0654.outlook.office365.com (2603:10b6:408:13b::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8356.22 via Frontend Transport; Wed, 22 Jan 2025 11:00:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF00020E63.mail.protection.outlook.com (10.167.249.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.8 via Frontend Transport; Wed, 22 Jan 2025 11:00:53 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 22 Jan 2025 03:00:30 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 22 Jan 2025 03:00:29 -0800 Received: from henryl-vm.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Wed, 22 Jan 2025 03:00:27 -0800 From: Henry Lin To: JC Kuo , Vinod Koul , "Kishon Vijay Abraham I" , Thierry Reding , Jonathan Hunter , Henry Lin CC: , , , BH Hsieh , Subject: [PATCH v2] phy: tegra: xusb: reset VBUS & ID OVERRIDE Date: Wed, 22 Jan 2025 18:59:43 +0800 Message-ID: <20250122105943.8057-1-henryl@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E63:EE_|PH0PR12MB8050:EE_ X-MS-Office365-Filtering-Correlation-Id: 2017e464-3346-43fa-3911-08dd3ad40a72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: nRkw5nc2IUp/SIu9VuExsFCdwmoYTaShJxBY+8duafJT51w9X75DmCoAxvKsyRPHpSGtRphPsOdkZt+Yl4pxQZlTftXzPyqMVeDY8xEyOMEA9ikZr2b1U0RjnDkiah/DLxdMfNYmC7yDTw1OiokTFBksf1S4HxUm4xtn+Leu3G5F5j1Y0GAFJA7g+fqtnbWmiVVeStq5DoYnAUZTA+eXvhapJ2co3C8C3BZw7yWfGe/TQJZzgEEHThEbFHwzGonI/MPJhkW6pI9XJC+lHwV2CtX3LmjwK5rb41/E+CA2IfoOE9a3L9QPJ3V2h8mi9Pu5KeG5ZyrMj1hx5CArvWYksz7LkfWEC0f6kZ9kXICG80e8Az0/6wrkn3p/X0gtJ1BRHIMq1T0hPhLp8h/PpM3Gf3iPC/MeqeBTUm9asEzc999sU1wXSl5HRgmJaWErpUMtlLeorutZKGr6h8CJCJVL92Vg2P7mumvdfnz/kDQetFiEZ78e1XCOXO9Q5qxhpJe5ziX/zQ7y37ioP4lnR1tmz8M5lj3EQxXl9Dd7sXPf9NgOKexKy5ENiZuvnZ1dg/Fe9ire4vyBYZtNPtW7C5xARWATF42FM+dM65Dg/FPUb/oLo+yZRksaF6IUItF/hf7N/n+QqxnpqZiWosNc+aOkr0NU4CHGgOrAX0IJ6MXexOonNGx2P5hDn+Iuzlj32If8kDYKLPclxEFxSJ6Kl4tJLDkYvyHRii3ZKuei9mXGZhxDY7CMCr/RkoyJPrQNAOOTmiXH85YhPqn2AL3DeQWoxgtDEWjstXuQwlUHrD6tBS5SOjGSnpRPhvizwi+P7mCHnZ1jR2K6k1P4j1xjzf2ZbyViySUyF9NW53dR9wqKffkTtSf3cX/m9IyzttRszD0hFDNGY7PcNZDAgipE3rK1+OaK9kLxAfjVMUSI3pyxBlFAw1I+rac3dCAn7y5c6g5qdzqxCL97JtgRmsgEoR2VKl3MF0vl26lvgfypcdNbEKslVDj1Oc3KFIICLqRXgrkUaL5Rl0ARy45Fx7OkQdUt7IkFr0ieJRzA+ru2Vxln3Bnvn9rqmjOOTuF0cR2oHj4BbQU3UoVivjR5XNNUbOYqoBz3N0rWeqKYjCRfxxCKzSKHTkQcz3Psa00kgDRD44XXw+dCqhL9fcXJcxOU5pSSY25sPD2SFfHYVkBZwLsO8Cfv+hSiSu2pyIYpKbcsXAavuzkUDBxkz1IMoxC5YAjwoqmCD7iSTFg0LuABApU6U7Cl+QoHAvIDZ1iEf4wAMQqXonK6BIm0PXHyjWARDAmNbQJavJ1boRynJfqQO6onrhMOMVUVwjzYRul6BSoTuJFKNW9lOBhGFCoFY9dtsBQXy9gmn9OTh8bXjZl4w6yVFkcR4zrDdTYY9n6OHu4VBIdEsGpHQqXbMjg442TqXtZ5jCRNdtWl/EtqSKkOJSJXca3oTCrggVwnFk4PS82j5Zt9xc745fLo+n5fimEbLYrDrJli0zfE2dBqokkc+LZ5PnE= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2025 11:00:53.7182 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2017e464-3346-43fa-3911-08dd3ad40a72 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E63.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8050 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250122_030106_517398_15A60DD1 X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org From: BH Hsieh Observed VBUS_OVERRIDE & ID_OVERRIDE might be programmed with unexpected value prior to XUSB PADCTL driver, this could also occur in virtualization scenario. For example, UEFI firmware programs ID_OVERRIDE=GROUNDED to set a type-c port to host mode and keeps the value to kernel. If the type-c port is connected a usb host, below errors can be observed right after usb host mode driver gets probed. The errors would keep until usb role class driver detects the type-c port as device mode and notifies usb device mode driver to set both ID_OVERRIDE and VBUS_OVERRIDE to correct value by XUSB PADCTL driver. [ 173.765814] usb usb3-port2: Cannot enable. Maybe the USB cable is bad? [ 173.765837] usb usb3-port2: config error Taking virtualization into account, asserting XUSB PADCTL reset would break XUSB functions used by other guest OS, hence only reset VBUS & ID OVERRIDE of the port in utmi_phy_init. Fixes: bbf711682cd5 ("phy: tegra: xusb: Add Tegra186 support") Cc: stable@vger.kernel.org Change-Id: Ic63058d4d49b4a1f8f9ab313196e20ad131cc591 Signed-off-by: BH Hsieh Signed-off-by: Henry Lin --- V1 -> V2: Only reset VBUS/ID OVERRIDE for otg/peripheral port drivers/phy/tegra/xusb-tegra186.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c index 0f60d5d1c167..fae6242aa730 100644 --- a/drivers/phy/tegra/xusb-tegra186.c +++ b/drivers/phy/tegra/xusb-tegra186.c @@ -928,6 +928,7 @@ static int tegra186_utmi_phy_init(struct phy *phy) unsigned int index = lane->index; struct device *dev = padctl->dev; int err; + u32 reg; port = tegra_xusb_find_usb2_port(padctl, index); if (!port) { @@ -935,6 +936,16 @@ static int tegra186_utmi_phy_init(struct phy *phy) return -ENODEV; } + if (port->mode == USB_DR_MODE_OTG || + port->mode == USB_DR_MODE_PERIPHERAL) { + /* reset VBUS&ID OVERRIDE */ + reg = padctl_readl(padctl, USB2_VBUS_ID); + reg &= ~VBUS_OVERRIDE; + reg &= ~ID_OVERRIDE(~0); + reg |= ID_OVERRIDE_FLOATING; + padctl_writel(padctl, reg, USB2_VBUS_ID); + } + if (port->supply && port->mode == USB_DR_MODE_HOST) { err = regulator_enable(port->supply); if (err) {