From patchwork Thu Jan 23 10:35:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 13948132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 230A3C02182 for ; Thu, 23 Jan 2025 10:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MOpNDsisMi4uqZQx0p8MXJf8+lrjc4G3zo+0/Kwdcyk=; b=KkBQ0RyVfkOuAL2RIZ1DRFh0qr Oq/KCqfFD3ojcpRSUAEKtMXa1Nk5EBI5MLivGRG10QLODKNFnmOWD5HtH4XQu73pFhnPQYd2dToev /FVmfiNlgV1iXPugpa2HSSqjTW1sgNSOl4EtXioSHXQyDyxmNV5yLouwLcA71OYEtIstXAAVRki6o C2aTDg6jEoW7PL4aBJ7MWqgmcnulkZs7QuSQ3bDwhBUDSD6bXK7T/s7o5IL+08jjiYd8rxwSTbZgs Bs5DcSFZg7GFyGzIVigW/vCE0VzAAA6sbj1kyu1viqj3adjcQ2cFThSZ4WO2AUgPi9O51o8rKJXWw keY4akUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taubF-0000000CETU-3aas; Thu, 23 Jan 2025 10:38:13 +0000 Received: from mail-dm6nam11on2062b.outbound.protection.outlook.com ([2a01:111:f403:2415::62b] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tauYh-0000000CE9m-25bw for linux-arm-kernel@lists.infradead.org; Thu, 23 Jan 2025 10:35:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hxYgWSoWUPogt7F40IScWcAYdoB5KVW2iq52o5dnQfMy/bnV5oKz2znWg3S2M769m83G2IEKk6O124qRlPCG46MvhRNdsIMWJw/Q+tJFymxOSLz1lCsYz+Gi/QmB0fRQEk7HejujFzgew312di9jdL4QvE/JlmijaY3plIM++UloeIiFJfKMsRoxx/tY0Tz4MEMRCu3My3oOVOQgmlAB995OhSRp2MY7fOvLmdRgk5kokqoh/o321IlMTiaJ8yIjp1rIu0ScJ/xY8TGDh2s653hrFHjs2tONK5VTA8Co7yNYcnHWHeG7lD8bRV3XDC120aJowl2AqCApChB1C7AmxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MOpNDsisMi4uqZQx0p8MXJf8+lrjc4G3zo+0/Kwdcyk=; b=PB9oD4wjla4i/7HWDEA/CZ+qxuUyx7mAU/ldbBErb0XMTIh+YUtiYYXLGvMr7Bkchs38tGIBVAJhCmFJRgkoXMOUVzXIGZ7jowP7BHJ1EYG+sqqGHxnrRmnQBWHQL0+aI3gAOeoNd1wNvPPS5XJf0FvsJFAaYY5soZq4VDYQltEjSGRVaF+DEx0nFDb1aYpKEsh02IkUvHUw8XabnfiVMUx8OIoYlIskwpgo+GjVNW12Uq2y/sT05CpqmoOzeCGMhM0yLOh8/Z8+42GqQxVLswjQq4BUKnFJz8IkduL6GOHTJfeyg1VZB3vBzjZu5h7aksub3GZFyZ4Qut0ueKVHPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MOpNDsisMi4uqZQx0p8MXJf8+lrjc4G3zo+0/Kwdcyk=; b=doD6wrZRehU5+NQm5AEvGx6e7P3bdpI9nw9d5NTmyA1mOsvuh8uiiI73GG2esr8KNfod8A52ymfRNBTLeNrnci87LVZo70K4D6AEFcJJpodsXHnzsiTeFf4TlVghmAiMKzqS76FfzF5oicCUvVpftrBBldgI2/P/vIlfYbyQSi8= Received: from BN0PR04CA0001.namprd04.prod.outlook.com (2603:10b6:408:ee::6) by PH8PR12MB7135.namprd12.prod.outlook.com (2603:10b6:510:22c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.20; Thu, 23 Jan 2025 10:35:29 +0000 Received: from BL6PEPF0001AB51.namprd04.prod.outlook.com (2603:10b6:408:ee:cafe::94) by BN0PR04CA0001.outlook.office365.com (2603:10b6:408:ee::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8377.14 via Frontend Transport; Thu, 23 Jan 2025 10:35:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB51.mail.protection.outlook.com (10.167.242.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8377.8 via Frontend Transport; Thu, 23 Jan 2025 10:35:29 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 23 Jan 2025 04:35:27 -0600 From: Nava kishore Manne To: , , , , , , , , , Subject: [PATCH 1/2] firmware: xilinx: Update the zynqmp_pm_load_pdi() API Date: Thu, 23 Jan 2025 16:05:21 +0530 Message-ID: <20250123103522.1258499-2-nava.kishore.manne@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250123103522.1258499-1-nava.kishore.manne@amd.com> References: <20250123103522.1258499-1-nava.kishore.manne@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB51:EE_|PH8PR12MB7135:EE_ X-MS-Office365-Filtering-Correlation-Id: 28ef21cf-5f23-43ff-d844-08dd3b99a809 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?aGYxk7TYO/QrXVo/NLvnYIQxtKaVKuD?= =?utf-8?q?a/icqWmRCsoJayvmeD5adtCypKWlsqJOW/L5pp7oVrV3gqy/lB2X73qxjIgrWxA0E?= =?utf-8?q?bOdaHC7Dn76fsQOqduRuK+OEvF5pESbox5KFAHXbBhb5Wfog7Os9Q/lx/1RRCTPlN?= =?utf-8?q?3TsNhojCWoUY0Od+c1xECrRsTpyGF6wl0bmNKB6fTme+FaaNmTw2/yfxa4anJB2yY?= =?utf-8?q?PUOlarkNjNped5/miLck9AHGwmwEhEjOciItgES8aUHYT5oewO4w50CduCucLdR70?= =?utf-8?q?EPZzKCl8XWA2QDHVuEzmrxL2aN3iTwZI8FwT7CDpwqUVNxtlqpR9XcQ5vncslrHNm?= =?utf-8?q?911QH5vdTU5+dVi0bTxgFixR+tIvRV+5w7iFJETxOHyHyVB8zVLW09Afvj0/UdjSz?= =?utf-8?q?p7xDQkVSD7kArzqM9UOoar2YLZGaTcILD6uRMHSETcc8/dgjSKzBZJemQOw/d44x9?= =?utf-8?q?kyIWb3dJAa1quO77m+P74k5KefhjgBFgEyQSvr0xZV+IAV30RNFUzuWoeIHWbNYoG?= =?utf-8?q?NrMRDO/++rlOS8y10BNC7u+7sNXzx3bQQwsGliZvRjzWkQWbN0DjMdCMCeVJESs5J?= =?utf-8?q?MVygvPE2WZeETrtICx0PR6iyBV6RnOW5CayXpIqfpiWsLtaOv7OhVt7k5MbPC/nzU?= =?utf-8?q?gT5aTmZCclqFxqEp11kcgD95FJb3XSxBknGftxQRtq3iGQjU2zPrsRZP4udCOanAx?= =?utf-8?q?z4uGBAJhcb56xX0QRgAUEADqsFBS3QkD0vD2z2j9FWI8ubveJFu+6meJ9Zi1MUK67?= =?utf-8?q?j7EGlRghmYl4MXU9bhjY4y0nuevD9W7FnSkGtStK5Zwv1cnE2Nl0bNm1vOYL1RoN1?= =?utf-8?q?DkAN4gbzKkHFe/W7H1znEVVOoB+ANzlGxVLX8n9K9oqa2F20GPjz205oy/U2e2pVJ?= =?utf-8?q?wHAJdNgZfX2OaRiQicR4qg3ylNyWCV0NcX/0PFfFL9CGxEonL/PubuvZau51BOlm1?= =?utf-8?q?OwMvL8sEdOfo3HhkYfFngLTnP3+yP3VzBrQ8fBcK3prgFL5yhDAHyvKIS7QLPfI9U?= =?utf-8?q?f4MY+hyhXGdU0LbtzGSGGiR0LV+35lMTQMe6BDAooibr6gyfMLq58vxuNTKOHPofM?= =?utf-8?q?2oRKQmfWIDNlp0AwNEfSPSxyQTsfErcPwB1MXj09ztF+lqvJOlxkcfjTsb01Dz48J?= =?utf-8?q?74/50MWETc9tPb6sBpSnJgHkXK1P0EUAbrHOwV4Oekc3Nh0Q1SlvMxj5cMowVirfr?= =?utf-8?q?n5h08OvAikk2BkXWu+axPG1pXN+UNuDDwhRWQJYCntpfLSufz/B+jeVX0p+rdBOqD?= =?utf-8?q?+hWnyYB8A/vN2nfzYc6d0iZI5Vs/cTKoTLXDfWOmt9mv/Mh4lZup6DLeLk3TliG9N?= =?utf-8?q?mvjwTbwiGH/EW/JdiHIKeIDKtN70V+lT/XPerUTkT3SDizQAPR1oBFXp9/Mu0Ee0d?= =?utf-8?q?RSxAJvZvk5ucZbBFx9+bp3DGFDHBEbfqYrnfelgbHZAvwBZ0CQG3NE=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2025 10:35:29.1106 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 28ef21cf-5f23-43ff-d844-08dd3b99a809 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB51.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7135 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250123_023535_569795_093E3331 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Update the zynqmp_pm_load_pdi() API to handle the firmware error’s properly. Signed-off-by: Nava kishore Manne --- drivers/firmware/xilinx/zynqmp.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index 720fa8b5d8e9..ea04a6ac402d 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -1483,8 +1483,16 @@ EXPORT_SYMBOL_GPL(zynqmp_pm_set_requirement); */ int zynqmp_pm_load_pdi(const u32 src, const u64 address) { - return zynqmp_pm_invoke_fn(PM_LOAD_PDI, NULL, 3, src, lower_32_bits(address), - upper_32_bits(address)); + u32 ret_payload[PAYLOAD_ARG_CNT]; + int ret; + + ret = zynqmp_pm_invoke_fn(PM_LOAD_PDI, ret_payload, 3, src, + lower_32_bits(address), + upper_32_bits(address)); + if (ret_payload[0]) + return ret_payload[0]; + + return ret; } EXPORT_SYMBOL_GPL(zynqmp_pm_load_pdi); From patchwork Thu Jan 23 10:35:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 13948138 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F5C1C0218B for ; Thu, 23 Jan 2025 10:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:To:From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2lUtNZQslyHUn8r1mI2CtzRhyYSYs+k/lefUiZNuwt0=; b=OTvAUWQserNCPbC76lQfMwu0Jy GipJQNRH3ot3vTx90ELm8FXn0qE5qQZbZ2l2w3NbrvGSrIQmghEed9BCToTlhdemi+kABcdqFGzeQ 7nHQUxfC8ZZKnWkNg+MI2ty96m2BjZUyYCf5lLgsKbboJcfmWZV5wB4rfuD8UA+baxMD1FA62ZUej jL1Kkk/pVaWSBBbgSWzunT+UOdIeBjEH+iPqrbjvaoOMnJWsVrmZRD4Bf3ocnzSpXLvh1LXf9Levp 9YXluF9Iv504sTKxR2LbmpdXOXDxNkuiFI0j401Od4jw9S1aSbmFjPKdabhSjCUq/o85CFAA/S7RL oCeBfZBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taucV-0000000CEbc-212u; Thu, 23 Jan 2025 10:39:31 +0000 Received: from mail-dm6nam11on20612.outbound.protection.outlook.com ([2a01:111:f403:2415::612] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tauYj-0000000CEAH-0yk4 for linux-arm-kernel@lists.infradead.org; Thu, 23 Jan 2025 10:35:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WbRdwlXjX1WY80MW2PpzutYsYYK2Irahr/NVYXyVFGHFC6oTJkGJV1AvbFHFMgwRmDCSnT8fqAIIDOfrnybZJiStFsfHRtRsMYBtTHvx+fKAUhoOUWrYgCiA2YEaei9vBg9Jz7EzQtwH8kM4pnC40nuDXclU6+FF6B4qH4wF7sstA12i7c3jQsXLcOf/V7ysS1VcsIMDOPQt1R3e7VUYIo9yVBNsYA1VbXcHLUaAH1/N4H+jQLsWf5vUwbodyShjg5u4feNwZpS97YnP9A+5nP4ok/AkCyulUDAx9U+Rs+zKQhMKpF1hIwsh6e+R+jKG59hNzDgsq8dxwVVzn5kR0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2lUtNZQslyHUn8r1mI2CtzRhyYSYs+k/lefUiZNuwt0=; b=xMMuymXNQtr0E3QBL+5Gfx6qQm9E5+ngK9PfHwIJq8RlLCCta03NnYYUE7BVmG2aTA/LXKKE/zK8oMwKGAWWrkvFyCueCV6OnLUoC5jAjEv59oC0wOdtDQt7ofVe/5rf7DTj/gnORZ0ekTZllJ0KMA5gnUR7eNwV4wsNZB9lcvgUwk33/rYUrXYlYv29tMMdth3ezg7cmXv3osTm7RnA+nZddd3MqTVJA9SHHfrvV8m3827BVj/e6282mgmRA2FAT9lSmm3eNUO18hadmOfDCquEdlkTzhq7AuGzGWcwqoD492Hz0aoRdKGPl/431/MTbXFQ6ZQcryn53fjOp/RiBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2lUtNZQslyHUn8r1mI2CtzRhyYSYs+k/lefUiZNuwt0=; b=OH8HL742xp+1Dam62KJDfNOFEUl7PwHGs1nOoL0QO4CUmV57WaBySK6hKq2b41jbPsFZ+vU3QNIleucX3G4rZmKCzsq1WmG3S9K5Oo5cECJxBxGyedsffvWjbTv/ZSeB1Qr1fP0Z5StEuY8W+NYTI4F7mH9pm1BNllXrWNitwE0= Received: from MN2PR20CA0056.namprd20.prod.outlook.com (2603:10b6:208:235::25) by CY5PR12MB6201.namprd12.prod.outlook.com (2603:10b6:930:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.17; Thu, 23 Jan 2025 10:35:32 +0000 Received: from BL6PEPF0001AB4A.namprd04.prod.outlook.com (2603:10b6:208:235:cafe::1d) by MN2PR20CA0056.outlook.office365.com (2603:10b6:208:235::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8377.14 via Frontend Transport; Thu, 23 Jan 2025 10:35:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB4A.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8377.8 via Frontend Transport; Thu, 23 Jan 2025 10:35:32 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 23 Jan 2025 04:35:31 -0600 From: Nava kishore Manne To: , , , , , , , , , Subject: [PATCH 2/2] firmware: xilinx: Dont send linux address to get fpga config get status Date: Thu, 23 Jan 2025 16:05:22 +0530 Message-ID: <20250123103522.1258499-3-nava.kishore.manne@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250123103522.1258499-1-nava.kishore.manne@amd.com> References: <20250123103522.1258499-1-nava.kishore.manne@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4A:EE_|CY5PR12MB6201:EE_ X-MS-Office365-Filtering-Correlation-Id: f12d71fb-00fc-474e-ba66-08dd3b99a9f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014|921020; X-Microsoft-Antispam-Message-Info: RYGq+tSXHYw/fRQuK3W8ATTP4SvGFCZ1QsT0EJDhtZPMSOHUJ908YO++eJZLcWzKuhw9UdTsOhkh3Qx9V6f0qESuYLjmOw+mZZjgxLU/oUe/4P/e2K23zLwApsDvFumQHXCDQNo8n2zttz5EtUwZwoPrphDk+pB+ONHp8EHa3A5GcHYmua0jObMNG4+CzA15XEkqpM6fQ+e+YvUgLjmDsqSlIZ1912ze3y+/MEHfTEnmgtZjhA4lI9ooPl/Xnu0gixNQjQghborBerby3e71ECPJy6QRUexbKYOYi+oDnq3icb7hVCqrNYa3q9LZr61fTj5pJAgqW+pAcSZaXSC91x7qKjrbmKuUuuuWXwRKpXvwo89Z0yA7NSKI33FrA1C1UKLokbuViRZFWW4Pou37Qw3X9gRW/5XcQQOA3/UjNCnvEgYX9pZFmAH4VUSc5h33976QvaaI9rFvRnwa3v4BO2v9O5TsePS8SBM0gdqFF0o0bxEDGl+PWKeONt/XsW+4enIxv1Xd7jPlBD0vnh70MyZMy+aXRBBfI8wHIw3jSq7D/kDyzOE1lSJcuC8bJPSLsiZiup5qMBD5jM/ZD639GpGFbVpq4saUbEW9/3BcOadq0ciWUDUfQHl4GJllrnO1zrXDPxShePBQTwPQmcdnLsMjUAB9P61f8dlz+9LgK7bGPiSv2/pDhcefhy9+DtuyBUCETe1r1uHplJ82apl3aTt5xH6EY3TIk8pQPUxTxcQyWtQRqLhVUUZapcp0ZGsB7tuTgcCfrON2RA61MPnMONyAC9zZVU5rGwfNh7wZu83BgZ8Go2yVQXYeleg5GBLrMKn9WR4lpjGqxKIbmfAQGvPXY1E2ZSWzhg+mtG5pmPBa6M0Eoh7rrGC+64kn2t5NqWYSQzGBr6dH9vXfY1Es+aB2Em73dzz/6KgxHy76mrIAgVRIFaNU2eSneAfElCS4kvFrZmaw1dVeglqshR5TtuRzW206j965RHwgDSbe0hcGwZu7Rm2RmgHo56vyW2Lan8pTHhQCAfHpcfz+dI89pqkeEvWoVts5td5m3FFiJgYprBfCpFyYAvIlkWp0urwk8WoiaGZEYlrkKs37yDIcwCO2cjKLssjpzE8vkPbSg9SipgHMrFqrdcJuvJAR2X6VOdYvjwHIkoB88cW8YZf+bNve3khqyERLc4bUFZYrCj9M0ILmJo+z+uj32bw4KO8wLnASETkU3Z1o+DLiLFglwHj/i443F/XKSd//PWfd8KhbHbxii2bcoDU9adpqtSSOzRI6h1R6UIBLsIjUXDkFUrILvfWcgT6wFLoMM56QSMqVSV5byyvlAD7FiO/VN+pfwCj1lJJyBiLEg4ncHuSXPBCszzwsYbiU08gCigR6dd6TNZII1Web7qDG4Wa1rqU+/5T5pUcguLkG+mwAoID8MyaaIx2NxxfzRp0WiuLD76U847Khwq8cKvv3//ff4CsWWftbVPkA9MkBapoXjbQMsEfxaf1yQVT9pXDDoBWNgh8F1jR/AZj4/jiAE9Xrgvzt X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2025 10:35:32.3382 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f12d71fb-00fc-474e-ba66-08dd3b99a9f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB4A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6201 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250123_023537_273502_67E84DA2 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Siva Durga Prasad Paladugu Fpga get config status just returns status through ret_payload and there is no need to allocate local buf and send its address through SMC args. Moreover, the address that is being passed till now is linux virtual address and is incorrect. Corresponding modification has been done in the firmware to avoid using the address sent by linux. Signed-off-by: Siva Durga Prasad Paladugu Signed-off-by: Nava kishore Manne --- drivers/firmware/xilinx/zynqmp.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index ea04a6ac402d..406b4bd10894 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -1139,17 +1139,13 @@ EXPORT_SYMBOL_GPL(zynqmp_pm_fpga_get_status); int zynqmp_pm_fpga_get_config_status(u32 *value) { u32 ret_payload[PAYLOAD_ARG_CNT]; - u32 buf, lower_addr, upper_addr; int ret; if (!value) return -EINVAL; - lower_addr = lower_32_bits((u64)&buf); - upper_addr = upper_32_bits((u64)&buf); - ret = zynqmp_pm_invoke_fn(PM_FPGA_READ, ret_payload, 4, - XILINX_ZYNQMP_PM_FPGA_CONFIG_STAT_OFFSET, lower_addr, upper_addr, + XILINX_ZYNQMP_PM_FPGA_CONFIG_STAT_OFFSET, 0, 0, XILINX_ZYNQMP_PM_FPGA_READ_CONFIG_REG); *value = ret_payload[1];