From patchwork Fri Jan 24 15:07:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 13949537 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011031.outbound.protection.outlook.com [52.101.65.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10C2413AD20; Fri, 24 Jan 2025 15:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737731339; cv=fail; b=QbukMbTyhjLxgU7F+qFj1d1JzC6CFGKa/E34ZW6PWha+8uLCVpgAibqz7e9HtOsm8al12HBOkJXL/hcGiXcfGvRnSjwNjsfOUcU8tHmVWZBWO1MrUzTpxICNgkZe1j+MrejtnWSVrGzEFV2gnUzHFAtnuo65kkm6X57TxQ9Lj9Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737731339; c=relaxed/simple; bh=5NuNQ0c8D+vLwnnpR2muXeIhoiT5iD7YTsP4Zzc1hH4=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=FvClIP9RdxSSxh+fyYKalKoL2WJ/nZpJr++gRsWB2gX6B3QShILTFXao31NlQhARhfpAwf0ZCjgLoG62lvbWQ3IGrxfM+pTWisHRLIC8k+9c5nwvFAMuyjRWiITbjCy/4SS5gDvUmyQzAjcKDWOiH3v0Jj4rSCqdtgKA43oS8UY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=nu8dwiYb; arc=fail smtp.client-ip=52.101.65.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="nu8dwiYb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=frjlhJYBl2tHgDcbM2H9fQ4OOHMS7RUVrAbZ1T5HydDy19J+g+XEJpCRz0C12sPTL6SEMOsGjGTH0Bk38yBKiYvdvsJzTMwGTGI93QzWw69luJuuBPMu3lyuX/ZlPqi47QAik34FwtY2YgjeVXG/z351SbbhOv9Xs3b4Rrxr/CrtVQIu+Iy/VQsx7MzFxOGL/UE4qkCLyIHknOsSLuEtQ9dW7L85h7E2IEwWAcjmdvZ24h9a6wKLOoK+ORKPwdcug0oBlmR7djcBodMVnsT8S6YsVPITgXub5bCj5i/K2KPenQgRaUHX2qOmbIQkmlzO7qFzU5aVf5XYB1GclOOg6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCcQMGyf8M4UR3tUKSETD1uDLqR3FodT1tlRePVY7XA=; b=bJYyBO1ckbfb8ng2m7H2zN5awKBeJXiWjFhg2nqdPnQUBDBRCsq1vbXg2jNcCPCYhZhm7aLMO7gPEHASbV2W+TQ6BnoOw4C5ujGirtKAGt5YATl53N75ORLuEepd3L/49BvgsLVSvqDhK1etezYzgH4izekjS9o+3I51/5eV2TXAer5asXtN+nsIkAUaO3eAHNQ+4OFtQ5fXhPxZ/pdFk4WyB/8++DQu65Uw+iI821ca2rJNtaJ+LSH+PPz/YaKv6xvDPUH2h2KlhZPIdXW11uCDjZWJSVCTvUD1BqWCN1n3KRySUtz7fnE4hDoNyEs+P4pf072mQuWUvr3306Zwiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCcQMGyf8M4UR3tUKSETD1uDLqR3FodT1tlRePVY7XA=; b=nu8dwiYbhA502Fryue5UkU10AoUBH/UYhiszBuoDABJQTxkBiqpDl+pL3b2kqDByXUJ8MJzCLvuwUrCCYWHvZ3PNYr5/9hi6SsljIPEZ0k+UhhGlMg+qcPoH9O0M0N5gXwjNqZm030o4v2JTFOdAvAsj/0424ga7YqP0UWtzSCMEjdTrnQFUskKjGbgwW+Md9wjlNbFL5vXR7RWyevlmjt23dJ/JCnzP9v428kA8aLYAdW2nk9TLzby0bCJuVFKiLQWiY71vhiarR2onX+jLApabaabUYmY/0IwDovVpZovnF8C5K3LhlLmbBf1mM4m0WKs6wwBcGwRkBnxP61KZNQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by DU5PR03MB10423.eurprd03.prod.outlook.com (2603:10a6:10:51b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.16; Fri, 24 Jan 2025 15:08:54 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%5]) with mapi id 15.20.8356.010; Fri, 24 Jan 2025 15:08:54 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Lars-Peter Clausen , Michael Hennerich , Alisa-Dariana Roman , Jonathan Cameron , linux-iio@vger.kernel.org, =?utf-8?q?N?= =?utf-8?q?uno_S=C3=A1?= Subject: [PATCH v2] iio: adc: ad7192: fix channel select Date: Fri, 24 Jan 2025 16:07:03 +0100 Message-Id: <20250124150703.97848-1-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 X-ClientProxiedBy: ZR2P278CA0021.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::17) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|DU5PR03MB10423:EE_ X-MS-Office365-Filtering-Correlation-Id: 54a8611e-f6c9-41a4-3a41-08dd3c8904c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?TPJoDmeo/6R/2uUwAaKLAKkY0CcBYeI?= =?utf-8?q?zheFpOu4OkhrZiINUN/lNPTdUJ4JYUB8OBv1HTFxmazpJkO8iQo/yl4rkaX7x4Gyx?= =?utf-8?q?eupbbSvt7PzuzicjStBWB+NXhc8p7WinXMCMYFpkLiVKZnfl5y3z5OnSgeu6ODvLL?= =?utf-8?q?yt5Zcekh5b833JJ8TlxZd1Ufd7XOASPeBc4bxYZ1+uX+sd4KsB7IZOVCljRlj4fCn?= =?utf-8?q?LbWCsjS2fQDpRhf4LwYdiIOkaOymFqXbArU/gN6jzzRDJNiMXwmrULfYGLftEp8PU?= =?utf-8?q?93iE95jefr6TJHGC0K9pEIHXJ/JwRcckGpcPZsuDm5T9W1e1VFv/iLPOWFfan+O9W?= =?utf-8?q?MELkss57aIT9eaIAmn987U9V+nQLsDvaBrUS0ApGROTt0SXYh/Uiac8njaA/GUkw1?= =?utf-8?q?QswF3fvWzhXgY5Lg4IEZ9nECAq/bBXDckDKbU6QRhXVSzB17kUpHZ4Ex7VwESzYA6?= =?utf-8?q?onLToGtP+ZJaajC+fjfp8qB+5YzqNDNRtIJMaDb8PBMVwYBXJVDSX618VQipF9Qzv?= =?utf-8?q?gndh83qk3FJ7OGlrSoLfDoNWvXWafZFmHljXt1doSfhM5DNGtFhgrkkvAa2/DZolm?= =?utf-8?q?1mPuFhPW2k7AJXqsC0QFLXoCJohztf0KlPP8q/2DHFrUHHz+TCbKG4IFjeyy1H/aD?= =?utf-8?q?ziOzPUqbfIsLLwL23XhjcI+lUy4Aq3R08C7KFfpaLEvhxBNV6l+QBjDVSdPeqeHNn?= =?utf-8?q?m4VIT7Xl3POd91p9SWhFHBTSzjpGM3U4+vprNMcXOWFP7XMHVPzRZ94QwhSGEwVNO?= =?utf-8?q?s4wvlbXzP14V1Ha8UH4V3njxGntazpa/x+oBk81TZ4vZNSDcEploXGKmt29oh5pUi?= =?utf-8?q?3HUkhW01BIhLv8qUsf40uzPU5pHyDIH+4OM8DuZBqfi0F2rn0atOuziOZc7l0Up2U?= =?utf-8?q?p77Sx4Mudzk36mHw6ZEKXAG6LM9au7MLJUnb6dZnHdJq0Nh4oClz6oxD3sbixK+2G?= =?utf-8?q?kGneRFZfNhFbHOIgfr/U37k/0jZ+DAKzMaMZq4G15rduznW3Wgsb5pFNFiQk182TC?= =?utf-8?q?xtTMnY9Ew4nmKJYdREg+yotYeOL9KGTHgmCaXIr+Dt4e4z2Bi1IvxcVJzplmZScQQ?= =?utf-8?q?zPOyb7+RZr5a8DjPaWYfMp5IE7UXqbUN9S5OH+lvvQa9lPCaaETTZejmjasjoRs7n?= =?utf-8?q?mgY4sCx34xgBKOcy3lVlzWV/qKWTSWRTVlrNi9TYL/IJExeL63P8Zi1cgvUBE+q+B?= =?utf-8?q?0NM45OjFyVvK6Az1xcIuA05nvG99OrCDFeVnruDVZBg10xlPPfu9DlxIxumbjLlbv?= =?utf-8?q?xjbaOlQhn8hF/wHkm1DW03K7912uq9nAIY6sEoLoi1+3wUsErD8cWVnQ42/3eUYrQ?= =?utf-8?q?9okSv1xjpqKaqlMwKlbhVPB9e2VA3iIF/gTuFqFrTJb7dSFwRG+9bzs+eI9NXh2gm?= =?utf-8?q?yOB5BioyjVR?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR03MB5399.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3HDoxF4VXM8cYHEn83He1PoJ6dhB?= =?utf-8?q?7B0yezAL8/wDWVOCQKnxe62G2NI3YXxeZnCl5dwi00PGd2NLLt2T9+//vWP52iA/N?= =?utf-8?q?TbKApytHUxx4+8r56b/rSeDheYktGi2MXcvesFlE+hGwmYFXEto7iTmFoNTaiH9rc?= =?utf-8?q?qOR22pFfcDK1OIVIwN35LbPYqHvNGM8TXjn35duZED11yQLp/Ykd+/3dpFHUwNGuT?= =?utf-8?q?F/GnAwNa8Ea++aNCgDyWP62lBrlCiMCXUoDR1nlsbKL+gt6FUnCZS9qCuBVR4bnU5?= =?utf-8?q?3nfqRKWSaWw5TCwi+h8f0MuMivKmJC+/IbqHW5qXa9ZTt726syiACKuXzgoC0Jsw4?= =?utf-8?q?Tc5lnPPEp1wZWVhWxXCpG6RqBfNgCA2Zm24vTvtdMMuewrg3U6E7Z0H/V3i/hra8R?= =?utf-8?q?LiOgF2NBRUBeStfNwtAWZZQBl8vMIL0aj/hpcyBFeG/YCHIe7VLLHL64xDDxFHjkK?= =?utf-8?q?cX0odQ4HnHiYu1BR+0W6WwZkf5xl3OITp4aLxfIOo/lecHykcH/O2sZ0dcYsyDUot?= =?utf-8?q?RX7h/oySQTAG78qpwwFKKptFAoLfW4APAvuocoPoMAbM4V1wOAvmNxqbvhGFy9jc8?= =?utf-8?q?XiFy1JPEAYcpNGF54z5/8vrmk29I8bim76dFQKwgKk9tLy4YV05n0a2b0C0TLzUZH?= =?utf-8?q?BXvk+5YMMz6saQnI7Zu5zi4SEejNkFOZ+iHRcacXNZu1iGk5b25KOGIuVJtOdcRcK?= =?utf-8?q?ctEaV9D+0+mW7U3z+atVOj/szZ6hp6ECJzl6w+ZoePLcKGS5WsLTaPosUl0tThz2c?= =?utf-8?q?CC8gS8EfO+RVwNAza8HCNamTaJDHX4gKzDtHagdHZcBmsdDTphFPlpt4ZyzC025Bq?= =?utf-8?q?9PK4GhjPkmjoRfG36IHJBdsEuNGg43aOJGPssMir0AcxrWE5mMkMZlvAIfrx0oVIF?= =?utf-8?q?ql8OiOf+LdkgiTSr5gjSCU0oHo2lmod9KpbwR94RaPmvoCVLSBjfqrJyTgc/ss8MK?= =?utf-8?q?Chf+RC40PyG6skI5Cstf+BVRaEJ2TZJPrIyyAb0wStMajnCQH+dKUlmpC2ugUfLGy?= =?utf-8?q?3zzP2n+DV0ClPB8k/8W4EAmmoTSbMaxdnduw1X2nmbJirAWxS1oqPtTnbOz+CKEYy?= =?utf-8?q?2coUh9RpESozs6kWaiQsbe5XSSgM9BJVO++BkYh+383BRtBvpFef8esvsXwww2gmk?= =?utf-8?q?oSFn3O68dJX87WMzjMybstrBRg9M60NUfFDYF0uVa1Z9rByelcdO1eC7id8hF7iJV?= =?utf-8?q?WtYr+Oie7Kb5wUS7gJPKvHETuhMH9oA6VBWi+yuLaR+pefaXv8mrgCtYYXx7UkKzn?= =?utf-8?q?jF3F4jbLgUcz9wp0MmcwuItP8noHZYDpwlLAXZ1Xg3BAskiFsh8O7X6vCJENCEEV/?= =?utf-8?q?wokk3ZNv5zjeFLRb+GfiuYIVeZrrKenheYJsofOnfERaD/FpPRKTTOx3s24t1IF45?= =?utf-8?q?o88y89rWydh5/AjBvaK83XQBPZG0Il1Q1r/2QidZLeeJLoJJHMiPkLddkj2Q1+VDz?= =?utf-8?q?o55O1w8eZOdtCylfmquxCluLnLraiOhxh943kDwDb9kBVM5avOUxP67oPd5FWlOi/?= =?utf-8?q?QslgSkdStoLq?= X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54a8611e-f6c9-41a4-3a41-08dd3c8904c1 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2025 15:08:54.5343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CC85t+j4j0ZzgbHBLU+UC19U/0Xp/xfLLzMLh9o5yvBikxDVwveERP61oW2Q95hSUSmFQpRL5yQHx2XruCubgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR03MB10423 Channel configuration doesn't work as expected. For FIELD_PREP the bit mask is needed and not the bit number. Fixes: 874bbd1219c7 ("iio: adc: ad7192: Use bitfield access macros") Signed-off-by: Markus Burri Reviewed-by: Nuno Sá --- drivers/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index 1c87db0e0460..c4effe8429c8 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -1082,7 +1082,7 @@ static int ad7192_update_scan_mode(struct iio_dev *indio_dev, const unsigned lon conf &= ~AD7192_CONF_CHAN_MASK; for_each_set_bit(i, scan_mask, 8) - conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, i); + conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, BIT(i)); ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, conf); if (ret < 0)