From patchwork Mon Jan 27 13:21:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13951378 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63BE6C02188 for ; Mon, 27 Jan 2025 13:21:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1AB910E3B0; Mon, 27 Jan 2025 13:21:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="TV7rmXZ7"; dkim-atps=neutral Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7901A10E23F for ; Mon, 27 Jan 2025 13:21:10 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43616c12d72so7028205e9.2 for ; Mon, 27 Jan 2025 05:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737984069; x=1738588869; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+klEMk0HAOeZBAXubltjLaVWMvzRQNoO88wNMjjAFMg=; b=TV7rmXZ7m7dE0Bq+y7MI3kH794/DZ4fgvEweWAjXWW9FpjX0YNiVBusbJPZyhfQ6hy 7sA6WvJWg74V/29lzRoHBkGxAqceUW9zloWbH9nyiAnTzjaTQith4CtiBU84Mq8TWMWh NBgDIslPLxpSYIoltn7nADIUkKO8FlFIORMuUwyyK1kr6JStk9P9GW3ncUNmgYBpT3eO qyfq8nknl4/YaifyprgWMjouxY6B39rvgxAZeCqik64mBJrx7CcTwQmg9FbCwLCC3qxe LCQTRpaSKvzi2OoKUOSutHvp6wVXoIB2hXiHS1ryRYEzD4zFBNNBgI8rnA1ghuGJU8S4 NVZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737984069; x=1738588869; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+klEMk0HAOeZBAXubltjLaVWMvzRQNoO88wNMjjAFMg=; b=NWpDi5/8U3TuQRQ3U47XmBf/+lbEfQdiv07GNreYZy9y5bi2liua2HiyEouP10pnTA L75Q+PUS2cEbSVEzN7RRiiqg1i20+IyFy5Ww57VdtuDKmX7dCDZmU3LjjWJi+Yo5GGC8 PeJlpIb+4RpuSiGivFv3/G0AIIoIKAY/nZIULDPb8H4r3E5UllP1Dz89TA8hSuQUodTH 25xlaFkwCKE8N0XEjiR3Ykj2mow9I2W5Iwh2gbxrcnY4gH2TZV051zF6ZtfXF+xPUTXt swOh8MhpMldzRRM/E+iIpQaCAB3jgHMgRG7xTIMXntPANM049sfzXyenhMMb4ODrrp6R UsVA== X-Forwarded-Encrypted: i=1; AJvYcCWq68TfZ+vvxA1q2zfipu6wMNevO2U3fUjJ+w+oqmIbZ5miXcfGVgbS8IyZzdbBftQ7lPofYZuMgJg=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxKXT9WlD1FuPAkNfCnlA5S+Iv3hBFBZWrb+pgBqqdr6cM0SBDw AFldA9gU1H2zt4vnUxIg24P2OvHjs80jv4GNNcVFtEzY87EYVYiIOid2gGqyMVU= X-Gm-Gg: ASbGncuhhs7wiwPlSPsQqd06lLLfAnx3lADEeV/8XquAEbd1re38OwbuCePgk1q2Q98 kKitliVxp+BvhSn530DhMHHqkevQzhxqi/yauXbK6Hg0qmXAssr+Xamrml5eQSdg8QPM3iznBJ9 LaA2K9C0B9tNAP3RtvH0W3FCfawrg77zDSwh0YBkg5mmmGKqSCIbifkHT4opbB8yOzYalrf1U8w wnvDlgO4BUhEo10koa7fHwrUehnavS5czpPYJfX/isGCtGEBgwTjSrOPQ51JRqsPMOq25mh42LC 360UlP7IU88vUvv0EA== X-Google-Smtp-Source: AGHT+IHXp0TkSnUcKeJc7jgumcRa74yvba9PnZUCBYFw4tCqyzZOJvhurHlS0rdMsNnSl5Phd/c0+g== X-Received: by 2002:a05:600c:1c0a:b0:42c:bfd6:9d2f with SMTP id 5b1f17b1804b1-438913bde78mr147472595e9.1.1737984068879; Mon, 27 Jan 2025 05:21:08 -0800 (PST) Received: from krzk-bin.. ([178.197.218.98]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd4b9977sm132386105e9.25.2025.01.27.05.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2025 05:21:08 -0800 (PST) From: Krzysztof Kozlowski To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Michael Turquette , Stephen Boyd , Krishna Manikandan , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] dt-bindings: display/msm/dsi-phy: Add header with exposed clock IDs Date: Mon, 27 Jan 2025 14:21:04 +0100 Message-ID: <20250127132105.107138-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" DSI phys, from earliest (28 nm) up to newest (3 nm) generation, provide two clocks. The respective clock ID is used by drivers and DTS, so it should be documented as explicit ABI. Signed-off-by: Krzysztof Kozlowski Acked-by: Stephen Boyd Acked-by: Dmitry Baryshkov --- Patch for Display tree, although with Ack from clock. --- .../devicetree/bindings/display/msm/dsi-phy-common.yaml | 2 ++ MAINTAINERS | 1 + include/dt-bindings/clock/qcom,dsi-phy-28nm.h | 9 +++++++++ 3 files changed, 12 insertions(+) create mode 100644 include/dt-bindings/clock/qcom,dsi-phy-28nm.h diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml index 6b57ce41c95f..d0ce85a08b6d 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml @@ -15,6 +15,8 @@ description: properties: "#clock-cells": const: 1 + description: + See include/dt-bindings/clock/qcom,dsi-phy-28nm.h for clock IDs. "#phy-cells": const: 0 diff --git a/MAINTAINERS b/MAINTAINERS index eb75c95f6c45..30103e3918ea 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7398,6 +7398,7 @@ T: git https://gitlab.freedesktop.org/drm/msm.git F: Documentation/devicetree/bindings/display/msm/ F: drivers/gpu/drm/ci/xfails/msm* F: drivers/gpu/drm/msm/ +F: include/dt-bindings/clock/qcom,dsi-phy-28nm.h F: include/uapi/drm/msm_drm.h DRM DRIVER FOR NOVATEK NT35510 PANELS diff --git a/include/dt-bindings/clock/qcom,dsi-phy-28nm.h b/include/dt-bindings/clock/qcom,dsi-phy-28nm.h new file mode 100644 index 000000000000..ab94d58377a1 --- /dev/null +++ b/include/dt-bindings/clock/qcom,dsi-phy-28nm.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ + +#ifndef _DT_BINDINGS_CLK_QCOM_DSI_PHY_28NM_H +#define _DT_BINDINGS_CLK_QCOM_DSI_PHY_28NM_H + +#define DSI_BYTE_PLL_CLK 0 +#define DSI_PIXEL_PLL_CLK 1 + +#endif From patchwork Mon Jan 27 13:21:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13951379 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BC01C02188 for ; Mon, 27 Jan 2025 13:21:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D4FFA10E50E; Mon, 27 Jan 2025 13:21:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="jJ8QcOWm"; dkim-atps=neutral Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id B233C10E50E for ; Mon, 27 Jan 2025 13:21:12 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-436203f1203so2758865e9.2 for ; Mon, 27 Jan 2025 05:21:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737984071; x=1738588871; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1lrk19+x0xCyWtNAM9zqIl3MR0fAbQ4p3LHFnpdDhys=; b=jJ8QcOWms9z+sGwGXBNiPbvF1+wau2Llbssq+3v8wRGOsXc0NjwFzfyKz6o6+RCBhM PXao0vPTDfePYbiT+vKw63lY+CmFFZt4aujq3RgRd9UM3bKpmhzd/3SKastrDvgNkXZI snVxDOuGJSbdH7ByGx8ajdAyBIDZWaMZT4JQ+5wJr+Blk/BmxEiT8W18R2VTpG0duU8G 744BDwIdLTho5CczYp0GCVnnhP0GD04by7xZmm3fHsAzmay8ni/S7NH17E1wUWEBE6X9 umeQYEQahqycWWchQs+JI7Fols+DFsUDYy8R4oq425LgG6oL4zFYz/uKVOOTg49YL9sE dJyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737984071; x=1738588871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1lrk19+x0xCyWtNAM9zqIl3MR0fAbQ4p3LHFnpdDhys=; b=IlylyFTIc6YbvJEUPwGpETh9LHZCePmu45b0LiEmMJ3UXxoo9tT22d1b36elZQiSvC ZVyzeMSgx3hURuI2hOmo3rXX307xq25fNBMKQedhDPQqor/YG92JBOLiSfPlqqtHzt2r dqM4VAZo1KbGQvl+LdHw2vENx5c791tNWVvVQadd8BbSMiOxtHvjtWMmAtv4CL3PR0nz Ry4WuHpM/f1U27PRhR2QBANjJQuvMk39Eafk7TBpHWtEiIVUoGYDLD+Z4f36sxD48GEW WB4xYsu5fDIzBFk+xLzYZSQBZvJLhhNM/+MqHZ1FPU+W1QZ3RypUQZnka4DJ9H+8FsIu z04w== X-Forwarded-Encrypted: i=1; AJvYcCVd0KzhrYXD3QLawkPxubHUaUTGJZm03k7HAB/rPTmdldkYsIFWUOshUroXqYX8D/Wb18hKK+aLFGs=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yx16FELLuMXeMjuCq43F8MZOTtSiNDZQrzmnn6uGMkj1zYhKCtO DiFJFIBn0yKIyq+RKXTbRUoAUO01r5LtpLSOxUSbjqkndiiy1h+fZgT+8qlEmVg= X-Gm-Gg: ASbGncthiLlldTTBwqfyasi7cS2TsTNxRJU6kY/zVP9+Ndc1oXcKK7Mp7BtzkAXksQ8 OHYp1OonksHUBoE5fC9pjdXE61MZl0knuvwffVBAu/02zVGelk5gvR97RmjiWrznfdq7u23C4qu Nf0U09BkBvE0VY4VsBAsG+PzbQcjVFIKoH0Vl8UqLfpmSH5e1DSzamHo1ebaraZ2VXSPJqKBbu5 Mv3ca99nuKowPnKsAvps+vD0SgHIBCn8qX6BVG3W+Jx71D491Jdc7zfn22y9Inw+KvLFzHhJ394 Q5JzDPNLyVUhwHr/bQ== X-Google-Smtp-Source: AGHT+IFQ3yteVkt9TcZzs8X17uQXuOmJxl9Leoqq2TKqJE6nDiurSR7kDwbdcXBuU+CbDYLyoR4UeQ== X-Received: by 2002:a05:600c:1f10:b0:436:fb10:d595 with SMTP id 5b1f17b1804b1-438b1763eeemr80946485e9.1.1737984070644; Mon, 27 Jan 2025 05:21:10 -0800 (PST) Received: from krzk-bin.. ([178.197.218.98]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd4b9977sm132386105e9.25.2025.01.27.05.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2025 05:21:10 -0800 (PST) From: Krzysztof Kozlowski To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Michael Turquette , Stephen Boyd , Krishna Manikandan , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] drm/msm/dsi/phy: Use the header with clock IDs Date: Mon, 27 Jan 2025 14:21:05 +0100 Message-ID: <20250127132105.107138-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250127132105.107138-1-krzysztof.kozlowski@linaro.org> References: <20250127132105.107138-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use the header with clock IDs to bind the interface between driver and DTS. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 5 ++--- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 1 + 6 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h index fdb6c648e16f..7541ffde6521 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h @@ -6,6 +6,7 @@ #ifndef __DSI_PHY_H__ #define __DSI_PHY_H__ +#include #include #include #include @@ -85,9 +86,7 @@ struct msm_dsi_dphy_timing { u8 hs_halfbyte_en_ckln; }; -#define DSI_BYTE_PLL_CLK 0 -#define DSI_PIXEL_PLL_CLK 1 -#define NUM_PROVIDED_CLKS 2 +#define NUM_PROVIDED_CLKS (DSI_PIXEL_PLL_CLK + 1) #define DSI_LANE_MAX 5 diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c index 677c62571811..9812b4d69197 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c @@ -3,6 +3,7 @@ * Copyright (c) 2018, The Linux Foundation */ +#include #include #include #include diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c index 2c3cbe0f2870..3a1c8ece6657 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c @@ -3,6 +3,7 @@ * Copyright (c) 2016, The Linux Foundation. All rights reserved. */ +#include #include #include #include diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c index 1383e3a4e050..90348a2af3e9 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c @@ -3,6 +3,7 @@ * Copyright (c) 2015, The Linux Foundation. All rights reserved. */ +#include #include #include diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c index 5311ab7f3c70..f3643320ff2f 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c @@ -3,6 +3,7 @@ * Copyright (c) 2012-2015, The Linux Foundation. All rights reserved. */ +#include #include #include diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c index ed8192d56b06..305042c29b2b 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -3,6 +3,7 @@ * Copyright (c) 2018, The Linux Foundation */ +#include #include #include #include