From patchwork Fri Jan 31 16:24:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Begunkov X-Patchwork-Id: 13955484 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789B11E3DD6 for ; Fri, 31 Jan 2025 16:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738340666; cv=none; b=CojjeLhIUgwGMijROoL7mhdPYsXytQ/JB7eLlx10ws4e42QqrGVd4r8ciqt3XTGeRQVE+8JSC7alapJpYePwmqhmbkgCii75tsh5rQOznQb2xPIJWiF0EYv85hWSTVr8n0voKWqRg+cLuBjN7jmFT47cdEkJQ/MzWQ4K3cbFmmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738340666; c=relaxed/simple; bh=bkd+Zf2XzomXl3doWyxMmc8SnDDmoa1SNJsmxFvJB7o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fQ95hKs0R/NyPjObOfjm4iNYev6Q7uQyiyHE2Xjll77U17oT43tW1B5i2yF9gISxmy+QfkAW/C5m/QmLTmPIJ/+cG5HSy+F7Ihew1aotmO5ahDhnP9ciEdppNxgO2it77/G133v5/AImtWlqqJeldYf7+g6xUX3fOlYvn2D/N5Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RJVz1rQd; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RJVz1rQd" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-38a88ba968aso1999534f8f.3 for ; Fri, 31 Jan 2025 08:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738340662; x=1738945462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LiWN85FsAMDKk9w97cQXnBLc5+Zh9mJsqs589omCjK8=; b=RJVz1rQdGISQ9tlIxWn77MD2p55GQpuaTmOvdI7q0zobqPjUZbOmv5nG9mNv39CbfQ R4MTd8RRsrDJLTmd8y7tOldXgpmOi366OLnrhPoe/SH36z5hkIENAYmgiYqbmw/AGxam ar4GRs/jhBaOizND/JRYvkyaxKJMi+qNidQO4Qu0BumNqb8PvH7fpIEY7OB7yDWU0MbD xMLQSytXrnUmym3eJlWmKZHRGKd5ajIbjqV2WovNAew+UEEfaX1x/MRAbw/DN9oKGgQE j5XK2WFDExfP/0L49MNUJBbGEvcnRewljrckh0ZKTMcB+Qgkw5T3d81OxCWzJ/2X45q0 5Mbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738340662; x=1738945462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LiWN85FsAMDKk9w97cQXnBLc5+Zh9mJsqs589omCjK8=; b=eoL6hnhTc5DU4+aRfmy1o93lQN3tHMbsF7y694CH2bcgRkXj1Y5M0akFUw19y1g+W8 NVZUfsGJ578ISedZbik1AKoXqsH35LhSDPS/y0masrHDVsh9QKbp1dT0nHU/T7y2NjxQ xC3h56txa3L+py0U3BaH6k2SOF+5nyeTLgMC1l2R7tg8Qs5slPjp+s0IiJF5vxo4q8Ui 2CgdY2TD8IKHF7mAaXe58fANXlFozV61I1MKnYkeGKq2lGNgmuKDRksS9+0wIBsBRZhU 5LfLf8sxq5zADk1rsU098eZ1gZLDL//SWTDmRQDzhqUzBDt9SepfbPdlC7Do3uBVUTA1 TGaQ== X-Gm-Message-State: AOJu0YxurL6L3DOgNHoGayNvxorJOc+JB7eFcRi3QqzWutwPShdEMZK7 d7WPjxCAhc/c2sAI7I4LFk7lkpZFq1wa7FGvwG9XKwtBD5ZS21G5yEaayA== X-Gm-Gg: ASbGncuadZJZs2TlC4+/b2cdgZ+smA0Wne0qL2GTalH5ILp1Sf6CdaazHG0I5e26R76 O/QsOPaLHivTR7SqA4liZWCD7TaAB5iP2NwgiM1MsXfYZFQjck4RvbnWgZZShm6FWNRuR1YANoa LEazyhDAPpPF3nNlGB7jxT5wwseKvFYRURWkrAvBK3uaeI0o7PBO+xGL9Y4soLdG99KH/rdb+Ym CDbe1f2bMtoG0qLULCfyUHS4O14q7VcbX2UNbm8XO2gueiImPxBipC+Ii3IH3ik2ueaSmUthFo= X-Google-Smtp-Source: AGHT+IGCnJySH51qew/XvxoE8kPpkEau1ASuRvxQ2BX4auUYkm+eg+1n9cP5k+U2dR6yLVOaI/goJQ== X-Received: by 2002:a5d:56d0:0:b0:38b:5e14:23e7 with SMTP id ffacd0b85a97d-38c519698a1mr9736245f8f.23.1738340662260; Fri, 31 Jan 2025 08:24:22 -0800 (PST) Received: from 127.com ([2620:10d:c092:600::1:7071]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e4a56587sm323292266b.175.2025.01.31.08.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 08:24:21 -0800 (PST) From: Pavel Begunkov To: io-uring@vger.kernel.org Cc: asml.silence@gmail.com Subject: [PATCH 1/3] io_uring: propagate req cache creation errors Date: Fri, 31 Jan 2025 16:24:21 +0000 Message-ID: <8adc7ffcac05a8f1ae2c309ea1d0806b5b0c48b4.1738339723.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 It's very unlikely, but in theory cache creation can fail during initcall, so don't forget to return errors back if something goes wrong. Fixes: 2b188cc1bb857 ("Add io_uring IO interface") Signed-off-by: Pavel Begunkov --- io_uring/io_uring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 263e504be4a8b..9335144495299 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -3916,6 +3916,9 @@ static int __init io_uring_init(void) req_cachep = kmem_cache_create("io_kiocb", sizeof(struct io_kiocb), &kmem_args, SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT | SLAB_TYPESAFE_BY_RCU); + if (!req_cachep) + return -ENOMEM; + io_buf_cachep = KMEM_CACHE(io_buffer, SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT); From patchwork Fri Jan 31 16:24:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Begunkov X-Patchwork-Id: 13955485 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4052E1E47A6 for ; Fri, 31 Jan 2025 16:24:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738340667; cv=none; b=bPX4ESwq8f/xnVns5gfM3vjOeXrEp6dhQMFVZuq6R/rANbP7OWTDFZHMTfVdkMTVRO7sp6z5Q3qPN7NWb7sVE75WAwsI9MUdPD48+zkLfhsxyxTAGmNiqHABE8rbgccxtcUZSs+9+us9VyhyXFGAg98Bh1WnoOGcvkOi9Z88Mcc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738340667; c=relaxed/simple; bh=Q4n0BlU9xiYRE363wEGsujhBUpR2oikIqQOdkwZ1r9c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mHgGK+zUB617rv1FINVUUP463IKfUtcx4Z0MEjK5O12evU+Q8/rU7r1wYTkpaOjN6RhMz6U5MPURKy3Gdoya/OCKrXiPBn6XqE4yPly/bHOaF+z0+0yLfgrUDu3dgULrEixGco8GqrTAf/ixTS4TUQ5RyVOOcOVdcYa8dQoWuhs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hCQki0gE; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hCQki0gE" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5d4e2aa7ea9so4579798a12.2 for ; Fri, 31 Jan 2025 08:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738340664; x=1738945464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HsiGWZn6vGNty14t/0TTWAT1Hkfe2j70nTerz+KVhvE=; b=hCQki0gEfSH/NKXGtX2OWgQuhZKHZK/5qD954jun7quSPA0FYhJQDBv3m5C5NrKgBS VdppfME1M+2dY/krGqKorJNbkDMXtk8v5YMoX218Zg3TudMyV1YXqei1UjYa/EgOMM6e HElQDOhGKJ7j3otNoTMZUxLPBOOrHjbQ/koybQyWJVpbjEPI6sWj8llnILy1Vf3G9+r4 Bdpqt89N8PsPwsXxg7qORNYH5o5dT9loZqWEivEtP4TXhTLh/jw+JeajC7MTNg/IR8CS 1Du0XcV6/vVFYadjJ3xiEczQa+POk6eeCWrlqR112cpILIui66kAfI17lOLUD87LeQVV CGBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738340664; x=1738945464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HsiGWZn6vGNty14t/0TTWAT1Hkfe2j70nTerz+KVhvE=; b=jfHMbrR8974EQQ2ElLQ2l8SZ+EnzpVcqSYKYxJiauBoGMcjaVjfXqTmg4uBtet/lki Cl7Tr7UP0JDqs6MxJvN/b48YwOdRBCi6NaQoXc/bXidmdKJ0kfNZcnQ+XsdLtk6L0tDK 2R45KBm3AEit4jGFETc70vTwxz4GNWSRJFTC45OcrvGZkw8JHoAjNMTb8epAOzHQCqdv mXsw+Jx3tRRqMZQVMdieLrOEL9PW2odmu7xlSAHCrxxgrNLFwkymHc9TKE9oVfg6gHW4 cijSyhwpznhP1IKOEWqPyfGhQj/CiurJrdzIS5wD0fg8+cgJzlJK4flphhlbrsOaY9El JqdA== X-Gm-Message-State: AOJu0YxDSdfHoaO5JD59r370Z3VwsyOkMO1lhAzaugiKdxX9dVt+KeA8 2XWbSLq8IfxB85OlDNlrFp/tzDa6DSywARfSThEZAYq/9iXCg3NO0ey6kw== X-Gm-Gg: ASbGnctjUIS4ezd4aYpvKj2j+1pZv4f+SpFOC2iQsUIcyxp1KnQsgcTQj4S+pLexTRF ncLBk/CZlOlCaXsYetcF2AOIQJOm5PFPnuYOuAvLiJ/Chl1gdylKbK/t6vkyDT4GPLTmhIuXx4P GKt13fM71eb7N3LLTWfiXHhCHBSTS8kKY64kZhfx+cHLQqvFQCZF+Cdk4rLNXKcjgM2DvvQVCSV fk6YIPf3amj1sdvlwKI8EH9ThX1SltSPdMvPvYpIJx9KeG079gl/J/EYSglaVBe017HsoVRdPw= X-Google-Smtp-Source: AGHT+IEKlKEivl1r1d5w+zgkHEQhkBEpSf8qTddQGk3VmvK7iSeZIgxtxq9vyuZc07BEsQgrgNFwfw== X-Received: by 2002:a17:906:da82:b0:ab6:f4e0:320a with SMTP id a640c23a62f3a-ab6f4e04bddmr441891066b.21.1738340663922; Fri, 31 Jan 2025 08:24:23 -0800 (PST) Received: from 127.com ([2620:10d:c092:600::1:7071]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e4a56587sm323292266b.175.2025.01.31.08.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 08:24:22 -0800 (PST) From: Pavel Begunkov To: io-uring@vger.kernel.org Cc: asml.silence@gmail.com Subject: [PATCH 2/3] io_uring: propagate io_buffer creation errors Date: Fri, 31 Jan 2025 16:24:22 +0000 Message-ID: <139e48488d160a13e81b170fe0499c4b756d527b.1738339723.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 It's very unlikely, but in theory cache creation can fail during initcall, so don't forget to return errors back if something goes wrong. Fixes: b3a4dbc89d402 ("io_uring/kbuf: Use slab for struct io_buffer objects") Signed-off-by: Pavel Begunkov --- io_uring/io_uring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 9335144495299..b05580c1a6424 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -3921,6 +3921,8 @@ static int __init io_uring_init(void) io_buf_cachep = KMEM_CACHE(io_buffer, SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT); + if (!io_buf_cachep) + return -ENOMEM; iou_wq = alloc_workqueue("iou_exit", WQ_UNBOUND, 64); From patchwork Fri Jan 31 16:24:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Begunkov X-Patchwork-Id: 13955486 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85EE71E3DD6 for ; Fri, 31 Jan 2025 16:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738340669; cv=none; b=m3xdw98xC/FIkRekmMS3dqDpukZcGxvm1DJBigni/3z6l/scKntOh4pU7C/F/J1oFw81l60u3pkDEM9zQBrrz0GDFqQ+tspPNushFQdHtXjhlvBWL/GD2Ugwt5m/mWmKdCjjTYfRmZI5nm6tG/356jAgzUBczxy0PaJkRKZ5xAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738340669; c=relaxed/simple; bh=RojzI89zRcBAtwxUQpYd7AyKCGEom1915DBoAKmnGNA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bB5cs382YuHaHYem8M1nV8gyvgkXcsZqYOJa15lx+RNQXV603qZPnw+3ZD1TjwflE0PyzPyQ3nQ6+cXtujg9iyk2BPAQvUduCBefmG2uV6F/Ul4/ltVJABaEagGvTsjxPgOb49yhNaG/yi98G/SJGi4H8dwlbtkelcuFCGTDjas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aIxWJgHe; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aIxWJgHe" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-ab698eae2d9so432019066b.0 for ; Fri, 31 Jan 2025 08:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738340665; x=1738945465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/MG5ukT4UriAnTWgSKLhedlVT0jI9uEOg2wz5KlXJbI=; b=aIxWJgHeCP+G1wTMKMBPTtp0OHvzW+elhrhMeDd8nsm3as2/s9CEkgWdHQbQT+2MGT Sd/laPL/7TqKiV8UwqpcJFI4Pwq/2wm4EoSspMDk40rFQzu/PRFouB42w62NF6v77fQg fzeWe+JggQLGTBK6WnSTvlitsj9MzunI4Vi3bo8+6CU32gJBlgU5d6S9Lw/QbnlXRMpJ pEhQS+XZCXasdC2+AgZPuIfz7DqGx9Q4Wlia7/92DfPJxqHrxiOPR6mcaMCyhvEkzwQb 0q6MMCZGVeIR9A/H4MU05Krh5MLSZWhEfis/bmcYWw3rdKHqYePnrA0o/Hsc9TpLsxca 6VHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738340665; x=1738945465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/MG5ukT4UriAnTWgSKLhedlVT0jI9uEOg2wz5KlXJbI=; b=bXc6wSzZhtFGfJzFFBKXVHsgPuc6jNzq3XW6XEC7ZUL/0X8YORN3BAx4gfeTzSzt4W rLaODWWCuIlB/5m9OeAP5OB9JrOSV4mhJNIRIVpHhoe/XeAEuCkwDQgJtIbbAzVCWU8j Q4HtY08nZwPRCxKX7SOtTNcMHA9mX6CUvqTUkSY7CLNsvRoCynIov2EtNH+S3/CpCkun sIAI/K0r1o6jlj8auGBGI9FJKqvr2bs8O+53c0NTTKf04KKawEAIeOnHajFDz4bB61ue lNr2YIIAK/kfAzFq58G7p0ydNYQe6kXDotyjdj0Kw9+cqlW6in3JhT+vNGVMsyhqBa0C C/jQ== X-Gm-Message-State: AOJu0Yyc07Cd8FYE4qBDwhWc8o3GMjmHJSQTFBRxy10Xop6+Ju/U0VBG cq9DyswVBoprXYQQhMRu5/2fbVMgDM/MQN/Xf2kpKz6BozpdT4DW5xj5xg== X-Gm-Gg: ASbGncumkrBSvjvg6/bGbyqJVXGdt8sIO3t8ZmIx3Gs0m7vF8KvAiCl1EMWnk/AzAKv 1Gyrni0/FvZml6X1/oLmo5P/kPEJjsdOG30v2/N9DhzKeIVX82Ngc/GHHR54UsW2Fxm26U0f96E vQbS0iIAdu7EpCIiNWJwh7S9jFybdriLoai/PhiHxvBC95lSZHrzUqIEtr/DZnmrmn6xfjwIJhw 3MKGl6LL3yJMKNasptxVbZy3AXDYiSo9v9XhWh5X23GkChMbSKl9dF8BCITS8izQJiuuvEkjlw= X-Google-Smtp-Source: AGHT+IGXFJqwAbcNvGJRJENIllDZTb8AHcShP2Gs5TGbxbCYfVvNbwo2K5iM7BrE56klKcQ0OHE0ow== X-Received: by 2002:a17:907:961a:b0:aac:619:7ed8 with SMTP id a640c23a62f3a-ab6cfc86accmr1427177066b.7.1738340665083; Fri, 31 Jan 2025 08:24:25 -0800 (PST) Received: from 127.com ([2620:10d:c092:600::1:7071]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e4a56587sm323292266b.175.2025.01.31.08.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 08:24:24 -0800 (PST) From: Pavel Begunkov To: io-uring@vger.kernel.org Cc: asml.silence@gmail.com Subject: [PATCH 3/3] io_uring: check for iowq alloc_workqueue errors Date: Fri, 31 Jan 2025 16:24:23 +0000 Message-ID: X-Mailer: git-send-email 2.47.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 alloc_workqueue() can fail, check the result and return an error back from io_uring_init() if needed. Fixes: 73eaa2b583493 ("io_uring: use private workqueue for exit work") Signed-off-by: Pavel Begunkov --- io_uring/io_uring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index b05580c1a6424..78a6cc84304f2 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -3925,6 +3925,8 @@ static int __init io_uring_init(void) return -ENOMEM; iou_wq = alloc_workqueue("iou_exit", WQ_UNBOUND, 64); + if (!iou_wq) + return -ENOMEM; #ifdef CONFIG_SYSCTL register_sysctl_init("kernel", kernel_io_uring_disabled_table);