From patchwork Fri Jan 31 20:24:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955736 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A3341F3D3B for ; Fri, 31 Jan 2025 20:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355092; cv=none; b=X18pz5xLv3KgxzcTCFcYvlV1fdnG1ctKWvidYt71n67lw80u9FQlLxF9rLvPYiGpATIgLe4fI98H7/Qsu+9iqd8uvPVE3INCTmp2X5C8+7VSrTrT75DVKNakkmqdMGJa6ljkst8xwJxab/eIfUewWbCA/ma/ZyrtEhaCZUD+IzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355092; c=relaxed/simple; bh=oe7N+J9cytrMnLNUSaM/Omiuuu90wAztekXP99d069k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WgmBUAW9u65h3NO77iM+TaxZNrVuzvNAoB6anGB2YS622yXO9TRpYLh3aL+r8vacmByb9Yo7xcx3ed1hwFwyWzHzzCZo1UCttFQ47W7r5illFcGywhDndSNnqBr5mZ8PAnuhVXM6ivNG9D6wonRgc3kWHCIk9g3ustYGNaZlX6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ueZMN8Jw; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ueZMN8Jw" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-2addd5053c0so1229758fac.1 for ; Fri, 31 Jan 2025 12:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355088; x=1738959888; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VExoELcV8x0LQmV6C7xp1BlVeCvht+mgfIMccHi3FPY=; b=ueZMN8Jwvfxq+NQV2mO6jeS6cQV/cLFNjN5CTUYEa6sBTQguN+LLIxjtEH66QaMmTv XaCz6U/OOKgomm2+nMFBh3Jq0MDvqnML+yfPSg+9kiIMSTzypHAweQ1bYTTu+3SJrcDL vZylBg681V64dP87Wuzi78d0D7c2GNNuGOdiHWrZAluukTm3GzBeMn2N9Ghv2m+O3Hbm ZKkFmBJjdgeHQCcdgi54aa/LExPrwHyI+pTx+2dIovWscRu/P8n7+X/MXpEQENZjzJy3 cr4AVI8IM5sgwc+kmRMXyAXLwJS2HVPbD2CEKjvnhbEYUC/k4CnpdgzfO9JddltaCvwo Jh5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355088; x=1738959888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VExoELcV8x0LQmV6C7xp1BlVeCvht+mgfIMccHi3FPY=; b=WY8wUynX3bViHnY5D8NjZ05In9jNf+OhBq+RFeM2GhH98yc4hWhvywr4GRAOm8wbVw +DzhTAWgnmKfBCQUeG5kqPiXRgyRJ87eAjxl32PBLOlukY5XxumQMd+g7aoYiScD1d8x gb4or0E2TGBHcCdG5Hw9JufKn/jdZLwU/ZJhk6aTu6h1yFVbB92v9Xi6UlrOCEGXJ7b5 Xwbj7Fnj0qvwjiN2BF/DxCcGtV8xE/45V7K1ufNccgdX1//UMjLNDaqdGAYDqOBIdbqE dErIfBvDGpYypfIrHsBMf7nblH0boXH+APBM6FXSg7LaaElyXgMlILI6LLO7/rUPwdDS /Rgg== X-Forwarded-Encrypted: i=1; AJvYcCXHANhgjL5qUp/WZhsfIjILIL/fBuRSn+vSSqTHtlEMY9LFb0vHl3VSYQx9UsXTwuVbN2jfBioA0h4QEw==@vger.kernel.org X-Gm-Message-State: AOJu0Yys7WKTKHw2xkyeU7xAILC3vRR9oR6/dcT9rxQzoQnkxKvQNxCu TTmNE05BXe0uICC0z7a4LnY1IZWvQKuh7bItbFGyf33wXCBF0cwz9bMQCCCPRWM= X-Gm-Gg: ASbGncseLIAmv6sib8/jthremsUKre4r8XT2+LMvmZFnzosTAlpYCORRoZtKZQF4MFM XJjH5aG69r0Rq0o9C3fn77kXBXF00RIA6v7HIjUOwWlwH3GAPbr3c8rEoNYW9MMxQP/EcOBknDr I9pfGLLsQ1Pqwhotv7rEpXfTLtDIPZoVhD+wR606a4nS8LSm56dT0NsycoDuGZbNwINfaEHMc9u 45/GKnCy1xI5h0dJe5fsj9Ih3Z4sCRMcZ53w0n1Pa7Jrrs93H9R34xCB6RVV6M+nI4TVOXLjsqI 9fOnq9DvPp81xSl3W6fHZ7T/2ubO4AGH+7V3Sf5lInNOMhI= X-Google-Smtp-Source: AGHT+IG48amD1C5d4QahkI7FJNfsOoMi2CtgfNG8+gnzn0CcyJBNzM/PkTQMiDNqV/T79ZK3cKZLjg== X-Received: by 2002:a05:6871:a012:b0:29e:5297:a2a7 with SMTP id 586e51a60fabf-2b32f3ca389mr8811438fac.30.1738355088436; Fri, 31 Jan 2025 12:24:48 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:47 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:41 -0600 Subject: [PATCH 01/13] gpiolib: add gpiods_set_array_value_cansleep() Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-1-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add a new gpiods_set_array_value_cansleep() helper function with fewer parameters than gpiod_set_array_value_cansleep(). Calling gpiod_set_array_value_cansleep() can get quite verbose. In many cases, the first arguments all come from the same struct gpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate. Signed-off-by: David Lechner --- include/linux/gpio/consumer.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index db2dfbae8edbd12059826183b1c0f73c7a58ff40..1c9bb3cb1ee80fe52aabf5bd24b1d128eff2bc99 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -655,4 +655,11 @@ static inline void gpiod_unexport(struct gpio_desc *desc) #endif /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */ +static inline int gpiods_set_array_value_cansleep(struct gpio_descs *descs, + unsigned long *value_bitmap) +{ + return gpiod_set_array_value_cansleep(descs->ndescs, descs->desc, + descs->info, value_bitmap); +} + #endif From patchwork Fri Jan 31 20:24:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955737 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 804631F4268 for ; Fri, 31 Jan 2025 20:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355094; cv=none; b=Qeo6sJzP9pkDcx426puoJinVEIQmNx7fJsLF7MsmczBLBHjp7NREiCI0GCagvVkWCXhisDMuO4XFtmRUhIpRPrMWlaeHHdjtX03NE17Mnq62Hbx/HN8PH8QfMPaeUJRj30wYAJHuh2+YB2U33tlXzQm34OcvXqh2tzn8MwhuM1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355094; c=relaxed/simple; bh=rw0sTpvokUQNOxXktkwUiVgyBWFEQak6z7kbvwC+d0k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YsdBzx7bFOA6RWuAvn9NxrNZ0MQrgsBp/zgoPcs/HQwypM+iLs4WRbrKAORTLU5YUciL0q2F5cPGajLUTVYQSr5WRAu9rvAXLSiafb05tKRfyZ07hK4ReIt+p1EGWbsXmDknD6wdna2fiAyZM0653kcvWvrcTTmDkpWnHOmDgCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ig2spnB5; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ig2spnB5" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-29fad34bb62so1325928fac.1 for ; Fri, 31 Jan 2025 12:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355091; x=1738959891; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8Y1Uq2vC9ngxtabj+o6Gf/0MmnPKx34MFqyZVe1ZJHY=; b=ig2spnB5ORsHBPO9Y7nXycafF0XrCNtyHpbBQiJlFhRCJzhD+P63NHG7Yc3+rie4wo Mr917YqOD9SDmep54TVk1MQRWPTZklSbZHJI0otG2bBK7sL8CU+OGhyYSPEut98gL4Am /OamnTc89XUpnCD9s8nMCU1Yp2t50dPGzeYwrwj4B0whOWNhTdqOgAGsfB57FU3Q7ibZ +D2hbdgSPZW/fxOr2hN2CCrhN6U1bEW+MkJXEhvm7iZ0xdvgqfME5m+uCnNVxhEQEJMH Lx2W6FXmvSWHlwbKU0a4TJ/gjeqx78VIr5vzW4+lr6aucRQxdzZvzXh+n5sjyaEunDVz 5L8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355091; x=1738959891; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Y1Uq2vC9ngxtabj+o6Gf/0MmnPKx34MFqyZVe1ZJHY=; b=PJGNB7VjU0a7o+B/ov0o2fgaFJflX/ULEQ4mxZT89yAfE+ZMYPSWW76wKkpfcJ4yV6 eEfbQZH3SkDxvvqWF4CXHiQLRu3T7+bOeOqOWHbkygdjUjPyfB0JyK/waqSeZtv80vYF ieow+fnb/jjJHzQ0L9/oB+NugG+ulOrdCsGzzGz00Zm0AzpXO2x7qWMqRaLoxQkePgmh SKQAb7sUYZTMQwEYmj+hngBhwivu1HwNS+sCYzNzDFT24gKpB0DHTxpAjbrkHXu18o6j 3geA0yVb99G0xgdUm80GF3sCkMEfNBGxk64vml8bFJlEda6vcXHuZ+5JCL69B5Gs9sqC 1T1w== X-Forwarded-Encrypted: i=1; AJvYcCX3EeXSflexAAI52vEm8nYV/1xkzQrmpZ52XOLEsMUUbkBz07uypaJv8+r6oCMJj0nblQt3Ey6T1AOn/g==@vger.kernel.org X-Gm-Message-State: AOJu0YxBdbnzZgiH8fsRJwSPQEd1IZXoLNvYpFF7vVRIPy+vf8tibPBx AhGGe1tLJ7XfroY51Sc2HlHOvS1uMWlJ0vb+zjGdE0PwE3/CAXRvbjttxULHw/8= X-Gm-Gg: ASbGncvHJrLlDGrRCrOINDpCfmm7xNCPKcuL/T2ektkWBn1hYL4hBQ9jeJPwLo0FbZo 9Uc7Me2sUupFuHW+pAi045EvYWqv4+hCfdh9ur/lcCYC8bYdsIG8izRy0co+Wu3JSB0SriumX4L vqYBg8NGEymkxxy7aoCh3td/C8dEuGAXPzuzVLbqh7xk3QxAx9BJRdD2EWt7uhXlVOTuBQyoaXU a5/aFXj+2W8ZI3N92btGae8kCwqSEPMzxBxhIqtIfF9bBVOwUMgyKt2n5rqj3rhLJfwV/oDZzCb TZn5NgYjXM0uLs1CZKekttJzrf+UBnfrqVulayXxy2A0g8w= X-Google-Smtp-Source: AGHT+IHpL9OiC+7p99DGjWrddY5GvJC4qVZT5ABdvIbOzG8MeWG3IwFdHaR/KYiBNOSR8xIQZbb8jw== X-Received: by 2002:a05:6870:ff46:b0:29f:ecfc:32df with SMTP id 586e51a60fabf-2b32f02152dmr8447581fac.14.1738355091503; Fri, 31 Jan 2025 12:24:51 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:50 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:42 -0600 Subject: [PATCH 02/13] auxdisplay: seg-led-gpio: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-2-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c index f10c25e6bf126cfaac3e4c353f8bfc6639d94a60..c158b2c2827415e75d0b122914b8b18c043e8c76 100644 --- a/drivers/auxdisplay/seg-led-gpio.c +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work) bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), 0); - gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment_gpios->desc, - priv->segment_gpios->info, values); + gpiods_set_array_value_cansleep(priv->segment_gpios, values); } static int seg_led_linedisp_get_map_type(struct linedisp *linedisp) From patchwork Fri Jan 31 20:24:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955738 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B52E1F4296 for ; Fri, 31 Jan 2025 20:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355097; cv=none; b=DRxtctD0wNAUgsqPoZitiHm0e0YU++uz2FxhiDdnZploMXYASlKxAghvO0UcC551Yeqq9AIULmTBmhSdo4d+n0ZVtP6j3RrkM1xjuTrh4koYq29n/vQ+NiYuYcefFrHi+f7NNpQ/htTPP0lUq3nCerJtSN/KBKFwK8SgvBi8mDU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355097; c=relaxed/simple; bh=KSnpvBpYf1I2zTKJ1PQkgSeFWmdqfKH1K8H306V9HCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kD/ijQA3dIfIVItzcWUyf96LVZ3NFO5VP3gsyvSmlTRWHm/9xJtjKC0Fw505aZVqHRLeuU5HDdWnYTJ6b3GSj+WsIzkm0oIWaYkap8ngDglSiSkpDUhsCS6UNOojht0QKHFLE++urz30aJZ4pTFmRjkaBof2IWiafOZOKVIaLdk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=kHPWQe4x; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="kHPWQe4x" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-2b3680e548aso934583fac.0 for ; Fri, 31 Jan 2025 12:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355093; x=1738959893; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=g/d91jflGtqcHyVEIBk6nu4SgcmlMkVjeTIYU/X9iWg=; b=kHPWQe4xfcF8hLtkR73pCTnp9JC2Vm/ElpZTPXHBFENS4iT24APePUQBTkbV4+bEA/ 0RhMD7TIunoXPctqU2fPlCrGa3VuP1xVpfET4CmlHHA1RSayvsnIsckNhUuiwUOXGQmV xa2xA2Ch6zTxl5kOtM/fsVWxGbOJ2n9EuIGsxWawKEj6TZ9BneYxeOYrFCRo5FzBVbX8 5SQoMARcWE3CvFe+zbojReetgvJiknmmYk+Vzq++6AX6SkxKURkZKOduwIkDOp1rr46X A2gNeYU0pPxNBBIic4gouY0tM+GFGx3F/Id9f/o9Qc7JiUnW8AEMLqd+xt41yWYjYJMg VJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355093; x=1738959893; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g/d91jflGtqcHyVEIBk6nu4SgcmlMkVjeTIYU/X9iWg=; b=hp+OS0k88phrquw73QpfZzBpUd/UJpwTvx+BhvcqrApPdqL3ARYzEJvQc9c4vKcDQR K1SEALXJHAyZeY97Au3Wyzmz5gnlAdkKuPP8vJRCEdMLX+JOtEFx1BHY2YV9x6vASCii gS4LshFuF5/7cLLHPPUaikJns/y0TXAxaa3LPJZfLxhFK1AJ1bH+YrfgaAuGdU4tnMpU BwkGxNUtgp6Wnltf8QvK3x7oPl6peW0UWJYpqdByfbtaUEwfYexLJtv7cFqF3wDMzpve O3OIXCamoOry/OzzKJUdujBs0NLcFgiNMLbFJQJ09fmTgv1fyBBjTo/F3rIH9XDeSEGF w/Lg== X-Forwarded-Encrypted: i=1; AJvYcCWdcnPx8BSsySZJA54UflQbGwkVM+ht8sgWpRXMZUuVdvbtnE0Ly0T53CQQcfVBw3rBHtrW6OxE97lrQg==@vger.kernel.org X-Gm-Message-State: AOJu0Yxd850Lx9gdB6Dbg4IAbbBkd3H/wcbgZ/FsOffdKNF3feMsVheA Tb4wn1C1CbrbO6kSgMljDruFnnCxSUElrf4Bt+zB03pkDMhtJCYYtQhXerkKedM= X-Gm-Gg: ASbGncv2hAPdc1XtPszGziWJKCHDXkvTev7kQPCyOl1NSmQuTd4mCA23cexY27xqL0B qe7yo9W5hn/28Aem0pUB6kKkddTPv2l7829jKBpE+FCZPs2vODIh4k3qiAMdy6r+rR83Ip9tFjd F/Kj+EsOUYViRyBS53k9z9MbUE9++12LIv7wIRszgA103TnRArHVh9uNf0dR+qWy1Fiub0wPqPr 2mCuWNdYrn64wl/+1Xlw8tfsjUVFVnruIVjtBLn/C9hClAoERLcESMXPIFRJ0utPIQci3doXvsS GofiY4ZEwc87SOL5mXBlfAELUvfLIhBekV8cy0gN2OBRbLw= X-Google-Smtp-Source: AGHT+IG7MwrRorXxkcWjIdgGK+4mzXkuq9AO0FFEdnZrk7oRmiSNnPUZ/DfqxHivj4lEixFczChGQg== X-Received: by 2002:a05:6870:d1d0:b0:2ae:d23:3c2d with SMTP id 586e51a60fabf-2b34fe99372mr8034579fac.8.1738355093684; Fri, 31 Jan 2025 12:24:53 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:52 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:43 -0600 Subject: [PATCH 03/13] bus: ts-nbus: validate ts,data-gpios array size Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-3-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pdev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); + if (ts_nbus->data->ndescs != 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn = devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), From patchwork Fri Jan 31 20:24:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955739 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2D581F4712 for ; Fri, 31 Jan 2025 20:24:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355099; cv=none; b=KtSuTMDLByGCKuZZqFUdieWOzaV3CmVBJXLC8vWF61z3EWPUTUrVes0pzW9oTh89V9pJxWhOOewc4JZqRIlPmPPrEZDJrHPt+FgP+bglGP8Kpv+odzVe63AIcCPbnYLUsd1ZK55JXFtMjjB4wEWcy7AOUrAtW9Jxe5zUDLjEOdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355099; c=relaxed/simple; bh=YRrA2gctgtC9TxPdq1m76F+qrw6XgkoDj0DtVE83Qk0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ka20YwXyfBb+AuLqpwKTzekzhFr9F6IL7DGCficfcuycHN5yCXjATc7FRfI568hojhEuORvni4y9VLVzAw0Hbi50j/V4e7FlrI2dZr6RWCczIZ+VmKLK4BbPzKWrFNyl7UIoPPQi+spMkapFdn3RF16a2PdoMVI+AGo+4B5OY64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=NDdrGTEY; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="NDdrGTEY" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3ebadbb14dcso1000382b6e.3 for ; Fri, 31 Jan 2025 12:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355097; x=1738959897; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9hlyYXLAXkselsSNF7g0Bc64z/LNWZ956QqcL4gqDjo=; b=NDdrGTEYz2np6Cl9evbzZyDhI/48wDzwH/V/o9jhCus8B4Itu8rtWCN/G175aqpP25 3eN2VqFSu9aiy1ZSMHmmLkptNDCz9pnbscxcAVeVAAo06WrBVIdJpPMOJm5BBI8FDoqK Eltr9akLCmJcgQsHWwlKFWyNKrPq/TobSsUsiKO7MfKwJYJ13K+JJm3yuB6SD04pnKCx X6o8+4mlL90DOWZMwDwgmw+TIt0jiDjrtPdJpGiQgPObMN8rKQdhwmE5e5B8djmy85YE 2MPRUnZ2SDn0IR9qnz+NMVojogLOoy2OvLOg6eKcXggazySkyKDBDiMcPFstObe2681I XOpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355097; x=1738959897; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9hlyYXLAXkselsSNF7g0Bc64z/LNWZ956QqcL4gqDjo=; b=sIslwpkIq7NulIa25d+eRLF+W4rZvQI8sxyvHxCnJtSCaxFUPjQPj18dr07aEVTqyE 8Lfx9NOcMJ+eZ393OHfADqfWtDTg3VH+PApRM7JlJkVLZVgPkAYLPIo0X+TfhLv4vHOm yFbO8HdTmGtuoz8go3ZldwOGvBRxnBPbX3NwDgnr6/H0ovZl1tIvxdkveKddlDtrg2mp Tyer9ZuQb9LKzWsnCj5Ve+YPt5Wdk6NkTFVudUVIbGkQSqXVdzj/57U6EzC/EiMAg7Iw mUtyU0sbLyNxAce50iHWg68wreQgoTMmq3ol9Kp4XuYpOzItLKHgHPUhkw4qjDjzwViY i3Bw== X-Forwarded-Encrypted: i=1; AJvYcCWsN+KM8LaRzPz4gSjygB8kGKOdq7IcwiF866uPG+WEC4AiUpKvQaWQ0cMrJpQBfz+XEPCMpZ4tQpI+Hw==@vger.kernel.org X-Gm-Message-State: AOJu0YwIlBowntY8sYIxVKxD6WPFWTr7GbtGhVrsuPpdRrwKQXxTxmd2 EIZ9GjKObOvfuQI5ICEibEoDZdANcVFbJq2K8oliLoZvROe/p1z/8ui056tqRxw= X-Gm-Gg: ASbGnctACGUmim4A46ryANcIza4eQLmoMCxiETzpa0w5GTrCaitTRItqPiTpvpCNsgJ wMwDNVq9uMX6kKUsqxblKnZjxrpxuf9xm2G/r4rBJUgN/GOC9CM9bYPz1qNI9yTdHYLWpJ45YYj FR2TYSGmN7HvoxPp0IbL6JM0TWS6GgAWwoO9iWoLEvHFUISgMEfuyKdCf/62nz/W0fJIj9FOidj AwmjVu6fRmhQIu9IEtbvKt2ffcrTEUr6kuRZ2ER7yKlVCV1zxL7Tq/vR0SllyeyMhQWunWqlN3+ JmJnvJ3cPFFxMgF9eAcBRiEoxMcs4aIg8GgjNlZV/L+WzDA= X-Google-Smtp-Source: AGHT+IG22JJZ1zoEE08gl8CxgOf30mezmJIUs5PEqf+3dMT59zSIuFvgdvLgZxy1Rl/Rs71gFur6Bg== X-Received: by 2002:a05:6870:2dcb:b0:29e:6647:1080 with SMTP id 586e51a60fabf-2b32f07b26bmr7733897fac.21.1738355096771; Fri, 31 Jan 2025 12:24:56 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:55 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:44 -0600 Subject: [PATCH 04/13] bus: ts-nbus: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-4-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..31ae9a26257c3e0af2ba99666e0c04e882da935b 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) values[0] = 0; - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiods_set_array_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios = ts_nbus->data; DECLARE_BITMAP(values, 8); values[0] = byte; - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiods_set_array_value_cansleep(ts_nbus->data, values); } /* From patchwork Fri Jan 31 20:24:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955740 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1D941F540B for ; Fri, 31 Jan 2025 20:24:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355102; cv=none; b=UV7EGilioUm3+Yapsj0Cn1Tp82W/P7SF9fIn4fwyRmvUWWuP1lDb2awBMFlkQ9I19rK9J+41frHT0cL+yyJtDcDrwDqX6KTogQeLdtTIliPCGOfEn7jw0jrCUc+pA+f6tYxQYIId+XXfLEj+aFTCHMsQH2IZZXYjjUrtyugByGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355102; c=relaxed/simple; bh=Y984jgguFlZIBOThWuuUJpuuUbC3lQREEzsrrqDNozE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZLaJvWoASXCMU1Js2UhWOL/J1ptGMdLuc5dhl1INmvqKmg9X7aWFMbDJNGxtteGqdP3wzYYBlRxJk35xlkC2bqqDyjzomI7nbkneQT8QNeQedxe8IbFjcr1GrU/UnzXzrWWo6gE2vCKLUgrMKrBwL2cMzV+tN3h8K/8Is+u3htk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=g6MnSnqm; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="g6MnSnqm" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5fa8fa48ee5so689739eaf.2 for ; Fri, 31 Jan 2025 12:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355099; x=1738959899; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o0JxocTLtlGRqW6c379kuZnM3hX6Je635Dhf0CbFSJY=; b=g6MnSnqmPtos+/Hg7bCHWyJKjyq+TDTZqQp7OZrONvvlcKC/VYH7QgztlisRLGBmdQ jghEuXFMKrOniW4QAFgqAQCOipaZgdbpuJ2O4hEfYH6TL1LPD66bsT8BBIUmC5cK5oXY a3WzaqU9TOr9tJbZlFvfxYd28mIK3gM++T93/iSK0iFNb/wyxXP5FCzwszwhwIwkWzPF Cf7b4jyXBl9ahw4wJ+Dwp0erV/pFzP6ulzDkKc2WOMQkoWqUs0lv6OwYa4WGFYdXzh04 EW1bOG18E7VCvYDsAEcFi3H4hFINROcY5yuREBrnlO8RR+FZ0ZCadWx38i+EYlzpnau/ dkSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355099; x=1738959899; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o0JxocTLtlGRqW6c379kuZnM3hX6Je635Dhf0CbFSJY=; b=EnLsz01zoyj+589lbTflu7Rj5Gn4uzH2tpvzCJ3xdB8R/vOTdzQAwOucVtwXmWbdS4 LN/OCzAJzhNzt73FWWeGIJXpK/gEZyj08PbW9ikSuTYryAq9wqmUAHwcRGjTtO3MWdmI OpPhjV75TWYLcNolE5EsF046Ky7Yxifsmyb3RMqmIYslLAea/zmTiFm0KQG6tbjeT7+z DaHPRRh2DHVkh1R53XiyMjDdZ/xBnBGZILw8tAcO5JjQZFDfp+0XWV5XmBK0YRBsAxe5 oTAwoyPLJK/Sg5AAdBPHzlDEWLM7j+w7iyx4pEPW+tQoRCJsv4crj4WBzArQAGuOaUCV Nfxw== X-Forwarded-Encrypted: i=1; AJvYcCVGpEJOOTs45JvZAJ0UjLyFAa7qk2cXPUZ84zCCwCjMJ18pVci6UINqa+PiC6ATm3EWrhkEu/5y21hCJw==@vger.kernel.org X-Gm-Message-State: AOJu0YzVdh/P+VA1w8bSIb9ZlHs49a6L3D6ixQoNxQcyM5/Ykmw1TKFR v1WmihdI1CuzfJljj4LULXoKbaHIOyzIy5QSpAmC2Y0qnOurKRWONaZEw7mFY6A= X-Gm-Gg: ASbGncu01+G4n39xSofDoVUCqF3eC684bLMhs1H6hKbEGJV8SY8H/kwEISJWlmt8Z+2 XSe8+kcZL/kg0sGQaSe00zrfTvzX7+qzkSQecGqRCzYlKgWdmNHAI8RChZEmaecMJvhA1wRnOPy k35Rqc9NWQ6JvIBqpjHRanbgbQ8uExSjCrMmFQ+ZnLGrrnfu5JZ+e3PkodpcyDCDlhLIx6wT6du ul0LQWw2EIU7nl+vVHzEoOKLbABp7jaNIjmA2Df1bjvw7yp2oeiA2Lrc4QBUxWYQ3KT3JJxl8HY +7Wqnq6Hagrl0Im/2z/y8uTAwacHN3IxH/dPpZ+gog+sR8E= X-Google-Smtp-Source: AGHT+IHLLvw8v92D1IAdlvToO2DW44SjM8+FGXyX2n6gPI7BbY77buvq2CWQaGC5P0PVhdqadGjO1Q== X-Received: by 2002:a05:6870:948e:b0:296:beb3:aa40 with SMTP id 586e51a60fabf-2b32f350834mr9144614fac.36.1738355098867; Fri, 31 Jan 2025 12:24:58 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:57 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:45 -0600 Subject: [PATCH 05/13] gpio: max3191x: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-5-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index bbacc714632b70e672a3d8494636fbc40dfea8ec..fee8dd2bd3c9eb7c06817430634eaf905cc9cbd8 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -309,23 +309,21 @@ static int max3191x_set_config(struct gpio_chip *gpio, unsigned int offset, return 0; } -static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, - struct gpio_desc **desc, - struct gpio_array *info, +static void gpiod_set_array_single_value_cansleep(struct gpio_descs *descs, int value) { unsigned long *values; - values = bitmap_alloc(ndescs, GFP_KERNEL); + values = bitmap_alloc(descs->ndescs, GFP_KERNEL); if (!values) return; if (value) - bitmap_fill(values, ndescs); + bitmap_fill(values, descs->ndescs); else - bitmap_zero(values, ndescs); + bitmap_zero(values, descs->ndescs); - gpiod_set_array_value_cansleep(ndescs, desc, info, values); + gpiods_set_array_value_cansleep(descs, values); bitmap_free(values); } @@ -396,10 +394,8 @@ static int max3191x_probe(struct spi_device *spi) max3191x->mode = device_property_read_bool(dev, "maxim,modesel-8bit") ? STATUS_BYTE_DISABLED : STATUS_BYTE_ENABLED; if (max3191x->modesel_pins) - gpiod_set_array_single_value_cansleep( - max3191x->modesel_pins->ndescs, - max3191x->modesel_pins->desc, - max3191x->modesel_pins->info, max3191x->mode); + gpiod_set_array_single_value_cansleep(max3191x->modesel_pins, + max3191x->mode); max3191x->ignore_uv = device_property_read_bool(dev, "maxim,ignore-undervoltage"); From patchwork Fri Jan 31 20:24:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955741 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11BF81F5601 for ; Fri, 31 Jan 2025 20:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355104; cv=none; b=lkfpvB2eX16sP8jO+nFHWF5tvt5hfoP5syk6UWXgN/tUYHQP1PEaB7kgOn7i/ivKL7FP5SyOkTPrUUNiXSboJtPaX7sLEIoXlnxXdxOc7by+NFOsAJ0Qn0bhRgZz99trC5g0AelN+SgtNfTIVdm4p5qvzUmCO3hpwqAnLGvZ8ck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355104; c=relaxed/simple; bh=9/jQiweV7yB0cOyjEzTaktkYDTP4ZnpLC0eY9PbXQiI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rc2MbjCfcxQfUSr/Bk5AqeVsn3NEVvwN2kULKJIg2RQB8js/V+1gBCzA3gvt5vts9jAK1PBHKHPw98HxMDydiXQV2z6d91KDR6LAqw6nWqGsKVrYJquisprtazrEy3Y8k1pN4Ewyg1sf0psohjaYFmfwxU5fnvqTaBkEYAqGXMU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dPOQXsl0; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dPOQXsl0" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5f88a93dceeso736806eaf.2 for ; Fri, 31 Jan 2025 12:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355101; x=1738959901; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HLsz4+tHpjKqe9Yh2fzFcV0a8GzDcsWx5V/eyXI7CsY=; b=dPOQXsl0jyCRKlP9OZrbnBzIkog9S7YDFa0F4xmuWXBuN9tnRHwd2YqfZbpjURjHM2 qotZJvpGyyYMyW3I7NxtrwidnoXp9GUZspNWpvTUEjW5TY0uzG27gbKE3jqVKVXaamVV c3sCvAtI2fBkvD/jRU1HabsdnA1biCTUsxXzorz50dCFKhTEpAK7eWVgdg3z/364Dc/n GB4Kx4b6/PU/kvEOEgifO7TlOvvbLhze+14A19IMqYf+IbZn2EFAvoebHmjnrwFQBsyG 0o+mH2KgOAiIG552xnoZDlO3DmItar2Vq5PY90p38uXkikPoSt+v2xaj9hwtSwmk3p8I 7QHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355101; x=1738959901; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HLsz4+tHpjKqe9Yh2fzFcV0a8GzDcsWx5V/eyXI7CsY=; b=Tv3H4gWlkGopUtTB3oMgBIuiancIZ4lm5u/hFadVRWExGVuSxYimOih5Abjzh22FdZ f1GaRJj3w8NAhIVV0XHUgXCGoTA9BW2ZHA+jKRjAysq7xBjVbV5vYbszVVGbIyDwwXvJ XIrtqKOLd6iz5M2ZFMFygeGEKIWVu2qx+BMHmyBNs2owXL5KllxS8OlzHyWrRQWPg3m2 +Y/aLipBCVdZNCoCiESmGsooP3GrEqnIIeff0WHIi8uHmjE5z0YOt9Ie1ncrV04PODvV iBP6YeyiDfzMG5m3TseO3WDEzvouVUcPPK5QMWC/4WjXMueivts906i+M3ttHjfbEr9r 8pag== X-Forwarded-Encrypted: i=1; AJvYcCW0pOPLC23x4N7pdrCh1+if6XktF72a6s19KiR+u9y1PobCiRt91dh8fZjLuNh6lCVepLHaP/GE1Sk42Q==@vger.kernel.org X-Gm-Message-State: AOJu0Ywthj/pMu4Q/AmoukVUwxQKdt7o1KUxWJ87GpcG5q8iZmcFvzSi vau7kE61dXwZJlsut0Ymb96WDakKY0ecBKvHu/yQCa2WAJwBFzlbKGsBapqt/vQ= X-Gm-Gg: ASbGncvYn093G+Hpdd96ZGpQFhHnRPC/OhGq9rUgTXzKfChe/NZKScdPOL3CfGvpDcG NAu5GbEyb3jwMoVGp80U6O2dvX6TKNQ2c+6n1hrJwo0VOXxdTczdcUg6z+lpqIWSvsb2Q8zmbXY N1HzGG8VwlPA+XvF8AY46aggHQsgEHvOhHGvSpYd1GPQGo8+Kg+j5VfnJ6a6EMWXcL1DPR1zFus P2IpDOfcAvaHyOtNJ6kdr3D9+5kizsiGrM2aJxCdQL4Qyjyubp8FmYs8gth7rKnPKeQmGxUNuzb WnfM7EJq8ad7N3Kpmy2NldxGPoIq8oaMqlhSVrOVLC0nxXc= X-Google-Smtp-Source: AGHT+IE0gOiKruiwKZS2fVv0rrPSXfEcYE6NWhi9xtJKoPa0qd12KXWlAvVzsWhUG+e0SGLuDExKGg== X-Received: by 2002:a05:6870:702a:b0:29e:6096:c25f with SMTP id 586e51a60fabf-2b32f0bbdf3mr8023505fac.23.1738355101014; Fri, 31 Jan 2025 12:25:01 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:59 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:46 -0600 Subject: [PATCH 06/13] iio: adc: ad7606: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-6-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Signed-off-by: David Lechner --- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d8e3c7a43678c57470a5118715637a68b39125c1..fe2216fd072e375f3dd8096980e53074f8ee3758 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val) values[0] = val & GENMASK(2, 0); - gpiod_set_array_value(st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); + gpiods_set_array_value_cansleep(st->gpio_os, values); /* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset) diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c index e2c1475257065c98bf8e2512bda921d6d88a3002..d3064e452adfbc40b44f4437e76a73aeeb036ef0 100644 --- a/drivers/iio/adc/ad7606_spi.c +++ b/drivers/iio/adc/ad7606_spi.c @@ -297,8 +297,7 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio_dev) * otherwise, they must be hardwired to VDD */ if (st->gpio_os) { - gpiod_set_array_value(st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); + gpiods_set_array_value_cansleep(st->gpio_os, os); } /* OS of 128 and 256 are available only in software mode */ st->oversampling_avail = ad7606B_oversampling_avail; From patchwork Fri Jan 31 20:24:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955742 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B1AF1F3D4F for ; Fri, 31 Jan 2025 20:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355106; cv=none; b=NZzOnpiqSeNte0yIP0Z+VHf6G3qxcdZQIt4fheEo3pOcteo7ZG4IGB2qG9PGmBYRGT9WJ77YgWnNlr0opnP7487VKKRGjCFGSSziWMoZ8ArgDkuLZom5LfSQ0gU38AkPL/9LgEGFT5OmI9b4s1lZz2QT1wfcaiRpCp16pVxy1vI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355106; c=relaxed/simple; bh=a4UCT4/NNPETnikiY/3/IXvAqgQyANJWQskJKLdiZxw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DD0FWMSxfdqg5ta+JuT4UcPpsHj+A6BJalS6wtNur5tc4otHkUeJP7mMgFVlc4K/du27rRlZZtN9afRkNLIxILIdUJTnKw5ifH8gVs+tEd+UGZwsjy2MBCcdEmfwIyRXjXpihLd9VFCgSdXiByvjAtxC9psxw5WPhWKtCDCHIc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=i3p50MoR; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="i3p50MoR" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2a01bcd0143so1484716fac.2 for ; Fri, 31 Jan 2025 12:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355104; x=1738959904; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WNU4SR73NkzT5flFO6XZzV58Nb+8n8xP048rFGpOLNA=; b=i3p50MoRqTck66HqRmjce02FFEVCLPd1WryuRoM8Vuk+27DcmPvbT5L1dLrth8Rspe SEJB+O8mrL3HlRbKg5VFYWuQCDhd9iOd4J+Lt4BFQJljF4pHcQrCLAKdvLDtw0FlJGV1 7dEVAyPkdLMXt20S1aFiNAknpOWcDXQLBiMeQMF6UQLyyjAzwVOLhiheBRWtvlGJLrkT YS2GUkU7S1H9uADGOi9+20YUVkUG5taerhoyFL8T8fFl/7yBhswxXr+dFp1bwdy7n38P 1IXFmSQrGkvfN+yZ77Yu/R9POZDUUjLQtzpE/7EtjT2Db+Ut9M+aCRHdVkFBw5e8e1N8 FszQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355104; x=1738959904; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WNU4SR73NkzT5flFO6XZzV58Nb+8n8xP048rFGpOLNA=; b=tJZCqfZhid5lK2L1ufGB3/c0l39x5Zb3VtfICrQqJfZ/b7uSwa64daYGWvyq9UHLGO H7hkBYaim9xn816DO8TbQhoJnDilYGjt9H/HZyzl5aLevSKWjrXusiEwKUCN0lshkUoI OMRAY1LdWVpCRGlgdmOJ8lRTv7i9SYkryucE15IkOfSEL+g5DDyic/wjiGJE2jcIMBzy d0a/B1HevxCg/Oao+0B4o1ysMsSR6AjtphJ3nIyLpaJ/D892blWE2WRGq3Sy5v30npXM mqnZ4QMffjbkDOvFKHqQzqnKAg72EfUY+3HLIEW1c/imLgTAOEKKh1xGzO6fnPOKUhso rABg== X-Forwarded-Encrypted: i=1; AJvYcCWWqGt4+nRJ2wKfXlsUhoxFMzfqOAeJVbLQQHm64uFD/0RU3aHXJKoPEbq6f2UMpGuiac+w1lbCq1hlgw==@vger.kernel.org X-Gm-Message-State: AOJu0YwarchnXUhdBTtGo0B/QVU+h5d1+GrDsZNy970Sa6jZCHhiI8SU nrBMKPopOxiaU3srpxj/HUXgtfX8FUahz7yxh4cjmdCHMIwMnCnMGWEmyV/YzIg= X-Gm-Gg: ASbGncszUwDmJKukI5tnEFT0VYJ5a1Id4epc2+OYrXsfjJKpVZxNpx8qkTA9oN9GpKJ qhqgs1/aYLu4Ruma2J7PnNVCIcaLzWeB4wF9bNIPnIoEs06kS27oqOlFMf7d23kh2SyUaoN039h Qno63ysZZDfJCDAEgjtApxvMlQid7fM7Evw9Gz0DSX/uz7QeDZMRwKN5Vt593ucJhCfGy2KGL5u jMyc92scs2ZkSBZmRERtGVq/hTEmqpaG6gRtDvh+AMFbf8FyhLGOJK1of6IORn0Z59bn51VmWX0 nhp/izF+sToxz3WeaJOKDgaLkhUNWDHLgawKjtbmYuaJTVM= X-Google-Smtp-Source: AGHT+IEjjM8UkUItH0qBBqM7/8yjcARln6tFWMQk1I1vtwY7yg+bjxT3tjK0CN1AwA297vbCg45WVA== X-Received: by 2002:a05:6871:7891:b0:29e:48d6:2e62 with SMTP id 586e51a60fabf-2b32f06986amr8146491fac.9.1738355104164; Fri, 31 Jan 2025 12:25:04 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:02 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:47 -0600 Subject: [PATCH 07/13] iio: amplifiers: hmc425a: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-7-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient. Signed-off-by: David Lechner --- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index 2ee4c0d70281e24c1c818249b86d89ebe06d4876..e8c67c8145b1b9ccb9b70ccd3ce4f5de08f96e69 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32 value) values[0] = value; - gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, - NULL, values); + gpiods_set_array_value_cansleep(st->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955743 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F3271F707F for ; Fri, 31 Jan 2025 20:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355109; cv=none; b=cser8XxR+K0Q8Ve3MCdoEkt1ELln2mgsOeSyndYdLHJu9Zxye+9RyRLayZMo3Vq8q8gCsgVXGc0o9F8hhqMEZdNreQBMR4ziiiYGW53s6UZqvhvfkwWjCHylf/K0tYhl1NeFzDB/S6nh3i6fEnko+UD5qbyLIQjYssZowZeBAOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355109; c=relaxed/simple; bh=Dir9udBrhZIEDuzX3pRLNcZGmhbiV9AhUdKa7dHH2zs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S7Xi3c0rJCTqQoNvtHG2jc4aqEVycsc0dk4NYoQo+QSCNF8r40vAMIJJybVnfKV7vU4Myf77UEm31Tx9TcPwE0NdanmOXkxY/Vg135vNEeSP1tZCBSq4/icAYC6Ns0a6v0ymsLr/H5zp0/cNhkXFzaAkjWVftESBq5BxHZT21Cg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=JLqiHDEm; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="JLqiHDEm" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-2aa17010cbcso994437fac.3 for ; Fri, 31 Jan 2025 12:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355106; x=1738959906; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DXSo9qIqFw2jH0TFUFiXNHDreUcSE5l/XqXZpt46Vu0=; b=JLqiHDEmc5QOTTvhC7d5nL1vn+WC3Poy4hTEcuXYTaFGW4yEm/1zyc+ngmEptSqGFM uLDCvKUKB++42M2YtmVGMG0QBxnNnDglYbuSmoY6Ojjf+BoLddAmKeFvrnbE2viMU1zr hhhq06ewVft5HMEb2wOISaPPa/E+ZIPsyuNTNxcUhi0AJxLV8Be03dvfV0Xq+T+brhbL cQUb2KfmxGPVChau+3bN0HKFgOtWb+up3CWWwR0OUMjKQ6/0E678p/pgFHPrZrG4NkYR HfGTCH7jhVbD3GS8EjzY8v/BkE8WIdOJ9SLNLfWUMt8ac9GfrpDw1+tbgvOHgUbuo8Iq NhKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355106; x=1738959906; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXSo9qIqFw2jH0TFUFiXNHDreUcSE5l/XqXZpt46Vu0=; b=D2IU0f4ua/V2WEEFhkEd/G7whpKws000J8dnUt8X+DQqhPfwNDy5NlNyp4eU88wszE jH1mEOG8lEiuXm6PGlxmYM4u7H9zoflagmRhSFfxniMn2F4KJ6/pvA5tfXtWItoVEPaG NP+aL/iPlnFNwWss1ZpQR8gnTgWxmugocKdX9zSHf79T9KkkiNNk8Raq5Zp/1hGBI0l3 Cf735/ZuK3Jqf/O1NWcbmVbjpDTAWKM2PcVeu4+x+clxgPL7OT4oE/DEGSKZ3t8R8vYr xcdgo/C+ZYX6/fKOtz5HTNaksKb06lcxRhLm688Lqc1kOf++s6Q8IMjwvmQpcrDq02ZD nTQw== X-Forwarded-Encrypted: i=1; AJvYcCUHr0KaDWpjkczQpaumlRPqvAzrXu1ND4fIREkmf/sfes74oRCIT7+QK6m2R6CNbszQHni5Kx0pzdtFVg==@vger.kernel.org X-Gm-Message-State: AOJu0YzS4yQyT0TD36Jlw6HEuSCTdBH320EeWvOh3iAhG0V0/Tnp1Dsv qdR/AqAVckj4EEj5u0OW7IKuPdFMqOmLGKH+asRrCEFAtos9nR2nnzc1j8mBFo8= X-Gm-Gg: ASbGncs+AQql3Di1p/OuJMvOwES6CRYkr1jdCB5pkWNpH86iseCt4Eu+kcOfruWyESn kSXh40vwbCo2XAMG8JyjYhVgD8HqnXW0ILHveRnChTsmFYtf0ttcFWD0tR56xWIpQ9hiPW2MERf bJq7TUVnizTxgOyzGEe7zij9MpCPUc+Gg58nlVhnNSiRGC3z37q19CckOBMoKc6WXTJuIwErGmE FKaHVb6X/BWfuK+wIF0RLS3WSgMkS5f3kb42m2DWnRfPKEeX387CFJgo2Zn3ZXvVltfrGvANqg4 dyEIBV+uKeT2mugjSUneuXF3dlCrGp1FwVJGYmN7Uqy4R2w= X-Google-Smtp-Source: AGHT+IEk+EYILkaYfRPwnEDbJBIEBFXhatYC+4TE05088ijfOkCj1XESP7wyxn6VQQJyYksFnt4aeg== X-Received: by 2002:a05:6871:a9cc:b0:29e:2d18:2718 with SMTP id 586e51a60fabf-2b32f26194dmr7999805fac.28.1738355106264; Fri, 31 Jan 2025 12:25:06 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:04 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:48 -0600 Subject: [PATCH 08/13] iio: resolver: ad2s1210: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-8-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Signed-off-by: David Lechner --- drivers/iio/resolver/ad2s1210.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..938176ac7209a92180fe8d55191d4abce026afdd 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) bitmap[0] = mode; - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, - bitmap); + return gpiods_set_array_value_cansleep(gpios, bitmap); } /* @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) bitmap[0] = st->resolution; - ret = gpiod_set_array_value(resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret = gpiods_set_array_value_cansleep(resolution_gpios, bitmap); if (ret < 0) return dev_err_probe(dev, ret, "failed to set resolution gpios\n"); From patchwork Fri Jan 31 20:24:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955744 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E7A1F75B2 for ; Fri, 31 Jan 2025 20:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355112; cv=none; b=RDqie3SUZ+X3T39hGgebYRTfdc2g+89cevKqaiTLdZ5qSV/TxY4RS/HX0QMCKvZYHWC7IB2kVJI2Qc6D1ErCbmkY0vUTcATOOQyVJ3WRTn41cU2WReTEZjIFO/Ge9z82hhnG1Vm/yXWAn4J76ENgGYxXwiIG6witGgRQgOP0F38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355112; c=relaxed/simple; bh=MK0Ks2Di2rJVvigp/s/vAkyxV2Ps9hTBvb2TEAom5M0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bQ2GIfaah1wjGLldLOWlNd5T1GECbYPks0zlkwTaJOveHIKIB1aiGo2QcRGX4XepvJJ0xtc//Wg3w3x7M2ceX9RzwuWKveRvLoqsfq95GD92pDHPILZz6eMA8qRfPnkZpCtkymApAuiQKEAlPGhO83DHZWCNcLrW7dMawPWOtLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=TvKooawx; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="TvKooawx" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-29fe7ff65e6so819562fac.0 for ; Fri, 31 Jan 2025 12:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355109; x=1738959909; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lwWNVnhNlJbHZ/NQhMSjzQrpqbMeo/6h41DdX1Qvb2w=; b=TvKooawxk3ek74wKtIXI5KaEKZulBtQxUrB6kT0RHQ8XQ5TNLQejFlCawjYv5dJxKP QmA0sG4JSA4gCGhiV44hp1U4iN0rC9D0ZGD6wp3VOQdc+WLXeUfK4cBDwc+pjyGzfk/7 pIVDcxasgxQJ2GQFj2lxnW02DL477FldSm5uh+zU/Fgw1W+FRvpN4rRejYXzpHxzzQSq iCG1ZxCO27hKzZQIg5uybXovgC0OSu8/fCgzH4gIlDI1w2BuG2YhRlRuDEC39pO9u22J zfw/1OapEiNvUatIPZ5hKMapWz2jItA1s2EfzhfSeHtmWGsEuE8dHTerIIfQDTMKhuZ/ 0yHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355109; x=1738959909; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lwWNVnhNlJbHZ/NQhMSjzQrpqbMeo/6h41DdX1Qvb2w=; b=s0QNNzvAf7u/OqZy8J8GxG/ZeqrNdP2T0iyMHQKx2v/s1PmSs4c4u9Th62E95e8H5v COwGn3HTfjqi0h7O7YJV1FxT1ypotSMphUgqYTw3lwYue2xGNBL7q7MPEJljxyrgGJRH 4iX4tezhN32kR8To1XMK65C4sV5tFzInYTyFa6ADprPYXNp85Z150fhYJLepYLMtKIBS xpOZ9hymMXDVrAFWqviNyB51mjPTMGdl7a0Hd19XVhkfuECUxheiPamAKWiQcbumDFwK v5GsGK2F5Z1yZCsKCzVicsX7mDo1KmbXEO/DDYepD1v1vrD+tGyltHi3B0C7RsD68Fqa SnqA== X-Forwarded-Encrypted: i=1; AJvYcCW39BcuAqLX2TI29u9ILmVuKIwcSCWPrvXAvBndfzSzGbHIs6NorPedh8wgimgThK8CLGXy4mEiE2wfzw==@vger.kernel.org X-Gm-Message-State: AOJu0YzSYYUBwq/qFbAwc6SrzrYZQbFJf63dDzW6lNxciuzI9HgBsehK oyOzB2sCQ5pBigdajZW1v8lEg/GAHeJp3nKgKW6xm1Cwlbfpq4SC/Hpxuga6aL8= X-Gm-Gg: ASbGnctQ5luDjakLGK7yg9Gd9E4Gk7AMpg5W76O3MR8I218GJhJv+x4+XkBM3Gley8q dEZA57yDqVSN7tGBZO44dlKDLGDFIm9vbJfF5ZiPjqueem2MG31DU0EGcIGwZgf3fbviFJvlfuV jhyJu8Sh12TdLQPI5c2JBMycl5FyC9zqQ5uPM9GgoumeGfwFbkMIL9YML7WvDUS4NHsNFRMNRbt q/gDTSbK4PMbXyphHfgDDfdHFkti53Uzu+kp9ECzv57oW/Bcl/gAcrCaDv1ulGCYcnEHr4gdDiu H+LChuBNw9txWWOhG8mpEcqC+wgWudOcxu6JnyWUO5bxAA0= X-Google-Smtp-Source: AGHT+IHQyjQ8y3Rtu7NlfkeMw/zOxhLdOk/J2rb/TrRaSbO1InYUF9KwbynHBq+Y9XgpJsj8OqBDUw== X-Received: by 2002:a05:6870:7186:b0:296:aef8:fe9a with SMTP id 586e51a60fabf-2b32efdc7b9mr8033858fac.7.1738355109312; Fri, 31 Jan 2025 12:25:09 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:08 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:49 -0600 Subject: [PATCH 09/13] mmc: pwrseq_simple: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-9-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- drivers/mmc/core/pwrseq_simple.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c index 37cd858df0f4d7123683e1fe23a4c3fcd7817d13..b3a6d053c826741005f1484ad81df30b6bf75bbc 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -54,8 +54,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq, else bitmap_zero(values, nvalues); - gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc, - reset_gpios->info, values); + gpiods_set_array_value_cansleep(reset_gpios, values); bitmap_free(values); } From patchwork Fri Jan 31 20:24:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955745 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52D281F78E8 for ; Fri, 31 Jan 2025 20:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355115; cv=none; b=gahbTtub7mL5LURLU+UX/zIwJ8Z3CLqKT7J9ZiMeabIN8y/0Z8AvyyoolTRwumlqiilQXFHcZNTeHGH7GUIC46rQ0kYV+JhFmjNMDhSaYl8JMbSBaV1j8Hx2otShMq0oGfp1E0oHwbs925hLb/YhoqaMnR5z4lIE0hZpEqmSAF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355115; c=relaxed/simple; bh=9CicIm6xDarlbk67AANQJSF1s3m5MgjSBlIRcxjc/Fo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WSlGA2CfeMN85XV6S3ArOe/iQ5Oxz0w0n3B3Ww2lsKqU0iHOk6pER0vnmRcLMy5TAuQ+d4sw/v5YXLsW7xw1LBegcC7l6AeIqlYI8S3KhYTeSmlCeuUdSp0YMTNs+J5tnFKu8NyOdgBbXgCAyp6eqoXKvzj/PahxdBMUSHTd40o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=wlI+CUIC; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="wlI+CUIC" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-71e10e6a1ceso618988a34.0 for ; Fri, 31 Jan 2025 12:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355112; x=1738959912; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=q8dlq+1FyobpCXd9TkKRwFwRft57r9IiORFW/g/tAaA=; b=wlI+CUICXgXZ59m2jPFbdGv2J3EAl6YkI5OUi/o+5HQFg88HspRlr0dr1Ize9/zZhX vgbpaxsjqQ/QqRq1yjMqvW9qbxX33uCRK4wTRB91evDI5+FGRFEuBDaMCqG/MQZpJC3/ bCWmxqxUDHoywe7tnFcOdgK2yuwPKsY+vyODObT6GFruCueLz/oc+ccc/9kSiZ+XWO8E 8hdmqDBq4XpUmELiwQFDfZpCjeeFhJdOkm6M20lOsf8VzfgOqD5FaKNCKmDUeS++Fdp6 Xq3mCVUjEVhfX7aQ5E0CD3QkC7ZwhZ9xffOXr1M0hlZ8bVJXGwPCZbNeTgRpOff8wAZW z6Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355112; x=1738959912; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q8dlq+1FyobpCXd9TkKRwFwRft57r9IiORFW/g/tAaA=; b=DfxHMcPhPv3vVs5nf/tTDFj66SqZG0oUP2hDQLoPSCo5+AzQ+PPtIrykaj4D6+4SuA /KftDMkj71zaeu8ZbBnG2dYkV0Joq+rzkY8KW1BEjYWCZbSgWdYJPFiA9saKJicnplQS xmHmfi4GABTBuI28jIpC4lZ19y8fDXC657O+kKf6dNtlTXJGaDdLE+57Du346bs/aKeu 8T5xN8XRjA64dwCXFxaMlpbBV/5Wtv8Dw8G1HMjWvlAmbOPdaO26JjF7e6uuzXNjMqMl 6fyLzMNYP98xlMiVnnDCDnJC/7eEA3Iguifng3N9ZONjqYQaKUwejcASz8AZQoF4w2yj u5/A== X-Forwarded-Encrypted: i=1; AJvYcCUVFDPTNriRCvJDDgL7/Vv7ieuimU0wmsMPMMBZg1SlO/YrR+SNf5uAlgXgWGVpTmt+MiNb0OBS7sBcUA==@vger.kernel.org X-Gm-Message-State: AOJu0YxHBxwWB5MfmB5mBC9uboUDBj0v+3+O6L13FZkV4YXvrI3ATni4 LhfKv0ypSXNAi8CwOBceiQ+SNxuRLSVwubKbF4n4NrMzSGougqWF0h1uHAofaPw= X-Gm-Gg: ASbGncvjBK7U48nRVXaSXSKyhOzPfBrYLDe6bDE2S843DXsXFjsbwXw73ZzKeTSQhpu O56+ZvSCNQv5uh6m2VQ27x1U6yIyyxUIHCulJXHa0VGE36J1VC19olu8W+TpMoJNy7X5FBvspXl hVqIF+uXDNgZ/vjIg+3GkHc9f5RceN2s9plpkW82D4RfSdEMbdQVkamJ4kNpa/bVmg7vHkcgPlr nrmooacwXufzPfA5iYTBP+QI8jpY3bfyp4L4B1Q3NsoqSraNFAWT0xzrrRfFvJ9Qc27/DZK+t5w WKcySxZ13UVNiTXupkQgxbWlXXMVsNTAEcnKl0moiehEb8c= X-Google-Smtp-Source: AGHT+IEOPFpYcNvsoJvtChI72uu39YNNI5XV7tV2UH+PWhk+hEwEt/BHCYYItie+9RSXj9400mKLXw== X-Received: by 2002:a05:6871:2106:b0:29e:2caf:8cc with SMTP id 586e51a60fabf-2b32f30c9fcmr7202349fac.37.1738355112453; Fri, 31 Jan 2025 12:25:12 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:11 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:50 -0600 Subject: [PATCH 10/13] mux: gpio: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-10-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Peter Rosin --- drivers/mux/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index cc5f2c1861d4a22d984bcd37efb98dd3561ee765..fdfb3407543dc3c2563750b013754ceb3390e39a 100644 --- a/drivers/mux/gpio.c +++ b/drivers/mux/gpio.c @@ -28,9 +28,7 @@ static int mux_gpio_set(struct mux_control *mux, int state) bitmap_from_arr32(values, &value, BITS_PER_TYPE(value)); - gpiod_set_array_value_cansleep(mux_gpio->gpios->ndescs, - mux_gpio->gpios->desc, - mux_gpio->gpios->info, values); + gpiods_set_array_value_cansleep(mux_gpio->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955746 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B321F866F for ; Fri, 31 Jan 2025 20:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355118; cv=none; b=mJLtbLpufCALPhdf9/fbY+3a2OSsmeTf4lYkOujcpcDxdwQhdDSHNLHWBgwYsmUBZmc8TGdwDa2l28kIt/9GS/0tVM4/pedUUlgfcW30be7zoIrcWxLLx+uydR3ufHArb7UbWayqSZCI8PfbghoVQvOgThp8XKOc4jT+loRwT2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355118; c=relaxed/simple; bh=5lFciV6sDtnvvFQNJQrSdhN6LDbuB2QD+esDyLXoYWY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aGG3iWZJHFctJDskLNoWmpVWkJaQp+MFaIKEF7MlkFdO+BuMLDLotlQHnO9I04vGVwBtBtquFsUpkF1Lz5yofB4LNQdB2/U4kGjabUu5n5yP+jPcd/9LPmaYQ4RO7b3kIHULFtw/+Z52iT1whXTsF4NTPI1on5Z7FsazPP+FC5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=xfWVISNq; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="xfWVISNq" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-724f4d99ba0so1124295a34.0 for ; Fri, 31 Jan 2025 12:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355115; x=1738959915; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=59JJI4CO0oacXanEEbv/QOEs28IMbairlUQePRWumA8=; b=xfWVISNqGvmJvPxCnksE/Yz1kneKNWKaDoiPyVLVuJJqQz0AQds5/lIkpGqMh16iAD ZERvZm4NHH8ecjtnA156EOdT+s3afBz+65DNdZt3iYc6HqEWYMjMyPm8Oa1Zu3dPVK4n CbpaQ2ouRcwZeE4GRJsuUuze3SLPEEZf4CyvVcS6g/sEFkP/lEB0nbmevg42OYuehQjL 4ohqvG7FisQgxd+xvcJN/S6d9ahf31PmA33gG1nKowgQJgD8P+e0HjR3kWZiVVKkuPUD 3mdj0uy6cgk5FRaXgawn4H7fxeN9x9oZP6o3ixsNVrT4QqFTpirkBPSGe8iZKk7Ez5iQ nxhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355115; x=1738959915; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59JJI4CO0oacXanEEbv/QOEs28IMbairlUQePRWumA8=; b=HlitiYfO8Mos1wKQ3fYquBqfvkWCq+Zt9R6SM24zwLIUqekAkoFVZ7jgHZX6yHWkqy oqFulqpNRKlEcSYa4Et5WtG7Jvqk+2W0Y/kdeqL7jFsqOWR95KABUZupE51lE7DUixLf V+MubwhXj+L7IgT2oIC2Ecb4NzYBjTvDWbSUvGDWxxFlwQZZDJHaWoVJ5Q2w6Z/04Szk cECUyeagut7By4tt8A5XLes3PqO19hBQytlzMOcN4h2MJlhPgxdLHO+W1JgJadqeddSn cTO2HjyKkceV7AM+k+TW3aebwmRxgqnRXQG2iYMp7rQR69AwySVppthBH0ScQ9hWS6lo fLhQ== X-Forwarded-Encrypted: i=1; AJvYcCX3InwVGOqjqeU6zWr4UMqWgp+L3aOPoFOboGEA9n7DJcxpxRNmd2xo6l5PUwgkOe9aQ+SRtzQ8LuzoJA==@vger.kernel.org X-Gm-Message-State: AOJu0YzNDQGn6FV/ZEwFss9WP/ahs3xFh8//5Qe5PBcXrr4FtGIP6TAN T0BArTlVCWmlCfUvKRKpGtc1C41+oLlG8wbOq11YRUZ0b+HzV7ckN3G7WfzAptQ= X-Gm-Gg: ASbGncuNbBHeXgNGJmaiScUx0jvPHl8SXoVBkSnqpkDVZCV4pMXrQndNtGKAB4PfYkp w2Rw3fLxMqfzkv6/tg0yIFop8IqVNPeGprlZK5yZYk576P5K4FK4x9mu/0yGVkWBAaqKJvU9fbI imCwU2B6LkIMjhzxTn0k5Y6U6LY86Wa+TzEFPr/e8a6wf4b7KViv6o1Z3OW1bT5IlBfyObYNzx8 TEjk+oEWw0DreT4e6HJsnvjsCBesyAaue/ntCFjCm4LY94liDonY7zf+sLtvs0s9FacAiP+QGIy lerRjp0GWYL/Ak+VUdsqoQAOiiURoohlNp+MNyyMLw+W2EE= X-Google-Smtp-Source: AGHT+IFrVMAfd3Y3wOZ0h4O9q45j+fMg4Vw3AAmlNZ9ZgYIq1KVZZxWHseA00ADe6a66eu+rR/ZJMg== X-Received: by 2002:a05:6830:6805:b0:71d:eb02:baed with SMTP id 46e09a7af769-72656774376mr9460293a34.8.1738355115546; Fri, 31 Jan 2025 12:25:15 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:14 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:51 -0600 Subject: [PATCH 11/13] net: mdio: mux-gpio: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-11-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-gpio.c index ef77bd1abae984e5b1e51315de39cae33e0d063d..d7eaeadde2873977606bdcb5821dba18aa4a578f 100644 --- a/drivers/net/mdio/mdio-mux-gpio.c +++ b/drivers/net/mdio/mdio-mux-gpio.c @@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int desired_child, values[0] = desired_child; - gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc, - s->gpios->info, values); + gpiods_set_array_value_cansleep(s->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955747 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B7821F890A for ; Fri, 31 Jan 2025 20:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355121; cv=none; b=TOMJ2C3qCKqZcjkrkkN77s0ChCXja2NPEN19l30Vr0gZjBgPMjQ1NI7CDq280FKzxly0REN+XzwsFIUsq03tXhB76xR4sdwKqyVGt+xN6QwEfTbIkGhr3cT/hCZcOdIdAuk0x///HFWZCZF/Vs8UFFbIULu1jDMnIZl1MCVaQG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355121; c=relaxed/simple; bh=rmBWKBYHCI+WuV2jjWYGUn7c5T236U0xlpQEPpz0oeY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l4ajjrm45oeQcuKa36ScyrU8w6J1Bjzp76oYwEupEU74+ydl66/7WjzT1Yydk+FqyDv6blMovyDXBcWruLtdKrYNQEXMx999t2ctbCu1ovKVxkcl1zGwPSVgP0lQRZpxA97PaNRaa1q5qpFlYILwrQktr30gHX9wkPZNvB/aDF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=uPUzRuuQ; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="uPUzRuuQ" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-29fb5257e05so788413fac.0 for ; Fri, 31 Jan 2025 12:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355118; x=1738959918; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FzzIwzQtyYUR99JIrJ6how8p6bj9KukV10X1RHN4Hv8=; b=uPUzRuuQm3ZGPf+v7Th3oUHvv+dGvhO4XsIBcA/QvMsizBApe0tGtAB7+nO1P7jy1q Ik/cc+vEza7Pr28FhufIO5AhgNywlFpeHhVthF2ROlZ23MTfqT9DC0/fPVHcfpQqKK1x kzOILKZEZX9col5sG0JKUv9gD/6s4Cc3oCTkY2HUjkGPU6GRoci/acai9Itvr6Qp2/SU kKWD+BuyBLR4hZ99kKwNJdiWIWD6UX7ascKxVB9hBP3OJH7zJg23t4lGgvJvfcmyLr6q QU/xxC/WfSqs/ZrYSf+pAdMqu0PJ/iCbo21j6K9tQFnuf4+j/WZhIqaFOn2uSzUKXEVA TSLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355118; x=1738959918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FzzIwzQtyYUR99JIrJ6how8p6bj9KukV10X1RHN4Hv8=; b=LdUCR/7qEVYmfXqPSRzzmm61YNjcgLZgGiitW0nGhmmffieDPG0lCVLYVB52hGP5iZ TJVeb+EbfDUmqHBo97uJ2WmMBcI4VryGoS2mhVK0YIzK138suTtbl15Ool5SJksdQVkH TnjmkDuftoMSX3I5aghy/qbhaq7xJ0uI/n13VvrlA4JQKt+0MrF1/YxzP4UKTlfkgbqW Pty0FALy/n1bwHyNVyC4cjKIl8/fNYCwDbWvcWaYgy+27gCMJz1Fo64EUoQn8AGDrzmR AlK6gPuCSo5uJG5SePiZ+j/3sj+6LpwPDQY76u2yoQVaQ9EgAWPS3ieBZ3bJRYyZivlX Z6YA== X-Forwarded-Encrypted: i=1; AJvYcCVdYpYIg+TX4Oz+AntCXO2tMzd8BG/yTMvCOud0UBxcUoU/+1KpQrO4PISJpw7qkzsnmqOJv/W6QaGHBg==@vger.kernel.org X-Gm-Message-State: AOJu0YwZUqLZSQNN/Jje/FahMy/HAcNEYO52UAXlgudZ+gFDNpPnxCcd MGKjHuch6oZyUhtqzCv3rxCQ8XjHAFgTlA1QUikDI5KF1U+WeEhexhK1nU5LXO0= X-Gm-Gg: ASbGncu+JyQC13CWPtCD1PGIu/o0D2Ij9QQ35WggfSBLHECKFQ+0Tz60722soJIaiko O/UB3F3M3ys2vA2Lqyp7Iv+TklUpSnCDy+r66nxu8tS7XG2qUFY4s2v96hLtgPbgsoxRuuQTQk6 oUb8of2eg6sFcV7PWh/vRaw+gLKTVZKDgOVpRKdUhMhiF7YT5t39hshH+fx5ljyIqs4R9wAWKb1 ZfDCWFhDgF1h6a/pDsgHBrEo9FY2RMg59bpt/L7GVIp6FW7S18lBqk5/Ir49HlbCTa2WuSSYxw8 zX2i0EgAh1yf4MSbSpRf5ycN1uNhoLPut16R0IXluV1tnWE= X-Google-Smtp-Source: AGHT+IERsKIHS0RESeT1aGghrd2e2VbJU3Jew/L2qRirwk6axnCtq0WNFwypLdr9E1c9DhZObl9GKw== X-Received: by 2002:a05:6870:32cf:b0:29e:255e:9551 with SMTP id 586e51a60fabf-2b32ef5a830mr8108456fac.2.1738355117684; Fri, 31 Jan 2025 12:25:17 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:17 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:52 -0600 Subject: [PATCH 12/13] phy: mapphone-mdm6600: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-12-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Signed-off-by: David Lechner --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..8243bab6ac3af2ee1394ef743aaad12a19c8ae36 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) values[0] = val; - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiods_set_array_value_cansleep(ddata->cmd_gpios, values); } /** From patchwork Fri Jan 31 20:24:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955748 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B5111F8922 for ; Fri, 31 Jan 2025 20:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355122; cv=none; b=onfxzc1ZoRea5N/tvjRb1OiTsPc5+TuEvaXFMpXNm/uedAhGJhQ3eop9cw8VaFrZEihiDzzUDoUXsvAjBb28nLnV/ggwGevPhQqM18Rv+jzJna3ku86q8ADU2E9JsRLfAbF2E7OdDwRNpNddvLo8HM9I5XV8Uyu092viM8VGuSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355122; c=relaxed/simple; bh=Q5q1Cf62xGuA/zV0+TKjafPv8tjFCx47ZmXmvjB7zzM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=htJ5QfJjj6a/lheL+QYYTNsPQ5Yir5Zb7e6O2aYXsCVSl1FPm1S83GHCE0hAFM3etmU6IPHgBxjhSc3IWqnYOY4NbRkTu39pwDbc3lXOZbp0gFGXnZjoLDTEtEVau1qr241vuWzjSRlsXw0fL3YNyiCtQflw8rJKZdwRGAVaTO4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=FbeReIqM; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="FbeReIqM" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-2a7ccb2c618so1390704fac.2 for ; Fri, 31 Jan 2025 12:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355120; x=1738959920; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t9cxGVlfrmOEOQA8LocUnneYPfclUeeeatGnfm6leQU=; b=FbeReIqMO8vnYpLBMq/tCQ0Wzeek2MVG2PLNB7Yw48XmSR91lLUE85YYll47wHcuEu KycvhEOn+wigv6T6KB/XPC6dioLkMKuCOjMedEl4BodAinW7aFP4eqPQQ99l0fu3cWaq gL2G84kObRY7oQq7XO76+72cpJntOeMqOKS/xffF+kT00xJqHKfs15kGwTrKa/ctI3TQ 77d0pr/L9NTJqbNgESKgZy83jyDmvTaegIUUhESKXVJFQSNXL4ADZVNr2ACMFqyVI1q7 uISHy0u6AS8n/eTyhSwV2M7LS93hU2/mUq2Kkd/UVI0onUxYS/iy/TL1dPzrw+s0oVxw cz3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355120; x=1738959920; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t9cxGVlfrmOEOQA8LocUnneYPfclUeeeatGnfm6leQU=; b=PwbuPKwSZGeX1f+qZv3TNfJiBniXD0NqIdsUhmyycyjN9AtGcNWVjv+1WOWQ0Z0b8k rY65QrzqCOWZDGkaOWuuzlL8Qb/OJK6ON6/UYK2hOpvEQGzVH3ke6cYlIE8gEOh03PEJ q/dSYYrvTTLle/e2fB4a9zSjrejf/jELIB7MuUU+bWzaFthq5mRI37/ffQSV67Vr7KcX WkNg+kka8Yso5Ggy915t0x1qm2o1rl+FZkhAdj4G3f6WStovnwAN7I2hbBu2B0Td36Hk LK05BJ2zhjKnolJynB28CNh87HqhvSboAIxXHRVKIZlSobGch/+KOUnaHYZl1k3T8FML 0P4A== X-Forwarded-Encrypted: i=1; AJvYcCUa2qMz7adzaeAX/8qQeXaLQsgBKKqQRdoZkVwN3igjO3PMFjlVCJDSobK6zs4PtiJyRnfjGVowENz9LA==@vger.kernel.org X-Gm-Message-State: AOJu0Yzhs6BIyRcAK5LdJ41rfu4/DfBlDxQtxnztKVGeR/DnVuoRbUJt VapcEEaeRcUg9ynVFkizuCTI9spqkZFzAImvf3XCDFAhqIviEbIPl4LlD5Vps7A= X-Gm-Gg: ASbGncvtSMWy1eNNYmVfsq14o8L0ox9zf8TujI/I8CJb9KjlJI5Dj5yMhmmz4HKssXF O4Qq2CxvxS+6D8qg/LzDvomZazUfmkkC92UuxRb825YF32Te3P1G4z+KQLmE2uibYYVT0inGKDm fgqV+sHHCgniRY4YvVOXChH8erlVOy955nsmIBkEgHq2Lw1+g6SvZS5V1ZgKzy3KB34qUwU34lg D/lIm5+/KUWGxV29l/FoJeHZ9/5r/fHMhECc91lCeq3RkCpu93ZsPWIdbFoeGxudKuB32QcEj9S evkSuwVu5yUDRWnX8V9Ycf/iTfCNMRBMAfNedZYNDaYHlss= X-Google-Smtp-Source: AGHT+IGqg3uaTvNfsfu96auAGMNqMTSmH6qy7PdoMmcZZ87lNXJHf3Cu8HBE7iXbpxe/5j7p/ZYumg== X-Received: by 2002:a05:6871:209:b0:29e:20c4:222e with SMTP id 586e51a60fabf-2b32f2f8592mr8795453fac.34.1738355119837; Fri, 31 Jan 2025 12:25:19 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:18 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:53 -0600 Subject: [PATCH 13/13] ASoC: adau1701: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-13-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- sound/soc/codecs/adau1701.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 291249e0a2a32df7dde81904dce2f6be143fc2d7..d3e6b2763950f78143c0feb07c36764cb265441a 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -325,9 +325,7 @@ static int adau1701_reset(struct snd_soc_component *component, unsigned int clkd __assign_bit(1, values, 1); break; } - gpiod_set_array_value_cansleep(adau1701->gpio_pll_mode->ndescs, - adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info, - values); + gpiods_set_array_value_cansleep(adau1701->gpio_pll_mode, values); } adau1701->pll_clkdiv = clkdiv;