From patchwork Fri Jan 31 20:24:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955750 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6779F1F3D38 for ; Fri, 31 Jan 2025 20:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355091; cv=none; b=AMxTzL7xvLpCEywaDzymK3l6ITc3I97oXnLUlG0LcvUPXeFJvFeMQkEvuTsfOOhF7LPtMK3poei0KA2T9Q3mqYwt6AJ1KzkMwmsFntHSLkYL1aenDvgYlkI6cyAVljQ5Hccm98OFimVN2NKkgrii3RMxfKYjALB8Pf1TZY6hWQA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355091; c=relaxed/simple; bh=oe7N+J9cytrMnLNUSaM/Omiuuu90wAztekXP99d069k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ruy+VY6o/V1QDnmTj5/KNZaicOuKgc/gwisQ3OOSLNJSvle/lyevBcDue3vbsjE//fmV3Q+g/cN2KqJilvFAXO2zocQGq1nK27PQKYlbjyIWK+usb48aVG2Lu8osu5wCwI37dm55tn4rdqanrX55S7/r0Xvudr6wjEAffJe80uw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ueZMN8Jw; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ueZMN8Jw" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-2a0206590a7so1322860fac.0 for ; Fri, 31 Jan 2025 12:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355088; x=1738959888; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VExoELcV8x0LQmV6C7xp1BlVeCvht+mgfIMccHi3FPY=; b=ueZMN8Jwvfxq+NQV2mO6jeS6cQV/cLFNjN5CTUYEa6sBTQguN+LLIxjtEH66QaMmTv XaCz6U/OOKgomm2+nMFBh3Jq0MDvqnML+yfPSg+9kiIMSTzypHAweQ1bYTTu+3SJrcDL vZylBg681V64dP87Wuzi78d0D7c2GNNuGOdiHWrZAluukTm3GzBeMn2N9Ghv2m+O3Hbm ZKkFmBJjdgeHQCcdgi54aa/LExPrwHyI+pTx+2dIovWscRu/P8n7+X/MXpEQENZjzJy3 cr4AVI8IM5sgwc+kmRMXyAXLwJS2HVPbD2CEKjvnhbEYUC/k4CnpdgzfO9JddltaCvwo Jh5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355088; x=1738959888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VExoELcV8x0LQmV6C7xp1BlVeCvht+mgfIMccHi3FPY=; b=Ftt4P4m7WGA/DG4bPX15OXqt93GiPrE/KAFuYrvoNCSBJsPykAjFy/ysvt+F36j6K2 qVndCv4yH3BD9jb14i/9VP/4LkFY1aipj+v1qPj0sF/aFJihQGiNjfKwDbOjT6PeUFbu 5FhBy4d28PVb8WbR9y+NUo5ynLznBvqSGEM2MBiQO4ToMk4p1QEi40Rbqy253t3R4mGV KSnxu9St66ddO6t4Hzexle+1gYi6yVNkudfznW4K0tW1ouJ8vrd6ICU+mFG1G0paXmnO xrbvhgBGnzJOV7DQ2uoIxJBaSyZGta6oaW9RnwQ4Z63KzMZK/n1QCg9yGKW92GRQdqvE XEPw== X-Forwarded-Encrypted: i=1; AJvYcCW/+LmgT7ENngluYn1timVDyP8kLLv+DFmOTv5kpkNIsJ9rINTjSSKV9LumIf/QtR5/45LY9x0Qf08=@vger.kernel.org X-Gm-Message-State: AOJu0YwEpkjjHEAuX18tx+V1/cEJSChN+vS4n76EXI/tCa70a0jU1Ha4 ltLUBGubIa9pGkauNlNEejX5auzISF8daKRe3do+Oc+jKqmAAJCDXw3nKTykATU= X-Gm-Gg: ASbGncsfp+eJ7rCEHr2vg7Q2a7qheZXPHtXieTfOt1FJjDkIf4NvLL4kzCRuEcQgeX0 M1lYjfU0FJ5aqZL+A9xlfKI/GekaNgh7SfeCMVX5OhvBMTEJaOQvaNBTAFDYW59dzfU6Ww2avV1 LoQh4FOSw7WT2pEEcJuMWntQeJEDMjfECl4pHfCcG+/Gizej/9C1uTURvZILv0r3vRf/OxfhraS 3s5sJAtrC3egwYpC0CS6HfzUkM0KDST04+4pEhsbswJRmDmm4tKqbF/YpBjEEv+zLVoPGgsV3/q HcoKxsmFs49fkUv5YPzHU9xyk889i45DhIHwt3CNjxSGMK4= X-Google-Smtp-Source: AGHT+IG48amD1C5d4QahkI7FJNfsOoMi2CtgfNG8+gnzn0CcyJBNzM/PkTQMiDNqV/T79ZK3cKZLjg== X-Received: by 2002:a05:6871:a012:b0:29e:5297:a2a7 with SMTP id 586e51a60fabf-2b32f3ca389mr8811438fac.30.1738355088436; Fri, 31 Jan 2025 12:24:48 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:47 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:41 -0600 Subject: [PATCH 01/13] gpiolib: add gpiods_set_array_value_cansleep() Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-1-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add a new gpiods_set_array_value_cansleep() helper function with fewer parameters than gpiod_set_array_value_cansleep(). Calling gpiod_set_array_value_cansleep() can get quite verbose. In many cases, the first arguments all come from the same struct gpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate. Signed-off-by: David Lechner --- include/linux/gpio/consumer.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index db2dfbae8edbd12059826183b1c0f73c7a58ff40..1c9bb3cb1ee80fe52aabf5bd24b1d128eff2bc99 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -655,4 +655,11 @@ static inline void gpiod_unexport(struct gpio_desc *desc) #endif /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */ +static inline int gpiods_set_array_value_cansleep(struct gpio_descs *descs, + unsigned long *value_bitmap) +{ + return gpiod_set_array_value_cansleep(descs->ndescs, descs->desc, + descs->info, value_bitmap); +} + #endif From patchwork Fri Jan 31 20:24:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955751 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD141F3D4C for ; Fri, 31 Jan 2025 20:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355094; cv=none; b=ItU3BitieQJOqBSOvv7xq8zKDEiHQO+b3DSMzKpq5ur/qYafkdxoGVYVBNlxXNsdOY/B/GtSuhgpjEf9a2pE28LUbVPhQM1ulfXVuuVDsSZFaBzbydN7SEQsTbSNRCX3Ipp95clh9KDHWv9KqEPSKAzpeaDWNDaJkD1pDVSrwPA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355094; c=relaxed/simple; bh=rw0sTpvokUQNOxXktkwUiVgyBWFEQak6z7kbvwC+d0k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YsdBzx7bFOA6RWuAvn9NxrNZ0MQrgsBp/zgoPcs/HQwypM+iLs4WRbrKAORTLU5YUciL0q2F5cPGajLUTVYQSr5WRAu9rvAXLSiafb05tKRfyZ07hK4ReIt+p1EGWbsXmDknD6wdna2fiAyZM0653kcvWvrcTTmDkpWnHOmDgCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ig2spnB5; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ig2spnB5" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-71e3284f963so1236525a34.1 for ; Fri, 31 Jan 2025 12:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355091; x=1738959891; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8Y1Uq2vC9ngxtabj+o6Gf/0MmnPKx34MFqyZVe1ZJHY=; b=ig2spnB5ORsHBPO9Y7nXycafF0XrCNtyHpbBQiJlFhRCJzhD+P63NHG7Yc3+rie4wo Mr917YqOD9SDmep54TVk1MQRWPTZklSbZHJI0otG2bBK7sL8CU+OGhyYSPEut98gL4Am /OamnTc89XUpnCD9s8nMCU1Yp2t50dPGzeYwrwj4B0whOWNhTdqOgAGsfB57FU3Q7ibZ +D2hbdgSPZW/fxOr2hN2CCrhN6U1bEW+MkJXEhvm7iZ0xdvgqfME5m+uCnNVxhEQEJMH Lx2W6FXmvSWHlwbKU0a4TJ/gjeqx78VIr5vzW4+lr6aucRQxdzZvzXh+n5sjyaEunDVz 5L8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355091; x=1738959891; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Y1Uq2vC9ngxtabj+o6Gf/0MmnPKx34MFqyZVe1ZJHY=; b=OyAlLKewbg3HH4IuXmIThc2otIPFHoTs6/v62mcLyNhQyYBw+JcKQ4DYo/XYKixX5e PkHxUw2AAEDkudAW7ftowPFbUs45aPgeIoRehD752cZssngQjC0LgeUY/zmBqq7Yl96K zaYrX2fEPqUp65y1gNBFx4T2ft/7OjEMHGfbs5gSpLgxCEmaY5kW5ZBH/Wz1ubx20pun TxUOFMtzsBuTdzBL295Toenph3UrMuNrSHZ4EZUPDiDR3SWipbJXulSdVSJQpWVqVyre O+DAW42/E/dI1GOKFxiveciNz1hrdNG398sraQP08CO7HEk8H90y/Irb0vcqpfv0dlPm j2TQ== X-Forwarded-Encrypted: i=1; AJvYcCVcukPLMhoirKTIItdGV6W96T283M7+17yqngORTmPcmQMw4aVOxaD1LsXOLAShIvkNYA5aXLGny4c=@vger.kernel.org X-Gm-Message-State: AOJu0YxNrE2o/hXBIqmUowHNmJZ794FOfQekNT5VS4l105aKArFc9N2y oJ/zMasb7DcRXx9f64YZQMNzXDAsgwHK/WcnrbWYrPvIVa7HbOLuXH6uu1pXNqc= X-Gm-Gg: ASbGncsyYWXBeYMni/JrlMB+VnlXtjztg7uf+88e8M5Eda8S9rpMHjmjWo5TUlMTrQK 9Ys/94N5NkZ8yro3owaY/qT6GrxLVVxr0vPN0DliCJMmxRL69cuXfd1hb+XrZKTKkK1pgci9AOv wSTPGqOzmwPKimX4YRU6Ay9cEQiYdlrBeac1mn7tKkmxLymR+Qf4aWnedlkC07fvg8+3agbLJw9 lYcwIkIVHAgWNhcbM1a68QIXH7161b2dmScpD4RZTTzfXWUzLuxrsuS3cFEXH73qFBH7FrKoBYz hnM2sld7l8orols5tGFOagiL5CuxCaIcgOOOpKB1kvD5PfU= X-Google-Smtp-Source: AGHT+IHpL9OiC+7p99DGjWrddY5GvJC4qVZT5ABdvIbOzG8MeWG3IwFdHaR/KYiBNOSR8xIQZbb8jw== X-Received: by 2002:a05:6870:ff46:b0:29f:ecfc:32df with SMTP id 586e51a60fabf-2b32f02152dmr8447581fac.14.1738355091503; Fri, 31 Jan 2025 12:24:51 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:50 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:42 -0600 Subject: [PATCH 02/13] auxdisplay: seg-led-gpio: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-2-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Andy Shevchenko --- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c index f10c25e6bf126cfaac3e4c353f8bfc6639d94a60..c158b2c2827415e75d0b122914b8b18c043e8c76 100644 --- a/drivers/auxdisplay/seg-led-gpio.c +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work) bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), 0); - gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment_gpios->desc, - priv->segment_gpios->info, values); + gpiods_set_array_value_cansleep(priv->segment_gpios, values); } static int seg_led_linedisp_get_map_type(struct linedisp *linedisp) From patchwork Fri Jan 31 20:24:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955752 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B15811F4712 for ; Fri, 31 Jan 2025 20:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355097; cv=none; b=km1Tw1CkJTNmdDwkGRt3fNDjL1FqOhZysWUtRVesE8biHiz0UeKpqFt14QiWrCIHD2V+2vX6BCQISztbIwKt8WlSP5LtyZU5IxQMd/Qq1XZGRQGQ+/FsXRaqZZcySESDEBlcUwf0ED8Oh+mDzVmg8o1pRxZWGgyZb4+gMv91GUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355097; c=relaxed/simple; bh=KSnpvBpYf1I2zTKJ1PQkgSeFWmdqfKH1K8H306V9HCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kD/ijQA3dIfIVItzcWUyf96LVZ3NFO5VP3gsyvSmlTRWHm/9xJtjKC0Fw505aZVqHRLeuU5HDdWnYTJ6b3GSj+WsIzkm0oIWaYkap8ngDglSiSkpDUhsCS6UNOojht0QKHFLE++urz30aJZ4pTFmRjkaBof2IWiafOZOKVIaLdk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=kHPWQe4x; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="kHPWQe4x" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-2b3680e548aso934578fac.0 for ; Fri, 31 Jan 2025 12:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355093; x=1738959893; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=g/d91jflGtqcHyVEIBk6nu4SgcmlMkVjeTIYU/X9iWg=; b=kHPWQe4xfcF8hLtkR73pCTnp9JC2Vm/ElpZTPXHBFENS4iT24APePUQBTkbV4+bEA/ 0RhMD7TIunoXPctqU2fPlCrGa3VuP1xVpfET4CmlHHA1RSayvsnIsckNhUuiwUOXGQmV xa2xA2Ch6zTxl5kOtM/fsVWxGbOJ2n9EuIGsxWawKEj6TZ9BneYxeOYrFCRo5FzBVbX8 5SQoMARcWE3CvFe+zbojReetgvJiknmmYk+Vzq++6AX6SkxKURkZKOduwIkDOp1rr46X A2gNeYU0pPxNBBIic4gouY0tM+GFGx3F/Id9f/o9Qc7JiUnW8AEMLqd+xt41yWYjYJMg VJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355093; x=1738959893; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g/d91jflGtqcHyVEIBk6nu4SgcmlMkVjeTIYU/X9iWg=; b=JmqNB9ridw69/UijePgBFdC1/W7bT1pEqgeyFOySh79te6yaexpO+4aW/bdat1Nn7/ 0S6aBjqUK3kp0ev+gn4qh5V+cxAFmr8G1d0B6KyPOY5CWYRy0O+KrbS13Whc88dgbw+5 mmmgBUcwonTUFcQFp95UZdqfWbKz83nQvWVqiMyR9IBZi/T501437pFnJT3WlL+Jego8 uJa4mEvh6ny17w4uP1GPoEmbaaIk4uIJ00ZBYcZ7xZ92HB/F+RAzgyGlkoU7yTYmIoX6 gkKk4OyW25x/7vZR+/WVuS302vR2a+p0cQybKdl42687QcMCD9sjCjcXBRSMlShRVrlw /jDA== X-Forwarded-Encrypted: i=1; AJvYcCUkx1cSTgs0l5sf1OYWe1UCUfnM+41yiUuVfvuDilXgwmB87bWd98K5PKgkDc3ieyNirJiCkIMviV8=@vger.kernel.org X-Gm-Message-State: AOJu0YyawnVc2B0dBG59cAHY0OqECuQ9K65hM8NZBjbKtwQ9rffdt4jH 4vbwWBuEuIfFdInGxG8gBokGdCIHwoBp19aiM0BgGDA2x9Jqez4ZE2voN/qFjfc= X-Gm-Gg: ASbGncvqjiG3MNjxiSIfiVcEazUnxNlNP3ba1vuR/Daf0OUOppUCnv2oF3xoAk80vme nax+e7XiDkjParW6bHyxP3N+cbPBreYU8MavFjVyn9lYtu8I4SxkbfaKrBY5PB1fNvn3xwl9IVu 8dxbBvmvuduzC217+gFCY1jD8xJgqSMU3qM/z4MwAGt1tmSZ/Zt44VPzzqSp7Kafa4sP9HH8s7j Dx9P2HDKcHWzBaXSlcU2UAUZJWRyJCz3X6pqxfbvPVm5k3rlqyRjFQNT6VwlWwJtaxvwBOidDpd NGlpEU8kVBFdsopDBu4Y6yEkmpwC1BycIT2AvrAZtfc7ouA= X-Google-Smtp-Source: AGHT+IG7MwrRorXxkcWjIdgGK+4mzXkuq9AO0FFEdnZrk7oRmiSNnPUZ/DfqxHivj4lEixFczChGQg== X-Received: by 2002:a05:6870:d1d0:b0:2ae:d23:3c2d with SMTP id 586e51a60fabf-2b34fe99372mr8034579fac.8.1738355093684; Fri, 31 Jan 2025 12:24:53 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:52 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:43 -0600 Subject: [PATCH 03/13] bus: ts-nbus: validate ts,data-gpios array size Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-3-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pdev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); + if (ts_nbus->data->ndescs != 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn = devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), From patchwork Fri Jan 31 20:24:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955753 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2EB71F4E43 for ; Fri, 31 Jan 2025 20:24:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355099; cv=none; b=p90NdKoBi98eTxBP6cjAPXMsQMttA2oDxtZ+g6nIJq2m3aTmtSLS2ZMdKrSGWuICMw4ut+7g2r+AstZx85G+tsaXXAGL+o6vUacRLa4RBpKNHxtjUQ3QpCS9kvvQcXBoz5uxq/55cnIxHd5oXKNmqYPQxMBmXrUf4v1sbBqTFg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355099; c=relaxed/simple; bh=YRrA2gctgtC9TxPdq1m76F+qrw6XgkoDj0DtVE83Qk0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ka20YwXyfBb+AuLqpwKTzekzhFr9F6IL7DGCficfcuycHN5yCXjATc7FRfI568hojhEuORvni4y9VLVzAw0Hbi50j/V4e7FlrI2dZr6RWCczIZ+VmKLK4BbPzKWrFNyl7UIoPPQi+spMkapFdn3RF16a2PdoMVI+AGo+4B5OY64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=NDdrGTEY; arc=none smtp.client-ip=209.85.167.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="NDdrGTEY" Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3ebb4aae80dso1011130b6e.2 for ; Fri, 31 Jan 2025 12:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355097; x=1738959897; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9hlyYXLAXkselsSNF7g0Bc64z/LNWZ956QqcL4gqDjo=; b=NDdrGTEYz2np6Cl9evbzZyDhI/48wDzwH/V/o9jhCus8B4Itu8rtWCN/G175aqpP25 3eN2VqFSu9aiy1ZSMHmmLkptNDCz9pnbscxcAVeVAAo06WrBVIdJpPMOJm5BBI8FDoqK Eltr9akLCmJcgQsHWwlKFWyNKrPq/TobSsUsiKO7MfKwJYJ13K+JJm3yuB6SD04pnKCx X6o8+4mlL90DOWZMwDwgmw+TIt0jiDjrtPdJpGiQgPObMN8rKQdhwmE5e5B8djmy85YE 2MPRUnZ2SDn0IR9qnz+NMVojogLOoy2OvLOg6eKcXggazySkyKDBDiMcPFstObe2681I XOpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355097; x=1738959897; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9hlyYXLAXkselsSNF7g0Bc64z/LNWZ956QqcL4gqDjo=; b=W9JEzXD1xFld4OdZjxj+/Cz47/23aMvBbIBryiUbb8nI7QqhDkkxFlDYwNYgY5O8td tDds6mHevnH+x3FEYL3TRrUDIwKqt7SNQrjMr04/Rb8vwcP20NsKyfmB04Tt5/1vcBxW NflpoavQa7yVgQHqLzLSofYpzvceBz07ZO2AZtqsyPo2hA7RM6ZovC7+o6zYR9zKGyGY c7Z8X7VX/l9v4JdIPIOH8+sFGBoUhddvXdiNWS/7eHfVZS3T+aATsl3/DvEv4l85nUy4 Sk7kWPwzbCulSXi500LRPKBvrM8Tt3GS92kvpf1YIVnSfzmCZ8/v14Ni7XNDYw3NdKns Mcdw== X-Forwarded-Encrypted: i=1; AJvYcCUYgcFu/I2JPz7vVpkDQRuI05Jq5lV5fbdtJL4PsH2vTsqbzAMpUuSfbJn3RhoxPJ40/8kA8JLE1hw=@vger.kernel.org X-Gm-Message-State: AOJu0YyCzqs6sf6OrvEXChPD+vdwkiHGUhPmAEGgqrbgvS7rulzqny3e AvCo5bGKc2khQjniGpkT7boQnGY6NHdF9IJyVGLuGGHCBxNQ/K475YmhG/PVPSY= X-Gm-Gg: ASbGncvNjj/QBt7HQOFdDSoj3qy+HtRYuGwieEvhemOFkVJ701o6Y+e+vKVY3o4qvfj mg+KamxYwHlrkSsTDlP8GCJ73UItexz25OS9kjOInqgHHLij9bPWtDhhYEUT4ZPriFEieYojaEj 9dRGKjySIAa5a50QA2Aqkj52bzIyxsoAtH2yItabG5PYoNZ9Zy/GGVbBySk0HVErQEUHg8vzIP3 d7ijDJMxcWdYECk21HfY48hw3mCoU1feBErgw9GU/t9KfLXYMJYmtQXEqzDz4TRGO68n1T8hSTa gXNBY3zr+2+YIDPzLZa6M8IutLuwBm9/fXCxDMns485DYVk= X-Google-Smtp-Source: AGHT+IG22JJZ1zoEE08gl8CxgOf30mezmJIUs5PEqf+3dMT59zSIuFvgdvLgZxy1Rl/Rs71gFur6Bg== X-Received: by 2002:a05:6870:2dcb:b0:29e:6647:1080 with SMTP id 586e51a60fabf-2b32f07b26bmr7733897fac.21.1738355096771; Fri, 31 Jan 2025 12:24:56 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:55 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:44 -0600 Subject: [PATCH 04/13] bus: ts-nbus: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-4-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..31ae9a26257c3e0af2ba99666e0c04e882da935b 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) values[0] = 0; - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiods_set_array_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios = ts_nbus->data; DECLARE_BITMAP(values, 8); values[0] = byte; - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiods_set_array_value_cansleep(ts_nbus->data, values); } /* From patchwork Fri Jan 31 20:24:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955754 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E7B1F540E for ; Fri, 31 Jan 2025 20:24:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355101; cv=none; b=bmTDLRDgcZGNY1j71/JsZH1kopZXNH0/o0gJzBFsQiw1MRP2GH1zJWFktQsEK2ITkYcsBA0ujhQNmlrUdJCFxijCPx+2KejDCA6ZYB/MUO/UhGQaU1C0vuX3Yuje9URHtMCrBxa+tGaVCSm2tuozy9HvO+mU46zMUHYUUlJQadc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355101; c=relaxed/simple; bh=Y984jgguFlZIBOThWuuUJpuuUbC3lQREEzsrrqDNozE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tXjRIWSdwHWvRUmByrjuQBc7SUfAtKyHGqmganbUaxg/7sJm1t+LHPZECjuB4m4F36vUOIc7zn6w7F5dyurMUZUTlmh65OLrEBeLc+7/URHZDHW9E3+Sgu7cxds60CvPppCi7FxhuMbvAJZVilNg6710nFU5MGIq1aGIKCVsDfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=g6MnSnqm; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="g6MnSnqm" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5f2d7868ef0so642631eaf.3 for ; Fri, 31 Jan 2025 12:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355099; x=1738959899; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o0JxocTLtlGRqW6c379kuZnM3hX6Je635Dhf0CbFSJY=; b=g6MnSnqmPtos+/Hg7bCHWyJKjyq+TDTZqQp7OZrONvvlcKC/VYH7QgztlisRLGBmdQ jghEuXFMKrOniW4QAFgqAQCOipaZgdbpuJ2O4hEfYH6TL1LPD66bsT8BBIUmC5cK5oXY a3WzaqU9TOr9tJbZlFvfxYd28mIK3gM++T93/iSK0iFNb/wyxXP5FCzwszwhwIwkWzPF Cf7b4jyXBl9ahw4wJ+Dwp0erV/pFzP6ulzDkKc2WOMQkoWqUs0lv6OwYa4WGFYdXzh04 EW1bOG18E7VCvYDsAEcFi3H4hFINROcY5yuREBrnlO8RR+FZ0ZCadWx38i+EYlzpnau/ dkSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355099; x=1738959899; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o0JxocTLtlGRqW6c379kuZnM3hX6Je635Dhf0CbFSJY=; b=cLFVaNgBjvlXLsx29apkDeTay6ftdjsRKoNmSXvTNw4gqcI1CbrrGi7VTQCBFxl4Ej jcycVcVGccIETI1WomyDbOvRDnGxTpkQOUoLZDHL/kDX+SsYKbbA8kEz3OBZsMg4W5qg fLNfpNe38VqEH2v1hRp7iK2o5hps26wp3o745gn9Jfm4ddTfv2ni/Xk1/rU9jGkj7UI7 md51WItgSg28S4Dy0qz0zvNyjy0MBKS0eKqtG5B2zMl3zSgg2SI8UMcW3npX1pHXw/Ke z2YH0biazL9RfuTi+o4DERTR8bx5DclnOmGo9yhzRqEUdw7edxweWoQx4sS1dsfb/wiF nrDQ== X-Forwarded-Encrypted: i=1; AJvYcCXXW3rSX6GYslT5GAm/XLGS3cY1XgfUQOfyf6FVVEhEBAVBHVZwngXdyWbDo1sS10VL0BAizxMZB1M=@vger.kernel.org X-Gm-Message-State: AOJu0YxtwIVuMKyUCCixgYAZd2guEMYeyJGsW9tgMfrUozt6l4/2BMWS B6RlAWlsuBZuovzk8n1VnIintUu3vbszh5Coa3PZO2IYu5luT9lFaBdsNbWdjuM= X-Gm-Gg: ASbGncv/vyR0Xe1xIB2afAwtJqjKrkbcRKG7PafwWIy1SZZjmv9zJbz0IE6vLjt8bfG f8/k2Hrov0wdbzjO4YGFLlH3pqnKOpjYhCOAxoJ8Rqc3atD9oKeSUQodq2hA0ADf+F1pUezPRsQ 4LaHzaxeXo2n1YFNqhSEZqGdKIGpL2hKg0wN2gxSvKAyvNhaCO/hYNn/XCVImLDf4668xJXWkyQ V/mk5YeYtjmQjY4Gh6xkzxKEBpsSHGVapovqmCIjGfuzfeU801wdwX20N5ckbiugBKrP3WLNwC9 tRiSpbXBAnOcj5QEyvee2SbNPgVIxVQ61Ead28VYn0UUGkg= X-Google-Smtp-Source: AGHT+IHLLvw8v92D1IAdlvToO2DW44SjM8+FGXyX2n6gPI7BbY77buvq2CWQaGC5P0PVhdqadGjO1Q== X-Received: by 2002:a05:6870:948e:b0:296:beb3:aa40 with SMTP id 586e51a60fabf-2b32f350834mr9144614fac.36.1738355098867; Fri, 31 Jan 2025 12:24:58 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:57 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:45 -0600 Subject: [PATCH 05/13] gpio: max3191x: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-5-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index bbacc714632b70e672a3d8494636fbc40dfea8ec..fee8dd2bd3c9eb7c06817430634eaf905cc9cbd8 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -309,23 +309,21 @@ static int max3191x_set_config(struct gpio_chip *gpio, unsigned int offset, return 0; } -static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, - struct gpio_desc **desc, - struct gpio_array *info, +static void gpiod_set_array_single_value_cansleep(struct gpio_descs *descs, int value) { unsigned long *values; - values = bitmap_alloc(ndescs, GFP_KERNEL); + values = bitmap_alloc(descs->ndescs, GFP_KERNEL); if (!values) return; if (value) - bitmap_fill(values, ndescs); + bitmap_fill(values, descs->ndescs); else - bitmap_zero(values, ndescs); + bitmap_zero(values, descs->ndescs); - gpiod_set_array_value_cansleep(ndescs, desc, info, values); + gpiods_set_array_value_cansleep(descs, values); bitmap_free(values); } @@ -396,10 +394,8 @@ static int max3191x_probe(struct spi_device *spi) max3191x->mode = device_property_read_bool(dev, "maxim,modesel-8bit") ? STATUS_BYTE_DISABLED : STATUS_BYTE_ENABLED; if (max3191x->modesel_pins) - gpiod_set_array_single_value_cansleep( - max3191x->modesel_pins->ndescs, - max3191x->modesel_pins->desc, - max3191x->modesel_pins->info, max3191x->mode); + gpiod_set_array_single_value_cansleep(max3191x->modesel_pins, + max3191x->mode); max3191x->ignore_uv = device_property_read_bool(dev, "maxim,ignore-undervoltage"); From patchwork Fri Jan 31 20:24:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955755 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11B9A1F5600 for ; Fri, 31 Jan 2025 20:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355104; cv=none; b=lkfpvB2eX16sP8jO+nFHWF5tvt5hfoP5syk6UWXgN/tUYHQP1PEaB7kgOn7i/ivKL7FP5SyOkTPrUUNiXSboJtPaX7sLEIoXlnxXdxOc7by+NFOsAJ0Qn0bhRgZz99trC5g0AelN+SgtNfTIVdm4p5qvzUmCO3hpwqAnLGvZ8ck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355104; c=relaxed/simple; bh=9/jQiweV7yB0cOyjEzTaktkYDTP4ZnpLC0eY9PbXQiI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rc2MbjCfcxQfUSr/Bk5AqeVsn3NEVvwN2kULKJIg2RQB8js/V+1gBCzA3gvt5vts9jAK1PBHKHPw98HxMDydiXQV2z6d91KDR6LAqw6nWqGsKVrYJquisprtazrEy3Y8k1pN4Ewyg1sf0psohjaYFmfwxU5fnvqTaBkEYAqGXMU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dPOQXsl0; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dPOQXsl0" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5fc0b7a4e5dso1111212eaf.1 for ; Fri, 31 Jan 2025 12:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355101; x=1738959901; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HLsz4+tHpjKqe9Yh2fzFcV0a8GzDcsWx5V/eyXI7CsY=; b=dPOQXsl0jyCRKlP9OZrbnBzIkog9S7YDFa0F4xmuWXBuN9tnRHwd2YqfZbpjURjHM2 qotZJvpGyyYMyW3I7NxtrwidnoXp9GUZspNWpvTUEjW5TY0uzG27gbKE3jqVKVXaamVV c3sCvAtI2fBkvD/jRU1HabsdnA1biCTUsxXzorz50dCFKhTEpAK7eWVgdg3z/364Dc/n GB4Kx4b6/PU/kvEOEgifO7TlOvvbLhze+14A19IMqYf+IbZn2EFAvoebHmjnrwFQBsyG 0o+mH2KgOAiIG552xnoZDlO3DmItar2Vq5PY90p38uXkikPoSt+v2xaj9hwtSwmk3p8I 7QHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355101; x=1738959901; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HLsz4+tHpjKqe9Yh2fzFcV0a8GzDcsWx5V/eyXI7CsY=; b=N7peuOuqhZTZKPF3R7ayFR5CLBRcZUDe9hn4sogUtV5/ImlkczlDSKczwwBLhh8Pu8 hfNTsOnAHcwsxJNsy47EvcB5tO2dO/cWL9KmUOuRsn0thkgP4EnlD9PNBAim7rY6O4zT oa7sBlUr/VH1jGsZG7MnmexWIInx1IDvOVoeenfB16mObNCTY5ToSa8liWjK3mP3+ZTS a4Sci3Tn7KbbpTH0kh46j3QjN1Fj9wtdXB06GACpF76uViCvcTwIT245e6IruaLyWv/L T//XrtV9zmnsdPBHRPmo3xJ0/fiUiG9CMpYkWooYSGz9whoCvCU2lyl6pndCDeGyouiw kDuQ== X-Forwarded-Encrypted: i=1; AJvYcCU2Bx1POu4r7iQ2JH5RCvRfVnW/ofXX462y47FCv1ZLPbEUowJNB/5ELp4AWXGBEieYHqGDF7bfcBk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8opvnHoj8bUgx25iTzliIdgVFHG1Ns75Qr1OqjeswCPQQQmV9 NncukCICuXObc2WFc28ysb7fT26HTnjEiM3OKTaMhcDbQ6D4vUP0MyKWTm8ULns= X-Gm-Gg: ASbGncsXrx0T74nX0ibN+lpsvOzbqSFvavaLZiQ4Chh8EeOPmoJqulP4b7eu2d1HkmD t2gXLqEnT/m3zqeoTD0v2HCNweOJJuPAkOWf3N74PmDrJIoEaDR14uQ2S04i2ooEOCMawKqKVc+ vGSbkCrTrg4HKPGsxccvfbu4XFpj6sLanQ6MYFQOFby/gEdFaJei+69Ul5KDqq8X9r6SV0JsJzy MfNGThAmKyths8wEeWswzv5rMwkmET3wG5/itgFKdOelJz5+K65NjjaHXijPxxHYKa1wmtBN1hv Cl7OI5OKN1ajUEfW8TwDf/9liM7aNgZAo9iM/0WBfst/uK0= X-Google-Smtp-Source: AGHT+IE0gOiKruiwKZS2fVv0rrPSXfEcYE6NWhi9xtJKoPa0qd12KXWlAvVzsWhUG+e0SGLuDExKGg== X-Received: by 2002:a05:6870:702a:b0:29e:6096:c25f with SMTP id 586e51a60fabf-2b32f0bbdf3mr8023505fac.23.1738355101014; Fri, 31 Jan 2025 12:25:01 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:59 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:46 -0600 Subject: [PATCH 06/13] iio: adc: ad7606: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-6-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Signed-off-by: David Lechner --- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d8e3c7a43678c57470a5118715637a68b39125c1..fe2216fd072e375f3dd8096980e53074f8ee3758 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val) values[0] = val & GENMASK(2, 0); - gpiod_set_array_value(st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); + gpiods_set_array_value_cansleep(st->gpio_os, values); /* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset) diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c index e2c1475257065c98bf8e2512bda921d6d88a3002..d3064e452adfbc40b44f4437e76a73aeeb036ef0 100644 --- a/drivers/iio/adc/ad7606_spi.c +++ b/drivers/iio/adc/ad7606_spi.c @@ -297,8 +297,7 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio_dev) * otherwise, they must be hardwired to VDD */ if (st->gpio_os) { - gpiod_set_array_value(st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); + gpiods_set_array_value_cansleep(st->gpio_os, os); } /* OS of 128 and 256 are available only in software mode */ st->oversampling_avail = ad7606B_oversampling_avail; From patchwork Fri Jan 31 20:24:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955756 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3E651F63F8 for ; Fri, 31 Jan 2025 20:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355106; cv=none; b=ceoA1yI33J4UqRHFPc4iHQDpiRc9WaKJcqJS/8lhWNJSfw3B6hoMf1iHj5xqUugHHR4OHa95tRXy0HQaBxslCl0lGximXuAvw1E2hW4QrnoDvyy5AgENaDm7A6IfEp0vsvoX3IhdWyA6TYBhnnFUyNvnW7TGGrcuTPaKIQbf/Lo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355106; c=relaxed/simple; bh=a4UCT4/NNPETnikiY/3/IXvAqgQyANJWQskJKLdiZxw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DD0FWMSxfdqg5ta+JuT4UcPpsHj+A6BJalS6wtNur5tc4otHkUeJP7mMgFVlc4K/du27rRlZZtN9afRkNLIxILIdUJTnKw5ifH8gVs+tEd+UGZwsjy2MBCcdEmfwIyRXjXpihLd9VFCgSdXiByvjAtxC9psxw5WPhWKtCDCHIc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=i3p50MoR; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="i3p50MoR" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-2a01bcd0143so1484714fac.2 for ; Fri, 31 Jan 2025 12:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355104; x=1738959904; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WNU4SR73NkzT5flFO6XZzV58Nb+8n8xP048rFGpOLNA=; b=i3p50MoRqTck66HqRmjce02FFEVCLPd1WryuRoM8Vuk+27DcmPvbT5L1dLrth8Rspe SEJB+O8mrL3HlRbKg5VFYWuQCDhd9iOd4J+Lt4BFQJljF4pHcQrCLAKdvLDtw0FlJGV1 7dEVAyPkdLMXt20S1aFiNAknpOWcDXQLBiMeQMF6UQLyyjAzwVOLhiheBRWtvlGJLrkT YS2GUkU7S1H9uADGOi9+20YUVkUG5taerhoyFL8T8fFl/7yBhswxXr+dFp1bwdy7n38P 1IXFmSQrGkvfN+yZ77Yu/R9POZDUUjLQtzpE/7EtjT2Db+Ut9M+aCRHdVkFBw5e8e1N8 FszQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355104; x=1738959904; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WNU4SR73NkzT5flFO6XZzV58Nb+8n8xP048rFGpOLNA=; b=EJLlxz5sd9kK2dfIH96Cj4ABfWUxCDsoz8PylrGKROrtjxcldLzrmQewfwmfPbhD3D XxtSG7BVsQ38uDSO6erFYQlpciTth9HK961kwvYIdNdr4oVRC7Iuqyxm820iL6R3iDBm whwWwggYb5jzMLKnvmkEa1tT3CCfW9rmZx53B/YERWZvIDMNo9LnNltc9RdxwSuQPypm ntLepFaUCGWdCOkvY9oNYAcLRX0S4u+RTp/1EGpPyeh1nRd1ZFpTSz+Is7SN4Qkc2lNx 9pddKDmgHKk/ETaNGuJsIQzYiRgpA+RJ0WUr8Z/WFv/wDGkHFpPTmBgISCehiQ9PPuk7 22Yg== X-Forwarded-Encrypted: i=1; AJvYcCVZ6FpH0d4w9Tv4VKE7ThpLgfKCvaJu+O9E0jIvzb4E65CKTK4XanTxZTLmBcdGbIAdMYhIe8NcLVE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5zV9mXS+AWp89BPEahQYWornGqWAFt5Vah++Vofdh/xaFIY2m sw6ZSubSTiyG75FCfxk96snus9WY22RG8pAR/U0PaJLwF5oluUhG9e9QLEPIe1g= X-Gm-Gg: ASbGnctiT6GP2f8RRTkB0ptbp0IYKkFNXTD+kriCFJlmgq7nIO9UKkYks60Tti71wwq qpm+cyUJi3pFIo3l/ySwn9Ccgd1NVL/4W5i4R4cvaldbGMU37lbFFQoz8q18JacgEnqpYPZYCUa ZA1LxMFmOHn7jAbELpiKh82x+w9G/L0Ni7rPDXCEdTfqKMphfqPMYa0o30/Iq97utQpIBJsSbCE FLEBZx+I5tgE16mEgxauIbLeTPJ5/oPnPsGpw0WfXn8CeJJeQrN9JHyKw/6M2A/4huHD13GLBdx H7jKNBLFZ1IHOh+YO1F8mt/pvsxQz5HZbk8ray0R3iTbGF8= X-Google-Smtp-Source: AGHT+IEjjM8UkUItH0qBBqM7/8yjcARln6tFWMQk1I1vtwY7yg+bjxT3tjK0CN1AwA297vbCg45WVA== X-Received: by 2002:a05:6871:7891:b0:29e:48d6:2e62 with SMTP id 586e51a60fabf-2b32f06986amr8146491fac.9.1738355104164; Fri, 31 Jan 2025 12:25:04 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:02 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:47 -0600 Subject: [PATCH 07/13] iio: amplifiers: hmc425a: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-7-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient. Signed-off-by: David Lechner --- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index 2ee4c0d70281e24c1c818249b86d89ebe06d4876..e8c67c8145b1b9ccb9b70ccd3ce4f5de08f96e69 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32 value) values[0] = value; - gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, - NULL, values); + gpiods_set_array_value_cansleep(st->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955757 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 641F41F7084 for ; Fri, 31 Jan 2025 20:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355109; cv=none; b=a0B1n0tvJjWjK0fxFG34wa3KM4SGamK3oy4ggWuXcxlSE7tvGcT/Etq8lpWOGWFr5YNrvY/NgWVRVO5JawCLU/dSJ7cB9MMh6Zu5wq7QVfuF6MHN0qbZmB+vIp0pjd7dtJvnYz6jzwsd2l8JWDlqExswGZMDt1WySL2KIQNv9lQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355109; c=relaxed/simple; bh=Dir9udBrhZIEDuzX3pRLNcZGmhbiV9AhUdKa7dHH2zs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S7Xi3c0rJCTqQoNvtHG2jc4aqEVycsc0dk4NYoQo+QSCNF8r40vAMIJJybVnfKV7vU4Myf77UEm31Tx9TcPwE0NdanmOXkxY/Vg135vNEeSP1tZCBSq4/icAYC6Ns0a6v0ymsLr/H5zp0/cNhkXFzaAkjWVftESBq5BxHZT21Cg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=JLqiHDEm; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="JLqiHDEm" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2b33aabfe46so986026fac.2 for ; Fri, 31 Jan 2025 12:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355106; x=1738959906; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DXSo9qIqFw2jH0TFUFiXNHDreUcSE5l/XqXZpt46Vu0=; b=JLqiHDEmc5QOTTvhC7d5nL1vn+WC3Poy4hTEcuXYTaFGW4yEm/1zyc+ngmEptSqGFM uLDCvKUKB++42M2YtmVGMG0QBxnNnDglYbuSmoY6Ojjf+BoLddAmKeFvrnbE2viMU1zr hhhq06ewVft5HMEb2wOISaPPa/E+ZIPsyuNTNxcUhi0AJxLV8Be03dvfV0Xq+T+brhbL cQUb2KfmxGPVChau+3bN0HKFgOtWb+up3CWWwR0OUMjKQ6/0E678p/pgFHPrZrG4NkYR HfGTCH7jhVbD3GS8EjzY8v/BkE8WIdOJ9SLNLfWUMt8ac9GfrpDw1+tbgvOHgUbuo8Iq NhKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355106; x=1738959906; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXSo9qIqFw2jH0TFUFiXNHDreUcSE5l/XqXZpt46Vu0=; b=MA9TjrGqVsW6x4MxcRMMUSx1gK/lW4BfBf91TKb9jj6BmaA5fSmEfpzhFEbr49oERU 52GSO+KCswwBE75Iiwj2M5rkTGciNvt3lbuppGNRpJT1uJa2xBUQy+BqQr5yQP+jJcWc KTpHARR+YB/6+PJhRu8LR/4SjzD+2OwZYP4pE/q/wQhZQaiEZTYUGLMs1San0CynAckE JJ1JrLFvAyTi5H+EjUO7uRIdO8ft1Iq7vwxw81Qkasaw9yM4KsEmUui0pOjXI/PCFUS2 cPqTQwmYOlUxBYPbQ3tCBby9Zap8mODR8pX/sjWBac6BMZUseyhKZeanVqdZJK1fgdEC AVbQ== X-Forwarded-Encrypted: i=1; AJvYcCXUoXRqn55LdUzovdFYMcqwk9ZF5rfo6xjo8hLBlzWGlwBVC5ALXinahfj/l/3JPKC02nNdKRljHFo=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ32VrcF4iqdHnNbv8NfIMpsNUtrzocsyo4GLdPmsV1qNgCieb y5OV+Ptihk4Yqq1pcq9uOtMRIoDMwOdkO0eYmQLHYpUVmhmdJKEfBRQcadVLoRI= X-Gm-Gg: ASbGncuJO2Os6dQtDraJK3ff4xRVRGcUVWtAhkxwNUS2u5Ozc784i7Tj+A6f5ba1qc5 dorgvqlTpDuKAjk8uE0U3Gj6GigGKkUsrOvBtbkgQ43/1RGFFCcLimqxQy+cqTSEUiEPUVZBk+Z Lr3wDJtjR/6ONDUfoS3XlgWVkz1RWdWiH6JmF0Oz6rIq/KWKhnb8QuL3C4yDxQorPBYkx+IJPJP 9DjaEo43bwRrkTA94oCpABWDh6EwFQLukKSmqBpjtr5hicBkdoxmuPbifzD7hOUjULJ58W9qKay V7KKIXrjyYp2Ss5K06sqEwASzsWfP/4mhOPI5CeMHTofnzg= X-Google-Smtp-Source: AGHT+IEk+EYILkaYfRPwnEDbJBIEBFXhatYC+4TE05088ijfOkCj1XESP7wyxn6VQQJyYksFnt4aeg== X-Received: by 2002:a05:6871:a9cc:b0:29e:2d18:2718 with SMTP id 586e51a60fabf-2b32f26194dmr7999805fac.28.1738355106264; Fri, 31 Jan 2025 12:25:06 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:04 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:48 -0600 Subject: [PATCH 08/13] iio: resolver: ad2s1210: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-8-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Signed-off-by: David Lechner --- drivers/iio/resolver/ad2s1210.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..938176ac7209a92180fe8d55191d4abce026afdd 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) bitmap[0] = mode; - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, - bitmap); + return gpiods_set_array_value_cansleep(gpios, bitmap); } /* @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) bitmap[0] = st->resolution; - ret = gpiod_set_array_value(resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret = gpiods_set_array_value_cansleep(resolution_gpios, bitmap); if (ret < 0) return dev_err_probe(dev, ret, "failed to set resolution gpios\n"); From patchwork Fri Jan 31 20:24:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955758 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 301641F75A5 for ; Fri, 31 Jan 2025 20:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355113; cv=none; b=KICjf9JrrR51XI2+p5N8XTqbn8wlqweC9R2HEvWch2i83uaNa+Q8I0BnBPgXNJtI8+apKk1xhGrOR/9VfMHp0RwjRwbi/gortrsydxUrbEHGHR+5bCza065rOJY+uVrlPLqoGls3jNF2sn9hrgx8aoYf4lxm7Oqsuru+NJC4BB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355113; c=relaxed/simple; bh=MK0Ks2Di2rJVvigp/s/vAkyxV2Ps9hTBvb2TEAom5M0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gQzRc0RaodosamFqvuUW/6aLzDmHQrO8VtkiHpAjynZ9AHk2YIZ+8ND4Wsuip6p2qyuNpTtg+ANvlQi2PLSF+ezR6oLzJMNw1jM6M2QXEEafbtKIFznBpth6wg4kUEsi/D451TVV1c2GFDzURohUyhePewj7f+4z9SRtbOWXBSs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=TvKooawx; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="TvKooawx" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5fa8fa48ee5so689782eaf.2 for ; Fri, 31 Jan 2025 12:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355109; x=1738959909; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lwWNVnhNlJbHZ/NQhMSjzQrpqbMeo/6h41DdX1Qvb2w=; b=TvKooawxk3ek74wKtIXI5KaEKZulBtQxUrB6kT0RHQ8XQ5TNLQejFlCawjYv5dJxKP QmA0sG4JSA4gCGhiV44hp1U4iN0rC9D0ZGD6wp3VOQdc+WLXeUfK4cBDwc+pjyGzfk/7 pIVDcxasgxQJ2GQFj2lxnW02DL477FldSm5uh+zU/Fgw1W+FRvpN4rRejYXzpHxzzQSq iCG1ZxCO27hKzZQIg5uybXovgC0OSu8/fCgzH4gIlDI1w2BuG2YhRlRuDEC39pO9u22J zfw/1OapEiNvUatIPZ5hKMapWz2jItA1s2EfzhfSeHtmWGsEuE8dHTerIIfQDTMKhuZ/ 0yHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355109; x=1738959909; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lwWNVnhNlJbHZ/NQhMSjzQrpqbMeo/6h41DdX1Qvb2w=; b=VEe6/NoV6xQG0fZe3fdku9ip2HR9yKyta08ouyKXvQVMa/EjV09/59XwMTN7VQeMxJ 7DidLaDZf+zYLqxc34OFS1PWaFhCodCEhNcwWIz5bLpm840gWj8hGuaLFctpZBEkkLCw wIsKa6W9IW8KMd4ZPj9tZVs/bxDuFww498mzwp30P4o91TQNDLq4OM4uRm9D4N7r+SvV +GJn7+A/WtqQGKwaKT5LQJ8vQGsT0t9oKfE/u+ij1v4OuOJU0Elyw9SC0oIga3zdp6v1 StXcOZPw747WhQjlA2nnGNMnNjdvzFARd0r8diAOjA0nWC0nrX4i4N/XMl+nboCyaRSY IurA== X-Forwarded-Encrypted: i=1; AJvYcCVNv6LFcZHTpucfhr8YQ9LxjJF7FGtVPEH7WlVVzNhSgnxdChv6wN5nD42jtXnNRXklINCqc/V6Anw=@vger.kernel.org X-Gm-Message-State: AOJu0YyNepMvuLhZXeZ687+9jhREUz6Im1jWPr/0PmKD8ORs25J+w9Sw fLQXF8K9ET3ScpRYDS/yqg/rcWoJVgzBpkJ6SGIm2/mRPRDxkk/mj8JJIHri+Zg= X-Gm-Gg: ASbGncuDfd5h+jrAgzubj2gvdglCpaAGtDADFXhmjKwkijaYGPVIQihl4TFVNZEelWB YQY4gBl5NKt5iofRE4/Nl5Qr47vsLOqF7eQB6F2iLLJyi4HvSosTfLTbjvXQXf3QQf+W6KppycN NVebQ8B0Rw4zYa+OJzkZPmVJwKwih3yeY3uuARs7dnUlSJcTZMWmE8nMyp2T0NPgk5O3bBD9o3B Ci7R3vR7ST5xhOka90ZPD4Lg2jaUF4DlsGxsIome+BUoVf1lsquFS7fy5y7qEJwnQlZkcr0YVkl GnDCsGIz0KesIP8n5TksvpPbt9PNv0p841LvebwnByXmAYc= X-Google-Smtp-Source: AGHT+IHQyjQ8y3Rtu7NlfkeMw/zOxhLdOk/J2rb/TrRaSbO1InYUF9KwbynHBq+Y9XgpJsj8OqBDUw== X-Received: by 2002:a05:6870:7186:b0:296:aef8:fe9a with SMTP id 586e51a60fabf-2b32efdc7b9mr8033858fac.7.1738355109312; Fri, 31 Jan 2025 12:25:09 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:08 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:49 -0600 Subject: [PATCH 09/13] mmc: pwrseq_simple: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-9-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Ulf Hansson --- drivers/mmc/core/pwrseq_simple.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c index 37cd858df0f4d7123683e1fe23a4c3fcd7817d13..b3a6d053c826741005f1484ad81df30b6bf75bbc 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -54,8 +54,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq, else bitmap_zero(values, nvalues); - gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc, - reset_gpios->info, values); + gpiods_set_array_value_cansleep(reset_gpios, values); bitmap_free(values); } From patchwork Fri Jan 31 20:24:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955759 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22F8A1F76B7 for ; Fri, 31 Jan 2025 20:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355114; cv=none; b=RbRz9ca9ttysB32RMZwF7rfPkadaOmNfOGy6UP4xb+MVNkVSFp1NKwZq72YBWyOWCp8TEw9vxJiMAlizaUprlWEN7GaLl1TQGxCS7jMk64bOiQyBtwh1tGWGXfcm6FX1h+rCjUXwmH104U4ysHbEltfcfQ8vw57Uw53hjDTx6rs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355114; c=relaxed/simple; bh=9CicIm6xDarlbk67AANQJSF1s3m5MgjSBlIRcxjc/Fo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xsvyt3YaYG0qRRx6pHsL/tampxyXLV+nq8X8nv7OX2pLhYdkuDASm/nDefU+3StTx34pHQTxdIgHtGpaFs5/A9Il1NlGuhSfCjZ0gVgHVkhKHQu3uap47aR2gDf4RPVdver4y6qsD8nFv9DBu/k9Ou6EMo1cwfjRQcc/h4x5gwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=wlI+CUIC; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="wlI+CUIC" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-29f88004a92so1298206fac.1 for ; Fri, 31 Jan 2025 12:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355112; x=1738959912; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=q8dlq+1FyobpCXd9TkKRwFwRft57r9IiORFW/g/tAaA=; b=wlI+CUICXgXZ59m2jPFbdGv2J3EAl6YkI5OUi/o+5HQFg88HspRlr0dr1Ize9/zZhX vgbpaxsjqQ/QqRq1yjMqvW9qbxX33uCRK4wTRB91evDI5+FGRFEuBDaMCqG/MQZpJC3/ bCWmxqxUDHoywe7tnFcOdgK2yuwPKsY+vyODObT6GFruCueLz/oc+ccc/9kSiZ+XWO8E 8hdmqDBq4XpUmELiwQFDfZpCjeeFhJdOkm6M20lOsf8VzfgOqD5FaKNCKmDUeS++Fdp6 Xq3mCVUjEVhfX7aQ5E0CD3QkC7ZwhZ9xffOXr1M0hlZ8bVJXGwPCZbNeTgRpOff8wAZW z6Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355112; x=1738959912; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q8dlq+1FyobpCXd9TkKRwFwRft57r9IiORFW/g/tAaA=; b=gg4KtYbl+8L7F/bW7im/s05CxWmUMZXtQscvmntsW43OYPYvUXojMiZJFMSbs+IZ8F 583QT1YJLZ9zQ5J9Jdia0XW+JiyZcxhs0eZIHFxi/zqha1EE0mgujNVjnx6UvViCDToN 3rmn9rNKnRjfBMPKIJ+ClSoQrHAkLechOEUnIS0eeLVl5znTYR4ELrvK44002+mjWa6o vMAgLzxVFsyYowzHZ9nNpKhcUnwO/QyshLF0uOxrcnWrbHCJCYMKaFNvmyCOCp0fvKPr T9WR3VT51iye95FfTV0XASxznJJMJwPoZyVafGkTfjJSDMQ5kX/qMGWRVDyN2w489cMd Q5Ug== X-Forwarded-Encrypted: i=1; AJvYcCWlZ1nmt4zCTZ7SDNZBfs9Pk+goEwl9F88JdCbffyuX5BpMKCgwZbaT/nis7KXK3o4IBbOABs0m7VY=@vger.kernel.org X-Gm-Message-State: AOJu0YxF9+kIFQsknXnbz2SxwTaTj1GFZUFX+b43K8XY5QvEzo1lkQFj eSf3WgbuVzDmw37kWx1ZUWCYpbSYcPbab4mTmLR2hu0/nTfKdhd8s9Ry5ZAjX2Q= X-Gm-Gg: ASbGncua+AnpuOPUV7GIiIcLopdR3RLgVtmP/hM6bLuisyDWkkiSgYPeUMZ/PLUMYaa 6gsJ+oEkIIMcoENRT2p8V/30+Ztv+I3fLJP848B2yp3Rhezo+wD7t7BXP6oXBzmtCOkH2AleTOH qp+7bxL6LKStBgSMCZiJhMOu31sKv9PXlFXup3BAYfKYScYNJzXJCj6xrhBtMqWpjhE6/QYc+re ndP4vB8Y2Pi26m0PLEYEkMlVuIFutWpkxAINC0irQoFpGyfGX+t2HjcJg2AJatom8EI6fMrm8DG IzbyXPRk1juzBFN2ssiZkLDb8tpzAVIZnDrsn2M4/97y0zs= X-Google-Smtp-Source: AGHT+IEOPFpYcNvsoJvtChI72uu39YNNI5XV7tV2UH+PWhk+hEwEt/BHCYYItie+9RSXj9400mKLXw== X-Received: by 2002:a05:6871:2106:b0:29e:2caf:8cc with SMTP id 586e51a60fabf-2b32f30c9fcmr7202349fac.37.1738355112453; Fri, 31 Jan 2025 12:25:12 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:11 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:50 -0600 Subject: [PATCH 10/13] mux: gpio: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-10-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Peter Rosin --- drivers/mux/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index cc5f2c1861d4a22d984bcd37efb98dd3561ee765..fdfb3407543dc3c2563750b013754ceb3390e39a 100644 --- a/drivers/mux/gpio.c +++ b/drivers/mux/gpio.c @@ -28,9 +28,7 @@ static int mux_gpio_set(struct mux_control *mux, int state) bitmap_from_arr32(values, &value, BITS_PER_TYPE(value)); - gpiod_set_array_value_cansleep(mux_gpio->gpios->ndescs, - mux_gpio->gpios->desc, - mux_gpio->gpios->info, values); + gpiods_set_array_value_cansleep(mux_gpio->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955760 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1DC1F8677 for ; Fri, 31 Jan 2025 20:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355118; cv=none; b=Xqb/ldFsQTpTro7HxxePPdOMvz2jMGZY4AwE0zw935zgSyAjudp4+89X6cfL/72V1qTSP1V9BQhYilj1nj3jJGBlxO20bm9vmUnkxp8ezs2dwSV/97ogi35fgpMZ5oOKZUbapxGmJDUYg6H/U2IkGbsnusm+17EqhpKkINogS5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355118; c=relaxed/simple; bh=5lFciV6sDtnvvFQNJQrSdhN6LDbuB2QD+esDyLXoYWY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aGG3iWZJHFctJDskLNoWmpVWkJaQp+MFaIKEF7MlkFdO+BuMLDLotlQHnO9I04vGVwBtBtquFsUpkF1Lz5yofB4LNQdB2/U4kGjabUu5n5yP+jPcd/9LPmaYQ4RO7b3kIHULFtw/+Z52iT1whXTsF4NTPI1on5Z7FsazPP+FC5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=K8giR6/e; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="K8giR6/e" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-71fbb0d035dso1387373a34.2 for ; Fri, 31 Jan 2025 12:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355116; x=1738959916; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=59JJI4CO0oacXanEEbv/QOEs28IMbairlUQePRWumA8=; b=K8giR6/eb07WBP8z96Yn2P2K3obtSp8rW+Pob0UH8Ra4ZZdKYcomCZ3EHCvJt3zZJh BnmQb7b4tAB4gHRhk97QgDo4vASvBI49hBHnGYY9xkkJQyl8WRBdiH8brjJ8sTA3eJCM T/tAfGFulugaJ42LaF2c5YaS3Dl7i9RkLP8OcAgahoha86+w3Evrnth78oilenwTfgCR C6USuGEVz57oJMVDATFrFocZL9xfFtCeB97mx8BZzgVStlHYsJqw1G0AkzXPQPn/Da89 nvwI7JmYZ8cTs5O0j9a2ryqinLe19Yo47Z80bCn4yTbCDRZqCBbFceQTYk4imyCfvwjB BMqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355116; x=1738959916; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59JJI4CO0oacXanEEbv/QOEs28IMbairlUQePRWumA8=; b=aSOLVx1CRMz/kFB9KRBzkZQAxFQLAy9I7OQJa+ycIdhBxXN6cxgwS4q6TZssaUaeyc eOQz1ctmWI34++E83xZvgvfHfOpYVP5SQV5+RIWzLtIoJyu5YDJyFd86l4WU5+lPJPDq 700ajBZZimAY0FIGN+9eo4fLiY1hDu9S2I1gXQg9QuPdKW9D4tLm0tCtaeJo1UNdjNy1 /2pkgUzNJ2l5rhLFxfapaGco4ZDAqMYL3y6jrEHbQQB17DaFZlY3An1BGx9W0AUleJVZ 3gOhx4RVpi3rKDCAyRACMWtmxpIbSROiQBTPTk4ln2mpmOc8eQiINARDFjOzMs6zsvux B3WA== X-Forwarded-Encrypted: i=1; AJvYcCVtq9pYxWFpjQpRmjxSV9ZdXMwoVoupy6zmlT44ry2spUtylze6BZhGY64crZrO/OHpF1/X+TCjIEo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+kF4f5H1Y6+t5mX9Xbdiu58paoD1KQu9h87gO1NkyO5t9kwOX n1UVHefIgPvfHVeJGLajfaADUqzi6xVohlawaR+0otW3qIYAJMRF8y+8Q3xVWDw= X-Gm-Gg: ASbGncvbrKXuQpaqy/HG591qkghp2jArvNdOU0fWlW4IKBnvbu9ZYkCcUCMqqyLK/3O HKcFdxIrJBseTZChKKL3J+6nc6O/vr3mKw1hSmPFXsn7B6qWgERVi1zAJQNHet9LE4dsaZE8BiI Z6ngoDOch4hp/bBCczWNZdO1m7sbGd6pHC/EYtyiN6mq6CIRgjXD/9WNd8O36m3+Tj5vBi4fHN8 B4LWboDhw0k49F6CbTPNVLobp93L4aznnho0FIf6Vp1PQdtSmjjeIple7txzcPGK7EJqgSD+BvW aTFZAhaJBPkvzvsJ7Z4Wztt6um7pbF4suBsUaynQZNdWst4= X-Google-Smtp-Source: AGHT+IFrVMAfd3Y3wOZ0h4O9q45j+fMg4Vw3AAmlNZ9ZgYIq1KVZZxWHseA00ADe6a66eu+rR/ZJMg== X-Received: by 2002:a05:6830:6805:b0:71d:eb02:baed with SMTP id 46e09a7af769-72656774376mr9460293a34.8.1738355115546; Fri, 31 Jan 2025 12:25:15 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:14 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:51 -0600 Subject: [PATCH 11/13] net: mdio: mux-gpio: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-11-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-gpio.c index ef77bd1abae984e5b1e51315de39cae33e0d063d..d7eaeadde2873977606bdcb5821dba18aa4a578f 100644 --- a/drivers/net/mdio/mdio-mux-gpio.c +++ b/drivers/net/mdio/mdio-mux-gpio.c @@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int desired_child, values[0] = desired_child; - gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc, - s->gpios->info, values); + gpiods_set_array_value_cansleep(s->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955761 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88D431F8699 for ; Fri, 31 Jan 2025 20:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355120; cv=none; b=ExzOcFxFlOQK79IjdypIwlckmN9krFdyqmZW6an1i5eweJRGBZyeor+8+ELcobIA/1YzgqN/+ei4PCY9soC4hlmUQiaUMAII4wBO6emst44dhp1AJWow6fTIpcAkOMqOUyDNPbjLlSJQO0JuoAVk3qC4TUhHLhBp5CjBZkL19Jc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355120; c=relaxed/simple; bh=rmBWKBYHCI+WuV2jjWYGUn7c5T236U0xlpQEPpz0oeY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oWjerb7oBRIoEbIImcgW3GmSxK8FRTExUyi1VXV5l53CBgwMTrMZsmOHfS9s1dDEc5Dc/FnOmH7dHVnQOlWBlQEmIMBGCBkK6vpCo6o0oA+/YqehD4NNmS7NhhP79Ezd/F/JTtJX0Yu4gVQ8R6dposJVmPaWDzIM+8dwhyATNE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=s6wxqIkH; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="s6wxqIkH" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-2adc2b6837eso662331fac.1 for ; Fri, 31 Jan 2025 12:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355117; x=1738959917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FzzIwzQtyYUR99JIrJ6how8p6bj9KukV10X1RHN4Hv8=; b=s6wxqIkH1D9BN7+dFKiVfTcWWUarvgFPerBjQBy2NCE81v48dt3r66cfJ5wtOQ/LiT PzJg2f0V1gkwEImOdpkVpgU8AM/RLxz5Yp8VdZT+gXb7II+fyULczC9ffD4/Rq0p+WEr X5lbmVf3N1WdV+WTfAOiA1ZdqYc8frmtJxKxmU/7Hv1rDXeiNfReGh2nl7dvUtOYPfrW QpIB/BIY4NB7jyxCkAPzlo0R+x8sTudxVaSVqlzpwMi0EpHUtGcDJVqkDoP4UGtxYXRg Q07OAtIcAT8tRFMvvVrQ60DJmzpBTFdHI8Q5YjebwR34OUPgteE5yDJftgmc9pUg+HwJ Tigw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355117; x=1738959917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FzzIwzQtyYUR99JIrJ6how8p6bj9KukV10X1RHN4Hv8=; b=I237F841z+EmVgVHaSlIRdOx5TzoWgfalXvzwlCK1b1z14D5srbb0I7QuVOBsl6XoL BlcTga8goQ0r7a8EoYWeaKVabC+IDRWspt0nUNUuWIj31jWGcZ0QbxB7E2I1xG0AGrmq j+VjugUUMo5HFIi5CxePummDMTxbub4hf/axN3M7BMg8twIYE34h0yGN84anqiALl6Nb KUE5cfKRz4zoIzPG5I/MaQIC0k+vspml3GRcuLcS2+9hqjt2qwq5wlO+QJL8q/XG6mIt 1jR5eno6qZesl2z1G0XsxTj/uMED4o8Ka/JBQQiMSSO9WR6DtwN7zVwp3k3nYKeUFdBv pdVw== X-Forwarded-Encrypted: i=1; AJvYcCWMY4rF8Y169S1hsPgwF31eICs8W4pirtuHRw2NlUhVPBjGnc0/28MjsXHNSCaaLzqeehE3cQebd/8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2cFU/5jjRx0xfEpWjv+CJQ8o6US2ZTonJotz/IiDqO56/XDcm GWT5x37cvVtbjlv89Un3WPs7Q3Sf9CTGl/0H5b9BavDSxDItrdHbHQs7TZMaaSk= X-Gm-Gg: ASbGncuBkuYv2K3xxm0A9dTbxupjgV2rwXF0RLkGYvx0O6V+QE3k+NQQLjA7y1+srCO CrfayRjROW69l0tkxfxvEqQX9lZlOA7hRxbL6kdVZ/gxdUWtmlBzuaElSnLP8Goo5YMzNf15kUk zDi0DNBlSL4rVZ85439N4RTGsnfS1qMiud4W/a9aZSIyyMhcdY9aEa4JEJhsvRlqh5o8seIKrUi ZB96kLrL1tBgv2rm5x+Pvt3WBedMga/6HKK1u3e5+yi7IQGvu2+r+pfG7m+B+vGK/5wLwBOMwU2 6SdfRABh1BkawGXCpIKio/I4PfHsevSemGdMRNMw2yuctTM= X-Google-Smtp-Source: AGHT+IERsKIHS0RESeT1aGghrd2e2VbJU3Jew/L2qRirwk6axnCtq0WNFwypLdr9E1c9DhZObl9GKw== X-Received: by 2002:a05:6870:32cf:b0:29e:255e:9551 with SMTP id 586e51a60fabf-2b32ef5a830mr8108456fac.2.1738355117684; Fri, 31 Jan 2025 12:25:17 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:17 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:52 -0600 Subject: [PATCH 12/13] phy: mapphone-mdm6600: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-12-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Signed-off-by: David Lechner --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..8243bab6ac3af2ee1394ef743aaad12a19c8ae36 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) values[0] = val; - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiods_set_array_value_cansleep(ddata->cmd_gpios, values); } /** From patchwork Fri Jan 31 20:24:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955762 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5B481F892B for ; Fri, 31 Jan 2025 20:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355122; cv=none; b=VFxnL1/N+hW2Mhivz7eFSPGwADVJW0eSmg7aKYE2ccH6/drHPy4oJI5suhkOQMGGQccQ4mLU6kHBshAej/nn1ZdVuDs27WhhrGNvmIJmAY74VHyT9lUh3bNVfMV6qoq/vy6taEvoUwmabw/UeBvJTzYxf41t0TGFOCzLzZEqhoY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355122; c=relaxed/simple; bh=Q5q1Cf62xGuA/zV0+TKjafPv8tjFCx47ZmXmvjB7zzM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=htJ5QfJjj6a/lheL+QYYTNsPQ5Yir5Zb7e6O2aYXsCVSl1FPm1S83GHCE0hAFM3etmU6IPHgBxjhSc3IWqnYOY4NbRkTu39pwDbc3lXOZbp0gFGXnZjoLDTEtEVau1qr241vuWzjSRlsXw0fL3YNyiCtQflw8rJKZdwRGAVaTO4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=FbeReIqM; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="FbeReIqM" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-71e2bc5b90fso1331510a34.0 for ; Fri, 31 Jan 2025 12:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355120; x=1738959920; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t9cxGVlfrmOEOQA8LocUnneYPfclUeeeatGnfm6leQU=; b=FbeReIqMO8vnYpLBMq/tCQ0Wzeek2MVG2PLNB7Yw48XmSR91lLUE85YYll47wHcuEu KycvhEOn+wigv6T6KB/XPC6dioLkMKuCOjMedEl4BodAinW7aFP4eqPQQ99l0fu3cWaq gL2G84kObRY7oQq7XO76+72cpJntOeMqOKS/xffF+kT00xJqHKfs15kGwTrKa/ctI3TQ 77d0pr/L9NTJqbNgESKgZy83jyDmvTaegIUUhESKXVJFQSNXL4ADZVNr2ACMFqyVI1q7 uISHy0u6AS8n/eTyhSwV2M7LS93hU2/mUq2Kkd/UVI0onUxYS/iy/TL1dPzrw+s0oVxw cz3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355120; x=1738959920; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t9cxGVlfrmOEOQA8LocUnneYPfclUeeeatGnfm6leQU=; b=IEk27en6aNMWYfsYeQaqhYXGDVxkORpEU3Y+HuUo8sgOqW0QepmPyPXzdcwzyowQTV 0eCQuRmXjQddTU6RDsua2zSHDvUxihfvVtLaSuuQ1WykkQ2mn/3uH+7vu3WSuB45jVcK zW73aziAKUS5ZZ98xDM4t5gsqryZ6KWtB2ZZHxRKjvEVlWGjdHuSO3KtLD3URPvxNpPi OnJpcLG/1kWlEBzzsBFQSPGhAA4t3r7WDZKSZeaZVXR1pWDlQnII63wHsUjw+TG6w+CJ 25i7TZZyay5guoqVJL9GxrmduVtsc4liFy2o2uztLqalEqjftNM/AkRUvZYBZJ1FDMKp 6JDg== X-Forwarded-Encrypted: i=1; AJvYcCV0eCTWMCqV7/Gu/5PqeJN/aVGWH9G38KcPm81whiG5eetXxoTVZmcxEKSHn2oI9kdWhiI3Z4cQA1A=@vger.kernel.org X-Gm-Message-State: AOJu0Ywr+Ih2uEDXvW4jmPonPO7CW55Kz6YcyMNxctdPQRWl1TJpMPKY 87cXy7Om0tBwd//jmIZyKw2zNsHwfQzHZFOA/5FPfJ4Nld0oSYRxEj+VqrbRWqs= X-Gm-Gg: ASbGncvR0vzS5ZnydAIl7NiwG0V4A4JBVhDPrTE95oaGOx5essx7suqq4UXhqqsQVaT D8BPkvsLY3DXifc1kIh7CpdHEf1kyQ+ACSmh/R4vPb4DdEDIHQvVN/nLEJ8r1Pu5EdyTS4FHpMV G3eFk7+cR74XFHt8xgBMigQdXSKE21U6SI3+pdzrJX5oioVS6w1Hb+OTvroaHiMVGgrZXgoDul1 BNiK6Uh2fMqD50qOGZoWdQT+T4fq94qU/WTk4sbQsRHKO0JHUs4c2wM0gMz9c+2TDQSJT65zXrj L+EvyZ5XpS8OxJeUmN4cnNml4f5eaZyFZ0ulS4rlvg1Pe3g= X-Google-Smtp-Source: AGHT+IGqg3uaTvNfsfu96auAGMNqMTSmH6qy7PdoMmcZZ87lNXJHf3Cu8HBE7iXbpxe/5j7p/ZYumg== X-Received: by 2002:a05:6871:209:b0:29e:20c4:222e with SMTP id 586e51a60fabf-2b32f2f8592mr8795453fac.34.1738355119837; Fri, 31 Jan 2025 12:25:19 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:18 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:53 -0600 Subject: [PATCH 13/13] ASoC: adau1701: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-13-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Mark Brown --- sound/soc/codecs/adau1701.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 291249e0a2a32df7dde81904dce2f6be143fc2d7..d3e6b2763950f78143c0feb07c36764cb265441a 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -325,9 +325,7 @@ static int adau1701_reset(struct snd_soc_component *component, unsigned int clkd __assign_bit(1, values, 1); break; } - gpiod_set_array_value_cansleep(adau1701->gpio_pll_mode->ndescs, - adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info, - values); + gpiods_set_array_value_cansleep(adau1701->gpio_pll_mode, values); } adau1701->pll_clkdiv = clkdiv;