From patchwork Fri Jan 31 20:24:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955778 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D380C02194 for ; Fri, 31 Jan 2025 20:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IDGSRu9+RarSXbLVuqOmfI3R8pbpfvZ7S0T//JcGGLQ=; b=FCcLnLjdJwHoL0 X3sEsBLq11jT1JEgKiZW0bI8TwB35Y6V9KWfZcTfplJGUgvIM28DxgHqdnki4T7pAQ8lS2lQOYOtP Gd+2nih2xgl7D4I62pUiWawz0vs/2zSGowq8/MVfATYugAVHoPKuD3WpCcGABzaTkDnLduQzFs7+t 3SVGstlfKdEZCwQjRY8Qd1RME2vwHG4UX3aB2luIw6vzCo/7lK7f83txQJBK3YE7JytsogHeSdyVj wyvdB8ezjU5/xdkpwvMhGw3Ku8rpSusdigcLWRaTP8XbdyhstHFpeYmiz2oCvLDYMFBTG5Y3Wi++7 OomzDN2wh1b5p8qNpUDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZM-0000000BMlh-3eMP; Fri, 31 Jan 2025 20:24:52 +0000 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZJ-0000000BMki-2Xhr for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:24:50 +0000 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-2addd5053c0so1229759fac.1 for ; Fri, 31 Jan 2025 12:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355088; x=1738959888; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VExoELcV8x0LQmV6C7xp1BlVeCvht+mgfIMccHi3FPY=; b=m59P7CGskUwOWcpfrHSTeMSnGSSuiKFnR1vmCw3GjarFD9fOZY707wt+N3p/lYNi+a +BN5JE62g0uXR8N+oCmWcbJdR9ERpkExiq2BWV5XLyL0IR3BLuQq9TKWyJwRSY1RWguD PNfjjVpDmTCiFpTN+rW39YwPfOrGDuwvPiMAFR34LkgdTxw6SRqdEYeUkp0H2iOmCJWP 4wnx3o6/RPlq8q3QcAJdFBCYwLjsF54AQlUDwOR+C87wf2ARwlbsvXmNip571jqMlXe2 29it+KvY8bdpLRF3f3XONXp4/heXbAYG+Y1NdTEJIi++8GN8tOskE8PWFdovnuwoLKKh c+sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355088; x=1738959888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VExoELcV8x0LQmV6C7xp1BlVeCvht+mgfIMccHi3FPY=; b=kB9k7y3WWFVpRJz3+vKa+8WsXCMxaxj0XDvNCUHneab1C153kUaqfWgmLKpf8YASyB OVs4DebiMur5GQ+QnvamDwGfMzGAPw3X2P4eMNGeoRWMHKbU/YJy5A3UpYlcr98J2rkU GcCXIfRhuXvS2dXz0Gz1P5eq5+wISkrAUp6G2rwm5SX+br13zZjFPM6Dn0UcIZZ0tL25 9q7m65H+ZfBcbwlnMTzq/luUcGklhQYdAuPHWKxS5jHN8zqJdcwcAukpk0ELUG8UBYJy S9P/TgG3jAtUsIZkotB/QFUnAg/hWdj+KKCDmL5FMHTpShNcLqgZnptHfnrky8/weTJU 9n5w== X-Forwarded-Encrypted: i=1; AJvYcCUCpWeGFh8FEa+ZMn8Eu3hmXP89kNHDSdvFbKBURwBMb+1P2ImRUKrEaIGDSUUCBsbSbytwSWhwM2M=@lists.infradead.org X-Gm-Message-State: AOJu0YxWJCBw2iaI4TNKefYsIX52PLAPJ5aHkXUxy82YJNMTmoNgXz0x mQG0RKwa0NtEmUQthVxM54xGIsFBWT32trt0bjAj+CWN8g1GEaul/AaugNbMTrU= X-Gm-Gg: ASbGncsXoaW8cDNvybEh1JFYSw0qYFAP9VVGTjF606p1Aa8LBrOLzLrFBu97K2oppQf o6XKAqbYs1+GjXtGp6JFvgUvHgxcug/RvCEIqpAHV5AuSS+8dI0O541/Xw6RXLEgsJXE94o+Xs8 Vyg6MVbnTlmyBXZeyVpKsC7GTEficqfHWS97IlsuxUOlQHNmPtgnWaoCFYGY4kf0yhKnq7F5Raw M+2gruUbfNZWDjpH4SjQS6n2ICi+3PTiS1zwAOT1Cwvhoy6Nj1mb3zN6ckbVL5CJJ0pO5t0HzcZ T9qm9i61INt1QSRRblHvrOBWnRcYhhkWo1sIGOgUNaJ8qzo= X-Google-Smtp-Source: AGHT+IG48amD1C5d4QahkI7FJNfsOoMi2CtgfNG8+gnzn0CcyJBNzM/PkTQMiDNqV/T79ZK3cKZLjg== X-Received: by 2002:a05:6871:a012:b0:29e:5297:a2a7 with SMTP id 586e51a60fabf-2b32f3ca389mr8811438fac.30.1738355088436; Fri, 31 Jan 2025 12:24:48 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:47 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:41 -0600 Subject: [PATCH 01/13] gpiolib: add gpiods_set_array_value_cansleep() MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-1-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122449_647050_2EA0A359 X-CRM114-Status: GOOD ( 10.83 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add a new gpiods_set_array_value_cansleep() helper function with fewer parameters than gpiod_set_array_value_cansleep(). Calling gpiod_set_array_value_cansleep() can get quite verbose. In many cases, the first arguments all come from the same struct gpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate. Signed-off-by: David Lechner --- include/linux/gpio/consumer.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index db2dfbae8edbd12059826183b1c0f73c7a58ff40..1c9bb3cb1ee80fe52aabf5bd24b1d128eff2bc99 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -655,4 +655,11 @@ static inline void gpiod_unexport(struct gpio_desc *desc) #endif /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */ +static inline int gpiods_set_array_value_cansleep(struct gpio_descs *descs, + unsigned long *value_bitmap) +{ + return gpiod_set_array_value_cansleep(descs->ndescs, descs->desc, + descs->info, value_bitmap); +} + #endif From patchwork Fri Jan 31 20:24:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955779 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A503C0218F for ; Fri, 31 Jan 2025 20:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gbLxD5I2T6u2xxBDI/v8uoOeSQWAkFGH7VykRqyWDSE=; b=iPeml7979tkYIT mjsbfutbOV5smhukKnEjLp2h/SkUtLAK5HAJ7McFsaXyMPSjx5arunThAhhKmUnmvSdidhOJaaDKT xipqKD1qvfq4W5zLTKE/3JdRVxfVQ7/BCYcJcBKnMd6lLjMq8M/JOjeEvMfSRqLvnwF2Spw7E30K8 uv/e+CS5Uq6nI37eiSDFwxIX/055AKlePTyjpiFbYSi6a1Q0PO/F8L1rkTBCNjvDJb7R2xashLaHH +i2UMTNxB44EoMFVceKKrxUcHVH6XR5tEaWCiZaQ5cXQEUmjcxE80jm6fxruHzxD2DNAk9FjIOCYa eUpTcpAl8fd0MQ8EH4uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZP-0000000BMmg-0XMw; Fri, 31 Jan 2025 20:24:55 +0000 Received: from mail-oo1-xc35.google.com ([2607:f8b0:4864:20::c35]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZM-0000000BMlO-29tL for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:24:53 +0000 Received: by mail-oo1-xc35.google.com with SMTP id 006d021491bc7-5f31b3db5ecso1003678eaf.0 for ; Fri, 31 Jan 2025 12:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355091; x=1738959891; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8Y1Uq2vC9ngxtabj+o6Gf/0MmnPKx34MFqyZVe1ZJHY=; b=yMLNTYQazZarCdflcvMcn1spbSPYZpZDnKp8DT7A1S0bggj3EHG/l+3oxmYPgz0Mo1 Xv3kkQC5auac8E0q0p10+U1Ik/a+7Bev38qy4E1EUGAZkZDEvzqD0GsxV3YwIysPJ/iy l8ehAbQxzkpG3mHVGtKqCD/XFLnuUPw2UC8xDUtiBnQehADPL1oaUfm6YAhfSK2CTl+d H3pGj45gRM3P+eWqAH28ood8zKSBExcJ0Sd1HG4FG2SMlckcuUqNVYL4U/1neVzTI0mZ ZImUzAWK/B132+TJhHCMD9Jxz/PghfZtasthuGlf2ftGQFn2ozvb1Ad9ZGCLPzJN0HzG yQvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355091; x=1738959891; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Y1Uq2vC9ngxtabj+o6Gf/0MmnPKx34MFqyZVe1ZJHY=; b=Fhh87sc9EbdndyNSavltzvez6X4r0ovofJj1uTyM/A6DnkvRxgs3A8psdoOd9w0STW wr3CWQ2YeZZSIhOSFrbRYKZWJwG8QnALy5II4gn1y9mYCJzkq97Z9IWNz/Qrt1owrSxj 2vsjmbNg8K81rhK1TYmjw8KeVxIbKtayaHuY+oEggIONyE7RDWE488Ya5DIp8L/BWi2Q TLiVYeg/4RxZ0AjTzmhjwgTL4lb5wpI6SBt3DaZG8CxSYYmmyOSnioVwjXOsle80ymld cZRe8UE9MfjgiyVNmskIhdBRt/fBJYs3Aqpu7R5wTJ8QXXPjsXBSHPItBkJrzpDgTmO7 zS/g== X-Forwarded-Encrypted: i=1; AJvYcCWDTmNKRecDUNGYgU8CBKaYdAMJVPNj4ks4GK9IDvyMG6XFh7FCS5YMwcYqYjGc5onWVGkVpS2ovJM=@lists.infradead.org X-Gm-Message-State: AOJu0YyMXeHM4xVhdCsRFZNWk7dVHUz21QNKP30YTN0o3lgb1rsn09uZ R57YYXIjll2qSnJMX5bC7VzSRRMv9DYEqu+tukAbd7Z4ZOrkWA9TAvMph4+Z2d4= X-Gm-Gg: ASbGncv8LldBJ1EeTOt84MMfSDUQytOTBUqA4+VyQcwzBNlTjf0E5cKnFV94V5Zs1Pg vG79jZ1YGubjArap1AoTclZw1AxDMKz5sIsD8z5JBjflOF3yL0JJnSamqVJLLT8Y+ma+mhXWhPj fYbSvdIUHQICXNyfrhR9GJKsIyQWLtBbBDiq3DLExfZ+Np8hVS3XwmlZoLg7NbYJQ1ms3cAYygN K4As3KbtMhWHfz+bACVi7eMLV6RQ0Tz+StoQX71a4+ACHAuM+zlfGb7GdO+52daTA3qKyh85Ok5 r8xIkNy9z555NExcnmOYtutZw0hAtM5qR0f9mEEtAp3WRYw= X-Google-Smtp-Source: AGHT+IHpL9OiC+7p99DGjWrddY5GvJC4qVZT5ABdvIbOzG8MeWG3IwFdHaR/KYiBNOSR8xIQZbb8jw== X-Received: by 2002:a05:6870:ff46:b0:29f:ecfc:32df with SMTP id 586e51a60fabf-2b32f02152dmr8447581fac.14.1738355091503; Fri, 31 Jan 2025 12:24:51 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:50 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:42 -0600 Subject: [PATCH 02/13] auxdisplay: seg-led-gpio: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-2-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122452_558574_0CCB151E X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Andy Shevchenko --- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c index f10c25e6bf126cfaac3e4c353f8bfc6639d94a60..c158b2c2827415e75d0b122914b8b18c043e8c76 100644 --- a/drivers/auxdisplay/seg-led-gpio.c +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work) bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), 0); - gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment_gpios->desc, - priv->segment_gpios->info, values); + gpiods_set_array_value_cansleep(priv->segment_gpios, values); } static int seg_led_linedisp_get_map_type(struct linedisp *linedisp) From patchwork Fri Jan 31 20:24:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E7DAC02194 for ; Fri, 31 Jan 2025 20:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PmIvRCvcDF3Dj2KR2kPGhjP3It2QNcHK0RksTxjF7Jg=; b=0Lcw4BS4JocL8n U6HEU8wFzOVch5Jgh1NVr9qWO33VmmhpcpuBla5xkgoFLqm5W8GVsplB+IUqax9yHxzjHABRBIUkb FWFea8uOTgoryhjwhJD5F0/o1S1JKrjDgo68/CvKsSfX+eG3cf53afc8xsh+xNv69wW1kdNydiWPc PGWwdKqgzAdr8fWNt5Ev+F4y2XI3KoqKkGuVzuLSCx+5sAiHT6kdyOwqcj8Xh2ELKftQvF1eYLulH wxfVRPnnUSvRtpMY8PFIWTeFXjmRWyn6oZg2t8441Jk7dFE5djkxjV/dxxvOMRW5ibRw3VZJMJ9AA 7/1SbbJEbwim0N6ogT3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZR-0000000BMnV-1dQT; Fri, 31 Jan 2025 20:24:57 +0000 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZO-0000000BMmL-2of8 for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:24:55 +0000 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-2b3680e548aso934577fac.0 for ; Fri, 31 Jan 2025 12:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355093; x=1738959893; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=g/d91jflGtqcHyVEIBk6nu4SgcmlMkVjeTIYU/X9iWg=; b=ddm2W9tv5xODMVMC0qOScLFeckihXN0rhxzK0GrQprH/j5qpeDyVgjJ4dk5x+s9OHf oSLcgpRw3phxMHzx6PCFdE5X2jmqMtAFfa+XvEWllCjZtnmUuGeqjgNiS7jro4c9j/Mt XVeRqmNEi164x8zT8KP/UyKnm7gh4U2fkCPrwmIaRtgoJV1UOjE3+A0vTjqz4j4PRe5b ovgBr7x+xCitOIdA67heDXfTAgRunOptj9YrmBzaOZe3x1PNepwC3FkDcdLIPO2UHOK9 XKxzl0Cn84EG4kWrnb2cIur2+w23CDepvuyL7ZH2iUHvaOgFRPcRFzeZ8PdovLjmIqd/ bLPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355093; x=1738959893; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g/d91jflGtqcHyVEIBk6nu4SgcmlMkVjeTIYU/X9iWg=; b=T6b9S5hIhvXkjAp+oZ88+lriZpHjBizlvtoMxdw5QbtrPU8qGiLgyFdXIZqvWs6Q5/ X1BA6j52ksjoOJzryXvuFlYOaQgDrxMwgmvUFJGrDshjC61xHovH7KSFUQMWbVTQa3jC WV8Z2e9OjBixtXYqLacajRhxuJXXm4kP53Ut5vVDp10HFVcj7/AxlRNg7ZGqzDFVOPHt BbpHL7S7L+A6x9zKR6nRLQY2/IVL4uuehbvcoEAJeXWoJeX9PF4eOwiKCpk8DKRxU0mH CckkREKnsuSHOUofBMAgcnLGzdHxMZtjAke+KVFkHtR1cjG92cQ9lFu+djSwlNtXGmS3 OiKQ== X-Forwarded-Encrypted: i=1; AJvYcCVW4E09/QnsCA50qEd9YAfLQPfUlphY55Z2ENyZeE0Ypmz8h8hyqFsQ9JGzejhtoAE7+DL084lhLhA=@lists.infradead.org X-Gm-Message-State: AOJu0YypWCCGEWPpKfukPhElBG/KFLZWjOSOUMRF+J4PZ1V8qoTIyhZ6 cDnA3MMpl7u9g9G/O1OXO4oH1pzIrUY99bzg/NA0FS8MsFSa1ahE1x6A1XJdQV8= X-Gm-Gg: ASbGnctFJmrx+bu0g+7tyf4gVhnGsr55nelJVDrQLQP4LetbyRk3gBlRlK/Snan3YeB GMSG2cb566sxx8/wWKSrajehA09DDgnK7Os1ATMk/xb0kRiOlmMpsDTxVcuVEoHe2fNU/WVSxc8 KAAgv3BlJ2vShyoNgK5+Js1cUHVdAnAxduGpEoQhN6d4eC2vde7WuA3aofu9msW/TGzs7jO4Lzh IJuT/UpW08RDKBcn1ehIY/UABe627sN6l5P9YRLjCZkYKhcEoHC4IUZZ1unUmMp3r9a9Tql1EQM PO1kinitoKF2QdfVfQneCDnfyoPG2vh1Rh2ZnlY3ZoV90ws= X-Google-Smtp-Source: AGHT+IG7MwrRorXxkcWjIdgGK+4mzXkuq9AO0FFEdnZrk7oRmiSNnPUZ/DfqxHivj4lEixFczChGQg== X-Received: by 2002:a05:6870:d1d0:b0:2ae:d23:3c2d with SMTP id 586e51a60fabf-2b34fe99372mr8034579fac.8.1738355093684; Fri, 31 Jan 2025 12:24:53 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:52 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:43 -0600 Subject: [PATCH 03/13] bus: ts-nbus: validate ts,data-gpios array size MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-3-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122454_714233_4195771D X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pdev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); + if (ts_nbus->data->ndescs != 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn = devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), From patchwork Fri Jan 31 20:24:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25800C02193 for ; Fri, 31 Jan 2025 20:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Bcvelkj+I1J4grc7run702IUiG2TVqoZPJAoNrqgWI=; b=dplOaaFE9dE6Hu k7PgEXSKZS5l/kr8u8t6lpFZOf2k/Ov7UvYoQBwSM/KpETONO0VGftfRZzojsFbU8XLUXKGljeGv+ wU9lXh9H2Bv/+7aynANai1qR8iIpnC5JYkTJE9116FVLw+xWsdLfxxR8Rf3VMR3BjqDPyaBL+v7eF cJO22EPigB0IPapWzE/PQn1iuN04cbFkruPXYgFf8OOebQARz3U5SOOsZyRskskUUotsrweuQjlh/ wBy34/1H3j82onibgvsBCD/sMGAK/oUlexId4Kpn+46HXqTldA5GexBqfvV4f2Es3DVC0T8MmM7kf ylPF7z/povjiWN+lyqnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZT-0000000BMos-3g79; Fri, 31 Jan 2025 20:24:59 +0000 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZR-0000000BMnP-38ma for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:24:58 +0000 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-2b33aabfe46so985964fac.2 for ; Fri, 31 Jan 2025 12:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355097; x=1738959897; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9hlyYXLAXkselsSNF7g0Bc64z/LNWZ956QqcL4gqDjo=; b=b3GeYaL8DHgesZdm7Mol5ConxyOUy8cMEq9o95CJj1V3i2Mgv+Dg34cnvDOZv/wnE3 VvyJi5fV/irCmPo28A64ltJs/MWCOkUQHR4P9UB2Xlka2/Sf5YPMp6jgu1LK8sYhEmty cqY37lktU285WzJjoAR48B3XtmkArGKD6jCRqvZJZU+qwLTC4hDgJxCJG2sXTJKYXn+A O0QaySQ4sLBv7rclWR+jSXy1XAbDOiJnoSWPyMT7omZ3bwI8xTy1HrMFwJSf2DhJvxGk H79y4F1Rbo9LKRP+tYl9WcJbMvwcOsC72bAcYzv5xmbChwoLcgi+CBXwoFfmsYHEc4zf 6dbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355097; x=1738959897; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9hlyYXLAXkselsSNF7g0Bc64z/LNWZ956QqcL4gqDjo=; b=GYSB1dic5+syPqaF4BhGhn43h0z/6kJjrAN/Bv7nzsbRpw9RCQmXSzXpwnRtS+DxVn zCxhLFSwT44/aSoldIzSEt659yOiNUu4iSaHzwqmASguOnBdmIskZYKVYDFbCMuHbdyV jM6wptdY4wPne6mU9xn5UYpr2RSxiMR4WpT1JruTUe5bldd5XoBPqiAM61buaBHfexBX rpLz96Of9Aly641Dnm7/M/JvXBJanTZeLXKmsLTv/bq8o54s3Au8vdjSKZ4d5tSYtti/ XRjOIQejLCSvervs1PBzFanOiNaL2FAZZRaZ/xdMskYYosezg36gWIPRj4TEEm6zQZ1i fLGg== X-Forwarded-Encrypted: i=1; AJvYcCVNWyXyLW1C6qJslXxFI8eCan8DNR2K8/WRp4YqQyNQ9fgpbMrYYn89XcLV8bQHZsle+p+NyYX8cM0=@lists.infradead.org X-Gm-Message-State: AOJu0YwEJ/9mCFn+vThf33DjM+MaaKt/kDFhoeLL3GH/m6zknOiCllaX RpsGYzUJwsjbKtfqoCTV/XMy5gWbg5Q7GzG0CU9ajR2G4Y57OwzSyM4PIJLaRZA= X-Gm-Gg: ASbGncvVm0VEoGKbAz+0FilDbCNt8bLBGLI2EXc1KqKM0m4vvnlX+YYF1Cc0K9jgG0i NeXf91zCr3IQXEXpLyb03PgzckGwrGm7uPsJaYePocQKCNSnssb0C0Acqv9qoHpLlxvbnf606D3 vF9G0kJH/4D2ikVPRAyggQjH2Z+jdrz4XjSR+sSpNMWpwREt/7PkuQFpcjeW4zdEXVNL8wVPvSH EbvHq3yjRB87X1jOupBMJWzYx5BI5liFi+4d3Y7IbJeIcqLKaxwiupkRVyyUrrKy5xUr7HWMehW Fp//fqgxiGnSe69AFYUaLZtodHIkW52pA1gR+R7aCLBecm8= X-Google-Smtp-Source: AGHT+IG22JJZ1zoEE08gl8CxgOf30mezmJIUs5PEqf+3dMT59zSIuFvgdvLgZxy1Rl/Rs71gFur6Bg== X-Received: by 2002:a05:6870:2dcb:b0:29e:6647:1080 with SMTP id 586e51a60fabf-2b32f07b26bmr7733897fac.21.1738355096771; Fri, 31 Jan 2025 12:24:56 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:55 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:44 -0600 Subject: [PATCH 04/13] bus: ts-nbus: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-4-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122457_791303_9FB9C5C4 X-CRM114-Status: GOOD ( 11.13 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..31ae9a26257c3e0af2ba99666e0c04e882da935b 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) values[0] = 0; - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiods_set_array_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios = ts_nbus->data; DECLARE_BITMAP(values, 8); values[0] = byte; - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiods_set_array_value_cansleep(ts_nbus->data, values); } /* From patchwork Fri Jan 31 20:24:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60173C0218F for ; Fri, 31 Jan 2025 20:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hwkilRbVevIlUbaRORBwC03/GUh10dSJZqfM7wmjLuI=; b=cw0UWDlTZz7FZz 6m7/shSuiP8u3pRYleWmUKE4xpnfAwpoEylR6VL5opQ9kSiQ2EbqiMEfe7mNy2lM15xF2uy8TL5ca ijDd71jGDKYG6J2jhtJU79MLjZQWglid5S2jb+yccNTSwVpN8PdZ1uX6NPU+NwG7ykEMEib7vbX+6 xxbVhWiBwyQLyV0NWOAMhbqHSwvocGXT8EVZYE2DitgzyKGcTIvhfjGfiM0z9zRZ3SRn1d//V4/wj IMY2R5As0N8P90TRz6NnIP7xMS3XuUT1jHVDi6pX+MPTpXp933RJ/6xPfjTDsCL134TvEhGBvTqBy tEh47bgafxyyq2F2r8ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZW-0000000BMpn-0bJX; Fri, 31 Jan 2025 20:25:02 +0000 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZT-0000000BMoU-2sav for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:00 +0000 Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-7231e2ac9e4so637129a34.0 for ; Fri, 31 Jan 2025 12:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355099; x=1738959899; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o0JxocTLtlGRqW6c379kuZnM3hX6Je635Dhf0CbFSJY=; b=nwJGS1TbDUc04Tw5kpTNhNWGuVbCFYrCFfi0JrcUr6zgOcS4LPu3Gty96ekl1bv3BP LnSKv7zqCVEyHaidXWyn81ZMJyCmuVPCHDZgAKr1ffachZqoyN/zj2Z8QU4EJ4NR/i5J WR+Hflxf08R29n9CIGYcy4ayPIugWooD3mcxUXN/Lhylzwg0Po3YEmC9vdpbdgQ+XlEo Vs/NIlkkRh7SZzanoxRJafEBWrgqVSB8DqIt5Fro7fp0/+mvJ+ZnUHmHjke8JCe0V5VN 4rxc0Sb3c1Hd/N7eBlDaoUzZJf703GRUTiSlx0wjUDYd0lPIjWsLwFcjprZ+2ChXOzAW WKTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355099; x=1738959899; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o0JxocTLtlGRqW6c379kuZnM3hX6Je635Dhf0CbFSJY=; b=HdUGbeuRGkbNc2ek4LTmA5RO/GgPisANZeXdhRCBsjMz97ikXGa+OXsUCyTMYpD0K8 SdbdtJJryvwZbopi0TzsmlHvEIt8ni5Y0tApwf4Y5WGc4umPUMdX8t+qqG7jNLkj88CD 3bfN4pLC3GcalsMKGxk7CFiS4I9d6B3mCc1wDQ5IMPHa2ofaTgB9XjZWKGgBQ6PrydTr gU9X9N3+yqjX3hH9Zc/FD3c2DXa4jRMn5MUiSUw45lgbem1+w5kiAbiv8koZJ5vuLEr7 huwa0fhsVPpv1bPs7ymV2Xd0mRgubeQghoLHIpluTTf/EmefI7WhMuhLvh0G/j/hTcMW mO1Q== X-Forwarded-Encrypted: i=1; AJvYcCVJ1TM4PwgKv4Lom8d+cv29cenQ/WXRUGG6EuIFdSsCYRDLfgYRtOma0Ad5pjHZwEgIlSaHZquTFLs=@lists.infradead.org X-Gm-Message-State: AOJu0Yw1GjZPm568WxFC5J0CEKrvJYcd/NARAc+LB/NSjyFH5CnMVXsT 6468OPb9cx/9xEibUAqZm5cfSngJHQrggmW/DCJf54VLW95V1suSZW9LxoCd2i8= X-Gm-Gg: ASbGnctqDxERgJMu5nCjtUjbWA6bovlsRIlgpYhVq10uTRxWJ2iOFYuUut3q6Wblnqc 93VdSlzdlV5LaHTpLOhhLgjjPMUajbOgiDfu9hjBPLjyoa+Pby1k3UyBT0iXv0t3UJD6W6nmjlu 14xgJmOUvcYAM4qllysb8wr3EoNJ0De5QGKCuTgPwztbNFo/vhampT/jXni/xyTO1hOEseNLbov sDBu+o4Nl2OR3ESYHM9F9ldwcB/Sz9Ndn4ZVXfwasp5YBODIaEjo9hUMJ4Zd9UULCHkH7Zscnq3 3NXW+VmsNqc5kKRS+JfMUstekXK2j9C72VpOk4m2cjbBBEQ= X-Google-Smtp-Source: AGHT+IHLLvw8v92D1IAdlvToO2DW44SjM8+FGXyX2n6gPI7BbY77buvq2CWQaGC5P0PVhdqadGjO1Q== X-Received: by 2002:a05:6870:948e:b0:296:beb3:aa40 with SMTP id 586e51a60fabf-2b32f350834mr9144614fac.36.1738355098867; Fri, 31 Jan 2025 12:24:58 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:57 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:45 -0600 Subject: [PATCH 05/13] gpio: max3191x: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-5-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122459_740149_DF768B2D X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index bbacc714632b70e672a3d8494636fbc40dfea8ec..fee8dd2bd3c9eb7c06817430634eaf905cc9cbd8 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -309,23 +309,21 @@ static int max3191x_set_config(struct gpio_chip *gpio, unsigned int offset, return 0; } -static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, - struct gpio_desc **desc, - struct gpio_array *info, +static void gpiod_set_array_single_value_cansleep(struct gpio_descs *descs, int value) { unsigned long *values; - values = bitmap_alloc(ndescs, GFP_KERNEL); + values = bitmap_alloc(descs->ndescs, GFP_KERNEL); if (!values) return; if (value) - bitmap_fill(values, ndescs); + bitmap_fill(values, descs->ndescs); else - bitmap_zero(values, ndescs); + bitmap_zero(values, descs->ndescs); - gpiod_set_array_value_cansleep(ndescs, desc, info, values); + gpiods_set_array_value_cansleep(descs, values); bitmap_free(values); } @@ -396,10 +394,8 @@ static int max3191x_probe(struct spi_device *spi) max3191x->mode = device_property_read_bool(dev, "maxim,modesel-8bit") ? STATUS_BYTE_DISABLED : STATUS_BYTE_ENABLED; if (max3191x->modesel_pins) - gpiod_set_array_single_value_cansleep( - max3191x->modesel_pins->ndescs, - max3191x->modesel_pins->desc, - max3191x->modesel_pins->info, max3191x->mode); + gpiod_set_array_single_value_cansleep(max3191x->modesel_pins, + max3191x->mode); max3191x->ignore_uv = device_property_read_bool(dev, "maxim,ignore-undervoltage"); From patchwork Fri Jan 31 20:24:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F765C0218F for ; Fri, 31 Jan 2025 20:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KEt6O+9h3Pa/CGMKjMV2YbU7Y2Wd6VmxrcLGMxE96/4=; b=VNREik9R1qqgXL BazVxdkNxFV0Szk+6PQoohrF12uqAaaF8O+fnto35YWbjf3TkMpKpm5o2Yw6niCCUhBZxharEmLkF AzjzAsSwG1gMwfSJTQrxdcHxfy0PBA29ebGUv2c5VZ4t5hW2uB097KiqChlbFJmfFPheIa3/yBfzA GkNlAqFHcJeEyvkIhlLbiVztkkaupX0ledBGGJx7ho0VSBMpNk0a7ouHvN+AUZcNWckzmwUSUXNZ+ yXNGLWrGyBjNSh66JAlTS2dY9zI1r28PWcqhAXym9QPz/DlArk2aAbLVBLK4viezKCiwT0Xi62O3s uZaqvS4ER4tSQHIhBrLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZZ-0000000BMrc-1hJv; Fri, 31 Jan 2025 20:25:05 +0000 Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZW-0000000BMpe-0NxI for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:03 +0000 Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-5f4ce54feb8so1270254eaf.3 for ; Fri, 31 Jan 2025 12:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355101; x=1738959901; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HLsz4+tHpjKqe9Yh2fzFcV0a8GzDcsWx5V/eyXI7CsY=; b=zcyMRgeC9XyNXkiLEuCg7daneuRNiYX7/iURcLLVGyJIYzzhBJN+QxHVbFyBo6MN3J dF/Vno1/hYLKDdQokgWZuje9gWA48iMm5m2FmXYGVF+6e6N/VHOm/5JNP5P8Xqk6TRGt eqdVtUJ2Qf7Lw+FJeJ3IukTPWtFWl+8tsrVVvXQUBv01Efo7SCarz2Uho9TiZe7zjPOH 2/oCrCQtRi3ibpxYQoH2RafguAHFEBfylxWXTwW+sbl7Xy1ARcr2XctfxaRk3wzxJEcj rtGZtq0KB2vpCNk7JIkQJrsR/0h6xT1t6F9rJZkZpHyd+NN4cNid9aPiJEhZDJ8yibl8 /PNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355101; x=1738959901; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HLsz4+tHpjKqe9Yh2fzFcV0a8GzDcsWx5V/eyXI7CsY=; b=po7Q8szhHbXvhbBGb4Ylic+8ODQl3bRCpKxWW9WOnXE46KnMxZxzWb91+kZmlR9OLC m7UjRnwTV9EPJGZsCn6DyRcBlQ5IYu/ybWn7l4sIadQwMV7EoSQsXIGBjQ4QpynWPe2J CYSOHqB65Z6dffGiqU3VZjtPeN2Yj2RPNHw/dCy9BMRLYPhExz7Pb/orxR7w785nFzV2 /UbO+hGlcFtbHXgFxX9XqnUeR6Kzz2E+w+q6Ng35VcgJu77LYvLNC5o7lYyHVOq+0gUa BXdZisNb845C/PBlF5ptwYHiTwH+PappABoLG/HZ+GrX7gu19DfJMOh9FcNbc1ozqAQ/ zpkw== X-Forwarded-Encrypted: i=1; AJvYcCUF4B0EuIFQmibzW6pKteBBY3+pDmoYREB7ptxLqzI1VdzKd84HdzO9dF6LeL4Mbvs7FjzmyJ3zFKs=@lists.infradead.org X-Gm-Message-State: AOJu0YwWLo+iltpxEphmM2pToIHxy0qx+2VIblHx8eSLazxV/5X0rr5a h0jyMptlAZmBL/AkxBUfS3rBnhxct8wu99dhVNtMVRECDkhaalfMiPH26LucwHI= X-Gm-Gg: ASbGnct6ky7+YTzL9NxZsVX6UHEg50/xlRPji9AcCbJ1/E9rk0/4v2KX0f6BtjEFXNT 6QIEMEpBUwFGvinChF3lPiPsc//6BzzPg0hyd+ICxPiAg4seK5AOICoQHo93CspFmjeSgKBoWJz 7l0ZHWBQpHjYnrMBaYM/RPnejqFr5zwwVicP3MIZCoMgJTNF1qerg6pepCaRV2lEyrTOE+stMNC 7nwPV7CrDwXJaUl52QuU7sEI3bd71yzM0g45uK5bImO65krD1e4adgcyItwA3HxwkU10k+EwxUo D+KP0VKK7iTRp5qqZtOWxqm5HZTMvZeWAOve58R0n1CC+Nk= X-Google-Smtp-Source: AGHT+IE0gOiKruiwKZS2fVv0rrPSXfEcYE6NWhi9xtJKoPa0qd12KXWlAvVzsWhUG+e0SGLuDExKGg== X-Received: by 2002:a05:6870:702a:b0:29e:6096:c25f with SMTP id 586e51a60fabf-2b32f0bbdf3mr8023505fac.23.1738355101014; Fri, 31 Jan 2025 12:25:01 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:59 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:46 -0600 Subject: [PATCH 06/13] iio: adc: ad7606: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-6-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122502_147986_C75E96BA X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Signed-off-by: David Lechner --- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d8e3c7a43678c57470a5118715637a68b39125c1..fe2216fd072e375f3dd8096980e53074f8ee3758 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val) values[0] = val & GENMASK(2, 0); - gpiod_set_array_value(st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); + gpiods_set_array_value_cansleep(st->gpio_os, values); /* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset) diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c index e2c1475257065c98bf8e2512bda921d6d88a3002..d3064e452adfbc40b44f4437e76a73aeeb036ef0 100644 --- a/drivers/iio/adc/ad7606_spi.c +++ b/drivers/iio/adc/ad7606_spi.c @@ -297,8 +297,7 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio_dev) * otherwise, they must be hardwired to VDD */ if (st->gpio_os) { - gpiod_set_array_value(st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); + gpiods_set_array_value_cansleep(st->gpio_os, os); } /* OS of 128 and 256 are available only in software mode */ st->oversampling_avail = ad7606B_oversampling_avail; From patchwork Fri Jan 31 20:24:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDD8BC02194 for ; Fri, 31 Jan 2025 20:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iPksdWFLQ0rEKufw8FEzV82SO01/egygbfSbj527fY4=; b=VA6VH1a4RvIkgD k4sxNml7OMADsBk8eFVR3rFQTdcas8Ddu6STCyb9WE3qO04sYb3UkdJCbSjDC3p261m7MhIx4ZPyp RQTkL200ByZ0THqWt9syLcAgtq8/81ekEeEL15dzjPhtiAY5Xj8Tcm8UasuywH13SVVE+xLc1C3su JHzPwes8m3fM2Bkts5/NoztkUBD8fXXwVSzPj3CvFma38c6RlLiECWrVo5ziF5Fg0pftc18sQkjph QWCYvPvnewfzSDpgLRmqs5KlSxNSalXUO+NEcrt2W59yXTC/7XVc/AGQEhvel8IdtS0kBjD9f6UqJ wVoEOUFao0G7gg5CeMHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZa-0000000BMs0-2leD; Fri, 31 Jan 2025 20:25:06 +0000 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZY-0000000BMrB-3IjM for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:05 +0000 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-2a01bcd0143so1484715fac.2 for ; Fri, 31 Jan 2025 12:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355104; x=1738959904; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WNU4SR73NkzT5flFO6XZzV58Nb+8n8xP048rFGpOLNA=; b=X8tb2YBJny1BkJS5lMyeDR+4CBK8s3oTM/XAnMaYBpob0KG8aJycBFMiIgDFzkG57N 9FStGzPEGaioLzqjDT8kgkEyetr17MRWG0+ugasDmAhS098BPSISkRvwq3cmcn0tD9Vv 6SmMoFbMl18p3g4buafJFkPjEoLiJ8JEdE72bZ49eCffNUNW4bE7I8Ft3MnnwpjnUnPl AZK9AeZnbvvTVZcsnnQH2/XdVyDXQI8+EOUP0DG2SY3tRQ9TXR2ef36GGSpYShvAhKgg m1HsgkJUsSFT3Zl9a2DGdrddf90b8Ta49qHcKbi+187Dm2FQeG7kLfgoz9iD+NclXRdK Pg4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355104; x=1738959904; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WNU4SR73NkzT5flFO6XZzV58Nb+8n8xP048rFGpOLNA=; b=H51aaZwpAlAJnDrUicQZZX6g4piqdDg52/3LFMJntBRiiFfcRYPDnGQ6fC2CQbdPio 9ABvZL6n32S7BeEW5bLG/HL9q1at2/BpovkiZrZeOqajwKOgKBeOkpd9JVSE4+NScJeh pQx8XQpw4VRc7puYbXil941npW7bJ8m0PE6B71U0Fmo2r8JSVnYvXnbDFJnMFlXxfvGY cMTeM3QhMJTCsWlfo0DzY0iavw7OOQn4/YVKannoYaB8RZXLo4E6qjFJ5XJBOxe2Isn8 bDMius8x9bo+pXum/7jEvhw6cd/sZkv9xiXuTTXj+ghaqwVmvylocKWAVnWScBiHeBpl ci0g== X-Forwarded-Encrypted: i=1; AJvYcCVjaqGCcI5m5aNJ6Axb01V6W09kQJH7Sfwr85IBhkydLIN+FwakGOlrc9N4mXaA5UXPMhLV35k5Sk4=@lists.infradead.org X-Gm-Message-State: AOJu0YzBBc4shqg/lcqKeFTb2n4HjXdxGqFOdQzAcPkz2ESwKUzQZPTk DRnE92s+o+QxzGO8yjxjq7dlg7co89MhQFJ5jdYdOJnhgKrMAoVmA7fMZxm7Ylg= X-Gm-Gg: ASbGncs4p0KLEdrYWhjMEWP5KANTNzixZ0iOIVeOrnC20LY6j+Vnpgc7ogYjfvVqH2w fyJQz3TMsCtX8T2rX+4z5MlfRBIhjPwpobkCZsLPc3NCk+7negKhD5F2rqFX3F8IJvkCL587HiT HU+F7Nh4jelQ2d+lV9P98O7z2s20YFGjckkUgf8NwFmjTaW3E3WRA+igQQrkwhgcVgphmcPNdmx 2HKtIgq7dQ3L4EJSLTfcx1U/FduOmbkJH25gTcCyJp5gPLpp3k0Am8bwFL97D8I32fVTavX3dml T/dxB57xkH8IsDId3gdBUlGygj8u0XCzriN5YXIGc+Hw8cE= X-Google-Smtp-Source: AGHT+IEjjM8UkUItH0qBBqM7/8yjcARln6tFWMQk1I1vtwY7yg+bjxT3tjK0CN1AwA297vbCg45WVA== X-Received: by 2002:a05:6871:7891:b0:29e:48d6:2e62 with SMTP id 586e51a60fabf-2b32f06986amr8146491fac.9.1738355104164; Fri, 31 Jan 2025 12:25:04 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:02 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:47 -0600 Subject: [PATCH 07/13] iio: amplifiers: hmc425a: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-7-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122504_833843_976DC3BB X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient. Signed-off-by: David Lechner --- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index 2ee4c0d70281e24c1c818249b86d89ebe06d4876..e8c67c8145b1b9ccb9b70ccd3ce4f5de08f96e69 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32 value) values[0] = value; - gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, - NULL, values); + gpiods_set_array_value_cansleep(st->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955785 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EC5EC02193 for ; Fri, 31 Jan 2025 20:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u/HbdRs+AwrPDhVP9zkZBPWa4bF0E8L18G8FzdJWahg=; b=a2NacS9WYlq5or +KSixyhonCt3hThBPl7I6r//tjpkP2xNfynjm6c81TNvikB2L9Yn9pYTwKXdQarNn9mVsRHwI5+Wr +FHJwfRu5EAxCxI/dMud32vM6UbsxU6+7XnpdkIJjSsYo4lMO6ozsusOHMkJp8hesD+4bl7eGI6Qo r10CFYuJLfvLuy/aVRjFohE8DQCZ3MQ4YLomJmVa/S6oSul0UsZtL+b4m1Fqoc6WzqszbBIHQI6K2 +nI4glC8zEKMwiNuvwpXDnfXKXwgD86f2aJNQYjM09mluEUeJPnglcEYwVwnPjCGjNv1pzQ7pdCqs Swiyzw56F5daUOZe7nwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZe-0000000BMtX-0aCx; Fri, 31 Jan 2025 20:25:10 +0000 Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZb-0000000BMsG-1rms for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:08 +0000 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-2a3bf796cccso1125465fac.1 for ; Fri, 31 Jan 2025 12:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355106; x=1738959906; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DXSo9qIqFw2jH0TFUFiXNHDreUcSE5l/XqXZpt46Vu0=; b=Y12Pm5FOEMYwti8ilq7nKfhzzaSRB7KcgIdmEeLzjlIF4NqMrgl+vGt7b366xcvSWL caqkv318Cf1Jk2zT8jM9/EZ1xLgw9eKnc4p844lXQk513AiA+Aeqalng59WAN5hxfg5V or/KRKw4HGjpPLIc9grmCW/GdYzdfdRLm8XmIYUPmD/LGvku52pqixGDqTfQGIBTKOqX f0ATe2gvmJ6KmFsh5WS3r5YuZUqJ1jGmL574O9z16Oz5+0iFNI7pJdiGA5BZJPrO9pDq mf/RKhKr6z5LN25epXLXu67DGh8lapB7lfVcKE9BlqdjwCG/TtvNfm9qXS6Q508FUQFI nvMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355106; x=1738959906; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXSo9qIqFw2jH0TFUFiXNHDreUcSE5l/XqXZpt46Vu0=; b=RjV2dwaZP/M3hx0QFi3p34KNKZiFaWD0iYkAperW/c/CRQ3yzRlJqhDGL5ZTKwHg4d BB/s/W/n0TLaUlo8qhs9gRh3YzK8LIeqV0NkFgwsZD65aPJLMToQb9W0vOLMzbvtcsNX 7EkGl6CnQYTxPfxBGJ4LRbMXzLkz+fPtZempjaPSExcsyLMadY9cY1sNoDpYrnowK868 yQhRm1G0C7u9+0QVv2WwGfYYfXcv6N/8x/ghWSzcNuKugq+yVXYZ0Z93wu426y0ehyCx 1bwGbfjlXp/3pJdfo1xuFdhkxsDbKzFeKaKKje5Hf5Ry5wyeYEHfJy9oKfpAeUxz4XIs DIbQ== X-Forwarded-Encrypted: i=1; AJvYcCXSd4ySRZ2vktV7IxogTwOCpzy7TI7omYuhPx8h0OEFOLXYY5s4HV4n+zwIiL4/rgsjXjdjT5DB4Ak=@lists.infradead.org X-Gm-Message-State: AOJu0YyRRvAkIEku7b/2vsXgdfUPSccqyKi18lnUMaIDLDKob7shg1br 6fwSIJmZ1ss1N7um7Dz0VtnV0Ay/d49+A8aDdHtNGIiy46s1VOmV+CqLdJyeokg= X-Gm-Gg: ASbGnctl7zhnX+HxNxMX6G7He3XXZh0N3hBUtiCWVf3y9DMIKTKIaRhuRaR+KOgmxQq oAxDL2g/Of0DybW76SyiV4JWf//P1LI/JKISrn3sgfpNBrMxn4nftlKmfI8PRa9jea6jgSzHiQT oWdPXp/tRzxYVEuy2wKi9aQPkloyK7IGdLy/DawsydvF7rMLJqNLjRe/NgoOJtu1fLFOnMBrpWH 2ogJYbFnHBUqAr7sS9p2yYicRqSQb2pGgvzD81iCh9KzmBqOi2r5FtWZ8u3oqDogL4cDvHJO0XU 1s44+o94XgLANs7Fj2f+hbWwZEgstLjfljw42muOUfyyzNM= X-Google-Smtp-Source: AGHT+IEk+EYILkaYfRPwnEDbJBIEBFXhatYC+4TE05088ijfOkCj1XESP7wyxn6VQQJyYksFnt4aeg== X-Received: by 2002:a05:6871:a9cc:b0:29e:2d18:2718 with SMTP id 586e51a60fabf-2b32f26194dmr7999805fac.28.1738355106264; Fri, 31 Jan 2025 12:25:06 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:04 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:48 -0600 Subject: [PATCH 08/13] iio: resolver: ad2s1210: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-8-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122507_486571_F979DB83 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Signed-off-by: David Lechner --- drivers/iio/resolver/ad2s1210.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..938176ac7209a92180fe8d55191d4abce026afdd 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) bitmap[0] = mode; - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, - bitmap); + return gpiods_set_array_value_cansleep(gpios, bitmap); } /* @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) bitmap[0] = st->resolution; - ret = gpiod_set_array_value(resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret = gpiods_set_array_value_cansleep(resolution_gpios, bitmap); if (ret < 0) return dev_err_probe(dev, ret, "failed to set resolution gpios\n"); From patchwork Fri Jan 31 20:24:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955786 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ECB5C02193 for ; Fri, 31 Jan 2025 20:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Bsbg5/qtVEfKOgo9hLA6yLsLgaJk/fmz5jWveRf48Y=; b=W3QhL+ygMXbFxk tmaSv3r+LZnKYiq5suqJvxkqE8AlDVaQMd71rT65m+yLSmKNCKACDA9RGxeJOo81NA0TANMXFh2rN 70WKBvbo1ouB/mEC6G/NGELH798k43EvoqdVkhCVgi68Sk+B4wW2oYFBVYZyULQI8xCN7ic4Jzig1 wsww7f26penI+WobGShBjyxb46UP6s2lJjuRrMR9g/+vW1O6V+cqQ8kpVFlASz4QaoLpcXGiKxg7c KBdalCOD/lU44JWzHhYQiPV5vZO6pd+jDfF/yJCGSqcRxDxJ0/gg4N1IcbrBQAi5AyWv1WFGdJbUy FlGOxCRvsSAhFEtjAMoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZg-0000000BMut-1fjb; Fri, 31 Jan 2025 20:25:12 +0000 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZe-0000000BMtU-18bD for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:11 +0000 Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-7231e2ac9e4so637189a34.0 for ; Fri, 31 Jan 2025 12:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355109; x=1738959909; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lwWNVnhNlJbHZ/NQhMSjzQrpqbMeo/6h41DdX1Qvb2w=; b=uc3lTs+eetLggqXjgztk6ymzJYdeIASEcDLOcM4KlcNxEwV1DCD5mxgdQXkp2mcGnB TASXEFwsJiuXwUF+cPovkc5WJbEFs+/e5FIiQrptmIyTNLrP8SGwfB7zXVWe1j8791oq ZIFK1pMQLbY9x+UGNSfNrxfsvk7u4M63hF9Tf9N4+QZtDx5t3AVh2xiTwWY5o3/k26Yw /tHHI/vMAs1Oa/rOQ0QblpOBkLnirMBUzPRbkfJj13/nV/ijhr6FV0k37MvskcDc7Pu7 03nFmsPdhgl+LA2IDwfHAwKbpggD5D/gGJ5dcwvpPfRn7HnrtZT62LvBcmWhsbqnxFr5 Darg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355109; x=1738959909; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lwWNVnhNlJbHZ/NQhMSjzQrpqbMeo/6h41DdX1Qvb2w=; b=XLMfx8HvRFkiwFFzYFt583nkmY9xs2XNDuGwvSbnhg0TiOiVxbaVyJnjY1TFHZEkIQ j1ySbqbumOAsooqhFkP2M/WWpWY1H4cfcmmHPaj8QzCZLeumMDtHlSPVuXOjYZBJEvqX ba7ogReOwtHdjN+cpixMzKh4wiJwVy9FAeXRStHpYa+XBcsmzBhFAoACurAfsuzArLQp zl4K6jcfbGBbhOHS/GoV83kQponEAHmX7PKZFT/qSfLvLRJiaPTQRvB2AxO6cERjg9hF DFBIfY76l/EiSlNlLWXJioyyxcKtq8Mj9cTHZVRljRUIJ0+ysBb83SK8CpV1Z/rtRbZW v3+w== X-Forwarded-Encrypted: i=1; AJvYcCWOYE8ecrPE6JjoVTvc3YeHkdvlWbotbxTLCxLFJ8dxRWj4YaUfVtIsieHl8LjF0YQGot8pCLEvMyM=@lists.infradead.org X-Gm-Message-State: AOJu0Yx9uaOqeE1lCdBMWHUy0dXqrWNYWaBu8JHMpSVOzDLn6eO3oLih ro8aF4TpecFN8qKpZ3w/I4ryFT0YkzZRA+E9TbAVmC0sdFzFAvAleKhygw2RVrQ= X-Gm-Gg: ASbGncsrHPN5+QmW5f+urPWuC9ldPpQlb0HjiBNNg3lnbilAYHBGL8y8ZSfACnjiONA wCrrmbg4BBxCQX05PyEU3LSJNHyX09u6eqsU4LOMl/03f5qOD1trax37WAviAZTFUpBRxx0eNH0 U+pT9jLIi23L4T/LSFArxKBQIe1PZu/95QEayfOlGQAqdb7jnD0ggl+xj8qUDqLT8IIoE9fwIrF MLMCDMZpSgLrUSS2uUT1ankszzu2I1SIRrgqN7zKr0pwJNRg01/VsP2Ajvjbf2B9QPur2IEDQ8K AjExrkptyg4/GgBeSxETMTYcx4yoFDB2nX4fFTFSgW4+Mdg= X-Google-Smtp-Source: AGHT+IHQyjQ8y3Rtu7NlfkeMw/zOxhLdOk/J2rb/TrRaSbO1InYUF9KwbynHBq+Y9XgpJsj8OqBDUw== X-Received: by 2002:a05:6870:7186:b0:296:aef8:fe9a with SMTP id 586e51a60fabf-2b32efdc7b9mr8033858fac.7.1738355109312; Fri, 31 Jan 2025 12:25:09 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:08 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:49 -0600 Subject: [PATCH 09/13] mmc: pwrseq_simple: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-9-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122510_315591_E5B6EE7B X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Ulf Hansson --- drivers/mmc/core/pwrseq_simple.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c index 37cd858df0f4d7123683e1fe23a4c3fcd7817d13..b3a6d053c826741005f1484ad81df30b6bf75bbc 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -54,8 +54,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq, else bitmap_zero(values, nvalues); - gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc, - reset_gpios->info, values); + gpiods_set_array_value_cansleep(reset_gpios, values); bitmap_free(values); } From patchwork Fri Jan 31 20:24:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955787 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E060EC02193 for ; Fri, 31 Jan 2025 20:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fwKOcFTkMzsYKWQWrVS16pSUskt7OMR+LJmUHJShsOE=; b=oe4xer0YTCJz24 Wry0GnIr1xHbNfrOsH8sioZp/v9D+xBofaO2wQIjEt/LvH1OGuMYIU/qnw5eYnRNF0SXslm20e5S7 IiYlgU5SpyXVtvA0go9fWZJzWNS2mgew5m8J/Lmjj3cW0E6bWICbqaruZJSwghGkEJFEa2N0Jamsh 743m/OtDKN66zJ6/UAuT3sjQB5vBCHBo48I6QEK0fL0TEw5Z7vUAvMlf0+SkO5q785Umliq1NOTJx oPxGLxXVCfMYrJl9Wc2mPNN0uo/HY/G8foIZNeirSTWzftfiJyXxODpxKsQo4eT3TpyXtPcOySJax M7R6v+/KHtratNf2On3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZj-0000000BMw7-2m1T; Fri, 31 Jan 2025 20:25:15 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZh-0000000BMvD-1lHF for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:14 +0000 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-71e10e6a1ceso618990a34.0 for ; Fri, 31 Jan 2025 12:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355112; x=1738959912; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=q8dlq+1FyobpCXd9TkKRwFwRft57r9IiORFW/g/tAaA=; b=ekMju6EXyeCvEWCr9HkYYHemTDU6OOJlfbBXtK8qnzFbvsfIOyd0uyMUFLb/v4ceCn XHmDS2dScIWnYna+OWKI6ORCXdzK9BxlH4QVCNL9tGnJ1lr0bWz9Spvtb3Mo0lXtJ77m RLqwut8lj3C8M3YLLQ6cLg/yqv0xssDRu4gpBEvUl4OSLfCLO0ZXqjNW7IEbox+DhgYt kKi84LNv/0IF0HkFlu6KeUBtL+3LIB/gnxszVGAJhG1VgABZoWaQSnO7EPEQpPAFH3WZ vQS1ujknV1tH9nA5N3cvM3o2qaOlmoUuzbrAws2X3iIraUhXYgBwM2M2J1awPvKQIT2c uInw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355112; x=1738959912; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q8dlq+1FyobpCXd9TkKRwFwRft57r9IiORFW/g/tAaA=; b=FlH/Uj0euqvULA5ygJ87bvohgfQltKdrnIMvmMuKjQFZZHDjGmg30nzNz2pudH5QdD ANJSW/CzJxDcd5lvRFMM5vF06j7Bnp1KxhrR9QJDYb5f3gFnW5Db12CWqtGG+LwQJjmT BzzBhl5a1nXWgwj6j7DWvH/E9Ij1CXO+/13T98RW2sn8cYDokXnmR3md2vFT7s7Vz+t7 riX6kxMWa7IcHARlULYJOtQaUtEKpLiRXMObwOYeNLn1xnlWNZgCAeNf4f+fY6NNFMK4 979OgA1XHgb2lRduA6h1UgyB+UUtv3c3/K6VtBZ0L3pcO448xNhfTgee01FJtoW3Tq7Z Xk1Q== X-Forwarded-Encrypted: i=1; AJvYcCW8FwpDIackA4UXNghflE+qWaTqv7zA+cPKnOppJggkh7ao8NdlEM7fOMbWzLvYaf9Nqlhbi0dvvv0=@lists.infradead.org X-Gm-Message-State: AOJu0YwsEsoBQer2/7bZOjEAdS8ZE64yqB9D2lNJWUZoH4WczJcZ+bGO jgDEIhiEtXUdabOEreOW+M8WyihF5uwHQ5r0z3FsRfp7GxxtCG1TXMhncKDXjOE= X-Gm-Gg: ASbGncu6+Ksv5bRjyn9iX4716pvhkhXBaTe016yg++hiJGEFt+a6cs44N+sKU78abvE 64XjyWNiYZhI2FP6S4wZ79USSdJBXdIqC4rlhxDbrAsLw5jXL6044AMxDN3+rwQ8EPfh0iWOCWz EOmPpOscZyU/fJfky1uG/YtUG6kbOR25m1rVBfVmN0GBDcORR9GsJfu2HBUI+iGphqHk48WZG1i OfYABN+RYuYnRADMoykvMnivuUYOeImxPKF4U3pVNjoQNrjVXxAqjOxr7iPG/CRoutCNT6zdxEz IECino/g4/TcDcr/1Q7JabKbmnC1mqDsIJg/pIJX70ofXaA= X-Google-Smtp-Source: AGHT+IEOPFpYcNvsoJvtChI72uu39YNNI5XV7tV2UH+PWhk+hEwEt/BHCYYItie+9RSXj9400mKLXw== X-Received: by 2002:a05:6871:2106:b0:29e:2caf:8cc with SMTP id 586e51a60fabf-2b32f30c9fcmr7202349fac.37.1738355112453; Fri, 31 Jan 2025 12:25:12 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:11 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:50 -0600 Subject: [PATCH 10/13] mux: gpio: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-10-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122513_461329_5F82C3E9 X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Peter Rosin --- drivers/mux/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index cc5f2c1861d4a22d984bcd37efb98dd3561ee765..fdfb3407543dc3c2563750b013754ceb3390e39a 100644 --- a/drivers/mux/gpio.c +++ b/drivers/mux/gpio.c @@ -28,9 +28,7 @@ static int mux_gpio_set(struct mux_control *mux, int state) bitmap_from_arr32(values, &value, BITS_PER_TYPE(value)); - gpiod_set_array_value_cansleep(mux_gpio->gpios->ndescs, - mux_gpio->gpios->desc, - mux_gpio->gpios->info, values); + gpiods_set_array_value_cansleep(mux_gpio->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955788 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30606C02193 for ; Fri, 31 Jan 2025 20:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/nP9clFA9YNJgiaE2f+LpjY9TGxi7wt62ysrR75LmFM=; b=ZuR3kZlsAZpKlL 6dxb6eG6P165b8wnlQ9IJYw8WTiWL0ZfbB08ChZSr7iTFm5YfhXUQxqbwX+BK1epzISjFMLYXgoF9 IB7wtorFCzvpmpy9aNe8pp0NbqbajrK7d5NIYa7T1b7pkRpRzL6OZOy55He26rk2c090IgrV3RIfO Pz4Ka5Ek9skkmrJ7hzF+RA8S/NLi4HxKar895SoJPmNCYtSoarjPQ13wq5Ll8U0bk98FxUqYo6THj 3cWctnrNFmWYHqS1gMElSW2tOsQ0ZU0f82fd8E6ybAJGyLGMquUPBF+UsWyJfXrr/JjYwCUNdrnkX 260O+wz/+Nh2JAMPg4bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZm-0000000BMxh-3sd0; Fri, 31 Jan 2025 20:25:18 +0000 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZk-0000000BMwP-2wOT for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:17 +0000 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-724f4d99ba0so1124298a34.0 for ; Fri, 31 Jan 2025 12:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355116; x=1738959916; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=59JJI4CO0oacXanEEbv/QOEs28IMbairlUQePRWumA8=; b=HS9fidPbcF0Z5ui4TidcdVE8z5UEb/nrBE5UOZ8i+C0raY3fyh3OM04ogXKPlZyVs7 wzeZSc3q50VhmUKzVam04wa0I+8G/aou6oKy7Ovw35lkAmberBM/1E3z4xa9KT8a3HXV IKTQ/rvUrpKgrT+0VGv1BL6WaLA+ejZWyvknj4bZGkMPJbbIFFQytkbuuCzCeW5f8ops R1IuzCCl7BmS8W+DOr7l/hOk4NoUrrG5PYdY2IWZErL6vmzmDaHpOC1DZXqxwIsGb0Xr uUT7FeIvYicjkaMX1i0Mw39Jk9jC4pPtl0ShVS+pZ8p2b8iN7BOekxoDB25VPbxyak6P Ygug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355116; x=1738959916; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59JJI4CO0oacXanEEbv/QOEs28IMbairlUQePRWumA8=; b=d9a2o+9gS6EXnGO3n/TZrV0rgL2COjdd3Y45UBFJYAxrAjcQXgd0KLWXnNWzi9kSXn sQUmd7QojUc7P/5++in5iGeEKHYso89Jg4xPEB+Xh/nlM7A9YxVxxiN8IxBnXCL3Q1Zm 2AEOqJDk0YEvX1X4ZB3sNF7h1TQ/J0iICYNSsKaUGXHayP4GsXxJOgf8ffVdcEpR2GnZ BbJQdCKDhyUeeVzy9Sa0Zx2ZAw0vHmCaHO+teo7Nm3DEBM7dG8gVrdoCaCs45ywTJTOL GwnhJc2D6djfRNXK8iYdXMmG03/3Nd/Y6tiViazugBL9Q5UXrlb++ofhObDC6Pq1s363 KPEg== X-Forwarded-Encrypted: i=1; AJvYcCVKZSUpakTnZoAsgtXd2bb8omjvt/58aYgsI2q2jOCB6CPaGCHRHlDBcJdhG4+DUMoUHDxrONhT6eE=@lists.infradead.org X-Gm-Message-State: AOJu0Yy0nzYDSVW4w5gkDlfrBkmsk08JpBbTCm5WQl/LGeVEE2Xj8o15 eISoXOhF3anb0bRoePr+tWau3/t7n1N7wMl5fT3ZWHHpezbsUkT5hsw5CwHUXQ0= X-Gm-Gg: ASbGncsrRaxZsAC/I5yp+/ChCPQrLzDCpj9Zix3eYhPSzPArsTiqarRzzsG10Iw/Uvl o1l/TkW5NHueHDkOPWagL08lIR3c9v7isiQMyjh2jQxQ2S9mmiy85UTpaGzskPzAvCeH7cd/zsr Vf2vUlx4tmO5PUKXWXsiSSVWMkzm1JsefMUnmXYAWx+70xkJRjZCP2TNtVY3veZcuxLdC+/ZSCK 9TvL1Nkm/VW7WpzJIGLkBfR1obPap3P+g5pv3U/+kGbYobEfgnAHRKbGa3MirP/qXsrAWWhmbfl 6YDa1+FTNBg8c0N0mdBGllO4s5IzoK30obje8YnhELbLgHo= X-Google-Smtp-Source: AGHT+IFrVMAfd3Y3wOZ0h4O9q45j+fMg4Vw3AAmlNZ9ZgYIq1KVZZxWHseA00ADe6a66eu+rR/ZJMg== X-Received: by 2002:a05:6830:6805:b0:71d:eb02:baed with SMTP id 46e09a7af769-72656774376mr9460293a34.8.1738355115546; Fri, 31 Jan 2025 12:25:15 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:14 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:51 -0600 Subject: [PATCH 11/13] net: mdio: mux-gpio: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-11-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122516_743148_817584C3 X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner --- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-gpio.c index ef77bd1abae984e5b1e51315de39cae33e0d063d..d7eaeadde2873977606bdcb5821dba18aa4a578f 100644 --- a/drivers/net/mdio/mdio-mux-gpio.c +++ b/drivers/net/mdio/mdio-mux-gpio.c @@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int desired_child, values[0] = desired_child; - gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc, - s->gpios->info, values); + gpiods_set_array_value_cansleep(s->gpios, values); return 0; } From patchwork Fri Jan 31 20:24:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1B31C0218F for ; Fri, 31 Jan 2025 20:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DxUr9IaHUbk0w+3k/PMPkCVRx08sVRd6l8ueFIhjbWM=; b=Frysr9q/Fj3QPo yp6XZT4oiNjiy1LzXQHox+Yu0qaBhNnoj4bZYf/OUJRhu0LxBG48pV083CqfjJdzr0nJUcTHiJBMM sK6zq7P3Mgs6zyF2fa4m+wpcjYpF1X+u0HqcNqNTo+QMGt1w+kYVozb5t5ODtBspoOkDXxo6A4Ti9 u4+DEh2whSBLXfZSjxG4dGEokJ3RfA9R6aKEfhDTjV376bdB4yt42ZTyRh6tXNScHiiI3sp2U6HCG KluhTXwicD2lugZCmOnMmGFuBMqz8wElrxnqjn9kLBtsMn+yRxeS36PjfKID2d8wVAr3vn2OikzU8 5uGwqU9rTIAoVu389q4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZp-0000000BMyh-1jZW; Fri, 31 Jan 2025 20:25:21 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZm-0000000BMx6-2pDj for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:20 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-29fb5257e05so788408fac.0 for ; Fri, 31 Jan 2025 12:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355117; x=1738959917; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FzzIwzQtyYUR99JIrJ6how8p6bj9KukV10X1RHN4Hv8=; b=Bvt0xM0vf5E1uszFLQOsz8oVnxcq/fXcWNShiimH6hmdapPBq9Y02oj1+PS2zM+798 7fCL+zSRxexAZY/wBxqgZYgbe0sORAI5wPZN4I3YRzJDS+4eWUoH/sTJUwpkKR/YNUNn s1vxQnOrs8F/57JjpPt6J5dMX+OTvtmFgpHuw/qw08Ryob+IGUdCPs65d2luidl56P6u qg1z47dwoXL+g7lJmijpnDZAONV5LBxI2UeCXBQz9BC9fwcQ4J9hLrP3/miXDaVCmaJ7 wnl6LS+YbxLpJt2DLB/Fr7zOYmALO5BqNg4qr78ZduSdi6hJ2KCkGQ5pwQeq0q2cvhdn S39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355117; x=1738959917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FzzIwzQtyYUR99JIrJ6how8p6bj9KukV10X1RHN4Hv8=; b=vNF5gtSyOTQHjw72LoKwG+EDwvkiDB/rBlvrnSV5qnxrNxxYcF9O2PaxyU/gC+J/pD boqYdOKcjVwii+M/hyDZg/luU8fU5NnXNY9hvA8pjjYNbVN/5o1s8vrn+IVMTcAR2k0K kn+e4fHUmxzklhkwfgjLYWVhgKN38i0hNIfi9eHN4b9jQouFzVdFVznSKusxm5mJv9tl dH9tR5KLmkZhIRLYCdpikqkVg8yLfscQgiPRqg3roF7081hQj99otLjlZOXibM7spDYg wF6obDnTFSOz60/r0XAuMpvDJZFe0kLHygcvedNKvK7v9enPS4fvL3uPzIeVseOZqg0w tsaw== X-Forwarded-Encrypted: i=1; AJvYcCU9L30NsncumsQHj/wuGYqNNRrtnFAiacT/Nfraas8ySkHuIFS82+qdkiQg8uj9BEN0EsumL1HOpgc=@lists.infradead.org X-Gm-Message-State: AOJu0Yxa4LZIb8OFqS+qHWo3VJzi47wb1J14HLOr5yqRV8ZojYi60Qlv O9RzTYQRqQgwkB/1aSpmUHuKNfVM+OdZwj11Aa0VD5mmXQhxc8NXhbwoFMIiErk= X-Gm-Gg: ASbGncuMOIZEUbNzHQbySZq6vytppvTJhc0sUWaZze7d1atRqqq8Dy8b1dPYBh0tULP lGTmfaStmGFKH1ePp3O0Gubslw1TOXGDg7xgpubC7tScThs+MEr8e2QIEztBP3yDTZgk3V41WZI 6QtMZzWLb8Wdikvg8oXge8CGXy7+YcJwfJLTOI2w+D7gU3a7McXTlw34KDt7FWUZ+g4iue0Xa95 VV5XAkSJy5T3+Ev0xU+8/pdNQLLsXtQUzMyjnaWK7hQvCKJLL+CtmxAh3Qlloie3sJ2Tg6s3SJV cNTNSsW3+QYMq8QxIqMpfpp4m+QM0TEhigSVT50jFMlUA8s= X-Google-Smtp-Source: AGHT+IERsKIHS0RESeT1aGghrd2e2VbJU3Jew/L2qRirwk6axnCtq0WNFwypLdr9E1c9DhZObl9GKw== X-Received: by 2002:a05:6870:32cf:b0:29e:255e:9551 with SMTP id 586e51a60fabf-2b32ef5a830mr8108456fac.2.1738355117684; Fri, 31 Jan 2025 12:25:17 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:17 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:52 -0600 Subject: [PATCH 12/13] phy: mapphone-mdm6600: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-12-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122518_720064_ECF2A2D1 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Signed-off-by: David Lechner --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..8243bab6ac3af2ee1394ef743aaad12a19c8ae36 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) values[0] = val; - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiods_set_array_value_cansleep(ddata->cmd_gpios, values); } /** From patchwork Fri Jan 31 20:24:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E082AC02194 for ; Fri, 31 Jan 2025 20:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RDTYCjwpVidxWdbIm+eElV9+YgQu/M3/96rSnrIJWM8=; b=CuOicnHVz8ztAu j6pUehd+m1338W5+4NREpNUSwjRfELwgGH8Yq7hW8/Oic3bxmWO6B7TlvmpV8Ig0D04PrpUwgGIf/ +mv696Qsr6H7HrLOKGVZwatpe+XyVnxtI93ubVQD8T0QAg5AQAp/fUGemY8I0dVHUI3hrPCRBuSeC 163rSXUOuX5oKCGLryVUBODdyb3yx7KDTkrIsEk4bgodViqXZoNBgOfK4C19LUgdTyubKrJxAT1vm 3XDjaxnBFfDskNsj347dZ/qA7OfCXb4LAISvyoZiKHeQ50oKUIgIhEwEPpC1ESlc/36mIu2WWbQAw kscWjB25qyUcgENRM6SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZq-0000000BMzZ-2nUI; Fri, 31 Jan 2025 20:25:22 +0000 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdxZo-0000000BMyB-3b1U for linux-phy@lists.infradead.org; Fri, 31 Jan 2025 20:25:21 +0000 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-2b2b6019a74so1123830fac.0 for ; Fri, 31 Jan 2025 12:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355120; x=1738959920; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t9cxGVlfrmOEOQA8LocUnneYPfclUeeeatGnfm6leQU=; b=mWY8nlJouWjt2OghQ24xFO6cU7ZSWiXwHRF4Hr5Sduq7mi7lqEXRE6ac8bltHjzjjB VA9/i9Eq33vcaxMtFJh57KAbCmecvRnN7+5rrvdoyQ9l5DCvUMFSw6dwrDRx+IjoueCw fHTkhui3U0sGs59gYwsCPRgpivgppDeRr49vQr1m4O5KVCPLNMnudW9uTNlTuevhylHY xJO78K3b8I9c0Z2RjWVnOxnEu0o9FVHZiiU/R0RXX7c2BpNljNKG1CbIUNK8rGFXCCzF 36vYUz448hrGwD3w4o66r7EFM83RgOrjtCBixkVJQHLLxB2KG9OLUv6bF8vIT2T+ov1F NL3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355120; x=1738959920; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t9cxGVlfrmOEOQA8LocUnneYPfclUeeeatGnfm6leQU=; b=npleop4EWhQTXlnC2IQMHbebe00gIfLsgWUxs1kVt0EHp3iSGlgLBC5N4K3JMZVtGK zNm9ui5RVI9ZAQlmJj7Dx3yH/elPeD/vBGHG+c6kDwiZ+6xvzqRZ4+VKaj5hPfEIR8ah b4W/gZJBv1UOtqJ4NAmEO6bFV4DmV0ci7PPEA1Kk6IZCWpcBhK4u42ieaimaoJ+61yB1 RASK4xQZy/F+6Sf/Fg7I78flkfggjsnskMnfgy3VEDnmV9zYyr5L2JSG8Xoe36drQAnR AhONuysouFrJqBZV4x/xC0uMBd9te9EirZeMEW0cABKFr8zKq4qM03gfjD8S3ht3mXii tw1w== X-Forwarded-Encrypted: i=1; AJvYcCWdH3FwBBOIbE+un0pinOL+KTJWK0SF0DQwV3HGSsFCgnQKXuH5ysWEyfA04oeqQ87IaJ4pocH7cRA=@lists.infradead.org X-Gm-Message-State: AOJu0Yxm+UGkz92j/3zXPIUjnqoILGxdWARAq0Nm9aQY1dZTUp1okDVK CWnxfQd8DQdvjXWDpx0cUyRXdEcYC1dfgXF69qAeaK+iKof+g2uz3EPvtBFCEAY= X-Gm-Gg: ASbGncumwJ27OxdD7V6rdUweyOePCSCXkwEmjJa12LbANY/KRBEcIB07uKb3s/ED7BR ji0pqXcHZtFfG3Miv+6vpKmMPphSQugy20QXvLy8l99EATksGDVJOd7lI+fJdCoTdPBvC6dtlGV ZvOCKoTKBD5Gwb0r9CJnlfeKUSFi1Q45nH7D/llQUm8dUDAizxvuLb769HugdUwHBktyVlMUByW soG9WtLrZqGzfstsZE8N8UK0unvZdRHsayT7VLD9aPMEEaU3+HMlwPUKKVDpdfRdi1emUrXPYfX fRWcKVGZll486eZP1GVBfiw8kILEgwkO+430tKsLq+encVM= X-Google-Smtp-Source: AGHT+IGqg3uaTvNfsfu96auAGMNqMTSmH6qy7PdoMmcZZ87lNXJHf3Cu8HBE7iXbpxe/5j7p/ZYumg== X-Received: by 2002:a05:6871:209:b0:29e:20c4:222e with SMTP id 586e51a60fabf-2b32f2f8592mr8795453fac.34.1738355119837; Fri, 31 Jan 2025 12:25:19 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:18 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:53 -0600 Subject: [PATCH 13/13] ASoC: adau1701: use gpiods_set_array_value_cansleep MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-13-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_122520_904572_1B56D459 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Signed-off-by: David Lechner Acked-by: Mark Brown --- sound/soc/codecs/adau1701.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 291249e0a2a32df7dde81904dce2f6be143fc2d7..d3e6b2763950f78143c0feb07c36764cb265441a 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -325,9 +325,7 @@ static int adau1701_reset(struct snd_soc_component *component, unsigned int clkd __assign_bit(1, values, 1); break; } - gpiod_set_array_value_cansleep(adau1701->gpio_pll_mode->ndescs, - adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info, - values); + gpiods_set_array_value_cansleep(adau1701->gpio_pll_mode, values); } adau1701->pll_clkdiv = clkdiv;