From patchwork Sat Feb 1 12:14:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13956226 X-Patchwork-Delegate: kw@linux.com Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7B384A30 for ; Sat, 1 Feb 2025 12:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738412074; cv=none; b=kG5Kqjcy3vD92Gg/u2YmUyR9TgBcCvDAzmsOfKIoHmsO0iWnB17NRyRDeWNMhWDq2hdCguG4f7J/pQBkXg81BkV+QxiHmlZTx+Ls4IfdWrnYog7s1Q4TbXJz0TO7yOcER70WxB1qdOKtm92NgIRnyojoKyxD+jJClPycN2yS4EI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738412074; c=relaxed/simple; bh=CgjrduspYJu2rROU7CPiB3HogLwGGdiG/c2Lq3AYQ5E=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=TNxv5vfZl2I1O6Am6stTyyvXDbqZPhM0Gg698JnRtiHnMHTqRUYV/RvYYqCIteAa+ExTcyTHMEuuLHx3ArS7a/s5gsscR3DFuiyN2GhkubtSWSfPSJF7uc12bab2wK5iIR2d+odJgXMDGWng29hIzCbRad6H0bhqX9QLEHaJMb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=e+lNvylA; arc=none smtp.client-ip=212.227.15.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="e+lNvylA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1738412063; x=1739016863; i=wahrenst@gmx.net; bh=HTEVgElkJYk7nsJ76qRX1q+NvOWVT0ntXJHe5Etnm4E=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id: MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=e+lNvylATOOXoJ2x1Mv3EKtL6tNLNcZPiWISVbWxjwNfYwM1BSwO6nipj2fX8zvM hWDIDi1893NROL8psXedBCMSKB2/4ESC1jSV92/V8qH7oUdEzzcQrlKUMl8kpcpjl EjtVp20uVSzbMO+lqzvCyTMOTRfEFAGLKY0WJAHi1ka5VJMxC6xs4tLY42jIC4zsg L7z4AqVK+qUg0cs8Uf14xnU1Ajd6WZtO7l2bRnf8KoYi1VLn17J55OaRRiWYEUuuE 2iAjU46/OIdblCXVI2jLbN/eYQzWuncqHqYLBJDaPAGoGH2vSSBf1J4lwY4mvQoIQ ykehW1JWg4WaBHU9gg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.251.153]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MZCb5-1u0Yla2oa1-00IRDU; Sat, 01 Feb 2025 13:14:23 +0100 From: Stefan Wahren To: Rob Herring , Jim Quinlan , Nicolas Saenz Julienne , Florian Fainelli , Lorenzo Pieralisi Cc: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, Stefan Wahren Subject: [PATCH] PCI: brcmstb: Adjust message if L23 cannot be entered Date: Sat, 1 Feb 2025 13:14:20 +0100 Message-Id: <20250201121420.32316-1-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:u/0mFk/jI+uEMG4AnL1r5NzMclC3cs2OdNv8kDxNKxkovub8F97 tWIrjL41Xe6S348E5dEE/c9vSWrutIumle89k5mQ9wTsUjPtzo/D5YK3bDDotF6qPP+7fWN VucMaUGd6vua5lgGwqJy21u414X1wWCv7g2EYinlvlfl4f5k0N7iosuLwv4IbdtDBuZQLQC 5R1B71l83ypchZPoJA86Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Es5ibtccUaw=;3FIp3tRBvuHzp4EoTXfndo5cG1u jXqJJvUFMym19MP0I23pk13LJqmIL3kH0wV0fP6BOSZzo6kZHoPvY6WqMH6N056kJB3PpgMnp EZNsJalj+s9qJqqS4QnTkjA94+O92S4MXvdkYnS3+QQCQOCtyLE/t7U7gdjJEhF8LvQfu2a1n vBjXK9+vlsPVMTNFuEgzDwXkr1zG17XX/cfaS/g1tzzIUXbWEGlzNob55OxD36agQIs0qncnD y8OddGeKVWMzmo58yneyRC3Xf3UkCuwLMXEB6GnjsAW61uwdJmPWXvUP9V+xhXRHE5RXqXJqG YzVK3i+DoCtPQznag7oC95rEX3SzhF0Y34BjTMIT71vRpaZCmt9/9+HtllJpNix4MqkX96yzU of1cjkw1MBqktfd8NcDEouDT7nWXK+6UtUSV0zkbR3A/dcfnifsXjRVLL4UvR+vzafqFpyl0v v7B8SP2FBrIAY2l69VT97CfxnneZYW8RCaJHYC9gQBVHRu8aku2bcdwi/t+l6c7fz54Q5pWtd r1Fl6zRvgQAOKzdyfGywPMCFY5qQeQgIAWZx0wE94GcRKI3aVQS1cENl0usXccB0istoagP0R /Ykm4dNE4omG867VtAV6QMkdLligqMyI5CRRkCb8oLt6aFezWz2BLcCASRPLZDZhwpM5bR7ML UzlnINsvMW+3XOKbqg6QsSj2qv6oOknkzJZcrejSDHCgO+716AT5XgCmDfVZl6ArJe7QB7BtO 3SNA1SOUw979gE4vZf1NVlcKaZd6l6drqDXOQgFHIh2jhPnPp0ca5dIAIvY6SDFnKk+fov7+z FfWZJ088gJiZWs1UgY/xyj5+41tkKBHIOxmvq+oaN+2AozCCUQ6+1ap33LZay5DReZU5sqhe2 3J5z10SFdqwRDceh04Iqir2mxza8lPUkUn5JpNnJsC/U0jdtED8soXIl5t84kuHImYcRbzpUT r3DfpNAtwkI3Skqju8KExC8oKbtUgvqR48fgX1YSBznydkr6GjOp+IvF984jUqEnWtjzfmO2H TjJPgIPpDVFWW0Y8djLODZrvHH2RND86dQQvf6u3l/gHZCJ3CK2hc8DB5/ClqrpicbkPgu06R pINXhpN21Enb/J5fDWpWUJZ4h4F4azpqIkTwkl3j8sfV9PHrpad05LUxy6CHHl/VvEcB9oRql DDWux8j3Tyv1lSlgzRX502v+PQiO7roYM01sGrWzx4WSb21ZTwQXcrJr1KWxW4u37sm16N9aw 3w+8V+AGttnArEvKAwidqq6HXXBMK8qr/FBVOjY1iMDWufmbQyolB3W4Okhbi3evqbYVNbyG3 oipC0/h+Xh8ECCYJFlog4PJTnJ7JAD0J5vLd8MaBgb9WKk= The entering of L23 lower-power state is optional, because the connected endpoint might doesn't support it. So pcie-brcmstb shouldn't print an error if it fails. Signed-off-by: Stefan Wahren Reviewed-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index e733a27dc8df..9e7c5349c6c2 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1399,7 +1399,10 @@ static void brcm_pcie_remove_bus(struct pci_bus *bus) pcie->sr = NULL; } -/* L23 is a low-power PCIe link state */ +/* + * Try to enter L23 ( low-power PCIe link state ) + * This might fail if connected endpoint doesn't support it. + */ static void brcm_pcie_enter_l23(struct brcm_pcie *pcie) { void __iomem *base = pcie->base; @@ -1422,7 +1425,7 @@ static void brcm_pcie_enter_l23(struct brcm_pcie *pcie) } if (!l23) - dev_err(pcie->dev, "failed to enter low-power link state\n"); + dev_dbg(pcie->dev, "Unable to enter low-power link state\n"); } static int brcm_phy_cntl(struct brcm_pcie *pcie, const int start)