From patchwork Mon Feb 3 11:50:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13957341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77FB7C02192 for ; Mon, 3 Feb 2025 11:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bvsk07Lzw6XdWgB2cdXk97Y7I1cSDuStLmoSGezH+tI=; b=yohNeAfsLDCHM7VXH0nHqc7YIo ZphsSMMskuJIi4icFOdn1GxsZDi6zIMXQ0gBcm3Nw3KuZ4kOJr/eBq7w7HwPVE/iGXa7CknvFuchA MKh6DnpQjBzSd5KEnK+UNFco8yHOc1CE4I320MwZxVUZM3C912ktgJ6vgDr3wsHUgG+KGVaFXTDQr TKxSA4uyMQoADmqILaIW6TbIICm3CaUwf0izK/DVbXnZfPjyCkQ097d1gt/sNVSh1+dYTHP3WnAQ+ SObM8VXRkILjMm8HkzcpXQ0f3TGInprIPw4ADYGoClOAgWm02x23tlajb+XaouiiIxbwac/Ag+WE+ KanPmT7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tev2j-0000000FI7d-1uDZ; Mon, 03 Feb 2025 11:55:09 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tev0A-0000000FHho-15h1 for linux-arm-kernel@lists.infradead.org; Mon, 03 Feb 2025 11:52:31 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-21619108a6bso69830655ad.3 for ; Mon, 03 Feb 2025 03:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738583549; x=1739188349; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bvsk07Lzw6XdWgB2cdXk97Y7I1cSDuStLmoSGezH+tI=; b=bTYyfSbD7Fj8SP/dc/rxgdoV6z7X/jOtxoY7i5/l5T6GItsghwqUbG6FXiggPqvH3O Vy/tQS32axze/gbpwo9z8s8rw0M1J5dDduUNdxRV5J3GhVomVm8QBS++f4f2v+DSEbSH l15ziqkQcHaq0wkWZt4K0leGGbyLPc1nOHg1m1NhB7RuSGUS4TiVFT1dJ9Stb1qg7q6s nu5YGn6VXhjdN3X9JyLAF7MtN9jTXXxZv2sUxZmHgTb/mC09FM8aHxjl4mufypw8od9v 89zoQq7oC/H/6xrYaiTYpMGjk64pCNtLubTkuSDa0NyKy0w/Y6eIAM4M35McW0pAKDpe 4RMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738583549; x=1739188349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bvsk07Lzw6XdWgB2cdXk97Y7I1cSDuStLmoSGezH+tI=; b=Y6NvHQBNmh2ge6ia9qQJOl6/uzOHo4VqUyjqh3PVOxMNlu6TmhnEDFpSvfG+N7kgXH 9QoZx1lynoXX8LvDVmYA4Cjf+3kYsv+cjlFCq36C75F/7X6urGwmLlcV+MDnZjdBMOMU PueiVOlqxjus07jTBYGNoTSMDsMfE8N01ovV5Yw2sh5aJe/wrY6ivkSx21OHXkHrAIMF R+mBu5k8COLl++LaqVORCDy0YEcY+aUFI+J1ybORN/xVACc7eXeQbN+oARC8ZTCMEGTf TMrw2bIiRRtHm64Pcr5YJVP5ircCyw9LPGNnl8XFwTHBhcBWV4vz1LRW5eo3ehY16lp4 E9mg== X-Forwarded-Encrypted: i=1; AJvYcCUAWM5zKkD9UbddVWYcMl3mDM7g0dYI9enQMAAAVSCmmYC0RFHINhiieYTc6zp4VWMFmxhI9u4GhqGN0d4bcn2O@lists.infradead.org X-Gm-Message-State: AOJu0YxgKV1nQFAAUlELUZtTGJEq78EnxTk6+FnKuBObeeINli9NzH4/ 0RpBdWdDbNvuVI4+OlKyyUZmvTJDDbVrcK8pEWugWtNiP6m/1cge X-Gm-Gg: ASbGnctCl8vJ6LGr/x+j8J2JYqjpI0ok4A5IYfllnrLvdTl6QwsmoBa/aPpPj1QJmty XEa16LKtmDR7u2lymOUyjhHAwRjuyVo3F+EQ1wpOW88l+x/T6wtYBI5fm3D0SPRReYQ9oeIZoVN 3/1+yipMJKtpSl0LcyrCbxNTF7md1ZWcLoPrm6OirdxB22kLu05OOjYzfsy50V5ALyLzqqdB2Ic xGZwZ3mm7Wuj7gWhFzzix0Ah4QMzPZffsdqzgQiqf/HkJ+KyHo1wuJ9zfQm9Fys/dw0lM07BadW pRSiCFJpg7KQjO1U X-Google-Smtp-Source: AGHT+IH1MtQsv7n9+03TmRQLhZL0KNOrrS14baU7/DtFKLh1qhS09XchSBq/EFGuV307S9+ypU09rw== X-Received: by 2002:a05:6a20:cd93:b0:1e1:afa9:d38a with SMTP id adf61e73a8af0-1ed7a48c85cmr32676039637.1.1738583549287; Mon, 03 Feb 2025 03:52:29 -0800 (PST) Received: from nick-mbp.. ([59.188.211.160]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-72fe631c039sm8262408b3a.25.2025.02.03.03.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 03:52:28 -0800 (PST) From: Nick Chan To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v5 RESEND 1/3] dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight Date: Mon, 3 Feb 2025 19:50:32 +0800 Message-ID: <20250203115156.28174-2-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203115156.28174-1-towinchenmi@gmail.com> References: <20250203115156.28174-1-towinchenmi@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250203_035230_298291_79D935CD X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add backlight controllers attached via Apple DWI 2-wire interface. Reviewed-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson (RISCstar) Signed-off-by: Nick Chan --- .../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml diff --git a/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml new file mode 100644 index 000000000000..29caeb356e6f --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/apple,dwi-bl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple DWI 2-Wire Interface Backlight Controller + +maintainers: + - Nick Chan + +description: + Apple SoCs contain a 2-wire interface called DWI. On some Apple iPhones, + iPads and iPod touches with a LCD display, 1-2 backlight controllers + are connected via DWI. Interfacing with DWI controls all backlight + controllers at the same time. As such, the backlight controllers are + treated as a single controller regardless of the underlying + configuration. + +allOf: + - $ref: common.yaml# + +properties: + compatible: + items: + - enum: + - apple,s5l8960x-dwi-bl + - apple,t7000-dwi-bl + - apple,s8000-dwi-bl + - apple,t8010-dwi-bl + - apple,t8015-dwi-bl + - const: apple,dwi-bl + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + dwi_bl: backlight@20e200010 { + compatible = "apple,s5l8960x-dwi-bl", "apple,dwi-bl"; + reg = <0x2 0x0e200010 0x0 0x8>; + power-domains = <&ps_dwi>; + }; + }; From patchwork Mon Feb 3 11:50:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13957342 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5CDEC02193 for ; Mon, 3 Feb 2025 11:56:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NuVUwIb3ATElWRb+tDZLU6hMx05qo8CzOAa+DShnxhY=; b=I6j82w2gNH/RnnB9Vy5mKY3c1L Zp7qVNcom6tAg6YKazGc0LTxZvrYdnXQpy2sCDt+E5QLnavpRj1kLCnuHZ1wJDIStf13xdqw5x8JT W/0SZCQHKd37pGVXe1JmFK325PR1/CvMnAdFIOF10C+ePnV05E/KwfqUrhogxjIutyys6+fSXO3d4 VZTRjGDlzfG2W/YboK/cJ9p2YiJBnLFnCppEDqNkhq6oYmsgb7lBgJcXuxvfDlcxzNUBveoN9pjxZ Nfn317cZS4hB7gmkWTDtwgKzhqI8ZAeZxN8Dd2LXpYO492MkYEzf9KeUy65pf8GDkxn0iFBtfM9JC UXCTjxHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tev42-0000000FINh-0rHq; Mon, 03 Feb 2025 11:56:30 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tev0E-0000000FHjL-1Gd1 for linux-arm-kernel@lists.infradead.org; Mon, 03 Feb 2025 11:52:35 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-216281bc30fso3705925ad.0 for ; Mon, 03 Feb 2025 03:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738583553; x=1739188353; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NuVUwIb3ATElWRb+tDZLU6hMx05qo8CzOAa+DShnxhY=; b=Ifg64Tmfx0wCwBsBjPIm5au8vN5daq4kPdp6c+hl5eZccZUYL2/p5Cq77Lg/tU/9PI 0ZYksi4O2++37fR2uRmfMSCU3rJyhBWTv4v99I/BFvDTND/RdMumDc9mLYJ1XdmG5PfU AyN1cnFZ3X+PWkzUx56UVO19Zpb/dRSBndV44bNGCZObi3Wdrp7nvyeO7K7BL0v5t6ZA GvZXap0NaR5rIIaAF+mYVBQcfthmnB9cbjjzNM/V79OvQSg1/jE8w89imH2HS9WjxjJW vgS2AGx305mFxG8lg8o073oyq9aQ17Xn/ggM4uxSVG0UrzS5O6w4Dy8GoEjVYIbyhHgq xtWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738583553; x=1739188353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NuVUwIb3ATElWRb+tDZLU6hMx05qo8CzOAa+DShnxhY=; b=O03TZenAZSq9taINLKHQcxnEdKUn40OxH3db/tQBfxvKn2+3q6bzKz2SbMfwlAEVrx KtkJSdFdfZRWvmrer0oLZVZGoXeFNLYA9KIDA4QAkm6bscSoy2mJr0hcAnapfCNOWSB7 eaJUwK0RtLOYUPo/5/LheiAc3L4Yj1n/McnpmWsEzOuCNMxIHL2HtClGqvwvSEcMirMG ypOdgsc0IUBZST01OSiQWVHIhOyDrn95AODp+Ym9AXe0599W6Y86V0ym3YGvwq0iiJRM HUgnssblVC+oxxGA9zDEqq4jWZmtychTwPOHE4KfwMs4R7YXqDn9kJvJKN0MdQG/XVQB /VzA== X-Forwarded-Encrypted: i=1; AJvYcCXeoQF8kj6MmaZ9HTSbgFXC09bLY6a8sxMJilEbXxsApwflHTJaUCL6QY/7oKQuZJXT05/yGn6Rj58YuiUwh9Jj@lists.infradead.org X-Gm-Message-State: AOJu0YxTG5Jg7TZN4OM4r9mNqZRqVyBUY6QO/QbkHBHqMn1c2UcLdwWF sbVgOm/uAWYyEkiU9D3WEePEVp1Amlub5Qm7X7FsMR6vRswikgS7DqDdHiZ5 X-Gm-Gg: ASbGncvWMxjFgrhuWK7KFO2i8TCAquCtzAaGFd7tAFnn2znD+J8BObn4p7LU4Uy2zam uAn2oNdvjUvrRlVouj4u+mbwSzRXxM51M77RZXfrSf6qt4uSYQuiyqnId9OpN0GrDoNaadPlb+a rXpE4Q+uw6B3IICxF1DDJflIMujEcsywbyy6wm2+bkHZJ6Z8syMFyPrS6xOqJBs8k2Srr7dZT/f fV1H+f9X7yET5Bf0S6v/0H3Kzhk4e9oaIVCEyU5UEX/laEPJXsmyxW5nvzN1qL1owbPnHkMhSis 4aFLkTe7qWV1OnIS X-Google-Smtp-Source: AGHT+IHAUg+jBA6FADxyc/xDCHiXuFU49eYPAhY7dRRNEYaiurAK+cyssoskPZL1rJkF+Q3jR0YDHw== X-Received: by 2002:a05:6a00:2e14:b0:71e:4cff:2654 with SMTP id d2e1a72fcca58-72fd0bf7126mr31273767b3a.6.1738583553324; Mon, 03 Feb 2025 03:52:33 -0800 (PST) Received: from nick-mbp.. ([59.188.211.160]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-72fe631c039sm8262408b3a.25.2025.02.03.03.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 03:52:32 -0800 (PST) From: Nick Chan To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v5 RESEND 2/3] backlight: apple_dwi_bl: Add Apple DWI backlight driver Date: Mon, 3 Feb 2025 19:50:33 +0800 Message-ID: <20250203115156.28174-3-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203115156.28174-1-towinchenmi@gmail.com> References: <20250203115156.28174-1-towinchenmi@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250203_035234_340182_6F6E1182 X-CRM114-Status: GOOD ( 24.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add driver for backlight controllers attached via Apple DWI 2-wire interface, which is found on some Apple iPhones, iPads and iPod touches with a LCD display. Although there is an existing apple_bl driver, it is for backlight controllers on Intel Macs attached via PCI, which is completely different from the Samsung-derived DWI block. Signed-off-by: Nick Chan --- drivers/video/backlight/Kconfig | 12 +++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/apple_dwi_bl.c | 123 +++++++++++++++++++++++++ 3 files changed, 136 insertions(+) create mode 100644 drivers/video/backlight/apple_dwi_bl.c diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 3614a5d29c71..c6168727900a 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -290,6 +290,18 @@ config BACKLIGHT_APPLE If you have an Intel-based Apple say Y to enable a driver for its backlight. +config BACKLIGHT_APPLE_DWI + tristate "Apple DWI 2-Wire Interface Backlight Driver" + depends on ARCH_APPLE || COMPILE_TEST + default y + help + Say Y to enable the backlight driver for backlight controllers + attached via the Apple DWI 2-wire interface which is found in some + Apple iPhones, iPads and iPod touches. + + To compile this driver as a module, choose M here: the module will + be called apple_dwi_bl. + config BACKLIGHT_QCOM_WLED tristate "Qualcomm PMIC WLED Driver" select REGMAP diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile index 8fc98f760a8a..156ff9461fb3 100644 --- a/drivers/video/backlight/Makefile +++ b/drivers/video/backlight/Makefile @@ -23,6 +23,7 @@ obj-$(CONFIG_BACKLIGHT_ADP5520) += adp5520_bl.o obj-$(CONFIG_BACKLIGHT_ADP8860) += adp8860_bl.o obj-$(CONFIG_BACKLIGHT_ADP8870) += adp8870_bl.o obj-$(CONFIG_BACKLIGHT_APPLE) += apple_bl.o +obj-$(CONFIG_BACKLIGHT_APPLE_DWI) += apple_dwi_bl.o obj-$(CONFIG_BACKLIGHT_AS3711) += as3711_bl.o obj-$(CONFIG_BACKLIGHT_BD6107) += bd6107.o obj-$(CONFIG_BACKLIGHT_CLASS_DEVICE) += backlight.o diff --git a/drivers/video/backlight/apple_dwi_bl.c b/drivers/video/backlight/apple_dwi_bl.c new file mode 100644 index 000000000000..93bd744972d6 --- /dev/null +++ b/drivers/video/backlight/apple_dwi_bl.c @@ -0,0 +1,123 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT +/* + * Driver for backlight controllers attached via Apple DWI 2-wire interface + * + * Copyright (c) 2024 Nick Chan + */ + +#include +#include +#include +#include +#include +#include + +#define DWI_BL_CTL 0x0 +#define DWI_BL_CTL_SEND1 BIT(0) +#define DWI_BL_CTL_SEND2 BIT(4) +#define DWI_BL_CTL_SEND3 BIT(5) +#define DWI_BL_CTL_LE_DATA BIT(6) +/* Only used on Apple A9 and later */ +#define DWI_BL_CTL_SEND4 BIT(12) + +#define DWI_BL_CMD 0x4 +#define DWI_BL_CMD_TYPE GENMASK(31, 28) +#define DWI_BL_CMD_TYPE_SET_BRIGHTNESS 0xa +#define DWI_BL_CMD_DATA GENMASK(10, 0) + +#define DWI_BL_CTL_SEND (DWI_BL_CTL_SEND1 | \ + DWI_BL_CTL_SEND2 | \ + DWI_BL_CTL_SEND3 | \ + DWI_BL_CTL_LE_DATA | \ + DWI_BL_CTL_SEND4) + +#define DWI_BL_MAX_BRIGHTNESS 2047 + +struct apple_dwi_bl { + void __iomem *base; +}; + +static int dwi_bl_update_status(struct backlight_device *bl) +{ + struct apple_dwi_bl *dwi_bl = bl_get_data(bl); + + int brightness = backlight_get_brightness(bl); + + u32 cmd = 0; + + cmd |= FIELD_PREP(DWI_BL_CMD_DATA, brightness); + cmd |= FIELD_PREP(DWI_BL_CMD_TYPE, DWI_BL_CMD_TYPE_SET_BRIGHTNESS); + + writel(cmd, dwi_bl->base + DWI_BL_CMD); + writel(DWI_BL_CTL_SEND, dwi_bl->base + DWI_BL_CTL); + + return 0; +} + +static int dwi_bl_get_brightness(struct backlight_device *bl) +{ + struct apple_dwi_bl *dwi_bl = bl_get_data(bl); + + u32 cmd = readl(dwi_bl->base + DWI_BL_CMD); + + return FIELD_GET(DWI_BL_CMD_DATA, cmd); +} + +static const struct backlight_ops dwi_bl_ops = { + .options = BL_CORE_SUSPENDRESUME, + .get_brightness = dwi_bl_get_brightness, + .update_status = dwi_bl_update_status +}; + +static int dwi_bl_probe(struct platform_device *dev) +{ + struct apple_dwi_bl *dwi_bl; + struct backlight_device *bl; + struct backlight_properties props; + struct resource *res; + + dwi_bl = devm_kzalloc(&dev->dev, sizeof(*dwi_bl), GFP_KERNEL); + if (!dwi_bl) + return -ENOMEM; + + dwi_bl->base = devm_platform_get_and_ioremap_resource(dev, 0, &res); + if (IS_ERR(dwi_bl->base)) + return PTR_ERR(dwi_bl->base); + + memset(&props, 0, sizeof(struct backlight_properties)); + props.type = BACKLIGHT_PLATFORM; + props.max_brightness = DWI_BL_MAX_BRIGHTNESS; + props.scale = BACKLIGHT_SCALE_LINEAR; + + bl = devm_backlight_device_register(&dev->dev, dev->name, &dev->dev, + dwi_bl, &dwi_bl_ops, &props); + if (IS_ERR(bl)) + return PTR_ERR(bl); + + platform_set_drvdata(dev, dwi_bl); + + bl->props.brightness = dwi_bl_get_brightness(bl); + + return 0; +} + +static const struct of_device_id dwi_bl_of_match[] = { + { .compatible = "apple,dwi-bl" }, + {}, +}; + +MODULE_DEVICE_TABLE(of, dwi_bl_of_match); + +static struct platform_driver dwi_bl_driver = { + .driver = { + .name = "apple-dwi-bl", + .of_match_table = dwi_bl_of_match + }, + .probe = dwi_bl_probe, +}; + +module_platform_driver(dwi_bl_driver); + +MODULE_DESCRIPTION("Apple DWI Backlight Driver"); +MODULE_AUTHOR("Nick Chan "); +MODULE_LICENSE("Dual MIT/GPL"); From patchwork Mon Feb 3 11:50:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13957343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8662BC02192 for ; Mon, 3 Feb 2025 11:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Uc4uCqsleGcCsKVC2kCtafnEyIcpxj+3QblkARK4r2c=; b=HKKj+MxXZq3LAvd8Met+Phk6Fi eq3ZNo87FhqPaS4Ow2wfFUkgkCdeOKpm8DarwBRh7TVlFs1waoBBYWdsV68cA1mPwdIDCjFlar455 ow83g08A1RRBOV3WeRTpiOvRyq22Vu1XqFi9hWsHexfneONxO55FsyHhqjPrGC7Fm/ouyTpproeeP WEgx2+AJIGpbQ9Vd99j8oHUbauDArnfTt8hv0iKLy50rKOqGObI7NXhCE0MDdrq1eeNYV88+6dryW 3cxv0ZPpraPhi6C1fjdjRCwuPMVrUX7IV6E5VtChCuVr1eFFXl+XEHQOlfBIlyzi1R4+HRGlV8qrX QQ7HzbXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tev5K-0000000FId1-3Xqy; Mon, 03 Feb 2025 11:57:50 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tev0I-0000000FHlG-1LoU for linux-arm-kernel@lists.infradead.org; Mon, 03 Feb 2025 11:52:39 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2161eb94cceso49914825ad.2 for ; Mon, 03 Feb 2025 03:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738583557; x=1739188357; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Uc4uCqsleGcCsKVC2kCtafnEyIcpxj+3QblkARK4r2c=; b=QvQOeu9ORRwUI4derwKZFTO+1bawyoH//2U7PlzKP0zcvI7kJsKVYpM7Rdwyz8ec1h YnRtChXSwZRvj+gUhFG8o7uVtsbkULKQWWHHswiSikfch8/BY3jEyr9OHJE8gu492Izj mkBTwC1wzHpkTv6cilrMwGY4aarOE/NCo7ulzhr39z5Fp95NM0l19mVZC4qQPgjRvGqr /We57DduKyq1zqWL/4ECsLLsVNLRfvRX9vb+CHRepzh5UUt3KL3egW9o9ETmJZvTS8Sc zVwfwODqkODavNer/sbHH3+0EifrU1e09mMhQicySx2FRJe8QWVRCBjZo0XMKIp52ipP wt0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738583557; x=1739188357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uc4uCqsleGcCsKVC2kCtafnEyIcpxj+3QblkARK4r2c=; b=L+aBM69Y4YdUD0d9VOXb6/lC2NdzSA/aa0QDnEn7paXyW1zottQbypJ8DEHqGjpAIR IqeeS+cUWQ4UoAX0TVserOFvy6nwTVRhVIA/PqMVNqdgt6JwvWCHzzA57yZMM07yz4Iy d3eTGoeJ8x+k9G0Le3ov8e4zA4LHwMI4BvqfcadbT3q2v6LX3uaY0KRxZtJzPDTseucV x1wqCO5coIQAcV8ZNzMfzTSGeYQkb26df2fusVE8iSvFtlVOD7wscFn3ooRTKOUXxTtF AJVu0VcxmCi+fm0uPbBPH2DzxoynV2nNFNDfHItsGurDdYQaWPP0S/IxSjuRfgeRHBU3 VXsg== X-Forwarded-Encrypted: i=1; AJvYcCWp3DAfids4J79OyoxKpjE6vjrluW9IWssVW5LbpwSI/eb8Am5l8SaEoIebrRw5iViZvO89lLmW/HwkUCMYURFI@lists.infradead.org X-Gm-Message-State: AOJu0YzJ+UnqkATBmvFlLjp1ylNyahAQ8e5jPGm1wD9ho3nd9W90rJhX iX/0CZEAWHLXXg++q4kyW6TS9gJlygg7jMH0+oGabNlqpIdDmGjX X-Gm-Gg: ASbGnctmhjZRhWqeOWxyi8YXgeMi31UGs/G9PJHJ79Jv9LmE9ZX4aTkVb4/uB8+x6+w r58UMK8zH1UOJUK8P56AUQ/euwbVKWKSlQMeh1vKBYTHPe7bDVnDJ6smF74QKHVfBiDOMCM287N neIZCzPixtlT0Pm/9s++hRzYb3vFwQgXaKz9oRFZuohnIu2KLgbhLxDEz8RNiFh0i3OrdQSmgja L4OP2+y3Y7bcmBGTYoJDjWzJVoHbrMgFr9tLqexZ4ZRfeS3ytz5Tnj4Be1/6EwU+PkRM/emG9/G T02h2RfLVdCBqxxl X-Google-Smtp-Source: AGHT+IG9OzjbgkvCS8tq7nwliRQ7D0GE7eIK1YFb7OgjbU/H0UhSsEr4jVXSBegVQdOpNlym0wtPBw== X-Received: by 2002:a05:6a00:4642:b0:725:f1b1:cbc5 with SMTP id d2e1a72fcca58-72fd0bc26c1mr38178820b3a.3.1738583557299; Mon, 03 Feb 2025 03:52:37 -0800 (PST) Received: from nick-mbp.. ([59.188.211.160]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-72fe631c039sm8262408b3a.25.2025.02.03.03.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 03:52:36 -0800 (PST) From: Nick Chan To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v5 RESEND 3/3] MAINTAINERS: Add entries for Apple DWI backlight controller Date: Mon, 3 Feb 2025 19:50:34 +0800 Message-ID: <20250203115156.28174-4-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203115156.28174-1-towinchenmi@gmail.com> References: <20250203115156.28174-1-towinchenmi@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250203_035238_357395_0BD657D2 X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add MAINTAINERS entries for the driver. Reviewed-by: Daniel Thompson (RISCstar) Signed-off-by: Nick Chan --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 896a307fa065..a576324807f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2228,6 +2228,7 @@ F: Documentation/devicetree/bindings/i2c/apple,i2c.yaml F: Documentation/devicetree/bindings/interrupt-controller/apple,* F: Documentation/devicetree/bindings/iommu/apple,dart.yaml F: Documentation/devicetree/bindings/iommu/apple,sart.yaml +F: Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml F: Documentation/devicetree/bindings/net/bluetooth/brcm,bcm4377-bluetooth.yaml F: Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml @@ -2253,6 +2254,7 @@ F: drivers/nvmem/apple-efuses.c F: drivers/pinctrl/pinctrl-apple-gpio.c F: drivers/pwm/pwm-apple.c F: drivers/soc/apple/* +F: drivers/video/backlight/apple_dwi_bl.c F: drivers/watchdog/apple_wdt.c F: include/dt-bindings/interrupt-controller/apple-aic.h F: include/dt-bindings/pinctrl/apple.h